Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Tue, Sep 26, 2017 at 08:05:37AM -0700, Joe Perches wrote: > On Tue, 2017-09-26 at 11:38 +0300, Leon Romanovsky wrote: > > On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > > > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > > >

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Tue, Sep 26, 2017 at 08:05:37AM -0700, Joe Perches wrote: > On Tue, 2017-09-26 at 11:38 +0300, Leon Romanovsky wrote: > > On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > > > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > > >

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : >Add same changes for 'ocrdma_hw.c' > Two

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : >Add same changes for 'ocrdma_hw.c' > Two notes, 1. Please send

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > avoid other messages being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/infiniband/hw/mlx5/mr.c | 4 ++-- > 1 file

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > avoid other messages being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/infiniband/hw/mlx5/mr.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > This patch set presents some bug fixes for the HNS3 Ethernet driver, > identified > during internal testing & stabilization efforts. > > This patch series is meant for Linux 4.14 kernel. > > Lipeng (6): > net: hns3: get phy addr

Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > This patch set presents some bug fixes for the HNS3 Ethernet driver, > identified > during internal testing & stabilization efforts. > > This patch series is meant for Linux 4.14 kernel. > > Lipeng (6): > net: hns3: get phy addr

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

>delay_drop.dbg = dbg; > + > dbg->dir_debugfs = > debugfs_create_dir("delay_drop", > dev->mdev->priv.dbg_root); > if (!dbg->dir_debugfs) > - return -ENOMEM; > + goto out_debugfs; > Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

debugfs_create_dir("delay_drop", > dev->mdev->priv.dbg_root); > if (!dbg->dir_debugfs) > - return -ENOMEM; > + goto out_debugfs; > Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH] IB/mlx5: fix debugfs cleanup

On Sun, Sep 17, 2017 at 01:28:08PM +0100, Sudip Mukherjee wrote: > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and since > we have not yet

Re: [PATCH] IB/mlx5: fix debugfs cleanup

On Sun, Sep 17, 2017 at 01:28:08PM +0100, Sudip Mukherjee wrote: > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and since > we have not yet

Re: [PATCH for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

t; https://www.spinics.net/lists/linux-rdma/msg54392.html > https://www.spinics.net/lists/linux-rdma/msg54400.html > --- > drivers/infiniband/hw/hns/hns_roce_device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

/linux-rdma/msg54400.html > --- > drivers/infiniband/hw/hns/hns_roce_device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: > calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on > older compiler version such as gcc-4.6 results in a warning that > the return code is not initialized: > > drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c:147:6:

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: > calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on > older compiler version such as gcc-4.6 results in a warning that > the return code is not initialized: > > drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c:147:6:

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

ile changed, 3 insertions(+) > Except the wrong title: IB/core -> IB/ocrdma Reviewed-by: Leon Romanovsky <leo...@mellanox.com> Thanks signature.asc Description: PGP signature

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

uot;) > > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA > adapter") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++ > 1 file changed, 3 insertions(+) > Except the wrong title: IB/core -

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Sat, Sep 09, 2017 at 03:56:07PM +0300, Leon Romanovsky wrote: > On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > > From: Colin Ian King <colin.k...@canonical.com> > > > > The allocation for elem may fail (especially because we're using > > GFP_AT

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Sat, Sep 09, 2017 at 03:56:07PM +0300, Leon Romanovsky wrote: > On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The allocation for elem may fail (especially because we're using > > GFP_ATOMIC) so best to check for

Re: [PATCH 2/2] IB/uverbs: clean up INIT_UDATA() macro usage

On Wed, Sep 06, 2017 at 11:34:26PM +0200, Arnd Bergmann wrote: > After changing INIT_UDATA_BUF_OR_NULL() to an inline function, > this does the same change to INIT_UDATA for consistency. > I'm keeping it separate as this part is much larger and > we wouldn't want to backport this to stable kernels

Re: [PATCH 2/2] IB/uverbs: clean up INIT_UDATA() macro usage

On Wed, Sep 06, 2017 at 11:34:26PM +0200, Arnd Bergmann wrote: > After changing INIT_UDATA_BUF_OR_NULL() to an inline function, > this does the same change to INIT_UDATA for consistency. > I'm keeping it separate as this part is much larger and > we wouldn't want to backport this to stable kernels

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > From: Colin Ian King > > The allocation for elem may fail (especially because we're using > GFP_ATOMIC) so best to check for a null return. This fixes a potential > null pointer dereference when assigning

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > From: Colin Ian King > > The allocation for elem may fail (especially because we're using > GFP_ATOMIC) so best to check for a null return. This fixes a potential > null pointer dereference when assigning elem->pool. > > Detected by

Re: [PATCH][V2] RDMA/nes: do not leak uninitialized resp.reserved to userspace Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

which is a potential information leak. Fix this by > initializing all of resp to zero. > > V2: Initialize all of the struct rather than just resp.reserved as > suggested by Leon Romanovsky. Small nitpick, it is better to put changelog under "---" marker, so it won't be visibl

Re: [PATCH][V2] RDMA/nes: do not leak uninitialized resp.reserved to userspace Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

ation leak. Fix this by > initializing all of resp to zero. > > V2: Initialize all of the struct rather than just resp.reserved as > suggested by Leon Romanovsky. Small nitpick, it is better to put changelog under "---" marker, so it won't be visible in the git log. Thanks Reviewed

Re: [PATCH] RDMA/nes: do not leak uninitialized resp.reserved to userspace

On Mon, Sep 04, 2017 at 12:23:16PM +0100, Colin King wrote: > From: Colin Ian King > > resp.reserved has not been initialized and so the copy_to_user (via > ib_copy_to_udata) is copying uninitialized data from the stack back > to user space which is a potential

Re: [PATCH] RDMA/nes: do not leak uninitialized resp.reserved to userspace

On Mon, Sep 04, 2017 at 12:23:16PM +0100, Colin King wrote: > From: Colin Ian King > > resp.reserved has not been initialized and so the copy_to_user (via > ib_copy_to_udata) is copying uninitialized data from the stack back > to user space which is a potential information leak. Fix this by >

Re: [PATCH][next] IB/core: fix spelling mistake: "aceess" -> "access"

bs_ioctl_merge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH][next] IB/core: fix spelling mistake: "aceess" -> "access"

1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 05/13] IB/umem: update to new mmu_notifier semantic

e_page callback. > > Signed-off-by: Jérôme Glisse <jgli...@redhat.com> > Cc: Leon Romanovsky <leo...@mellanox.com> > Cc: linux-r...@vger.kernel.org > Cc: Artemy Kovalyov <artem...@mellanox.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Kirill A. Sh

Re: [PATCH 05/13] IB/umem: update to new mmu_notifier semantic

e_page callback. > > Signed-off-by: Jérôme Glisse > Cc: Leon Romanovsky > Cc: linux-r...@vger.kernel.org > Cc: Artemy Kovalyov > Cc: Doug Ledford > Cc: Kirill A. Shutemov > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Andrea Arcangeli > --- > drivers/infin

Re: [PATCH] RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid"

/hw/qedr/verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid"

n(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Wed, Aug 23, 2017 at 07:10:38PM +, Long Li wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, August 23, 2017 12:02 PM > > To: Long Li <lon...@microsoft.com> > > Cc: Steve French <s

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Wed, Aug 23, 2017 at 07:10:38PM +, Long Li wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, August 23, 2017 12:02 PM > > To: Long Li > > Cc: Steve French ; linux-c...@vger.kernel.org;

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Wed, Aug 23, 2017 at 06:09:11PM +, Long Li wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, August 23, 2017 6:52 AM > > To: Long Li <lon...@microsoft.com> > > Cc: Steve French <s

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Wed, Aug 23, 2017 at 06:09:11PM +, Long Li wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, August 23, 2017 6:52 AM > > To: Long Li > > Cc: Steve French ; linux-c...@vger.kernel.org;

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Sun, Aug 20, 2017 at 12:04:37PM -0700, Long Li wrote: > From: Long Li > > When sending I/O, if size is larger than rdma_readwrite_threshold we prepare > to send SMB WRITE packet for a RDMA read via memory registration. The actual > I/O is done out-of-the-band, so modify

Re: [Patch v2 13/19] CIFS: SMBD: Use registered memory RDMA read for SMB write

On Sun, Aug 20, 2017 at 12:04:37PM -0700, Long Li wrote: > From: Long Li > > When sending I/O, if size is larger than rdma_readwrite_threshold we prepare > to send SMB WRITE packet for a RDMA read via memory registration. The actual > I/O is done out-of-the-band, so modify the relevant fields

Re: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

t; > Signed-off-by: lipeng <lipeng...@huawei.com> > Signed-off-by: Salil Mehta <salil.me...@huawei.com> > --- > PATCH V4: Addressed some minor comments Leon Romanovsky > 1. https://lkml.org/lkml/2017/8/21/212 > PATCH V3: Addressed some minor comments Leon Romanovsky &

Re: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

t; > Signed-off-by: lipeng > Signed-off-by: Salil Mehta > --- > PATCH V4: Addressed some minor comments Leon Romanovsky > 1. https://lkml.org/lkml/2017/8/21/212 > PATCH V3: Addressed some minor comments Leon Romanovsky > 1. https://lkml.org/lkml/2017/8/20/27

Re: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Mon, Aug 21, 2017 at 02:32:40PM +, Salil Mehta wrote: > Hi Andrew, > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Monday, August 21, 2017 3:30 PM > > To: Salil Mehta > > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > >

Re: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Mon, Aug 21, 2017 at 02:32:40PM +, Salil Mehta wrote: > Hi Andrew, > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Monday, August 21, 2017 3:30 PM > > To: Salil Mehta > > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > >

Re: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

t; > Signed-off-by: lipeng <lipeng...@huawei.com> > Signed-off-by: Salil Mehta <salil.me...@huawei.com> > --- > PATCH V3: Addressed some minor comments Leon Romanovsky > 1. https://lkml.org/lkml/2017/8/20/27 > PATCH V2: Addresses comments given by Andrew Lunn >

Re: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

t; > Signed-off-by: lipeng > Signed-off-by: Salil Mehta > --- > PATCH V3: Addressed some minor comments Leon Romanovsky > 1. https://lkml.org/lkml/2017/8/20/27 > PATCH V2: Addresses comments given by Andrew Lunn > 1. https://lkml.org/lkml/2017/8/18/282 > PA

Re: [Patch v2 01/19] CIFS: Add RDMA mount option

On Sun, Aug 20, 2017 at 12:04:25PM -0700, Long Li wrote: > From: Long Li > > Add "rdma" to CIFS mount option, which tells CIFS this is for connecting to a > SMB server over SMBDirect. Add checks to validate this feature is only used > on SMB 3.X dialects. > > To connect to

Re: [Patch v2 01/19] CIFS: Add RDMA mount option

On Sun, Aug 20, 2017 at 12:04:25PM -0700, Long Li wrote: > From: Long Li > > Add "rdma" to CIFS mount option, which tells CIFS this is for connecting to a > SMB server over SMBDirect. Add checks to validate this feature is only used > on SMB 3.X dialects. > > To connect to SMBDirect, use

Re: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Sun, Aug 20, 2017 at 02:35:58PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Sunday, August 20, 2017 8:05 AM > > To: Salil Mehta > > Cc: da...@davemloft.net; Zhuangyuzeng

Re: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Sun, Aug 20, 2017 at 02:35:58PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Sunday, August 20, 2017 8:05 AM > > To: Salil Mehta > > Cc: da...@davemloft.net; Zhuangyuzeng

Re: Possible race in mlx5_ib.ko

On Fri, Aug 18, 2017 at 06:17:15PM +0300, Anton Volkov wrote: > Hello. > > While searching for races in the Linux kernel I've come across > "drivers/infiniband/hw/mlx5/mlx5_ib.ko" module. Here are questions that I > came up with while analyzing results. Lines are given using the info from > Linux

Re: Possible race in mlx5_ib.ko

On Fri, Aug 18, 2017 at 06:17:15PM +0300, Anton Volkov wrote: > Hello. > > While searching for races in the Linux kernel I've come across > "drivers/infiniband/hw/mlx5/mlx5_ib.ko" module. Here are questions that I > came up with while analyzing results. Lines are given using the info from > Linux

Re: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Fri, Aug 18, 2017 at 05:57:59PM +0100, Salil Mehta wrote: > This patch adds the following support to the HNS3 driver: > 1. Support to change the Maximum Transmission Unit of a >of a port in the HNS NIC hardware . Extra space before dot. > 2. Initializes the supported MTU range for the

Re: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

On Fri, Aug 18, 2017 at 05:57:59PM +0100, Salil Mehta wrote: > This patch adds the following support to the HNS3 driver: > 1. Support to change the Maximum Transmission Unit of a >of a port in the HNS NIC hardware . Extra space before dot. > 2. Initializes the supported MTU range for the

Re: [PATCH] mlx5: ensure 0 is returned when vport is zero

> esw_debug(esw->dev, "\tADDED UC MAC: vport[%d] %pM fr(%p)\n", > vport, mac, vaddr->flow_rule); > > - return err; > + return 0; > } > I personally prefer initialization of "err" to zero, but this solution is fine enough too. Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] mlx5: ensure 0 is returned when vport is zero

fr(%p)\n", > vport, mac, vaddr->flow_rule); > > - return err; > + return 0; > } > I personally prefer initialization of "err" to zero, but this solution is fine enough too. Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "availible" -> "available"

On Wed, Aug 16, 2017 at 03:02:31PM +0100, Colin Ian King wrote: > On 16/08/17 14:58, Leon Romanovsky wrote: > > On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote: > >> From: Colin Ian King <colin.k...@canonical.com> > >> > >> Trivial f

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "availible" -> "available"

On Wed, Aug 16, 2017 at 03:02:31PM +0100, Colin Ian King wrote: > On 16/08/17 14:58, Leon Romanovsky wrote: > > On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Trivial fix to spelling mistakes in the mlx4 driver

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "availible" -> "available"

On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in the mlx4 driver. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/mellanox/mlx4/cmd.c| 16

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "availible" -> "available"

On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in the mlx4 driver. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/mellanox/mlx4/cmd.c| 16 > drivers/net/ethernet/mellanox/mlx4/fw_qos.c

Re: [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity

On Wed, Aug 16, 2017 at 10:29:40AM +0100, Colin King wrote: > From: Colin Ian King > > The function mlx5_ib_get_vector_affinity is local to the source > and does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol

Re: [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity

On Wed, Aug 16, 2017 at 10:29:40AM +0100, Colin King wrote: > From: Colin Ian King > > The function mlx5_ib_get_vector_affinity is local to the source > and does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'mlx5_ib_get_vector_affinity' was not

Re: [PATCH] net/mlx4: fix spelling mistake: "availible" -> "available"

ernet/mellanox/mlx4/cmd.c| 16 > drivers/net/ethernet/mellanox/mlx4/fw_qos.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw_qos.h | 10 +- > 3 files changed, 16 insertions(+), 16 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] net/mlx4: fix spelling mistake: "availible" -> "available"

t/mellanox/mlx4/fw_qos.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw_qos.h | 10 +- > 3 files changed, 16 insertions(+), 16 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > Debugfs file reset_stats is created with S_IRUSR permissions, > but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, > whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. > > The patch fixes misstype with

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > Debugfs file reset_stats is created with S_IRUSR permissions, > but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, > whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. > > The patch fixes misstype with

Re: [PATCH] IB/core: fix duplicated code for different branches

On Sat, Aug 12, 2017 at 07:52:35PM -0500, Gustavo A. R. Silva wrote: > Refactor code to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/core/cm.c | 4

Re: [PATCH] IB/core: fix duplicated code for different branches

On Sat, Aug 12, 2017 at 07:52:35PM -0500, Gustavo A. R. Silva wrote: > Refactor code to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/core/cm.c | 4 > 1 file changed, 4

Re: [v2 01/12] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Tue, Aug 08, 2017 at 07:26:45PM +0200, SF Markus Elfring wrote: > Hello, > > How will the clarification be continued for the shown change possibilities? Every sub-maintainer will decide on his own what and how to proceed with these patches. Thanks > > Regards, > Markus signature.asc

Re: [v2 01/12] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Tue, Aug 08, 2017 at 07:26:45PM +0200, SF Markus Elfring wrote: > Hello, > > How will the clarification be continued for the shown change possibilities? Every sub-maintainer will decide on his own what and how to proceed with these patches. Thanks > > Regards, > Markus signature.asc

Re: [PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework

igned-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> > --- > Patch V5: Addressed following comments > 1. Leon Romanovsky: > https://lkml.org/lkml/2017/7/23/67 > Patch V4: Addressed following comments > 1. Andrew Lunn: > https://lkml.org/lkml/2017/6/17/233 > http

Re: [PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework

t drivers (like ODP etc.) to register with HNAE3 > devices and their associated operations. > > Signed-off-by: Daode Huang > Signed-off-by: lipeng > Signed-off-by: Salil Mehta > Signed-off-by: Yisen Zhuang > --- > Patch V5: Addressed following comments > 1. Leon Roman

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM

Re: [PATCH] drivers/rxe: improve rxe loopback

On Thu, Jul 27, 2017 at 12:49:17PM +0300, Marcel Apfelbaum wrote: > On 27/07/2017 10:36, Leon Romanovsky wrote: > > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > > > Currently a packet is marked for loopback only if the source and > > >

Re: [PATCH] drivers/rxe: improve rxe loopback

On Thu, Jul 27, 2017 at 12:49:17PM +0300, Marcel Apfelbaum wrote: > On 27/07/2017 10:36, Leon Romanovsky wrote: > > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > > > Currently a packet is marked for loopback only if the source and > > >

Re: [PATCH] drivers/rxe: improve rxe loopback

On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Sat, Jul 22, 2017 at 11:09:36PM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Sat, Jul 22, 2017 at 11:09:36PM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

Re: [PATCH V4 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS

On Sat, Jul 22, 2017 at 11:09:42PM +0100, Salil Mehta wrote: > This patch updates the MAINTAINERS file with HNS3 Ethernet driver > maintainers names and other details. This also introduces the new > Makefiles required to build the HNS3 Ethernet driver and updates > the existing Kconfig file in the

Re: [PATCH V4 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS

On Sat, Jul 22, 2017 at 11:09:42PM +0100, Salil Mehta wrote: > This patch updates the MAINTAINERS file with HNS3 Ethernet driver > maintainers names and other details. This also introduces the new > Makefiles required to build the HNS3 Ethernet driver and updates > the existing Kconfig file in the

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 10:33:54AM -0400, Doug Ledford wrote: > So, you need to take your pick. Do you want continuous development, or > do you want me bending over backwards to try and avoid your company's > endless stream of conflicts so Linus isn't yelling about that? Doug, You are mixing my

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 10:33:54AM -0400, Doug Ledford wrote: > So, you need to take your pick. Do you want continuous development, or > do you want me bending over backwards to try and avoid your company's > endless stream of conflicts so Linus isn't yelling about that? Doug, You are mixing my

Re: [PATCH 22/22] IB/mlx4: fix sprintf format warning

here, > making the buffer one byte longer has no downsides and avoids the > warning. > > Fixes: c1e7e466120b ("IB/mlx4: Add iov directory in sysfs under the ib > device") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > drivers/infiniband/hw/mlx4/sysfs.c

Re: [PATCH 22/22] IB/mlx4: fix sprintf format warning

here, > making the buffer one byte longer has no downsides and avoids the > warning. > > Fixes: c1e7e466120b ("IB/mlx4: Add iov directory in sysfs under the ib > device") > Signed-off-by: Arnd Bergmann > --- > drivers/infiniband/hw/mlx4/sysfs.c | 2 +- > 1 f

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 08:03:49AM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 07:55 +0300, Leon Romanovsky wrote: > > On Fri, Jul 14, 2017 at 01:50:26PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > On Fri, 14 Jul 2017 06:34:16 +0

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 08:03:49AM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 07:55 +0300, Leon Romanovsky wrote: > > On Fri, Jul 14, 2017 at 01:50:26PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > On Fri, 14 Jul 2017 06:34:1

Re: [PATCH 11/14] IB/uverbs: fix gcc-7 type warning

macro to explicitly check the number for a positive > length, which avoids the warning. > > Fixes: a96e4e2ffe43 ("IB/uverbs: New macro to set pointers to NULL if length > is 0 in INIT_UDATA()") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > drivers/infiniband/co

Re: [PATCH 11/14] IB/uverbs: fix gcc-7 type warning

macro to explicitly check the number for a positive > length, which avoids the warning. > > Fixes: a96e4e2ffe43 ("IB/uverbs: New macro to set pointers to NULL if length > is 0 in INIT_UDATA()") > Signed-off-by: Arnd Bergmann > --- > drivers/infiniband/core/uverbs.h | 14

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 01:50:26PM +1000, Stephen Rothwell wrote: > Hi all, > > On Fri, 14 Jul 2017 06:34:16 +0300 Leon Romanovsky <l...@kernel.org> wrote: > > > > Sorry Doug, but it is not expected at all for the code which will go to > > 4.14. > > >

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 01:50:26PM +1000, Stephen Rothwell wrote: > Hi all, > > On Fri, 14 Jul 2017 06:34:16 +0300 Leon Romanovsky wrote: > > > > Sorry Doug, but it is not expected at all for the code which will go to > > 4.14. > > > > Both patches in

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 12:12:33AM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 06:34 +0300, Leon Romanovsky wrote: > > On Thu, Jul 13, 2017 at 09:17:13PM -0400, Doug Ledford wrote: > > > On Fri, 2017-07-14 at 11:14 +1000, Stephen Rothwell wrote: > > > > Hi

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Fri, Jul 14, 2017 at 12:12:33AM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 06:34 +0300, Leon Romanovsky wrote: > > On Thu, Jul 13, 2017 at 09:17:13PM -0400, Doug Ledford wrote: > > > On Fri, 2017-07-14 at 11:14 +1000, Stephen Rothwell wrote: > > > > Hi

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Thu, Jul 13, 2017 at 09:17:13PM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 11:14 +1000, Stephen Rothwell wrote: > > Hi Doug, > > > > Today's linux-next merge of the rdma tree got conflicts in: > > > > drivers/infiniband/core/uverbs_cmd.c > > drivers/infiniband/core/verbs.c > > > >

Re: linux-next: manual merge of the rdma tree with Linus' tree

On Thu, Jul 13, 2017 at 09:17:13PM -0400, Doug Ledford wrote: > On Fri, 2017-07-14 at 11:14 +1000, Stephen Rothwell wrote: > > Hi Doug, > > > > Today's linux-next merge of the rdma tree got conflicts in: > > > > drivers/infiniband/core/uverbs_cmd.c > > drivers/infiniband/core/verbs.c > > > >

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Fri, Jun 23, 2017 at 12:37:57AM +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > >

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Fri, Jun 23, 2017 at 12:37:57AM +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > > > wrote: > > >> We have hit this four times

Re: [PATCH V3 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver

On Sat, Jun 17, 2017 at 06:24:23PM +0100, Salil Mehta wrote: > This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem > 3) > Ethernet driver for hip08 family of SoCs and future upcoming SoCs. > > Hisilicon's new hip08 SoCs have integrated ethernet based on PCI Express and >

Re: [PATCH V3 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver

On Sat, Jun 17, 2017 at 06:24:23PM +0100, Salil Mehta wrote: > This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem > 3) > Ethernet driver for hip08 family of SoCs and future upcoming SoCs. > > Hisilicon's new hip08 SoCs have integrated ethernet based on PCI Express and >

<    5   6   7   8   9   10   11   12   13   14   >