RE: [PATCH]PCIE ASPM support - takes 3

2008-01-25 Thread Li, Shaohua
> > >Hi! > >> v3->v2, fixed the issues Matthew Wilcox raised. >> >> PCI Express ASPM defines a protocol for PCI Express components in the D0 >> state to reduce Link power by placing their Links into a low power state >> and instructing the other end of the Link to do likewise. This >> capability

RE: [PATCH]PCIE ASPM support - takes 3

2008-01-25 Thread Li, Shaohua
Hi! v3-v2, fixed the issues Matthew Wilcox raised. PCI Express ASPM defines a protocol for PCI Express components in the D0 state to reduce Link power by placing their Links into a low power state and instructing the other end of the Link to do likewise. This capability allows

RE: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Li, Shaohua
>-Original Message- >From: Robert Hancock [mailto:[EMAIL PROTECTED] >Sent: Friday, June 29, 2007 8:59 AM >To: Zan Lynx >Cc: Andrew Morton; linux-kernel@vger.kernel.org; Raj, Ashok; Li, Shaohua; >Keshavamurthy, Anil S >Subject: Re: 2.6.22-rc6-mm1 Intel DMAR crash on A

RE: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Li, Shaohua
-Original Message- From: Robert Hancock [mailto:[EMAIL PROTECTED] Sent: Friday, June 29, 2007 8:59 AM To: Zan Lynx Cc: Andrew Morton; linux-kernel@vger.kernel.org; Raj, Ashok; Li, Shaohua; Keshavamurthy, Anil S Subject: Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64 Zan Lynx wrote

RE: [ACPI] S3 and sigwait (was Re: 2.6.13-rc3: swsusp works (TP 600X))

2005-08-01 Thread Li, Shaohua
Hi, >> > If you think it is a linux bug, can you produce small test case doing >> > just the sigwait, and post it on l-k with big title "sigwait() breaks >> > when straced, and on suspend"? >> > >> > That way it is going to get some attetion, and you'll get either >> > documentation or kernel

RE: [ACPI] S3 and sigwait (was Re: 2.6.13-rc3: swsusp works (TP 600X))

2005-08-01 Thread Li, Shaohua
Hi, If you think it is a linux bug, can you produce small test case doing just the sigwait, and post it on l-k with big title sigwait() breaks when straced, and on suspend? That way it is going to get some attetion, and you'll get either documentation or kernel fixed. Looks like a

Re: [PATCH 4/6]cpu state clean after hot remove

2005-04-20 Thread Li Shaohua
On Tue, 2005-04-12 at 13:31, Li Shaohua wrote: > @@ -1052,7 +1086,7 @@ static void __init smp_boot_cpus(unsigne > if (max_cpus <= cpucount+1) > continue; > > - if (do_boot_cpu(apicid)) > + if ((cpu = alloc_cpu_id(

Re: [PATCH 4/6]cpu state clean after hot remove

2005-04-20 Thread Li Shaohua
On Tue, 2005-04-12 at 13:31, Li Shaohua wrote: @@ -1052,7 +1086,7 @@ static void __init smp_boot_cpus(unsigne if (max_cpus = cpucount+1) continue; - if (do_boot_cpu(apicid)) + if ((cpu = alloc_cpu_id() 0) do_boot_cpu(apicid, cpu

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-14 Thread Li Shaohua
On Thu, 2005-04-14 at 16:27, Li Shaohua wrote: > On Wed, 2005-04-13 at 16:32, Pavel Machek wrote: > > [EMAIL PROTECTED]:/sys/devices/system/cpu/cpu1# dmesg | tail -25 > > [] activate_task+0x1/0xa0 > > [] resched_task+0x68/0x90 > > [] try_to_wake_up+0x2aa/0x2f0 >

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-14 Thread Li Shaohua
On Wed, 2005-04-13 at 16:32, Pavel Machek wrote: > [EMAIL PROTECTED]:/sys/devices/system/cpu/cpu1# dmesg | tail -25 > [] activate_task+0x1/0xa0 > [] resched_task+0x68/0x90 > [] try_to_wake_up+0x2aa/0x2f0 > [] fbcon_cursor+0x19a/0x270 > [] hide_cursor+0x18/0x30 > []

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-14 Thread Li Shaohua
On Wed, 2005-04-13 at 16:32, Pavel Machek wrote: [EMAIL PROTECTED]:/sys/devices/system/cpu/cpu1# dmesg | tail -25 [c011d001] activate_task+0x1/0xa0 [c011d128] resched_task+0x68/0x90 [c011d8ba] try_to_wake_up+0x2aa/0x2f0 [c025ed7a] fbcon_cursor+0x19a/0x270 [c02c4958]

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-14 Thread Li Shaohua
On Thu, 2005-04-14 at 16:27, Li Shaohua wrote: On Wed, 2005-04-13 at 16:32, Pavel Machek wrote: [EMAIL PROTECTED]:/sys/devices/system/cpu/cpu1# dmesg | tail -25 [c011d001] activate_task+0x1/0xa0 [c011d128] resched_task+0x68/0x90 [c011d8ba] try_to_wake_up+0x2aa/0x2f0 [c025ed7a

Re: [PATCH 5/6]physical CPU hot add

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 20:17, Zwane Mwaikambo wrote: > On Tue, 12 Apr 2005, Li Shaohua wrote: > > > #ifdef CONFIG_HOTPLUG_CPU > > +int __attribute__ ((weak)) smp_prepare_cpu(int cpu) > > +{ > > + return 0; > > +} > > + > > Any way for you to av

Re: [PATCH 3/6]init call cleanup

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 17:32, Rolf Eike Beer wrote: > Li Shaohua wrote: > > Trival patch for CPU hotplug. In CPU identify part, only did cleaup > for > > intel CPUs. Need do for other CPUs if they support S3 SMP. > > > > @@ -405,7 +405,7 @@

RE: [PATCH 1/6]sep initializing rework

2005-04-12 Thread Li Shaohua
On Wed, 2005-04-13 at 01:57, Protasevich, Natalie wrote: > Hello, > This is a hotplug CPU patch for i386, done against 2.6.12-rc2-mm3. > Somewhat alternative to the one posted by Li Shaohua, but not really > (and I didn't mean that :). If you look closer, our patches are > di

Re: [PATCH 5/6]physical CPU hot add

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 20:17, Zwane Mwaikambo wrote: > On Tue, 12 Apr 2005, Li Shaohua wrote: > > > #ifdef CONFIG_HOTPLUG_CPU > > +int __attribute__ ((weak)) smp_prepare_cpu(int cpu) > > +{ > > + return 0; > > +} > > + > > Any way for you to avo

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 18:51, Pavel Machek wrote: > > Using CPU hotplug to support suspend/resume SMP. Both S3 and S4 use > > disable/enable_nonboot_cpus API. The S4 part is based on Pavel's > > original S4 SMP patch. > > I tested it on 2x PII(?) 550MHz system. Suspend went ok, resume loaded >

[PATCH 3/6]init call cleanup

2005-04-12 Thread Li Shaohua
Trival patch for CPU hotplug. In CPU identify part, only did cleaup for intel CPUs. Need do for other CPUs if they support S3 SMP. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/arch/i386/kernel/apic.c| 14 +++ linux-2.6.11-root/arch/i386/kern

[PATCH 1/6]sep initializing rework

2005-04-12 Thread Li Shaohua
, so it is hotplug safed. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 12 +++- linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |4

[PATCH 2/6]sibling map initializing rework

2005-04-12 Thread Li Shaohua
Make sibling map init per-cpu. Hotplug CPU may change the map at runtime. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 86 ++- 1 files changed, 45 insertions(+), 41 deletions(-) diff -puN arch/i386/kernel/smp

[PATCH 2/6]sibling map initializing rework

2005-04-12 Thread Li Shaohua
Make sibling map init per-cpu. Hotplug CPU may change the map at runtime. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 86 ++- 1 files changed, 45 insertions(+), 41 deletions(-) diff -puN arch/i386/kernel/smpboot.c

[PATCH 1/6]sep initializing rework

2005-04-12 Thread Li Shaohua
, so it is hotplug safed. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 12 +++- linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |4 linux

[PATCH 3/6]init call cleanup

2005-04-12 Thread Li Shaohua
Trival patch for CPU hotplug. In CPU identify part, only did cleaup for intel CPUs. Need do for other CPUs if they support S3 SMP. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/arch/i386/kernel/apic.c| 14 +++ linux-2.6.11-root/arch/i386/kernel/cpu

Re: [PATCH 6/6]suspend/resume SMP support

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 18:51, Pavel Machek wrote: Using CPU hotplug to support suspend/resume SMP. Both S3 and S4 use disable/enable_nonboot_cpus API. The S4 part is based on Pavel's original S4 SMP patch. I tested it on 2x PII(?) 550MHz system. Suspend went ok, resume loaded image from

Re: [PATCH 5/6]physical CPU hot add

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 20:17, Zwane Mwaikambo wrote: On Tue, 12 Apr 2005, Li Shaohua wrote: #ifdef CONFIG_HOTPLUG_CPU +int __attribute__ ((weak)) smp_prepare_cpu(int cpu) +{ + return 0; +} + Any way for you to avoid using weak attribute? Just want to avoid more 'ifdef

RE: [PATCH 1/6]sep initializing rework

2005-04-12 Thread Li Shaohua
On Wed, 2005-04-13 at 01:57, Protasevich, Natalie wrote: Hello, This is a hotplug CPU patch for i386, done against 2.6.12-rc2-mm3. Somewhat alternative to the one posted by Li Shaohua, but not really (and I didn't mean that :). If you look closer, our patches are different and can complement

Re: [PATCH 3/6]init call cleanup

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 17:32, Rolf Eike Beer wrote: Li Shaohua wrote: Trival patch for CPU hotplug. In CPU identify part, only did cleaup for intel CPUs. Need do for other CPUs if they support S3 SMP. @@ -405,7 +405,7 @@ void __init init_bsp_APIC(void) apic_write_around(APIC_LVT1

Re: [PATCH 5/6]physical CPU hot add

2005-04-12 Thread Li Shaohua
On Tue, 2005-04-12 at 20:17, Zwane Mwaikambo wrote: On Tue, 12 Apr 2005, Li Shaohua wrote: #ifdef CONFIG_HOTPLUG_CPU +int __attribute__ ((weak)) smp_prepare_cpu(int cpu) +{ + return 0; +} + Any way for you to avoid using weak attribute? Replace weak attribute with define

[PATCH 4/6]cpu state clean after hot remove

2005-04-11 Thread Li Shaohua
Clean CPU states in order to reuse smp boot code for CPU hotplug. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/arch/i386/kernel/cpu/common.c | 12 linux-2.6.11-root/arch/i386/kernel/irq.c|5 + linux-2.6.11-root/arch/i386/kernel/process.c

[PATCH 6/6]suspend/resume SMP support

2005-04-11 Thread Li Shaohua
Using CPU hotplug to support suspend/resume SMP. Both S3 and S4 use disable/enable_nonboot_cpus API. The S4 part is based on Pavel's original S4 SMP patch. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/drivers/acpi/Kconfig|2 linux-2.6.11-root/include

[PATCH 5/6]physical CPU hot add

2005-04-11 Thread Li Shaohua
Boot a CPU at runtime. Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 112 --- linux-2.6.11-root/drivers/base/cpu.c |8 + linux-2.6.11-root/include/asm-i386/smp.h |2 3 files changed, 93 inse

[PATCH 5/6]physical CPU hot add

2005-04-11 Thread Li Shaohua
Boot a CPU at runtime. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 112 --- linux-2.6.11-root/drivers/base/cpu.c |8 + linux-2.6.11-root/include/asm-i386/smp.h |2 3 files changed, 93 insertions

[PATCH 6/6]suspend/resume SMP support

2005-04-11 Thread Li Shaohua
Using CPU hotplug to support suspend/resume SMP. Both S3 and S4 use disable/enable_nonboot_cpus API. The S4 part is based on Pavel's original S4 SMP patch. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/drivers/acpi/Kconfig|2 linux-2.6.11-root/include/linux/suspend.h

[PATCH 4/6]cpu state clean after hot remove

2005-04-11 Thread Li Shaohua
Clean CPU states in order to reuse smp boot code for CPU hotplug. Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- linux-2.6.11-root/arch/i386/kernel/cpu/common.c | 12 linux-2.6.11-root/arch/i386/kernel/irq.c|5 + linux-2.6.11-root/arch/i386/kernel/process.c| 19

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-05 Thread Li Shaohua
On Mon, 2005-04-04 at 23:33, Nathan Lynch wrote: > > > > > > I don't understand why this is needed at all. It looks like a fair > > > amount of code from do_exit is being duplicated here. > > Yes, exactly. Someone who understand do_exit please help clean up the > > code. I'd like to remove the

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-05 Thread Li Shaohua
On Mon, 2005-04-04 at 23:33, Nathan Lynch wrote: I don't understand why this is needed at all. It looks like a fair amount of code from do_exit is being duplicated here. Yes, exactly. Someone who understand do_exit please help clean up the code. I'd like to remove the idle thread,

Re: [RFC 1/6]SEP initialization rework

2005-04-04 Thread Li Shaohua
On Tue, 2005-04-05 at 03:10, Zwane Mwaikambo wrote: > On Mon, 4 Apr 2005, Li Shaohua wrote: > > > linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ > > linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ > > linux-2.6.11-roo

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-04 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 23:33, Nathan Lynch wrote: > > I'd say fix the smpboot code so that it doesn't create new idle tasks > except during boot. I'd like the the CPU hotremove case just likes the case that CPU isn't boot. A non-boot CPU hasn't a idle thread. But you may think it's not worthy

Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-04 Thread Li Shaohua
On Tue, 2005-04-05 at 03:11, Zwane Mwaikambo wrote: > On Mon, 4 Apr 2005, Li Shaohua wrote: > > > Clean up all CPU states including its runqueue and idle thread, > > so we can use boot time code without any changes. > > Note this makes /sys/devices/system/cp

Re: [ACPI] Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 17:10, Pavel Machek wrote: > Hi! > > > > I'm switching suspend2 to use hotplug too. Li, I'll try adding your > > > patches as well as Zwane's if you like > > Great! > > > > > (suspend2 can enter S3, S4 or S5 > > > after writing the image). I'd love to try it on my HT

Re: [RFC 4/6]Add kconfig for S3 SMP

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 16:59, Pavel Machek wrote: > Hi! > > > Add kconfig for IA32 S3 SMP. > > > > Thanks, > > Shaohua > > > > --- > > > > linux-2.6.11-root/kernel/power/Kconfig |7 +++ > > 1 files changed, 7 insertions(+) > > > > diff -puN kernel/power/Kconfig~smp_s3_kconfig

Re: [RFC 1/6]SEP initialization rework

2005-04-04 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 16:46, Pavel Machek wrote: > > --- > > > > linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ > > linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ > > linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |6 ++ > >

Re: [ACPI] Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 16:01, Nigel Cunningham wrote: > Hi. > > I'm switching suspend2 to use hotplug too. Li, I'll try adding your > patches as well as Zwane's if you like Great! > (suspend2 can enter S3, S4 or S5 > after writing the image). I'd love to try it on my HT desktop, and > hotplug

Re: [ACPI] Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 16:01, Nigel Cunningham wrote: Hi. I'm switching suspend2 to use hotplug too. Li, I'll try adding your patches as well as Zwane's if you like Great! (suspend2 can enter S3, S4 or S5 after writing the image). I'd love to try it on my HT desktop, and hotplug will get

Re: [RFC 1/6]SEP initialization rework

2005-04-04 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 16:46, Pavel Machek wrote: --- linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |6 ++ 3 files

Re: [RFC 4/6]Add kconfig for S3 SMP

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 16:59, Pavel Machek wrote: Hi! Add kconfig for IA32 S3 SMP. Thanks, Shaohua --- linux-2.6.11-root/kernel/power/Kconfig |7 +++ 1 files changed, 7 insertions(+) diff -puN kernel/power/Kconfig~smp_s3_kconfig kernel/power/Kconfig ---

Re: [ACPI] Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-04 Thread Li Shaohua
On Mon, 2005-04-04 at 17:10, Pavel Machek wrote: Hi! I'm switching suspend2 to use hotplug too. Li, I'll try adding your patches as well as Zwane's if you like Great! (suspend2 can enter S3, S4 or S5 after writing the image). I'd love to try it on my HT desktop, and hotplug

Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-04 Thread Li Shaohua
On Tue, 2005-04-05 at 03:11, Zwane Mwaikambo wrote: On Mon, 4 Apr 2005, Li Shaohua wrote: Clean up all CPU states including its runqueue and idle thread, so we can use boot time code without any changes. Note this makes /sys/devices/system/cpu/cpux/online unworkable. #ifdef

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-04 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 23:33, Nathan Lynch wrote: I'd say fix the smpboot code so that it doesn't create new idle tasks except during boot. I'd like the the CPU hotremove case just likes the case that CPU isn't boot. A non-boot CPU hasn't a idle thread. But you may think it's not worthy

Re: [RFC 1/6]SEP initialization rework

2005-04-04 Thread Li Shaohua
On Tue, 2005-04-05 at 03:10, Zwane Mwaikambo wrote: On Mon, 4 Apr 2005, Li Shaohua wrote: linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-03 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 13:28, Nathan Lynch wrote: > On Mon, Apr 04, 2005 at 10:07:02AM +0800, Li Shaohua wrote: > > Clean up all CPU states including its runqueue and idle thread, > > so we can use boot time code without any changes. > > Note this makes /sys/devices/s

Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
On Mon, 2005-04-04 at 10:48, Andrew Morton wrote: > Li Shaohua <[EMAIL PROTECTED]> wrote: > > > > On Mon, 2005-04-04 at 10:37, Andrew Morton wrote: > > > Li Shaohua <[EMAIL PROTECTED]> wrote: > > > > > > > > The patches are against 2.

Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
On Mon, 2005-04-04 at 10:37, Andrew Morton wrote: > Li Shaohua <[EMAIL PROTECTED]> wrote: > > > > The patches are against 2.6.11-rc1 with Zwane's CPU hotplug patch in -mm > > tree. > > Should I merge that thing into mainline? It seems that a few people are

[RFC 6/6]Physcial CPU hotadd and S3 SMP support

2005-04-03 Thread Li Shaohua
Boot a CPU at runtime and use it to support S3 SMP. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 79 +++ linux-2.6.11-root/include/asm-i386/smp.h |4 + linux-2.6.11-root/kernel/power/main.c| 30 ++ 3 files changed, 104

[RFC 5/6]clean cpu state after hotremove CPU

2005-04-03 Thread Li Shaohua
Clean up all CPU states including its runqueue and idle thread, so we can use boot time code without any changes. Note this makes /sys/devices/system/cpu/cpux/online unworkable. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/cpu/common.c | 12

[RFC 3/6]init call cleanup

2005-04-03 Thread Li Shaohua
Trival patch for CPU hotplug. In CPU identify part, only did cleanup for intel CPUs. Need do for other CPUs if they support S3 SMP. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/apic.c| 14 +++ linux-2.6.11-root/arch/i386/kernel/cpu/common.c | 30

[RFC 4/6]Add kconfig for S3 SMP

2005-04-03 Thread Li Shaohua
Add kconfig for IA32 S3 SMP. Thanks, Shaohua --- linux-2.6.11-root/kernel/power/Kconfig |7 +++ 1 files changed, 7 insertions(+) diff -puN kernel/power/Kconfig~smp_s3_kconfig kernel/power/Kconfig --- linux-2.6.11/kernel/power/Kconfig~smp_s3_kconfig2005-03-31 10:49:57.156487160

[RFC 2/6]cpu_sibling_map rework

2005-04-03 Thread Li Shaohua
Make sibling map init per-cpu. Hotplug CPU may change the map at runtime. cpuhotplug semaphore should be used to protect the map. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 56 +-- 1 files changed, 29 insertions(+), 27 deletions(-) diff -puN

[RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
Hi, The following 6 patches try to add suspend-to-ram (or S3) SMP support for IA32. It's for support HT based system suspend/resume currently and most of the code are also useful for physical CPU hotplug. In a SMP system, after S3 resume, the BP is starting to execute the ACPI wakeup address just

[RFC 1/6]SEP initialization rework

2005-04-03 Thread Li Shaohua
Make SEP init per-cpu, so is hotplug safe. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |6 ++ 3 files changed,

[RFC 1/6]SEP initialization rework

2005-04-03 Thread Li Shaohua
Make SEP init per-cpu, so is hotplug safe. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c |6 ++ linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++ linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c |6 ++ 3 files changed,

[RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
Hi, The following 6 patches try to add suspend-to-ram (or S3) SMP support for IA32. It's for support HT based system suspend/resume currently and most of the code are also useful for physical CPU hotplug. In a SMP system, after S3 resume, the BP is starting to execute the ACPI wakeup address just

[RFC 2/6]cpu_sibling_map rework

2005-04-03 Thread Li Shaohua
Make sibling map init per-cpu. Hotplug CPU may change the map at runtime. cpuhotplug semaphore should be used to protect the map. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 56 +-- 1 files changed, 29 insertions(+), 27 deletions(-) diff -puN

[RFC 5/6]clean cpu state after hotremove CPU

2005-04-03 Thread Li Shaohua
Clean up all CPU states including its runqueue and idle thread, so we can use boot time code without any changes. Note this makes /sys/devices/system/cpu/cpux/online unworkable. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/cpu/common.c | 12

[RFC 6/6]Physcial CPU hotadd and S3 SMP support

2005-04-03 Thread Li Shaohua
Boot a CPU at runtime and use it to support S3 SMP. Thanks, Shaohua --- linux-2.6.11-root/arch/i386/kernel/smpboot.c | 79 +++ linux-2.6.11-root/include/asm-i386/smp.h |4 + linux-2.6.11-root/kernel/power/main.c| 30 ++ 3 files changed, 104

Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
On Mon, 2005-04-04 at 10:37, Andrew Morton wrote: Li Shaohua [EMAIL PROTECTED] wrote: The patches are against 2.6.11-rc1 with Zwane's CPU hotplug patch in -mm tree. Should I merge that thing into mainline? It seems that a few people are needing it. I'd like to listen to some comments

Re: [RFC 0/6] S3 SMP support with physcial CPU hotplug

2005-04-03 Thread Li Shaohua
On Mon, 2005-04-04 at 10:48, Andrew Morton wrote: Li Shaohua [EMAIL PROTECTED] wrote: On Mon, 2005-04-04 at 10:37, Andrew Morton wrote: Li Shaohua [EMAIL PROTECTED] wrote: The patches are against 2.6.11-rc1 with Zwane's CPU hotplug patch in -mm tree. Should I merge

Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU

2005-04-03 Thread Li Shaohua
Hi, On Mon, 2005-04-04 at 13:28, Nathan Lynch wrote: On Mon, Apr 04, 2005 at 10:07:02AM +0800, Li Shaohua wrote: Clean up all CPU states including its runqueue and idle thread, so we can use boot time code without any changes. Note this makes /sys/devices/system/cpu/cpux/online unworkable

Re: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers

2005-03-27 Thread Li Shaohua
On Sun, 2005-03-27 at 02:23, Rafael J. Wysocki wrote: > Hi, > > On Friday, 25 of March 2005 15:19, Rafael J. Wysocki wrote: > > On Friday, 25 of March 2005 13:54, you wrote: > > ]--snip--[ > > > >My box is still hanged solid on resume (swsusp) by the drivers: > > > > > > > >ohci_hcd > > >

Re: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers

2005-03-27 Thread Li Shaohua
On Sun, 2005-03-27 at 02:23, Rafael J. Wysocki wrote: Hi, On Friday, 25 of March 2005 15:19, Rafael J. Wysocki wrote: On Friday, 25 of March 2005 13:54, you wrote: ]--snip--[ My box is still hanged solid on resume (swsusp) by the drivers: ohci_hcd ehci_hcd yenta_socket

RE: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers

2005-03-25 Thread Li, Shaohua
Hi, >On Friday, 25 of March 2005 09:21, Andrew Morton wrote: >> >> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12- >rc1/2.6.12-rc1-mm3/ >> >> - Mainly a bunch of fixes relative to 2.6.12-rc1-mm2. > >First, rmmod works again (thanks ;-)). > >> - Again, we'd like people who

RE: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers

2005-03-25 Thread Li, Shaohua
Hi, On Friday, 25 of March 2005 09:21, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12- rc1/2.6.12-rc1-mm3/ - Mainly a bunch of fixes relative to 2.6.12-rc1-mm2. First, rmmod works again (thanks ;-)). - Again, we'd like people who have had recent

Re: 2.6.12-rc1-mm1: resume regression [update] (was: Re:2.6.12-rc1-mm1: Kernel BUG at pci:389)

2005-03-24 Thread Li Shaohua
On Thu, 2005-03-24 at 21:42, Rafael J. Wysocki wrote: > Hi, > > On Thursday, 24 of March 2005 02:27, Li Shaohua wrote: > > On Thu, 2005-03-24 at 09:03, Len Brown wrote: > > > On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote: > > > > Hi, > > > &g

Re: 2.6.12-rc1-mm1: resume regression [update] (was: Re:2.6.12-rc1-mm1: Kernel BUG at pci:389)

2005-03-24 Thread Li Shaohua
On Thu, 2005-03-24 at 21:42, Rafael J. Wysocki wrote: Hi, On Thursday, 24 of March 2005 02:27, Li Shaohua wrote: On Thu, 2005-03-24 at 09:03, Len Brown wrote: On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote: Hi, On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote

Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-23 Thread Li Shaohua
On Tue, 2005-03-22 at 20:20, Pavel Machek wrote: > Hi! > > > >> > Yes, but it is needed. There are many drivers, and they look at > > >> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully > > killed > > >> > all direct accesses to the constants, and will switch constants > to > >

Re: 2.6.12-rc1-mm1: resume regression [update] (was: Re:2.6.12-rc1-mm1: Kernel BUG at pci:389)

2005-03-23 Thread Li Shaohua
On Thu, 2005-03-24 at 09:03, Len Brown wrote: > On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote: > > Hi, > > > > On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote: > > > Hi! > > > > > > > > > > Will this do it for the moment? > > > > > > > > > > > > Its certainly better. > > > > > > >

Re: 2.6.12-rc1-mm1: resume regression [update] (was: Re:2.6.12-rc1-mm1: Kernel BUG at pci:389)

2005-03-23 Thread Li Shaohua
On Thu, 2005-03-24 at 09:03, Len Brown wrote: On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote: Hi, On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote: Hi! Will this do it for the moment? Its certainly better. With the Len's patch applied I have

Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-23 Thread Li Shaohua
On Tue, 2005-03-22 at 20:20, Pavel Machek wrote: Hi! Yes, but it is needed. There are many drivers, and they look at numerical value of PMSG_*. I'm proceeding in steps. I hopefully killed all direct accesses to the constants, and will switch constants to something else... But

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-22 Thread Li Shaohua
On Wed, 2005-03-23 at 04:57, Bjorn Helgaas wrote: > > Your patch applied with some problems: > > > > patching file arch/i386/pci/irq.c > > Hunk #2 succeeded at 1081 with fuzz 2 (offset 1 line). > > patching file drivers/acpi/pci_irq.c > > patching file drivers/pci/quirks.c > > Hunk #1 succeeded at

RE: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-22 Thread Li, Shaohua
> >> > Yes, but it is needed. There are many drivers, and they look at >> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully killed >> > all direct accesses to the constants, and will switch constants to >> > something else... But that is going to be tommorow (need some sleep). >>

RE: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-22 Thread Li, Shaohua
Yes, but it is needed. There are many drivers, and they look at numerical value of PMSG_*. I'm proceeding in steps. I hopefully killed all direct accesses to the constants, and will switch constants to something else... But that is going to be tommorow (need some sleep). The patches are

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-22 Thread Li Shaohua
On Wed, 2005-03-23 at 04:57, Bjorn Helgaas wrote: Your patch applied with some problems: patching file arch/i386/pci/irq.c Hunk #2 succeeded at 1081 with fuzz 2 (offset 1 line). patching file drivers/acpi/pci_irq.c patching file drivers/pci/quirks.c Hunk #1 succeeded at 678 (offset

Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-21 Thread Li Shaohua
On Tue, 2005-03-22 at 09:35, Pavel Machek wrote: > Hi! > > > > and that says: > > > > > > #define PMSG_FREEZE ((__force pm_message_t) 3) > > > > > > ... I certainly have _FREEZE defined as 1 in my local tree, but I > do > > > not see that change in -mm yet. > > > > Both 2.6.12-rc1-mm1 and

Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389

2005-03-21 Thread Li Shaohua
On Tue, 2005-03-22 at 09:35, Pavel Machek wrote: Hi! and that says: #define PMSG_FREEZE ((__force pm_message_t) 3) ... I certainly have _FREEZE defined as 1 in my local tree, but I do not see that change in -mm yet. Both 2.6.12-rc1-mm1 and 2.6.12-rc1 have:

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-17 Thread Li Shaohua
On Fri, 2005-03-18 at 02:08, Bjorn Helgaas wrote: > On Thu, 2005-03-17 at 09:33 +0800, Li Shaohua wrote: > > The comments in previous quirk said it's required only in PIC mode. > ... > > I feel we concerned too much. Changing the interrupt line isn't harmful, > > right

[PATCH]fix oops when inserting ipmi_si module

2005-03-17 Thread Li Shaohua
Hi, In one of machines in our lab, spmi->addr.register_bit_width is 0 (so the returned address is invalid). Ignoring the check will cause inserting the module oops. Thanks, Shaohua Signed-off-by: Li Shaohua<[EMAIL PROTECTED]> --- a/drivers/char/ipmi/ipmi_si_intf.c 2005-03-03 10:56:51.

[PATCH]fix oops when inserting ipmi_si module

2005-03-17 Thread Li Shaohua
Hi, In one of machines in our lab, spmi-addr.register_bit_width is 0 (so the returned address is invalid). Ignoring the check will cause inserting the module oops. Thanks, Shaohua Signed-off-by: Li Shaohua[EMAIL PROTECTED] --- a/drivers/char/ipmi/ipmi_si_intf.c 2005-03-03 10:56:51.0

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-17 Thread Li Shaohua
On Fri, 2005-03-18 at 02:08, Bjorn Helgaas wrote: On Thu, 2005-03-17 at 09:33 +0800, Li Shaohua wrote: The comments in previous quirk said it's required only in PIC mode. ... I feel we concerned too much. Changing the interrupt line isn't harmful, right? Linux actually ignored interrupt

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-16 Thread Li Shaohua
Hi, On Thu, 2005-03-17 at 00:10, Bjorn Helgaas wrote: > On Tue, 2005-03-15 at 16:02 -0700, Zwane Mwaikambo wrote: > > On Tue, 15 Mar 2005, Bjorn Helgaas wrote: > > > That seems awfully suspicious to me. So the following is > > > probably safe as far as it goes, but not sufficient for all > > >

Re: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-16 Thread Li Shaohua
Hi, On Thu, 2005-03-17 at 00:10, Bjorn Helgaas wrote: On Tue, 2005-03-15 at 16:02 -0700, Zwane Mwaikambo wrote: On Tue, 15 Mar 2005, Bjorn Helgaas wrote: That seems awfully suspicious to me. So the following is probably safe as far as it goes, but not sufficient for all cases.

Re: [ACPI] Re: Call for help: list of machines with working S3

2005-03-15 Thread Li Shaohua
Hi, On Mon, 2005-03-14 at 16:00, Pavel Machek wrote: > Hi! > > > * MySQL (hinders the actual suspension process and kicks the pc > back to > > where it was) > > Try this patch... > Pavel > > --- clean/kernel/signal.c

Re: [ACPI] Re: Call for help: list of machines with working S3

2005-03-15 Thread Li Shaohua
Hi, On Mon, 2005-03-14 at 16:00, Pavel Machek wrote: Hi! * MySQL (hinders the actual suspension process and kicks the pc back to where it was) Try this patch... Pavel --- clean/kernel/signal.c 2005-02-03

RE: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-14 Thread Li, Shaohua
Hi, This issue is quite interesting. We removed all specific VIA quirk recently and apply a generic VIA quirk. But in this case, the MCH 00:0.0 is from AMD, and the ISA bridge and built-in devices are from VIA, this means VIA quirk is useless, since it takes action only when the MCH is from VIA.

RE: [ACPI] Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

2005-03-14 Thread Li, Shaohua
Hi, This issue is quite interesting. We removed all specific VIA quirk recently and apply a generic VIA quirk. But in this case, the MCH 00:0.0 is from AMD, and the ISA bridge and built-in devices are from VIA, this means VIA quirk is useless, since it takes action only when the MCH is from VIA.

RE: [ACPI] s4bios: does anyone use it?

2005-03-07 Thread Li, Shaohua
Hi, >> > >> > Is there single user of s4bios? It used to work for me 4 notebooks >> > ago, but I never really used it. >> >> I don't have anymore my toshiba laptop where S4 bios was first >> implemented. >> >> > I think I'm the only person that ever >> > seen it working, but I could be wrong. >>

RE: [ACPI] s4bios: does anyone use it?

2005-03-07 Thread Li, Shaohua
Hi, Is there single user of s4bios? It used to work for me 4 notebooks ago, but I never really used it. I don't have anymore my toshiba laptop where S4 bios was first implemented. I think I'm the only person that ever seen it working, but I could be wrong. You are indeed wrong.

Re: [PATCH] fixup debug warnings during ACPI S3 resume from ram

2005-01-17 Thread Li Shaohua
On Sat, 2005-01-15 at 08:24, Christian Borntraeger wrote: > During the wakeup from suspend-to-ram I get several warnings (see below). > This patch fixes the warnings for me, but I am not an expert in ACPI. Please > read the patch and consider to apply it. Thanks looking at this issue. We (intel

Re: [PATCH 0/4]Bind physical devices with ACPI devices - take 2

2005-01-17 Thread Li Shaohua
On Mon, 2005-01-17 at 19:28, Pavel Machek wrote: > Hi! > > > > The series of patches implement binding physical devices with ACPI > > > devices. With it, device drivers can utilize methods provided by > > > firmware (ACPI). These patches are against 2.6.10, please give your > > > comments. > > >

Re: [PATCH 0/4]Bind physical devices with ACPI devices - take 2

2005-01-17 Thread Li Shaohua
On Wed, 2005-01-05 at 10:50, Li Shaohua wrote: > Hi, > The series of patches implement binding physical devices with ACPI > devices. With it, device drivers can utilize methods provided by > firmware (ACPI). These patches are against 2.6.10, please give your > comments. Hi, This is

Re: [PATCH 0/4]Bind physical devices with ACPI devices - take 2

2005-01-17 Thread Li Shaohua
On Wed, 2005-01-05 at 10:50, Li Shaohua wrote: Hi, The series of patches implement binding physical devices with ACPI devices. With it, device drivers can utilize methods provided by firmware (ACPI). These patches are against 2.6.10, please give your comments. Hi, This is updated patches

  1   2   >