Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

On Fri, Apr 16, 2021 at 1:47 AM Thomas Gleixner wrote: > Enable tracing and enable the following tracepoints: > [...] Sorry for the delay. I had to learn a bit about how to use the tracing infrastructure. I don't know if I can post here, but to my untrained eye, one big difference between the

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

On Wed, Apr 14, 2021 at 2:14 AM Greg KH wrote: > To give context, the commit is now 46eb1701c046 ("hrtimer: Update > softirq_expires_next correctly after __hrtimer_get_next_event()") and is > attached below. > > The f_ncm.c driver is doing a lot of calls to hrtimer_start() with mode >

Re: [PATCH] USB: gadget: Fix a configfs return code

\ > opts->_n_ = val;\ > ret = len; \ > } \ Acked-by: Lorenzo Colitti

Re: [PATCH] xfrm:fragmented ipv4 tunnel packets in inner interface

On Tue, Sep 15, 2020 at 4:30 PM Steffen Klassert wrote: > > In esp's tunnel mode,if inner interface is ipv4,outer is ipv4,one big > > packet which travels through tunnel will be fragmented with outer > > interface's mtu,peer server will remove tunnelled esp header and assemble > > them in big

Re: [PATCH 00/31 v2] PTI support for x86_32

On Wed, Feb 14, 2018 at 5:54 PM, Greg KH wrote: > > > IPSEC doesn't work with a 64bit kernel and 32bit userspace right now. > > > > > > Back in 2015 someone started to work on that, and properly marked that > > > the kernel could not handle this with commit

Re: [PATCH 00/31 v2] PTI support for x86_32

On Wed, Feb 14, 2018 at 5:54 PM, Greg KH wrote: > > > IPSEC doesn't work with a 64bit kernel and 32bit userspace right now. > > > > > > Back in 2015 someone started to work on that, and properly marked that > > > the kernel could not handle this with commit 74005991b78a ("xfrm: Do not > > > parse

Re: [PATCH 7/9] config: android-base: enable CONFIG_INET_DIAG_DESTROY

On Thu, Jun 8, 2017 at 6:55 PM, Amit Pundir wrote: > Reviewed-at: https://android-review.googlesource.com/#/c/322674/ Note: that change was a mistake. > --- a/kernel/configs/android-base.config > +++ b/kernel/configs/android-base.config > @@ -27,6 +27,7 @@

Re: [PATCH 7/9] config: android-base: enable CONFIG_INET_DIAG_DESTROY

On Thu, Jun 8, 2017 at 6:55 PM, Amit Pundir wrote: > Reviewed-at: https://android-review.googlesource.com/#/c/322674/ Note: that change was a mistake. > --- a/kernel/configs/android-base.config > +++ b/kernel/configs/android-base.config > @@ -27,6 +27,7 @@ CONFIG_HIGH_RES_TIMERS=y >

Re: [PATCH net] net: ping: do not abuse udp_poll()

On Sun, Jun 4, 2017 at 1:29 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > The problem is that ping sockets should not use udp_poll() in the first > place, and recent changes in UDP stack finally exposed this old bug. Acked-By: Lorenzo Colitti <lore...@google.com> Tested-B

Re: [PATCH net] net: ping: do not abuse udp_poll()

On Sun, Jun 4, 2017 at 1:29 AM, Eric Dumazet wrote: > The problem is that ping sockets should not use udp_poll() in the first > place, and recent changes in UDP stack finally exposed this old bug. Acked-By: Lorenzo Colitti Tested-By: Lorenzo Colitti

Re: [PATCH] net: ipv6: check route protocol when deleting routes

On Fri, Dec 16, 2016 at 5:30 PM, Mantas Mikulėnas wrote: > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can

Re: [PATCH] net: ipv6: check route protocol when deleting routes

On Fri, Dec 16, 2016 at 5:30 PM, Mantas Mikulėnas wrote: > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can be verified using

Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr()

android-review.googlesource.com/316594 . Tested-by: Lorenzo Colitti <lore...@google.com> Acked-by: Lorenzo Colitti <lore...@google.com>

Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr()

ally only valid when ATTR_UID is set in ia_valid, indicating that > the uid is being changed, e.g. by chown. > [...] > - if (!err) { > + if (!err && (iattr->ia_valid & ATTR_UID)) { Oops. Thanks for fixing this. Unit tested in https://android-review.googlesourc

Re: [PATCH] net: ping: check minimum size on ICMP header length

On Sat, Dec 3, 2016 at 9:58 AM, Kees Cook wrote: > - if (len > 0x) > + if (len > 0x || len < icmph_len) > return -EMSGSIZE; EMSGSIZE usually means the message is too long. Maybe use EINVAL? That's what the code will return if the

Re: [PATCH] net: ping: check minimum size on ICMP header length

On Sat, Dec 3, 2016 at 9:58 AM, Kees Cook wrote: > - if (len > 0x) > + if (len > 0x || len < icmph_len) > return -EMSGSIZE; EMSGSIZE usually means the message is too long. Maybe use EINVAL? That's what the code will return if the passed-in ICMP header is

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Wed, Aug 3, 2016 at 3:00 AM, David Miller wrote: > > index 96161b8..ce19c5b 100644 > > --- a/include/uapi/linux/fib_rules.h > > +++ b/include/uapi/linux/fib_rules.h > > @@ -49,6 +49,8 @@ enum { > > FRA_TABLE, /* Extended table id */ > > FRA_FWMASK,

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Wed, Aug 3, 2016 at 3:00 AM, David Miller wrote: > > index 96161b8..ce19c5b 100644 > > --- a/include/uapi/linux/fib_rules.h > > +++ b/include/uapi/linux/fib_rules.h > > @@ -49,6 +49,8 @@ enum { > > FRA_TABLE, /* Extended table id */ > > FRA_FWMASK, /* mask for

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: > > With the patch reverted, and the system working, I see: > > # ip rule ls > 0: from all lookup local > 1: from all fwmark 0xc/0xd lookup legacy_system > 13000: from all fwmark 0x10063/0x1 lookup

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: > > With the patch reverted, and the system working, I see: > > # ip rule ls > 0: from all lookup local > 1: from all fwmark 0xc/0xd lookup legacy_system > 13000: from all fwmark 0x10063/0x1 lookup local_network > 13000:

Re: [PATCH] net: ipv6: Fix incompatible pointer type warning

6 port, u32 info, u8 *payload) {} > int dummy_ipv6_chk_addr(struct net *net, const struct in6_addr *addr, > - struct net_device *dev, int strict) > + const struct net_device *dev, int strict) > { > return 0; > } > -- > 1.7.1

Re: [PATCH] net: ipv6: Fix incompatible pointer type warning

) + const struct net_device *dev, int strict) { return 0; } -- 1.7.10.4 Acked-by: Lorenzo Colitti lore...@google.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: Vendor: Hewlett-Packard - Version: 68BDD Ver. F.0F - Release Date: 07/23/2004 + Version: 68BDD Ver. F.11 + Release Date: 11/22/2004 Ok, so you both have different BIOS versions and different CPUs. S3

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: I beg to differ: it works for me on 2.6.11-rc3 (even with the swsusp2 patch). However, I need to use acpi_sleep=s3_bios, and I can't use radeonfb or it will lock up on resume. Could you grab dmidecode from http://www.nongnu.org/dmidecode/ and provide the output? It'd be

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: I beg to differ: it works for me on 2.6.11-rc3 (even with the swsusp2 patch). However, I need to use acpi_sleep=s3_bios, and I can't use radeonfb or it will lock up on resume. Could you grab dmidecode from http://www.nongnu.org/dmidecode/ and provide the output? It'd be

Re: [ACPI] Re: Call for help: list of machines with working S3

Alistair John Strachan wrote: .config attached. As recommended elsewhere in this thread, I'm not using any sort of framebuffer driver, but vesafb IS compiled in (but no vga= option is present). Does it need to be compiled out completely? I don't remember, maybe you can deduce it from the .config

Re: [ACPI] Re: Call for help: list of machines with working S3

Alistair John Strachan wrote: On Monday 14 Feb 2005 21:11, Pavel Machek wrote: Table of known working systems: Model hack (or "how to do it") [...] HP NC6000 s3_bios (2) The above report is incorrect. On 2.6.11-rc4, even with the s3_bios option, the

Re: [ACPI] Re: Call for help: list of machines with working S3

Alistair John Strachan wrote: On Monday 14 Feb 2005 21:11, Pavel Machek wrote: Table of known working systems: Model hack (or how to do it) [...] HP NC6000 s3_bios (2) The above report is incorrect. On 2.6.11-rc4, even with the s3_bios option, the

Re: [ACPI] Re: Call for help: list of machines with working S3

Alistair John Strachan wrote: .config attached. As recommended elsewhere in this thread, I'm not using any sort of framebuffer driver, but vesafb IS compiled in (but no vga= option is present). Does it need to be compiled out completely? I don't remember, maybe you can deduce it from the .config

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: I beg to differ: it works for me on 2.6.11-rc3 (even with the swsusp2 patch). However, I need to use acpi_sleep=s3_bios, and I can't use radeonfb or it will lock up on resume. Could you grab dmidecode from http://www.nongnu.org/dmidecode/ and provide the output? It'd be

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: I beg to differ: it works for me on 2.6.11-rc3 (even with the swsusp2 patch). However, I need to use acpi_sleep=s3_bios, and I can't use radeonfb or it will lock up on resume. Could you grab dmidecode from http://www.nongnu.org/dmidecode/ and provide the output? It'd be

Re: [ACPI] Re: Call for help: list of machines with working S3

Matthew Garrett wrote: Vendor: Hewlett-Packard - Version: 68BDD Ver. F.0F - Release Date: 07/23/2004 + Version: 68BDD Ver. F.11 + Release Date: 11/22/2004 Ok, so you both have different BIOS versions and different CPUs. S3