[PATCH v3 02/15] ASoC: cs42l42: Fix channel width support

Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1

[PATCH v3 08/15] ASoC: cs42l42: Provide finer control on playback path

Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 65 +- sound/soc

[PATCH v3 12/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs

[PATCH v3 10/15] ASoC: cs42l42: Add Capture Support

Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff

[PATCH v3 03/15] ASoC: cs42l42: Fix mixer volume control

The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs

[PATCH v3 09/15] ASoC: cs42l42: Set clock source for both ways of stream

Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Add missing cs42l42_private struct pointer sound/soc/codecs/cs42l42.c | 86 +- sound

[PATCH v3 04/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b

[PATCH v3 07/15] ASoC: cs42l42: Disable regulators if probe fails

In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c

[PATCH v3 06/15] ASoC: cs42l42: Remove power if the driver is being removed

Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- Changes in v3: - Free IRQ before pm_suspend Changes in v2: - Use PM functions to shutdown the codec - Disable IRQ before pm_suspend sound/soc/codecs/cs42l42.c | 6 -- 1 file changed, 4

[PATCH v3 05/15] ASoC: cs42l42: Always wait at least 3ms after reset

This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2

[PATCH v3 13/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - struct cs42l42_private add by this patch was wrong and moved to the correct patch - Lucas signed-off added sound/soc/codecs/cs42l42.c | 27 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed

[PATCH v3 14/15] ASoC: cs42l42: Only start PLL if it is needed

From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in

[PATCH v3 15/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Lucas signed-off added sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h

[PATCH v3 11/15] ASoC: cs42l42: Report jack and button detection

Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Don't move the code around

[PATCH v3 00/15] Report jack and button detection + Capture Support

Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Fix Bitclock polarity inversion ASoC: cs42l42: Fix channel width support

[PATCH v3 01/15] ASoC: cs42l42: Fix Bitclock polarity inversion

The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 20

[PATCH v2 07/15] ASoC: cs42l42: Disable regulators if probe fails

In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c

[PATCH v2 00/15] Report jack and button detection + Capture Support

Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Fix Bitclock polarity inversion ASoC: cs42l42: Fix channel width support

[PATCH v2 13/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

Signed-off-by: Lucas Tanure --- Changes in v2: - struct cs42l42_private add by this patch was wrong and moved to the correct patch - Lucas signed-off added sound/soc/codecs/cs42l42.c | 27 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 23 insertions(+), 5 deletions

[PATCH v2 01/15] ASoC: cs42l42: Fix Bitclock polarity inversion

The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 20 sound/soc/codecs

[PATCH v2 11/15] ASoC: cs42l42: Report jack and button detection

Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- Changes in v2: - Don't move the code around - Removed rename component

[PATCH v2 09/15] ASoC: cs42l42: Set clock source for both ways of stream

Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- Changes in v2: - Add missing cs42l42_private struct pointer sound/soc/codecs/cs42l42.c | 86 +- sound/soc/codecs/cs42l42.h | 1 + 2

[PATCH v2 08/15] ASoC: cs42l42: Provide finer control on playback path

Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 65 +- sound/soc/codecs/cs42l42.h | 8 ++--- 2

[PATCH v2 04/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c

[PATCH v2 10/15] ASoC: cs42l42: Add Capture Support

Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff --git a/sound/soc/codecs

[PATCH v2 15/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v2: - Lucas signed-off added sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h | 2 ++ 2 files changed, 13

[PATCH v2 12/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 14 insertions(+), 4

[PATCH v2 05/15] ASoC: cs42l42: Always wait at least 3ms after reset

This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 3 insertions

[PATCH v2 14/15] ASoC: cs42l42: Only start PLL if it is needed

From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v2: - Lucas signed-off ad

[PATCH v2 06/15] ASoC: cs42l42: Remove power if the driver is being removed

Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- Changes in v2: - Use PM functions to shutdown the codec - Disable IRQ before pm_suspend sound/soc/codecs/cs42l42.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound

[PATCH v2 03/15] ASoC: cs42l42: Fix mixer volume control

The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 4f9ad95479292

[PATCH v2 02/15] ASoC: cs42l42: Fix channel width support

Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1 - 2 files changed, 22

[PATCH 12/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

From: Richard Fitzgerald There must be a delay of at least 150us after writing SCLK_PRESENT before issuing another I2C write. This is done using struct reg_sequence because it can specify a delay after the write and the whole sequence is written atomically. Signed-off-by: Richard Fitzgerald

[PATCH 04/15] ASoC: cs42l42: Disable regulators if probe fails

In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 00e303c711ddc

[PATCH 14/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.c

[PATCH 09/15] ASoC: cs42l42: Add Capture Support

Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs

[PATCH 07/15] ASoC: cs42l42: Set clock source for both ways of stream

Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 85 +- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 48 insertions(+), 38 deletions(-) diff --git

[PATCH 13/15] ASoC: cs42l42: Only start PLL if it is needed

From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs42l42.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 08/15] ASoC: cs42l42: Fix channel width support

Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1 - 2 files changed, 22 insertions(+), 26 deletions(-) diff

[PATCH 11/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 14 insertions(+), 4

[PATCH 10/15] ASoC: cs42l42: Report jack and button detection

Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 142 + sound

[PATCH 06/15] ASoC: cs42l42: Provide finer control on playback path

Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 65 +- sound/soc/codecs/cs42l42.h | 8 ++--- 2 files changed, 26 insertions

[PATCH 03/15] ASoC: cs42l42: Remove power if the driver is being removed

Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 2a25a30f842b1..00e303c711ddc 100644 --- a/sound/soc

[PATCH 15/15] ASoC: cs42l42: Fix mixer volume control

The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 96f4e98ceaa0b..39f742a83cd2c 100644 --- a/sound

[PATCH 02/15] ASoC: cs42l42: Always wait at least 3ms after reset

This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 05/15] ASoC: cs42l42: Fix Bitclock polarity inversion

The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 20 sound/soc/codecs/cs42l42.h | 11 ++- 2

[PATCH 01/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 210fcbedf2413

[PATCH 00/15] Report jack and button detection + Capture Support

Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Don't enable/disable regulator at Bias Level ASoC: cs42l42: Always wait

[PATCH] USB: apple-mfi-fastcharge: Fix kfree after failed kzalloc

kfree don't need to be called after a failed kzalloc Signed-off-by: Lucas Tanure --- Follow up patch from "USB: apple-mfi-fastcharge: Use devm_kzalloc and simplify the code" drivers/usb/misc/apple-mfi-fastcharge.c | 15 --- 1 file changed, 4 insertions(+), 11 deletion

Re: [PATCH] USB: apple-mfi-fastcharge: Use devm_kzalloc and simplify the code

On Sat, Nov 14, 2020 at 3:03 PM Greg Kroah-Hartman wrote: > > On Sat, Nov 14, 2020 at 02:17:48PM +, Lucas Tanure wrote: > > On Sat, Nov 14, 2020 at 12:56 PM Greg Kroah-Hartman > > wrote: > > > > > > On Sat, Nov 14, 2020 at 12:42:49PM +, Lucas Tanure

Re: [PATCH] USB: apple-mfi-fastcharge: Use devm_kzalloc and simplify the code

On Sat, Nov 14, 2020 at 12:56 PM Greg Kroah-Hartman wrote: > > On Sat, Nov 14, 2020 at 12:42:49PM +, Lucas Tanure wrote: > > Signed-off-by: Lucas Tanure > > I can't take patches without any changelog text, sorry. > > > --- > > drivers/usb

[PATCH] USB: apple-mfi-fastcharge: Use devm_kzalloc and simplify the code

Signed-off-by: Lucas Tanure --- drivers/usb/misc/apple-mfi-fastcharge.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c index 9de0171b5177..de86e389a008 100644 --- a/drivers

[PATCH] regmap: Fix order of regmap write log

_regmap_write can trigger a _regmap_select_page, which will call another _regmap_write that will be executed first, but the log shows the inverse order Also, keep consistency with _regmap_read which only logs in case of success Signed-off-by: Lucas Tanure --- drivers/base/regmap/regmap.c | 11

Re: Question about mfd_add_devices and platform_data

Hi Lee, Can you help me with this question? Thanks Lucas On Mon, Aug 5, 2019 at 2:43 PM Lucas Tanure wrote: > > Hi, > > I would like to understand mfd_add_devices call and platform_data section. > An mfd device can have platform_data, which is kmemdup at > platform_de

Question about mfd_add_devices and platform_data

Hi, I would like to understand mfd_add_devices call and platform_data section. An mfd device can have platform_data, which is kmemdup at platform_device_add_data from platform_device_add_data call inside mfd_add_device. And after this kmemdup the new mfd device receives the clone memory and the

[PATCH 2/2] regmap: debugfs: Jump to the next readable register

Improve the speed of the loop jumping to the next available register Signed-off-by: Lucas Tanure --- drivers/base/regmap/regmap-debugfs.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap

[PATCH 1/2] regmap: debugfs: Replace code by already existing function

Signed-off-by: Lucas Tanure --- drivers/base/regmap/regmap-debugfs.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index 6d3dc1429ae57..9b3f49ffc4a5f 100644 --- a/drivers/base/regmap/regmap

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 4:26 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: >> On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: >> > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: >> > > On 30.01, Lucas Tanur

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > On 30.01, Lucas Tanure wrote: >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > You might have noticed we have literally hundreds of them spread over 100 > files in the netfilt

[PATCH 2/4] netfilter: ipv4: EXPORT_SYMBOL should be shortly thereafter the exported function

change made to resolve following checkpatch message: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Lucas Tanure --- net/ipv4/netfilter/ip_tables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/netfilter

[PATCH 4/4] netfilter: ipv4: spaces preferred around operators

Fix the checkpatch.pl issues: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Lucas Tanure --- net/ipv4/netfilter/i

[PATCH 3/4] netfilter: ipv4: use preferred kernel types

As suggested by checkpatch.pl: CHECK: Prefer kernel type 'uX' over 'uintX_t' Signed-off-by: Lucas Tanure --- net/ipv4/netfilter/ip_tables.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index 79d4a04

[PATCH 1/4] netfilter: ipv4: use linux/uaccess.h

Fix checkpatch warning WARNING: Use #include instead of Signed-off-by: Lucas Tanure --- net/ipv4/netfilter/ip_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index b99affa..aa0e41e 100644 --- a/net

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 4:26 PM, Joe Perches <j...@perches.com> wrote: > On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: >> On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: >> > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy <ka...@trash.net> wrote:

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy <ka...@trash.net> wrote: > On 30.01, Lucas Tanure wrote: >> As suggested by checkpatch.pl: >> CHECK: Prefer kernel type 'uX' over 'uintX_t' > > You might have noticed we have literally hundreds of them spread over 100 &g

[PATCH 2/4] netfilter: ipv4: EXPORT_SYMBOL should be shortly thereafter the exported function

change made to resolve following checkpatch message: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Lucas Tanure <tan...@linux.com> --- net/ipv4/netfilter/ip_tables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ne

[PATCH 4/4] netfilter: ipv4: spaces preferred around operators

Fix the checkpatch.pl issues: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Lucas Tanure <tan...@linux.com&g

[PATCH 3/4] netfilter: ipv4: use preferred kernel types

As suggested by checkpatch.pl: CHECK: Prefer kernel type 'uX' over 'uintX_t' Signed-off-by: Lucas Tanure <tan...@linux.com> --- net/ipv4/netfilter/ip_tables.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_ta

[PATCH 1/4] netfilter: ipv4: use linux/uaccess.h

Fix checkpatch warning WARNING: Use #include instead of Signed-off-by: Lucas Tanure <tan...@linux.com> --- net/ipv4/netfilter/ip_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index b99affa..a

Re: [PATCH] iio: ltr501: Use a signed return type for ltr501_match_samp_freq

ed int and get the value by reference in the parameters. > > ok, or just change the return type to int w/o adding a new pointer > argument? Yeah, you explained better. =p Do you need me to resend ? Thanks! > >> Done with the help of Coccinelle. >> >> Sign

[PATCH] iio: ltr501: Use a signed return type for ltr501_match_samp_freq

The return type "unsigned int" was used by the ltr501_match_samp_freq function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get the value by reference in the parameters. Done with the help of Coccinelle. Signed-off-by: Lu

[PATCH] iio: ltr501: Use a signed return type for ltr501_match_samp_freq

The return type "unsigned int" was used by the ltr501_match_samp_freq function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get the value by reference in the parameters. Done with the help of Coccinelle. Signed-off-by: Lucas T

Re: [PATCH] iio: ltr501: Use a signed return type for ltr501_match_samp_freq

. >> So, change to signed int and get the value by reference in the parameters. > > ok, or just change the return type to int w/o adding a new pointer > argument? Yeah, you explained better. =p Do you need me to resend ? Thanks! > >> Done with the help of Coccinelle. >> &

[PATCH] stm class: Use a signed return type for stm_find_master_chan

The return type "unsigned int" was used by the stm_find_master_chan function despite of the aspect that it will eventually return a negative error code. Done with the help of Coccinelle. Signed-off-by: Lucas Tanure --- drivers/hwtracing/stm/core.c | 4 ++-- 1 file changed, 2 insert

[PATCH] ALSA: bebob: Use a signed return type for get_formation_index

The return type "unsigned int" was used by the get_formation_index function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get index by reference in the parameters. Done with the help of Coccinelle. Signed-off-by: Lucas Tanure

[PATCH] ASoC: wm2000: Use a signed return type for regmap_read

The return type "unsigned int" was used by the regmap_read() function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get reg by reference in the parameters Signed-off-by: Lucas Tanure --- sound/soc/codecs/wm2

[PATCH] ALSA: bebob: Use a signed return type for get_formation_index

The return type "unsigned int" was used by the get_formation_index function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get index by reference in the parameters. Done with the help of Coccinelle. Signed-off-by: Lucas T

[PATCH] ASoC: wm2000: Use a signed return type for regmap_read

The return type "unsigned int" was used by the regmap_read() function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get reg by reference in the parameters Signed-off-by: Lucas Tanure <tan...@linux.com> --- sound/soc/code

[PATCH] stm class: Use a signed return type for stm_find_master_chan

The return type "unsigned int" was used by the stm_find_master_chan function despite of the aspect that it will eventually return a negative error code. Done with the help of Coccinelle. Signed-off-by: Lucas Tanure <tan...@linux.com> --- drivers/hwtracing/stm/core.c | 4 ++-- 1

[PATCH] Staging: comedi: s626: Remove unnecessary cast on void pointer

The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by: Lucas Tanure --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/s626.c b

[PATCH] Staging: comedi: s626: Remove unnecessary cast on void pointer

The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by: Lucas Tanure <tan...@linux.com> --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/

[PATCH] drivers: net: ethernet: intel: i40e: Fix missing uapi/linux/dcbnl.h include in i40e_fcoe.c

Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel

[PATCH] drivers: net: ethernet: intel: i40e: Fix missing uapi/linux/dcbnl.h include in i40e_fcoe.c

Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers

Re: Eudyptula Challenge (Task 10)

Hi Christoph, What kind of things that you think a newbie can fix ? Thanks -- Lucas Tanure +55 (19) 988176559 On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig wrote: > Can you folks please stop this challenge Bullshit? More checkpatch > fixes is not something we'll need at all. >

Re: Eudyptula Challenge (Task 10)

Hi Christoph, What kind of things that you think a newbie can fix ? Thanks -- Lucas Tanure +55 (19) 988176559 On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig h...@infradead.org wrote: Can you folks please stop this challenge Bullshit? More checkpatch fixes is not something we'll need

[PATCH] powerpc: fix wrong defintion in boot/io.h

Fix wrong __IO_H definition in boot/io.h Reported-by: Fernando Silveira Signed-off-by: Lucas Tanure --- arch/powerpc/boot/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/io.h b/arch/powerpc/boot/io.h index 7c09f48..394da55 100644 --- a/arch/powerpc

[PATCH] powerpc: fix wrong defintion in boot/io.h

Fix wrong __IO_H definition in boot/io.h Reported-by: Fernando Silveira fsilve...@gmail.com Signed-off-by: Lucas Tanure tan...@linux.com --- arch/powerpc/boot/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/io.h b/arch/powerpc/boot/io.h index 7c09f48

[PATCH] staging: android: Clean up else statement from sync_fence_poll()

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure --- drivers/staging/android/sync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index c9a0c2c..e7b2e02 100644

Re: [PATCH v4] staging: android: Clean up else statement from binder_send_failed_reply

Hi, This patch got accepted ? Thanks -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 9:31 PM, Lucas Tanure wrote: > Kernel coding style. Remove useless else statement after return. > Changes from v1 and v2: Fix warning for mixed declarations and code. > Declaration o

Re: [PATCH] NoMoreModuleVmalloc - Try alloc_pages_exact before vmalloc, if fails do vmalloc

Hi Russell, I found that project http://kernelnewbies.org/KernelProjects/NoMoreModuleVmalloc. So I thought that doing first a alloc_pages_exact would be the goal. The kernel/module.c doesn't need this task any more, or I just did in the wrong way ? Thanks -- Lucas Tanure +55 (19) 988176559

Re: [PATCH] NoMoreModuleVmalloc - Try alloc_pages_exact before vmalloc, if fails do vmalloc

Hi Russell, I found that project http://kernelnewbies.org/KernelProjects/NoMoreModuleVmalloc. So I thought that doing first a alloc_pages_exact would be the goal. The kernel/module.c doesn't need this task any more, or I just did in the wrong way ? Thanks -- Lucas Tanure +55 (19) 988176559

Re: [PATCH v4] staging: android: Clean up else statement from binder_send_failed_reply

Hi, This patch got accepted ? Thanks -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 9:31 PM, Lucas Tanure tan...@linux.com wrote: Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration

[PATCH] staging: android: Clean up else statement from sync_fence_poll()

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/staging/android/sync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index c9a0c2c

Re: [PATCH v3] staging: android: Clean up else statement from binder_send_failed_reply

Ok. I will do it. 4th could be the right one =p. Thanks for your time Cheers -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 9:13 PM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 08:25:13PM -0300, Lucas Tanure wrote: >> Kernel coding style. Remove useless else

[PATCH v4] staging: android: Clean up else statement from binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration of "struct binder_transaction *next" made outside of while. Changes from v3: Removed initialization to NULL for next variable. Signed-off

[PATCH v3] staging: android: Clean up else statement from binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration of "struct binder_transaction *next" made outside of while, and initialized with NULL. Signed-off-by: Lucas Tanure --- drivers/stagi

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Sorry, I didn't know. I will fix. Thanks -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 4:07 PM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote: >> Kernel coding style. Remove useless else statement after return. >> >>

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

I missed on trailing whitespace in first patch. Didn't saw a ERROR: trailing whitespace in the first patch. Sorry, Thanks -- Lucas Tanure +55 (19) 988176559 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

[RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure --- drivers/staging/android/binder.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c

[PATCH] staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure --- drivers/staging/android/binder.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c

  1   2   >