Re: [PATCH 3/3] pinctrl: at91-pio4: fix "Prefer 'unsigned int' to bare use of 'unsigned'"

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:14PM +0200, Claudiu Beznea wrote: > Fix "Prefer 'unsigned int' to bare use of 'unsigned'" checkpatch.pl > warning. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > ---

Re: [PATCH 2/3] pinctrl: at91-pio4: add support for slew-rate

2021-01-27 Thread Ludovic Desroches
banks; > unsigned last_bank_count; > + unsigned int sr; Hi Claudiu, Nitpicking: I tend to prefer a verbose name as slew_rate or even slew_rate_support. Otherwise, Acked-by: Ludovic Desroches Regards Ludovic > }; > > struct atmel_group { > @@ -117,6 +120,7 @@ s

Re: [PATCH 1/3] dt-bindings: pinctrl: at91-pio4: add slew-rate

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:12PM +0200, Claudiu Beznea wrote: > Document slew-rate DT binding for SAMA7G5. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > --- > .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 8 > +--- &g

Re: [PATCH] mmc: Assign boolean values to a bool variable

2021-01-21 Thread Ludovic Desroches
0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 46 > ++-- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --

Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank

2020-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2020 at 09:31:36AM +0100, Linus Walleij wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Nov 13, 2020 at 2:25 PM Eugen Hristev > wrote: > > > Some products, like sama7g5, do not have a full last bank of PIO lines.

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
On Wed, Nov 18, 2020 at 04:26:52PM +0100, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello, > > On 18/11/2020 16:03:36+0100, Ludovic Desroches wrote: > > At first glance, there is no trivial

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
g pincontrol > configuration. The patch was tested on SAM9x60EK, SAMA5D4-EK and SAMA5D3-EK. > No problem on my side with this set of patches, it's consistent with what we have. Acked-by: Ludovic Desroches I just want to share the full picture leading to this situation. You told me the brea

Re: [PATCH 0/9] iio: adc: at91_adc: cleanup DT bindings

2020-11-15 Thread Ludovic Desroches
options and names and the triggers description > back in the driver. > > There are also other cleanups, like removing platform data support, this > was pending for a while. > Nice cleanup of this old and obscur binding. Reviewed-by: Ludovic Desroches Thanks. > Alexandre Bell

Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank

2020-11-15 Thread Ludovic Desroches
the actual 136, as this > product supports, and to avoid reading/writing to invalid register addresses. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 18 -- > 1 file changed, 16 inser

Re: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak

2020-09-22 Thread Ludovic Desroches
ludovic.desroc...@microchip.com, sta...@vger.kernel.org, > Greg KH > Subject: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak > > > This fixes memory leak in at_hdmac. Mainline does not have the same > problem. > > Signed-off-by: Pavel Machek (CIP) Acked-by: Ludovic Desroch

Re: [PATCH 1/2] dt-bindings: pinctrl: at91-pio4: add microchip,sama7g5

2020-09-20 Thread Ludovic Desroches
On Thu, Sep 17, 2020 at 04:12:56PM +0300, Eugen Hristev wrote: > Add compatible string for microchip sama7g5 SoC. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks Ludovic > --- > .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 4 +++- >

Re: [PATCH 2/2] pinctrl: at91-pio4: add support for sama7g5 SoC

2020-09-20 Thread Ludovic Desroches
On Thu, Sep 17, 2020 at 04:12:57PM +0300, Eugen Hristev wrote: > Add support for sama7g5 pinctrl block, which has 5 PIO banks. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks. Ludovic > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 7 +++ > 1 file cha

Re: [PATCH 05/10] gpio: gpio-sama5d2-piobu: Demote all kerneldoc headers to basic comment blocks

2020-07-01 Thread Ludovic Desroches
_output' > drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member > 'chip' not described in 'sama5d2_piobu_get' > drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member > 'pin' not described in 'sama5d2_p

Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver

2020-06-01 Thread Ludovic Desroches
when trying to apply a change for this. > > > > Signed-off-by: Alexandru Ardelean > Makes sense. Given this sort of change can expose weird an wonderful > dependencies that were previously hidden, I'll be wanting an > ack from at91 people. Agree. Acked-by: Ludovic De

Re: [PATCH] dmaengine: at_hdmac: Replace zero-length array with flexible-array

2020-05-10 Thread Ludovic Desroches
ions) will also > help to get completely rid of those sorts of issues. > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxg

Re: [PATCH] dmaengine: at_xdmac: Replace zero-length array with flexible-array

2020-05-10 Thread Ludovic Desroches
ions) will also > help to get completely rid of those sorts of issues. > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix

Re: [PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-18 Thread Ludovic Desroches
On Fri, Oct 18, 2019 at 12:56:14PM +0200, Ulf Hansson wrote: > On Fri, 11 Oct 2019 at 12:33, Ludovic Desroches > wrote: > > > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > &

Re: [PATCH 2/2] mmc: sdhci-of-at91: add DT property to enable calibration on full reset

2019-10-11 Thread Ludovic Desroches
d reduce > power consumption on some SAMA5D2 SiP revisions. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/mmc/host/s

[PATCH v2 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-10-11 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- Changes: -v2: none arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot

[PATCH v2 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-11 Thread Ludovic Desroches
clock which can take several rates. As we can't trust those values, take them from the clock tree and update the capabilities according to. As we can have the same pitfall, in some cases, with the SAMA5D2 Soc, stop relying on capabilities too. Signed-off-by: Ludovic Desroches --- Changes:

[PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-11 Thread Ludovic Desroches
There is a new compatible string for the SAM9X60 sdhci device. It involves an update of the properties about the clocks stuff. Signed-off-by: Ludovic Desroches --- Changes: - v2: remove the extra example and fix node label This patch conflicts with Nicolas' one: "dt-bindings: sdh

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 09, 2019 at 04:01:47PM +0200, Alexandre Belloni wrote: > > On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > > External E-Mail > > > > > > > > > Implement i2c

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > External E-Mail > > > Implement i2c bus recovery when slaves devices might hold SDA low. > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > until the slave release SDA. > Hi Kamel, Thanks for adding this n

Re: [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()

2019-10-09 Thread Ludovic Desroches
> Signed-off-by: Markus Elfring Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b58ac720d9a1..f71c9f77d405 100644 &

Re: [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-08 Thread Ludovic Desroches
On Mon, Sep 30, 2019 at 09:56:13AM -0500, Rob Herring wrote: > On Thu, Sep 12, 2019 at 10:09:06PM +0200, Ludovic Desroches wrote: > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > > >

Re: [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-08 Thread Ludovic Desroches
On Fri, Sep 20, 2019 at 11:34:50AM +0200, Eugen Hristev - M18282 wrote: > > > On 12.09.2019 23:09, Ludovic Desroches wrote: > > > > > In the SAM9x60 SoC, there are only two clocks instead of three for the > > SDHCI device. The base clk is no longer provided, it is

Re: [PATCH] pinctrl: at91-pio4: implement .get_multiple and .set_multiple

2019-09-14 Thread Ludovic Desroches
; > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Thanks for this improvement. You can keep my ack for v3 as the changes should be the commit message only. I'll be off for three weeks. Regards Ludovic > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 60 ++

Re: [PATCH v5 0/9] i2c: add support for filters

2019-09-14 Thread Ludovic Desroches
s is the result of the comments on the ML in the direction > requested: to make the bindings globally available for i2c drivers. > > Changes in v5: > - renamed i2c-filter-width-ns to i2c-digital-filter-width-ns as this > is applicable only to digital filter > - created new binding i2c-digit

Re: [PATCH] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-14 Thread Ludovic Desroches
ubotariu Acked-by: Ludovic Desroches I'll be off for three weeks so if there are minor changes, you can keep my ack. Thanks Ludovic > --- > drivers/i2c/busses/i2c-at91-master.c | 20 > drivers/i2c/busses/i2c-at91.h| 6 +- > 2 files chang

[PATCH 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-09-12 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch

[PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-09-12 Thread Ludovic Desroches
There is a new compatible string for the SAM9X60 sdhci device. It involves an update of the properties about the clocks stuff. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/mmc/sdhci-atmel.txt | 25 --- 1 file changed, 22 insertions(+), 3 deletions(-) diff

[PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-09-12 Thread Ludovic Desroches
clock which can take several rates. As we can't trust those values, take them from the clock tree and update the capabilities according to. As we can have the same pitfall, in some cases, with the SAMA5D2 Soc, stop relying on capabilities too. Signed-off-by: Ludovic Desroches --- drivers/mmc

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-12 Thread Ludovic Desroches
On Mon, Aug 12, 2019 at 03:38:34PM +, eugen.hris...@microchip.com wrote: > On 09.08.2019 09:23, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > >> On 8/08/19 3:42 PM, Ludovic Desroches wrote: > >>> On Thu, Aug 08, 2

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-09 Thread Ludovic Desroches
On Thu, Aug 08, 2019 at 05:23:00PM +0200, Ulf Hansson wrote: > On Thu, 8 Aug 2019 at 10:35, wrote: > > > > From: Eugen Hristev > > > > HS200 is not implemented in the driver, but the controller claims it > > through caps. > > Remove it via quirk. > > Without this quirk, the mmc core will try to e

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > On 8/08/19 3:42 PM, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 10:35:43AM +0200, Eugen Hristev - M18282 wrote: > >> From: Eugen Hristev > >> > >> Add mmc capabilities for SDMMC0 for this

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-08 Thread Ludovic Desroches
ll fail, > and the eMMC initialization will fail. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c > b/dri

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
Eugen Hristev Acked-by: Ludovic Desroches I am interested to have the some insights about the use of sd-uhs-* properties. Our IP can't deal with 1V8 by itself. It has a 1V8SEL signal which can be used as the logic control input of a mux. So even if the IP claims to support UHS modes, it depends

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-08-01 Thread Ludovic Desroches
On Wed, Jul 31, 2019 at 09:06:07AM -0700, Kees Cook wrote: > On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > >host->c

Re: [PATCH] crypto: atmel-sha204a: Use device-managed registration API

2019-07-31 Thread Ludovic Desroches
On Tue, Jul 23, 2019 at 03:19:36PM +0800, Chuhong Yuan wrote: > > Use devm_hwrng_register to get rid of manual > unregistration. > > Signed-off-by: Chuhong Yuan Acked-by: Ludovic Desroches Thanks > --- > drivers/crypto/atmel-sha204a.c | 3 +-- > 1 file changed, 1 i

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-31 Thread Ludovic Desroches
y: Gustavo A. R. Silva I don't know if there is a policy in the kernel about the expression to use. As this one does the job Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/

Re: [PATCH v3 0/9] i2c: add support for filters

2019-07-12 Thread Ludovic Desroches
2c-core-base.c| 2 + > include/linux/i2c.h | 2 + > 9 files changed, 121 insertions(+), 4 deletions(-) Hi, I don't know if it will fit other vendors need concerning the binding but for Microchip it sounds good. Acked-by: Ludovic Desroches for the whole serie. Regards Ludovic

Re: [PATCH] dmaengine: at_xdmac: check for non-empty xfers_list before invoking callback

2019-07-01 Thread Ludovic Desroches
On Sat, Jun 29, 2019 at 01:50:48PM +0530, Raag Jadav wrote: > > tx descriptor retrieved from an empty xfers_list may not have valid > pointers to the callback functions. > Avoid calling dmaengine_desc_get_callback_invoke if xfers_list is empty. > > Signed-off-by: Raag Jadav

Re: [PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

2019-06-12 Thread Ludovic Desroches
Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor > > loop") > > Signed-off-by: Codrin Ciubotariu > > Yes: > Acked-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks Ludovic > > Thanks for having fixed this Codrin. Best regards, >

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Mon, May 06, 2019 at 10:19:01AM +0200, Eugen Hristev - M18282 wrote: > > > On 04.05.2019 02:58, Raag Jadav wrote: > > > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > >> On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav w

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Sat, May 04, 2019 at 05:28:51AM +0530, Raag Jadav wrote: > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > > On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > > > External E-Mail > > > > > > > > > On Mon, Apr 29

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-02 Thread Ludovic Desroches
On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > External E-Mail > > > On Mon, Apr 29, 2019 at 11:00:05AM +0200, Ludovic Desroches wrote: > > Hello Raag, > > > > On Tue, Apr 23, 2019 at 01:06:48PM +0530, Raag Jadav wrote: > > > External E-

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-04-29 Thread Ludovic Desroches
Hello Raag, On Tue, Apr 23, 2019 at 01:06:48PM +0530, Raag Jadav wrote: > External E-Mail > > > Performing i2c write operation while SDA or SCL line is held > or grounded by slave device, we go into infinite at91_twi_write_next_byte > loop with TXRDY interrupt spam. Sorry but I am not sure to h

Re: linux-next: build failure after merge of the at91 tree

2019-04-23 Thread Ludovic Desroches
On Tue, Apr 23, 2019 at 01:27:52PM +0900, Masahiro Yamada wrote: > External E-Mail > > > On Tue, Apr 23, 2019 at 10:33 AM Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the at91 tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > arch/arm/mach-

Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91

2019-04-19 Thread Ludovic Desroches
On Mon, Apr 15, 2019 at 05:14:50PM +0200, Alexandre Belloni wrote: > External E-Mail > > > On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote: > > is only generated and included > > by arch/arm/mach-at91/, so it does not need to reside in the > > globally visible include/generated/. > > > > I m

Re: [PATCH v2 1/4] ARM: dts: sama5d{2,4}: use SPDX-License-Identifier

2019-04-08 Thread Ludovic Desroches
@ -1,46 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > /* > * sama5d2.dtsi - Device Tree Include file for SAMA5D2 family SoC > * > * Copyright (C) 2015 Atmel, > *2015 Ludovic Desroches > - * > - * This file is dual-licensed: you can use it eit

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-04-08 Thread Ludovic Desroches
On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > SAMA5 devices use the newer DRM driver for LCD. They don't need > the older FB driver: remove the Kconfig option for them. > > Signed-off-by: Nicolas Ferre Applied to at91-defconfig. Thanks. > --- > arch/arm/mach-at91/Kconfig |

Re: linux-next: manual merge of the at91 tree with the at91-fixes tree

2019-04-05 Thread Ludovic Desroches
Hi Stephen, On Fri, Apr 05, 2019 at 09:15:19AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the at91 tree got a conflict in: > > arch/arm/mach-at91/pm.c > > between commit: > > ba5e60c9b75d ("arm/mach-at91/pm : fix possible object reference leak") > > from the

Re: [PATCH v4] arm/mach-at91/pm : fix possible object reference leak

2019-04-04 Thread Ludovic Desroches
On Tue, Apr 02, 2019 at 10:12:38PM +0800, Peng Hao wrote: > > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device. When returning error we should > call put_device. > > Reviewed-by: Mukesh Ojha > Signed-off-by: Peng Hao Thanks applied to at91-

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-03-29 Thread Ludovic Desroches
On Fri, Mar 29, 2019 at 02:05:38PM +0100, Ludovic Desroches wrote: > On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > > SAMA5 devices use the newer DRM driver for LCD. They don't need > > the older FB driver: remove the Kconfig option for them. > > > &

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-03-29 Thread Ludovic Desroches
On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > SAMA5 devices use the newer DRM driver for LCD. They don't need > the older FB driver: remove the Kconfig option for them. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches CONFIG_FB_ATMEL shoul

Re: [PATCH] arm/mach-at91/pm : fix possible object reference leak

2019-03-29 Thread Ludovic Desroches
Hi, On Wed, Feb 13, 2019 at 10:55:46PM +0800, Peng Hao wrote: > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device. When returning error we should > call put_device. > > Signed-off-by: Peng Hao > --- > arch/arm/mach-at91/pm.c | 1 + > 1 file c

Re: [PATCH] iio: adc: at91: disable adc channel interrupt in timeout case

2019-02-22 Thread Ludovic Desroches
ld like to > prepare a pull request concerning the 2nd Issue. For the 3rd and the 4th > Issue I would like to hear your opinion if our modifications are sound before > I will write an pull request. > > Thanks for your time, > Best wishes, > Georg Ottinger > > -

Re: [PATCH] iio: adc: at91: disable adc channel interrupt in timeout case

2019-02-22 Thread Ludovic Desroches
are queried we can end up with a > situation where two interrupts are enabled, but only one interrupt is > cleared in the interrupt handler. Resulting in a interrupt loop and a > system hang. > > Signed-off-by: Georg Ottinger Acked-by: Ludovic Desroches Thanks > --- &

[PATCH v5 1/3] i2c: at91: segregate master mode specific code from probe and init func

2019-02-22 Thread Ludovic Desroches
shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 +-- 1 file changed, 55 insertions(+), 35 deletions

[PATCH v5 0/3] i2c: at91: slave mode support

2019-02-22 Thread Ludovic Desroches
[Ludovic Desroches: see Changes section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can be

[PATCH v5 2/3] i2c: at91: split driver into core and master file

2019-02-22 Thread Ludovic Desroches
only had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors and use SPDX] Signed-off-by: Ludovic Desroches --- MAINTAINERS | 3 +- drivers/i2c/busses/Mak

[PATCH v5 3/3] i2c: at91: added slave mode support

2019-02-22 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: rework Kconfig and replace IS_ENABLED by defined] Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Kconfig | 13

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-02-19 Thread Ludovic Desroches
Hi, On Fri, Feb 15, 2019 at 10:18:47AM +0100, Wolfram Sang wrote: > On Tue, Jan 15, 2019 at 11:43:51PM +0100, Wolfram Sang wrote: > > > > > All errors (new ones prefixed by >>): > > > > > > >> ERROR: "at91_init_twi_bus_slave" [drivers/i2c/busses/i2c-at91.ko] > > > >> undefined! > > > >> ERROR:

Re: [PATCH v2 1/7] pinctrl: at91: add option to use drive strength bits

2019-02-06 Thread Ludovic Desroches
On Wed, Feb 06, 2019 at 09:46:28AM +, claudiu.bez...@microchip.com wrote: > > > On 06.02.2019 10:13, Ludovic Desroches wrote: > > On Thu, Jan 31, 2019 at 05:18:04PM +0100, Claudiu Beznea - M18063 wrote: > >> From: Claudiu Beznea > >> > >> SAM

Re: [PATCH v2 0/7] add support for SAM9X60 pin controller

2019-02-06 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 05:18:00PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea Minor comment for patch 1. Acked-by: Ludovic Desroches for the whole series. > > This series adds drive strenght and slew rate support for SAMX60's pin > controller. For drive

Re: [PATCH v2 1/7] pinctrl: at91: add option to use drive strength bits

2019-02-06 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 05:18:04PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > SAM9X60 uses high and low drive strengths. To implement this, in > at91_pinctrl_mux_ops::set_drivestrength and > at91_pinctrl_mux_ops::get_drivestrength we need bit numbers of > drive strengths (1

Re: [PATCH 3/3] dmaengine: at_xdmac: only monitor overflow errors for peripheral xfer

2019-02-05 Thread Ludovic Desroches
> request signal. > > Remove the use of this interrupt source in such a case. It's based on > the first descriptor which holds the configuration for the whole > linked list transfer. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > drivers/dm

Re: [PATCH 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-02-05 Thread Ludovic Desroches
On Tue, Feb 05, 2019 at 12:03:42PM +0100, Nicolas Ferre wrote: > Complement the identification of errors with stoping the channel and > dumping the descriptor that led to the error case. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > drivers/d

Re: [PATCH 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-02-05 Thread Ludovic Desroches
d > just finish the tasklet call. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index fe6

Re: [PATCH 5/7] dt-bindings: add bindings for SAM9X60

2019-01-31 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 01:29:40PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add device tree binding for SAM9X60 pin controller. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt | 5 +++-- > 1 file changed, 3 inse

Re: [PATCH 3/7] pinctrl: at91: add compatibles for SAM9X60 pin controller

2019-01-31 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 01:29:33PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add compatibles for SAM9X60 pin controller. > > Signed-off-by: Claudiu Beznea > --- > drivers/pinctrl/pinctrl-at91.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/p

Re: [PATCH] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-22 Thread Ludovic Desroches
gt; > Signed-off-by: Codrin Ciubotariu Acked-by: Ludovic Desroches As Vinod suggested, you may change the commit message to emphasize that the bug comes from the fact that a single variable is used to store different information. The Fixes: tag should be added too. Regards Lud

[PATCH v4 3/3] i2c: at91: added slave mode support

2018-12-27 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: rework Kconfig] Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Kconfig | 13 +++ drivers/i2c/busses/Makefile

[PATCH v4 2/3] i2c: at91: split driver into core and master file

2018-12-27 Thread Ludovic Desroches
only had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors] Signed-off-by: Ludovic Desroches --- MAINTAINERS | 3 +- drivers/i2c/busses/Mak

[PATCH v4 1/3] i2c: at91: segregate master mode specific code from probe and init func

2018-12-27 Thread Ludovic Desroches
shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 +-- 1 file changed, 55 insertions(+), 35 deletions

[PATCH v4 0/3] i2c: at91: slave mode support

2018-12-27 Thread Ludovic Desroches
[Ludovic Desroches: see Changes section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can be

Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD

2018-12-24 Thread Ludovic Desroches
c: new driver for the Atmel AHB DMA > Controller") > Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control") > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches Thanks > > --- > Successfully 0-day tested on 151 configurations. > > d

Re: [PATCH v3 0/3] i2c: at91: slave mode support

2018-12-21 Thread Ludovic Desroches
Hi Wolfram, On Tue, Dec 11, 2018 at 08:28:05PM +0100, Wolfram Sang wrote: > Hi Ludovic, > > > > > - fix checkpatch errors > > > > - tests: > > > >- hangs with a SAMA5D4 (master and slave on different busses) after > > > > about > > > >100 transfers. It's the firs time I do this test. >

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: add QSPI0 + SPI NOR memory nodes

2018-12-11 Thread Ludovic Desroches
On Tue, Dec 11, 2018 at 03:35:45PM +0100, Alexandre Belloni wrote: > On 11/12/2018 12:32:40+, tudor.amba...@microchip.com wrote: > > Hi, Alexandre, > > > > On 12/10/2018 11:35 PM, Alexandre Belloni wrote: > > > Hi, > > > > > > On 10/12/2018 17:15:29+, tudor.amba...@microchip.com wrote: >

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: add QSPI0 + SPI NOR memory nodes

2018-12-11 Thread Ludovic Desroches
On Tue, Dec 11, 2018 at 03:40:33PM +0100, Boris Brezillon wrote: > On Mon, 10 Dec 2018 17:15:29 + > wrote: > > > From: Cyrille Pitchen > > > > This patch configures the QSPI0 controller pin muxing and declares > > a jedec,spi-nor memory. > > > > sama5d2 Xplained RevB and RevC use the Macro

Re: [PATCH] dmaengine: at_hdmac: fix module unloading

2018-11-29 Thread Ludovic Desroches
dmac] > when of_dma_request_slave_channel() tried to call ofdma->of_dma_xlate(). > > Cc: sta...@vger.kernel.org > Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") > Signed-off-by: Richard Genoud Acked-by: Ludovic Desroches Thanks Ludovic > --- > d

Re: [PATCH] dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

2018-11-29 Thread Ludovic Desroches
; Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") > Reported-by: Mario Forner > Suggested-by: Alexandre Belloni > Acked-by: Alexandre Belloni > Signed-off-by: Richard Genoud Acked-by: Ludovic Desroches Thanks for handling this issue. Ludovic > --- > driv

Re: [PATCH v3 2/7] ARM: dts: at91: sama5d2: switch to new binding

2018-11-13 Thread Ludovic Desroches
clock is missing in the title of this patch. Regards Ludovic On Mon, Nov 12, 2018 at 02:31:03PM +0100, Alexandre Belloni wrote: > Switch sama5d2 boards to the new PMC clock bindings. > > Signed-off-by: Alexandre Belloni > --- > arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 12 +- > arch/arm/

Re: [PATCH] i2c: at91: switched to resume/suspend callbacks.

2018-11-07 Thread Ludovic Desroches
why we use the _noirq variant. When patches for PM stuff were sent, suspend/resume callbacks were used but in the latest version it moved to the _noirq variant without explanation. Excepting if someone has an argument to keep the _noirq variant, Acked-by: Ludovic Desroches Thanks Regards Ludovic >

Re: sama5d: using the ebi interface from another driver

2018-11-05 Thread Ludovic Desroches
Hi Jean-Michel, On Fri, Nov 02, 2018 at 02:35:26PM +0100, Jean-Michel Hautbois wrote: > Hi all, > > I have a custom board based on a sama5d3 chip. The SoC is connected to > 2 pef24628 SHDSL transceivers, the first one on ebi@4000 and the > second one on ebi@5000. > I tried to write a basi

Re: [RESEND PATCH 1/2] i2c: enable buses to save their clock frequency in adapter

2018-10-29 Thread Ludovic Desroches
their clock frequency in adapter. > > Signed-off-by: Tudor Ambarus Reviwed-by: Ludovic Desroches > --- > include/linux/i2c.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 65b4eaed1d96..f238da204c49 100644 > ---

[GIT PULL] ARM: at91: DT for 4.20 #2

2018-10-03 Thread Ludovic Desroches
Arnd, Olof, Here are the second round of DT changes for 4.20. It consists in NAND description fixes (size and partitions). Regards Ludovic The following changes since commit 97181516b0785dd032700ae4899842389c6bea78: arm: dts: sama5d2: Update coresight bindings for hardware ports (2018-09-19

Re: [PATCH 2/2] ARM: dts: at91: at91sam9x5cm: fix addressable nand flash size

2018-10-02 Thread Ludovic Desroches
On Tue, Oct 02, 2018 at 02:29:49PM +0300, Tudor Ambarus wrote: > at91sam9x5cm comes with a 2Gb NAND flash. Fix the rootfs size to > match this limit. > > Signed-off-by: Tudor Ambarus Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91sam9x5cm.dtsi | 2 +- &g

Re: [PATCH 1/2] ARM: dts: at91: sama5d4_xplained: fix addresable nand flash size

2018-10-02 Thread Ludovic Desroches
On Tue, Oct 02, 2018 at 02:29:48PM +0300, Tudor Ambarus wrote: > sama5d4_xplained comes with a 4Gb NAND flash. Increase the rootfs > size to match this limit. > > Signed-off-by: Tudor Ambarus Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91-sama5d4_xplain

[PATCH v5 2/2] tty/serial: atmel: add ISO7816 support

2018-09-26 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches Acked-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 190 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 181 insertions(+), 12 deletions(-) diff --git a

[PATCH v5 1/2] tty/serial_core: add ISO7816 infrastructure

2018-09-26 Thread Ludovic Desroches
-off-by: Ludovic Desroches --- Documentation/serial/serial-iso7816.txt | 83 + arch/alpha/include/uapi/asm/ioctls.h| 2 + arch/mips/include/uapi/asm/ioctls.h | 2 + arch/parisc/include/uapi/asm/ioctls.h | 2 + arch/powerpc/include/uapi/asm/ioctls.h | 2

[PATCH v5 0/2] add ISO7816 support

2018-09-26 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v5 - rebase on tty-next. - add documentation for the new ioctls (mimic rs485 one). - fix

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 18, 2018 at 03:28:56PM +0200, Greg KH wrote: > On Thu, Sep 06, 2018 at 03:42:14PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for coming back to this mode if requ

Re: [GIT PULL] ARM: at91: SoC for 4.20

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 25, 2018 at 01:38:12PM -0700, Olof Johansson wrote: > On Tue, Sep 25, 2018 at 12:37:35PM +0200, Alexandre Belloni wrote: > > Arnd, Olof, > > > > Most changes are shuffling around the maintainers entries. There are > > also two PM non urgent fixes. > > > > This one as a trivial conflic

Re: [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode

2018-09-25 Thread Ludovic Desroches
annel. > > Fixes 0e589d5fb "ARM: AT91: IIO: Add AT91 ADC driver." > Cc: Maxime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v2: > - Added 'const' spec to the declaration to avoid build warning > > drivers/

Re: [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions

2018-09-25 Thread Ludovic Desroches
ime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Hello Jonathan, > > I moved this LCDR read/acknowledge into the IRQ handler after the conversion > value is being read. > Sorry about the noise to stable@vger, removed from message. > > Than

[PATCH] pinctrl: at91: don't use the same irqchip with multiple gpiochips

2018-09-13 Thread Ludovic Desroches
Sharing the same irqchip with multiple gpiochips is not a good practice. For instance, when installing hooks, we change the state of the irqchip. The initial state of the irqchip for the second gpiochip to register is then disrupted. Signed-off-by: Ludovic Desroches --- Hi, This patch fixes the

Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards

2018-09-07 Thread Ludovic Desroches
ing it for all peripherals: trng, aes, tdes and sha are still missing a label. Otherwise Acked-by: Ludovic Desroches Regards Ludovic > > Based on top of at91-next branch of at91.git > > Thanks. > > arch/arm/boot/dts/sama5d4.dtsi | 8 > 1 file changed, 4 insertions(+

[PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl

2018-09-07 Thread Ludovic Desroches
The drive strength has to be set to medium otherwise some data corruption may happen. Signed-off-by: Ludovic Desroches --- Hi, This fix depends on the support of the drive-strength for the atmel pio4 pinctroller. It has been added in v4.19 but I omitted to send it at the same time. Ludovic

[PATCH v4 0/2] add ISO7816 support

2018-09-06 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v4 - use the IP version number instead of the compatible string to set min and max values

  1   2   3   4   5   6   7   >