Re: [PATCH v3 19/25] media: i2c: imx258: Change register settings for variants of the sensor

2024-04-04 Thread Luigi311
On 4/3/24 10:18, Sakari Ailus wrote: > Hi Luis, Dave, > > On Wed, Apr 03, 2024 at 09:03:48AM -0600, g...@luigi311.com wrote: >> From: Dave Stevenson >> >> Sony have advised that there are variants of the IMX258 sensor which >> require slightly different regis

Re: [PATCH v3 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour

2024-04-04 Thread Luigi311
On 4/3/24 12:48, Pavel Machek wrote: > Hi! > >> The sensor supports the clock lane either remaining in HS mode >> during frame blanking, or dropping to LP11. >> >> Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK. > >> +ret = imx258_write_reg(imx258, IMX258_CLK_BLANK_STOP,

Re: [PATCH v3 24/25] drivers: media: i2c: imx258: Add support for reset gpio

2024-04-03 Thread Luigi311
On 4/3/24 11:03, Ondřej Jirman wrote: > Hi, > > On Wed, Apr 03, 2024 at 04:28:59PM GMT, Sakari Ailus wrote: >> Hi Luis, >> >> Could you unify the subject prefix for the driver patches, please? E.g. >> "media: imx258: " would be fine. >> >>

Re: [PATCH v3 23/25] drivers: media: i2c: imx258: Add support for powerdown gpio

2024-04-03 Thread Luigi311
On 4/3/24 10:57, Ondřej Jirman wrote: > Hi Sakari and Luis, > > On Wed, Apr 03, 2024 at 04:25:41PM GMT, Sakari Ailus wrote: >> Hi Luis, Ondrej, >> >> On Wed, Apr 03, 2024 at 09:03:52AM -0600, g...@luigi311.com wrote: >>> From: Luis Garcia >>> &g

Re: [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-03 Thread Luigi311
On 4/3/24 12:49, Pavel Machek wrote: > Hi! > >> From: Luis Garcia >> >> Add powerdown-gpio binding as it is required for some boards > > "." at end of sentence. > >> Signed-off-by: Ondrej Jirman >> Signed-off-by: Luis Garcia > > If the patch is from Ondrej, he should be in From:, I believe.

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-03 Thread Luigi311
On 4/3/24 10:23, Sakari Ailus wrote: > Hi Luis, > > On Wed, Apr 03, 2024 at 09:03:50AM -0600, g...@luigi311.com wrote: >> From: Luis Garcia >> >> Use understandable macros instead of raw values. >> >> Signed-off-by: Ondrej Jirman >> Signed-off-