On Wed, Apr 29, 2020 at 11:50:34AM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 07:46:27AM +0000, Luis Chamberlain wrote:
> > Be pedantic on removal as well and hold the mutex.
> > This should prevent uses of addition while we exit.
> >
> > Signed-off-by: Luis Chambe
On Fri, May 1, 2020 at 9:40 AM Luis Chamberlain wrote:
>
> On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote:
> > On Fri, May 01, 2020 at 03:06:26PM +, Luis Chamberlain wrote:
> > > > You have access to a block device here, please use dev_war
On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote:
> On Fri, May 01, 2020 at 03:06:26PM +0000, Luis Chamberlain wrote:
> > > You have access to a block device here, please use dev_warn() instead
> > > here for that, that makes it obvious as to what
On Wed, Apr 29, 2020 at 02:57:26PM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 12:21:52PM +0000, Luis Chamberlain wrote:
> > On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote:
> > > On Wed, Apr 29, 2020 at 12:02:30PM +, Luis Chamberlain wrote:
> >
On Wed, Apr 29, 2020 at 11:49:37AM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 07:46:26AM +0000, Luis Chamberlain wrote:
> > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> > index 5c52976bd762..383045f67cb8 100644
> > --- a/kernel/trace/blktrace.c
&
On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote:
> > > Err, that function is static and has two callers.
> >
> > Yes but that is to make it easier to look for who is creating the
&g
On Wed, Apr 29, 2020 at 04:50:51AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 11:45:42AM +0000, Luis Chamberlain wrote:
> > On Wed, Apr 29, 2020 at 04:26:37AM -0700, Christoph Hellwig wrote:
> > > I can't say I'm a fan of all these long backtra
On Wed, Apr 29, 2020 at 04:26:37AM -0700, Christoph Hellwig wrote:
> I can't say I'm a fan of all these long backtraces in commit logs..
>
> > +static struct dentry *blk_debugfs_dir_register(const char *name)
> > +{
> > + return debugfs_create_dir(name, blk_debugfs_root);
> > +}
>
> I don't
://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200428-blktrace-fixes
Luis Chamberlain (6):
block: refcount the request_queue early in __device_add_disk()
block: move disk announce work from register_disk() to a helper
block: move disk invalidation from del_gendisk
eue() call followed but a put_disk(). And if the
refcount was incremented, we'd still be able to keep the same error
path of blk_cleanup_queue() followed by put_disk().
Signed-off-by: Luis Chamberlain
---
block/genhd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bl
This adds error handling to the *add_disk*() callers and the functions
it depends on. This is initial work as drivers are not converted. That
is separate work.
Signed-off-by: Luis Chamberlain
---
block/blk-integrity.c | 13 ++-
block/blk-sysfs.c | 7 +-
block/blk.h | 5
Move the disk / partition invalidation into a helper. This will make
reading del_gendisk easier to read, in preparation for adding support
to add error handling later on register_disk() and to later share more
code with del_gendisk.
This change has no functional changes.
Signed-off-by: Luis
This moves quite a bit of code which does one thing into a helper.
We currently do not check for errors but we may decide that might
be desirable later.
This also makes the code easier to read.
Signed-off-by: Luis Chamberlain
---
block/genhd.c | 30 +++---
1 file
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers
, but since
del_gendisk() deals with this before queue de-registration we'll
take a hint that's the right order that this should be done, and
we shouldn't instead strictly unwind register_disk() exactly.
We'll instead keep whatever lessons have been learned from
del_gendisk().
Signed-off-by: Luis
-blktrace-fixes
Luis Chamberlain (6):
block: revert back to synchronous request_queue removal
block: move main block debugfs initialization to its own file
blktrace: move blktrace debugfs creation to helper function
blktrace: fix debugfs use after free
blktrace: break out of blktrace
e
Cc: Omar Sandoval
Cc: Hannes Reinecke
Cc: Nicolai Stange
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Suggested-by: Nicolai Stange
Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression")
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 23
Be pedantic on removal as well and hold the mutex.
This should prevent uses of addition while we exit.
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index da693e6a834e..6dccba22c9b5
Move the work to create the debugfs directory used into a helper.
It will make further checks easier to read. This commit introduces
no functional changes.
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff
-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 5c52976bd762..383045f67cb8 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -4,6 +4,8 @@
*
*/
+#define
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Reviewed-by: Greg Kroah-Hartman
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/Makefile | 1 +
block/blk-core.c| 9 +
block/blk-debugfs.c | 15 +++
block/blk.h | 7 +++
4
Stange
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Reported-by: syzbot+603294af2d01acfdd...@syzkaller.appspotmail.com
Fixes: 6ac93117ab00 ("blktrace: use existing disk debugfs directory")
Signed-off-by: Luis Chamberlain
---
block/blk-debugfs.c | 29
On Wed, Oct 23, 2019 at 11:49:40AM +0100, Matthias Maennich wrote:
> On Fri, Oct 18, 2019 at 12:18:48PM +0000, Luis Chamberlain wrote:
> > On Wed, Oct 16, 2019 at 02:37:10PM +0100, Matthias Maennich wrote:
> > > On Wed, Oct 16, 2019 at 12:50:30PM +, Luis Chamberlain wrote:
&
On Fri, Oct 18, 2019 at 10:31:39AM +0100, Matthias Maennich wrote:
> The introduction of the symbol namespace patches changed the way symbols are
> named in the ksymtab entries. That caused userland tools to fail (such as
> kmod's depmod). As depmod is used as part of the kernel build it was worth
On Wed, Oct 16, 2019 at 03:06:30PM -0600, Tuowen Zhao wrote:
> Signed-off-by: Tuowen Zhao
Acked-by: Luis Chamberlain
Luis
On Sat, Oct 19, 2019 at 01:56:01PM +0100, Alan Maguire wrote:
> On Fri, 18 Oct 2019, Luis Chamberlain wrote:
>
> > On Thu, Oct 17, 2019 at 05:18:16PM -0700, Brendan Higgins wrote:
> > > From: Mike Salvatore
> > >
> > > In order to write the tests
On Thu, Oct 17, 2019 at 05:18:16PM -0700, Brendan Higgins wrote:
> From: Mike Salvatore
>
> In order to write the tests against the policy unpacking code, some
> static functions needed to be exposed for testing purposes. One of the
> goals of this patch is to establish a pattern for which
On Thu, Oct 17, 2019 at 07:32:18PM +0100, Alan Maguire wrote:
> kunit needs a non-exported global kernel symbol
> (sysctl_hung_task_timeout_secs).
Sounds like a perfect use case for the new symbol namespaces [0]. We
wouldn't want random drivers importing this namespace, but for kunit it
would
On Wed, Oct 16, 2019 at 02:37:10PM +0100, Matthias Maennich wrote:
> On Wed, Oct 16, 2019 at 12:50:30PM +0000, Luis Chamberlain wrote:
> > On Mon, Oct 14, 2019 at 03:44:40PM +0100, Matthias Maennich wrote:
> > > Hi Luis!
> > >
> > > On Mon, Oct 14, 2019 at 08:5
On Tue, Oct 15, 2019 at 10:44:34AM +0300, Andy Shevchenko wrote:
> On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> > On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > > -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # save the attached
On Mon, Oct 14, 2019 at 03:44:40PM +0100, Matthias Maennich wrote:
> Hi Luis!
>
> On Mon, Oct 14, 2019 at 08:52:35AM +0000, Luis Chamberlain wrote:
> > On Fri, Oct 11, 2019 at 09:26:05PM +0200, Heiner Kallweit wrote:
> > > On 10.10.2019 19:15
On Mon, Oct 14, 2019 at 03:02:03PM +0100, Alan Maguire wrote:
>
>
> On Mon, 14 Oct 2019, Luis Chamberlain wrote:
>
> > On Tue, Oct 08, 2019 at 03:55:43PM +0100, Alan Maguire wrote:
> > > The current kunit execution model is to provide base kunit function
On Mon, Oct 14, 2019 at 12:57:54PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 14, 2019 at 10:31:50AM +0000, Luis Chamberlain wrote:
> > On Mon, Oct 14, 2019 at 11:29:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Oct 14, 2019 at 09:22:16AM +, Luis Chamberlain wro
On Mon, Oct 14, 2019 at 12:01:44PM +0200, Jessica Yu wrote:
> +++ Heiner Kallweit [11/10/19 21:26 +0200]:
> > On 10.10.2019 19:15, Luis Chamberlain wrote:
> > >
> > >
> > > On Thu, Oct 10, 2019, 6:50 PM Heiner Kallweit > > <mailto:hkallwe...@gmail.co
On Tue, Oct 08, 2019 at 03:55:43PM +0100, Alan Maguire wrote:
> The current kunit execution model is to provide base kunit functionality
> and tests built-in to the kernel. The aim of this series is to allow
> building kunit itself and tests as modules. This in turn allows a
> simple form of
On Fri, Oct 11, 2019 at 09:26:05PM +0200, Heiner Kallweit wrote:
> On 10.10.2019 19:15, Luis Chamberlain wrote:
> >
> >
> > On Thu, Oct 10, 2019, 6:50 PM Heiner Kallweit > <mailto:hkallwe...@gmail.com>> wrote:
> >
> > MODULE_SOFTDEP(&quo
On Fri, Oct 04, 2019 at 04:17:33PM -0700, Dmitry Torokhov wrote:
> Hi Hans,
>
> On Fri, Oct 04, 2019 at 04:50:52PM +0200, Hans de Goede wrote:
> > In some cases the platform's main firmware (e.g. the UEFI fw) may contain
> > an embedded copy of device firmware which needs to be (re)loaded into
uct ctl_table {
> ...
>
> Besides the wide use of this proposed cose style, this change helps to
> find at a glance the struct definition when navigating the code.
>
> Signed-off-by: Alessio Balsini
> Cc: Luis Chamberlain
> Cc: Kees Cook
Acked-by: Luis Chamberlain
Luis
On Tue, Aug 27, 2019 at 12:40:02PM +0200, Takashi Iwai wrote:
> On Mon, 26 Aug 2019 19:24:22 +0200,
> Scott Branden wrote:
> >
> > I will admit I am not familiar with every subtlety of PCI
> > accesses. Any comments to the Valkyrie driver in this patch series are
> > appreciated.
> > But not all
On Wed, Oct 09, 2019 at 09:03:35PM -0600, Tuowen Zhao wrote:
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch use devm_ioremap_uc to
On Wed, Oct 09, 2019 at 09:03:34PM -0600, Tuowen Zhao wrote:
> Implement a resource managed strongly uncachable ioremap function.
>
> Tested-by: AceLan Kao
> Signed-off-by: Tuowen Zhao
> Acked-by: Mika Westerberg
> Acked-by: Andy Shevchenko
Acked-by: Luis Chamberlain
Luis
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> +EXPORT_SYMBOL(devm_ioremap_uc);
EXPORT_SYMBOL_GPL() would be my preference.
Luis
On Mon, Sep 30, 2019 at 02:05:22PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 27, 2019 at 11:55:13AM -0600, Tuowen Zhao wrote:
> > Write-combining BAR for intel-lpss-pci in MTRR causes system hangs
> > during boot.
> >
> > This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc
>
On Fri, Aug 23, 2019 at 12:55:30PM -0700, Scott Branden wrote:
> Hi Takashi
>
> On 2019-08-23 5:29 a.m., Takashi Iwai wrote:
> > On Thu, 22 Aug 2019 21:24:45 +0200,
> > Scott Branden wrote:
> > > Add kernel_pread_file* support to kernel to allow for partial read
> > > of files with an offset into
On Thu, Aug 22, 2019 at 04:30:37PM -0700, Scott Branden wrote:
> On 2019-08-22 2:12 p.m., Luis Chamberlain wrote:
> > On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
> > > On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> > > > This implies you havi
On Fri, Aug 23, 2019 at 12:31:40PM +0200, Takashi Iwai wrote:
> So, if any, we'd need put a mutex around the fallback loader code.
> And, the mutex should be rather per device, not a global one.
>
> Or we may trick it by appending the second parallel caller into the
> same wait queue, but the
On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
> On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> > This implies you having to change the other callers, and while currently
> > our list of drivers is small,
>
> Yes, the list is small, very small.
>
&g
On Thu, Aug 22, 2019 at 12:24:46PM -0700, Scott Branden wrote:
> @@ -923,16 +936,22 @@ EXPORT_SYMBOL_GPL(firmware_request_cache);
> */
> int
> request_firmware_into_buf(const struct firmware **firmware_p, const char
> *name,
> - struct device *device, void *buf, size_t
On Mon, Aug 19, 2019 at 09:19:51AM -0700, Scott Branden wrote:
> To be honest, I find the entire firmware code sloppy.
And that is after years of cleanup on my part. Try going back to v4.1
for instance, check the code out then for an incredible horrific sight :)
> I don't think the
On Thu, Aug 01, 2019 at 11:15:19AM -0700, Scott Branden wrote:
> Hi Luis,
>
> On 2019-08-01 10:42 a.m., Luis Chamberlain wrote:
> > On Thu, Aug 01, 2019 at 08:18:01AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Brande
On Thu, Aug 15, 2019 at 05:09:45PM -0700, Scott Branden wrote:
> A race condition exists between _request_firmware_prepare checking
> if firmware is assigned and firmware_fallback_sysfs creating a sysfs
> entry (kernel trace below). To avoid such condition add a mutex
> fw_lock_fallback to
On Thu, Aug 15, 2019 at 05:09:44PM -0700, Scott Branden wrote:
> Add tests cases for checking request_firmware_into_buf api.
> API was introduced into kernel with no testing present previously.
>
> Signed-off-by: Scott Branden
Acked-by: Luis Chamberlain
Luis
t been added to test such api in test_firmware until now.
>
> Signed-off-by: Scott Branden
Thanks for the patch!
Acked-by: Luis Chamberlain
Luis
I'd like to announce my first release of kdevops [0] which I am happy to
share with the community. The goal behind this project is to provide a
modern devops framework for Linux kernel development. It is not a tests
suite, it is designed to *use* *any* test suites, and more importantly,
it allows
On Tue, Aug 06, 2019 at 07:23:18PM +1000, Dave Chinner wrote:
> On Tue, Aug 06, 2019 at 09:10:57AM +0200, Kinky Nekoboi wrote:
> > Addional info:
> >
> > this only occurs if kernel is compiled with:
> >
> > CONFIG_XFS_DEBUG=y
> >
> > running 4.19.64 without xfs debugging works fine
>
> I'm
On Thu, Aug 01, 2019 at 08:18:01AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Branden wrote:
> > Hi Greg,
> >
> > I am now back from leave to continue this patch. Comment below.
> >
> > On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote:
> > > On Thu, May
Other than the two comments:
Reviewed-by: Luis Chamberlain
Luis
On Wed, Jul 24, 2019 at 01:58:48AM -0400, Alexandre Ghiti wrote:
> Mips uses TASK_IS_32BIT_ADDR to determine if a task is 32bit, but
> this define is mips specific and other arches do not have it: instead,
> use !IS_ENABLED(CONFIG_64BIT) || is_compat_task() condition.
>
> Signed-off-by: Alexandre
On Wed, Jul 24, 2019 at 01:58:41AM -0400, Alexandre Ghiti wrote:
> diff --git a/mm/util.c b/mm/util.c
> index 0781e5575cb3..16f1e56e2996 100644
> --- a/mm/util.c
> +++ b/mm/util.c
> @@ -321,7 +321,15 @@ unsigned long randomize_stack_top(unsigned long
> stack_top)
> }
>
> #ifdef
On Thu, Jul 11, 2019 at 04:07:27PM -0700, Brendan Higgins wrote:
> On Wed, Jul 3, 2019 at 3:25 PM Luis Chamberlain wrote:
> >
> > On Wed, Jul 03, 2019 at 08:57:58PM +0200, Greg Kroah-Hartman wrote:
> >
> > But again, this is a separate problem. The one I am addressing
ible to open the file for writing.
>
> Fixes: 0bd23d09b874 ("vfs: Don't modify inodes with a uid or gid unknown to
> the vfs")
> Cc: sta...@vger.kernel.org # v4.8+
> Signed-off-by: Radoslaw Burny
Acked-by: Luis Chamberlain
Andrew,
When you get a chance, can you p
Please Cc Andrew Morton on future follow
ups.
On Sat, Jul 06, 2019 at 12:19:16AM +0200, Radoslaw Burny wrote:
> On Fri, Jul 5, 2019 at 10:02 PM Luis Chamberlain wrote:
> >
> >
> > Please re-state the main fix in the commit log, not just the subject.
>
> Sure, I'll
Please re-state the main fix in the commit log, not just the subject.
Also, this does not explain why the current values are and the impact to
systems / users. This would help in determine and evaluating if this
deserves to be a stable fix.
On Fri, Jul 05, 2019 at 06:30:21PM +0200, Radoslaw
On Wed, Jul 03, 2019 at 09:31:33PM +0200, Enrico Weigelt, metux IT consult
wrote:
> On 03.07.19 19:35, Luis Chamberlain wrote:
>
> Hi,
>
> >> Okay, but IIRC this will add more boilerplate those modules.
> >
> > Just one module attribute.
>
> Yes
On Wed, Jul 03, 2019 at 08:57:58PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 03, 2019 at 04:50:20PM +0000, Luis Chamberlain wrote:
> > On Wed, Jul 03, 2019 at 09:40:48AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jul 02, 2019 at 08:51:06PM +, Luis Chamberlain wro
On Wed, Jul 03, 2019 at 02:16:44PM +0200, Enrico Weigelt, metux IT consult
wrote:
> On 28.06.19 20:40, Luis Chamberlain wrote:
>
> Hi folks,
>
> > The solution puts forward a mechanism to add a kconfig_symb where
> > we are 100% certain we have a direct module --
On Wed, Jul 03, 2019 at 09:40:48AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 02, 2019 at 08:51:06PM +0000, Luis Chamberlain wrote:
> > On Sat, Jun 29, 2019 at 10:42:57AM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Jun 28, 2019 at 11:40:22AM -0700, Luis Chamberlain wro
On Sat, Jun 29, 2019 at 10:42:57AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 28, 2019 at 11:40:22AM -0700, Luis Chamberlain wrote:
> > On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote:
> > >
> > > On Wed, Jun 26, 2019 at 03:21:08PM -0700, Luis Chamberlain w
On Tue, Jun 04, 2019 at 11:27:51PM +0800, Zhiqiang Liu wrote:
> > On Wed, May 15, 2019 at 10:53:55PM +0800, Zhiqiang Liu wrote:
> In proc_dointvec_jiffies func, the write value is only checked
> whether it is larger than INT_MAX. If the write value is less
> than zero, it can also
On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote:
> On Tue, Jun 25, 2019 at 12:10:20PM +0200, Christoph Hellwig wrote:
> > On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote:
> > > I'm a little concerned this is going to limit what we can do
> > > with the XFS IO path because
On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote:
>
> On Wed, Jun 26, 2019 at 03:21:08PM -0700, Luis Chamberlain wrote:
> > On Tue, Feb 5, 2019 at 2:07 PM Luis Chamberlain wrote:
> > > In lieu of no Luke Skywalker, if you will, for a large kconfig revamp
> &
On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote:
> On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote:
> > There is no real problem merging ioends that go beyond i_size into an
> > ioend that doesn't. We just need to move the append transaction to the
> > base
On Tue, Feb 5, 2019 at 2:07 PM Luis Chamberlain wrote:
> In lieu of no Luke Skywalker, if you will, for a large kconfig revamp
> on this, I'm inclined to believe *at least* having some kconfig_symb
> exposed for some modules is better than nothing. Christoph are you
> tot
On Tue, Jun 25, 2019 at 05:07:32PM -0700, Brendan Higgins wrote:
> On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote:
> >
> > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote:
> > > +/**
> > > + * module_test() - used to register a kunit_mod
On Mon, Jun 17, 2019 at 01:26:12AM -0700, Brendan Higgins wrote:
> From: Iurii Zaikin
>
> KUnit tests for initialized data behavior of proc_dointvec that is
> explicitly checked in the code. Includes basic parsing tests including
> int min/max overflow.
First, thanks for this work! My review
On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote:
> +/**
> + * module_test() - used to register a kunit_module with KUnit.
> + * @module: a statically allocated kunit_module.
> + *
> + * Registers @module with the test framework. See kunit_module for
> more
> + * information.
>
On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote:
> diff --git a/Kconfig b/Kconfig
> index 48a80beab6853..10428501edb78 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -30,3 +30,5 @@ source "crypto/Kconfig"
> source "lib/Kconfig"
>
> source "lib/Kconfig.debug"
> +
> +source
Sorry for the late review... Ah!
On Tue, Jun 11, 2019 at 02:26:25PM +0200, Takashi Iwai wrote:
> @@ -354,7 +454,12 @@ module_param_string(path, fw_path_para,
> sizeof(fw_path_para), 0644);
> MODULE_PARM_DESC(path, "customized firmware image search path with a higher
> priority than default
On Wed, Mar 20, 2019 at 03:01:12PM -0400, Andrea Arcangeli wrote:
> but
> that would be better be achieved through SECCOMP and not globally.'.
That begs the question why not use seccomp for this? What if everyone
decided to add a knob for all syscalls to do the same? For the commit
log, why is it
Currently the test script checks for the existance of the
sysctl test module's directory path prior to loading it.
We must first try to load the module prior to checking for
that path. This fixes the order for the load / test.
Signed-off-by: Luis Chamberlain
---
tools/testing/selftests/sysctl
):
test_sysctl: add proc_do_large_bitmap() test case
sysctl: Fix proc_do_large_bitmap for large input buffers
Luis Chamberlain (4):
test_sysctl: remove superfluous test_reqs()
test_sysctl: load module before testing for it
test_sysctl: ignore diff output on verify_diff_w()
test_sysctl: allow
just
seems rather odd. Better to just ignore that messsage all
together, what we really care about i sthe results, the
return value and we check for that.
Signed-off-by: Luis Chamberlain
---
tools/testing/selftests/sysctl/sysctl.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
verify_diff_proc_file() to use diff]
[mcgrof: use mktemp for tmp file]
[mcgrof: merge shell test and C code]
[mcgrof: commit log love]
[mcgrof: export proc_do_large_bitmap() to allow for the test
[mcgrof: check for the return value when writing to the proc file]
Signed-off-by: Luis Chamberlain
We already call test_reqs(), no need to call it twice.
Signed-off-by: Luis Chamberlain
---
tools/testing/selftests/sysctl/sysctl.sh | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/sysctl/sysctl.sh
b/tools/testing/selftests/sysctl/sysctl.sh
index 780ce7123374
), and ask the caller to come back for
more.
Signed-off-by: Eric Sandeen
Acked-by: Kees Cook
Signed-off-by: Luis Chamberlain
---
kernel/sysctl.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index e1
by requiring each test description to annotate their
respective test target file. If the target file does not exist, we skip
the test gracefully.
Signed-off-by: Luis Chamberlain
---
tools/testing/selftests/sysctl/sysctl.sh | 78
1 file changed, 53 insertions(+), 25 deletions
On Thu, Feb 14, 2019 at 11:56:46PM +0530, Jeffrin Thalakkottoor wrote:
> > Your subject is too long.
> ok . i have changed it
>
>
> > Please upgrade bash?
> anyway now i have an upgraded one.
>
> here is a clipping related to the error
>
On Thu, Feb 21, 2019 at 11:47:49AM -0600, Eric Sandeen wrote:
> On 2/21/19 9:18 AM, Luis Chamberlain wrote:
> > On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote:
> >> Here's a pretty hacky test script to test this code via
> >> ip_local_reserved_ports
> &
On Sat, Feb 16, 2019 at 01:28:35PM -0500, Theodore Y. Ts'o wrote:
> The block/*, loop/* and scsi/* tests in blktests do seem to be in
> pretty good shape. The nvme, nvmeof, and srp tests are *definitely*
> not as mature.
Can you say more about this later part. What would you like to see more
of
ing, So
> let's be explicit about that.
>
> Signed-off-by: John Zhao
Acked-by: Luis Chamberlain
Luis
On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote:
> Here's a pretty hacky test script to test this code via
> ip_local_reserved_ports
Thanks Eric!
So /proc/sys/net/ipv4/ip_local_reserved_ports is a production knob, and
if we wanted to stress test it with a selftest it could break
On Sun, Feb 17, 2019 at 04:25:10PM +0800, yuank...@codeaurora.org wrote:
> On 2019-02-05 07:30 AM, Luis Chamberlain wrote:
> > On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuank...@codeaurora.org wrote:
> > > Hi,
> > >
> > >
ine an IMA MODULE_CHECK policy rule if
> CONFIG_MODULE_SIG is not enabled. A custom IMA policy may still define
> and require an IMA signature.
>
> Signed-off-by: Mimi Zohar
Reviewed-by: Luis Chamberlain
Luis
On Wed, Feb 13, 2019 at 07:17:59AM -0500, Mimi Zohar wrote:
> Require signed kernel modules on systems with secure boot mode enabled.
>
> Requiring appended kernel module signatures may be configured, enabled
> on the boot command line, or with this patch enabled in secure boot
> mode.
But only
On Wed, Feb 13, 2019 at 04:17:13PM -0800, Brendan Higgins wrote:
> On Wed, Feb 13, 2019 at 1:55 PM Kieran Bingham
> wrote:
> Oh, yep, you are right. Does that mean we should bother at all with a
> defconfig?
If one wanted a qemu enabled type of kernel and also for kuniut one
could imply run:
I've started to give some love towards XFS stable maintenance, the first
results of that work went in v4.19.21. I'd like to review what I use to
track the stable kernel baselines, oscheck [0], to avoid regressions,
and show how this can also easily be used to track any distribution
baselines as
On Mon, Feb 11, 2019 at 10:32:50PM +0100, Christian Brauner wrote:
> On Mon, Feb 11, 2019 at 01:25:23PM -0800, Luis Chamberlain wrote:
> > On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote:
> > > On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote:
&
Your subject is too long.
On Fri, Feb 01, 2019 at 12:01:09AM +0530, Jeffrin Jose T wrote:
> The kmod.sh script breaks because an array is passed as input
> instead of a single element input.This patch takes elements
> one at a time and passed as input to the condition statement
> which in turn
On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote:
> On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote:
> > On Mon, Feb 11, 2019 at 01:06:32PM -0800, a...@linux-foundation.org wrote:
> >
> > > @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v
> >
> > >
problematic as it gives the illusion that the limit has indeed be bumped
> when in fact it failed.
> This commit makes sure to return EINVAL when an overflow is detected.
> Please note that this is a userspace facing change.
>
Acked-by: Luis Chamberlain
Luis
> Signe
401 - 500 of 569 matches
Mail list logo
