On Wed, Aug 02, 2017 at 10:55:03PM +0200, Luis R. Rodriguez wrote:
> On Thu, Jul 20, 2017 at 01:13:08PM -0700, Luis R. Rodriguez wrote:
> > Greg,
> >
> > as requested I've split up the pending firmware fixes for the firmware API
> > into two series, one for v4.13
This wait is similar to wait_event_interruptable_timeout() but only accepts
SIGKILL interrupt signal. Other signals are ignored.
Signed-off-by: Luis R. Rodriguez
---
include/linux/wait.h | 37 +
1 file changed, 37 insertions(+)
diff --git a/include/linux
ch one separately as they come in, this however puts a stop gap for
them as before.
Fixes: 6d7964a722af ("kmod: throttle kmod thread limit")
Reported-by: Matt Redfearn
Tested-by: Matt Redfearn
Signed-off-by: Luis R. Rodriguez
---
kernel/kmod.c | 25 +++--
1 fil
The descriptions were reversed, correct this.
Reported-by: Daniel Mentz
Fixes: 64b671204afd71 ("test_sysctl: add generic script to expand on tests")
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/kmod/kmod.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
we can come up with a more sensible generic
solution even better!
If there are any questions please let me know.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20170809-kmod-for-v4.13-final
[1] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git
Luis
Luis
On Wed, Aug 09, 2017 at 02:56:52PM -0700, Daniel Mentz wrote:
> OK. While we're here: I think there's a spelling error in usage() in
> tools/testing/selftests/kmod/kmod.sh
>
> echo "-c Run test ID once"
> echo "-s Run test ID x test-count number of times"
>
> I believe that "-c"
_unlock() twice.
>
> Signed-off-by: Daniel Mentz
> Cc: Luis R. Rodriguez
> Cc: Greg Kroah-Hartman
> Cc: Andrew Morton
> ---
Thanks Daniel but someone beat you to the fix, I've sent this to Andrew
and he's integrated into his -mm tree. See:
http://lkml.kernel.org/r/201
On Mon, Aug 07, 2017 at 02:17:33PM -0400, Prarit Bhargava wrote:
>
>
> On 08/07/2017 01:14 PM, Luis R. Rodriguez wrote:
>
> >
> > Note printk_late_init() is a late_initcall(). This means if the
> > printk_time_setting was disabled it will take a while to enable it
On Wed, Aug 02, 2017 at 02:12:00AM +0200, Luis R. Rodriguez wrote:
> On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote:
> > diff --git a/fs/exec.c b/fs/exec.c
> > index 62175cbcc801..004bb50a01fe 100644
> > --- a/fs/exec.c
> > +++ b/fs/exec.c
&g
On Mon, Aug 07, 2017 at 11:26:09AM +0100, Matt Redfearn wrote:
> Hi Luis,
> On 03/08/17 00:23, Luis R. Rodriguez wrote:
> > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote:
> > > On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez
> > > wrote:
> > &g
On Tue, Aug 08, 2017 at 11:04:11AM -0700, Florian Fainelli wrote:
> On 08/08/2017 10:57 AM, Luis R. Rodriguez wrote:
> > On Tue, Aug 08, 2017 at 09:40:26AM -0700, Florian Fainelli wrote:
> >> Add a test module that allows testing that CONFIG_DEBUG_VIRTUAL works
> >> corr
On Tue, Aug 08, 2017 at 09:40:26AM -0700, Florian Fainelli wrote:
> Add a test module that allows testing that CONFIG_DEBUG_VIRTUAL works
> correctly, at least that it can catch invalid calls to virt_to_phys()
> against the non-linear kernel virtual address map.
>
> Signed-off-by: Florian Fainelli
On Tue, Aug 08, 2017 at 07:50:04PM +1000, Michael Ellerman wrote:
> Andrew Morton writes:
> > On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodriguez"
> > wrote:
> >
> >> We had just forgotten to do this.
> >>
> >> Fixes: 3925
On Thu, Aug 03, 2017 at 01:24:36PM -0700, Luis R. Rodriguez wrote:
> Executing selftests is fragile as if someone forgot to set a secript
> as executable the test will fail, and you won't know for sure if the
> failure was caused by the lack of proper permissions or something else
This will ensure I get emails on my work and personal email address.
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3deaddc8c578..997b8062397a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
this driver anymore.
Before trying to due away with prism54 once more stuff it into staging,
which is our hospice for dying drivers.
Acked-by: Kalle Valo
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 4 ++--
drivers/net/wireless/intersil/Kconfig
Greg,
This v2 adds the TODO you requested to clarify prism54 will be removed in
two kernel releases from now, and so no further cleanup is needed other
than to ensure the driver compiles.
This is based on linux-next tag next-20170807.
Luis
Luis R. Rodriguez (2):
wireless: move prism54 out
On Thu, Aug 03, 2017 at 09:18:44PM -0400, Prarit Bhargava wrote:
> index fc47863f629c..8f093dd0a733 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1202,8 +1204,119 @@ static inline void boot_delay_msec(int level)
> }
> #endif
>
> -static bool printk_time = IS_ENABLED
On Thu, Aug 03, 2017 at 05:42:15PM -0700, Greg KH wrote:
> On Thu, Aug 03, 2017 at 04:59:36PM -0700, Luis R. Rodriguez wrote:
> > prism54 is deprecated in favor of the p54pci device driver. Although
> > only *one soul* had reported issues with it long ago Linux most Linux
> >
On Thu, Aug 03, 2017 at 05:02:40PM -0700, Kees Cook wrote:
> On Wed, Aug 2, 2017 at 4:23 PM, Luis R. Rodriguez wrote:
> > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote:
> >> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez
> >> wrote:
> >> > O
this driver anymore.
Before trying to due away with prism54 once more stuff it into staging,
which is our hospice for dying drivers.
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 4 ++--
drivers/net/wireless/intersil/Kconfig| 20
This will ensure I get emails on my work and personal email address.
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 97cf436e6750..49ae596584e7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Kalle, Greg,
This moves the prism54 diver to staging. The reason for this are
stated on the driver's own commit log. Let me know what tree you'd
prefer this to go through.
Luis R. Rodriguez (2):
wireless: move prism54 out to staging
MAINTAINERS: update email address for mcgr
tests as independent units.
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/lib.mk | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 959273c3a52e..e71f8e4633b1 100644
--- a/tools/testing/self
On Thu, Aug 03, 2017 at 10:27:33AM -0700, Kees Cook wrote:
> On Thu, Aug 3, 2017 at 9:59 AM, Luis R. Rodriguez wrote:
> > Executing selftests is fragile as if someone forgot to set a secript
> > as executable the test will fail. Setting scripts as executable is
> > desirab
ome/mcgrof/linux-next/tools/testing/selftests/sysctl
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/sysctl'
Fixes: 64b671204afd71 ("test_sysctl: add generic script to expand on tests")
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/sysctl
d.sh [FAIL]
/home/mcgrof/linux-next/tools/testing/selftests/kmod
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/kmod
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests
invoking the $SHELL for running each
script.
Suggsted-by: Andrew Morton
Signed-off-by: Luis R. Rodriguez
---
Shuah, while the last two patches could be queued in for 4.13-final,
this one I think is more appropriate for v4.14-rc1 only.
tools/testing/selftests/lib.mk | 2 +-
1 file changed, 1
On Thu, Aug 03, 2017 at 05:55:18AM +, Coelho, Luciano wrote:
> On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote:
> > "Luis R. Rodriguez" writes:
> >
> > > > +int request_firmware_nowait(struct module *module, bool uevent,
> > > > +
On Wed, Aug 02, 2017 at 04:42:50PM -0700, Andrew Morton wrote:
> On Wed, 2 Aug 2017 15:55:50 -0700 "Luis R. Rodriguez"
> wrote:
>
> > On Wed, Aug 2, 2017 at 3:43 PM, Andrew Morton
> > wrote:
> > > On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodri
On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote:
> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote:
> > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote:
> >> Commit 6d7964a722af ("kmod: throttle kmod thread limit") which was
> &g
On Wed, Aug 2, 2017 at 3:43 PM, Andrew Morton wrote:
> On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodriguez"
> wrote:
>
>> We had just forgotten to do this.
>>
>> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module
>&
On Tue, Aug 01, 2017 at 02:54:51PM -0700, Cong Wang wrote:
> On Tue, Aug 1, 2017 at 2:34 PM, Massimo Sala
> wrote:
> > Do you confirm it is a sysctl parsing bug ?
> >
> > Bosybox handles these cases, so I think also standalone sysctl have to.
> >
> > Or at least someone must update sysctl docs /
On Mon, Jul 31, 2017 at 05:09:44PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> So far we got only one function for loading firmware asynchronously:
> request_firmware_nowait. It didn't allow much customization of firmware
> loading process - there is only one bool uevent argument. Moreo
Andrew,
After the fixes for v4.13-final which I just sent these are the rest
of the development patches so far queued up for v4.14 for test_kmod.
Its just two minor changes.
These changes are available on my linux-next kernel.org tree on the
20170801-kmod-for-v4.14 branch [0]. Please let me know
er to know this.
Signed-off-by: Dan Carpenter
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ff9148969b92..67fc7b9f41e3 100644
--- a/lib/test_kmod.c
From: Dan Carpenter
Most checks will check for min and then max, except the int check.
Flip the checks to be consistent with the other code.
Signed-off-by: Dan Carpenter
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion
We had just forgotten to do this.
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/kmod/kmod.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/test
-by: Dan Carpenter
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 90c91541fc16..8f
258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter
[mcgrof: massaged subject, explain what happens]
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_kmod.c b/l
From: Colin Ian King
Trivial fix to spelling mistake in snprintf text
Signed-off-by: Colin Ian King
[mcgrof: massaged commit message]
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 4 ++--
1 fi
l.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20170801-kmod-for-v4.13-final
Colin Ian King (1):
test_kmod: fix spelling mistake: "EMTPY" -> "EMPTY"
Dan Carpenter (2):
test_kmod: fix the lock in register_test_dev_kmod()
test_kmod: fix small memory leak on filesys
cgrof: massaged commit subject, noted memory leak issue without the fix]
Signed-off-by: Luis R. Rodriguez
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 1bc06bbfc97a..ff9148969b92 100644
--- a/lib/test_kmod.c
+++ b/
On Thu, Jul 20, 2017 at 01:13:37PM -0700, Luis R. Rodriguez wrote:
> Greg,
>
> this is the series of pending fixes for v4.14-rc1. They depend on the
> series of fixes just posted for v4.13-final. This contains a set of minor
> fixes and also extends the test drivers to test
On Thu, Jul 20, 2017 at 01:13:08PM -0700, Luis R. Rodriguez wrote:
> Greg,
>
> as requested I've split up the pending firmware fixes for the firmware API
> into two series, one for v4.13-final and another for v4.14-rc1. This is the
> series of fixes for v4.13-final. They also
On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote:
> When the kernel does not have a binary format handler for an executable
> it is attempting to load, when CONFIG_MODULES is enabled it will attempt
> to load a module for that format. If the kernel does not have a binary
> format handl
On Mon, Jul 17, 2017 at 07:38:40AM +, David Binderman wrote:
> Hello there,
>
>
> lib/test_kmod.c:750]: (style) Statements following return, break, continue,
> goto or throw will never be executed.
>
> case TEST_KMOD_FS_TYPE:
> break;
> kfree_const(config->test_fs);
>
On Fri, Jul 07, 2017 at 11:41:17AM +0300, Dan Carpenter wrote:
> The break was in the wrong place so file system tests don't work as
> intended.
More importantly it leaked memory per test switch as well.
>
> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
> Signed-o
On Fri, Jul 07, 2017 at 11:40:36AM +0300, Dan Carpenter wrote:
> We accidentally just drop the lock twice instead of taking it and then
> releasing it.
>
> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Dan Carpenter
Thanks, queued!
Luis
On Fri, Jul 07, 2017 at 11:39:33AM +0300, Dan Carpenter wrote:
> There is technically a bug where we don't test for negatives in
> test_dev_config_update_uint_sync(). "new" is long and UINT_MAX is
> unsigned int so on 64 bit systems negatives are allowed.
Good catch. I however prefer we instead j
On Mon, Jul 24, 2017 at 10:34:18PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in snprintf text
>
> Signed-off-by: Colin Ian King
Queued, thanks!
Luis
On Tue, Aug 01, 2017 at 08:55:28AM -0400, Prarit Bhargava wrote:
> diff --git a/arch/x86/configs/x86_64_defconfig
> b/arch/x86/configs/x86_64_defconfig
> index 4a4b16e56d35..23da8e5297a1 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -283,7 +283,13
On Tue, Jul 25, 2017 at 08:17:26AM -0400, Prarit Bhargava wrote:
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index fc47863f629c..26cf6cadd267 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1202,8 +1202,40 @@ static inline void boot_delay_msec(int lev
On Thu, Jul 20, 2017 at 11:24:22AM -0700, Mark Salyzyn wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 98fe715522e8..0d63c3fb4e24 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -30,6 +30,58 @@ config CONSOLE_LOGLEVEL_DEFAULT
> usage in the kernel. That i
branch
on my linux-next tree [0]. If there are any questions or issues please let
me know.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170720-fw-fixes-wait-v4-for-v4.14
Luis R. Rodriguez (5):
test_firmware: add test case for SIGCHLD on sync fallback
Right now we send -EAGAIN to a syfs write which got interrupted.
Userspace can't tell what happened though, send -EINTR if we
were killed due to a signal so userspace can tell things apart.
This is only applicable to the fallback mechanism.
Reported-by: Martin Fuzzey
Signed-off-by: L
It has been reported that SIGCHLD will trigger an immediate abort
on sync firmware requests which rely on the sysfs interface for a
trigger. This is unexpected behaviour, this reproduces this issue.
This test case currenty fails.
Reported-by: Martin Fuzzey
Signed-off-by: Luis R. Rodriguez
protection")
Reported-by: Jakub Kicinski
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index b9f907eedbf7..f50ec6e3
CONFIG_FW_LOADER_USER_HELPER=n
Signed-off-by: Luis R. Rodriguez
---
lib/test_firmware.c | 710 ++
tools/testing/selftests/firmware/fw_filesystem.sh | 241 +++-
2 files changed, 949 insertions(+), 2 deletions(-)
diff --git a/lib
For some reason we have always forgotten this. Without this
we don't get a nice prefix on our pr_debug() / pr_*() messages.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_class.c b/drivers
icolas
Reported-by: John Ewalt
Reported-by: Jakub Kicinski
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 38 ++
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_c
it_for_completion is
interrupted")
Suggested-by: "Eric W. Biederman"
Suggested-by: Dmitry Torokhov
Tested-by: Martin Fuzzey
Reported-by: Martin Fuzzey
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --gi
Otherwise there is no easy way this actually happened.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index ba272a65291d..a5fb884a136d 100644
--- a/drivers
mware-fixes branch [0] on linux
tree based on Linus' latest tree. If there are any questions or issues
please let me know.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=2017072-firmware-fixes
Luis R. Rodriguez (3):
firmware: fix batched requests - wake all waiters
On Mon, Jul 17, 2017 at 06:20:37PM +0200, Greg KH wrote:
> On Mon, Jul 17, 2017 at 06:04:33PM +0200, Luis R. Rodriguez wrote:
> > On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote:
> > > On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote:
> > > >
On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote:
> On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote:
> > Right now we send -EAGAIN to a syfs write which got interrupted.
> > Userspace can't tell what happened though, send -EINTR if we
> > were
For some reason we have always forgotten this. Without this
we don't get a nice prefix on our pr_debug() / pr_*() messages.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_class.c b/drivers
OK
request_firmware_nowait(uevent=true) OK OK
request_firmware_nowait(uevent=false) OK OK
Signed-off-by: Luis R. Rodriguez
---
lib/test_firmware.c
Otherwise there is no easy way this actually happened.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 6f58a15efa2b..a85dabeb1e20 100644
--- a/drivers
OK
[0] https://bugzilla.kernel.org/show_bug.cgi?id=195477
Cc: stable # v3.14
Fixes: bba3a87e982ad ("firmware: Introduce request_firmware_direct()"
Reported-by: Nicolas
Reported-by: John Ewalt
Reported-by: Jakub Kicinski
Signed-off-by: Luis R. Rod
ched-req branch [0] based on linux-next tag next-20170714.
If there any questions please let me know.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170714-fw-fix-batched-req
Luis R. Rodriguez (4):
firmware: define pr_fmt
firwmare: enable a debug pr
On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote:
> On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote:
> > Why would we keep it if there is no in-tree user for it? If you want it
> > sometime in the future, great, we can revert the deletion then, but
> > keeping it around for n
On Wed, Jul 12, 2017 at 09:10:28AM +0100, Luis de Bethencourt wrote:
> On 07/09/2017 12:00 PM, Luis de Bethencourt wrote:
> > Updating the location of the befs git tree and my email address.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
> > Hello,
> >
> > The currently listed email address
On Fri, Jun 30, 2017 at 12:50:03AM +0200, Luis R. Rodriguez wrote:
> ie, I expect the combination of both to fix your issues, not just the last
> series I just posted [0]. If you want this in git form you can find all of
> the patches bundled on the 20170629-fw-fixes-wait-v4 branch [1
On Wed, Jul 05, 2017 at 09:33:38AM -0700, Linus Torvalds wrote:
> On Wed, Jul 5, 2017 at 9:18 AM, Peter Zijlstra wrote:
> > In any case, I'm not seeing why you call it idiotic.
>
> Have you read the problems?
>
> There were originally three users:
>
> - one of them is firmware loading, and it
On Wed, Jul 12, 2017 at 09:58:01AM +0200, Arnd Bergmann wrote:
> On Wed, Jul 12, 2017 at 3:31 AM, Palmer Dabbelt wrote:
> > At this point I'm not really sure how to proceed: reviews have calmed down
> > quite a bit over the last two weeks, but I'm not familiar with the Linux
> > development proces
x86 and the intel i915 driver.
> Signed-off-by: Palmer Dabbelt
As I noted with the other PCI patch, these should have addressed
Bjorn Helgaas and linux-...@vger.kernel.org.
You seem to have forgotten to do that this time again.
Provided you address the minor issues below here's a:
Reviewed-b
>
> The only functional change should be that microblaze used to export
> pcibios_fixup_bus. None of the other architectures export this, so I
> just dropped it.
>
> Signed-off-by: Palmer Dabbelt
Reviewed-by: Luis R. Rodriguez
But this should also get review by Bjorn an
On Mon, Jul 10, 2017 at 06:39:07PM -0700, Palmer Dabbelt wrote:
> Thanks to everyone who has participated in the review process so far. I've
> based this patch set on the current master. Things have really started to
> calmn down, so this is fairly similar to the v4 patch set. The most
> interes
, guaranteeing
> that we can always enable those, and fixing the 'randconfig' issues.
>
> Unfortunately, there is another problem that I have not found a
> good solution for: If any of the three drivers are built-in rather
> than loadable modules, then the module lo
7848.122.ca...@linux.intel.com
Acked-by: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-by: Luis R. Rodriguez
---
lib/Kconfig.debug | 11 +++
lib/Makefile| 1 +
lib/test_sysc
Add a few initial respective tests for an array:
o Echoing values separated by spaces works
o Echoing only first elements will set first elements
o Confirm PAGE_SIZE limit still applies even if an array is used
Cc: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-
Test against a simple proc_douintvec() case. While at it, add
a test against UINT_MAX. Make sure UINT_MAX works, and UINT_MAX+1
will fail and that negative values are not accepted.
Cc: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-by: Luis R. Rodriguez
---
lib/tes
xt 20170630-test-sysctl branch
based on linux-next next20170630 [0]. If there are any questionms please let me
know.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170630-test-sysctl
Luis
Luis R. Rodriguez (6):
test_sysctl: add dedicated proc sysctl test dri
number of times, say we want to run
a test case 100 times:
./sysctl.sh -c 0001 100
To run a test case only once, for example:
./sysctl.sh -s 0002
The default settings are specified at the top of sysctl.sh.
Cc: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-by: Luis R.
Test against a simple proc_dointvec() case. While at it, add a test
against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 will fail. Also
test negative values work.
Cc: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-by: Luis R. Rodriguez
---
lib/tes
shell reset_vals() with a reset to values we know
are set at init on the driver.
Cc: Kees Cook
Cc: "Eric W. Biederman"
Cc: Shuah Khan
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/sysctl/sysctl.sh | 66
1 file changed, 66 insertion
On Thu, Jun 29, 2017 at 12:35:27PM -0700, Andrew Morton wrote:
> On Wed, 28 Jun 2017 18:31:11 +1000 Stephen Rothwell
> wrote:
>
> > Hi all,
> >
> > Today's linux-next merge of the akpm-current tree got conflicts in:
> >
> > tools/testing/selftests/sysctl/common_tests
> > tools/testing/self
On Thu, Jun 29, 2017 at 3:53 PM, Jakub Kicinski
wrote:
> On Fri, 30 Jun 2017 00:50:03 +0200, Luis R. Rodriguez wrote:
>> On Thu, Jun 29, 2017 at 01:58:22PM -0700, Jakub Kicinski wrote:
>> > On Thu, 29 Jun 2017 21:44:55 +0200, Luis R. Rodriguez wrote:
>> &
On Thu, Jun 29, 2017 at 01:58:22PM -0700, Jakub Kicinski wrote:
> On Thu, 29 Jun 2017 21:44:55 +0200, Luis R. Rodriguez wrote:
> > > Since this swake_up() --> swake_up_all() reportedly *fixed* the one wake
> > > up
> > > issue it would seem this does queu
Fixes: 5b029624948d ("firmware: do not use fw_lock for fw_state protection")
Reported-by: Jakub Kicinski
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/base/firmware_class.c b
It has been reported that SIGCHLD will trigger an immediate abort
on sync firmware requests which rely on the sysfs interface for a
trigger. This is unexpected behaviour, this reproduces this issue.
This test case currenty fails.
Reported-by: Martin Fuzzey
Signed-off-by: Luis R. Rodriguez
Right now we send -EAGAIN to a syfs write which got interrupted.
Userspace can't tell what happened though, send -EINTR if we
were killed due to a signal so userspace can tell things apart.
This is only applicable to the fallback mechanism.
Reported-by: Martin Fuzzey
Signed-off-by: L
it_for_completion is
interrupted")
Suggested-by: "Eric W. Biederman"
Suggested-by: Dmitry Torokhov
Tested-by: Martin Fuzzey
Reported-by: Martin Fuzzey
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_class.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --gi
nel/git/mcgrof/linux-next.git/log/?h=20170629-fw-fixes-wait-v3
Luis R. Rodriguez (4):
firmware: fix batched requests - wake all waiters
test_firmware: add test case for SIGCHLD on sync fallback
firmware: avoid invalid fallback aborts by using killable wait
firmware: send -EINTR on sign
On Thu, Jun 29, 2017 at 12:08 PM, Davidlohr Bueso wrote:
> On Tue, 27 Jun 2017, Luis R. Rodriguez wrote:
>>
>> * As a side effect of this; the data structures are slimmer.
>> *
>> - * One would recommend using this wait queue where possible.
>> + * NOTE: swa
On Thu, Jun 29, 2017 at 09:40:15PM +0200, Luis R. Rodriguez wrote:
> On Thu, Jun 29, 2017 at 11:59:29AM -0700, Linus Torvalds wrote:
> > On Thu, Jun 29, 2017 at 11:33 AM, Davidlohr Bueso wrote:
> > > On Thu, 29 Jun 2017, Linus Torvalds wrote:
> > >
> > >>
On Thu, Jun 29, 2017 at 11:59:29AM -0700, Linus Torvalds wrote:
> On Thu, Jun 29, 2017 at 11:33 AM, Davidlohr Bueso wrote:
> > On Thu, 29 Jun 2017, Linus Torvalds wrote:
> >
> >> I actually think swait is pure garbage. Most users only wake up one
> >> process anyway, and using swait for that is st
On Thu, Jun 29, 2017 at 05:17:15PM +0200, Greg KH wrote:
> On Thu, Jun 29, 2017 at 05:16:41PM +0200, Greg KH wrote:
> > On Mon, Jun 26, 2017 at 02:23:12PM -0700, Luis R. Rodriguez wrote:
> > > From: Jakub Kicinski
> > >
> > > The firmware cache mechanis
On Thu, Jun 29, 2017 at 05:14:42PM +0200, Greg KH wrote:
> On Wed, Jun 14, 2017 at 03:20:13PM -0700, Luis R. Rodriguez wrote:
> > Martin reported an issue with Android where if sysfs is used to trigger a
> > sync
> > fw load which *relies* on the fallback mechanism
501 - 600 of 3112 matches
Mail list logo
