Re: [PATCH 2/3] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-02-20 Thread Luis R. Rodriguez
On Tue, Feb 20, 2018 at 03:17:05PM -0800, Andrew Morton wrote: > On Mon, 19 Feb 2018 11:53:50 -0500 Waiman Long wrote: > > > Even with clamped sysctl parameters, it is still not that straight > > forward to figure out the exact range of those parameters. One may > > try to

Re: [PATCH 2/3] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-02-20 Thread Luis R. Rodriguez
On Tue, Feb 20, 2018 at 03:17:05PM -0800, Andrew Morton wrote: > On Mon, 19 Feb 2018 11:53:50 -0500 Waiman Long wrote: > > > Even with clamped sysctl parameters, it is still not that straight > > forward to figure out the exact range of those parameters. One may > > try to write extreme

Re: [PATCH 1/3] sysctl: Add range clamping intvec helper functions

2018-02-20 Thread Luis R. Rodriguez
On Mon, Feb 19, 2018 at 11:53:49AM -0500, Waiman Long wrote: > The current intvec range helper functions will fail with error when > users try to assign an out-of-range value. As designed. > The following new non-failing range helper functions are now added: > - proc_dointvec_clamp_minmax() >

Re: [PATCH 1/3] sysctl: Add range clamping intvec helper functions

2018-02-20 Thread Luis R. Rodriguez
On Mon, Feb 19, 2018 at 11:53:49AM -0500, Waiman Long wrote: > The current intvec range helper functions will fail with error when > users try to assign an out-of-range value. As designed. > The following new non-failing range helper functions are now added: > - proc_dointvec_clamp_minmax() >

[TEST for] fs: global sync to not clear error status of individual inodes

2018-02-14 Thread Luis R. Rodriguez
Junichi, curious if you ever got to adapt a test case for xfstests for your patch "fs: global sync to not clear error status of individual inodes", which got merged as of v4.4 as: aa750fd71c242dba02ee2034e15fbd7d0cdb2461 mm/filemap.c: make global sync not clear error status of individual inodes

[TEST for] fs: global sync to not clear error status of individual inodes

2018-02-14 Thread Luis R. Rodriguez
Junichi, curious if you ever got to adapt a test case for xfstests for your patch "fs: global sync to not clear error status of individual inodes", which got merged as of v4.4 as: aa750fd71c242dba02ee2034e15fbd7d0cdb2461 mm/filemap.c: make global sync not clear error status of individual inodes

[PATCH v2 04/11] firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further

2018-02-13 Thread Luis R. Rodriguez
All CONFIG_FW_LOADER_USER_HELPER_FALLBACK really is, is just a bool, initailized at build time. Define it as such. This simplifies the logic even further, removing now all explicit #ifdefs around the code. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_lo

[PATCH v2 04/11] firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further

2018-02-13 Thread Luis R. Rodriguez
All CONFIG_FW_LOADER_USER_HELPER_FALLBACK really is, is just a bool, initailized at build time. Define it as such. This simplifies the logic even further, removing now all explicit #ifdefs around the code. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader.c | 25

[PATCH v2 02/11] test_firmware: replace syfs fallback check with kconfig_has helper

2018-02-13 Thread Luis R. Rodriguez
Now that we have a kconfig checker just use that instead of relying on testing a sysfs directory being present, since our requirements are spelled out. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tools/testing/selftests/firmware/fw_fallback.sh | 5 + 1 file changed, 1 ins

[PATCH v2 00/11] firmware: cleanup for v4.17

2018-02-13 Thread Luis R. Rodriguez
onto its own file, a goal I've been aiming for a while now. 0-day has given me its blessings on these builds. Questions, feedback, rants all equally welcomed. [0] https://lkml.kernel.org/r/938069cf-4478-2e46-f195-386830ce1...@kernel.org Luis R. Rodriguez (11): test_firmware: enable custom

[PATCH v2 01/11] test_firmware: enable custom fallback testing on limited kernel configs

2018-02-13 Thread Luis R. Rodriguez
for now. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tools/testing/selftests/firmware/config | 4 +++ tools/testing/selftests/firmware/fw_fallback.sh | 45 - 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/fi

[PATCH v2 02/11] test_firmware: replace syfs fallback check with kconfig_has helper

2018-02-13 Thread Luis R. Rodriguez
Now that we have a kconfig checker just use that instead of relying on testing a sysfs directory being present, since our requirements are spelled out. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests/firmware/fw_fallback.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH v2 00/11] firmware: cleanup for v4.17

2018-02-13 Thread Luis R. Rodriguez
onto its own file, a goal I've been aiming for a while now. 0-day has given me its blessings on these builds. Questions, feedback, rants all equally welcomed. [0] https://lkml.kernel.org/r/938069cf-4478-2e46-f195-386830ce1...@kernel.org Luis R. Rodriguez (11): test_firmware: enable custom

[PATCH v2 01/11] test_firmware: enable custom fallback testing on limited kernel configs

2018-02-13 Thread Luis R. Rodriguez
for now. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests/firmware/config | 4 +++ tools/testing/selftests/firmware/fw_fallback.sh | 45 - 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/firmware/config b/tools

[PATCH v2 05/11] firmware: use helpers for setting up a temporary cache timeout

2018-02-13 Thread Luis R. Rodriguez
. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader.c | 49 ++ 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/base/firmware_loader.c b/drivers/base/firmware_loader.c index 59dba794ce1a..2d8198

[PATCH v2 05/11] firmware: use helpers for setting up a temporary cache timeout

2018-02-13 Thread Luis R. Rodriguez
. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader.c | 49 ++ 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/base/firmware_loader.c b/drivers/base/firmware_loader.c index 59dba794ce1a..2d819875348d 100644

[PATCH v2 09/11] firmware: enable to force disable the fallback mechanism at run time

2018-02-13 Thread Luis R. Rodriguez
You currently need four different kernel builds to test the firmware API fully. By adding a proc knob to force disable the fallback mechanism completely we are able to reduce the amount of kernels you need built to test the firmware API down to two. Signed-off-by: Luis R. Rodriguez <

[PATCH v2 09/11] firmware: enable to force disable the fallback mechanism at run time

2018-02-13 Thread Luis R. Rodriguez
You currently need four different kernel builds to test the firmware API fully. By adding a proc knob to force disable the fallback mechanism completely we are able to reduce the amount of kernels you need built to test the firmware API down to two. Signed-off-by: Luis R. Rodriguez --- drivers

[PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-13 Thread Luis R. Rodriguez
The firmware fallback code is optional. Split that code out to help distinguish the fallback functionlity from othere core firmware loader features. This should make it easier to maintain and review code changes. This introduces no functional changes. Signed-off-by: Luis R. Rodriguez <

[PATCH v2 07/11] firmware: split firmware fallback functionality into its own file

2018-02-13 Thread Luis R. Rodriguez
The firmware fallback code is optional. Split that code out to help distinguish the fallback functionlity from othere core firmware loader features. This should make it easier to maintain and review code changes. This introduces no functional changes. Signed-off-by: Luis R. Rodriguez

[PATCH v2 08/11] firmware: enable run time change of forcing fallback loader

2018-02-13 Thread Luis R. Rodriguez
to inspect if CONFIG_FW_LOADER_USER_HELPER_FALLBACK was enabled at build time by checking the proc value at boot time. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_fallback.c | 22 +- kernel/sysctl.c | 11 +++ 2 files c

[PATCH v2 11/11] test_firmware: test three firmware kernel configs using a proc knob

2018-02-13 Thread Luis R. Rodriguez
(CONFIG_IKCONFIG_PROC) or haven't enabled CONFIG_FW_LOADER_USER_HELPER we cannot run these dynamic tests, so just run both scripts just as we used to before making blunt assumptions about your setup and requirements exactly as we did before. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.

[PATCH v2 11/11] test_firmware: test three firmware kernel configs using a proc knob

2018-02-13 Thread Luis R. Rodriguez
(CONFIG_IKCONFIG_PROC) or haven't enabled CONFIG_FW_LOADER_USER_HELPER we cannot run these dynamic tests, so just run both scripts just as we used to before making blunt assumptions about your setup and requirements exactly as we did before. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests

[PATCH v2 08/11] firmware: enable run time change of forcing fallback loader

2018-02-13 Thread Luis R. Rodriguez
to inspect if CONFIG_FW_LOADER_USER_HELPER_FALLBACK was enabled at build time by checking the proc value at boot time. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_fallback.c | 22 +- kernel/sysctl.c | 11 +++ 2 files changed, 32 insertions(+), 1

[PATCH v2 10/11] test_firmware: add a library for shared helpers

2018-02-13 Thread Luis R. Rodriguez
Both fw_fallback.sh and fw_filesystem.sh share a common set of boiler plate setup and tests. We can share these in a common place. While at it, move both test to use /bin/bash. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tools/testing/selftests/firmware/fw_fallback.sh

[PATCH v2 06/11] firmware: move loading timeout under struct firmware_fallback_config

2018-02-13 Thread Luis R. Rodriguez
, and that is used as an unsigned long. There a few cases however where it makes sense to get or set the timeout as an int, the helpers annotate these use cases have been properly vetted for. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader.

[PATCH v2 10/11] test_firmware: add a library for shared helpers

2018-02-13 Thread Luis R. Rodriguez
Both fw_fallback.sh and fw_filesystem.sh share a common set of boiler plate setup and tests. We can share these in a common place. While at it, move both test to use /bin/bash. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests/firmware/fw_fallback.sh | 69 ++--- tools

[PATCH v2 06/11] firmware: move loading timeout under struct firmware_fallback_config

2018-02-13 Thread Luis R. Rodriguez
, and that is used as an unsigned long. There a few cases however where it makes sense to get or set the timeout as an int, the helpers annotate these use cases have been properly vetted for. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader.c | 46 ++ 1

[PATCH v2 03/11] firmware: enable to split firmware_class into separate target files

2018-02-13 Thread Luis R. Rodriguez
. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/Makefile| 1 + drivers/base/{firmware_class.c => firmware_loader.c} | 0 2 files changed, 1 insertion(+) rename drivers/base/{firmware_class.c => firmware_loader.c} (100%) diff --git a/

[PATCH v2 03/11] firmware: enable to split firmware_class into separate target files

2018-02-13 Thread Luis R. Rodriguez
. Signed-off-by: Luis R. Rodriguez --- drivers/base/Makefile| 1 + drivers/base/{firmware_class.c => firmware_loader.c} | 0 2 files changed, 1 insertion(+) rename drivers/base/{firmware_class.c => firmware_loader.c} (100%) diff --git a/drivers/base/Makefile b/d

[PATCH 1/2] fstests: move expunge test into a helper

2018-01-20 Thread Luis R. Rodriguez
Move the expunge test into a helper. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- check | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/check b/check index f8db3cd6dfab..0ba71d5d2005 100755 --- a/check +++ b/check @@ -485,6 +

[PATCH 1/2] fstests: move expunge test into a helper

2018-01-20 Thread Luis R. Rodriguez
Move the expunge test into a helper. Signed-off-by: Luis R. Rodriguez --- check | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/check b/check index f8db3cd6dfab..0ba71d5d2005 100755 --- a/check +++ b/check @@ -485,6 +485,18 @@ _check_filesystems

[PATCH 2/2] fstests: expunge tests when doing a dry run

2018-01-20 Thread Luis R. Rodriguez
Running ./check with -n will not execute tests, however when exclude files are used we still show them as if they are run. Test the exclude file prior to assuming we can run a test on a dry run. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- check | 4 1 file changed, 4 inse

[PATCH 2/2] fstests: expunge tests when doing a dry run

2018-01-20 Thread Luis R. Rodriguez
Running ./check with -n will not execute tests, however when exclude files are used we still show them as if they are run. Test the exclude file prior to assuming we can run a test on a dry run. Signed-off-by: Luis R. Rodriguez --- check | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

2018-01-09 Thread Luis R. Rodriguez
On Tue, Jan 09, 2018 at 04:10:54PM +0100, Dongsu Park wrote: > On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > > I think this patch would read much better and easier to review i

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

2018-01-09 Thread Luis R. Rodriguez
On Tue, Jan 09, 2018 at 04:10:54PM +0100, Dongsu Park wrote: > On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > > I think this patch would read much better and easier to review if it was > > spl

Re: general protection fault in find_entry

2018-01-05 Thread Luis R. Rodriguez
On Fri, Dec 22, 2017 at 11:33:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in find_entry

2018-01-05 Thread Luis R. Rodriguez
On Fri, Dec 22, 2017 at 11:33:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

2018-01-05 Thread Luis R. Rodriguez
On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > diff --git a/fs/attr.c b/fs/attr.c > index 12ffdb6f..bf8e94f3 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -18,6 +18,30 @@ > #include > #include > > +static bool chown_ok(const struct inode *inode, kuid_t uid) > +{ > + if

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

2018-01-05 Thread Luis R. Rodriguez
On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > diff --git a/fs/attr.c b/fs/attr.c > index 12ffdb6f..bf8e94f3 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -18,6 +18,30 @@ > #include > #include > > +static bool chown_ok(const struct inode *inode, kuid_t uid) > +{ > + if

Re: [PATCH] linux-next: firmware: Fix a typo in fallback-mechanisms.rst

2018-01-05 Thread Luis R. Rodriguez
On Fri, Jan 05, 2018 at 09:00:41PM +0900, Masanari Iida wrote: > This patch fix a spelling typo found in fallback-mechanisms.rst > > Signed-off-by: Masanari Iida <standby2...@gmail.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Luis

Re: [PATCH] linux-next: firmware: Fix a typo in fallback-mechanisms.rst

2018-01-05 Thread Luis R. Rodriguez
On Fri, Jan 05, 2018 at 09:00:41PM +0900, Masanari Iida wrote: > This patch fix a spelling typo found in fallback-mechanisms.rst > > Signed-off-by: Masanari Iida Acked-by: Luis R. Rodriguez Luis

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

2018-01-04 Thread Luis R. Rodriguez
On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > This patch series fix processing MAC address for wl1251 chip found in Nokia > > N900. > > > > Changes since v1: > > * Added Acked-by for Pavel Machek > > * Fixed grammar > > *

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

2018-01-04 Thread Luis R. Rodriguez
On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > This patch series fix processing MAC address for wl1251 chip found in Nokia > > N900. > > > > Changes since v1: > > * Added Acked-by for Pavel Machek > > * Fixed grammar > > *

Re: [PATCH] generic/381: enable on systems which allows usernames that begin with digits

2017-12-21 Thread Luis R. Rodriguez
On Thu, Dec 21, 2017 at 04:23:42PM +0800, Eryu Guan wrote: > On Fri, Dec 15, 2017 at 12:41:07PM -0800, Luis R. Rodriguez wrote: > > Some systems are not allowing usernames prefixed with a number now, this > > test however relies on the assumption that you can end up with usernames &

Re: [PATCH] generic/381: enable on systems which allows usernames that begin with digits

2017-12-21 Thread Luis R. Rodriguez
On Thu, Dec 21, 2017 at 04:23:42PM +0800, Eryu Guan wrote: > On Fri, Dec 15, 2017 at 12:41:07PM -0800, Luis R. Rodriguez wrote: > > Some systems are not allowing usernames prefixed with a number now, this > > test however relies on the assumption that you can end up with usernames &

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-12-19 Thread Luis R. Rodriguez
On Wed, Dec 13, 2017 at 02:09:49AM +0100, Rafael J. Wysocki wrote: > I'm assuming an update of this to be posted due to the comments from Jan > on patch [3/11] and patch [7/11] probably. > > Is there anything else that needs to be addressed? I was waiting on Jan Kara's feedback on how he'd like

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-12-19 Thread Luis R. Rodriguez
On Wed, Dec 13, 2017 at 02:09:49AM +0100, Rafael J. Wysocki wrote: > I'm assuming an update of this to be posted due to the comments from Jan > on patch [3/11] and patch [7/11] probably. > > Is there anything else that needs to be addressed? I was waiting on Jan Kara's feedback on how he'd like

[PATCH] tests/xfs/040: document purpose

2017-12-15 Thread Luis R. Rodriguez
s. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/xfs/040 | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/xfs/040 b/tests/xfs/040 index fadb888cbfaf..a0abc42f3720 100755 --- a/tests/xfs/040 +++ b/tests/xfs/040 @@ -3,6 +3,11 @@ # # compare-libxfs test

[PATCH] tests/xfs/040: document purpose

2017-12-15 Thread Luis R. Rodriguez
s. Signed-off-by: Luis R. Rodriguez --- tests/xfs/040 | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/xfs/040 b/tests/xfs/040 index fadb888cbfaf..a0abc42f3720 100755 --- a/tests/xfs/040 +++ b/tests/xfs/040 @@ -3,6 +3,11 @@ # # compare-libxfs test # +# The purpose of this test is o

[PATCH] generic/381: enable on systems which allows usernames that begin with digits

2017-12-15 Thread Luis R. Rodriguez
com/systemd/systemd/issues/6237 [1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-182 [2] https://github.com/shadow-maint/shadow/commit/9db6abfa42c946b4046f4b2fe67dc43ba862eb0e Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- README| 7 +-- common/config

[PATCH] generic/381: enable on systems which allows usernames that begin with digits

2017-12-15 Thread Luis R. Rodriguez
com/systemd/systemd/issues/6237 [1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-182 [2] https://github.com/shadow-maint/shadow/commit/9db6abfa42c946b4046f4b2fe67dc43ba862eb0e Signed-off-by: Luis R. Rodriguez --- README| 7 +-- common/config | 1 + common

Re: [PATCH 2/2] kconfig: drop 'boolean' keyword

2017-12-15 Thread Luis R. Rodriguez
amada.masah...@socionext.com> Provided you get 0-day test it without complaints: Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Luis

Re: [PATCH 2/2] kconfig: drop 'boolean' keyword

2017-12-15 Thread Luis R. Rodriguez
ovided you get 0-day test it without complaints: Acked-by: Luis R. Rodriguez Luis

Re: [PATCH] kconfig: display recursive dependency resolution hint just once

2017-12-15 Thread Luis R. Rodriguez
ble. > > Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / > resolution" > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Luis

Re: [PATCH] kconfig: display recursive dependency resolution hint just once

2017-12-15 Thread Luis R. Rodriguez
ble. > > Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / > resolution" > Signed-off-by: Masahiro Yamada Acked-by: Luis R. Rodriguez Luis

Re: [PATCH 4/9] build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 01:51:02PM +0800, Eryu Guan wrote: > On Tue, Dec 12, 2017 at 04:45:14PM -0800, Luis R. Rodriguez wrote: > > Modern gdbm-devel packages bundle together gdbm.h and ndbm.h. > > The old m4 macro had detection support for some old gdbm libraries > >

Re: [PATCH 4/9] build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 01:51:02PM +0800, Eryu Guan wrote: > On Tue, Dec 12, 2017 at 04:45:14PM -0800, Luis R. Rodriguez wrote: > > Modern gdbm-devel packages bundle together gdbm.h and ndbm.h. > > The old m4 macro had detection support for some old gdbm libraries > >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 10:39:14AM +1100, Dave Chinner wrote: > You can't just run an internal log test then add couple of extra > external log tests and say "external logs work fine". > > > Automatic detection if the requirements are met is fine, but this doesn't > > let me easily use say: > >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-14 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 10:39:14AM +1100, Dave Chinner wrote: > You can't just run an internal log test then add couple of extra > external log tests and say "external logs work fine". > > > Automatic detection if the requirements are met is fine, but this doesn't > > let me easily use say: > >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > This should make it easy to run these separately or exclude them. > > These should notrun automatically if you don't have an external log >

Re: [PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-13 Thread Luis R. Rodriguez
On Thu, Dec 14, 2017 at 08:50:13AM +1100, Dave Chinner wrote: > On Tue, Dec 12, 2017 at 04:45:15PM -0800, Luis R. Rodriguez wrote: > > This should make it easy to run these separately or exclude them. > > These should notrun automatically if you don't have an external log >

[PATCH 2/9] README: document group fsgqa is required

2017-12-12 Thread Luis R. Rodriguez
The group fsgqa is also required. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index e05142be1a87..271d7df22b56 100644 --- a/README +++ b/README @@ -20,6 +20,7 @@ ___ - run make

[PATCH 2/9] README: document group fsgqa is required

2017-12-12 Thread Luis R. Rodriguez
The group fsgqa is also required. Signed-off-by: Luis R. Rodriguez --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index e05142be1a87..271d7df22b56 100644 --- a/README +++ b/README @@ -20,6 +20,7 @@ ___ - run make - run make install - create

[PATCH 6/9] tests/ext4/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/ext4/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ext4/group b/tests/ext4/group index 257bb646f312..6fa2f06432f3 100644 --- a

[PATCH 6/9] tests/ext4/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez --- tests/ext4/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ext4/group b/tests/ext4/group index 257bb646f312..6fa2f06432f3 100644 --- a/tests/ext4/group +++ b

[PATCH 0/9] fstests: few updates

2017-12-12 Thread Luis R. Rodriguez
of these tests are better designed to be run with a custom section and grouping them up helps with this. Luis R. Rodriguez (9): generic/381: use username fsgqa-381 README: document group fsgqa is required generic/group: add 304 to dedupe group build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c

[PATCH 4/9] build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build

2017-12-12 Thread Luis R. Rodriguez
both gdbm_ndbm_=true, and have_db=true, and define HAVE_GDBM_H. The src/dbtest.c already had a HAVE_GDBM_H but there was never a respective autoconf settter for it. We can just re-use this and fix it for new arrangement. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- m4/package_gdbm

[PATCH 0/9] fstests: few updates

2017-12-12 Thread Luis R. Rodriguez
of these tests are better designed to be run with a custom section and grouping them up helps with this. Luis R. Rodriguez (9): generic/381: use username fsgqa-381 README: document group fsgqa is required generic/group: add 304 to dedupe group build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c

[PATCH 4/9] build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build

2017-12-12 Thread Luis R. Rodriguez
both gdbm_ndbm_=true, and have_db=true, and define HAVE_GDBM_H. The src/dbtest.c already had a HAVE_GDBM_H but there was never a respective autoconf settter for it. We can just re-use this and fix it for new arrangement. Signed-off-by: Luis R. Rodriguez --- m4/package_gdbmdev.m4 | 8 src

[PATCH 7/9] tests/xfs/group: add realtimedev group

2017-12-12 Thread Luis R. Rodriguez
This groups up tests which require an external realtime volume, ie, SCRATCH_RTDEV. This requires CONFIG_XFS_RT and not all kernels support this. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/xfs/group | 36 ++-- 1 file changed, 18 inse

[PATCH 7/9] tests/xfs/group: add realtimedev group

2017-12-12 Thread Luis R. Rodriguez
This groups up tests which require an external realtime volume, ie, SCRATCH_RTDEV. This requires CONFIG_XFS_RT and not all kernels support this. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions

[PATCH 8/9] tests/xfs/group: add group for tests which require mkfs v4_5

2017-12-12 Thread Luis R. Rodriguez
This lets us skip these tests on newer systems. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/xfs/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xfs/group b/tests/xfs/group index 656b65f5fe7a..ebb1685e22eb 100644 --- a/tests/xfs/group +++ b

[PATCH 8/9] tests/xfs/group: add group for tests which require mkfs v4_5

2017-12-12 Thread Luis R. Rodriguez
This lets us skip these tests on newer systems. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xfs/group b/tests/xfs/group index 656b65f5fe7a..ebb1685e22eb 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -93,7

[PATCH 9/9] tests/xfs/group: add injection group

2017-12-12 Thread Luis R. Rodriguez
XFS error injection requires CONFIG_XFS_DEBUG and not all kernels have this enabled. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/xfs/group | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index ebb168

[PATCH 9/9] tests/xfs/group: add injection group

2017-12-12 Thread Luis R. Rodriguez
XFS error injection requires CONFIG_XFS_DEBUG and not all kernels have this enabled. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index ebb1685e22eb..1df0ab32b71c 100644

[PATCH 3/9] generic/group: add 304 to dedupe group

2017-12-12 Thread Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/generic/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/group b/tests/generic/group index 6c3bb03a9973..4e2fb0f720ba 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -306,7

[PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- tests/xfs/group | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index d23006041ea2..cce98847de53 100644 --- a

[PATCH 1/9] generic/381: use username fsgqa-381

2017-12-12 Thread Luis R. Rodriguez
Some systems are not allowing usernames prefixed with a number now. One can however use numbers as a postfix so use that. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- README| 2 +- tests/generic/381 | 16 tests/generic/381.out | 4 ++-- 3

[PATCH 3/9] generic/group: add 304 to dedupe group

2017-12-12 Thread Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez --- tests/generic/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/group b/tests/generic/group index 6c3bb03a9973..4e2fb0f720ba 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -306,7 +306,7 @@ 301 auto quick

[PATCH 5/9] tests/xfs/group: add group for tests which require a logdev

2017-12-12 Thread Luis R. Rodriguez
This should make it easy to run these separately or exclude them. Signed-off-by: Luis R. Rodriguez --- tests/xfs/group | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index d23006041ea2..cce98847de53 100644 --- a/tests/xfs/group +++ b

[PATCH 1/9] generic/381: use username fsgqa-381

2017-12-12 Thread Luis R. Rodriguez
Some systems are not allowing usernames prefixed with a number now. One can however use numbers as a postfix so use that. Signed-off-by: Luis R. Rodriguez --- README| 2 +- tests/generic/381 | 16 tests/generic/381.out | 4 ++-- 3 files changed, 11

[PATCH 2/3] module: move finished_loading()

2017-12-07 Thread Luis R. Rodriguez
This has no functional change, just moves a routine earlier as we'll make use of it next. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- kernel/module.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/kernel/modu

[PATCH 1/3] module: add an early early_mod_check()

2017-12-07 Thread Luis R. Rodriguez
with pointing to the user data. Just move this out into the laod_module() routine to make the early_mod_check() routine much simpler. This change just shuffles code around a bit to make the next change easier to read, it technically has no functional changes. Signed-off-by: Luis R. Rodriguez <

[PATCH 2/3] module: move finished_loading()

2017-12-07 Thread Luis R. Rodriguez
This has no functional change, just moves a routine earlier as we'll make use of it next. Signed-off-by: Luis R. Rodriguez --- kernel/module.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index

[PATCH 1/3] module: add an early early_mod_check()

2017-12-07 Thread Luis R. Rodriguez
with pointing to the user data. Just move this out into the laod_module() routine to make the early_mod_check() routine much simpler. This change just shuffles code around a bit to make the next change easier to read, it technically has no functional changes. Signed-off-by: Luis R. Rodriguez

[PATCH 3/3] module: avoid allocation if module is already present and ready

2017-12-07 Thread Luis R. Rodriguez
70 80 In terms of max memory use we have: $ sort -n -r log-0009-before.txt | head -1 2083344 $ sort -n -r log-0009-after.txt | head -1 2076236 So there is not much difference for this commit when we hammer on get_fs_type(). Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- ker

[PATCH 3/3] module: avoid allocation if module is already present and ready

2017-12-07 Thread Luis R. Rodriguez
70 80 In terms of max memory use we have: $ sort -n -r log-0009-before.txt | head -1 2083344 $ sort -n -r log-0009-after.txt | head -1 2076236 So there is not much difference for this commit when we hammer on get_fs_type(). Signed-off-by: Luis R. Rodriguez --- kernel/module.c | 3

[PATCH 0/3] module: minor allocation optimization

2017-12-07 Thread Luis R. Rodriguez
git/mcgrof/linux.git/log/?h=20171207-avoid-bogus-layout_and_allocate [1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20171207-avoid-bogus-layout_and_allocate Luis R. Rodriguez (3): module: add an early early_mod_check() module: move finished_loading() module: av

[PATCH 0/3] module: minor allocation optimization

2017-12-07 Thread Luis R. Rodriguez
git/mcgrof/linux.git/log/?h=20171207-avoid-bogus-layout_and_allocate [1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20171207-avoid-bogus-layout_and_allocate Luis R. Rodriguez (3): module: add an early early_mod_check() module: move finished_loading() module: av

Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown

2017-12-07 Thread Luis R. Rodriguez
On Tue, Dec 05, 2017 at 11:27:58AM +0100, Pavel Machek wrote: > Hi! > > > > Our ability to determine that userland hasn't been tampered with > > > depends on the kernel being trustworthy. If userland can upload > > > arbitrary firmware to DMA-capable devices then we can no longer trust > > > the

Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown

2017-12-07 Thread Luis R. Rodriguez
On Tue, Dec 05, 2017 at 11:27:58AM +0100, Pavel Machek wrote: > Hi! > > > > Our ability to determine that userland hasn't been tampered with > > > depends on the kernel being trustworthy. If userland can upload > > > arbitrary firmware to DMA-capable devices then we can no longer trust > > > the

Re: module: add debugging alias parsing support

2017-12-07 Thread Luis R. Rodriguez
On Mon, Dec 04, 2017 at 10:01:02AM +0100, Djalal Harouni wrote: > Luis in your commit log you say: > > "Obviously userspace can be buggy though, and it can lie to us. We > currently have no easy way to determine this." > > Could you please share some info here ? how userspace can be buggy ?

Re: module: add debugging alias parsing support

2017-12-07 Thread Luis R. Rodriguez
On Mon, Dec 04, 2017 at 10:01:02AM +0100, Djalal Harouni wrote: > Luis in your commit log you say: > > "Obviously userspace can be buggy though, and it can lie to us. We > currently have no easy way to determine this." > > Could you please share some info here ? how userspace can be buggy ?

Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown

2017-12-04 Thread Luis R. Rodriguez
On Mon, Nov 13, 2017 at 09:08:48PM +, Alan Cox wrote: > On Mon, 13 Nov 2017 18:42:50 +0100 > "Luis R. Rodriguez" <mcg...@kernel.org> wrote: > > > On Sat, Nov 11, 2017 at 02:32:40AM +, Alan Cox wrote: > > > > My assumption here is: > > >

Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown

2017-12-04 Thread Luis R. Rodriguez
On Mon, Nov 13, 2017 at 09:08:48PM +, Alan Cox wrote: > On Mon, 13 Nov 2017 18:42:50 +0100 > "Luis R. Rodriguez" wrote: > > > On Sat, Nov 11, 2017 at 02:32:40AM +, Alan Cox wrote: > > > > My assumption here is: > > > > 1) there ar

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Luis R. Rodriguez
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Luis R. Rodriguez
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl

Re: [PATCH 03/11] fs: add frozen sb state helpers

2017-12-01 Thread Luis R. Rodriguez
On Fri, Dec 01, 2017 at 12:47:24PM +0100, Jan Kara wrote: > On Thu 30-11-17 20:05:48, Luis R. Rodriguez wrote: > > On Thu, Nov 30, 2017 at 06:13:10PM +0100, Jan Kara wrote: > > > ... I dislike the _by_user() suffix as there may be different places that > > > call freeze_

Re: [PATCH 03/11] fs: add frozen sb state helpers

2017-12-01 Thread Luis R. Rodriguez
On Fri, Dec 01, 2017 at 12:47:24PM +0100, Jan Kara wrote: > On Thu 30-11-17 20:05:48, Luis R. Rodriguez wrote: > > On Thu, Nov 30, 2017 at 06:13:10PM +0100, Jan Kara wrote: > > > ... I dislike the _by_user() suffix as there may be different places that > > > call freeze_

<    2   3   4   5   6   7   8   9   10   11   >