Re: [PATCH] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Tue, 2 Jul 2013 21:47:03 +0200 Pavel Machek wrote: > On Tue 2013-07-02 11:06:28, Luiz Capitulino wrote: > > On Mon, 1 Jul 2013 10:51:03 +0200 > > Pavel Machek wrote: > > > > > Hi! > > > > > > > diff --git a/Documentation/cgroups/mem

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Tue, 2 Jul 2013 10:24:09 -0700 Anton Vorontsov wrote: > > Honestly, what Andrew suggested is the best design for me: apps > > are notified on all events but the event name is sent to the application. > > I am fine with this approach (or any other, I'm really indifferent to the > API itself

Re: [PATCH] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Mon, 1 Jul 2013 10:51:03 +0200 Pavel Machek wrote: > Hi! > > > diff --git a/Documentation/cgroups/memory.txt > > b/Documentation/cgroups/memory.txt > > index ddf4f93..3c589cf 100644 > > --- a/Documentation/cgroups/memory.txt > > +++ b/Documentation/cgroups/memory.txt > > @@ -807,12 +807,14

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Fri, 28 Jun 2013 17:56:37 -0700 Anton Vorontsov wrote: > On Fri, Jun 28, 2013 at 03:44:02PM -0400, Luiz Capitulino wrote: > > > Why can't you use poll() and demultiplex the events? Check if there is an > > > event in the crit fd, and if there is, then jus

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Tue, 2 Jul 2013 10:24:09 -0700 Anton Vorontsov an...@enomsg.org wrote: Honestly, what Andrew suggested is the best design for me: apps are notified on all events but the event name is sent to the application. I am fine with this approach (or any other, I'm really indifferent to the API

Re: [PATCH] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Tue, 2 Jul 2013 21:47:03 +0200 Pavel Machek pa...@ucw.cz wrote: On Tue 2013-07-02 11:06:28, Luiz Capitulino wrote: On Mon, 1 Jul 2013 10:51:03 +0200 Pavel Machek pa...@ucw.cz wrote: Hi! diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Fri, 28 Jun 2013 17:56:37 -0700 Anton Vorontsov an...@enomsg.org wrote: On Fri, Jun 28, 2013 at 03:44:02PM -0400, Luiz Capitulino wrote: Why can't you use poll() and demultiplex the events? Check if there is an event in the crit fd, and if there is, then just ignore all the rest

Re: [PATCH] vmpressure: implement strict mode

2013-07-02 Thread Luiz Capitulino
On Mon, 1 Jul 2013 10:51:03 +0200 Pavel Machek pa...@ucw.cz wrote: Hi! diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt index ddf4f93..3c589cf 100644 --- a/Documentation/cgroups/memory.txt +++ b/Documentation/cgroups/memory.txt @@ -807,12 +807,14 @@

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 11:55:47 -0700 Anton Vorontsov wrote: > On Fri, Jun 28, 2013 at 02:45:07PM -0400, Luiz Capitulino wrote: > > On Fri, 28 Jun 2013 10:09:17 -0700 > > Anton Vorontsov wrote: > > > > > So, I would now argue that the current scheme is perfectly OK a

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 11:45:47 -0700 Anton Vorontsov wrote: > On Fri, Jun 28, 2013 at 02:25:58PM -0400, Luiz Capitulino wrote: > > > > > That's how it's expected to work, because on strict mode you're > > > > > notified > > > > > for the level you

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 10:09:17 -0700 Anton Vorontsov wrote: > So, I would now argue that the current scheme is perfectly OK and can do > everything you can do with the "strict" one, I forgot commenting this bit. This is not true, because I don't want a low fd to be notified on critical level. The

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 10:09:17 -0700 Anton Vorontsov wrote: > On Fri, Jun 28, 2013 at 09:57:22AM -0700, Anton Vorontsov wrote: > > On Fri, Jun 28, 2013 at 10:00:27AM -0400, Luiz Capitulino wrote: > > > On Thu, 27 Jun 2013 22:07:12 -0700 > > > Anton Vorontsov wrote: &g

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Thu, 27 Jun 2013 22:07:12 -0700 Anton Vorontsov wrote: > On Thu, Jun 27, 2013 at 09:34:11PM -0700, Anton Vorontsov wrote: > > ... we can add the strict mode and deprecate the > > "filtering" -- basically we'll implement the idea of requiring that > > userspace registers a separate fd for each

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Thu, 27 Jun 2013 21:34:11 -0700 Anton Vorontsov wrote: > On Thu, Jun 27, 2013 at 06:13:53PM -0700, Andrew Morton wrote: > > On Thu, 27 Jun 2013 17:58:53 -0700 Anton Vorontsov wrote: > > > Current frequency is 1/(2MB). Suppose we ended up scanning the whole > > > memory on a 2GB host, this

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Thu, 27 Jun 2013 21:34:11 -0700 Anton Vorontsov an...@enomsg.org wrote: On Thu, Jun 27, 2013 at 06:13:53PM -0700, Andrew Morton wrote: On Thu, 27 Jun 2013 17:58:53 -0700 Anton Vorontsov an...@enomsg.org wrote: Current frequency is 1/(2MB). Suppose we ended up scanning the whole memory

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Thu, 27 Jun 2013 22:07:12 -0700 Anton Vorontsov an...@enomsg.org wrote: On Thu, Jun 27, 2013 at 09:34:11PM -0700, Anton Vorontsov wrote: ... we can add the strict mode and deprecate the filtering -- basically we'll implement the idea of requiring that userspace registers a separate fd

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 10:09:17 -0700 Anton Vorontsov an...@enomsg.org wrote: On Fri, Jun 28, 2013 at 09:57:22AM -0700, Anton Vorontsov wrote: On Fri, Jun 28, 2013 at 10:00:27AM -0400, Luiz Capitulino wrote: On Thu, 27 Jun 2013 22:07:12 -0700 Anton Vorontsov an...@enomsg.org wrote

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 10:09:17 -0700 Anton Vorontsov an...@enomsg.org wrote: So, I would now argue that the current scheme is perfectly OK and can do everything you can do with the strict one, I forgot commenting this bit. This is not true, because I don't want a low fd to be notified on

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 11:45:47 -0700 Anton Vorontsov an...@enomsg.org wrote: On Fri, Jun 28, 2013 at 02:25:58PM -0400, Luiz Capitulino wrote: That's how it's expected to work, because on strict mode you're notified for the level you registered for. So apps registering for critical

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Luiz Capitulino
On Fri, 28 Jun 2013 11:55:47 -0700 Anton Vorontsov an...@enomsg.org wrote: On Fri, Jun 28, 2013 at 02:45:07PM -0400, Luiz Capitulino wrote: On Fri, 28 Jun 2013 10:09:17 -0700 Anton Vorontsov an...@enomsg.org wrote: So, I would now argue that the current scheme is perfectly OK and can

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 11:26:16 +0200 Michal Hocko wrote: > On Wed 26-06-13 23:17:12, Luiz Capitulino wrote: > > Currently, an eventfd is notified for the level it's registered for > > _plus_ higher levels. > > > > This is a problem if an application wants to impl

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 11:26:16 +0200 Michal Hocko mho...@suse.cz wrote: On Wed 26-06-13 23:17:12, Luiz Capitulino wrote: Currently, an eventfd is notified for the level it's registered for _plus_ higher levels. This is a problem if an application wants to implement different actions

[PATCH v2] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
it registered for. This new mode is optional, by default we still notify eventfds on higher levels too. Signed-off-by: Luiz Capitulino --- o v2 - Improve documentation - Use a bit to store mode instead of a bool - Minor changelog changes Documentation/cgroups/memory.txt | 26

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 10:08:27 +0200 Michal Hocko wrote: > On Tue 25-06-13 17:51:29, Luiz Capitulino wrote: > > Currently, applications are notified for the level they registered for > > _plus_ higher levels. > > > > This is a problem if the application wants to impl

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 17:20:40 +0900 Minchan Kim wrote: > Hello Michal, > > On Wed, Jun 26, 2013 at 09:59:21AM +0200, Michal Hocko wrote: > > On Wed 26-06-13 16:50:51, Minchan Kim wrote: > > > On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: > &g

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Tue, 25 Jun 2013 21:03:31 -0700 Anton Vorontsov wrote: > On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: > > Currently, applications are notified for the level they registered for > > _plus_ higher levels. > > > > This is a problem if the app

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Tue, 25 Jun 2013 21:03:31 -0700 Anton Vorontsov an...@enomsg.org wrote: On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: Currently, applications are notified for the level they registered for _plus_ higher levels. This is a problem if the application wants

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 17:20:40 +0900 Minchan Kim minc...@kernel.org wrote: Hello Michal, On Wed, Jun 26, 2013 at 09:59:21AM +0200, Michal Hocko wrote: On Wed 26-06-13 16:50:51, Minchan Kim wrote: On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: Currently, applications

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 10:08:27 +0200 Michal Hocko mho...@suse.cz wrote: On Tue 25-06-13 17:51:29, Luiz Capitulino wrote: Currently, applications are notified for the level they registered for _plus_ higher levels. This is a problem if the application wants to implement different actions

[PATCH v2] vmpressure: implement strict mode

2013-06-26 Thread Luiz Capitulino
it registered for. This new mode is optional, by default we still notify eventfds on higher levels too. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- o v2 - Improve documentation - Use a bit to store mode instead of a bool - Minor changelog changes Documentation/cgroups/memory.txt | 26

Re: [PATCH] vmpressure: implement strict mode

2013-06-25 Thread Luiz Capitulino
On Wed, 26 Jun 2013 10:12:15 +0900 Hyunhee Kim wrote: > Please see "[PATCH v3] memcg: event control at vmpressure". mail > thread. (and also the thread I sent last Saturday.) > There was discussion on this mode not sending lower events when "level > != ev->level". The new argument this patch

[PATCH] vmpressure: implement strict mode

2013-06-25 Thread Luiz Capitulino
. By default we still notify on higher levels. Signed-off-by: Luiz Capitulino --- PS: I'm following the discussion on the event storm problem, but I believe strict mode is orthogonal to what has been suggested (although the patches conflict) Documentation/cgroups/memory.txt | 10

[PATCH] vmpressure: implement strict mode

2013-06-25 Thread Luiz Capitulino
. By default we still notify on higher levels. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- PS: I'm following the discussion on the event storm problem, but I believe strict mode is orthogonal to what has been suggested (although the patches conflict) Documentation/cgroups

Re: [PATCH] vmpressure: implement strict mode

2013-06-25 Thread Luiz Capitulino
On Wed, 26 Jun 2013 10:12:15 +0900 Hyunhee Kim hyunhee@samsung.com wrote: Please see [PATCH v3] memcg: event control at vmpressure. mail thread. (and also the thread I sent last Saturday.) There was discussion on this mode not sending lower events when level != ev-level. The new argument

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-17 Thread Luiz Capitulino
On Wed, 5 Jun 2013 21:18:37 -0400 Luiz Capitulino wrote: > The balloon_page_dequeue() function can return NULL. If it does for > the first page being freed, then leak_balloon() will create a > scatter list with len=0. Which in turn seems to generate an invalid > virtio request. >

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-17 Thread Luiz Capitulino
On Wed, 5 Jun 2013 21:18:37 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len=0. Which in turn seems to generate an invalid virtio request

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-06 Thread Luiz Capitulino
On Thu, 6 Jun 2013 11:13:58 -0300 Rafael Aquini wrote: > On Wed, Jun 05, 2013 at 09:18:37PM -0400, Luiz Capitulino wrote: > > The balloon_page_dequeue() function can return NULL. If it does for > > the first page being freed, then leak_balloon() will create a > > scatter l

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-06 Thread Luiz Capitulino
On Thu, 6 Jun 2013 11:13:58 -0300 Rafael Aquini aqu...@redhat.com wrote: On Wed, Jun 05, 2013 at 09:18:37PM -0400, Luiz Capitulino wrote: The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len

[PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
, such an invalid virtio request will cause errors in QEMU and fill_balloon() also performs the same check implemented by this commit. Signed-off-by: Luiz Capitulino Acked-by: Rafael Aquini --- o v2 - Improve changelog drivers/virtio/virtio_balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
On Wed, 5 Jun 2013 18:24:49 -0300 Rafael Aquini wrote: > On Wed, Jun 05, 2013 at 05:10:31PM -0400, Luiz Capitulino wrote: > > The balloon_page_dequeue() function can return NULL. If it does for > > the first page being freed, then leak_balloon() will create a > > scatter l

[PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len=0. Which in turn seems to generate an invalid virtio request. Signed-off-by: Luiz Capitulino --- PS: I didn't get this in practice. I found

[PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len=0. Which in turn seems to generate an invalid virtio request. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- PS: I didn't get

Re: [PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
On Wed, 5 Jun 2013 18:24:49 -0300 Rafael Aquini aqu...@redhat.com wrote: On Wed, Jun 05, 2013 at 05:10:31PM -0400, Luiz Capitulino wrote: The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len

[PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
, such an invalid virtio request will cause errors in QEMU and fill_balloon() also performs the same check implemented by this commit. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Rafael Aquini aqu...@redhat.com --- o v2 - Improve changelog drivers/virtio/virtio_balloon.c | 3 ++- 1

Re: [RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-16 Thread Luiz Capitulino
On Thu, 16 May 2013 16:56:34 -0400 Sasha Levin wrote: > On 05/09/2013 10:53 AM, Luiz Capitulino wrote: > > Hi, > > > > This series is a respin of automatic ballooning support I started > > working on last year. Patch 2/2 contains all relevant technical > > det

Re: [RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-16 Thread Luiz Capitulino
On Thu, 16 May 2013 16:56:34 -0400 Sasha Levin sasha.le...@oracle.com wrote: On 05/09/2013 10:53 AM, Luiz Capitulino wrote: Hi, This series is a respin of automatic ballooning support I started working on last year. Patch 2/2 contains all relevant technical details and performance

[PATCH] package: Makefile: unbreak binrpm-pkg target

2013-05-15 Thread Luiz Capitulino
Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a prerequisite for the binrpm-pkg target but forgot to update $< usage, which causes the rule to break. This commit fixes that by replacing $< with the spec name. Signed-off-by: Luiz Capitulino --- scripts/package/Ma

[PATCH] package: Makefile: unbreak binrpm-pkg target

2013-05-15 Thread Luiz Capitulino
Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a prerequisite for the binrpm-pkg target but forgot to update $ usage, which causes the rule to break. This commit fixes that by replacing $ with the spec name. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 22:02:50 +0300 "Michael S. Tsirkin" wrote: > On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote: > > On Mon, 13 May 2013 11:34:41 -0300 > > Rafael Aquini wrote: > > > > > You're right, and the host's member is used t

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 11:34:41 -0300 Rafael Aquini wrote: > You're right, and the host's member is used to communicate the configured size > to guest's balloon device, however, by not changing it when the shrinker > causes > the balloon to deflate will make the balloon thread to be woken up

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Sun, 12 May 2013 21:49:34 +0300 "Michael S. Tsirkin" wrote: > On Sun, May 12, 2013 at 12:36:09PM -0400, Rik van Riel wrote: > > On 05/12/2013 10:30 AM, Michael S. Tsirkin wrote: > > >On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > &g

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Sun, 12 May 2013 21:49:34 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 12, 2013 at 12:36:09PM -0400, Rik van Riel wrote: On 05/12/2013 10:30 AM, Michael S. Tsirkin wrote: On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: Automatic ballooning consists

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 11:34:41 -0300 Rafael Aquini aqu...@redhat.com wrote: You're right, and the host's member is used to communicate the configured size to guest's balloon device, however, by not changing it when the shrinker causes the balloon to deflate will make the balloon thread to be

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 22:02:50 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote: On Mon, 13 May 2013 11:34:41 -0300 Rafael Aquini aqu...@redhat.com wrote: You're right, and the host's member is used to communicate

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Fri, 10 May 2013 09:20:46 -0400 Luiz Capitulino wrote: > On Thu, 9 May 2013 18:15:19 -0300 > Rafael Aquini wrote: > > > On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > > > Automatic ballooning consists of dynamically adjusting the guest's > >

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:15:19 -0300 Rafael Aquini wrote: > On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > > Automatic ballooning consists of dynamically adjusting the guest's > > balloon according to memory pressure in the host and in the guest. > > >

Re: [RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:03:09 -0300 Rafael Aquini wrote: > On Thu, May 09, 2013 at 10:53:48AM -0400, Luiz Capitulino wrote: > > This commit moves the balloon_lock mutex out of the fill_balloon() > > and leak_balloon() functions to their callers. > > > > The reason for t

Re: [RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:03:09 -0300 Rafael Aquini aqu...@redhat.com wrote: On Thu, May 09, 2013 at 10:53:48AM -0400, Luiz Capitulino wrote: This commit moves the balloon_lock mutex out of the fill_balloon() and leak_balloon() functions to their callers. The reason for this change

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:15:19 -0300 Rafael Aquini aqu...@redhat.com wrote: On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: Automatic ballooning consists of dynamically adjusting the guest's balloon according to memory pressure in the host and in the guest. This commit

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Fri, 10 May 2013 09:20:46 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 9 May 2013 18:15:19 -0300 Rafael Aquini aqu...@redhat.com wrote: On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: Automatic ballooning consists of dynamically adjusting the guest's

[RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-09 Thread Luiz Capitulino
semantics. Signed-off-by: Luiz Capitulino --- drivers/virtio/virtio_balloon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index bd3ae32..9d5fe2b 100644 --- a/drivers/virtio/virtio_balloon.c +++ b

[RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
1079847 1616367 4543 953289 1635379 5642 913237 1514000 Auto-ballooning enabled: RUN TIME(s) SWAP IN SWAP OUT 1629 901 12537 2624 981 18506 3626 573 9085 4631 2250 42534 5627 1610 20808 Signed-off-by: Luiz

[RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
the guest memory down, say from 1G to 256MB 6. Generate some pressure in the guest, say a kernel build with -j16 Any feedback is appreciated! Luiz Capitulino (2): virtio_balloon: move balloon_lock mutex to callers virtio_balloon: auto-ballooning support drivers/virtio/virtio_balloon.c

[RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
the guest memory down, say from 1G to 256MB 6. Generate some pressure in the guest, say a kernel build with -j16 Any feedback is appreciated! Luiz Capitulino (2): virtio_balloon: move balloon_lock mutex to callers virtio_balloon: auto-ballooning support drivers/virtio/virtio_balloon.c

[RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
1079847 1616367 4543 953289 1635379 5642 913237 1514000 Auto-ballooning enabled: RUN TIME(s) SWAP IN SWAP OUT 1629 901 12537 2624 981 18506 3626 573 9085 4631 2250 42534 5627 1610 20808 Signed-off-by: Luiz

[RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-09 Thread Luiz Capitulino
semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- drivers/virtio/virtio_balloon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index bd3ae32..9d5fe2b 100644 --- a/drivers/virtio

Re: [RFC 2/2] virtio_balloon: add auto-ballooning support

2013-01-14 Thread Luiz Capitulino
On Sat, 12 Jan 2013 02:13:17 +0530 Amit Shah wrote: > On (Tue) 18 Dec 2012 [18:17:30], Luiz Capitulino wrote: > > The auto-ballooning feature automatically performs balloon inflate or > > deflate based on host and guest memory pressure. This can help to > > avoid swapping o

Re: [RFC 2/2] virtio_balloon: add auto-ballooning support

2013-01-14 Thread Luiz Capitulino
On Sat, 12 Jan 2013 02:13:17 +0530 Amit Shah amit.s...@redhat.com wrote: On (Tue) 18 Dec 2012 [18:17:30], Luiz Capitulino wrote: The auto-ballooning feature automatically performs balloon inflate or deflate based on host and guest memory pressure. This can help to avoid swapping or worse

Re: [PATCH 0/2] Mempressure cgroup

2013-01-11 Thread Luiz Capitulino
On Fri, 4 Jan 2013 00:27:52 -0800 Anton Vorontsov wrote: > - I've split the pach into two: 'shrinker' and 'levels' parts. While the > full-fledged userland shrinker is an interesting idea, we don't have any > users ready for it, so I won't advocate for it too much. For the next version of

Re: [PATCH 0/2] Mempressure cgroup

2013-01-11 Thread Luiz Capitulino
On Fri, 4 Jan 2013 00:27:52 -0800 Anton Vorontsov anton.voront...@linaro.org wrote: - I've split the pach into two: 'shrinker' and 'levels' parts. While the full-fledged userland shrinker is an interesting idea, we don't have any users ready for it, so I won't advocate for it too much.

Re: [Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-22 Thread Luiz Capitulino
On Thu, 20 Dec 2012 05:24:12 + Dietmar Maurer wrote: > > > Wow, you're fast! And I'm glad that it works for you, so we have two > > > full-featured mempressure cgroup users already. > > > > Thanks, although I think we need more testing to be sure this does what we > > want. I mean, the

Re: [Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-22 Thread Luiz Capitulino
On Thu, 20 Dec 2012 05:24:12 + Dietmar Maurer diet...@proxmox.com wrote: Wow, you're fast! And I'm glad that it works for you, so we have two full-featured mempressure cgroup users already. Thanks, although I think we need more testing to be sure this does what we want. I mean,

Re: [RFC 1/2] virtio_balloon: move locking to the balloon thread

2012-12-19 Thread Luiz Capitulino
On Wed, 19 Dec 2012 09:55:58 -0200 Rafael Aquini wrote: > On Tue, Dec 18, 2012 at 06:17:29PM -0200, Luiz Capitulino wrote: > > Today, the balloon_lock mutex is taken and released by fill_balloon() > > and leak_balloon() when both functions are entered and when

Re: [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-19 Thread Luiz Capitulino
On Tue, 18 Dec 2012 14:53:30 -0800 Anton Vorontsov wrote: > Hello Luiz, > > On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote: > > The auto-ballooning feature automatically performs balloon inflate > > or deflate based on host and guest memory pressure. This

Re: [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-19 Thread Luiz Capitulino
On Tue, 18 Dec 2012 14:53:30 -0800 Anton Vorontsov anton.voront...@linaro.org wrote: Hello Luiz, On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote: The auto-ballooning feature automatically performs balloon inflate or deflate based on host and guest memory pressure. This can

Re: [RFC 1/2] virtio_balloon: move locking to the balloon thread

2012-12-19 Thread Luiz Capitulino
On Wed, 19 Dec 2012 09:55:58 -0200 Rafael Aquini aqu...@redhat.com wrote: On Tue, Dec 18, 2012 at 06:17:29PM -0200, Luiz Capitulino wrote: Today, the balloon_lock mutex is taken and released by fill_balloon() and leak_balloon() when both functions are entered and when they return

[RFC 2/2] virtio_balloon: add auto-ballooning support

2012-12-18 Thread Luiz Capitulino
kernel seems to spin when the host is performing a long auto-inflate Signed-off-by: Luiz Capitulino --- drivers/virtio/virtio_balloon.c | 54 + include/uapi/linux/virtio_balloon.h | 1 + 2 files changed, 55 insertions(+) diff --git a/drivers/virtio

[RFC 0/2] auto-ballooning prototype (guest part)

2012-12-18 Thread Luiz Capitulino
(please, never mind the repo name): git://repo.or.cz/qemu/qmp-unstable.git balloon/auto-ballooning/rfc Any feedback is appreciated! Luiz Capitulino (2): virtio_balloon: move locking to the balloon thread virtio_balloon: add auto-ballooning support drivers/virtio/virtio_balloon.c | 60

[RFC 1/2] virtio_balloon: move locking to the balloon thread

2012-12-18 Thread Luiz Capitulino
. The reason for this move is that the next commit will introduce a shrinker callback for the balloon driver, which will also call leak_balloon() but will require different locking semantics. Signed-off-by: Luiz Capitulino --- drivers/virtio/virtio_balloon.c | 6 ++ 1 file changed, 2 insertions

[RFC 1/2] virtio_balloon: move locking to the balloon thread

2012-12-18 Thread Luiz Capitulino
. The reason for this move is that the next commit will introduce a shrinker callback for the balloon driver, which will also call leak_balloon() but will require different locking semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- drivers/virtio/virtio_balloon.c | 6 ++ 1 file

[RFC 0/2] auto-ballooning prototype (guest part)

2012-12-18 Thread Luiz Capitulino
(please, never mind the repo name): git://repo.or.cz/qemu/qmp-unstable.git balloon/auto-ballooning/rfc Any feedback is appreciated! Luiz Capitulino (2): virtio_balloon: move locking to the balloon thread virtio_balloon: add auto-ballooning support drivers/virtio/virtio_balloon.c | 60

[RFC 2/2] virtio_balloon: add auto-ballooning support

2012-12-18 Thread Luiz Capitulino
kernel seems to spin when the host is performing a long auto-inflate Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- drivers/virtio/virtio_balloon.c | 54 + include/uapi/linux/virtio_balloon.h | 1 + 2 files changed, 55 insertions(+) diff --git

Re: [RFC] Add mempressure cgroup

2012-11-30 Thread Luiz Capitulino
On Wed, 28 Nov 2012 17:27:51 -0800 Anton Vorontsov wrote: > On Wed, Nov 28, 2012 at 03:14:32PM -0800, Andrew Morton wrote: > [...] > > Compare this with the shrink_slab() shrinkers. With these, the VM can > > query and then control the clients. If something goes wrong or is out > > of balance,

Re: [RFC] Add mempressure cgroup

2012-11-30 Thread Luiz Capitulino
On Wed, 28 Nov 2012 17:27:51 -0800 Anton Vorontsov anton.voront...@linaro.org wrote: On Wed, Nov 28, 2012 at 03:14:32PM -0800, Andrew Morton wrote: [...] Compare this with the shrink_slab() shrinkers. With these, the VM can query and then control the clients. If something goes wrong or is

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-09 Thread Luiz Capitulino
Hi Anton, On Wed, 7 Nov 2012 02:53:49 -0800 Anton Vorontsov wrote: > Hi all, > > This is the third RFC. As suggested by Minchan Kim, the API is much > simplified now (comparing to vmevent_fd): Which tree is this against? I'd like to try this series, but it doesn't apply to Linus tree. -- To

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-09 Thread Luiz Capitulino
Hi Anton, On Wed, 7 Nov 2012 02:53:49 -0800 Anton Vorontsov anton.voront...@linaro.org wrote: Hi all, This is the third RFC. As suggested by Minchan Kim, the API is much simplified now (comparing to vmevent_fd): Which tree is this against? I'd like to try this series, but it doesn't apply

Re: [Qemu-devel] [PATCH v10] kvm: notify host when the guest is panicked

2012-10-01 Thread Luiz Capitulino
On Wed, 29 Aug 2012 13:18:54 +0800 Wen Congyang wrote: > We can know the guest is panicked when the guest runs on xen. > But we do not have such feature on kvm. What's the status of this series? It got lost in my queue and I ended up not reviewing it, but it seems to be stuck. > > Another

Re: [Qemu-devel] [PATCH v10] kvm: notify host when the guest is panicked

2012-10-01 Thread Luiz Capitulino
On Wed, 29 Aug 2012 13:18:54 +0800 Wen Congyang we...@cn.fujitsu.com wrote: We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. What's the status of this series? It got lost in my queue and I ended up not reviewing it, but it seems to be

<    1   2   3   4   5   6