Re: [PATCH V6 ] mm readahead: Fix readahead fail for memoryless cpu and limit readahead pages

2014-03-16 Thread Madper Xie
Raghavendra K T writes: > On 02/18/2014 03:19 PM, Jan Kara wrote: >> On Tue 18-02-14 12:55:38, Raghavendra K T wrote: >>> Currently max_sane_readahead() returns zero on the cpu having no local >>> memory node >>> which leads to readahead failure. Fix the readahead failure by returning >>>

Re: [PATCH V6 ] mm readahead: Fix readahead fail for memoryless cpu and limit readahead pages

2014-03-16 Thread Madper Xie
Raghavendra K T raghavendra...@linux.vnet.ibm.com writes: On 02/18/2014 03:19 PM, Jan Kara wrote: On Tue 18-02-14 12:55:38, Raghavendra K T wrote: Currently max_sane_readahead() returns zero on the cpu having no local memory node which leads to readahead failure. Fix the readahead failure

WARNING: CPU: 0 PID: 0 at lib/dma-debug.c:491

2014-02-17 Thread Madper Xie
Howdy all, Meet following warning and call trace: [307001.720980] [ cut here ] [307001.720994] WARNING: CPU: 0 PID: 0 at lib/dma-debug.c:491 add_dma_entry+0x127/0x130() [307001.720996] DMA-API: exceeded 7 overlapping mappings of pfn 1932f8 [307001.720998] Modules linked

WARNING: CPU: 0 PID: 0 at lib/dma-debug.c:491

2014-02-17 Thread Madper Xie
Howdy all, Meet following warning and call trace: [307001.720980] [ cut here ] [307001.720994] WARNING: CPU: 0 PID: 0 at lib/dma-debug.c:491 add_dma_entry+0x127/0x130() [307001.720996] DMA-API: exceeded 7 overlapping mappings of pfn 1932f8 [307001.720998] Modules linked

Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-13 Thread Madper Xie
m...@console-pimps.org writes: > On Wed, 12 Feb, at 09:15:03AM, Toshi Kani wrote: >> >> Hi Matt, >> >> Yes, I agree that the table size should be 0x38. However, ACPI spec >> states that bit0 of status indicates if the boot image graphic is valid. >> This bit is set to 0 (invalid) on the

Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-13 Thread Madper Xie
m...@console-pimps.org writes: On Wed, 12 Feb, at 09:15:03AM, Toshi Kani wrote: Hi Matt, Yes, I agree that the table size should be 0x38. However, ACPI spec states that bit0 of status indicates if the boot image graphic is valid. This bit is set to 0 (invalid) on the system. Can you

Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-10 Thread Madper Xie
m...@console-pimps.org writes: > On Mon, 10 Feb, at 03:23:33PM, Madper Xie wrote: >> Howdy, >> >> With old kernel (from 3.10 to 3.14-rc1), my hp box shows following >> outputs: >> ~~~ >> [0.009166] Freeing SMP alternatives memory: 20K (

Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-10 Thread Madper Xie
m...@console-pimps.org writes: On Mon, 10 Feb, at 03:23:33PM, Madper Xie wrote: Howdy, With old kernel (from 3.10 to 3.14-rc1), my hp box shows following outputs: ~~~ [0.009166] Freeing SMP alternatives memory: 20K (82234000 - 82239000) [0.010302] ioremap

[BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-09 Thread Madper Xie
Howdy, With old kernel (from 3.10 to 3.14-rc1), my hp box shows following outputs: ~~~ [0.009166] Freeing SMP alternatives memory: 20K (82234000 - 82239000) [0.010302] ioremap: invalid physical address 1376e0180001 [0.010303] [ cut here ] [

[BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-09 Thread Madper Xie
Howdy, With old kernel (from 3.10 to 3.14-rc1), my hp box shows following outputs: ~~~ [0.009166] Freeing SMP alternatives memory: 20K (82234000 - 82239000) [0.010302] ioremap: invalid physical address 1376e0180001 [0.010303] [ cut here ] [

[BUG] Panic when booting

2014-01-17 Thread Madper Xie
Howdy all, I meet following panic when I booting my HP Compad Elite 8300 Elite SFF desktop. [call trace here:] [0.569993] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [0.578269] CPU: 1 PID: 1 Comm: swapper/0 Tainted: GW3.13.0-rc8 #1 [

[BUG] Panic when booting

2014-01-17 Thread Madper Xie
Howdy all, I meet following panic when I booting my HP Compad Elite 8300 Elite SFF desktop. [call trace here:] [0.569993] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [0.578269] CPU: 1 PID: 1 Comm: swapper/0 Tainted: GW3.13.0-rc8 #1 [

[BUG] Kernel OOPS when reboot if I set reboot=efi,{warm, cold} (and some questions :-)

2014-01-03 Thread Madper Xie
Howdy Folks, Happy new yeah, happy new bug! With a uefi system, I meet following panic when reboot after I adding `reboot=efi,warm` [call trace]: <0>[ 698.736637] reboot: Restarting system <5>[ 698.737407] reboot: machine restart <1>[ 698.738399] BUG: unable to handle kernel paging

[BUG] Kernel OOPS when reboot if I set reboot=efi,{warm, cold} (and some questions :-)

2014-01-03 Thread Madper Xie
Howdy Folks, Happy new yeah, happy new bug! With a uefi system, I meet following panic when reboot after I adding `reboot=efi,warm` [call trace]: 0[ 698.736637] reboot: Restarting system 5[ 698.737407] reboot: machine restart 1[ 698.738399] BUG: unable to handle kernel paging request at

Re: [PATCH v2] efi-pstore: Make efi-pstore return a unique id

2013-11-27 Thread Madper Xie
m...@console-pimps.org writes: > On Sat, 23 Nov, at 07:55:37PM, Madper Xie wrote: >> >> Pstore fs expects that backends provide a uniqued id which could avoid >> pstore making entries as duplication or denominating entries the same >> name. So I combine the timest

Re: [PATCH v2] efi-pstore: Make efi-pstore return a unique id

2013-11-27 Thread Madper Xie
m...@console-pimps.org writes: On Sat, 23 Nov, at 07:55:37PM, Madper Xie wrote: Pstore fs expects that backends provide a uniqued id which could avoid pstore making entries as duplication or denominating entries the same name. So I combine the timestamp, part and count into id. Signed

[PATCH v2] efi-pstore: Make efi-pstore return a unique id

2013-11-23 Thread Madper Xie
Pstore fs expects that backends provide a uniqued id which could avoid pstore making entries as duplication or denominating entries the same name. So I combine the timestamp, part and count into id. Signed-off-by: Madper Xie --- drivers/firmware/efi/efi-pstore.c | 19 +-- 1

[PATCH v2] efi-pstore: Make efi-pstore return a unique id

2013-11-23 Thread Madper Xie
Pstore fs expects that backends provide a uniqued id which could avoid pstore making entries as duplication or denominating entries the same name. So I combine the timestamp, part and count into id. Signed-off-by: Madper Xie c...@redhat.com --- drivers/firmware/efi/efi-pstore.c | 19

Re: [PATCH] Make efi-pstore return a unique id

2013-11-20 Thread Madper Xie
rich...@nod.at writes: > Am 01.11.2013 20:22, schrieb Seiji Aguchi: >>> >>> Agreed. I liked your ((timestamp * 100 + part) * 100 + count function much >>> more than this. >> >> I was worried that the part and count could be more than 100. >> If it happens, the id may not be unique... >> >>

Re: [PATCH] Make efi-pstore return a unique id

2013-11-20 Thread Madper Xie
rich...@nod.at writes: Am 01.11.2013 20:22, schrieb Seiji Aguchi: Agreed. I liked your ((timestamp * 100 + part) * 100 + count function much more than this. I was worried that the part and count could be more than 100. If it happens, the id may not be unique... But, currently, size

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-18 Thread Madper Xie
isimatu.yasu...@jp.fujitsu.com writes: > Hi Matt, > > Sorry for late the reply. > > > (2013/11/11 19:54), Matt Fleming wrote: >> On Mon, 11 Nov, at 05:52:59PM, Yasuaki Ishimatsu wrote: >>> Hi Matt, >>> >>> I uses FUJITSU's x86 box. >>> This does not become bricked even if I use all efi variable

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-18 Thread Madper Xie
isimatu.yasu...@jp.fujitsu.com writes: Hi Matt, Sorry for late the reply. (2013/11/11 19:54), Matt Fleming wrote: On Mon, 11 Nov, at 05:52:59PM, Yasuaki Ishimatsu wrote: Hi Matt, I uses FUJITSU's x86 box. This does not become bricked even if I use all efi variable storage. Thus I

Re: [BUG]: DELL XPS 8500 become a brick after fill too many entries to nvram.

2013-11-13 Thread Madper Xie
m...@console-pimps.org writes: > On Mon, 11 Nov, at 08:38:31PM, Madper Xie wrote: >> >> m...@console-pimps.org writes: >> >> > On Mon, 11 Nov, at 02:15:22PM, Madper Xie wrote: >> >> Howdy all, >> >> For now we ensure at least ~5kb fr

Re: [BUG]: DELL XPS 8500 become a brick after fill too many entries to nvram.

2013-11-13 Thread Madper Xie
m...@console-pimps.org writes: On Mon, 11 Nov, at 08:38:31PM, Madper Xie wrote: m...@console-pimps.org writes: On Mon, 11 Nov, at 02:15:22PM, Madper Xie wrote: Howdy all, For now we ensure at least ~5kb free space. But my dell xps still become a brick after I add too many

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-11 Thread Madper Xie
; I will read it. >> >> Out of curiosity, what hardware are you using? >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/ma

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-11 Thread Madper Xie
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[BUG]: DELL XPS 8500 become a brick after fill too many entries to nvram.

2013-11-10 Thread Madper Xie
Howdy all, For now we ensure at least ~5kb free space. But my dell xps still become a brick after I add too many entries to my nvram. So maybe 5kb is not safe enough. and 5kb is just aginst Samsung's laptop. So should we enlarge EFI_MIN_RESERVE? -- Best, Madper Xie. -- To unsubscribe from

[PATCH] EFI: Delete out-of-date comments of efi_query_variable_store

2013-11-10 Thread Madper Xie
For now we only ensure about 5kb free space for avoiding our board refusing boot. But the comment lies that we retain 50% space. Signed-off-by: Madper Xie --- arch/x86/platform/efi/efi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/x86/platform/efi

[PATCH] EFI: Delete out-of-date comments of efi_query_variable_store

2013-11-10 Thread Madper Xie
For now we only ensure about 5kb free space for avoiding our board refusing boot. But the comment lies that we retain 50% space. Signed-off-by: Madper Xie c...@redhat.com --- arch/x86/platform/efi/efi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/x86

[BUG]: DELL XPS 8500 become a brick after fill too many entries to nvram.

2013-11-10 Thread Madper Xie
Howdy all, For now we ensure at least ~5kb free space. But my dell xps still become a brick after I add too many entries to my nvram. So maybe 5kb is not safe enough. and 5kb is just aginst Samsung's laptop. So should we enlarge EFI_MIN_RESERVE? -- Best, Madper Xie. -- To unsubscribe from

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-08 Thread Madper Xie
ors will more careful in their next generation of products... But it's painful for everyone, both customers and vendors. > Thanks, > //richard > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majord...@vger.kernel.org >

Re: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia

2013-11-08 Thread Madper Xie
for everyone, both customers and vendors. Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best, Madper Xie. -- To unsubscribe

Re: [PATCH] Make efi-pstore return a unique id

2013-11-01 Thread Madper Xie
a non-cryptographic > hash function? > Using this way you get a cheap unique id. > > Thanks, > //richard > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo inf

[PATCH] Make efi-pstore return a unique id

2013-11-01 Thread Madper Xie
Pstore fs expects that backends provide a uniqued id which could avoid pstore making entries as duplication or denominating entries the same name. So I combine the timestamp, part and count into id. Signed-off-by: Madper Xie --- drivers/firmware/efi/efi-pstore.c | 22 ++ 1

[PATCH] Make efi-pstore return a unique id

2013-11-01 Thread Madper Xie
Pstore fs expects that backends provide a uniqued id which could avoid pstore making entries as duplication or denominating entries the same name. So I combine the timestamp, part and count into id. Signed-off-by: Madper Xie c...@redhat.com --- drivers/firmware/efi/efi-pstore.c | 22

Re: [PATCH] Make efi-pstore return a unique id

2013-11-01 Thread Madper Xie
, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-31 Thread Madper Xie
20 > [1.158207] [] vfs_kern_mount+0x63/0xf0 > [1.158207] [] do_mount+0x23e/0xa20 > [1.158207] [] ? strndup_user+0x4b/0xf0 > [1.158207] [] SyS_mount+0x83/0xc0 > [1.158207] [] system_call_fastpath+0x16/0x1b > [1.158207] ---[ end trace 61981bc62de9f6f4 ]--- >

Re: [PATCH v4] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-31 Thread Madper Xie
] ---[ end trace 61981bc62de9f6f4 ]--- Signed-off-by: Seiji Aguchi seiji.agu...@hds.com After applied this patch, I can't see the warning again when I mounting pstore fs and deleting pstore entries. Tested-by: Madper Xie c...@redhat.com --- drivers/firmware/efi/efi-pstore.c | 143

Re: [PATCH 0/2] make all stored entries accessible.

2013-10-30 Thread Madper Xie
iple numbers visible to the file name. >> >>> -r--r--r-- 1 root root 17499 Oct 30 13:41 >>> dmesg-erst-5940651313304961029--2129078373-1383165669 > > after I added the "count = 0" initialization the filename gets a tiny bit less > scary: > > -r--r--

Re: [PATCH 1/2] pstore: avoid incorrectly mark entry as duplicate

2013-10-30 Thread Madper Xie
seiji.agu...@hds.com writes: >> -Original Message- >> From: Madper Xie [mailto:c...@redhat.com] >> Sent: Wednesday, October 30, 2013 5:45 AM >> To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com; >> an...@enomsg.org; Seiji Aguchi >>

[PATCH 0/2] make all stored entries accessible.

2013-10-30 Thread Madper Xie
1. checking type, id, psi, count and timespec when finding duplicate entries. 2. adding count and timestamp for differentiating. Madper Xie (2): pstore: avoid incorrectly mark entry as duplicate pstore: Differentiating names by adding count and timestamp fs/pstore/inode.c | 35

[PATCH 2/2] pstore: Differentiating names by adding count and timestamp

2013-10-30 Thread Madper Xie
From: Madper Xie pstore denominates dumped file as type-psname-id. it makes many file have the same name if there are many entries in backend have the same id. So adding count and timestamp to file name for differentiating. Signed-off-by: Madper Xie --- fs/pstore/inode.c | 29

[PATCH 1/2] pstore: avoid incorrectly mark entry as duplicate

2013-10-30 Thread Madper Xie
From: Madper Xie pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump-type0-9-1-1382511508-C-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 dump-type0-9-1-1382515661-C-cfc8fc79

[PATCH 1/2] pstore: avoid incorrectly mark entry as duplicate

2013-10-30 Thread Madper Xie
From: Madper Xie bbbo...@gmail.com pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump-type0-9-1-1382511508-C-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 dump-type0-9-1

[PATCH 2/2] pstore: Differentiating names by adding count and timestamp

2013-10-30 Thread Madper Xie
From: Madper Xie bbbo...@gmail.com pstore denominates dumped file as type-psname-id. it makes many file have the same name if there are many entries in backend have the same id. So adding count and timestamp to file name for differentiating. Signed-off-by: Madper Xie c...@redhat.com --- fs

[PATCH 0/2] make all stored entries accessible.

2013-10-30 Thread Madper Xie
1. checking type, id, psi, count and timespec when finding duplicate entries. 2. adding count and timestamp for differentiating. Madper Xie (2): pstore: avoid incorrectly mark entry as duplicate pstore: Differentiating names by adding count and timestamp fs/pstore/inode.c | 35

Re: [PATCH 1/2] pstore: avoid incorrectly mark entry as duplicate

2013-10-30 Thread Madper Xie
seiji.agu...@hds.com writes: -Original Message- From: Madper Xie [mailto:c...@redhat.com] Sent: Wednesday, October 30, 2013 5:45 AM To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com; an...@enomsg.org; Seiji Aguchi Cc: linux-...@vger.kernel.org; linux-kernel

Re: [PATCH 0/2] make all stored entries accessible.

2013-10-30 Thread Madper Xie
-5940651313304961029--2129078373-1383165669 after I added the count = 0 initialization the filename gets a tiny bit less scary: -r--r--r-- 1 root root 17499 Oct 30 13:41 dmesg-erst-5940651313304961029-0-1383165669 -Tony -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-28 Thread Madper Xie
Howdy Tony, Does this patch still need some rework? c...@redhat.com writes: > tony.l...@gmail.com writes: > >> On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie wrote: >>> The "duplicate" entries won't appear in pstorefs. And a complain will be >>> pri

[PATCH] Differentiating names by adding a timestamp.

2013-10-28 Thread Madper Xie
pstore denominate dumped file as type-psname-id. it makes many file have the same name if there are many entries in backend have the same id. So adding a timestamp to file name. Signed-off-by: Madper Xie --- fs/pstore/inode.c | 26 -- 1 file changed, 16 insertions

[PATCH] Differentiating names by adding a timestamp.

2013-10-28 Thread Madper Xie
pstore denominate dumped file as type-psname-id. it makes many file have the same name if there are many entries in backend have the same id. So adding a timestamp to file name. Signed-off-by: Madper Xie c...@redhat.com --- fs/pstore/inode.c | 26 -- 1 file changed, 16

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-28 Thread Madper Xie
Howdy Tony, Does this patch still need some rework? c...@redhat.com writes: tony.l...@gmail.com writes: On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
tony.l...@gmail.com writes: > On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie wrote: >> The "duplicate" entries won't appear in pstorefs. And a complain will be >> print -- pstore: failed to load 76 record(s) from 'efi' > > Maybe I don't quite get this - but it s

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
richard.weinber...@gmail.com writes: > On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie wrote: >> pstore try to find duplicate entries by check both ID, type and psi. >> They are not really enough for efi backend. dumped vars always have >> the same type, psi and ID. like follo

[PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
-9f98bfe298a0 The "duplicate" entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' So I add one more check: timespec. Signed-off-by: Madper Xie --- fs/pstore/inode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [BUG] pstore: failed to load 76 record(s) from 'efi'

2013-10-23 Thread Madper Xie
test-12341234-1234-1234-1234-123412341234 > test2-12341234-1234-2134-1234-123412341234 > test3-12341234-1234-1234-1234-123412341234 > test4-12341234-1234-1234-1234-123412341234 > test5-12341234-1234-1234-1234-123412341234 > test6-12341234-1234-1234-1234-123412341234 > Timeout-8be4df61-93ca-11d2-aa0d-00e098032b8c > UsbHandOnOffEntry-0a602c5b-05a0-40c4-9181-edcd891d0018 > UsbMassDevNum-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 > UsbMassDevValid-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 > USB_POINT-8be4df61-93ca-11d2-aa0d-00e098032b8c > UsbSupport-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 > WdtPersistentData-78ce2354-cfbc-4643-aeba-07a27fa892bf -- Best, Madper Xie. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [BUG] pstore: failed to load 76 record(s) from 'efi'

2013-10-23 Thread Madper Xie
-00e098032b8c UsbSupport-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 WdtPersistentData-78ce2354-cfbc-4643-aeba-07a27fa892bf -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
-9f98bfe298a0 The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' So I add one more check: timespec. Signed-off-by: Madper Xie c...@redhat.com --- fs/pstore/inode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
richard.weinber...@gmail.com writes: On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie c...@redhat.com wrote: pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
tony.l...@gmail.com writes: On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole

[BUG] pstore: failed to load 76 record(s) from 'efi'

2013-10-22 Thread Madper Xie
181-edcd891d0018 UsbMassDevNum-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 UsbMassDevValid-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 USB_POINT-8be4df61-93ca-11d2-aa0d-00e098032b8c UsbSupport-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 WdtPersistentData-78ce2354-cfbc-4643-aeba-07a27fa892bf -- Best, Madper

[BUG] pstore: failed to load 76 record(s) from 'efi'

2013-10-22 Thread Madper Xie
-edcd891d0018 UsbMassDevNum-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 UsbMassDevValid-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 USB_POINT-8be4df61-93ca-11d2-aa0d-00e098032b8c UsbSupport-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 WdtPersistentData-78ce2354-cfbc-4643-aeba-07a27fa892bf -- Best, Madper Xie

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-17 Thread Madper Xie
Hi folks, I tested it on my DELL XPS desktop. And it won't show any warnings when I mounting pstore and deleting pstore items after this patch applied. Tested-by: Madper Xie c...@redhat.com writes: > Oops, It seems my mu4e(a email client for emacs)'s auto-indent breaks the >

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-17 Thread Madper Xie
;> -Original Message- >> From: Madper Xie [mailto:c...@redhat.com] >> Sent: Thursday, October 17, 2013 1:54 AM >> To: Seiji Aguchi >> Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; >> matt.flem...@intel.com; tony.l...@intel.com; Tomoki Sekiyama; dle- &

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-17 Thread Madper Xie
efi_variable var; struct list_head list; struct kobject kobj; + bool scanning; + bool deleting; }; extern struct list_head efivar_sysfs_list; -- Best, Madper Xie. -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-17 Thread Madper Xie
Hi folks, I tested it on my DELL XPS desktop. And it won't show any warnings when I mounting pstore and deleting pstore items after this patch applied. Tested-by: Madper Xie c...@redhat.com writes: Oops, It seems my mu4e(a email client for emacs)'s auto-indent breaks the patch... I

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-16 Thread Madper Xie
rmware/efi/vars.c b/drivers/firmware/efi/vars.c > index 391c67b..b22659c 100644 > --- a/drivers/firmware/efi/vars.c > +++ b/drivers/firmware/efi/vars.c > @@ -683,8 +683,16 @@ struct efivar_entry *efivar_entry_find(efi_char16_t > *name, efi_guid_t guid, > if (!found) > return NULL; > > - if (remove) > - list_del(>list); > + if (remove) { > + if (entry->scanning) { > + /* > + * The entry will be deleted > + * after scanning is completed. > + */ > + entry->deleting = true; > + } else > + list_del(>list); > + } > > return entry; > } > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 5f8f176..04088fb 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -782,6 +782,8 @@ struct efivar_entry { > struct efi_variable var; > struct list_head list; > struct kobject kobj; > + bool scanning; > + bool deleting; > }; > > extern struct list_head efivar_sysfs_list; -- Best, Madper Xie. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-16 Thread Madper Xie
; struct list_head list; struct kobject kobj; + bool scanning; + bool deleting; }; extern struct list_head efivar_sysfs_list; -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-07 Thread Madper Xie
[ 15.906392] r8169 :02:00.0 p3p1: link up > [ 15.906416] IPv6: ADDRCONF(NETDEV_CHANGE): p3p1: link becomes ready > [ 17.121989] systemd-udevd (334) used greatest stack depth: 3352 bytes left > > I'm working on finding which version bring this bug in. -- Best, Madper Xie. --

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-07 Thread Madper Xie
becomes ready [ 17.121989] systemd-udevd (334) used greatest stack depth: 3352 bytes left I'm working on finding which version bring this bug in. -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[Bug] 12.864681 BUG: lock held when returning to user space!

2013-09-30 Thread Madper Xie
: ADDRCONF(NETDEV_CHANGE): p3p1: link becomes ready [ 17.121989] systemd-udevd (334) used greatest stack depth: 3352 bytes left I'm working on finding which version bring this bug in. -- Best, Madper Xie. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

[Bug] 12.864681 BUG: lock held when returning to user space!

2013-09-30 Thread Madper Xie
] IPv6: ADDRCONF(NETDEV_CHANGE): p3p1: link becomes ready [ 17.121989] systemd-udevd (334) used greatest stack depth: 3352 bytes left I'm working on finding which version bring this bug in. -- Best, Madper Xie. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body