Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-16 Thread Manoj
t? >> > > Yes, eBPF is one of the usecases. After this, I am also planning to send > patches to BCC so that it can use this feature when compiling C to eBPF. > Tested-by: Manoj Rao I think this can definitely make it easier to use eBPF on Android. Thanks for initiating this. > Thanks! > > - Joel -- Manoj http://www.mycpu.org

Re: [PATCH] debugfs: Check return value of debugfs_real_fops() for NULL

2018-03-28 Thread Manoj Gupta
is dereferenced. Here is an example. void null_check(int *P) { int deref = *P; if (P == 0) // GCC won't check the condition. return; *P = 4; } Compiling with gcc -O2 gives: movl$4, (%rdi) ret Thanks, Manoj On Tue, Mar 27, 2018 at 11:16 PM, Greg Kroah-Hartman <

Re: [PATCH] debugfs: Check return value of debugfs_real_fops() for NULL

2018-03-28 Thread Manoj Gupta
is dereferenced. Here is an example. void null_check(int *P) { int deref = *P; if (P == 0) // GCC won't check the condition. return; *P = 4; } Compiling with gcc -O2 gives: movl$4, (%rdi) ret Thanks, Manoj On Tue, Mar 27, 2018 at 11:16 PM, Greg Kroah-Hartman wrote

Re: [v3,2/2] arm64: Add software workaround for Falkor erratum 1041

2017-11-15 Thread Manoj Iyer
.13 kernel and ran the stress-ng and VM create/stop/restart testing like I did on the previous version of this patch series. Tests successfully ran on qdf2400 platform, I did not observe any regressions on the Artful 4.13 kernel. Tested-by: Manoj Iyer <manoj.i...@canonical.com> -- ==

Re: [v3,2/2] arm64: Add software workaround for Falkor erratum 1041

2017-11-15 Thread Manoj Iyer
tress-ng and VM create/stop/restart testing like I did on the previous version of this patch series. Tests successfully ran on qdf2400 platform, I did not observe any regressions on the Artful 4.13 kernel. Tested-by: Manoj Iyer -- Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-15 Thread Manoj Iyer
On Fri, 10 Nov 2017, Manoj Iyer wrote: On Thu, 9 Nov 2017, Manoj Iyer wrote: James, Looks like my VM test raised a false alarm. I retested stock Artful 4.13 kernel (No erratum 1041 patches applied). James, an update on the crash (false alarm). We suspect this is a firmware crash due

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-15 Thread Manoj Iyer
On Fri, 10 Nov 2017, Manoj Iyer wrote: On Thu, 9 Nov 2017, Manoj Iyer wrote: James, Looks like my VM test raised a false alarm. I retested stock Artful 4.13 kernel (No erratum 1041 patches applied). James, an update on the crash (false alarm). We suspect this is a firmware crash due

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-10 Thread Manoj Iyer
On Thu, 9 Nov 2017, Manoj Iyer wrote: James, Looks like my VM test raised a false alarm. I retested stock Artful 4.13 kernel (No erratum 1041 patches applied). James, an update on the crash (false alarm). We suspect this is a firmware crash due to a possible fw bug. Once

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-10 Thread Manoj Iyer
On Thu, 9 Nov 2017, Manoj Iyer wrote: James, Looks like my VM test raised a false alarm. I retested stock Artful 4.13 kernel (No erratum 1041 patches applied). James, an update on the crash (false alarm). We suspect this is a firmware crash due to a possible fw bug. Once

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
failed. Status=0 [ 464.258973] ACPI CPPC: PCC check channel failed. Status=0 [ 465.283028] ACPI CPPC: PCC check channel failed. Status=0 SYS_DBG: Running SDI image (immediate mode) SYS_DBG: Ram Dump Init SYS_DBG: Failed to init SD card SYS_DBG: Resetting system! On Thu, 9 Nov 2017, Manoj Iyer

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
failed. Status=0 [ 464.258973] ACPI CPPC: PCC check channel failed. Status=0 [ 465.283028] ACPI CPPC: PCC check channel failed. Status=0 SYS_DBG: Running SDI image (immediate mode) SYS_DBG: Ram Dump Init SYS_DBG: Failed to init SD card SYS_DBG: Resetting system! On Thu, 9 Nov 2017, Manoj Iyer

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
On Thu, 9 Nov 2017, Manoj Iyer wrote: James, (sorry for top-posting) Applied patch 3 patches to Ubuntu Artful Kernel ( 4.13.0-16-generic ) - Start 20 VMs one at a time In a loop: - Stop (virsh destroy) 20 VMs one at a time - Start (virsh start) 20 VMs one at a time. Fixing some

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
On Thu, 9 Nov 2017, Manoj Iyer wrote: James, (sorry for top-posting) Applied patch 3 patches to Ubuntu Artful Kernel ( 4.13.0-16-generic ) - Start 20 VMs one at a time In a loop: - Stop (virsh destroy) 20 VMs one at a time - Start (virsh start) 20 VMs one at a time. Fixing some

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
] [Hardware Error]: 0030: On Thu, 9 Nov 2017, James Morse wrote: Hi Manoj, On 08/11/17 19:05, Manoj Iyer wrote: On Thu, 2 Nov 2017, Shanker Donthineni wrote: The ARM architecture defines the memory locations that are permitted to be accessed

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-09 Thread Manoj Iyer
] [Hardware Error]: 0030: On Thu, 9 Nov 2017, James Morse wrote: Hi Manoj, On 08/11/17 19:05, Manoj Iyer wrote: On Thu, 2 Nov 2017, Shanker Donthineni wrote: The ARM architecture defines the memory locations that are permitted to be accessed

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-08 Thread Manoj Iyer
ssions either. I ran the stress-ng tests for over 8hrs found the system to be stable. Tested-by: Manoj Iyer <manoj.i...@canonical.com> Regards -- Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-08 Thread Manoj Iyer
s-ng tests for over 8hrs found the system to be stable. Tested-by: Manoj Iyer Regards -- Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> >

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> >> On Wed, Oct 4, 2017 at

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> &g

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> >> > > Thanks for

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
an you please test the patch I provided in the other reply? >> >> With this patch there are no errors when building the kernel with >> clang. > > Cool, thanks for checking! I will run it through full tests and queue > for upstreaming :) Just to let you know, using __BF_FIELD_CHECK macro will not Link with -O0 (GCC or Clang) since references to __compiletime_assert_xxx will not be cleaned up. Thanks, Manoj

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
provided in the other reply? >> >> With this patch there are no errors when building the kernel with >> clang. > > Cool, thanks for checking! I will run it through full tests and queue > for upstreaming :) Just to let you know, using __BF_FIELD_CHECK macro will not Link with -O0 (GCC or Clang) since references to __compiletime_assert_xxx will not be cleaned up. Thanks, Manoj

Re: mm/migrate: Fix ref-count handling when !hugepage_migration_supported()

2017-05-24 Thread Manoj Iyer
grate: correct failure handling if !hugepage_migration_support()") Reported-by: Manoj Iyer <manoj.i...@canonical.com> Signed-off-by: Punit Agrawal <punit.agra...@arm.com> Cc: Joonsoo Kim <iamjoonsoo@lge.com> Cc: Naoya Horiguchi <n-horigu...@ah.jp.nec.com> Cc: Wanpeng

Re: mm/migrate: Fix ref-count handling when !hugepage_migration_supported()

2017-05-24 Thread Manoj Iyer
grate: correct failure handling if !hugepage_migration_support()") Reported-by: Manoj Iyer Signed-off-by: Punit Agrawal Cc: Joonsoo Kim Cc: Naoya Horiguchi Cc: Wanpeng Li Cc: Christoph Lameter --- Hi Andrew, We ran into this bug when working towards enabling memory corruption on arm64.

iommu: Fix incompatible arg type in iommu_put/get_resv_regions

2017-05-05 Thread Manoj Iyer
In linux-next struct device dev; was added to struct iommu_device this breaks calls to iommu_put/get_resv_regions function because these functions expect struct device * instead. Please review and consider this patch to fix this. Thanks Manoj Iyer

iommu: Fix incompatible arg type in iommu_put/get_resv_regions

2017-05-05 Thread Manoj Iyer
In linux-next struct device dev; was added to struct iommu_device this breaks calls to iommu_put/get_resv_regions function because these functions expect struct device * instead. Please review and consider this patch to fix this. Thanks Manoj Iyer

[PATCH] iommu: Fix incompatible arg type passed to iommu_get/put_resv_regions

2017-05-05 Thread Manoj Iyer
to struct iommu_device instead of struct device * but the code in drivers/iommu/iommu.c was not refactored to take this change into account. Signed-off-by: Manoj Iyer <manoj.i...@canonical.com> --- drivers/iommu/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] iommu: Fix incompatible arg type passed to iommu_get/put_resv_regions

2017-05-05 Thread Manoj Iyer
to struct iommu_device instead of struct device * but the code in drivers/iommu/iommu.c was not refactored to take this change into account. Signed-off-by: Manoj Iyer --- drivers/iommu/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iom

[PATCH 2/4] Staging: bcm2835-audio: bcm835-ctl.c: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed the following warning : "drivers/staging/bcm2835-audio/bcm2835-ctl.c:251: WARNING: Block comments use a trailing */ on a separate line" Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 3 ++- 1 file changed, 2 insertion

[PATCH 2/4] Staging: bcm2835-audio: bcm835-ctl.c: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed the following warning : "drivers/staging/bcm2835-audio/bcm2835-ctl.c:251: WARNING: Block comments use a trailing */ on a separate line" Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue

2017-02-24 Thread Manoj Sawai
fixed the following checkpatch.pl warning: "drivers/staging/bcm2835-audio/bcm2835-pcm.c:320: WARNING: braces {} are not necessary for single statement blocks" Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 7 --- 1 file chang

[PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue

2017-02-24 Thread Manoj Sawai
fixed the following checkpatch.pl warning: "drivers/staging/bcm2835-audio/bcm2835-pcm.c:320: WARNING: braces {} are not necessary for single statement blocks" Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed a checkpatch.pl about coding style in comments. '*' missing on subsequent lines. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm283

[PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed a checkpatch.pl about coding style in comments. '*' missing on subsequent lines. Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging

[PATCH 4/4] Staging: bcm2835-audio: bcm2835-vchiq.c: lines over 80 character limit

2017-02-24 Thread Manoj Sawai
Trimmed lines that were unnecessarily over 80 characters long. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/d

[PATCH 4/4] Staging: bcm2835-audio: bcm2835-vchiq.c: lines over 80 character limit

2017-02-24 Thread Manoj Sawai
Trimmed lines that were unnecessarily over 80 characters long. Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835

Re: arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Manoj Iyer
Tested on Ubuntu 17.04 (Linux 4.10). I am able to boot the kernel on QDF2400 platform without any panics. Tested-by: Manoj Iyer <manoj.i...@canonical.com> -- ==== Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud On Wed, 22 Fe

Re: arm64: Fix the kernel panic() on QDF2400 platform

2017-02-23 Thread Manoj Iyer
Tested on Ubuntu 17.04 (Linux 4.10). I am able to boot the kernel on QDF2400 platform without any panics. Tested-by: Manoj Iyer -- Manoj Iyer Ubuntu/Canonical ARM Servers - Cloud On Wed, 22 Feb 2017, Shanker Donthineni wrote

[PATCH 1/2] Staging: ks7010: ks7010_sdio.h: Complex macro not in parentheses

2016-12-12 Thread Manoj Sawai
Fixed coding style error. Complex macro not inside parentheses. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_

[PATCH 1/2] Staging: ks7010: ks7010_sdio.h: Complex macro not in parentheses

2016-12-12 Thread Manoj Sawai
Fixed coding style error. Complex macro not inside parentheses. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0f5fd848e23d

[PATCH 2/2] Staging: ks7010: ks7010_sdio.h: Trailing whitespace

2016-12-12 Thread Manoj Sawai
Removed trailing whitespace. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 5820b5c9b684..016599

[PATCH 2/2] Staging: ks7010: ks7010_sdio.h: Trailing whitespace

2016-12-12 Thread Manoj Sawai
Removed trailing whitespace. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 5820b5c9b684..0165994605ac 100644 --- a/drivers

[PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style error

2016-12-09 Thread Manoj Sawai
Error - Complex macro not in parentheses and trailing whitespace Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/

[PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style error

2016-12-09 Thread Manoj Sawai
Error - Complex macro not in parentheses and trailing whitespace Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index

[PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors

2016-12-08 Thread Manoj Sawai
Errors - Complex macro not a parentheses and trailing whitespace Also fixed other small checkpatch warnings and checks. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/d

[PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors

2016-12-08 Thread Manoj Sawai
Errors - Complex macro not a parentheses and trailing whitespace Also fixed other small checkpatch warnings and checks. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010

[PATCH 2/2] Staging: ks7010: eap_packet.h: fixed coding style issue

2016-12-04 Thread Manoj Sawai
Rearranged comments so that lines are less than 80 characters long Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/eap_packet.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/

[PATCH 2/2] Staging: ks7010: eap_packet.h: fixed coding style issue

2016-12-04 Thread Manoj Sawai
Rearranged comments so that lines are less than 80 characters long Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/eap_packet.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index

[PATCH] Staging: ks7010: ks7010_stio.h: fixed coding style error

2016-12-04 Thread Manoj Sawai
Fixed 2 coding style errors about trailing whitespaces. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_

[PATCH] Staging: ks7010: ks7010_stio.h: fixed coding style error

2016-12-04 Thread Manoj Sawai
Fixed 2 coding style errors about trailing whitespaces. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0a0951a6

[PATCH] Staging: ks7010: ks7010_sdio.c: Fixed a coding style issue.

2016-10-29 Thread Manoj Sawai
Fixed a coding style error involving use of spaces instead of tabs. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/

[PATCH] Staging: ks7010: ks7010_sdio.c: Fixed a coding style issue.

2016-10-29 Thread Manoj Sawai
Fixed a coding style error involving use of spaces instead of tabs. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 81c46f4

[PATCH] Staging: ks7010: ks7010_stio: Fixed several coding style issues

2016-10-28 Thread Manoj Sawai
Fixed all the "errors" reported by checkpath.pl in ks7010_stio.c The "TODO" file ask to take the 80 character limit lightly, so the file still has some warnings about character limit. All the errors have been removed. Signed-off-by: Manoj Sawai <m...@iitkgp.ac.in> -

[PATCH] Staging: ks7010: ks7010_stio: Fixed several coding style issues

2016-10-28 Thread Manoj Sawai
Fixed all the "errors" reported by checkpath.pl in ks7010_stio.c The "TODO" file ask to take the 80 character limit lightly, so the file still has some warnings about character limit. All the errors have been removed. Signed-off-by: Manoj Sawai --- drivers/staging/ks701

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-28 Thread Ratna Manoj
Hi, On Thursday 28 April 2016 09:57 PM, Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: >>> Thanks for the review. >>> >>> Atleast fo

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-28 Thread Ratna Manoj
Hi, On Thursday 28 April 2016 09:57 PM, Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: >>> Thanks for the review. >>> >>> Atleast fo

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-22 Thread Ratna Manoj
to replacing disk with different disk suddenly). Ratna. On Wed, Apr 20, 2016 at 4:36 PM, Markus Pargmann <m...@pengutronix.de> wrote: > Hi, > > On Thursday 24 March 2016 07:04:10 Ratna Manoj wrote: > > From: Ratna Manoj Bolla <manoj...@gmail.com> > > > >

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-22 Thread Ratna Manoj
to replacing disk with different disk suddenly). Ratna. On Wed, Apr 20, 2016 at 4:36 PM, Markus Pargmann wrote: > Hi, > > On Thursday 24 March 2016 07:04:10 Ratna Manoj wrote: > > From: Ratna Manoj Bolla > > > > When a filesystem is mounted on a nbd device a

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd()

2016-03-11 Thread Manoj Kumar
ata *h, { int rel_port = -1, group_id; struct alua_port_group *pg, *old_pg = NULL; - bool pg_updated; + bool pg_updated = false; unsigned long flags; Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd()

2016-03-11 Thread Manoj Kumar
, group_id; struct alua_port_group *pg, *old_pg = NULL; - bool pg_updated; + bool pg_updated = false; unsigned long flags; Reviewed-by: Manoj Kumar --- Manoj Kumar

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 drivers

Re: [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are off by one. They are currently defined as 0x06 and 0x07 respetively. These values are defined in PAPR correctly as 0x05 and 0x06

Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-12 Thread Manoj Kumar
Tyrel: Thanks for incorporating the suggestions. Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a valid command/response entry (0x80

Re: [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are off by one. They are currently defined as 0x06 and 0x07 respetively. These values are defined in PAPR cor

Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-12 Thread Manoj Kumar
Tyrel: Thanks for incorporating the suggestions. Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Manoj Kumar
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vne

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-09 Thread Manoj Kumar
lid header that doesn't have its first bit set will also be logged by the ibmvscsi_handle_crq() switch statement default block and not silently ignored. -Tyrel Sounds good, Tyrel. Does this mean I should expect a v2 of this patch series? - Manoj N. Kumar

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-09 Thread Manoj Kumar
lid header that doesn't have its first bit set will also be logged by the ibmvscsi_handle_crq() switch statement default block and not silently ignored. -Tyrel Sounds good, Tyrel. Does this mean I should expect a v2 of this patch series? - Manoj N. Kumar

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-04 Thread Manoj Kumar
On 2/3/2016 5:28 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a valid command/response entry (0x80), a valid initialization entry (0xC0), and a transport event (0xFF). Define these values as enums

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-04 Thread Manoj Kumar
On 2/3/2016 5:28 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a valid command/response entry (0x80), a valid initialization entry (0xC0), and a transport event (0xFF). Define these values as enums

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-10-30 Thread Manoj Kumar
Tim: Reviewed-by: Manoj Kumar --- Manoj Kumar On 10/30/2015 1:22 PM, tim.gard...@canonical.com wrote: From: Tim Gardner drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-10-30 Thread Manoj Kumar
Tim: Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 10/30/2015 1:22 PM, tim.gard...@canonical.com wrote: From: Tim Gardner <tim.gard...@canonical.com> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_ma

Re: [PATCH 3/3] cxlflash: drop unlikely before IS_ERR_OR_NULL

2015-10-01 Thread Manoj Kumar
Geliang: Thanks for catching this. - Manoj Acked-by: Manoj Kumar On 9/30/2015 9:55 PM, Geliang Tang wrote: IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang --- drivers/scsi/cxlflash/superpipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 3/3] cxlflash: drop unlikely before IS_ERR_OR_NULL

2015-10-01 Thread Manoj Kumar
Geliang: Thanks for catching this. - Manoj Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> On 9/30/2015 9:55 PM, Geliang Tang wrote: IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang <geliangt...@163.com> --- drivers/scsi/cxlflash

Re: fakeroot make-kpkg is broken in 3.14

2014-04-11 Thread Manoj Srivastava
Hi, On Mon, Apr 07 2014, Alexei Starovoitov wrote: > looks like it's a problem of make-kpkg itself. I am afraid kernel-package has long need some attention; I am hoping to be able to do so in the coming month. manoj -- A mind is a wonderful thing to waste. Manoj Srivast

Re: fakeroot make-kpkg is broken in 3.14

2014-04-11 Thread Manoj Srivastava
Hi, On Mon, Apr 07 2014, Alexei Starovoitov wrote: looks like it's a problem of make-kpkg itself. I am afraid kernel-package has long need some attention; I am hoping to be able to do so in the coming month. manoj -- A mind is a wonderful thing to waste. Manoj Srivastava

RE: [PATCH] usb: hub: Avoid tight loop holding hdev lock

2014-01-30 Thread Manoj Chourasia
); kref_put(>kref, hub_release); + /* preventing tight loop holding hdev lock */ + msleep(20); + } /* end while (1) */ } -Manoj -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tues

RE: [PATCH] usb: hub: Avoid tight loop holding hdev lock

2014-01-30 Thread Manoj Chourasia
); kref_put(hub-kref, hub_release); + /* preventing tight loop holding hdev lock */ + msleep(20); + } /* end while (1) */ } -Manoj -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tuesday

[PATCH] usb: hub: Avoid tight loop holding hdev lock

2013-12-31 Thread Manoj Chourasia
. The call to usb_open stuck for very long time(sometimes forever) because the priority of kernel thread is higher than that system call in this case. Signed-off-by: Manoj Chourasia diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index c5c3667..b968fd5 100644 --- a/drivers

[PATCH] usb: hub: Avoid tight loop holding hdev lock

2013-12-31 Thread Manoj Chourasia
. The call to usb_open stuck for very long time(sometimes forever) because the priority of kernel thread is higher than that system call in this case. Signed-off-by: Manoj Chourasia mchoura...@nvidia.com diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index c5c3667..b968fd5

FW: [PATCH] hidraw: close underlying device at removal of last reader

2013-10-01 Thread Manoj Chourasia
proposing following patch as fix.  Please review it.  Mika will help in testing. >From b37519b65be0d51b90c5fc177c0dc0cd2f6358b1 Mon Sep 17 00:00:00 2001 From: Manoj Chourasia Date: Tue, 1 Oct 2013 15:39:00 +0530 Subject: [PATCH] HID: hidraw: close underly

FW: [PATCH] hidraw: close underlying device at removal of last reader

2013-10-01 Thread Manoj Chourasia
proposing following patch as fix.  Please review it.  Mika will help in testing. From b37519b65be0d51b90c5fc177c0dc0cd2f6358b1 Mon Sep 17 00:00:00 2001 From: Manoj Chourasia mchoura...@nvidia.com Date: Tue, 1 Oct 2013 15:39:00 +0530 Subject: [PATCH] HID: hidraw

RE: [PATCH] hidraw: correctly deallocate memory on device disconnect

2013-09-23 Thread Manoj Chourasia
Hi Jiri, What is the final proposed fix for this issue? Thanks -Manoj -Original Message- From: Peter Wu [mailto:lekenst...@gmail.com] Sent: Tuesday, August 20, 2013 7:44 PM To: Jiri Kosina Cc: Manoj Chourasia; linux-kernel@vger.kernel.org Subject: Re: [PATCH] hidraw: correctly

RE: [PATCH] hidraw: correctly deallocate memory on device disconnect

2013-09-23 Thread Manoj Chourasia
Hi Jiri, What is the final proposed fix for this issue? Thanks -Manoj -Original Message- From: Peter Wu [mailto:lekenst...@gmail.com] Sent: Tuesday, August 20, 2013 7:44 PM To: Jiri Kosina Cc: Manoj Chourasia; linux-kernel@vger.kernel.org Subject: Re: [PATCH] hidraw: correctly

RE: List corruption in hidraw_release in 3.11-rc4

2013-08-07 Thread Manoj Chourasia
then the patch could solve your issue. Regards -Manoj -Original Message- From: Jiri Kosina [mailto:jkos...@suse.cz] Sent: Wednesday, August 07, 2013 7:04 PM To: Peter Wu Cc: linux-in...@vger.kernel.org; Manoj Chourasia; linux-kernel@vger.kernel.org; alno...@suse.cz Subject: Re: List corruption

RE: List corruption in hidraw_release in 3.11-rc4

2013-08-07 Thread Manoj Chourasia
then the patch could solve your issue. Regards -Manoj -Original Message- From: Jiri Kosina [mailto:jkos...@suse.cz] Sent: Wednesday, August 07, 2013 7:04 PM To: Peter Wu Cc: linux-in...@vger.kernel.org; Manoj Chourasia; linux-kernel@vger.kernel.org; alno...@suse.cz Subject: Re: List corruption

[PATCH] hidraw: correctly deallocate memory on device disconnect

2013-07-22 Thread Manoj Chourasia
. The bug that was there in the commit that he was deleting list after words and feeing head of it before. I am attaching the patch. -regards Manoj --- diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index a745163

[PATCH] hidraw: correctly deallocate memory on device disconnect

2013-07-22 Thread Manoj Chourasia
can give evidence on issue. The bug that was there in the commit that he was deleting list after words and feeing head of it before. I am attaching the patch. -regards Manoj --- diff --git a/drivers/hid/hidraw.c b/drivers

[PATCH 1/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer Signed-off-by: Manoj Iyer Reported-by: Timo Aaltonen Original-author: Timo Aaltonen BugLink: http://bugs.launchpad.net/bugs/348861 --- drivers/usb/storage/unusual_devs.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_devs.h b

[PATCH 0/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer This patch enables GE0301 3G modem as an interface, the patch has been part of the Ubuntu kernel for a while but I forgot to upstream. Test details can be found in the bug http://bugs.launchpad.net/bugs/348861 Please consider this patch for upstream. Manoj Iyer (1): USB

[PATCH 0/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer manoj.i...@canonical.com This patch enables GE0301 3G modem as an interface, the patch has been part of the Ubuntu kernel for a while but I forgot to upstream. Test details can be found in the bug http://bugs.launchpad.net/bugs/348861 Please consider this patch for upstream

[PATCH 1/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer manoj.i...@canonical.com Signed-off-by: Manoj Iyer manoj.i...@canonical.com Reported-by: Timo Aaltonen tjaal...@ubuntu.com Original-author: Timo Aaltonen tjaal...@ubuntu.com BugLink: http://bugs.launchpad.net/bugs/348861 --- drivers/usb/storage/unusual_devs.h |7 +++ 1

Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

2012-11-26 Thread Manoj Iyer
Chris, Do you know what systems produce these errors? I can look and see if we have those for testing your patch. Cheers Manoj On Wed, 21 Nov 2012, Chris Ball wrote: Hi Manoj, Matsumuro-san, On Mon, Jul 18 2011, Manoj Iyer wrote: Right, without the patch I get.. [ 52.526665] mmc0

Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

2012-11-26 Thread Manoj Iyer
Chris, Do you know what systems produce these errors? I can look and see if we have those for testing your patch. Cheers Manoj On Wed, 21 Nov 2012, Chris Ball wrote: Hi Manoj, Matsumuro-san, On Mon, Jul 18 2011, Manoj Iyer wrote: Right, without the patch I get.. [ 52.526665] mmc0

[PATCH 1/1] thinkpad-acpi: enable loading module with new B-series Lenovo BIOS

2012-09-24 Thread manoj . iyer
From: Manoj Iyer The new B series BIOS has version string 43CN46WW. The driver requires that 2nd and 3rd characters be 'E' and 'T' respectively, where as the newer BIOS has 'C' and 'N' respectively. Failing to load the module causes some of the hotkeys to not work. Before the patch

[PATCH 0/1] thinkpad-acpi: enable loading module with new B-series Lenovo BIOS

2012-09-24 Thread manoj . iyer
From: Manoj Iyer The new B series BIOS has version string 43CN46WW. The driver requires that 2nd and 3rd characters be 'E' and 'T' respectively, where as the newer BIOS has 'C' and 'N' respectively. Failing to load the module causes some of the hotkeys to not work. This was tested by me

[PATCH 0/1] thinkpad-acpi: enable loading module with new B-series Lenovo BIOS

2012-09-24 Thread manoj . iyer
From: Manoj Iyer manoj.i...@canonical.com The new B series BIOS has version string 43CN46WW. The driver requires that 2nd and 3rd characters be 'E' and 'T' respectively, where as the newer BIOS has 'C' and 'N' respectively. Failing to load the module causes some of the hotkeys to not work

[PATCH 1/1] thinkpad-acpi: enable loading module with new B-series Lenovo BIOS

2012-09-24 Thread manoj . iyer
From: Manoj Iyer manoj.i...@canonical.com The new B series BIOS has version string 43CN46WW. The driver requires that 2nd and 3rd characters be 'E' and 'T' respectively, where as the newer BIOS has 'C' and 'N' respectively. Failing to load the module causes some of the hotkeys to not work

[PATCH 1/1] xhci: Recognize USB 3.0 devices as superspeed at powerup

2012-08-22 Thread manoj . iyer
From: Manoj Iyer On Intel Panther Point chipset USB 3.0 devices show up as high-speed devices on powerup, but after an s3 cycle they are correctly recognized as SuperSpeed. At powerup switch the port to xHCI so that USB 3.0 devices are correctly recognized. BugLink: http://bugs.launchpad.net

  1   2   >