Re: [PATCH] debugfs: Check return value of debugfs_real_fops() for NULL

2018-03-28 Thread Manoj Gupta
Please note that there is nothing wrong in the generated code, just that it confuses objtool. Clang has simply omitted the statement where NULL is returned since the pointer was always dereferenced post inlining. Note that GCC will also remove the NULL pointers if it knows that the pointer is

Re: [PATCH] debugfs: Check return value of debugfs_real_fops() for NULL

2018-03-28 Thread Manoj Gupta
Please note that there is nothing wrong in the generated code, just that it confuses objtool. Clang has simply omitted the statement where NULL is returned since the pointer was always dereferenced post inlining. Note that GCC will also remove the NULL pointers if it knows that the pointer is

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> >

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> >> On Wed, Oct 4, 2017 at

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> &g

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: >> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: >> > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> >> > > Thanks for

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
Hi Jakub, On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> > > Thanks for the suggestion. This seems a viable alternative if David >> > > and the NFP owners can live without the extra checking

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-04 Thread Manoj Gupta
Hi Jakub, On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: >> > > Thanks for the suggestion. This seems a viable alternative if David >> > > and the NFP owners can live without the extra checking provided by >> > >