Re: [PATCH] RDMA/core: Fix error return in _ib_modify_qp()

2020-10-18 Thread Maor Gottlieb
if (IS_ERR(slave)) { + ret = PTR_ERR(slave); goto out_av; + } attr->xmit_slave = slave; } } Looks good, Reviewed-by: Maor Gottlieb

Re: [PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-02 Thread Maor Gottlieb
On 10/2/2020 6:02 PM, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 09:46:44AM +0300, Leon Romanovsky wrote: +struct scatterlist *__sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, unsigned int offset, + unsigned long siz

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Maor Gottlieb
On 9/30/2020 6:14 PM, Jason Gunthorpe wrote: On Wed, Sep 30, 2020 at 06:05:15PM +0300, Maor Gottlieb wrote: This is right only for the last iteration. E.g. in the first iteration in case that there are more pages (left_pages), then we allocate SG_MAX_SINGLE_ALLOC.  We don't know how

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Maor Gottlieb
On 9/30/2020 2:58 PM, Jason Gunthorpe wrote: On Wed, Sep 30, 2020 at 02:53:58PM +0300, Maor Gottlieb wrote: On 9/30/2020 2:45 PM, Jason Gunthorpe wrote: On Wed, Sep 30, 2020 at 12:53:21PM +0300, Leon Romanovsky wrote: On Tue, Sep 29, 2020 at 04:59:29PM -0300, Jason Gunthorpe wrote: On Sun

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Maor Gottlieb
On 9/30/2020 2:45 PM, Jason Gunthorpe wrote: On Wed, Sep 30, 2020 at 12:53:21PM +0300, Leon Romanovsky wrote: On Tue, Sep 29, 2020 at 04:59:29PM -0300, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 09:46:47AM +0300, Leon Romanovsky wrote: @@ -296,11 +223,17 @@ static struct ib_umem *__ib_um

Re: [PATCH rdma-next 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-07 Thread Maor Gottlieb
On 9/7/2020 10:29 AM, Christoph Hellwig wrote: On Thu, Sep 03, 2020 at 03:18:52PM +0300, Leon Romanovsky wrote: +struct sg_append { + struct scatterlist *prv; /* Previous entry to append */ + unsigned int left_pages; /* Left pages to add to table */ +}; I don't really see the poin

Re: [PATCH rdma-next 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries

2020-09-07 Thread Maor Gottlieb
On 9/7/2020 10:29 AM, Christoph Hellwig wrote: +static inline void _sg_chain(struct scatterlist *chain_sg, +struct scatterlist *sgl) +{ + /* +* offset and length are unused for chain entry. Clear them. +*/ + chain_sg->offset = 0; + c

Re: [PATCH rdma-next 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages

2020-09-07 Thread Maor Gottlieb
On 9/7/2020 10:29 AM, Christoph Hellwig wrote: On Thu, Sep 03, 2020 at 06:54:34PM +0300, Leon Romanovsky wrote: From: Maor Gottlieb Currently, sg_alloc_table_from_pages doesn't support dynamic chaining of SG entries. Therefore it requires from user to allocate all the pages in advanc

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-19 Thread Maor Gottlieb
2016-03-16 2:58 GMT+02:00 Stephen Rothwell : > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c > > between commit: > > 60ab4584f5bf ("net/mlx5_core: Set flow steering dest only for forward > rules") > > from the net