Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

> @@ -908,6 +943,7 @@ extern struct efi { > unsigned long properties_table; /* properties table */ > unsigned long mem_attr_table; /* memory attributes table */ > unsigned long rng_seed; /* UEFI firmware random seed */ > + unsigned long tpm_log; /* TPM2 Event Log table */ > efi_get_time_t *get_time; > efi_set_time_t *set_time; > efi_get_wakeup_time_t *get_wakeup_time; > @@ -1504,6 +1540,8 @@ static inline void > efi_enable_reset_attack_mitigation(efi_system_table_t *sys_table_arg) { } > #endif > > +void efi_retrieve_tpm2_eventlog(efi_system_table_t *sys_table); > + > /* > * Arch code can implement the following three template macros, avoiding > * reptition for the void/non-void return cases of {__,}efi_call_virt(): > @@ -1571,4 +1609,12 @@ struct linux_efi_random_seed { > u8 bits[]; > }; > > +struct linux_efi_tpm_eventlog { > + u32 size; > + u8 version; > + u8 log[]; > +}; > + > +extern int efi_tpm_eventlog_init(void); > + > #endif /* _LINUX_EFI_H */ > -- > 2.14.1.821.g8fa685d3b7-goog > -- Marc-André Lureau

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

EVENT_LOG_GUID EFI_GUID(0xb7799cb0, 0xeca2, > 0x4943, 0x96, 0x67, 0x1f, 0xae, 0x07, 0xb7, 0x47, 0xfa) > > typedef struct { > efi_guid_t guid; > @@ -908,6 +943,7 @@ extern struct efi { > unsigned long properties_table; /* properties table */ > unsigned long mem_attr_table; /* memory attributes table */ > unsigned long rng_seed; /* UEFI firmware random seed */ > + unsigned long tpm_log; /* TPM2 Event Log table */ > efi_get_time_t *get_time; > efi_set_time_t *set_time; > efi_get_wakeup_time_t *get_wakeup_time; > @@ -1504,6 +1540,8 @@ static inline void > efi_enable_reset_attack_mitigation(efi_system_table_t *sys_table_arg) { } > #endif > > +void efi_retrieve_tpm2_eventlog(efi_system_table_t *sys_table); > + > /* > * Arch code can implement the following three template macros, avoiding > * reptition for the void/non-void return cases of {__,}efi_call_virt(): > @@ -1571,4 +1609,12 @@ struct linux_efi_random_seed { > u8 bits[]; > }; > > +struct linux_efi_tpm_eventlog { > + u32 size; > + u8 version; > + u8 log[]; > +}; > + > +extern int efi_tpm_eventlog_init(void); > + > #endif /* _LINUX_EFI_H */ > -- > 2.14.1.821.g8fa685d3b7-goog > -- Marc-André Lureau

Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

Hi On Fri, Mar 2, 2018 at 7:03 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote: >> Hi >> >> On 02/28/18 at 04:06pm, Marc-André Lureau wrote: >> > The following patch is going to use the symbol

Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

Hi On Fri, Mar 2, 2018 at 7:03 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote: >> Hi >> >> On 02/28/18 at 04:06pm, Marc-André Lureau wrote: >> > The following patch is going to use the symbol from the fw_cfg module, >&

Re: rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

gt;> >> Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right >> on resume on that box. Can you ask the reporter to: >> >> echo 1 > /sys/power/pm_print_times >> suspend/resume > > He uploaded it here: > https://bugzilla.suse.com/attachment.cgi?id=759933 > Same problem (with f27 and upstream kernel), is there anything else we can do to help? Should we open a bug on http://bugzilla.kernel.org ? thanks -- Marc-André Lureau

Re: rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

maybe the seuence between psmouse and rmi/smbus is not quite right >> on resume on that box. Can you ask the reporter to: >> >> echo 1 > /sys/power/pm_print_times >> suspend/resume > > He uploaded it here: > https://bugzilla.suse.com/attachment.cgi?id=759933 > Same problem (with f27 and upstream kernel), is there anything else we can do to help? Should we open a bug on http://bugzilla.kernel.org ? thanks -- Marc-André Lureau

Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

Hi On Wed, Feb 28, 2018 at 6:32 PM, Michael S. Tsirkin wrote: >> @@ -557,7 +566,10 @@ static int fw_cfg_sysfs_probe(struct platform_device >> *pdev) >> goto err_probe; >> >> /* get revision number, add matching top-level attribute */ >> -

Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

Hi On Wed, Feb 28, 2018 at 6:32 PM, Michael S. Tsirkin wrote: >> @@ -557,7 +566,10 @@ static int fw_cfg_sysfs_probe(struct platform_device >> *pdev) >> goto err_probe; >> >> /* get revision number, add matching top-level attribute */ >> - fw_cfg_read_blob(FW_CFG_ID, , 0,

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Wed, Feb 28, 2018 at 6:17 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Feb 28, 2018 at 04:41:51PM +0100, Marc-André Lureau wrote: >> I don't know if it's always safe to enable dma in read_raw(), how >> could we know? Is there a check we could use to choose

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Wed, Feb 28, 2018 at 6:17 PM, Michael S. Tsirkin wrote: > On Wed, Feb 28, 2018 at 04:41:51PM +0100, Marc-André Lureau wrote: >> I don't know if it's always safe to enable dma in read_raw(), how >> could we know? Is there a check we could use to choose one or ther >

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Wed, Feb 28, 2018 at 4:48 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Feb 28, 2018 at 04:41:51PM +0100, Marc-André Lureau wrote: >> I don't know if it's always safe to enable dma in read_raw(), how >> could we know? Is there a check we could use to choose

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Wed, Feb 28, 2018 at 4:48 PM, Michael S. Tsirkin wrote: > On Wed, Feb 28, 2018 at 04:41:51PM +0100, Marc-André Lureau wrote: >> I don't know if it's always safe to enable dma in read_raw(), how >> could we know? Is there a check we could use to choose one or ther >

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

On Wed, Feb 28, 2018 at 4:35 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Feb 28, 2018 at 01:27:02PM +0100, Marc-André Lureau wrote: >> Hi >> >> On Tue, Feb 27, 2018 at 1:04 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Thu, Fe

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

On Wed, Feb 28, 2018 at 4:35 PM, Michael S. Tsirkin wrote: > On Wed, Feb 28, 2018 at 01:27:02PM +0100, Marc-André Lureau wrote: >> Hi >> >> On Tue, Feb 27, 2018 at 1:04 AM, Michael S. Tsirkin wrote: >> > On Thu, Feb 15, 2018 at 10:33:12PM +0100, Marc-An

[PATCH v16 01/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index a41b572eeeb1..e7ea2b3b1d11 100644 --- a/drivers/firmware/qemu_fw_cfg.c

[PATCH v16 01/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index a41b572eeeb1..e7ea2b3b1d11 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware

[PATCH v16 04/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 inse

[PATCH v16 04/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

be handled appropriately. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c

[PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

be handled appropriately. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 0cc71d028ae3..45bfc389b226 100644

[PATCH v16 05/11] fw_cfg: remove inline from fw_cfg_read_blob()

The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v16 05/11] fw_cfg: remove inline from fw_cfg_read_blob()

The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b

[PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

gt; CC: Dave Young <dyo...@redhat.com> CC: Dave Young <dyo...@redhat.com> CC: Hari Bathini <hbath...@linux.vnet.ibm.com> CC: Tony Luck <tony.l...@intel.com> CC: Vivek Goyal <vgo...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Ack

[PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

: Tony Luck CC: Vivek Goyal Signed-off-by: Marc-André Lureau Acked-by: Gabriel Somlo --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 4f63597c824d..a93590cdd9e1 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c

[PATCH v16 10/11] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 145 ++- include/uapi/linux/qemu_fw_cfg.h | 31 + 2 files changed, 173 insertions(+), 3 deletion

[PATCH v16 10/11] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 145 ++- include/uapi/linux/qemu_fw_cfg.h | 31 + 2 files changed, 173 insertions(+), 3 deletions(-) diff --git a/drivers/firm

[PATCH v16 11/11] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 68 ++ 1 file changed, 55 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 14f

[PATCH v16 11/11] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 68 ++ 1 file changed, 55 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 14fedbeca724..db1cba4f99bd 100644 --- a

[PATCH v16 07/11] fw_cfg: add a public uapi header

Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- The related qemu patch making use of it, to be submitted: https://github.com/elmarco/qemu/commit/4884fc9e9c4c4467a371e5a40f3181239e1b70f5 --- MAINTAINERS | 1

[PATCH v16 08/11] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.

[PATCH v16 08/11] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau Reviewed-by: Gabriel Somlo

[PATCH v16 07/11] fw_cfg: add a public uapi header

by: Michael S. Tsirkin Signed-off-by: Marc-André Lureau --- The related qemu patch making use of it, to be submitted: https://github.com/elmarco/qemu/commit/4884fc9e9c4c4467a371e5a40f3181239e1b70f5 --- MAINTAINERS | 1 + drivers/firmware/qemu_fw_cfg.c | 22 ++--

[PATCH v16 03/11] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[PATCH v16 03/11] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v16 02/11] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_c

[PATCH v16 02/11] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware

[PATCH v16 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support

h, fixing kbuild .config test Marc-André Lureau (11): fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() fw_cfg: fix sparse warnings with fw_cfg_file fw_cfg: fix sparse warning reading FW_CFG_ID fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read fw_cfg: remove inline from fw_c

[PATCH v16 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support

h, fixing kbuild .config test Marc-André Lureau (11): fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() fw_cfg: fix sparse warnings with fw_cfg_file fw_cfg: fix sparse warning reading FW_CFG_ID fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read fw_cfg: remove inline from fw_c

Re: [PATCH] fw_cfg: avoid unused function warning

Hi On Wed, Feb 28, 2018 at 2:33 PM, Arnd Bergmann wrote: > The newly introduced fw_cfg_dma_transfer() function is unused when > CONFIG_CRASH_CORE is disabled: > > drivers/firmware/qemu_fw_cfg.c:89:16: error: 'fw_cfg_dma_transfer' defined > but not used [-Werror=unused-function] >

Re: [PATCH] fw_cfg: avoid unused function warning

Hi On Wed, Feb 28, 2018 at 2:33 PM, Arnd Bergmann wrote: > The newly introduced fw_cfg_dma_transfer() function is unused when > CONFIG_CRASH_CORE is disabled: > > drivers/firmware/qemu_fw_cfg.c:89:16: error: 'fw_cfg_dma_transfer' defined > but not used [-Werror=unused-function] > static

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Tue, Feb 27, 2018 at 1:04 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Feb 15, 2018 at 10:33:12PM +0100, Marc-André Lureau wrote: >> Modify fw_cfg_read_blob() to use DMA if the device supports it. >> Return errors, because the operation may fail. >&g

Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

Hi On Tue, Feb 27, 2018 at 1:04 AM, Michael S. Tsirkin wrote: > On Thu, Feb 15, 2018 at 10:33:12PM +0100, Marc-André Lureau wrote: >> Modify fw_cfg_read_blob() to use DMA if the device supports it. >> Return errors, because the operation may fail. >> >

Re: [PATCH v15 10/11] fw_cfg: write vmcoreinfo details

Hi On Tue, Feb 27, 2018 at 1:28 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Feb 15, 2018 at 10:33:11PM +0100, Marc-André Lureau wrote: >> If the "etc/vmcoreinfo" fw_cfg file is present and we are not running >> the kdump kernel, write the addr/

Re: [PATCH v15 10/11] fw_cfg: write vmcoreinfo details

Hi On Tue, Feb 27, 2018 at 1:28 AM, Michael S. Tsirkin wrote: > On Thu, Feb 15, 2018 at 10:33:11PM +0100, Marc-André Lureau wrote: >> If the "etc/vmcoreinfo" fw_cfg file is present and we are not running >> the kdump kernel, write the addr/size of the vmcoreinfo ELF note

Re: [PATCH v15 02/11] fw_cfg: add a public uapi header

On Tue, Feb 27, 2018 at 1:06 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Feb 15, 2018 at 10:33:03PM +0100, Marc-André Lureau wrote: >> Create a common header file for well-known values and structures to be >> shared by the Linux kernel with qemu or other projec

Re: [PATCH v15 02/11] fw_cfg: add a public uapi header

On Tue, Feb 27, 2018 at 1:06 AM, Michael S. Tsirkin wrote: > On Thu, Feb 15, 2018 at 10:33:03PM +0100, Marc-André Lureau wrote: >> Create a common header file for well-known values and structures to be >> shared by the Linux kernel with qemu or other projects. >> >>

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

Hi On Tue, Feb 27, 2018 at 1:20 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Feb 15, 2018 at 10:33:09PM +0100, Marc-André Lureau wrote: >> fw_cfg_read_blob() may fail, but does not return error. This may lead >> to undefined behaviours, such as a memcmp(sig, &q

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

Hi On Tue, Feb 27, 2018 at 1:20 AM, Michael S. Tsirkin wrote: > On Thu, Feb 15, 2018 at 10:33:09PM +0100, Marc-André Lureau wrote: >> fw_cfg_read_blob() may fail, but does not return error. This may lead >> to undefined behaviours, such as a memcmp(sig, "QEMU") on unin

[PATCH v15 01/11] crash: export paddr_vmcoreinfo_note()

gt; CC: Dave Young <dyo...@redhat.com> CC: Dave Young <dyo...@redhat.com> CC: Hari Bathini <hbath...@linux.vnet.ibm.com> CC: Tony Luck <tony.l...@intel.com> CC: Vivek Goyal <vgo...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Ack

[PATCH v15 02/11] fw_cfg: add a public uapi header

Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- The related qemu patch making use of it, to be submitted: https://github.com/elmarco/qemu/commit/4884fc9e9c4c4467a371e5a40f3181239e1b70f5 --- MAINTAINERS| 1 + d

[PATCH v15 01/11] crash: export paddr_vmcoreinfo_note()

: Tony Luck CC: Vivek Goyal Signed-off-by: Marc-André Lureau Acked-by: Gabriel Somlo --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 4f63597c824d..a93590cdd9e1 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c

[PATCH v15 02/11] fw_cfg: add a public uapi header

by: Michael S. Tsirkin Signed-off-by: Marc-André Lureau --- The related qemu patch making use of it, to be submitted: https://github.com/elmarco/qemu/commit/4884fc9e9c4c4467a371e5a40f3181239e1b70f5 --- MAINTAINERS| 1 + drivers/firmware/qemu_fw_cfg.c | 22 ++ inclu

[PATCH v15 05/11] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[PATCH v15 05/11] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v15 04/11] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_c

[PATCH v15 06/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 inse

[PATCH v15 04/11] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware

[PATCH v15 06/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

ropriately. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index f6f90bef60

[PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

ropriately. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index f6f90bef604c..5e6e5ac71dab 100644 --- a/driver

[PATCH v15 10/11] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 143 - include/uapi/linux/fw_cfg.h| 31 + 2 files changed, 171 insertions(+), 3 deletion

[PATCH v15 10/11] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 143 - include/uapi/linux/fw_cfg.h| 31 + 2 files changed, 171 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qem

[PATCH v15 07/11] fw_cfg: remove inline from fw_cfg_read_blob()

The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v15 07/11] fw_cfg: remove inline from fw_cfg_read_blob()

The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b

[PATCH v15 03/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 42601a3eaed5..6164731a3c35 100644 --- a/drivers/firmware/qemu_fw_cfg.c

[PATCH v15 03/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 42601a3eaed5..6164731a3c35 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware

[PATCH v15 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support

fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lureau (11): crash: export paddr_vmcoreinfo_note() fw_cfg: add a public uapi header fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() fw_cfg: fix sparse warnings with fw_c

[PATCH v15 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support

fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lureau (11): crash: export paddr_vmcoreinfo_note() fw_cfg: add a public uapi header fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() fw_cfg: fix sparse warnings with fw_c

[PATCH v15 09/11] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.

[PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 61 ++ 1 file changed, 50 insertions(+), 11 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 301

[PATCH v15 11/11] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 61 ++ 1 file changed, 50 insertions(+), 11 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 3015e77aebca..94df57e9be66 100644 --- a

[PATCH v15 09/11] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau Reviewed-by: Gabriel Somlo

Re: [PATCH v14 2/9] fw_cfg: add a public uapi header

b 14, 2018 at 03:18:43PM +0100, Marc-André Lureau wrote: >> >> Create a common header file for well-known values and structures to be >> >> shared by the Linux kernel with qemu or other projects. >> >> >> >> Suggested-by: Michael S. Tsi

Re: [PATCH v14 2/9] fw_cfg: add a public uapi header

Hi On Thu, Feb 15, 2018 at 7:20 PM, Michael S. Tsirkin wrote: > On Thu, Feb 15, 2018 at 10:25:27AM +0100, Marc-Andre Lureau wrote: >> Hi >> >> On Wed, Feb 14, 2018 at 9:41 PM, Michael S. Tsirkin wrote: >> > On Wed, Feb 14, 2018 at 03:18:43PM +0100, Marc-André Lurea

Re: [PATCH v14 8/9] fw_cfg: write vmcoreinfo details

Hi On Thu, Feb 15, 2018 at 7:09 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Feb 14, 2018 at 03:18:49PM +0100, Marc-André Lureau wrote: >> If the "etc/vmcoreinfo" fw_cfg file is present and we are not running >> the kdump kernel, write the addr/

Re: [PATCH v14 8/9] fw_cfg: write vmcoreinfo details

Hi On Thu, Feb 15, 2018 at 7:09 PM, Michael S. Tsirkin wrote: > On Wed, Feb 14, 2018 at 03:18:49PM +0100, Marc-André Lureau wrote: >> If the "etc/vmcoreinfo" fw_cfg file is present and we are not running >> the kdump kernel, write the addr/size of the vmcoreinfo ELF note

[PATCH v14 1/9] crash: export paddr_vmcoreinfo_note()

gt; CC: Dave Young <dyo...@redhat.com> CC: Dave Young <dyo...@redhat.com> CC: Hari Bathini <hbath...@linux.vnet.ibm.com> CC: Tony Luck <tony.l...@intel.com> CC: Vivek Goyal <vgo...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Ack

[PATCH v14 1/9] crash: export paddr_vmcoreinfo_note()

: Tony Luck CC: Vivek Goyal Signed-off-by: Marc-André Lureau Acked-by: Gabriel Somlo --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 4f63597c824d..a93590cdd9e1 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c

[PATCH v14 3/9] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

le16 degrades to integer Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 90f467232777..85e693287

[PATCH v14 3/9] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness()

le16 degrades to integer Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 90f467232777..85e693287d87 100644 --- a/drivers/firm

[PATCH v14 6/9] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 inse

[PATCH v14 6/9] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read

Use struct fw_cfg_files to read the directory size, fixing the sparse warnings: drivers/firmware/qemu_fw_cfg.c:485:17: warning: cast to restricted __be32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v14 9/9] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 80 ++ 1 file changed, 66 insertions(+), 14 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 699

[PATCH v14 8/9] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 144 - 1 file changed, 141 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_f

[PATCH v14 8/9] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 144 - 1 file changed, 141 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.

[PATCH v14 9/9] RFC: fw_cfg: do DMA read operation

MA there) Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 80 ++ 1 file changed, 66 insertions(+), 14 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 69939e2529f2..ba9b907a4399 100644 --- a

[PATCH v14 7/9] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.

[PATCH v14 5/9] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[PATCH v14 7/9] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau Reviewed-by: Gabriel Somlo

[PATCH v14 5/9] fw_cfg: fix sparse warning reading FW_CFG_ID

Use a restricted type for reading FW_CFG_ID, fixing sparse warning: drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32 Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v14 0/9] fw_cfg: add DMA operations & etc/vmcoreinfo support

measurements of DMA read speed-ups v12: - fix virt_to_phys(NULL) panic with CONFIG_DEBUG_VIRTUAL=y - do not use DMA read, except for kmalloc() memory we allocated ourself (only fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lur

[PATCH v14 4/9] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_c

[PATCH v14 0/9] fw_cfg: add DMA operations & etc/vmcoreinfo support

measurements of DMA read speed-ups v12: - fix virt_to_phys(NULL) panic with CONFIG_DEBUG_VIRTUAL=y - do not use DMA read, except for kmalloc() memory we allocated ourself (only fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lur

[PATCH v14 4/9] fw_cfg: fix sparse warnings with fw_cfg_file

[usertype] select drivers/firmware/qemu_fw_cfg.c:492:31:got int Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware

[PATCH v14 2/9] fw_cfg: add a public uapi header

Create a common header file for well-known values and structures to be shared by the Linux kernel with qemu or other projects. Suggested-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- The related qemu patc

[PATCH v14 2/9] fw_cfg: add a public uapi header

Create a common header file for well-known values and structures to be shared by the Linux kernel with qemu or other projects. Suggested-by: Michael S. Tsirkin Signed-off-by: Marc-André Lureau --- The related qemu patch making use of it, to be submitted: https://github.com/elmarco/qemu/commit

[PATCH v13 0/4] fw_cfg: add DMA operations & etc/vmcoreinfo support

f DMA read speed-ups v12: - fix virt_to_phys(NULL) panic with CONFIG_DEBUG_VIRTUAL=y - do not use DMA read, except for kmalloc() memory we allocated ourself (only fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lureau (4): cra

[PATCH v13 0/4] fw_cfg: add DMA operations & etc/vmcoreinfo support

f DMA read speed-ups v12: - fix virt_to_phys(NULL) panic with CONFIG_DEBUG_VIRTUAL=y - do not use DMA read, except for kmalloc() memory we allocated ourself (only fw_cfg_register_dir_entries() so far) v11: - add #include in last patch, fixing kbuild .config test Marc-André Lureau (4): cra

[PATCH v13 3/4] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- drivers/firmware/qemu_fw_cfg.c | 157 - 1 file changed, 154 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_f

[PATCH v13 3/4] fw_cfg: write vmcoreinfo details

ol" field check in a loop for eventual changes. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 157 - 1 file changed, 154 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.

  1   2   3   >