Re: [PATCH v11 5/9] drivers: thermal: tsens: Fix bug in sensor enable for msm8960

2021-03-22 Thread Marc Gonzalez
On 19/03/2021 01:52, Ansuel Smith wrote: > Device based on tsens VER_0 contains a hardware bug that results in some > problem with sensor enablement. Sensor id 6-11 can't be enabled > selectively and all of them must be enabled in one step. > > Signed-off-by: Ansuel Smith > --- >

Re: Old platforms: bring out your dead

2021-01-12 Thread Marc Gonzalez
On 11/01/2021 21:25, Song Bao Hua (Barry Song) wrote: > I got confirmation from Qualcomm guys that there is no plan > to maintain prima2 in mainline any more. > Please feel free to remove the code. If you need my help, > Please let me know. Hello Barry, I didn't know that qualcomm worked on

Re: Old platforms: bring out your dead

2021-01-12 Thread Marc Gonzalez
On 11/01/2021 22:50, Arnd Bergmann wrote: > On Mon, Jan 11, 2021 at 6:29 PM Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> Waiting for his take on the matter. >>> >>> I can point out some device-specific drivers that would become >>&g

Re: Old platforms: bring out your dead

2021-01-11 Thread Marc Gonzalez
[ Dropping maintainers of other platforms ] On 08/01/2021 23:55, Arnd Bergmann wrote: > After v5.10 was officially declared an LTS kernel, I had a look around > the Arm platforms that look like they have not seen any patches from > their maintainers or users that are actually running the

Re: [PATCH v2 2/2] spmi: fix some coding style issues at the spmi core

2020-09-29 Thread Marc Gonzalez
On 29/09/2020 08:22, Mauro Carvalho Chehab wrote: > @@ -487,7 +489,7 @@ static void of_spmi_register_devices(struct > spmi_controller *ctrl) > continue; > > sdev->dev.of_node = node; > - sdev->usid = (u8) reg[0]; > + sdev->usid =

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-21 Thread Marc Gonzalez
On 06/07/2020 21:57, Greg Kroah-Hartman wrote: > Given the lack of testing of the patch, it doesn't seem wise to add > this, right? You're probably not wrong :) > Please get some testing, and some more users, and I'll be glad to > consider it. "Users" == files modified to use the new helper?

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-06 Thread Marc Gonzalez
Hello Greg, Would you agree to take this series? Regards. On 18/06/2020 13:38, Marc Gonzalez wrote: > Hello everyone, > > In my opinion, the small and simple devm_add() helper > (and its cousin, devm_vadd) can help make devm code > slightly easier to write and maintain. > &

Re: Scanning for TV channels over DVB-T and DVB-T2

2020-06-19 Thread Marc Gonzalez
On 10/06/2020 17:22, Marc Gonzalez wrote: > FTR, on IRC, Brad pointed out this patch of his: > https://patchwork.kernel.org/patch/10744999/ I suggest the following patch on top of Brad's patch: Author: Marc Gonzalez Date: Fri Jun 19 22:09:26 2020 +0200 si2168: wait for carrie

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-18 Thread Marc Gonzalez
Hello everyone, In my opinion, the small and simple devm_add() helper (and its cousin, devm_vadd) can help make devm code slightly easier to write and maintain. Would anyone care to agree or disagree? :-) Regards. On 10/03/2020 11:11, Marc Gonzalez wrote: > Differences from v4 to v5 >

Re: [RFC 4/4] media: dvb_frontend: disable zigzag mode if not possible

2020-06-18 Thread Marc Gonzalez
On 17/06/2020 20:52, Mauro Carvalho Chehab wrote: > For the zigzag to work, the core needs to have a frequency > shift. Without that, the zigzag code will just try re-tuning > several times at the very same frequency, with seems wrong. s/with/which Suggest: "the core requires a frequency shift

Re: [RFC 3/4] media: dvb_frontend: move algo-specific settings to a function

2020-06-18 Thread Marc Gonzalez
2) fe->ops.info.frequency_stepsize_hz 3) fe->ops.tuner_ops.info.frequency_step_hz > - default: > - /* > - * FIXME: This sounds wrong! if freqency_stepsize is > - * defined by the frontend, why not use it??? > - */ > - fepriv->min_delay = HZ / 20; > - fepriv->step_size = 0; /* no zigzag */ > - fepriv->max_drift = 0; > - break; > - } > - } > - if (dvb_override_tune_delay > 0) > - fepriv->min_delay = (dvb_override_tune_delay * HZ) / 1000; > + prepare_tuning_algo_parameters(fe); LGTM Reviewed-by: Marc Gonzalez

Re: si2168: different default that windows driver

2020-06-17 Thread Marc Gonzalez
Hello Brad, I found this patch you wrote: https://github.com/b-rad-NDi/Ubuntu-media-tree-kernel-builder/blob/master/patches/mainline-extra/tip/10.random.patches/0004-si2168-different-default-that-windows-driver.patch Subject: [PATCH 4/5] si2168: different default that windows driver Unsure of

[RFC PATCH][DO NOT COMMIT] media: dvb_frontend: Support concurrent DVB-T/DVB-T2 scan

2020-06-11 Thread Marc Gonzalez
Some demodulators (e.g. si2168) are able to scan for DVB-T and DVB-T2 signals concurrently. Use SYS_DVBT_AUTO for this purpose. --- This is a Request For Comments from media maintainers and users :-) One issue: suppose DVB Project publishes DVB-T3 in a few years. Today's demods might handle T/T2,

Re: Scanning for TV channels over DVB-T and DVB-T2

2020-06-10 Thread Marc Gonzalez
On 09/06/2020 16:31, Marc Gonzalez wrote: > On 08/06/2020 17:30, Marc Gonzalez wrote: > >> Suppose we know that several channels are transmitted on a given frequency >> by terrestrial antenna. However, we don't know if the signal is "encoded" >> (not sure this

Re: Scanning for TV channels over DVB-T and DVB-T2

2020-06-09 Thread Marc Gonzalez
On 08/06/2020 17:30, Marc Gonzalez wrote: > Suppose we know that several channels are transmitted on a given frequency > by terrestrial antenna. However, we don't know if the signal is "encoded" > (not sure this is the right term) in DVB-T or DVB-T2 modulation. >

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-04 Thread Marc Gonzalez
Looks like this series has fallen through the cracks :( Greg, you would be taking the drivers/base/devres.c changes? As mentioned in patch 2, "This patch needs testing on a platform with many clocks." (I've only tested using a trivial kernel module) On 10/03/2020 11:11, Marc Gonz

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-09-30 Thread Marc Gonzalez
On 30/09/2019 06:36, Walter Wu wrote: > bool check_memory_region(unsigned long addr, size_t size, bool write, > unsigned long ret_ip) > { > + if (long(size) < 0) { > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > +

Re: [PATCH v2 3/3] phy: qcom-qmp: Add SM8150 QMP UFS PHY support

2019-09-18 Thread Marc Gonzalez
On 06/09/2019 07:10, Vinod Koul wrote: > SM8150 UFS PHY is v4 of QMP phy. Add support for V4 QMP phy register > defines and support for SM8150 QMP UFS PHY. > > Signed-off-by: Vinod Koul > Reviewed-by: Bjorn Andersson > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 125

Re: [PATCH v2 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure

2019-09-18 Thread Marc Gonzalez
On 17/09/2019 19:21, Saiyam Doshi wrote: > The debug message after platform_get_irq() failure is redundant > because platform_get_irq() already prints an error. Thus remove it. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Signed-off-by: Saiyam Doshi > --- > Changes in

Re: [PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

2019-09-04 Thread Marc Gonzalez
On 04/09/2019 07:39, Bjorn Andersson wrote: > On Mon 02 Sep 14:19 PDT 2019, Brian Masney wrote: > >> +DEFINE_QNODE(mas_ampss_m0, MSM8974_BIMC_MAS_AMPSS_M0, 8, 0, -1); >> +DEFINE_QNODE(mas_ampss_m1, MSM8974_BIMC_MAS_AMPSS_M1, 8, 0, -1); >> +DEFINE_QNODE(mas_mss_proc, MSM8974_BIMC_MAS_MSS_PROC, 8,

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Marc Gonzalez
On 21/08/2019 17:06, Mike Rapoport wrote: > Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem > cache for page table allocations on several architectures that do not use > PAGE_SIZE tables for one or more levels of the page table hierarchy. > > Most architectures do not

Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz

2019-08-20 Thread Marc Gonzalez
On 20/08/2019 05:08, Andrey Smirnov wrote: > Fiber-optic module attached to the bus is only rated to work at > 100kHz, so drop the bus frequncy to accomodate that. s/100kHz/100 kHz s/frequncy/frequency s/accomodate/accommodate Regards.

Re: [PATCH] phy: qcom-qmp: Correct ready status, again

2019-08-20 Thread Marc Gonzalez
> PHY and check for the appropriate ready state. > > Cc: sta...@vger.kernel.org > Cc: Vivek Gautam > Cc: Evan Green > Cc: Niklas Cassel > Reported-by: Marc Gonzalez > Fixes: 885bd765963b ("phy: qcom-qmp: Correct READY_STATUS poll break > condition")

Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}

2019-08-20 Thread Marc Gonzalez
On 15/07/2019 17:34, Marc Gonzalez wrote: > Provide devm variants for automatic resource release on device removal. > probe() error-handling is simpler, and remove is no longer required. > > Signed-off-by: Marc Gonzalez > --- > Documentation/driver-model/devres.rst | 3

Re: [PATCH v4] media: si2168: Refactor command setup code

2019-08-19 Thread Marc Gonzalez
On 15/07/2019 11:50, Marc Gonzalez wrote: > Use cmd_init() to fill a struct si2168_cmd command. > > Signed-off-by: Marc Gonzalez > --- > Changes from v1: > - Use a real function to populate struct si2168_cmd *cmd, and a trivial > macro wrapping it (macro because sizeo

Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-08-07 Thread Marc Gonzalez
On 30/07/2019 23:56, Bjorn Helgaas wrote: >> diff --git a/drivers/pci/controller/pcie-tango.c >> b/drivers/pci/controller/pcie-tango.c >> index 21a208da3f59..b87aa9041480 100644 >> --- a/drivers/pci/controller/pcie-tango.c >> +++ b/drivers/pci/controller/pcie-tango.c >> @@ -273,10 +273,8 @@

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-08-02 Thread Marc Gonzalez
On 23/07/2019 12:31, Marc Gonzalez wrote: > On 19/07/2019 17:50, Marc Gonzalez wrote: > >> On 13/06/2019 11:10, Marc Gonzalez wrote: >> >>> Here are my observations for a 8998 board: >>> >>> 1) If I apply only the readl_poll_timeout() fix (not the m

Re: [PATCH] arm64: dts: qcom: msm8998: Node ordering, address cleanups

2019-07-24 Thread Marc Gonzalez
> Signed-off-by: Jeffrey Hugo > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 254 +- > 1 file changed, 127 insertions(+), 127 deletions(-) LGTM. Reviewed-by: Marc Gonzalez Rob, Mark: when there are multiple reg properties, why is the convention to use the

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-07-23 Thread Marc Gonzalez
On 19/07/2019 17:50, Marc Gonzalez wrote: > On 13/06/2019 11:10, Marc Gonzalez wrote: > >> Here are my observations for a 8998 board: >> >> 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready >> fixup) >> qcom_pcie_prob

Re: [PATCH] firmware: qcom_scm: fix error for incompatible pointer

2019-07-22 Thread Marc Gonzalez
Adding people who have worked on drivers/firmware/qcom_scm.c or DMA On 19/07/2019 15:43, Minwoo Im wrote: > The following error can happen when trying to build it: > > ``` > drivers/firmware/qcom_scm.c: In function ‘qcom_scm_assign_mem’: > drivers/firmware/qcom_scm.c:460:47: error: passing

Re: [PATCH v3] media: dvb: Provide 4 devm variants

2019-07-22 Thread Marc Gonzalez
On 21/07/2019 17:02, Ezequiel Garcia wrote: > On Thu, 2019-07-18 at 15:03 +0200, Marc Gonzalez wrote: > >> Provide devm variants for automatic resource release on device removal. >> Makes error-handling in probe() simpler, thus less error-prone. >> Once all resource

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-07-19 Thread Marc Gonzalez
On 13/06/2019 11:10, Marc Gonzalez wrote: > Here are my observations for a 8998 board: > > 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready fixup) > qcom_pcie_probe() fails with a timeout in phy_init. > => this is in line with your regression analysis.

[PATCH v3] media: dvb: Provide 4 devm variants

2019-07-18 Thread Marc Gonzalez
Provide devm variants for automatic resource release on device removal. Makes error-handling in probe() simpler, thus less error-prone. Once all resources are devmanaged, remove() is no longer needed. Signed-off-by: Marc Gonzalez --- Changes from v2: x Handle dvb_register_adapter() return code

Re: [PATCH 2/3] media: Add lane checks for Cadence CSI2TX

2019-07-18 Thread Marc Gonzalez
On 18/07/2019 13:15, Jan Kotas wrote: > This patch adds line checks for CSI2TX, to prevent > clock lane being used as a data lane. "line checks" or "lane checks? ^_^ NB: commit messages may be up to 72-character-wide ;-) (No need to line-wrap at 50) Regards.

Re: [PATCH v2] media: dvb: Provide 4 devm variants

2019-07-18 Thread Marc Gonzalez
On 16/07/2019 10:56, Marc Gonzalez wrote: > +int devm_dvb_register_adapter(struct device *dev, struct dvb_adapter *adap, > + const char *name, struct module *module, short *adapter_nums) > +{ > + int rc = dvb_register_adapter(adap, name, module, dev, adapter_nums); &g

[PATCH v2] media: dvb: Provide 4 devm variants

2019-07-16 Thread Marc Gonzalez
Provide devm variants for automatic resource release on device removal. Makes error-handling in probe() much simpler, thus less error-prone. And once all resources are devmanaged, remove() is no longer needed. Signed-off-by: Marc Gonzalez --- Changes from v1: x Simplify devm_dvb_register_adapter

Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}

2019-07-16 Thread Marc Gonzalez
On 16/07/2019 02:25, Guenter Roeck wrote: > On 7/15/19 8:34 AM, Marc Gonzalez wrote: > >> Provide devm variants for automatic resource release on device removal. >> probe() error-handling is simpler, and remove is no longer required. >> >> Signed-off-by: Marc Gon

[PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}

2019-07-15 Thread Marc Gonzalez
Provide devm variants for automatic resource release on device removal. probe() error-handling is simpler, and remove is no longer required. Signed-off-by: Marc Gonzalez --- Documentation/driver-model/devres.rst | 3 +++ drivers/clk/clk.c | 24

DVB abstractions: filters and feeds

2019-07-15 Thread Marc Gonzalez
Hello, I'm having a hard time understanding two abstractions in the DVB framework, namely filters and feeds (P.S. I now see there are dvb_demux_filter's and dmxdev_filter's, so it's really 3 abstractions that I'm not grasping.) Specifically, struct dvb_demux { ... int filternum;

[PATCH v4] media: si2168: Refactor command setup code

2019-07-15 Thread Marc Gonzalez
Use cmd_init() to fill a struct si2168_cmd command. Signed-off-by: Marc Gonzalez --- Changes from v1: - Use a real function to populate struct si2168_cmd *cmd, and a trivial macro wrapping it (macro because sizeof). Changes from v2: - Fix header mess - Add Jonathan's tag Changes from v3: - Drop

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
On 12/07/2019 19:45, Mauro Carvalho Chehab wrote: > Brad Love escreveu: > >> On 04/07/2019 05.33, Marc Gonzalez wrote: >> >>> +#define CMD_SETUP(cmd, args, rlen) \ >>> + cmd_setup(cmd, args, sizeof(args) - 1, rlen) >>> + >> >> This i

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
On 12/07/2019 17:47, Brad Love wrote: > On 04/07/2019 05.33, Marc Gonzalez wrote: > >> Refactor the command setup code, and let the compiler determine >> the size of each command. >> >> Reviewed-by: Jonathan Neuschäfer >> Signed-off-by: Marc Gonzalez >&g

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
+ Sean On 12/07/2019 10:43, Uwe Kleine-König wrote: > On Thu, Jul 04, 2019 at 12:33:22PM +0200, Marc Gonzalez wrote: > >> Refactor the command setup code, and let the compiler determine >> the size of each command. >> >> Reviewed-by: Jonathan Neuschäfer &

[PATCH v3] media: si2168: Refactor command setup code

2019-07-04 Thread Marc Gonzalez
Refactor the command setup code, and let the compiler determine the size of each command. Reviewed-by: Jonathan Neuschäfer Signed-off-by: Marc Gonzalez --- Changes from v1: - Use a real function to populate struct si2168_cmd *cmd, and a trivial macro wrapping it (macro because sizeof). Changes

Re: [PATCH v2] media: si2168: Refactor command setup code

2019-07-04 Thread Marc Gonzalez
On 04/07/2019 12:14, Jonathan Neuschäfer wrote: > On Thu, Jul 04, 2019 at 11:58:45AM +0200, Marc Gonzalez wrote: >> >From ceb5f687f3f7dab2fb9d5b34408d9cf83a0be228 Mon Sep 17 00:00:00 2001 >> From: Marc Gonzalez >> Date: Mon, 1 Jul 2019 12:58:31 +0200 >> Sub

[PATCH v2] media: si2168: Refactor command setup code

2019-07-04 Thread Marc Gonzalez
>From ceb5f687f3f7dab2fb9d5b34408d9cf83a0be228 Mon Sep 17 00:00:00 2001 From: Marc Gonzalez Date: Mon, 1 Jul 2019 12:58:31 +0200 Subject: [PATCH v2] media: si2168: Refactor command setup code Refactor the command setup code, and let the compiler determine the size of each command. Signed-

Re: [PATCH v2 03/10] ARM: dts: meson6: update with SPDX Licence identifier

2019-07-03 Thread Marc Gonzalez
On 27/05/2019 15:38, Neil Armstrong wrote: > While the text specifies "of the GPL or the X11 license" the actual > license text matches the MIT license as specified at [0] > > [0] https://spdx.org/licenses/MIT.html > > Signed-off-by: Neil Armstrong > --- > arch/arm/boot/dts/meson6.dtsi | 44

Re: [PATCH v1] media: si2168: Refactor command setup code

2019-07-03 Thread Marc Gonzalez
On 03/07/2019 14:47, Marc Gonzalez wrote: > Come to think of it, I'm really not a fan of "large" macro functions. > I'll outline a different option in v2. My idea is to use a trivial helper function to assign the 3 struct fields, and then a trivial macro to invoke the help

Re: [PATCH v1] media: si2168: Refactor command setup code

2019-07-03 Thread Marc Gonzalez
On 02/07/2019 11:51, Jonathan Neuschäfer wrote: > On Mon, Jul 01, 2019 at 01:44:09PM +0200, Marc Gonzalez wrote: > >> By refactoring the command setup code, we can let the compiler >> determine the size of each command. > > I like the idea, it definitely saves some code.

Re: [PATCH v1] media: si2168: Refactor command setup code

2019-07-02 Thread Marc Gonzalez
On 01/07/2019 13:44, Marc Gonzalez wrote: > By refactoring the command setup code, we can let the compiler > determine the size of each command. > > Signed-off-by: Marc Gonzalez > --- > drivers/media/dvb-frontends/si2168.c | 142 --- > 1 file c

[PATCH v1] media: si2168: Refactor command setup code

2019-07-01 Thread Marc Gonzalez
By refactoring the command setup code, we can let the compiler determine the size of each command. Signed-off-by: Marc Gonzalez --- drivers/media/dvb-frontends/si2168.c | 142 --- 1 file changed, 41 insertions(+), 101 deletions(-) diff --git a/drivers/media/dvb

Re: [PATCH 2/2] dma-mapping: remove dma_max_pfn

2019-06-25 Thread Marc Gonzalez
Hello Christoph, There are some typos in the commit message that make it harder (for me) to parse. On 25/06/2019 11:20, Christoph Hellwig wrote: > These days the DMA mapping code must bounce buffer for any not supported Add comma after "These days" ? s/must bounce buffer/must bounce buffers/ ?

Re: [PATCH v1] phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay

2019-06-24 Thread Marc Gonzalez
On 20/06/2019 08:25, Kishon Vijay Abraham I wrote: > On 14/06/19 6:08 PM, Marc Gonzalez wrote: > >> The issue is usleep_range() being misused ^_^ >> >> Although usleep_range() takes unsigned longs as parameters, it is >> not appropriate over the entire 0-

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-21 Thread Marc Gonzalez
On 21/06/2019 01:43, Finn Thain wrote: > On Thu, 20 Jun 2019, Marc Gonzalez wrote: > >> How likely is it that distro kernels would *not* enable CHR_DEV_SG? >> (Distros tend to enable everything, and then some.) > > How likely is it that embedded developers would

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-20 Thread Marc Gonzalez
On 19/06/2019 16:34, Douglas Gilbert wrote: > On 2019-06-19 5:42 a.m., Marc Gonzalez wrote: > >> I assume sg3_utils requires CHR_DEV_SG. Is it the case? >> >> If so, we would just need to enable SCSI_PROC_FS when CHR_DEV_SG is enabled. >> >> diff --git a

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-06-19 Thread Marc Gonzalez
On 13/06/2019 11:10, Marc Gonzalez wrote: > Here are my observations for a 8998 board: > > 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready fixup) > qcom_pcie_probe() fails with a timeout in phy_init. > => this is in line with your regression analysis.

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-19 Thread Marc Gonzalez
On 18/06/2019 17:31, Douglas Gilbert wrote: > On 2019-06-18 3:29 a.m., Marc Gonzalez wrote: > >> Please note that I am _in no way_ suggesting that we remove any code. >> >> I just think it might be time to stop forcing CONFIG_SCSI_PROC_FS into >> every c

Re: [PATCH v2] ARM: dts: qcom: ipq4019: fix high resolution timer

2019-06-18 Thread Marc Gonzalez
On 15/06/2019 18:29, Christian Lamparter wrote: > From: Abhishek Sahu > > Isn't there a spurious newline there? > Cherry-picked from CAF QSDK repo with Change-Id > I7c00b3c74d97c2a30ac9f05e18b511a0550fd459. Do we really care about the downstream change-id? Is this publicly available

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-18 Thread Marc Gonzalez
On 18/06/2019 03:08, Finn Thain wrote: > On Mon, 17 Jun 2019, Douglas Gilbert wrote: > >> On 2019-06-17 5:11 p.m., Bart Van Assche wrote: >> >>> On 6/12/19 6:59 AM, Marc Gonzalez wrote: >>> >>>> According to the option's help message, SCSI_PROC_

Re: [PATCH v1] phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay

2019-06-14 Thread Marc Gonzalez
+ Doug (who is familiar with usleep_range quirks) On 14/06/2019 11:50, Vivek Gautam wrote: > On 6/13/2019 5:02 PM, Marc Gonzalez wrote: > >> readl_poll_timeout() calls usleep_range() to sleep between reads. >> usleep_range() doesn't work efficiently for tiny values. >&

Re: [PATCH v1] iopoll: Tweak readx_poll_timeout sleep range

2019-06-13 Thread Marc Gonzalez
On 13/06/2019 18:11, Doug Anderson wrote: > On Thu, Jun 13, 2019 at 9:04 AM Marc Gonzalez wrote: > >> Hmmm, I expect the typical use-case to be: >> "HW manual states operation X completes in 100 µs. >> Let's call usleep_range(100, foo); before hitting

Re: [PATCH v1] iopoll: Tweak readx_poll_timeout sleep range

2019-06-13 Thread Marc Gonzalez
On 13/06/2019 14:42, Arnd Bergmann wrote: > On Thu, Jun 13, 2019 at 2:16 PM Marc Gonzalez wrote: > >> Chopping max delay in 4 seems excessive. Let's just cut it in half. >> >> Signed-off-by: Marc Gonzalez >> --- >> When max_us=100, old_min was 26 us; new_mi

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-06-13 Thread Marc Gonzalez
On 12/06/2019 19:25, Bjorn Andersson wrote: > On Wed 12 Jun 09:24 PDT 2019, Marc Gonzalez wrote: > >> On 05/06/2019 01:24, Bjorn Andersson wrote: >> >>> After issuing a PHY_START request to the QMP, the hardware documentation >>> states that the software

Re: msm8996: qcom-qmp: apq8096-db820c fails to boot, reset back to fastboot and locks up

2019-06-13 Thread Marc Gonzalez
On 10/06/2019 15:44, Paolo Pisati wrote: > From time to time, my apq8096-db820c fails to boot to userspace, reset back to > fastboot and locks up: to easily reproduce the issue, i'm boot looping using a > cron job with a 1 min reboot entry on the board while leaving a "while 1; do > fastboot boot

[PATCH v1] phy: qcom-qmp: Drop useless msm8998_pciephy_cfg setting

2019-06-13 Thread Marc Gonzalez
'mask_com_pcs_ready' is only useful if 'has_phy_com_ctrl' is true. Since msm8998_pciephy_cfg.has_phy_com_ctrl is false, let's drop msm8998_pciephy_cfg.mask_com_pcs_ready altogether. Signed-off-by: Marc Gonzalez --- This was a relic from copying msm8996_pciephy_cfg --- drivers/phy/qualcomm/phy

[PATCH v1] phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay

2019-06-13 Thread Marc Gonzalez
readl_poll_timeout() calls usleep_range() to sleep between reads. usleep_range() doesn't work efficiently for tiny values. Raise the polling delay in qcom_qmp_phy_enable() to bring it in line with the delay in qcom_qmp_phy_com_init(). Signed-off-by: Marc Gonzalez --- Vivek, do you remember why

[PATCH v1] iopoll: Tweak readx_poll_timeout sleep range

2019-06-13 Thread Marc Gonzalez
Chopping max delay in 4 seems excessive. Let's just cut it in half. Signed-off-by: Marc Gonzalez --- When max_us=100, old_min was 26 us; new_min would be 50 us Was there a good reason for the 1/4th? Is new_min=0 a problem? (for max=1) --- include/linux/iopoll.h | 2 +- 1 file changed, 1

Re: [PATCH] msm: no need to check return value of debugfs_create functions

2019-06-13 Thread Marc Gonzalez
On 13/06/2019 14:24, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Naive question: if callers are supposed to ignore the return

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-06-12 Thread Marc Gonzalez
8996 and 8998 does not specify the mask_pcs_ready > register, which means that the code checks a bit that's always 0. So the > patch also fixes these, in order to not regress these targets. > > Cc: sta...@vger.kernel.org > Cc: Evan Green > Cc: Marc Gonzalez > Cc:

[PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-12 Thread Marc Gonzalez
According to the option's help message, SCSI_PROC_FS has been superseded for ~15 years. Don't select it by default anymore. Signed-off-by: Marc Gonzalez --- drivers/scsi/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 73bce9b6d037

Re: [PATCH] arm64: dts: sdm845: Add iommus property to qup1

2019-06-06 Thread Marc Gonzalez
On 06/06/2019 13:17, Vivek Gautam wrote: > <_smmu 0x6c0 0x3> // for both 0x6c0 (TZ) and 0x6c3 (HLOS) Another possibility is to list both: <_smmu 0x6c0 0x0> <_smmu 0x6c3 0x0> which leaves 0x6c1 and 0x6c2 out of the picture, and makes 0x6c3 appear explicitly (for anyone

Race between MMIO writes and level IRQs

2019-06-06 Thread Marc Gonzalez
Hello everyone, There's something about interrupts I have never quite understood, which I'd like to clear up once and for all. What I'm about to write will probably sound trivial to anyone's who's already figured it out, but I need to walk through it. Consider a device, living on some peripheral

Re: [PATCH v4 2/2] arm64: dts: qcom: Add Lenovo Miix 630

2019-06-06 Thread Marc Gonzalez
On 06/06/2019 10:13, Lee Jones wrote: > On Thu, 06 Jun 2019, Bjorn Andersson wrote: > >> On Wed 05 Jun 22:50 PDT 2019, Lee Jones wrote: >> >>> On Tue, 23 Apr 2019, Jeffrey Hugo wrote: >>> This adds the initial DT for the Lenovo Miix 630 laptop. Supported functionality includes USB

Re: [PATCH 1/3 v2] dt-bindings: power: reset: qcom: Add qcom,pm8998-pon compatability line

2019-06-04 Thread Marc Gonzalez
On 04/06/2019 00:23, John Stultz wrote: > Subject: [PATCH 1/3 v2] dt-bindings: power: reset: qcom: Add qcom,pm8998-pon > compatability line s/compatability/compatibility Regards.

Re: [PATCH 1/1] drm/panel: truly: Add additional delay after pulling down reset gpio

2019-05-28 Thread Marc Gonzalez
On 27/05/2019 12:26, Vivek Gautam wrote: > MTP SDM845 panel seems to need additional delay to bring panel > to a workable state. Running modetest without this change displays > blurry artifacts. > > Signed-off-by: Vivek Gautam > --- > drivers/gpu/drm/panel/panel-truly-nt35597.c | 1 + > 1 file

Re: [PATCH] PCI: qcom: Ensure that PERST is asserted for at least 100 ms

2019-05-24 Thread Marc Gonzalez
On 23/05/2019 21:44, Niklas Cassel wrote: > Currently, there is only a 1 ms sleep after asserting PERST. > > Reading the datasheets for different endpoints, some require PERST to be > asserted for 10 ms in order for the endpoint to perform a reset, others > require it to be asserted for 50 ms. >

Re: [PATCH] dt: bindings: mtd: replace references to nand.txt with nand-controller.yaml

2019-05-21 Thread Marc Gonzalez
On 21/05/2019 21:27, Kamal Dasu wrote: nand-controller.yaml replaced nand.txt however the references to it were not updated. This change updates these references wherever it appears in bindings documentation. Fixes: 212e49693592 ("dt-bindings: mtd: Add YAML schemas for the generic NAND

Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-05-21 Thread Marc Gonzalez
On 21/05/2019 14:03, Marc Gonzalez wrote: > the system starts to boot, hangs a few seconds, then silently reboots Using extremely high-tech debugging tools (i.e. spraying printk left and right) I traced this one down to: psci_cpu_suspend_enter: 435 psci_cpu_suspend: 171 psci_cpu_susp

Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-05-21 Thread Marc Gonzalez
On 21/05/2019 11:35, Amit Kucheria wrote: > Add device bindings for cpuidle states for cpu devices. > > Cc: Marc Gonzalez > Signed-off-by: Amit Kucheria > Acked-by: Daniel Lezcano > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++ > 1 fil

Re: [PATCH] clk: qcom: gdsc: WARN when failing to toggle

2019-05-20 Thread Marc Gonzalez
WARN(ret, "%s status stuck at 'o%s'", sc->pd.name, status ? "ff" : "n"); > + return ret; In my opinion, the minor obfuscation of "o%s", foo ? "ff" : "n" does not justify the tiny space savings. I'd spell it out: "%s", foo ? "off" : "on" In any event: Reviewed-by: Marc Gonzalez Regards.

Re: [GIT PULL 1/4] ARM: SoC platform updates

2019-05-16 Thread Marc Gonzalez
On 16/05/2019 17:33, Linus Torvalds wrote: > On Wed, May 15, 2019 at 11:43 PM Olof Johansson wrote: >> >> SoC updates, mostly refactorings and cleanups of old legacy platforms. >> Major themes this release: > > Hmm. This brings in a new warning: > > drivers/clocksource/timer-ixp4xx.c:78:20:

[PATCH] Opt out of scripts/get_maintainer.pl

2019-05-15 Thread Marc Gonzalez
A few months ago, I submitted a trivial arm64 defconfig update. get_maintainer.pl now outputs my address for every defconfig tweak. Add me to .get_maintainer.ignore to opt out of these notifications. Signed-off-by: Marc Gonzalez --- .get_maintainer.ignore | 1 + 1 file changed, 1 insertion

Re: [PATCHv1 7/8] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-05-10 Thread Marc Gonzalez
On 10/05/2019 16:12, Amit Kucheria wrote: On Fri, May 10, 2019 at 6:45 PM Marc Gonzalez wrote: On 10/05/2019 13:29, Amit Kucheria wrote: Add device bindings for cpuidle states for cpu devices. Cc: Marc Gonzalez Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 32

Re: [PATCHv1 7/8] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-05-10 Thread Marc Gonzalez
On 10/05/2019 13:29, Amit Kucheria wrote: > Add device bindings for cpuidle states for cpu devices. > > Cc: Marc Gonzalez > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 32 +++ > 1 file changed, 32 insertions(+) &

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-05-02 Thread Marc Gonzalez
On 30/04/2019 16:06, Lorenzo Pieralisi wrote: > On Tue, Mar 12, 2019 at 06:34:55PM +0100, Marc Gonzalez wrote: > >> On 12/03/2019 18:18, Marc Gonzalez wrote: >> >>> On 12/03/2019 13:42, Stanimir Varbanov wrote: >>> >>>> I wonder, in

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-25 Thread Marc Gonzalez
breaking the user-space ABI, since THERMAL_NAME_LENGTH is defined in include/uapi/linux/thermal.h Anyway, for msm8998 patches, you have my Tested-by: Marc Gonzalez Regards.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-25 Thread Marc Gonzalez
On 25/04/2019 08:31, Amit Kucheria wrote: > Marc, can you please test these 3 patches on top of my original series? Roger that. # dmesg | grep thermal /* NOTHING */ # for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-25 Thread Marc Gonzalez
On 25/04/2019 08:31, Amit Kucheria wrote: > Andy, patches 1 and 2 fix problems that already exist upstream. They > were not introduced by my series. On IRC, you wrote: "can you send me the same output against mainline (or linux-next) w/o my patches applied?" $ git show 58ad5ab73152 commit

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-24 Thread Marc Gonzalez
On 23/04/2019 15:10, Marc Gonzalez wrote: > Sure. I can give you a Tested-by once everything works on the MEDIABOX I have. > > You mention the 4 thermal_zone*/temp failures. > > What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures? I have synced up with tod

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-23 Thread Marc Gonzalez
On 23/04/2019 14:56, Amit Kucheria wrote: > On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez wrote: > >> On 02/04/2019 20:46, Amit Kucheria wrote: >> >>> On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: >>> >>>> On 29/03/2019 11:12,

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-23 Thread Marc Gonzalez
On 02/04/2019 20:46, Amit Kucheria wrote: > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: >> >> On 29/03/2019 11:12, Amit Kucheria wrote: >> >>> Changes since v1: >>> - Devices that are not associated with cooling-maps use the 'hot' type >>&

Re: linux-next: manual merge of the phy-next tree with the qcom tree

2019-04-23 Thread Marc Gonzalez
On 22/04/2019 13:47, Kishon Vijay Abraham I wrote: > On 19/04/19 10:28 AM, Andy Gross wrote: > >> On Thu, Apr 18, 2019 at 09:35:44AM +0200, Marc Gonzalez wrote: >>> >>> It is not clear to me what I could/should have done differently to avoid >>> the conf

Re: Issues with i.MX SPI DMA transfers

2019-04-18 Thread Marc Gonzalez
[ Trimming recipients list ] On 03/04/2019 17:51, Igor Plyatov wrote: > 2) I want to improve description and replace magic numbers by constants > in Device Tree for SDMA. I mean strings like "dmas = < 11 7 1>, > < 12 7 2>;"? > > So, finally Device Tree will have strings like > > dmas = <

Re: fs/proc: Crash observed in next_tgid (fs/proc/base.c)

2019-04-18 Thread Marc Gonzalez
NB: it is preferable to avoid top-posting here. On 17/04/2019 18:58, Jitendra Sharma wrote: > Kernel version: 4.14.83 NB2: 4.14.83 is obsolete, as it stands 2255 patches behind the tip of linux-4.14.y (though only 4 patches in fs/proc). NB3: 4.14 is 108499(!!) patches behind v5.1-rc5 (latest

Re: linux-next: manual merge of the phy-next tree with the qcom tree

2019-04-18 Thread Marc Gonzalez
On 18/04/2019 07:29, Stephen Rothwell wrote: > Today's linux-next merge of the phy-next tree got a conflict in: > > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > > between commit: > > 369b89366a3d ("dt-bindings: phy-qcom-qmp: Tweak qcom,msm8998-qmp-ufs-phy") > > from the qcom

Re: fs/proc: Crash observed in next_tgid (fs/proc/base.c)

2019-04-17 Thread Marc Gonzalez
On 15/04/2019 14:58, Jitendra Sharma wrote: > We are observing one kernel crash in next_tgid function through > getdents64 path. Call stack is as shown below: It might help if you specify the exact kernel version you are discussing, as in which tag or commit hash you are running. Also, what

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-17 Thread Marc Gonzalez
On 16/04/2019 22:25, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architecture, where a compat

Re: [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-17 Thread Marc Gonzalez
On 16/04/2019 11:59, Srinivas Kandagatla wrote: > Many nvmem providers are not very keen on having default sysfs > nvmem entry, as most of the usecases for them are inside kernel > itself. And in some cases read/writes to some areas in nvmem are > restricted and trapped at secure monitor level,

[PATCH] ASoC: wcd9335: Fix missing regmap requirement

2019-04-10 Thread Marc Gonzalez
wcd9335.c: undefined reference to 'devm_regmap_add_irq_chip' Signed-off-by: Marc Gonzalez --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 419142111b6d..33778dc99108 100644 --- a/sound/soc/codecs/Kconfig

Re: [PATCH 23/23] watchdog: tangox_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Marc Gonzalez
On 10/04/2019 15:37, Guenter Roeck wrote: > On 4/10/19 6:04 AM, Marc Gonzalez wrote: > >> On 09/04/2019 19:24, Guenter Roeck wrote: >> >>> Use device managed functions to simplify error handling, reduce >>> source code size, improve readability, and redu

  1   2   3   4   5   6   >