Re: [PATCH 06/10] KVM: x86: MMU: Consolidate WARN_ON/BUG_ON checks for reverse-mapped sptes

2015-11-13 Thread Marcelo Tosatti
On Thu, Nov 12, 2015 at 08:53:43PM +0900, Takuya Yoshikawa wrote: > At some call sites of rmap_get_first() and rmap_get_next(), BUG_ON is > placed right after the call to detect unrelated sptes which must not be > found in the reverse-mapping list. > > Move this check in rmap_get_first/next() so

Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk()

2015-11-13 Thread Marcelo Tosatti
On Thu, Nov 12, 2015 at 08:52:45PM +0900, Takuya Yoshikawa wrote: > kvm_mmu_mark_parents_unsync() alone uses pte_list_walk(), witch does > nearly the same as the for_each_rmap_spte macro. The only difference > is that is_shadow_present_pte() checks cannot be placed there because >

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 02:04:38PM -0500, Luiz Capitulino wrote: > On Fri, 13 Nov 2015 15:27:40 -0200 > Marcelo Tosatti wrote: > > > On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > > > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: >

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 03:27:40PM -0200, Marcelo Tosatti wrote: > On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > > + * * one tcrid entry can be in different locations > > &g

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

[PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
Attached is an early version of the ioctl based CAT interface we have been working on. NOTE: it does not compile, there is no locking, but should be sufficient for interested people to comment. diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index db3622f..293726b 100644 ---

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

[PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
Attached is an early version of the ioctl based CAT interface we have been working on. NOTE: it does not compile, there is no locking, but should be sufficient for interested people to comment. diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index db3622f..293726b 100644 ---

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 03:27:40PM -0200, Marcelo Tosatti wrote: > On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > > + * * one tcrid entry can be in different locations > > &g

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > On Fri, Nov 13, 2015 at 02:39:33PM -0200, Marcelo Tosatti wrote: > > + * * one tcrid entry can be in different locations > > + * in different sockets. > > NAK on that without cpuset i

Re: [PATCH 06/10] KVM: x86: MMU: Consolidate WARN_ON/BUG_ON checks for reverse-mapped sptes

2015-11-13 Thread Marcelo Tosatti
On Thu, Nov 12, 2015 at 08:53:43PM +0900, Takuya Yoshikawa wrote: > At some call sites of rmap_get_first() and rmap_get_next(), BUG_ON is > placed right after the call to detect unrelated sptes which must not be > found in the reverse-mapping list. > > Move this check in rmap_get_first/next() so

Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk()

2015-11-13 Thread Marcelo Tosatti
On Thu, Nov 12, 2015 at 08:52:45PM +0900, Takuya Yoshikawa wrote: > kvm_mmu_mark_parents_unsync() alone uses pte_list_walk(), witch does > nearly the same as the for_each_rmap_spte macro. The only difference > is that is_shadow_present_pte() checks cannot be placed there because >

Re: [PATCH RFC] ioctl based CAT interface

2015-11-13 Thread Marcelo Tosatti
On Fri, Nov 13, 2015 at 02:04:38PM -0500, Luiz Capitulino wrote: > On Fri, 13 Nov 2015 15:27:40 -0200 > Marcelo Tosatti <mtosa...@redhat.com> wrote: > > > On Fri, Nov 13, 2015 at 05:51:00PM +0100, Peter Zijlstra wrote: > > > On Fri, Nov 13, 2015 at 02:39:33P

cat cgroup interface proposal (non hierarchical) was Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-11-02 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 11:50:22AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 11:28:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti wrote: >

cat cgroup interface proposal (non hierarchical) was Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-11-02 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 11:50:22AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 11:28:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti wrote: >

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

2015-10-28 Thread Marcelo Tosatti
On Wed, Oct 28, 2015 at 06:05:00PM +0100, Paolo Bonzini wrote: > > > On 28/10/2015 17:00, Alex Williamson wrote: > > > Alex, would it make sense to use the IRQ bypass infrastructure always, > > > not just for VT-d, to do the MSI injection directly from the VFIO > > > interrupt handler and bypass

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

2015-10-28 Thread Marcelo Tosatti
On Wed, Oct 28, 2015 at 06:05:00PM +0100, Paolo Bonzini wrote: > > > On 28/10/2015 17:00, Alex Williamson wrote: > > > Alex, would it make sense to use the IRQ bypass infrastructure always, > > > not just for VT-d, to do the MSI injection directly from the VFIO > > > interrupt handler and bypass

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-26 Thread Marcelo Tosatti
Hi Peter, On Fri, Oct 16, 2015 at 11:50:22AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 11:28:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti w

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-26 Thread Marcelo Tosatti
Hi Peter, On Fri, Oct 16, 2015 at 11:50:22AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 11:28:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti w

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 05:24:42PM -0300, Marcelo Tosatti wrote: > On Fri, Oct 16, 2015 at 11:44:52AM +0200, Peter Zijlstra wrote: > > On Thu, Oct 15, 2015 at 09:17:16PM -0300, Marcelo Tosatti wrote: > > > On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > >

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 11:44:52AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 09:17:16PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 07:40:58PM -0300, Marcelo Tosatti wrote: >

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 11:44:52AM +0200, Peter Zijlstra wrote: > On Thu, Oct 15, 2015 at 09:17:16PM -0300, Marcelo Tosatti wrote: > > On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 13, 2015 at 07:40:58PM -0300, Marcelo Tosatti wrote: >

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2015 at 05:24:42PM -0300, Marcelo Tosatti wrote: > On Fri, Oct 16, 2015 at 11:44:52AM +0200, Peter Zijlstra wrote: > > On Thu, Oct 15, 2015 at 09:17:16PM -0300, Marcelo Tosatti wrote: > > > On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > >

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-15 Thread Marcelo Tosatti
On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti wrote: > > I am rewriting the interface with ioctls, with commands similar to the > > syscall interface proposed. > > Which is horrible for other use

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-15 Thread Marcelo Tosatti
On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2015 at 07:40:58PM -0300, Marcelo Tosatti wrote: > > How can you fix the issue of sockets with different reserved cache > > regions with hw in the cgroup interface? > > No idea what you're ref

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-15 Thread Marcelo Tosatti
On Thu, Oct 15, 2015 at 01:37:02PM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2015 at 07:40:58PM -0300, Marcelo Tosatti wrote: > > How can you fix the issue of sockets with different reserved cache > > regions with hw in the cgroup interface? > > No idea what you're ref

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-15 Thread Marcelo Tosatti
On Thu, Oct 15, 2015 at 01:36:14PM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2015 at 06:31:27PM -0300, Marcelo Tosatti wrote: > > I am rewriting the interface with ioctls, with commands similar to the > > syscall interface proposed. > > Which is horrible for other use

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-14 Thread Marcelo Tosatti
On Sun, Oct 11, 2015 at 09:50:12PM +0200, Thomas Gleixner wrote: > Fenghua, > > On Thu, 1 Oct 2015, Fenghua Yu wrote: > > +Cc: Marcelo > > > This series has some preparatory patches and Intel cache allocation > > support. > > > > > Changes in v15: > > - Add a global IPI to update the closid

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-14 Thread Marcelo Tosatti
On Mon, Oct 12, 2015 at 06:52:49PM +, Yu, Fenghua wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > Sent: Sunday, October 11, 2015 12:50 PM > > To: Yu, Fenghua > > Cc: H Peter Anvin; Ingo Molnar; Peter Zijlstra; linux-kernel; x86; Vikas > > Shivapp

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-14 Thread Marcelo Tosatti
On Sun, Oct 11, 2015 at 09:50:12PM +0200, Thomas Gleixner wrote: > Fenghua, > > On Thu, 1 Oct 2015, Fenghua Yu wrote: > > +Cc: Marcelo > > > This series has some preparatory patches and Intel cache allocation > > support. > > > > > Changes in v15: > > - Add a global IPI to update the closid

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

2015-10-14 Thread Marcelo Tosatti
On Mon, Oct 12, 2015 at 06:52:49PM +, Yu, Fenghua wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > Sent: Sunday, October 11, 2015 12:50 PM > > To: Yu, Fenghua > > Cc: H Peter Anvin; Ingo Molnar; Peter Zijlstra; linux-kernel; x86; Vikas > > Shivapp

Re: [PATCH 2/2] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-23 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 09:52:49PM +0200, Paolo Bonzini wrote: > > > On 22/09/2015 21:01, Marcelo Tosatti wrote: > > On Fri, Sep 18, 2015 at 05:54:30PM +0200, Radim Krčmář wrote: > >> Shifting pvclock_vcpu_time_info.system_time on write to KVM system time > >>

Re: [PATCH 2/2] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-23 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 09:52:49PM +0200, Paolo Bonzini wrote: > > > On 22/09/2015 21:01, Marcelo Tosatti wrote: > > On Fri, Sep 18, 2015 at 05:54:30PM +0200, Radim Krčmář wrote: > >> Shifting pvclock_vcpu_time_info.system_time on write to KVM system time > >>

Re: [PATCH v1] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-22 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 06:33:46PM +0200, Radim Krčmář wrote: > PVCLOCK_COUNTS_FROM_ZERO broke ABI and (at least) three things with it. > All problems stem from repeated writes to MSR_KVM_SYSTEM_TIME(_NEW). > The reverted patch treated the MSR write as a one-shot initializer: > any write from VCPU

Re: [PATCH 2/2] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-22 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:30PM +0200, Radim Krčmář wrote: > Shifting pvclock_vcpu_time_info.system_time on write to KVM system time > MSR is a change of ABI. Probably only 2.6.16 based SLES 10 breaks due > to its custom enhancements to kvmclock, but KVM never declared the MSR > only for

Re: [PATCH 1/2] x86: kvmclock: abolish PVCLOCK_COUNTS_FROM_ZERO

2015-09-22 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:29PM +0200, Radim Krčmář wrote: > Newer KVM won't be exposing PVCLOCK_COUNTS_FROM_ZERO anymore. > The purpose of that flags was to start counting system time from 0 when > the KVM clock has been initialized. > We can achieve the same by selecting one read as the

Re: [PATCH v1] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-22 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 06:33:46PM +0200, Radim Krčmář wrote: > PVCLOCK_COUNTS_FROM_ZERO broke ABI and (at least) three things with it. > All problems stem from repeated writes to MSR_KVM_SYSTEM_TIME(_NEW). > The reverted patch treated the MSR write as a one-shot initializer: > any write from VCPU

Re: [PATCH 1/2] x86: kvmclock: abolish PVCLOCK_COUNTS_FROM_ZERO

2015-09-22 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:29PM +0200, Radim Krčmář wrote: > Newer KVM won't be exposing PVCLOCK_COUNTS_FROM_ZERO anymore. > The purpose of that flags was to start counting system time from 0 when > the KVM clock has been initialized. > We can achieve the same by selecting one read as the

Re: [PATCH 2/2] Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR"

2015-09-22 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:30PM +0200, Radim Krčmář wrote: > Shifting pvclock_vcpu_time_info.system_time on write to KVM system time > MSR is a change of ABI. Probably only 2.6.16 based SLES 10 breaks due > to its custom enhancements to kvmclock, but KVM never declared the MSR > only for

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
> So either: > > Proceed with guest solution: > -> Make sure the overflow can't happen (and write down why not in the > code). Don't assume a small delta between kvmclock values of vcpus. > -> Handle stable -> non-stable kvmclock transition. > -> kvmclock counts from zero should not depend on

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 12:00:39AM +0200, Radim Krčmář wrote: > 2015-09-21 17:53-0300, Marcelo Tosatti: > > On Mon, Sep 21, 2015 at 10:00:27PM +0200, Radim Krčmář wrote: > >> 2015-09-21 12:52-0300, Marcelo Tosatti: > >> > On Mon, Sep 21, 2015 at 05:12:10PM +0200, Ra

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Mon, Sep 21, 2015 at 10:00:27PM +0200, Radim Krčmář wrote: > 2015-09-21 12:52-0300, Marcelo Tosatti: > > On Mon, Sep 21, 2015 at 05:12:10PM +0200, Radim Krčmář wrote: > >> 2015-09-20 19:57-0300, Marcelo Tosatti: > >>> Is it counting from zero that breaks SL

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Mon, Sep 21, 2015 at 05:12:10PM +0200, Radim Krčmář wrote: > 2015-09-20 19:57-0300, Marcelo Tosatti: > > On Fri, Sep 18, 2015 at 05:54:28PM +0200, Radim Krčmář wrote: > >> This patch series will be disabling PVCLOCK_COUNTS_FROM_ZERO flag and is > >> RFC because I have

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Tue, Sep 22, 2015 at 12:00:39AM +0200, Radim Krčmář wrote: > 2015-09-21 17:53-0300, Marcelo Tosatti: > > On Mon, Sep 21, 2015 at 10:00:27PM +0200, Radim Krčmář wrote: > >> 2015-09-21 12:52-0300, Marcelo Tosatti: > >> > On Mon, Sep 21, 2015 at 05:12:10PM +0200, Ra

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
> So either: > > Proceed with guest solution: > -> Make sure the overflow can't happen (and write down why not in the > code). Don't assume a small delta between kvmclock values of vcpus. > -> Handle stable -> non-stable kvmclock transition. > -> kvmclock counts from zero should not depend on

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Mon, Sep 21, 2015 at 05:12:10PM +0200, Radim Krčmář wrote: > 2015-09-20 19:57-0300, Marcelo Tosatti: > > On Fri, Sep 18, 2015 at 05:54:28PM +0200, Radim Krčmář wrote: > >> This patch series will be disabling PVCLOCK_COUNTS_FROM_ZERO flag and is > >> RFC because I have

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-21 Thread Marcelo Tosatti
On Mon, Sep 21, 2015 at 10:00:27PM +0200, Radim Krčmář wrote: > 2015-09-21 12:52-0300, Marcelo Tosatti: > > On Mon, Sep 21, 2015 at 05:12:10PM +0200, Radim Krčmář wrote: > >> 2015-09-20 19:57-0300, Marcelo Tosatti: > >>> Is it counting from zero that breaks SL

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-20 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:28PM +0200, Radim Krčmář wrote: > This patch series will be disabling PVCLOCK_COUNTS_FROM_ZERO flag and is > RFC because I haven't explored many potential problems or tested it. The justification to disable PVCLOCK_COUNTS_FROM_ZERO is because you haven't explored

Re: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO.

2015-09-20 Thread Marcelo Tosatti
On Fri, Sep 18, 2015 at 05:54:28PM +0200, Radim Krčmář wrote: > This patch series will be disabling PVCLOCK_COUNTS_FROM_ZERO flag and is > RFC because I haven't explored many potential problems or tested it. The justification to disable PVCLOCK_COUNTS_FROM_ZERO is because you haven't explored

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-24 Thread Marcelo Tosatti
On Sun, Aug 23, 2015 at 11:47:49AM -0700, Vikas Shivappa wrote: > > > On Fri, 21 Aug 2015, Marcelo Tosatti wrote: > > >On Thu, Aug 20, 2015 at 05:06:51PM -0700, Vikas Shivappa wrote: > >> > >> > >>On Mon, 17 Aug 2015, Marcelo Tosatti wrote: > >

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-24 Thread Marcelo Tosatti
On Sun, Aug 23, 2015 at 11:47:49AM -0700, Vikas Shivappa wrote: On Fri, 21 Aug 2015, Marcelo Tosatti wrote: On Thu, Aug 20, 2015 at 05:06:51PM -0700, Vikas Shivappa wrote: On Mon, 17 Aug 2015, Marcelo Tosatti wrote: Vikas, Tejun, This is an updated interface. It addresses all

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-21 Thread Marcelo Tosatti
On Thu, Aug 20, 2015 at 05:06:51PM -0700, Vikas Shivappa wrote: > > > On Mon, 17 Aug 2015, Marcelo Tosatti wrote: > > >Vikas, Tejun, > > > >This is an updated interface. It addresses all comments made > >so far and also covers all use-cases the cgroup int

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-21 Thread Marcelo Tosatti
On Thu, Aug 20, 2015 at 05:06:51PM -0700, Vikas Shivappa wrote: On Mon, 17 Aug 2015, Marcelo Tosatti wrote: Vikas, Tejun, This is an updated interface. It addresses all comments made so far and also covers all use-cases the cgroup interface covers. Let me know what you think. I'll

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-17 Thread Marcelo Tosatti
Vikas, Tejun, This is an updated interface. It addresses all comments made so far and also covers all use-cases the cgroup interface covers. Let me know what you think. I'll proceed to writing the test applications. Usage model: This document details how CAT technology is

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-17 Thread Marcelo Tosatti
Vikas, Tejun, This is an updated interface. It addresses all comments made so far and also covers all use-cases the cgroup interface covers. Let me know what you think. I'll proceed to writing the test applications. Usage model: This document details how CAT technology is

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-07 Thread Marcelo Tosatti
On Thu, Aug 06, 2015 at 01:46:06PM -0700, Vikas Shivappa wrote: > > > On Wed, 5 Aug 2015, Marcelo Tosatti wrote: > > >On Wed, Aug 05, 2015 at 01:22:57PM +0100, Matt Fleming wrote: > >>On Sun, 02 Aug, at 12:31:57PM, Tejun Heo wrote: > >>> > >>>B

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-07 Thread Marcelo Tosatti
On Thu, Aug 06, 2015 at 01:46:06PM -0700, Vikas Shivappa wrote: On Wed, 5 Aug 2015, Marcelo Tosatti wrote: On Wed, Aug 05, 2015 at 01:22:57PM +0100, Matt Fleming wrote: On Sun, 02 Aug, at 12:31:57PM, Tejun Heo wrote: But we're doing it the wrong way around. You can do most of what

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-05 Thread Marcelo Tosatti
On Wed, Aug 05, 2015 at 01:22:57PM +0100, Matt Fleming wrote: > On Sun, 02 Aug, at 12:31:57PM, Tejun Heo wrote: > > > > But we're doing it the wrong way around. You can do most of what > > cgroup interface can do with systemcall-like interface with some > > inconvenience. The other way doesn't

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-05 Thread Marcelo Tosatti
On Wed, Aug 05, 2015 at 01:22:57PM +0100, Matt Fleming wrote: On Sun, 02 Aug, at 12:31:57PM, Tejun Heo wrote: But we're doing it the wrong way around. You can do most of what cgroup interface can do with systemcall-like interface with some inconvenience. The other way doesn't really

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-04 Thread Marcelo Tosatti
On Mon, Aug 03, 2015 at 05:32:50PM -0300, Marcelo Tosatti wrote: > On Sun, Aug 02, 2015 at 12:23:25PM -0400, Tejun Heo wrote: > > Hello, > > > > On Fri, Jul 31, 2015 at 12:12:18PM -0300, Marcelo Tosatti wrote: > > > > I don't really think it makes sense

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-04 Thread Marcelo Tosatti
On Mon, Aug 03, 2015 at 05:32:50PM -0300, Marcelo Tosatti wrote: On Sun, Aug 02, 2015 at 12:23:25PM -0400, Tejun Heo wrote: Hello, On Fri, Jul 31, 2015 at 12:12:18PM -0300, Marcelo Tosatti wrote: I don't really think it makes sense to implement a fully hierarchical cgroup solution

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-03 Thread Marcelo Tosatti
On Sun, Aug 02, 2015 at 12:23:25PM -0400, Tejun Heo wrote: > Hello, > > On Fri, Jul 31, 2015 at 12:12:18PM -0300, Marcelo Tosatti wrote: > > > I don't really think it makes sense to implement a fully hierarchical > > > cgroup solution when there isn't the basic affinit

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-08-03 Thread Marcelo Tosatti
On Sun, Aug 02, 2015 at 05:48:07PM +0200, Martin Kletzander wrote: > On Thu, Jul 30, 2015 at 05:08:13PM -0300, Marcelo Tosatti wrote: > >On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: > >> > >> > >>Marcello, > >> > >> > >

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-08-03 Thread Marcelo Tosatti
On Sun, Aug 02, 2015 at 12:23:25PM -0400, Tejun Heo wrote: Hello, On Fri, Jul 31, 2015 at 12:12:18PM -0300, Marcelo Tosatti wrote: I don't really think it makes sense to implement a fully hierarchical cgroup solution when there isn't the basic affinity-adjusting interface What

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-08-03 Thread Marcelo Tosatti
On Sun, Aug 02, 2015 at 05:48:07PM +0200, Martin Kletzander wrote: On Thu, Jul 30, 2015 at 05:08:13PM -0300, Marcelo Tosatti wrote: On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: Marcello, On Wed, 29 Jul 2015, Marcelo Tosatti wrote: How about this: desiredclos

Re: [summary] Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
very confusing for the user if he > has allocated a cache mask and suddenly from under the floor the > kernel changes it. Agree. > > Thanks, > Vikas > > > On Fri, 31 Jul 2015, Marcelo Tosatti wrote: > > >On Thu, Jul 30, 2015 at 04:03:07PM -0700

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 05:08:13PM -0300, Marcelo Tosatti wrote: > On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: > > > > > > Marcello, > > > > > > On Wed, 29 Jul 2015, Marcelo Tosatti wrote: > > > > > >How

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 04:03:07PM -0700, Vikas Shivappa wrote: > > > On Thu, 30 Jul 2015, Marcelo Tosatti wrote: > > >On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: > >> > >> > >>Marcello, > >> > >> >

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 03:44:58PM -0400, Tejun Heo wrote: > Hello, Vikas. > > On Wed, Jul 01, 2015 at 03:21:06PM -0700, Vikas Shivappa wrote: > > This patch adds a cgroup subsystem for Intel Resource Director > > Technology(RDT) feature and Class of service(CLOSid) management which is > > part

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 04:03:07PM -0700, Vikas Shivappa wrote: On Thu, 30 Jul 2015, Marcelo Tosatti wrote: On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: Marcello, On Wed, 29 Jul 2015, Marcelo Tosatti wrote: How about this: desiredclos (closid p1 p2 p3

Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 03:44:58PM -0400, Tejun Heo wrote: Hello, Vikas. On Wed, Jul 01, 2015 at 03:21:06PM -0700, Vikas Shivappa wrote: This patch adds a cgroup subsystem for Intel Resource Director Technology(RDT) feature and Class of service(CLOSid) management which is part of common

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 05:08:13PM -0300, Marcelo Tosatti wrote: On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: Marcello, On Wed, 29 Jul 2015, Marcelo Tosatti wrote: How about this: desiredclos (closid p1 p2 p3 p4) 1 1 0 0 0

Re: [summary] Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-31 Thread Marcelo Tosatti
if we can avoid it. This interface lets the super-user control the cache allocation and it may be very confusing for the user if he has allocated a cache mask and suddenly from under the floor the kernel changes it. Agree. Thanks, Vikas On Fri, 31 Jul 2015, Marcelo Tosatti wrote

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-30 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: > > > Marcello, > > > On Wed, 29 Jul 2015, Marcelo Tosatti wrote: > > > >How about this: > > > >desiredclos (closid p1 p2 p3 p4) > > 1 1 0 0 0 > >

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-30 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: > > > Marcello, > > > On Wed, 29 Jul 2015, Marcelo Tosatti wrote: > > > >How about this: > > > >desiredclos (closid p1 p2 p3 p4) > > 1 1 0 0 0 > >

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-30 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: Marcello, On Wed, 29 Jul 2015, Marcelo Tosatti wrote: How about this: desiredclos (closid p1 p2 p3 p4) 1 1 0 0 0 2 0 0 0 1 3 0 1 1 0 #1 Currently

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-30 Thread Marcelo Tosatti
On Thu, Jul 30, 2015 at 10:47:23AM -0700, Vikas Shivappa wrote: Marcello, On Wed, 29 Jul 2015, Marcelo Tosatti wrote: How about this: desiredclos (closid p1 p2 p3 p4) 1 1 0 0 0 2 0 0 0 1 3 0 1 1 0 #1 Currently

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-29 Thread Marcelo Tosatti
On Wed, Jul 29, 2015 at 01:28:38AM +, Auld, Will wrote: > > > Whenever cgroupE has zero tasks, remove exclusivity (by allowing other > > > cgroups to use the exclusive ways of it). > > > > Same comment as above - Cgroup masks can always overlap and other cgroups > > can allocate the same

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-29 Thread Marcelo Tosatti
On Wed, Jul 29, 2015 at 01:28:38AM +, Auld, Will wrote: Whenever cgroupE has zero tasks, remove exclusivity (by allowing other cgroups to use the exclusive ways of it). Same comment as above - Cgroup masks can always overlap and other cgroups can allocate the same cache , and

Re: [PATCH 7/7] x86/intel_rdt: Add CAT documentation and usage guide

2015-07-28 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 10:27:32AM -0700, Vikas Shivappa wrote: > > > On Thu, 26 Mar 2015, Marcelo Tosatti wrote: > > > > >I can't find any discussion relating to exposing the CBM interface > >directly to userspace in that thread ? > > > >Cpu.shares is

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-28 Thread Marcelo Tosatti
On Wed, Jul 01, 2015 at 03:21:04PM -0700, Vikas Shivappa wrote: > Adds a description of Cache allocation technology, overview > of kernel implementation and usage of Cache Allocation cgroup interface. > > Cache allocation is a sub-feature of Resource Director Technology(RDT) > Allocation or

Re: [PATCH 3/9] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide

2015-07-28 Thread Marcelo Tosatti
On Wed, Jul 01, 2015 at 03:21:04PM -0700, Vikas Shivappa wrote: Adds a description of Cache allocation technology, overview of kernel implementation and usage of Cache Allocation cgroup interface. Cache allocation is a sub-feature of Resource Director Technology(RDT) Allocation or Platform

Re: [PATCH 7/7] x86/intel_rdt: Add CAT documentation and usage guide

2015-07-28 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 10:27:32AM -0700, Vikas Shivappa wrote: On Thu, 26 Mar 2015, Marcelo Tosatti wrote: I can't find any discussion relating to exposing the CBM interface directly to userspace in that thread ? Cpu.shares is written in ratio form, which is much more natural. Do

[GIT PULL] KVM fixes for 4.1-rc8

2015-06-16 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fix, which restores APIC migration functionality. Radim Krčmář (1): KVM: x86: fix lapic.timer_mode on restore arch/x86/kvm/lapic.c | 26 -- 1 file

[GIT PULL] KVM fixes for 4.1-rc8

2015-06-16 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fix, which restores APIC migration functionality. Radim Krčmář (1): KVM: x86: fix lapic.timer_mode on restore arch/x86/kvm/lapic.c | 26 -- 1 file

Re: [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked

2015-06-05 Thread Marcelo Tosatti
On Tue, Apr 14, 2015 at 07:37:44AM +, Wu, Feng wrote: > > > > -Original Message- > > From: Marcelo Tosatti [mailto:mtosa...@redhat.com] > > Sent: Tuesday, March 31, 2015 7:56 AM > > To: Wu, Feng > > Cc: h...@zytor.com; t...@linutronix.de; mi..

Re: [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked

2015-06-05 Thread Marcelo Tosatti
On Tue, Apr 14, 2015 at 07:37:44AM +, Wu, Feng wrote: -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Tuesday, March 31, 2015 7:56 AM To: Wu, Feng Cc: h...@zytor.com; t...@linutronix.de; mi...@redhat.com; x...@kernel.org; g...@kernel.org

[PATCH v2] KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR

2015-05-23 Thread Marcelo Tosatti
Initialize kvmclock base, on kvmclock system MSR write time, so that the guest sees kvmclock counting from zero. This matches baremetal behaviour when kvmclock in guest sets sched clock stable. Signed-off-by: Marcelo Tosatti diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index cc2c759

[PATCH v2] KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR

2015-05-23 Thread Marcelo Tosatti
Initialize kvmclock base, on kvmclock system MSR write time, so that the guest sees kvmclock counting from zero. This matches baremetal behaviour when kvmclock in guest sets sched clock stable. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm

Re: kvm: odd time values since "kvmclock: set scheduler clock stable"

2015-05-21 Thread Marcelo Tosatti
On Mon, May 18, 2015 at 10:13:03PM -0400, Sasha Levin wrote: > On 05/18/2015 10:02 PM, Sasha Levin wrote: > > On 05/18/2015 08:13 PM, Marcelo Tosatti wrote: > >> GOn Mon, May 18, 2015 at 07:45:41PM -0400, Sasha Levin wrote: > >>>> On 05/18/2015 06:39 PM, Marcelo To

KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR

2015-05-21 Thread Marcelo Tosatti
Initialize kvmclock base, on kvmclock system MSR write time, so that the guest sees kvmclock counting from zero. This matches baremetal behaviour when kvmclock in guest sets sched clock stable. Signed-off-by: Marcelo Tosatti diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index cc2c759

Re: kvm: odd time values since kvmclock: set scheduler clock stable

2015-05-21 Thread Marcelo Tosatti
On Mon, May 18, 2015 at 10:13:03PM -0400, Sasha Levin wrote: On 05/18/2015 10:02 PM, Sasha Levin wrote: On 05/18/2015 08:13 PM, Marcelo Tosatti wrote: GOn Mon, May 18, 2015 at 07:45:41PM -0400, Sasha Levin wrote: On 05/18/2015 06:39 PM, Marcelo Tosatti wrote: On Tue, May 12, 2015 at 07:17

KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR

2015-05-21 Thread Marcelo Tosatti
Initialize kvmclock base, on kvmclock system MSR write time, so that the guest sees kvmclock counting from zero. This matches baremetal behaviour when kvmclock in guest sets sched clock stable. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm

Re: kvm: odd time values since "kvmclock: set scheduler clock stable"

2015-05-18 Thread Marcelo Tosatti
GOn Mon, May 18, 2015 at 07:45:41PM -0400, Sasha Levin wrote: > On 05/18/2015 06:39 PM, Marcelo Tosatti wrote: > > On Tue, May 12, 2015 at 07:17:24PM -0400, Sasha Levin wrote: > >> Hi all, > >> > >> I'm seeing odd jump in time values during boot of a KVM guest

Re: kvm: odd time values since "kvmclock: set scheduler clock stable"

2015-05-18 Thread Marcelo Tosatti
On Tue, May 12, 2015 at 07:17:24PM -0400, Sasha Levin wrote: > Hi all, > > I'm seeing odd jump in time values during boot of a KVM guest: > > [...] > [0.00] tsc: Detected 2260.998 MHz processor > [3376355.247558] Calibrating delay loop (skipped) preset value.. > [...] > > I've bisected

Re: kvm: odd time values since kvmclock: set scheduler clock stable

2015-05-18 Thread Marcelo Tosatti
On Tue, May 12, 2015 at 07:17:24PM -0400, Sasha Levin wrote: Hi all, I'm seeing odd jump in time values during boot of a KVM guest: [...] [0.00] tsc: Detected 2260.998 MHz processor [3376355.247558] Calibrating delay loop (skipped) preset value.. [...] I've bisected it to:

Re: kvm: odd time values since kvmclock: set scheduler clock stable

2015-05-18 Thread Marcelo Tosatti
GOn Mon, May 18, 2015 at 07:45:41PM -0400, Sasha Levin wrote: On 05/18/2015 06:39 PM, Marcelo Tosatti wrote: On Tue, May 12, 2015 at 07:17:24PM -0400, Sasha Levin wrote: Hi all, I'm seeing odd jump in time values during boot of a KVM guest: [...] [0.00] tsc: Detected

<    1   2   3   4   5   6   7   8   9   10   >