break;
> + case MEDIA_BUS_FMT_RGB888_1X24:
> + reg |= CTRL_SET_BUS_WIDTH(STMLCDIF_24BIT);
> + break;
> + default:
> + dev_err(drm->dev, "Unknown media bus format %d\n", bus_format);
> + break;
> + }
> + writel(reg, mxsfb->base + LCDC_CTRL);
On MX6SX:
Tested-by: Marek Vasut <ma...@denx.de>
--
Best regards,
Marek Vasut
GB888_1X24:
> + reg |= CTRL_SET_BUS_WIDTH(STMLCDIF_24BIT);
> + break;
> + default:
> + dev_err(drm->dev, "Unknown media bus format %d\n", bus_format);
> + break;
> + }
> + writel(reg, mxsfb->base + LCDC_CTRL);
On MX6SX:
Tested-by: Marek Vasut
--
Best regards,
Marek Vasut
On 12/08/2016 09:46 PM, Stefan Agner wrote:
> On 2016-12-07 18:37, Marek Vasut wrote:
>> On 12/08/2016 02:26 AM, Stefan Agner wrote:
>>> On 2016-12-07 16:59, Stefan Agner wrote:
>>>> On 2016-12-07 16:49, Marek Vasut wrote:
>>>>> On 12/08/2016 01:27 AM,
On 12/08/2016 09:46 PM, Stefan Agner wrote:
> On 2016-12-07 18:37, Marek Vasut wrote:
>> On 12/08/2016 02:26 AM, Stefan Agner wrote:
>>> On 2016-12-07 16:59, Stefan Agner wrote:
>>>> On 2016-12-07 16:49, Marek Vasut wrote:
>>>>> On 12/08/2016 01:27 AM,
c-adc.c
> delete mode 100644 drivers/iio/adc/mxs-lradc.c
> create mode 100644 drivers/input/touchscreen/mxs-lradc-ts.c
> create mode 100644 drivers/mfd/mxs-lradc.c
> create mode 100644 include/linux/mfd/mxs-lradc.h
>
Except minor nit in 1/5, the whole series is:
Reviewed-by: Marek Vasut <ma...@denx.de>
--
Best regards,
Marek Vasut
c-adc.c
> delete mode 100644 drivers/iio/adc/mxs-lradc.c
> create mode 100644 drivers/input/touchscreen/mxs-lradc-ts.c
> create mode 100644 drivers/mfd/mxs-lradc.c
> create mode 100644 include/linux/mfd/mxs-lradc.h
>
Except minor nit in 1/5, the whole series is:
Reviewed-by: Marek Vasut
--
Best regards,
Marek Vasut
+#define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n))
This would turn into BIT(n) , no ?
> +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff
> +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff
> +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0
[...]
--
Best regards,
Marek Vasut
(1 << (n))
This would turn into BIT(n) , no ?
> +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff
> +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff
> +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0
[...]
--
Best regards,
Marek Vasut
On 12/07/2016 05:59 PM, Cyrille Pitchen wrote:
> Le 07/12/2016 à 17:32, Marek Vasut a écrit :
>> On 12/07/2016 05:29 PM, Cyrille Pitchen wrote:
>>> Le 07/12/2016 à 17:20, Marek Vasut a écrit :
>>>> On 12/06/2016 05:52 PM, Cyrille Pitchen wrote:
>>>>
On 12/07/2016 05:59 PM, Cyrille Pitchen wrote:
> Le 07/12/2016 à 17:32, Marek Vasut a écrit :
>> On 12/07/2016 05:29 PM, Cyrille Pitchen wrote:
>>> Le 07/12/2016 à 17:20, Marek Vasut a écrit :
>>>> On 12/06/2016 05:52 PM, Cyrille Pitchen wrote:
>>>>
On 12/08/2016 02:26 AM, Stefan Agner wrote:
> On 2016-12-07 16:59, Stefan Agner wrote:
>> On 2016-12-07 16:49, Marek Vasut wrote:
>>> On 12/08/2016 01:27 AM, Stefan Agner wrote:
>>>> The DRM subsystem specifies the pixel clock polarity from
On 12/08/2016 02:26 AM, Stefan Agner wrote:
> On 2016-12-07 16:59, Stefan Agner wrote:
>> On 2016-12-07 16:49, Marek Vasut wrote:
>>> On 12/08/2016 01:27 AM, Stefan Agner wrote:
>>>> The DRM subsystem specifies the pixel clock polarity from
GE -> VDCTRL0_DOTCLK_ACT_FALLING
> + */
> + if (bus_flags & DRM_BUS_FLAG_PIXDATA_POSEDGE)
> vdctrl0 |= VDCTRL0_DOTCLK_ACT_FALLING;
>
> writel(vdctrl0, mxsfb->base + LCDC_VDCTRL0);
>
--
Best regards,
Marek Vasut
LK_ACT_FALLING
> + */
> + if (bus_flags & DRM_BUS_FLAG_PIXDATA_POSEDGE)
> vdctrl0 |= VDCTRL0_DOTCLK_ACT_FALLING;
>
> writel(vdctrl0, mxsfb->base + LCDC_VDCTRL0);
>
--
Best regards,
Marek Vasut
On 12/07/2016 05:29 PM, Cyrille Pitchen wrote:
> Le 07/12/2016 à 17:20, Marek Vasut a écrit :
>> On 12/06/2016 05:52 PM, Cyrille Pitchen wrote:
>>> This patch provides an alternative mean to support memory above 16MiB
>>> (128Mib) by replacing 3byte address op code
On 12/07/2016 05:29 PM, Cyrille Pitchen wrote:
> Le 07/12/2016 à 17:20, Marek Vasut a écrit :
>> On 12/06/2016 05:52 PM, Cyrille Pitchen wrote:
>>> This patch provides an alternative mean to support memory above 16MiB
>>> (128Mib) by replacing 3byte address op code
for v4.11.
Hmmm, that kinda sucks. Lee, are you positive this isn't 4.10
material ?
--
Best regards,
Marek Vasut
for v4.11.
Hmmm, that kinda sucks. Lee, are you positive this isn't 4.10
material ?
--
Best regards,
Marek Vasut
built from the 3-byte address name appending the "_4B"
>> suffix.
>
> Acked-by: Mark Brown <broo...@kernel.org>
>
It's certainly less confusing naming, so
Acked-by: Marek Vasut <marek.va...@gmail.com>
--
Best regards,
Marek Vasut
built from the 3-byte address name appending the "_4B"
>> suffix.
>
> Acked-by: Mark Brown
>
It's certainly less confusing naming, so
Acked-by: Marek Vasut
--
Best regards,
Marek Vasut
am_opcode = SPINOR_OP_PP_4B;
> - /* No small sector erase for 4-byte command set */
> - nor->erase_opcode = SPINOR_OP_SE_4B;
> - mtd->erasesize = info->sector_size;
> - } else
> + if (JEDEC_MFR(info) == SNOR_MFR_SPANSION ||
> + info->flags & SPI_NOR_4B_OPCODES)
> + spi_nor_set_4byte_opcodes(nor, info);
> + else
> set_4byte(nor, info, 1);
> } else {
> nor->addr_width = 3;
>
--
Best regards,
Marek Vasut
break;
> - case SPI_NOR_NORMAL:
> - nor->read_opcode = SPINOR_OP_READ_4B;
> - break;
> - }
> - nor->program_opcode = SPINOR_OP_PP_4B;
> - /* No small sector erase for 4-byte command set */
> - nor->erase_opcode = SPINOR_OP_SE_4B;
> - mtd->erasesize = info->sector_size;
> - } else
> + if (JEDEC_MFR(info) == SNOR_MFR_SPANSION ||
> + info->flags & SPI_NOR_4B_OPCODES)
> + spi_nor_set_4byte_opcodes(nor, info);
> + else
> set_4byte(nor, info, 1);
> } else {
> nor->addr_width = 3;
>
--
Best regards,
Marek Vasut
On 12/07/2016 12:38 AM, Cyrille Pitchen wrote:
> Le 06/12/2016 à 20:00, Marek Vasut a écrit :
>> On 12/06/2016 06:14 PM, Cyrille Pitchen wrote:
>>> This patch removes the WARN_ONCE() test in spi_nor_write().
>>> This macro triggers the display of a warning message a
On 12/07/2016 12:38 AM, Cyrille Pitchen wrote:
> Le 06/12/2016 à 20:00, Marek Vasut a écrit :
>> On 12/06/2016 06:14 PM, Cyrille Pitchen wrote:
>>> This patch removes the WARN_ONCE() test in spi_nor_write().
>>> This macro triggers the display of a warning message a
On 12/07/2016 12:05 AM, Cyrille Pitchen wrote:
> Le 06/12/2016 à 20:01, Marek Vasut a écrit :
>> On 12/06/2016 05:01 PM, Cyrille Pitchen wrote:
>>> The patch checks whether the Quad Enable bit is already set in the Status
>>> Register. If so, the function exits immediate
On 12/07/2016 12:05 AM, Cyrille Pitchen wrote:
> Le 06/12/2016 à 20:01, Marek Vasut a écrit :
>> On 12/06/2016 05:01 PM, Cyrille Pitchen wrote:
>>> The patch checks whether the Quad Enable bit is already set in the Status
>>> Register. If so, the function exits immediate
On 12/06/2016 05:01 PM, Cyrille Pitchen wrote:
> The patch checks whether the Quad Enable bit is already set in the Status
> Register. If so, the function exits immediately with a successful return
> code.
Performance optimization I presume ?
Acked-by: Marek Vasut <marek.va.
On 12/06/2016 05:01 PM, Cyrille Pitchen wrote:
> The patch checks whether the Quad Enable bit is already set in the Status
> Register. If so, the function exits immediately with a successful return
> code.
Performance optimization I presume ?
Acked-by: Marek Vasut
> Signed-off
fset);
> /* the size of data remaining on the first page */
> page_remain = min_t(size_t,
> nor->page_size - page_offset, len - i);
>
--
Best regards,
Marek Vasut
ize_t,
> nor->page_size - page_offset, len - i);
>
--
Best regards,
Marek Vasut
On 12/05/2016 09:51 PM, Dinh Nguyen wrote:
> On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut <marek.va...@gmail.com> wrote:
>> On 12/05/2016 05:10 AM, Masahiro Yamada wrote:
>>> Hi Marek,
>>>
>>>
>>> 2016-12-05 12:44 GMT+09:00 Marek Vasut <marek.v
On 12/05/2016 09:51 PM, Dinh Nguyen wrote:
> On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut wrote:
>> On 12/05/2016 05:10 AM, Masahiro Yamada wrote:
>>> Hi Marek,
>>>
>>>
>>> 2016-12-05 12:44 GMT+09:00 Marek Vasut :
>>>> On
On 12/05/2016 09:36 AM, Boris Brezillon wrote:
> On Mon, 5 Dec 2016 05:25:54 +0100
> Marek Vasut <marek.va...@gmail.com> wrote:
>
>> On 12/05/2016 05:11 AM, Punnaiah Choudary Kalluri wrote:
>>> This patch adds the dts binding document for arasan nand flash
>
On 12/05/2016 09:36 AM, Boris Brezillon wrote:
> On Mon, 5 Dec 2016 05:25:54 +0100
> Marek Vasut wrote:
>
>> On 12/05/2016 05:11 AM, Punnaiah Choudary Kalluri wrote:
>>> This patch adds the dts binding document for arasan nand flash
>>> controller.
>>
n read-only
>> unless instructed othwerwise by module parameter.
>
> Hi Lee,
>
> I think we have enough acks from the MTD maintainers. I wonder if you
> could merge this series via your MFD tree?
>
Ideally you'd merge 1/3 via MTD and 2,3/3 via MFD, but I'm not sure if
that is possible and if that is a sensible thing to do.
--
Best regards,
Marek Vasut
n read-only
>> unless instructed othwerwise by module parameter.
>
> Hi Lee,
>
> I think we have enough acks from the MTD maintainers. I wonder if you
> could merge this series via your MFD tree?
>
Ideally you'd merge 1/3 via MTD and 2,3/3 via MFD, but I'm not sure if
that is possible and if that is a sensible thing to do.
--
Best regards,
Marek Vasut
reg = <0>
> + partition@0 {
> + label = "filesystem";
> + reg = <0x0 0x0 0x100>;
> + };
> + (...)
> + };
> + };
>
--
Best regards,
Marek Vasut
(mtd, NAND_CMD_SET_FEATURES, addr, -1);
> + anfc_writefifo(nfc, PROG_SET_FEATURE, achip->spktsize,
> + subfeature_param);
> +
> + status = chip->waitfunc(mtd, chip);
> + if (status & NAND_STATUS_FAIL)
> + return -EIO;
> +
> + return 0;
> +}
> +
> +static int anfc_init_timing_mode(struct anfc *nfc,
> + struct anfc_nand_chip *achip)
> +{
> + int mode, err;
> + unsigned int feature[2];
> + u32 inftimeval;
> + struct nand_chip *chip = >chip;
> + struct mtd_info *mtd = nand_to_mtd(chip);
> +
> + memset(feature, 0, NVDDR_MODE_PACKET_SIZE);
> + /* Get nvddr timing modes */
> + mode = onfi_get_sync_timing_mode(chip) & 0xff;
> + if (!mode) {
> + mode = fls(onfi_get_async_timing_mode(chip)) - 1;
> + inftimeval = mode;
> + } else {
> + mode = fls(mode) - 1;
> + inftimeval = NVDDR_MODE | (mode << NVDDR_TIMING_MODE_SHIFT);
> + mode |= ONFI_DATA_INTERFACE_NVDDR;
> + }
> +
> + feature[0] = mode;
> + chip->select_chip(mtd, achip->csnum);
> + err = chip->onfi_set_features(mtd, chip, ONFI_FEATURE_ADDR_TIMING_MODE,
> + (uint8_t *)feature);
> + chip->select_chip(mtd, -1);
> + if (err)
> + return err;
> +
> + achip->inftimeval = inftimeval;
> +
> + if (mode & ONFI_DATA_INTERFACE_NVDDR)
> + achip->spktsize = NVDDR_MODE_PACKET_SIZE;
> +
> + return 0;
> +}
[...]
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Xilinx, Inc");
There should be a contact with email address here.
> +MODULE_DESCRIPTION("Arasan NAND Flash Controller Driver");
>
--
Best regards,
Marek Vasut
interrupt-parent = <>;
> + interrupts = <0 14 4>;
> + arasan,has-mdma;
> + #address-cells = <1>;
> + #size-cells = <0>
> +
> + nand@0 {
> + reg = <0>
> + partition@0 {
> + label = "filesystem";
> + reg = <0x0 0x0 0x100>;
> + };
> + (...)
> + };
> + };
>
--
Best regards,
Marek Vasut
ddr, -1);
> + anfc_writefifo(nfc, PROG_SET_FEATURE, achip->spktsize,
> + subfeature_param);
> +
> + status = chip->waitfunc(mtd, chip);
> + if (status & NAND_STATUS_FAIL)
> + return -EIO;
> +
> + return 0;
> +}
> +
> +static int anfc_init_timing_mode(struct anfc *nfc,
> + struct anfc_nand_chip *achip)
> +{
> + int mode, err;
> + unsigned int feature[2];
> + u32 inftimeval;
> + struct nand_chip *chip = >chip;
> + struct mtd_info *mtd = nand_to_mtd(chip);
> +
> + memset(feature, 0, NVDDR_MODE_PACKET_SIZE);
> + /* Get nvddr timing modes */
> + mode = onfi_get_sync_timing_mode(chip) & 0xff;
> + if (!mode) {
> + mode = fls(onfi_get_async_timing_mode(chip)) - 1;
> + inftimeval = mode;
> + } else {
> + mode = fls(mode) - 1;
> + inftimeval = NVDDR_MODE | (mode << NVDDR_TIMING_MODE_SHIFT);
> + mode |= ONFI_DATA_INTERFACE_NVDDR;
> + }
> +
> + feature[0] = mode;
> + chip->select_chip(mtd, achip->csnum);
> + err = chip->onfi_set_features(mtd, chip, ONFI_FEATURE_ADDR_TIMING_MODE,
> + (uint8_t *)feature);
> + chip->select_chip(mtd, -1);
> + if (err)
> + return err;
> +
> + achip->inftimeval = inftimeval;
> +
> + if (mode & ONFI_DATA_INTERFACE_NVDDR)
> + achip->spktsize = NVDDR_MODE_PACKET_SIZE;
> +
> + return 0;
> +}
[...]
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Xilinx, Inc");
There should be a contact with email address here.
> +MODULE_DESCRIPTION("Arasan NAND Flash Controller Driver");
>
--
Best regards,
Marek Vasut
On 12/05/2016 05:10 AM, Masahiro Yamada wrote:
> Hi Marek,
>
>
> 2016-12-05 12:44 GMT+09:00 Marek Vasut <marek.va...@gmail.com>:
>> On 12/05/2016 04:30 AM, Masahiro Yamada wrote:
>>> Hi Dinh,
>>>
>>>
>>> 2016-12-04 7:08 GMT+09:00 Dinh N
On 12/05/2016 05:10 AM, Masahiro Yamada wrote:
> Hi Marek,
>
>
> 2016-12-05 12:44 GMT+09:00 Marek Vasut :
>> On 12/05/2016 04:30 AM, Masahiro Yamada wrote:
>>> Hi Dinh,
>>>
>>>
>>> 2016-12-04 7:08 GMT+09:00 Dinh Nguyen :
>>>>
On 12/05/2016 04:30 AM, Masahiro Yamada wrote:
> Hi Dinh,
>
>
> 2016-12-04 7:08 GMT+09:00 Dinh Nguyen <dinh.li...@gmail.com>:
>> Hi,
>>
>> On Fri, Dec 2, 2016 at 8:49 PM, Marek Vasut <marek.va...@gmail.com> wrote:
>>> On 12/03/2016 03:41
On 12/05/2016 04:30 AM, Masahiro Yamada wrote:
> Hi Dinh,
>
>
> 2016-12-04 7:08 GMT+09:00 Dinh Nguyen :
>> Hi,
>>
>> On Fri, Dec 2, 2016 at 8:49 PM, Marek Vasut wrote:
>>> On 12/03/2016 03:41 AM, Masahiro Yamada wrote:
>>>> Hi Rob,
>>
On 12/04/2016 09:33 PM, Joe Perches wrote:
> On Sun, 2016-12-04 at 13:48 +0100, Marek Vasut wrote:
>> On 12/04/2016 07:12 AM, Pan Bian wrote:
>>> From: Pan Bian <bianpan2...@163.com>
>>>
>>> When __vmalloc() returns a NULL pointer, the region is not chec
On 12/04/2016 09:33 PM, Joe Perches wrote:
> On Sun, 2016-12-04 at 13:48 +0100, Marek Vasut wrote:
>> On 12/04/2016 07:12 AM, Pan Bian wrote:
>>> From: Pan Bian
>>>
>>> When __vmalloc() returns a NULL pointer, the region is not checked, and
>>> we cann
rr(ubi, "cannot allocate memory to check for 0xFFs");
> - return 0;
> + return -ENOMEM;
I wonder if you shouldn't also nuke the ubi_err() , because when you run
out of memory, printk() will likely also fail.
> }
>
> err = mtd_read(ubi->mtd, addr, len, , buf);
>
--
Best regards,
Marek Vasut
");
> - return 0;
> + return -ENOMEM;
I wonder if you shouldn't also nuke the ubi_err() , because when you run
out of memory, printk() will likely also fail.
> }
>
> err = mtd_read(ubi->mtd, addr, len, , buf);
>
--
Best regards,
Marek Vasut
r-v5b-nand" (and v5a).
>> The fact that it is denali is part of the documentation.
>>
>
> Let me think about this.
>
> Socionext bought two version of Denali IP,
> and we are now re-using the newer one (v5b) for several SoCs.
> Socionext has some more product lines other than Uniphier SoC family,
> perhaps wider re-use might happen in the future.
>
> At first, I included "uniphier" in compatible, but I am still wondering
> if such a specific string is good or not.
>
> Also, comments from Altera engineers are appreciated.
Adding a few more on Cc
--
Best regards,
Marek Vasut
ot; (and v5a).
>> The fact that it is denali is part of the documentation.
>>
>
> Let me think about this.
>
> Socionext bought two version of Denali IP,
> and we are now re-using the newer one (v5b) for several SoCs.
> Socionext has some more product lines other than Uniphier SoC family,
> perhaps wider re-use might happen in the future.
>
> At first, I included "uniphier" in compatible, but I am still wondering
> if such a specific string is good or not.
>
> Also, comments from Altera engineers are appreciated.
Adding a few more on Cc
--
Best regards,
Marek Vasut
On 12/02/2016 11:52 AM, Ricardo Ribalda Delgado wrote:
> Hi Marek
Hi,
> On Thu, Dec 1, 2016 at 7:11 PM, Marek Vasut <marek.va...@gmail.com> wrote:
>> On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote:
>>> Hi Marek
>>
>> Hi,
>>
>>> Thanks
On 12/02/2016 11:52 AM, Ricardo Ribalda Delgado wrote:
> Hi Marek
Hi,
> On Thu, Dec 1, 2016 at 7:11 PM, Marek Vasut wrote:
>> On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote:
>>> Hi Marek
>>
>> Hi,
>>
>>> Thanks for your review
>>&g
On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote:
> Hi Marek
Hi,
> Thanks for your review
>
> On Thu, Dec 1, 2016 at 5:05 PM, Marek Vasut <marek.va...@gmail.com> wrote:
>>
>> On 11/24/2016 05:56 PM, Ricardo Ribalda Delgado wrote:
>
>>> +#
On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote:
> Hi Marek
Hi,
> Thanks for your review
>
> On Thu, Dec 1, 2016 at 5:05 PM, Marek Vasut wrote:
>>
>> On 11/24/2016 05:56 PM, Ricardo Ribalda Delgado wrote:
>
>>> +#define
On 12/01/2016 07:14 PM, Brian Norris wrote:
> On Thu, Dec 01, 2016 at 04:39:23PM +0100, Marek Vasut wrote:
>> On 11/29/2016 09:12 AM, Sandeep Jain wrote:
>>> On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrote:
>>>> On 11/03/2016 12:34 PM, Sandeep Jain wro
On 12/01/2016 07:14 PM, Brian Norris wrote:
> On Thu, Dec 01, 2016 at 04:39:23PM +0100, Marek Vasut wrote:
>> On 11/29/2016 09:12 AM, Sandeep Jain wrote:
>>> On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrote:
>>>> On 11/03/2016 12:34 PM, Sandeep Jain wro
Cyrille Pitchen <cyrille.pitc...@atmel.com>
> ---
[...]
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
--
Best regards,
Marek Vasut
vice has one.
>
> Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
--
Best regards,
Marek Vasut
iver exposes a single read-only MTD device but with a module parameter
> "writeable=1" the MTD device can be made read-write which makes it possible
> to upgrade BIOS directly from Linux.
>
> Signed-off-by: Mika Westerberg
> Acked-by: Cyrille Pitchen
> ---
[...]
Revi
vice has one.
>
> Signed-off-by: Mika Westerberg
> Acked-by: Lee Jones
Reviewed-by: Marek Vasut
--
Best regards,
Marek Vasut
de */
> + if (val & XSR_PAGESIZE) {
> + nor->page_size = (nor->page_size == 264) ? 256 : 512;
264 is due to some ECC ?
> + nor->mtd.writebufsize = nor->page_size;
> + nor->mtd.size = 8 * nor->page_size * info->n_sectors;
> + nor->mtd.erasesize = 8 * nor->page_size;
> + } else {
> + nor->flags |= SNOR_F_S3AN_ADDR_DEFAULT;
> + }
> +
> + return 0;
> +}
[...]
--
Best regards,
Marek Vasut
_OP_XPP;
> + nor->read_opcode = SPINOR_OP_READ;
> + nor->flags |= SNOR_F_NO_OP_CHIP_ERASE;
> +
> + /* Flash in Power of 2 mode */
> + if (val & XSR_PAGESIZE) {
> + nor->page_size = (nor->page_size == 264) ? 256 : 512;
264 is due to some ECC ?
On 11/29/2016 09:12 AM, Sandeep Jain wrote:
> Dear Maintainers,
>This patch is already reviewed twice with no issues.
> Requesting your attention for patch merge.
>
> Thanks & Regards,
> Sandeep Jain
>
> On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrot
On 11/29/2016 09:12 AM, Sandeep Jain wrote:
> Dear Maintainers,
>This patch is already reviewed twice with no issues.
> Requesting your attention for patch merge.
>
> Thanks & Regards,
> Sandeep Jain
>
> On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrot
}
> +
> + status = readl(ispi->base + HSFSTS_CTL);
> + if (status & HSFSTS_CTL_FCERR)
> + ret = -EIO;
> + else if (status & HSFSTS_CTL_AEL)
> + ret = -EACCES;
> +
> + if (ret < 0) {
> + dev_err(ispi->dev, "write error: %llx: %#x\n", to,
> + status);
> + return ret;
> + }
> +
> + len -= block_size;
> + to += block_size;
> + retlen += block_size;
> + write_buf += block_size;
> + }
> +
> + return retlen;
> +}
[...]
--
Best regards,
Marek Vasut
status = readl(ispi->base + HSFSTS_CTL);
> + if (status & HSFSTS_CTL_FCERR)
> + ret = -EIO;
> + else if (status & HSFSTS_CTL_AEL)
> + ret = -EACCES;
> +
> + if (ret < 0) {
> + dev_err(ispi->dev, "write error: %llx: %#x\n", to,
> + status);
> + return ret;
> + }
> +
> + len -= block_size;
> + to += block_size;
> + retlen += block_size;
> + write_buf += block_size;
> + }
> +
> + return retlen;
> +}
[...]
--
Best regards,
Marek Vasut
vice briefly in order to read BAR 0 of the SPI host controller.
>
> Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Acked-by: Marek Vasut <marek.va...@gmail.com>
--
Best regards,
Marek Vasut
pset].spi_type;
> +
> + switch (info->type) {
> + case INTEL_SPI_BYT:
> + pci_read_config_dword(dev, SPIBASE_BYT, _base);
> + if (spi_base & SPIBASE_BYT_EN) {
> + res->start = spi_base & ~(SPIBASE_BYT_SZ - 1);
> + res->end = res->start + SPIBASE_BYT_SZ - 1;
> + }
> + break;
> +
> + case INTEL_SPI_LPT:
> + pci_read_config_dword(dev, RCBABASE, );
> + if (rcba & 1) {
> + spi_base = rcba & ~(SPIBASE_LPT_SZ - 1);
Use the round_down() macro here ?
> + res->start = spi_base + SPIBASE_LPT;
> + res->end = res->start + SPIBASE_LPT_SZ - 1;
[...]
--
Best regards,
Marek Vasut
vice briefly in order to read BAR 0 of the SPI host controller.
>
> Signed-off-by: Mika Westerberg
> Acked-by: Lee Jones
Acked-by: Marek Vasut
--
Best regards,
Marek Vasut
SPI_BYT:
> + pci_read_config_dword(dev, SPIBASE_BYT, _base);
> + if (spi_base & SPIBASE_BYT_EN) {
> + res->start = spi_base & ~(SPIBASE_BYT_SZ - 1);
> + res->end = res->start + SPIBASE_BYT_SZ - 1;
> + }
> + break;
> +
> + case INTEL_SPI_LPT:
> + pci_read_config_dword(dev, RCBABASE, );
> + if (rcba & 1) {
> + spi_base = rcba & ~(SPIBASE_LPT_SZ - 1);
Use the round_down() macro here ?
> + res->start = spi_base + SPIBASE_LPT;
> + res->end = res->start + SPIBASE_LPT_SZ - 1;
[...]
--
Best regards,
Marek Vasut
].virt) {
> printk("Failed to ioremap_nocache\n");
> + for (j = 0; j < i; j++) {
> + if (mymtd[j]) {
> + map_destroy(mymtd[j]);
> +
) {
> printk("Failed to ioremap_nocache\n");
> + for (j = 0; j < i; j++) {
> + if (mymtd[j]) {
> + map_destroy(mymtd[j]);
> + iounmap(sc520cd
x-kernel@vger.kernel.org
> Cc: linux-f...@vger.kernel.org
Acked-by: Marek Vasut <ma...@denx.de>
> ---
> Hi all,
>
> Lately we've fallen behind a bit on reviewing patches lately.
>
> 'Behind the scenes', Alan has worked on getting a git tree setup
> for
On 11/21/2016 10:49 PM, Moritz Fischer wrote:
> Add myself as co-maintainer to fpga mgr framework.
>
> Signed-off-by: Moritz Fischer
> Cc: Alan Tull
> Cc: Greg Kroah-Hartman
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-f...@vger.kernel.org
Acked-by: Marek Vasut
> -
: Luis Henriques <hen...@camandro.org>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
> drivers/mtd/maps/sc520cdp.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c
> index 093edd5
ff-by: Luis Henriques
Reviewed-by: Marek Vasut
> ---
> drivers/mtd/maps/sc520cdp.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c
> index 093edd51bdc7..7a27ed345d0d 100644
> --- a/drivers/mtd/maps/sc52
.txt| 21
>>>> +
>>>> 1 file changed, 21 insertions(+)
>>>> create mode 100644
>>>> Documentation/devicetree/bindings/fpga/lattice-ice40-fpga-mgr.txt
>>>
>>> Acked-by: Rob Herring <r...@kernel.org&
>> 1 file changed, 21 insertions(+)
>>>> create mode 100644
>>>> Documentation/devicetree/bindings/fpga/lattice-ice40-fpga-mgr.txt
>>>
>>> Acked-by: Rob Herring
>>>
>>
>> Acked-by: Alan Tull
> Acked-by: Moritz Fischer
Acked-by: Marek Vasut
--
Best regards,
Marek Vasut
On 11/18/2016 09:42 AM, Masahiro Yamada wrote:
> Hi Marek,
>
>
> 2016-11-13 6:35 GMT+09:00 Marek Vasut <marek.va...@gmail.com>:
>> On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
>>> As far as I understood from the Kconfig menu deleted by commit
>>> be7
On 11/18/2016 09:42 AM, Masahiro Yamada wrote:
> Hi Marek,
>
>
> 2016-11-13 6:35 GMT+09:00 Marek Vasut :
>> On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
>>> As far as I understood from the Kconfig menu deleted by commit
>>> be7f39c5ecf5 ("Stagi
On 11/16/2016 09:56 PM, Sudip Mukherjee wrote:
> On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote:
>> On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
>>> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>>>> On 11/16/2016 12:09 AM, Sudip Mukherjee w
On 11/16/2016 09:56 PM, Sudip Mukherjee wrote:
> On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote:
>> On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
>>> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>>>> On 11/16/2016 12:09 AM, Sudip Mukherjee w
On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>>> a pointer on success. They do
On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>>> a pointer on success. They do
> @@ -550,7 +548,6 @@ static int nandsim_debugfs_create(struct nandsim *dev)
>
> out_remove:
> debugfs_remove_recursive(dbg->dfs_root);
> - err = dent ? PTR_ERR(dent) : -ENODEV;
> return err;
> }
>
>
--
Best regards,
Marek Vasut
nandsim_debugfs_create(struct nandsim *dev)
>
> out_remove:
> debugfs_remove_recursive(dbg->dfs_root);
> - err = dent ? PTR_ERR(dent) : -ENODEV;
> return err;
> }
>
>
--
Best regards,
Marek Vasut
On 11/15/2016 06:06 PM, Ksenija Stanojević wrote:
> On Mon, Nov 14, 2016 at 7:43 PM, Marek Vasut <ma...@denx.de> wrote:
>> On 11/02/2016 08:38 AM, Ksenija Stanojevic wrote:
>>> Add core files for low resolution analog-to-digital converter (mxs-lradc)
>>> MFD drive
On 11/15/2016 06:06 PM, Ksenija Stanojević wrote:
> On Mon, Nov 14, 2016 at 7:43 PM, Marek Vasut wrote:
>> On 11/02/2016 08:38 AM, Ksenija Stanojevic wrote:
>>> Add core files for low resolution analog-to-digital converter (mxs-lradc)
>>> MFD driver.
>>>
&
lt;ksenija.stanoje...@gmail.com>
> Reviewed-by: Jonathan Cameron <ji...@kernel.org>
> ---
Shouldn't you squash this and 4/5 , in which case this would result in a
move ?
--
Best regards,
Marek Vasut
iewed-by: Jonathan Cameron
> ---
Shouldn't you squash this and 4/5 , in which case this would result in a
move ?
--
Best regards,
Marek Vasut
xs-lradc.o
> diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c
> new file mode 100644
> index 000..ffc8f2e
> --- /dev/null
> +++ b/drivers/mfd/mxs-lradc.c
> @@ -0,0 +1,249 @@
> +/*
> + * Freescale MXS Low Resolution Analog-to-Digital Converter driver
> + *
ivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c
> new file mode 100644
> index 000..ffc8f2e
> --- /dev/null
> +++ b/drivers/mfd/mxs-lradc.c
> @@ -0,0 +1,249 @@
> +/*
> + * Freescale MXS Low Resolution Analog-to-Digital Converter driver
> + *
> + * Copyright (c)
On 11/09/2016 03:08 AM, Masahiro Yamada wrote:
> I hope this will make the code a little more readable.
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
>
> drivers/mtd/mtdcore.c | 4 ++--
&
ionext.com>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
>
> drivers/mtd/nand/denali.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 51ddb84..d6f1b29 100644
> --- a/drive
On 11/09/2016 03:08 AM, Masahiro Yamada wrote:
> I hope this will make the code a little more readable.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
> ---
>
> drivers/mtd/mtdcore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
&g
On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The interrupt handler is setup in denali_init(), not in
> denali_drv_init(). This comment is false.
>
> Such a comment adds no value, so just delete it instead of move.
>
> Signed-off-by: Masahiro Yamada
Review
tk"). Since then, this has been only initialized, but
> never referenced.
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
>
> drivers/mtd/nand/denali.c | 2 --
> drivers/mtd/nand/
..@socionext.com>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
>
> drivers/mtd/nand/denali.c | 8
> drivers/mtd/nand/denali.h | 2 --
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> ind
mada <yamada.masah...@socionext.com>
Reviewed-by: Marek Vasut <marek.va...@gmail.com>
> ---
>
> drivers/mtd/nand/denali.c | 29 -
> drivers/mtd/nand/denali.h | 9 -
> 2 files changed, 38 deletions(-)
>
> diff --git a/driver
On 11/09/2016 03:08 AM, Masahiro Yamada wrote:
> There is no need to initialize oobregion and section since they will
> be filled by mtd_ooblayout_find_region().
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
Reviewed-by: Marek Vasut <
801 - 900 of 1712 matches
Mail list logo
