Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Marko Katić
On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux wrote: > On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: >> - if (gpio_is_valid(lcd->gpio_backlight_cont)) >> - gpio_set_value(lcd->gpio_backlight_cont, cont); >> + if

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Marko Katić
On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: - if (gpio_is_valid(lcd-gpio_backlight_cont)) - gpio_set_value(lcd-gpio_backlight_cont, cont); + if

Re: [PATCH v3] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-04 Thread Marko Katić
On Tue, Dec 4, 2012 at 6:28 AM, Jingoo Han wrote: > From: Marko Katic > > Changing backlight intensity on an Akita (Sharp Zaurus C-1000) > triggers WARN_ON message: > > WARNING: at drivers/gpio/gpiolib.c:1672 __gpio_set_value+0x38/0xa4() > Modules linked in: > Backtrace: > []

Re: [PATCH v3] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-04 Thread Marko Katić
On Tue, Dec 4, 2012 at 6:28 AM, Jingoo Han jg1@samsung.com wrote: From: Marko Katic drom...@gmail.com Changing backlight intensity on an Akita (Sharp Zaurus C-1000) triggers WARN_ON message: WARNING: at drivers/gpio/gpiolib.c:1672 __gpio_set_value+0x38/0xa4() Modules linked in:

Re: [PATCH] backlight: corgi_lcd: Fix WARN_ON() when calling corgi_bl_set_intensity.

2012-11-29 Thread Marko Katić
On Thu, Nov 29, 2012 at 6:30 AM, Jingoo Han wrote: > On Thursday, November 29, 2012 6:47 AM, Marko Katic wrote >> Subject: [PATCH] backlight: corgi_lcd: Fix WARN_ON() when calling >> corgi_bl_set_intensity. > > CC'ed Andrew Morton. > > > Hi Marko Katic, > The commit subject and commit message

Re: [PATCH] backlight: corgi_lcd: Fix WARN_ON() when calling corgi_bl_set_intensity.

2012-11-29 Thread Marko Katić
On Thu, Nov 29, 2012 at 6:30 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, November 29, 2012 6:47 AM, Marko Katic wrote Subject: [PATCH] backlight: corgi_lcd: Fix WARN_ON() when calling corgi_bl_set_intensity. CC'ed Andrew Morton. Hi Marko Katic, The commit subject and commit