Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Martin Sebor
On 3/25/21 3:53 AM, Arnd Bergmann wrote: On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: Clearly something is wrong here, but I can't quite figure out what. Changing the array size to 16 bytes avoids the warning, but is probably the wrong solution here. Ugh. drm_dp_channel_eq_ok() does not

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Martin Sebor
On 3/22/21 2:29 PM, Ingo Molnar wrote: * Arnd Bergmann wrote: From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time c

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-11 Thread Martin Sebor
On 2/9/19 5:31 AM, Miguel Ojeda wrote: On Sat, Feb 9, 2019 at 12:26 PM Ard Biesheuvel wrote: On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda wrote: It also affects the optimizer in two different ways AFAIK: * For the function itself, it gets optimized for size instead of speed. * For calle

Re: Build regressions/improvements in v4.18-rc7

2018-07-31 Thread Martin Sebor
a reduced test case and when building *outside of the kernel*, the warnings appear again in 8.1/8.2/current 9.0, see [2] below. I guess that is a result of the warnings requiring some optimization passes enabled. Martin Sebor (CC'd) fixed some false positives from what I can see in gcc'

Re: [PATCH V2] xfs: fix string handling in get/set functions

2018-06-05 Thread Martin Sebor
rect sizeof() argument here copies the extra character. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85602 Fixes: f7664b31975b ("xfs: implement online get/set fs label") Cc: Eric Sandeen Cc: Martin Sebor Signed-off-by: Arnd Bergmann Signed-off-by: Eric Sandeen --- diff --git a/fs/

Re: [PATCH] test_rhashtable: avoid gcc-8 -Wformat-overflow warning

2018-03-13 Thread Martin Sebor
problem, and the simplest workaround. Fixes: 499ac3b60f65 ("test_rhashtable: add test case for rhltable with duplicate objects") Cc: Martin Sebor Signed-off-by: Arnd Bergmann --- My patch is untested, please try it out before applying. --- lib/test_rhashtable.c | 9

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

2018-03-13 Thread Martin Sebor
Martin Sebor also asked me about this, he's the one that worked on the gcc code that introduced the warning. Sorry for not replying earlier. Maybe you can pass this to him? (maybe open a bug in gcc's bugzilla?) I've opened bug 84725 to extend attribute nonstring to the othe

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

2018-03-05 Thread Martin Sebor
functions, I would favor supporting the warning and the attribute for all the three types. [By the way, CC'ing Xiongfeng, Willy and Arnd, since they were involved in the example report; sorry guys!]. Martin Sebor also asked me about this, he's the one that worked on the gcc code tha