inish_open+0x31/0x40
[] do_last+0xa64/0x1190
[] path_openat+0xcd/0x670
[] do_filp_open+0x4d/0xb0
[] do_sys_open+0x13d/0x230
[] SyS_open+0x1e/0x20
Masaru Nomura (3):
gpu: drm: vmwgfx: Fix memory leak by adding drm_ht_remove()
gpu: drm: Remove unnecessary parameter from drm_ht_remo
vm_compat_shader_manager is only used for drm_ht_remove_item() within the
function.
As drm_ht_remove_item() does not need a paremeter drm_open_hash(> shaders),
vm_compat_shader_manager(*man) does not have to be passed to this function.
Signed-off-by: Masaru Nomura
---
drivers/gpu/drm/vmw
removed drm_open_hash from drm_ht_remove_item() as the parameter is
not used within the function.
Signed-off-by: Masaru Nomura
---
Please review this patch carefully. The reason the parameter is passed
might be some historical one or clarity of which drm_open_hash
we remove an item from
drm_ht_remove() should be called in vmw_compat_shader_man_destroy()
This is because memory was allocated for (>shaders)->table by
vmw_compat_shader_man_create() -> drm_ht_create()
but this memory is not freed when vmw_compat_shader_mager is destroied.
Signed-off-by: Masaru Nomura
---
removed drm_open_hash from drm_ht_remove_item() as the parameter is
not used within the function.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
Please review this patch carefully. The reason the parameter is passed
might be some historical one or clarity of which drm_open_hash
we remove
drm_ht_remove() should be called in vmw_compat_shader_man_destroy()
This is because memory was allocated for (man-shaders)-table by
vmw_compat_shader_man_create() - drm_ht_create()
but this memory is not freed when vmw_compat_shader_mager is destroied.
Signed-off-by: Masaru Nomura massa.nom
/0x230
[811f140e] SyS_open+0x1e/0x20
Masaru Nomura (3):
gpu: drm: vmwgfx: Fix memory leak by adding drm_ht_remove()
gpu: drm: Remove unnecessary parameter from drm_ht_remove_item()
gpu: drm: vmwgfx: Remove unnecessary parameter from
vmw_compat_shader_free()
drivers/gpu/drm
vm_compat_shader_manager is only used for drm_ht_remove_item() within the
function.
As drm_ht_remove_item() does not need a paremeter drm_open_hash(man- shaders),
vm_compat_shader_manager(*man) does not have to be passed to this function.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
> What _branch_ of that git tree did you make it against?
>
I did my work against
commit 4b660a7f5c8099d88d1a43d8ae138965112592c7
Thank you,
Masaru
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
Remove prohibited space between function name and
open parenthesis to meet kernel coding style.
Also fix indenting due to changes to keep readability.
-since v2:
None. This is the resend of v2 as v2 failed to apply
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd
Remove prohibited space between function name and
open parenthesis to meet kernel coding style.
Also fix indenting due to changes to keep readability.
-since v2:
None. This is the resend of v2 as v2 failed to apply
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet
What _branch_ of that git tree did you make it against?
I did my work against
commit 4b660a7f5c8099d88d1a43d8ae138965112592c7
Thank you,
Masaru
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Remove prohibited space between function name and open parenthesis
to meet kernel coding style. Also, fix indenting due to changes.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 230 ++--
1 file changed, 116 insertions(+), 114 deletions
Remove prohibited space between function name and open parenthesis
to meet kernel coding style. Also, fix indenting due to changes.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 230 ++--
1 file changed, 116
memset.
With this, others can notice warnings against memset
caused by checkpatch.pl and modify it easily.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 238 ++--
1 file changed, 119 insertions(+), 119 deletions(-)
diff --git a/drivers
memset.
With this, others can notice warnings against memset
caused by checkpatch.pl and modify it easily.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 238 ++--
1 file changed, 119 insertions(+), 119 deletions(-)
diff
>> - memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags
>> etc */
>> + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */
>
> It looks like this memset is unnecessary
> as it's already zeroed by LIBCFS_ALLOC->
>
Remove prohibited space between open parenthesis and
function name to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 226 ++--
1 file changed, 113 insertions(+), 113 deletions(-)
diff --git a/drivers/staging
Remove prohibited space and fix indenting of following parameters
of ksocknal_create_conn(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Remove prohibited space and fix line over 80 characters of
memset(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds
These patches fix warnings below in socklnd.c to meet coding style.
Also fix some indenting due to changes to keep readability.
WARNING: space prohibited between function name and open parenthesis '('
WARNING: line over 80 characters
Masaru Nomura (5):
staging: lustre: lnet: socklnd: Remove
Remove prohibited space and fix indenting of following parameters
of CDEBUG(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre
Remove prohibited space and fix indenting of following parameter
of ksocknal_get_peer_info(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
Remove prohibited space and fix indenting of following parameters
of CDEBUG(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove prohibited space and fix indenting of following parameter
of ksocknal_get_peer_info(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +++---
1 file changed, 3 insertions(+), 3 deletions
Remove prohibited space and fix indenting of following parameters
of ksocknal_create_conn(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions
Remove prohibited space and fix line over 80 characters of
memset(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
These patches fix warnings below in socklnd.c to meet coding style.
Also fix some indenting due to changes to keep readability.
WARNING: space prohibited between function name and open parenthesis '('
WARNING: line over 80 characters
Masaru Nomura (5):
staging: lustre: lnet: socklnd: Remove
Remove prohibited space between open parenthesis and
function name to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 226 ++--
1 file changed, 113 insertions(+), 113 deletions(-)
diff --git
- memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags
etc */
+ memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */
It looks like this memset is unnecessary
as it's already zeroed by LIBCFS_ALLOC-
LIBCFS_ALLOC_GFP-LIBCFS_ALLOC_POST-memset.
It
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c | 36
WARNING: line over 80 characters
WARNING: braces {} are not necessary for single statement blocks
Masaru Nomura (3):
staging: dgnc: Put else statements on the right line
staging: dgnc: dgnc_neo: Clean up if statement
staging: dgnc: Remove extra curly braces
drivers/staging/dgnc/dgnc_neo.c | 112
Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 60 -
drivers/staging/dgnc/dgnc_tty.c | 110 ++-
2 files
Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c
Hi Dan,
Thank you for your detailed explanation!
> This isn't the right way. Write it like this:
>
> if ((ch->ch_digi.digi_flags & CTSPACE) ||
> (ch->ch_digi.digi_flags & RTSPACE) ||
> (ch->ch_c_cflag & CRTSCTS) ||
> !(ch->ch_digi.digi_flags &
Add a blank line after declarations to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/unisys/visorutil/charqueue.c |2 ++
drivers/staging/unisys/visorutil/easyproc.c |6 ++
drivers/staging/unisys/visorutil/periodic_work.c |1 +
drivers
Remove unnecessary braces of if-else statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 20
drivers/staging/dgnc/dgnc_tty.c | 10 --
2 files changed, 12 insertions(+), 18
Fix line over 80 characters of if-condition part and also
indent the lines to tell the difference between the condition and
body of the if statement.
Then I think we can keep the readability and meet coding style
with this change.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc
Fix indenting of if statement in dgnc_neo.c so that an open brace
follows if-condition part to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c | 36
statement blocks
Masaru Nomura (4):
staging: dgnc: Fix indenting of if-else statement
staging: dgnc: dgnc_neo: Fix indenting of if statement
staging: dgnc: dgnc_neo: Fix conditional part of if statement
staging: dgnc: Remove unnecessary braces
drivers/staging/dgnc/dgnc_neo.c | 67
statement blocks
Masaru Nomura (4):
staging: dgnc: Fix indenting of if-else statement
staging: dgnc: dgnc_neo: Fix indenting of if statement
staging: dgnc: dgnc_neo: Fix conditional part of if statement
staging: dgnc: Remove unnecessary braces
drivers/staging/dgnc/dgnc_neo.c | 67
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c
Fix indenting of if statement in dgnc_neo.c so that an open brace
follows if-condition part to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
Remove unnecessary braces of if-else statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 20
drivers/staging/dgnc/dgnc_tty.c | 10 --
2 files changed, 12
Fix line over 80 characters of if-condition part and also
indent the lines to tell the difference between the condition and
body of the if statement.
Then I think we can keep the readability and meet coding style
with this change.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers
Add a blank line after declarations to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/unisys/visorutil/charqueue.c |2 ++
drivers/staging/unisys/visorutil/easyproc.c |6 ++
drivers/staging/unisys/visorutil/periodic_work.c
Hi Dan,
Thank you for your detailed explanation!
This isn't the right way. Write it like this:
if ((ch-ch_digi.digi_flags CTSPACE) ||
(ch-ch_digi.digi_flags RTSPACE) ||
(ch-ch_c_cflag CRTSCTS) ||
!(ch-ch_digi.digi_flags DIGI_FORCEDCD) ||
WARNING: line over 80 characters
WARNING: braces {} are not necessary for single statement blocks
Masaru Nomura (3):
staging: dgnc: Put else statements on the right line
staging: dgnc: dgnc_neo: Clean up if statement
staging: dgnc: Remove extra curly braces
drivers/staging/dgnc/dgnc_neo.c | 112
Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 60 -
drivers/staging/dgnc/dgnc_tty.c | 110
Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c
Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
Add a required space before an open parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
Add a required space before an open parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b
Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
Remove unnecessary brackets from return statements in socklnd.c,
socklnd.h, socklnd_cb.c and socklnd_lib-linux.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +-
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|4
Remove unnecessary line continuation '\' in socklnd.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds
Remove unnecessary line continuation '\' in socklnd.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging
Remove unnecessary brackets from return statements in socklnd.c,
socklnd.h, socklnd_cb.c and socklnd_lib-linux.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +-
.../staging/lustre/lnet/klnds
Fixed indenting of if statement in socklnd.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
b/drivers
Added a required space before open brace and parenthsis
in socklnd.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds
Remove unnecessary brackets from return statements in socklnd.c
to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/lustre
Remove unnecessary brackets from return statements in socklnd.c
to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git
Added a required space before open brace and parenthsis
in socklnd.c to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Fixed indenting of if statement in socklnd.c to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd
66 matches
Mail list logo
