On 26 March 2015 at 23:15, Andrew Morton wrote:
> On Thu, 26 Mar 2015 14:58:40 -0700 Joe Perches wrote:
>
>> > I'd have thought that a function-wide
>> > __attribute__((__string_section__(foo))
>> > wouldn't be a ton of work to implement.
>>
>> Maybe not.
>>
>> Could some future version of gc
On 26 March 2015 at 22:40, Andrew Morton wrote:
> On Thu, 26 Mar 2015 21:49:06 +0100 Mathias Krause
> wrote:
>
>> Andrew, what's your opinion on such a patch set? Do you too think it's
>> useful? Or do you share Ingo's fear about the additional maintena
On 26 March 2015 at 18:53, Joe Perches wrote:
> On Thu, 2015-03-26 at 17:37 +0100, Mathias Krause wrote:
>> On 26 March 2015 at 17:13, Joe Perches wrote:
>> > On Thu, 2015-03-26 at 13:40 +0100, Mason wrote:
>> >> On 25/03/2015 19:01, Joe Perches wrote:
>> &g
On 26 March 2015 at 17:13, Joe Perches wrote:
> On Thu, 2015-03-26 at 13:40 +0100, Mason wrote:
>> On 25/03/2015 19:01, Joe Perches wrote:
>> > On Wed, 2015-03-25 at 18:56 +0100, Mason wrote:
>> >
>> >> AFAIU, functions only used at system init are tagged __init to have
>> >> the linker store them
On 27 November 2014 at 16:41, Дениска-редиска wrote:
> well, I will try to disable CONFIG_PAX_MEMORY_SANITIZE.
> Will take some time to make sure that this resolve the issue
That should fix the issue for you. You could also try to add
"pax_sanitize_slab=0" to the kernel command line to disable sl
fix at every level, correctly rejecting "vfat":
>
> net-pf-38
> algif-hash
> crypto-vfat(blowfish)
> crypto-vfat(blowfish)-all
> crypto-vfat
>
> Reported-by: Mathias Krause
> Signed-off-by: Kees Cook
> ---
> crypto/algapi.
fix at every level, correctly rejecting "vfat":
>
> net-pf-38
> algif-hash
> crypto-vfat(blowfish)
> crypto-vfat(blowfish)-all
> crypto-vfat
>
> Reported-by: Mathias Krause
> Signed-off-by: Kees Cook
> ---
> crypto/algapi.c | 4
On 21 November 2014 02:05, Kees Cook wrote:
> This prefixes all crypto module loading with "crypto-" so we never run
> the risk of exposing module auto-loading to userspace via a crypto API,
> as demonstrated by Mathias Krause:
>
> https://lkml.org/lkml/2013/3/4/70
>
On 18 November 2014 01:45, Kees Cook wrote:
> On Mon, Nov 17, 2014 at 3:20 PM, Mathias Krause
> wrote:
>> On 17 November 2014 21:02, Kees Cook wrote:
>>> This prefixes all crypto module loading with "crypto-" so we never run
>>> the risk of exposin
On 17 November 2014 21:02, Kees Cook wrote:
> This prefixes all crypto module loading with "crypto-" so we never run
> the risk of exposing module auto-loading to userspace via a crypto API,
> as demonstrated by Mathias Krause:
>
> https://lkml.org/lkml/2013/3/4/70
>
On 17 November 2014 16:09, Herbert Xu wrote:
> On Fri, Nov 14, 2014 at 01:34:59PM -0800, Kees Cook wrote:
>> This prefixes all crypto module loading with "crypto-" so we never run
>> the risk of exposing module auto-loading to userspace via a crypto API,
>> as
On 29 October 2014 15:22, Matt Fleming wrote:
> On Tue, 28 Oct, at 08:48:23PM, Mathias Krause wrote:
>> On 28 October 2014 19:57, Borislav Petkov wrote:
>> > [...]
>> >
>> > Ok, thanks for refreshing this for me, your patch is good, so
>> >
>>
On 29 October 2014 15:22, Matt Fleming wrote:
> On Tue, 28 Oct, at 08:48:23PM, Mathias Krause wrote:
>> On 28 October 2014 19:57, Borislav Petkov wrote:
>> > [...]
>> >
>> > Ok, thanks for refreshing this for me, your patch is good, so
>> >
>>
On 29 October 2014 15:20, Matt Fleming wrote:
> On Tue, 28 Oct, at 10:14:25PM, Mathias Krause wrote:
>>
>> Mapping the kernel into the EFI page table may help ;) Then the
>> kernel's #PF handler would be present and able to print a register
>> dump, at least.
>
On 28 October 2014 23:07, Borislav Petkov wrote:
> On Tue, Oct 28, 2014 at 10:49:36PM +0100, Mathias Krause wrote:
>> Sync only data or kernel code, too?
>
> Data only should be enough.
No, not really. This is why:
1/ When setting up the virtual mapping via a call to the
SetVi
On 28 October 2014 22:26, Borislav Petkov wrote:
> On Tue, Oct 28, 2014 at 10:14:25PM +0100, Mathias Krause wrote:
>> Oh, well. Have fun with that! I would take the "map kernel into EFI
>> page table" route instead. ;)
>
> Actually, I want to try to keep them co
On 28 October 2014 21:13, Borislav Petkov wrote:
> On Tue, Oct 28, 2014 at 08:48:23PM +0100, Mathias Krause wrote:
>> I tried so too but failed early as well. I tried putting the EFI
>> virtual mappings not in trampoline_pgd[511] but trampoline_pgd[510].
>> However, that d
On 28 October 2014 19:57, Borislav Petkov wrote:
> [...]
>
> Ok, thanks for refreshing this for me, your patch is good, so
>
> Acked-by: Borislav Petkov
Thanks. But as you said, the EFI mappings shouldn't be in the kernel's
page table in the first place, so I'd rather see a patch doing that
inst
Commit-ID: 6891c4509c792209c44ced55a60f13954cb50ef4
Gitweb: http://git.kernel.org/tip/6891c4509c792209c44ced55a60f13954cb50ef4
Author: Mathias Krause
AuthorDate: Sat, 4 Oct 2014 23:06:39 +0200
Committer: Thomas Gleixner
CommitDate: Sat, 25 Oct 2014 10:43:15 +0200
posix-timers: Fix
On Thu, Oct 09, 2014 at 12:26:19AM +0200, Borislav Petkov wrote:
> On Wed, Oct 08, 2014 at 11:58:20PM +0200, Mathias Krause wrote:
> > Well, that is only partly correct. The call chain in efi_map_regions()
> > [ -> efi_map_region() -> __map_region() -> kernel_map_pages_i
On 8 October 2014 17:17, Borislav Petkov wrote:
> On Tue, Oct 07, 2014 at 07:07:48PM +0200, Mathias Krause wrote:
>> What you can see here are actually the EFI runtime service mappings, not
>> the ESP fix area. Check the addresses and compare them. You should find
>> similar
On Tue, Oct 07, 2014 at 05:01:32PM +0200, Borislav Petkov wrote:
> On Fri, Oct 03, 2014 at 02:47:07PM +0100, Matt Fleming wrote:
> > Looks OK to me. Borislav?
>
> It needs more work AFAICT because with it, espfix area gets cut off
> prematurely:
>
I don't think so. See below...
> ...
> [0.1
On 5 October 2014 23:06, Oleg Nesterov wrote:
> On 10/04, Mathias Krause wrote:
>>
>> If userland creates a timer without specifying a sigevent info, we'll
>> create one ourself, using a stack local variable. Particularly will we
>> use the timer ID as sival_in
stack info leak.
Found in the PaX patch, written by the PaX Team.
Fixes: 5a9fa7307285 ("posix-timers: kill ->it_sigev_signo and...")
Signed-off-by: Mathias Krause
Cc: Oleg Nesterov
Cc: Brad Spengler
Cc: PaX Team
Cc: # v2.6.28+
---
kernel/time/posix-timers.c |1 +
1 file c
On 26 September 2014 11:25, Ingo Molnar wrote:
>
> * Mathias Krause wrote:
>
>> On 24 September 2014 09:45, Ingo Molnar wrote:
>> > * Mathias Krause wrote:
>> >> On 21 September 2014 21:49, Arjan van de Ven
>> >> wrote:
&g
On 24 September 2014 09:45, Ingo Molnar wrote:
> * Mathias Krause wrote:
>> On 21 September 2014 21:49, Arjan van de Ven wrote:
>> > On 9/21/2014 8:26 AM, Mathias Krause wrote:
>> >>
>> >> - if (pr & _PAGE_PCD)
>> >>
On 22 September 2014 22:34, Bjorn Helgaas wrote:
> [+cc x86 folks]
>
> On Mon, Sep 22, 2014 at 02:27:48PM -0600, Bjorn Helgaas wrote:
>> On Mon, Aug 25, 2014 at 11:26:34PM +0200, Mathias Krause wrote:
>> > Hi Bjorn,
>> >
>> > [...]
>> >
>>
On 21 September 2014 21:49, Arjan van de Ven wrote:
> On 9/21/2014 8:26 AM, Mathias Krause wrote:
>>
>> - if (pr & _PAGE_PCD)
>> - pt_dump_cont_printf(m, dmsg, "PCD ");
>> - else
>> -
tween the
espfix area and the high kernel memory mapping. Due to the enforced
limitation for the espfix area, the EFI mappings won't be printed in the
page table dump.
To make the ESP runtime service mappings visible again, provide them a
dedicated entry.
Signed-off-by: Mathias Krause
Cc: Ma
when CONFIG_X86_ESPFIX64 is set (patch 1).
Please apply!
Changelog:
v2:
- re-add pt_dump prefix to macros (and ignore checkpatch warnings) as
suggested by Ingo
Mathias Krause (3):
x86, ptdump: Add section for EFI runtime services
x86, ptdump: Simplify page flag evaluation code
x86, ptdump
common 'do ... while(0)' pattern instead of a compound statement
expression. We don't need no expression, just the statement.
Last, but not least, fix a few checkpatch warnings for the lines
touched.
Signed-off-by: Mathias Krause
Cc: Arjan van de Ven
Cc: H. Peter Anvin
---
v2: -
,
_PAGE_RW and _PAGE_NX throughout the page table walk and take them into
account when printing a page table entry's flags.
Signed-off-by: Mathias Krause
Cc: Arjan van de Ven
Cc: H. Peter Anvin
---
The kernel currently does not do such a thing as having a parent page
table entry having stricter flag
,
_PAGE_RW and _PAGE_NX throughout the page table walk and take them into
account when printing a page table entry's flags.
Signed-off-by: Mathias Krause
Cc: Arjan van de Ven
Cc: H. Peter Anvin
---
The kernel currently does not do such a thing as having a parent page
table entry having stricter flag
when CONFIG_X86_ESPFIX64 is set (patch 1).
Please apply!
Mathias Krause (3):
x86, ptdump: Add section for EFI runtime services
x86, ptdump: Simplify page flag evaluation code
x86, ptdump: Take parent page flags into account
arch/x86/include/asm/pgtable_64_types.h |2 +
arch/x86/mm
common 'do ... while(0)' pattern instead of a compound statement
expression. We don't need no expression, just the statement.
Last, but not least, fix the checkpatch warnings for the lines touched.
Signed-off-by: Mathias Krause
Cc: Arjan van de Ven
Cc: H. Peter Anvin
---
arch
tween the
espfix area and the high kernel memory mapping. Due to the enforced
limitation for the espfix area, the EFI mappings won't be printed in the
page table dump.
To make the ESP runtime service mappings visible again, provide them a
dedicated entry.
Signed-off-by: Mathias Krause
Cc: Ma
Commit-ID: 066ce64c7e867e95e5fee7c5f6b852710486392a
Gitweb: http://git.kernel.org/tip/066ce64c7e867e95e5fee7c5f6b852710486392a
Author: Mathias Krause
AuthorDate: Tue, 26 Aug 2014 18:49:45 +0200
Committer: Ingo Molnar
CommitDate: Tue, 9 Sep 2014 06:53:06 +0200
perf/x86/intel: Mark
Commit-ID: 8a5a5d1530d55e367ef29c80946d0274717617bb
Gitweb: http://git.kernel.org/tip/8a5a5d1530d55e367ef29c80946d0274717617bb
Author: Mathias Krause
AuthorDate: Sun, 7 Sep 2014 20:30:29 +0200
Committer: H. Peter Anvin
CommitDate: Mon, 8 Sep 2014 11:57:34 -0700
x86-64, ptdump: Mark
We should classify the espfix area as such only if we actually have
enabled the corresponding option. Otherwise the page table dump might
look confusing.
Signed-off-by: Mathias Krause
Cc: Arjan van de Ven
Cc: H. Peter Anvin
---
arch/x86/mm/dump_pagetables.c |4
1 file changed, 4
On 26 August 2014 18:49, Mathias Krause wrote:
> A few of the initialization functions are missing the __init annotation.
> Fix this and thereby allow ~680 additional bytes of code to be released
> after initialization.
>
> Signed-off-by: Mathias Krause
> ---
>
On 22 August 2014 10:24, Ingo Molnar wrote:
>
> * Mathias Krause wrote:
>
>> > It feels like a burdensome hack that kernel developers are
>> > forced to use different printing facilities, depending on
>> > the life cycle of a method. We want to simplify ini
A few of the initialization functions are missing the __init annotation.
Fix this and thereby allow ~680 additional bytes of code to be released
after initialization.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/cpu/perf_event_intel_ds.c |2 +-
arch/x86/kernel/cpu
Hi Rusty,
the following two patches lead to a small size reduction of modpost.
Please apply!
Thanks,
Mathias
Mathias Krause (2):
modpost: reduce visibility of symbols and constify r/o arrays
modpost: simplify file name generation of *.mod.c files
scripts/mod/modpost.c | 25
dec hex filename
513812640 12416 66437 10385 scripts/mod/modpost.old
517652224 12416 66405 10365 scripts/mod/modpost.new
Signed-off-by: Mathias Krause
---
...checkpatch warnings grossly ignored to comply to the coding style of
modpost.c
scripts/mod/modpost.c |
1030d scripts/mod/modpost.new
Signed-off-by: Mathias Krause
---
scripts/mod/modpost.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index c2ebdc788f..3b405c726e 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
On 21 August 2014 18:25, Sam Ravnborg wrote:
> On Thu, Aug 21, 2014 at 02:23:03PM +0200, Mathias Krause wrote:
>> This is v3 of the patch series initially posted here:
>>
>> https://lkml.org/lkml/2014/6/22/149
>>
>> This series tries to address the prob
On 21 August 2014 14:57, Ingo Molnar wrote:
>
> * Mathias Krause wrote:
>
>> This is v3 of the patch series initially posted here:
>>
>> https://lkml.org/lkml/2014/6/22/149
>>
>> This series tries to address the problem of dangling strings of __init
>
Add macros to be able to mark string literals used in __init / __exit
functions.
Signed-off-by: Mathias Krause
---
v2: - use a better code example
---
include/linux/init.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/linux/init.h b/include/linux/init.h
the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
v2: handle all of arch/x86/kernel/acpi/
---
arch/x86/kernel/acpi/boot.c | 155 +++---
arch/x86/kernel/acpi/sleep.c | 17 +++--
2 files
The __init_str() / __exit_str() annotations create pseudo symbols.
Ignore them, they have no value for us.
Signed-off-by: Mathias Krause
---
scripts/kallsyms.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index dc7aa45e80
ymbol name pattern and provide better help texts in this case.
Signed-off-by: Mathias Krause
---
This patch generates quite a few checkpatch warnings related to strings
split across lines. But I choose to do so anyway to not make the code
differ from other fprintf()s in this file.
scripts/mod
(...), though. They might have some value beyond
debugging. Moreover, this ensures we won't loose any message by this
conversion.
This moves ~0.8 kB from the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/e820.c |
(...), though. They might have some value beyond
debugging. Moreover, this ensures we won't loose any message by this
conversion.
This moves ~0.5 kB from the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/setup.c |
early_printk() and panic() expect a format string as first argument.
Change early_panic() to pass on the message as string instead of a
format string.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/e820.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86
emove entries from dyndbg after initialization. But supporting that
scenario would require more work (and code), therefore not necessarily
justifying the memory savings.
Signed-off-by: Mathias Krause
---
v3: change description to mention modpost error catching
v2: introduce printk_init / printk_exit m
All implementations of x86_init.memory_setup() actually return a const
char *. Adjust the prototypes to reflect reality.
Also add the missing __init annotation to xen_auto_xlated_memory_setup().
Signed-off-by: Mathias Krause
---
arch/x86/include/asm/e820.h |4 ++--
arch/x86/include
4: arch agnostic, 5-9: x86 specific
- rebased to v3.17-rc1
v2:
- introduce printk_init / printk_exit macros (suggested by Joe)
- filter __init / __exit string pseudo symols in kallsyms
- more x86 related patches making use of the new helpers
Mathias Krause (9):
init.h: Add __init_str / __exit
On 22 July 2014 21:50, Mathias Krause wrote:
> On 9 July 2014 08:52, Mathias Krause wrote:
>> On 9 July 2014 00:48, Dave Airlie wrote:
>>> On 2 July 2014 16:15, Mathias Krause wrote:
>>>> On 15 June 2014 23:02, Mathias Krause wrote:
>>>>> The VFS
On 31 July 2014 00:11, Borislav Petkov wrote:
>
> On Wed, Jul 30, 2014 at 11:28:14PM +0200, Mathias Krause wrote:
> > Gah, CONFIG_AS_CRC32 gets defined as a preprocessor symbol only so
> > cannot be used in makefiles. So crc32c-pcl-intel-asm_64.S needs a
> > "#ifd
On Wed, Jul 30, 2014 at 11:19:37PM +0200, Mathias Krause wrote:
> On Wed, Jul 30, 2014 at 06:47:01PM +0200, Borislav Petkov wrote:
> > [...]
>
> This looks too complicated. We do have as-instr for exactly those kind
> of tests. And, in fact, looking at arch/x86/Makefile we alre
On Wed, Jul 30, 2014 at 06:47:01PM +0200, Borislav Petkov wrote:
> Building current kernel with some old toolchain (gcc 4.1.2 and gas 2.17)
> chokes with:
>
> arch/x86/crypto/crc32c-pcl-intel-asm_64.S: Assembler messages:
> arch/x86/crypto/crc32c-pcl-intel-asm_64.S:128: Error: no such instruction:
On 9 July 2014 08:52, Mathias Krause wrote:
> On 9 July 2014 00:48, Dave Airlie wrote:
>> On 2 July 2014 16:15, Mathias Krause wrote:
>>> On 15 June 2014 23:02, Mathias Krause wrote:
>>>> The VFS layer handles those in the very same way, if unset. No
On Tue, Jul 15, 2014 at 04:26:54PM -0700, Andrew Morton wrote:
> On Sat, 12 Jul 2014 16:43:24 +0200 Mathias Krause
> wrote:
>
> > This is v2 of the patch series initially posted here:
> >
> > https://lkml.org/lkml/2014/6/22/149
>
> That was a useful overall
On Tue, Jul 15, 2014 at 04:23:30PM -0700, Andrew Morton wrote:
> On Sat, 12 Jul 2014 16:43:26 +0200 Mathias Krause
> wrote:
>
> > The memory used for functions marked with __init will be released after
> > initialization, albeit static data referenced by such code
early_printk() and panic() expect a format string as first argument.
Change early_panic() to pass on the message as string instead of a
format string.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/e820.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86
the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
v2: handle all of arch/x86/kernel/acpi/
---
arch/x86/kernel/acpi/boot.c | 162 +++---
arch/x86/kernel/acpi/sleep.c | 17 +++--
2 files
All implementations of x86_init.memory_setup() actually return a const
char *. Adjust the prototypes to reflect reality.
Also add the missing __init annotation to xen_auto_xlated_memory_setup().
Signed-off-by: Mathias Krause
---
arch/x86/include/asm/e820.h |4 ++--
arch/x86/include
iles, pushing up the memory moved from .rodata
to .init.rodata to ~3 kB. This should free up a page after init for
almost any x86 system.
Comments?
Mathias Krause (8):
init.h: Add __init_str / __exit_str macros
printk: Provide pi_ / pe_ macros for __init / __exit
code
x86, acpi: Mark __
ovide appropriate p[ie]_debug() macros
for the CONFIG_DYNAMIC_DEBUG case as there is (currently) no way to
remove entries from dyndbg after initialization. But supporting that
scenario would require more work (and code), therefore not necessarily
justifying the memory savings.
Signed-off-by: Mathias K
(...), though. They might have some value beyond
debugging. Moreover, this ensures we won't loose any message by this
conversion.
This moves ~0.8 kB from the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/e820.c |
The __init_str() / __exit_str() annotations create pseudo symbols.
Ignore them, they have no value for us.
Signed-off-by: Mathias Krause
---
scripts/kallsyms.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index dc7aa45e80
(...), though. They might have some value beyond
debugging. Moreover, this ensures we won't loose any message by this
conversion.
This moves ~0.5 kB from the .rodata section to .init.rodata, marking it
for release after initialization.
Signed-off-by: Mathias Krause
---
arch/x86/kernel/setup.c |
Add macros to be able to mark string literals used in __init / __exit
functions.
Signed-off-by: Mathias Krause
---
v2: - use a better code example
---
include/linux/init.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/linux/init.h b/include/linux/init.h
On 9 July 2014 00:48, Dave Airlie wrote:
> On 2 July 2014 16:15, Mathias Krause wrote:
>> On 15 June 2014 23:02, Mathias Krause wrote:
>>> The VFS layer handles those in the very same way, if unset. No need for
>>> additional stubs.
>>>
>>> Signed-o
On 15 June 2014 23:02, Mathias Krause wrote:
> The VFS layer handles those in the very same way, if unset. No need for
> additional stubs.
>
> Signed-off-by: Mathias Krause
> Cc: Alexander Viro
> ---
> drivers/char/agp/frontend.c | 15 ---
> 1 fi
On 25 June 2014 09:48, Joe Perches wrote:
> On Wed, 2014-06-25 at 09:35 +0200, Rasmus Villemoes wrote:
>> Speaking of dangling pointers: A similar disaster would happen if some
>> code containing pi_* calls gets copy-pasted to some non-__init
>> function.
>
> This is my biggest issue with adding t
On 25 June 2014 09:35, Rasmus Villemoes wrote:
> Mathias Krause writes:
>
>> On 24 June 2014 16:31, Rasmus Villemoes wrote:
>>> gcc already seems to contain infrastructure for this kind of thing, so
>>> maybe it doesn't even require a plugin, but simply a l
On 24 June 2014 23:45, Joe Perches wrote:
> On Tue, 2014-06-24 at 23:06 +0200, Mathias Krause wrote:
>> On 24 June 2014 22:57, Joe Perches wrote:
>> > On Tue, 2014-06-24 at 22:41 +0200, Mathias Krause wrote:
>> >> And all of those strings should be in the .roda
On 24 June 2014 22:57, Joe Perches wrote:
> On Tue, 2014-06-24 at 22:41 +0200, Mathias Krause wrote:
>> there is more to optimize
>> if one is patient enough ;)
>
> Ever thus.
>
>> And all of those strings should be in the .rodata section, now. But
>> why you&
On 24 June 2014 22:30, Joe Perches wrote:
> On Tue, 2014-06-24 at 22:10 +0200, Mathias Krause wrote:
>> I would like to handle the easy ones, too. E.g. strings used in
>> parameter parsing, i.e. strcmp()s.
>
> Sure, but that change is separable from printk conversions.
On 24 June 2014 21:43, Joe Perches wrote:
> On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote:
>> Add macros to be able to mark string literals used in __init / __exit
>> functions.
> []
>> diff --git a/include/linux/init.h b/include/linux/init.h
> []
On 24 June 2014 21:37, Joe Perches wrote:
> On Tue, 2014-06-24 at 21:13 +0200, Mathias Krause wrote:
>> I don't think it's that easy. You cannot simply put all strings into
>> the .init.rodata section when code currently gets emitted to
>> .init.text. The reason is
On 24 June 2014 16:31, Rasmus Villemoes wrote:
> Joe Perches writes:
>
>> On Mon, 2014-06-23 at 08:23 +0200, Mathias Krause wrote:
>>> On 23 June 2014 00:56, Joe Perches wrote:
>>> > On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote:
>>> >&g
On 23 June 2014 03:30, Joe Perches wrote:
> On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote:
>> This RFC series tries to address the problem of dangling strings of
>> __init functions after initialization, as well as __exit strings for
>> code not even included in t
On 23 June 2014 00:56, Joe Perches wrote:
> On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote:
>> [...] patch 2 adds some syntactical sugar for the most popular use
>> case, by providing pr_ alike macros, namely pi_ for __init
>> code and pe_ for __exit code. This
the .rodata section to .init.rodata.
Signed-off-by: Mathias Krause
---
Should the checkpatch warnings be handled, too, e.g. removing the line
breaks for strings?:
WARNING: quoted string split across lines
#421: FILE: arch/x86/kernel/acpi/boot.c:1263:
+ pi_notice("Warning
f pr_*()
or plain printk() in __init / __exit functions.
What do you think?
Regards,
Mathias
Mathias Krause (3):
init.h: Add __init_str / __exit_str macros
printk: Provide pi_ / pe_ macros for __init / __exit
code
x86, acpi: Mark __init strings as such
arch/x86/kernel/acpi/boot.c | 1
Add macros to be able to mark string literals used in __init / __exit
functions.
Signed-off-by: Mathias Krause
---
include/linux/init.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/include/linux/init.h b/include/linux/init.h
index 2df8e8dd10..0a425b296e 100644
--- a
yndbg after initialization. But supporting that
scenario would require more work (and code), therefore not necessarily
justifying the memory savings.
Signed-off-by: Mathias Krause
---
include/linux/printk.h | 52
1 file changed, 52 insertions(+)
The VFS layer handles those in the very same way, if unset. No need for
additional stubs.
Signed-off-by: Mathias Krause
Cc: Alexander Viro
---
drivers/char/agp/frontend.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp
52e lib/string_helpers.old.o
1326 0 01326 52e lib/string_helpers.new.o
Cc: James Bottomley
Signed-off-by: Mathias Krause
---
lib/string_helpers.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/string_helpers.c b/lib/string
On 5 June 2014 15:33, Luis Henriques wrote:
> On Wed, Jun 04, 2014 at 09:16:25PM -0700, Greg Kroah-Hartman wrote:
>> 3.4-stable review patch. If anyone has any objections, please let me know.
>> [...]
>> --- a/net/core/filter.c
>> +++ b/net/core/filter.c
>> @@ -338,11 +338,15 @@ load_b:
>>
>>
On 12 May 2014 02:32, Willy Tarreau wrote:
> 2.6.32-longterm review patch. If anyone has any objections, please let me
> know.
>
> --
>
> From: Mathias Krause
>
> [ Upstream commit e727ca82e0e9616ab4844301e6bae60ca7327682 ]
>
> Initialize event
Commit-ID: 6392b4ebdc1acfbed605d68c437ff5597d0a8d95
Gitweb: http://git.kernel.org/tip/6392b4ebdc1acfbed605d68c437ff5597d0a8d95
Author: Mathias Krause
AuthorDate: Sun, 27 Apr 2014 18:51:05 +0200
Committer: Jiri Olsa
CommitDate: Wed, 30 Apr 2014 17:02:30 +0200
perf x86: Fix perf to use
y) linking against libraries needing an executable stack.
But, apparently, regressing in that direction is wanted as it is an
indicator of poor code quality -- or just missing linker notes.
Fixes: 3c8b06f981 ("perf tests x86: Introduce perf_regs_load function")
Acked-by: Ingo Molnar
Si
On 27 April 2014 18:16, Jiri Olsa wrote:
> On Sun, Apr 27, 2014 at 06:07:30PM +0200, Mathias Krause wrote:
>> On 27 April 2014 12:39, Jiri Olsa wrote:
>> > On Sun, Apr 27, 2014 at 12:03:50PM +0200, Mathias Krause wrote:
>> > [...]
>> >> 2/ What if someb
On 27 April 2014 12:39, Jiri Olsa wrote:
> On Sun, Apr 27, 2014 at 12:03:50PM +0200, Mathias Krause wrote:
> [...]
>> 2/ What if somebody tries to add/link code to perf that makes use of
>> nested functions? That'll make perf fail as the trampoline code
>> generated b
On 27 April 2014 11:26, Jiri Olsa wrote:
> On Sat, Apr 26, 2014 at 09:02:45PM +0200, Mathias Krause wrote:
>> arch/x86/tests/regs_load.S is missing the linker note about the stack
>> requirements, therefore making the linker fall back to an executable
>> stack. As this objec
inker note.
Fixes: 3c8b06f981 ("perf tests x86: Introduce perf_regs_load function")
Signed-off-by: Mathias Krause
Cc: Peter Zijlstra
Cc: Paul Mackerras
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Jiri Olsa
---
tools/perf/arch/x86/tests/regs_load.S |8 +++-
1 file change
On 15 April 2014 00:08, Felipe Balbi wrote:
> On Tue, Apr 15, 2014 at 12:07:13AM +0200, Mathias Krause wrote:
>> On 14 April 2014 23:35, Felipe Balbi wrote:
>> > On Sun, Mar 30, 2014 at 03:34:15PM +0200, Mathias Krause wrote:
>> >> If we've registered a no
101 - 200 of 295 matches
Mail list logo
