Re: [PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

On Mon, Nov 13, 2017 at 11:31:31AM -0800, Matt Wilson wrote: > From: Matt Wilson <m...@amazon.com> > > This device will be used in future Amazon EC2 instances as the primary > serial port (i.e., data sent to this port will be available via the > GetConsoleOuput [1] EC2 API)

Re: [PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

On Mon, Nov 13, 2017 at 11:31:31AM -0800, Matt Wilson wrote: > From: Matt Wilson > > This device will be used in future Amazon EC2 instances as the primary > serial port (i.e., data sent to this port will be available via the > GetConsoleOuput [1] EC2 API). Ping? --msw

[PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

From: Matt Wilson <m...@amazon.com> This device will be used in future Amazon EC2 instances as the primary serial port (i.e., data sent to this port will be available via the GetConsoleOuput [1] EC2 API). [1] http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetConsoleOutput.ht

[PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

From: Matt Wilson This device will be used in future Amazon EC2 instances as the primary serial port (i.e., data sent to this port will be available via the GetConsoleOuput [1] EC2 API). [1] http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetConsoleOutput.html Cc: sta

[PATCH] serial: 8250_pci: Add Amazon PCI serial device ID

From: Matt Wilson <m...@amazon.com> Cc: sta...@vger.kernel.org Signed-off-by: Matt Wilson <m...@amazon.com> --- drivers/tty/serial/8250/8250_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c i

[PATCH] serial: 8250_pci: Add Amazon PCI serial device ID

From: Matt Wilson Cc: sta...@vger.kernel.org Signed-off-by: Matt Wilson --- drivers/tty/serial/8250/8250_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 0c101a7..d4e7be8 100644 --- a/drivers/tty/serial

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) > Signed-off-by: Netanel Belgazal > --- > drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- >

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) > Signed-off-by: Netanel Belgazal > --- > drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- > drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 --- > 2

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: > The ENA device can update the ena driver about the desire timeouts. > The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix - correct? If it is a new feature, submit it

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: > The ENA device can update the ena driver about the desire timeouts. > The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix - correct? If it is a new feature, submit it

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: > If for some reason the device stop responding and the device reset failed > to recover the device, the mmio register read datastructure will not be > reinitialized. If for some reason the device stops responding, and the device

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: > If for some reason the device stop responding and the device reset failed > to recover the device, the mmio register read datastructure will not be > reinitialized. If for some reason the device stops responding, and the device

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: > ndo_get_stat64 can be called from atomic context. > However the current implementation sends an admin command to retrieve > the statistics from the device. > This admin commands uses sleep. Suggest some comment edits:

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: > ndo_get_stat64 can be called from atomic context. > However the current implementation sends an admin command to retrieve > the statistics from the device. > This admin commands uses sleep. Suggest some comment edits:

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: > ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? > configure non ip packets. configuring non-IP packets. --msw >

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: > ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? > configure non ip packets. configuring non-IP packets. --msw >

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: > ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type > treat the ena_flow_hash_to_flow_type enum as power of two values. > > Change the values of ena_admin_flow_hash_fields to be power of two values. Then I generally prefer

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: > ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type > treat the ena_flow_hash_to_flow_type enum as power of two values. > > Change the values of ena_admin_flow_hash_fields to be power of two values. Then I generally prefer

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

ible_cpus(), num_online_cpus(). > Signed-off-by: Netanel Belgazal <neta...@annapurnalabs.com> Reviewed-by: Matt Wilson <m...@amazon.com> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

ible_cpus(), num_online_cpus(). > Signed-off-by: Netanel Belgazal Reviewed-by: Matt Wilson > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/d

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

d 75 columns. > Signed-off-by: Netanel Belgazal <neta...@annapurnalabs.com> Reviewed-by: Matt Wilson <m...@amazon.com> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_net

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

d 75 columns. > Signed-off-by: Netanel Belgazal Reviewed-by: Matt Wilson > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.

Re: [PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list

On Sun, Dec 04, 2016 at 03:19:19PM +0200, Netanel Belgazal wrote: > Remove NETIF_F_NTUPLE from netdev->features. > The ENA device driver does not support ntuple filtering. > > Signed-off-by: Netanel Belgazal <neta...@annapurnalabs.com> Reviewed-by: Matt Wilson <m...@amazo

Re: [PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list

On Sun, Dec 04, 2016 at 03:19:19PM +0200, Netanel Belgazal wrote: > Remove NETIF_F_NTUPLE from netdev->features. > The ENA device driver does not support ntuple filtering. > > Signed-off-by: Netanel Belgazal Reviewed-by: Matt Wilson > --- > drivers/net/ethernet/amazon

Re: [PATCH V2 net 00/20] Increase ENA driver version to 1.1.2

On Sun, Dec 04, 2016 at 09:37:43PM -0500, David Miller wrote: > > It is not appropriate to submit so many patches at one time. Indeed, https://www.kernel.org/doc/Documentation/SubmittingPatches recommends submitting no more than 15 or so at once. > Please keep your patch series to no more than

Re: [PATCH V2 net 00/20] Increase ENA driver version to 1.1.2

On Sun, Dec 04, 2016 at 09:37:43PM -0500, David Miller wrote: > > It is not appropriate to submit so many patches at one time. Indeed, https://www.kernel.org/doc/Documentation/SubmittingPatches recommends submitting no more than 15 or so at once. > Please keep your patch series to no more than

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote: > On 2016/07/14 08:22, Matt Wilson wrote: > [...] > > > > Dave and Benjamin, > > > > Do you want to see the interrupt moderation extensions to ethtool and > > the sysfs nodes removed befo

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote: > On 2016/07/14 08:22, Matt Wilson wrote: > [...] > > > > Dave and Benjamin, > > > > Do you want to see the interrupt moderation extensions to ethtool and > > the sysfs nodes removed befo

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: > Changes in v3: > - Fix compilation warning for 32bit systems. [kbuild test

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: > Changes in v3: > - Fix compilation warning for 32bit systems. [kbuild test rebot] > - Replace

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jun 16, 2016 at 07:06:52PM +0100, Ben Hutchings wrote: > On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote: > > On 2016/06/13 11:46, Netanel Belgazal wrote: > [...] > > > +static ssize_t ena_show_small_copy_len(struct device *dev, > > > +    struct

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jun 16, 2016 at 07:06:52PM +0100, Ben Hutchings wrote: > On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote: > > On 2016/06/13 11:46, Netanel Belgazal wrote: > [...] > > > +static ssize_t ena_show_small_copy_len(struct device *dev, > > > +    struct

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote: > Netanel Belgazal : > [...] > > Very limited review below. I'll comment on the documentation (since I edited it heavily) but will leave some the other parts for Netanel to answer. > > diff --git

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote: > Netanel Belgazal : > [...] > > Very limited review below. I'll comment on the documentation (since I edited it heavily) but will leave some the other parts for Netanel to answer. > > diff --git

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

lain text only. Have a look at [1] for how to set up a mailer like mutt with Gmail. --msw [1] https://www.kernel.org/doc/Documentation/email-clients.txt > On 15 June 2016 at 21:22, Matt Wilson <m...@amzn.com> wrote: > > > On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrot

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

lain text only. Have a look at [1] for how to set up a mailer like mutt with Gmail. --msw [1] https://www.kernel.org/doc/Documentation/email-clients.txt > On 15 June 2016 at 21:22, Matt Wilson wrote: > > > On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote: > > >

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote: > > You also had a few typos in the email addresses on the Cc: line that > I've corrected (d...@avemeloft.net -> da...@davemeloft.net, Argh, and of course I typo'ed the correction. -> da...@davemloft.net. --msw

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote: > > You also had a few typos in the email addresses on the Cc: line that > I've corrected (d...@avemeloft.net -> da...@davemeloft.net, Argh, and of course I typo'ed the correction. -> da...@davemloft.net. --msw

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. > > Signed-off-by: Netanel Belgazal [...] > + > +struct ena_napi { > + struct napi_struct napi cacheline_aligned; > +

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. > > Signed-off-by: Netanel Belgazal [...] > + > +struct ena_napi { > + struct napi_struct napi cacheline_aligned; > + struct ena_ring *tx_ring;

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jun 14, 2016 at 11:27:09PM -0700, David Miller wrote: > From: Matt Wilson <m...@amzn.com> > Date: Tue, 14 Jun 2016 23:23:36 -0700 > > > Point taken, though existing drivers (even fairly popular ones) also > > aren't as clean as you might like. A quick look arou

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jun 14, 2016 at 11:27:09PM -0700, David Miller wrote: > From: Matt Wilson > Date: Tue, 14 Jun 2016 23:23:36 -0700 > > > Point taken, though existing drivers (even fairly popular ones) also > > aren't as clean as you might like. A quick look around... > > Exis

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jun 14, 2016 at 10:25:16PM -0700, David Miller wrote: > From: Netanel Belgazal > Date: Mon, 13 Jun 2016 11:46:13 +0300 > > > +#define ena_trc_dbg(format, arg...) \ > > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg) > > +#define ena_trc_info(format,

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jun 14, 2016 at 10:25:16PM -0700, David Miller wrote: > From: Netanel Belgazal > Date: Mon, 13 Jun 2016 11:46:13 +0300 > > > +#define ena_trc_dbg(format, arg...) \ > > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg) > > +#define ena_trc_info(format, arg...) \ > > +

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. Reviewed-by: Matt Wilson <m...@amazon.com> > Signed-off-by: Netanel Belgazal <neta...@annapurnalabs.com> > --- > Documenta

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. Reviewed-by: Matt Wilson > Signed-off-by: Netanel Belgazal > --- > Documentation/networking/00-INDEX |2 + > Documenta

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote: > On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > > + > > +The ENA driver supports industry standard TCP/IP offload features > > such > > +as checksum offload and TCP transmit segmentation offload (TSO). > > + > >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote: > On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > > + > > +The ENA driver supports industry standard TCP/IP offload features > > such > > +as checksum offload and TCP transmit segmentation offload (TSO). > > + > >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: [...] > diff --git a/drivers/net/ethernet/amazon/Kconfig > b/drivers/net/ethernet/amazon/Kconfig > new file mode 100644 > index 000..bc4f240d > --- /dev/null > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -0,0 +1,27 @@ > +# >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: [...] > diff --git a/drivers/net/ethernet/amazon/Kconfig > b/drivers/net/ethernet/amazon/Kconfig > new file mode 100644 > index 000..bc4f240d > --- /dev/null > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -0,0 +1,27 @@ > +# >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

Hi Netanel, Looks like the last round of internal review went to {lkml,netdev,etc}, so this should be considered a RFC patch. The description still needs work. On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. ethernet ->

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

Hi Netanel, Looks like the last round of internal review went to {lkml,netdev,etc}, so this should be considered a RFC patch. The description still needs work. On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. ethernet ->

Re: [PATCH] virtio-pci: also bind to Amazon PCI vendor ID

0f is assigned to Amazon. See > > https://www.pcisig.com/membership/vid_search/ > > > > Vendors self-manage device IDs and we have allocated 0x1000-0x103f to > > virtio devices. > > > > >> That makes it impossible to use virtio drivers with >

Re: [PATCH] virtio-pci: also bind to Amazon PCI vendor ID

it. Be my guest. My only point is commit log should not say impossible to use. But this is IMO beside the point. Cc: Matt Wilson m...@amazon.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael Tsirkin m...@redhat.com Signed-off-by: Anthony Liguori aligu...@amazon.com

Re: [PATCH v3 2/2] xen/setup: Remap Xen Identity Mapped RAM

On Mon, Aug 11, 2014 at 10:34:01AM -0700, Matt Rushton wrote: > Instead of ballooning up and down dom0 memory this remaps the existing mfns > that were replaced by the identity map. The reason for this is that the > existing implementation ballooned memory up and and down which caused dom0 > to

Re: [PATCH v3 2/2] xen/setup: Remap Xen Identity Mapped RAM

On Mon, Aug 11, 2014 at 10:34:01AM -0700, Matt Rushton wrote: Instead of ballooning up and down dom0 memory this remaps the existing mfns that were replaced by the identity map. The reason for this is that the existing implementation ballooned memory up and and down which caused dom0 to have

Re: [PATCH v2 2/2] xen/setup: Remap Xen Identity Mapped RAM

On Fri, Aug 01, 2014 at 03:52:28PM +0100, David Vrabel wrote: > On 31/07/14 18:43, David Vrabel wrote: > > On 20/07/14 01:01, Matt Rushton wrote: > >> Instead of ballooning up and down dom0 memory this remaps the existing mfns > >> that were replaced by the identity map. The reason for this is

Re: [PATCH v2 2/2] xen/setup: Remap Xen Identity Mapped RAM

On Fri, Aug 01, 2014 at 03:52:28PM +0100, David Vrabel wrote: On 31/07/14 18:43, David Vrabel wrote: On 20/07/14 01:01, Matt Rushton wrote: Instead of ballooning up and down dom0 memory this remaps the existing mfns that were replaced by the identity map. The reason for this is that the

Re: [Xen-devel] [PATCH v2 0/4] xen-blk: bug fixes

On Thu, Feb 06, 2014 at 11:20:04AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 05, 2014 at 08:57:30PM -0800, Matt Wilson wrote: > > On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Tue, Feb 04, 2014 at 11:26:11AM +0100, Rog

Re: [Xen-devel] [PATCH v2 0/4] xen-blk: bug fixes

On Thu, Feb 06, 2014 at 11:20:04AM -0500, Konrad Rzeszutek Wilk wrote: On Wed, Feb 05, 2014 at 08:57:30PM -0800, Matt Wilson wrote: On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Feb 04, 2014 at 11:26:11AM +0100, Roger Pau Monne wrote: This series contain

Re: [Xen-devel] [PATCH v2 0/4] xen-blk: bug fixes

On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 04, 2014 at 11:26:11AM +0100, Roger Pau Monne wrote: > > This series contain blkback bug fixes for memory leaks (patches 1 and > > 2) and a race (patch 3). Patch 4 removes blkif_request_segment_aligned > > since

Re: [Xen-devel] [PATCH v2 0/4] xen-blk: bug fixes

On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Feb 04, 2014 at 11:26:11AM +0100, Roger Pau Monne wrote: This series contain blkback bug fixes for memory leaks (patches 1 and 2) and a race (patch 3). Patch 4 removes blkif_request_segment_aligned since its

Re: [PATCH v7] xen/grant-table: Avoid m2p_override during mapping

On Mon, Feb 03, 2014 at 01:24:58PM +, Zoltan Kiss wrote: > The grant mapping API does m2p_override unnecessarily: only gntdev needs it, > for blkback and future netback patches it just cause a lock contention, as > those pages never go to userspace. Therefore this series does the following: >

Re: [Xen-devel] xen-blkback: bug fixes

On Tue, Jan 28, 2014 at 03:38:37PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 28, 2014 at 06:43:32PM +0100, Roger Pau Monne wrote: > > blkback bug fixes for memory leaks (patches 1 and 2) and a race > > (patch 3). > > They all look OK to me. I've stuck them in my 'stable/for-jens-3.14' >

Re: [Xen-devel] xen-blkback: bug fixes

On Tue, Jan 28, 2014 at 03:38:37PM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Jan 28, 2014 at 06:43:32PM +0100, Roger Pau Monne wrote: blkback bug fixes for memory leaks (patches 1 and 2) and a race (patch 3). They all look OK to me. I've stuck them in my 'stable/for-jens-3.14' branch

Re: [PATCH v7] xen/grant-table: Avoid m2p_override during mapping

On Mon, Feb 03, 2014 at 01:24:58PM +, Zoltan Kiss wrote: The grant mapping API does m2p_override unnecessarily: only gntdev needs it, for blkback and future netback patches it just cause a lock contention, as those pages never go to userspace. Therefore this series does the following: -

Re: [PATCH] xen-blkback: fix memory leaks

d-black tree. > >> > >> Also, add some checks in xen_blkif_free to make sure we are cleaning > >> everything. > >> > >> Signed-off-by: Roger Pau Monné > >> Cc: Konrad Rzeszutek Wilk > >> Cc: David Vrabel > >> Cc: Boris Ostrovs

Re: [PATCH] xen-blkback: fix memory leaks

@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: David Vrabel david.vra...@citrix.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: Matt Rushton mrush...@amazon.com Cc: Matt Wilson m...@amazon.com Cc: Ian Campbell ian.campb...@citrix.com --- This should

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

On Fri, Jan 24, 2014 at 03:36:22PM +, Ian Campbell wrote: > On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: > > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: > > > From: Matt Rushton > > > > > > Currently shrink_free_pagepo

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

On Fri, Jan 24, 2014 at 03:36:22PM +, Ian Campbell wrote: On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently shrink_free_pagepool() is called before the pages used

Re: [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

On Thu, Jan 23, 2014 at 09:23:44PM +, Zoltan Kiss wrote: > The grant mapping API does m2p_override unnecessarily: only gntdev needs it, > for blkback and future netback patches it just cause a lock contention, as > those pages never go to userspace. Therefore this series does the following: >

[PATCH] xen-blkback: fix memory leak when persistent grants are used

; Cc: Ian Campbell Cc: David Vrabel Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xen.org Cc: Anthony Liguori Signed-off-by: Matt Rushton Signed-off-by: Matt Wilson --- drivers/block/xen-blkback/blkback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] xen-blkback: fix memory leak when persistent grants are used

...@oracle.com Cc: Roger Pau Monné roger@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: David Vrabel david.vra...@citrix.com Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xen.org Cc: Anthony Liguori aligu...@amazon.com Signed-off-by: Matt Rushton mrush...@amazon.com Signed-off-by: Matt

Re: [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

On Thu, Jan 23, 2014 at 09:23:44PM +, Zoltan Kiss wrote: The grant mapping API does m2p_override unnecessarily: only gntdev needs it, for blkback and future netback patches it just cause a lock contention, as those pages never go to userspace. Therefore this series does the following: -

[PATCH] xen/gnttab: leave lazy MMU mode in the case of a m2p override failure

From: Matt Wilson Commit f62805f1 introduced a bug where lazy MMU mode isn't exited if a m2p_add/remove_override call fails. Cc: Stefano Stabellini Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel Cc: Anthony Liguori Cc: xen-de...@lists.xenproject.org Cc: linux-kernel

[PATCH] xen/gnttab: leave lazy MMU mode in the case of a m2p override failure

From: Matt Wilson m...@amazon.com Commit f62805f1 introduced a bug where lazy MMU mode isn't exited if a m2p_add/remove_override call fails. Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc

Re: [PATCH] xen-gnttab: do not add m2p override entries for blkback mappings

kernel/1590932 for a full > analysis of current users. > > Signed-off-by: Anthony Liguori Reviewed-by: Matt Wilson One comment for discussion below. > --- > A backported version of this has been heavily tested but the testing > against the latest Linux tree is light so far. [...]

Re: [PATCH] xen-gnttab: do not add m2p override entries for blkback mappings

of current users. Signed-off-by: Anthony Liguori aligu...@amazon.com Reviewed-by: Matt Wilson m...@amazon.com One comment for discussion below. --- A backported version of this has been heavily tested but the testing against the latest Linux tree is light so far. [...] diff --git

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Wed, Nov 06, 2013 at 11:34:27AM +, David Vrabel wrote: [...] > > Matt, Anthony, I presume you have profiling results or performance data > that support this proposed change? Can you provide them? I've measured 10-20% performance improvement in configurations where: 1) dom0 has a

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Wed, Nov 06, 2013 at 11:34:27AM +, David Vrabel wrote: [...] Matt, Anthony, I presume you have profiling results or performance data that support this proposed change? Can you provide them? I've measured 10-20% performance improvement in configurations where: 1) dom0 has a moderate

Re: [GIT PULL] (xen) stable/for-jens-3.13

On Tue, Nov 05, 2013 at 02:52:29PM -0800, Matt Wilson wrote: > On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote: > > > > Hey Jens, > > > > Please git pull the following branch: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/k

Re: [GIT PULL] (xen) stable/for-jens-3.13

On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote: > > Hey Jens, > > Please git pull the following branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git > stable/for-jens-3.13 > > > which has a fix to the Xen block frontend driver. For the backends

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Tue, Nov 05, 2013 at 02:09:53PM -0800, Anthony Liguori wrote: > On Tue, Nov 5, 2013 at 1:16 PM, Konrad Rzeszutek Wilk > wrote: > > On Tue, Nov 05, 2013 at 12:53:17PM -0800, Anthony Liguori wrote: > >> Matt Wilson writes: > >> > >> > On Tue, Nov 05,

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Tue, Nov 05, 2013 at 05:03:58PM +0100, Roger Pau Monné wrote: > On 05/11/13 16:08, Ian Campbell wrote: > > On Tue, 2013-11-05 at 16:01 +0100, Roger Pau Monné wrote: > >> On 05/11/13 15:56, Konrad Rzeszutek Wilk wrote: > >>> On Tue, Nov 05, 2013 at 03:47:08PM +0100, Roger Pau Monné wrote: >

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Tue, Nov 05, 2013 at 05:03:58PM +0100, Roger Pau Monné wrote: On 05/11/13 16:08, Ian Campbell wrote: On Tue, 2013-11-05 at 16:01 +0100, Roger Pau Monné wrote: On 05/11/13 15:56, Konrad Rzeszutek Wilk wrote: On Tue, Nov 05, 2013 at 03:47:08PM +0100, Roger Pau Monné wrote: On 05/11/13

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

On Tue, Nov 05, 2013 at 02:09:53PM -0800, Anthony Liguori wrote: On Tue, Nov 5, 2013 at 1:16 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Tue, Nov 05, 2013 at 12:53:17PM -0800, Anthony Liguori wrote: Matt Wilson m...@linux.com writes: On Tue, Nov 05, 2013 at 05:03:58PM

Re: [GIT PULL] (xen) stable/for-jens-3.13

On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote: Hey Jens, Please git pull the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-3.13 which has a fix to the Xen block frontend driver. For the backends that don't

Re: [GIT PULL] (xen) stable/for-jens-3.13

On Tue, Nov 05, 2013 at 02:52:29PM -0800, Matt Wilson wrote: On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote: Hey Jens, Please git pull the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-3.13 which

Re: [PATCH] hpet, allow user controlled mmap for user processes

|9 +++-- > drivers/char/hpet.c | 25 +++-- > 3 files changed, 34 insertions(+), 4 deletions(-) It doesn't seem like this patch got picked up and seems like a good idea to me. Clemens, what do you think? Acked-by: Matt Wilson --msw -- T

Re: [PATCH] hpet, allow user controlled mmap for user processes

+++-- 3 files changed, 34 insertions(+), 4 deletions(-) It doesn't seem like this patch got picked up and seems like a good idea to me. Clemens, what do you think? Acked-by: Matt Wilson m...@amazon.com --msw -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 3/3] xen-blkfront: revoke foreign access for grants not mapped by the backend

s controlled by the > value in blkback). > > Signed-off-by: Roger Pau Monné Acked-by: Matt Wilson > Cc: Konrad Rzeszutek Wilk > Cc: David Vrabel > --- > drivers/block/xen-blkfront.c | 33 + > 1 files changed, 29 insertions(+), 4 deletions(

Re: [PATCH 3/3] xen-blkfront: revoke foreign access for grants not mapped by the backend

). Signed-off-by: Roger Pau Monné roger@citrix.com Acked-by: Matt Wilson m...@amazon.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: David Vrabel david.vra...@citrix.com --- drivers/block/xen-blkfront.c | 33 + 1 files changed, 29 insertions(+), 4

Re: [PATCH 1/3] xen-gnt: prevent adding duplicate gnt callbacks

ack in the list. If we add the same callback twice > we end up with an infinite loop, were callback == callback->next. > > Replace this check with a proper one that iterates over the list to > see if the callback has already been added. Acked-by: Matt Wilson > Signed-off-by: Roger

Re: [PATCH 1/3] xen-gnt: prevent adding duplicate gnt callbacks

add the same callback twice we end up with an infinite loop, were callback == callback-next. Replace this check with a proper one that iterates over the list to see if the callback has already been added. Acked-by: Matt Wilson m...@amazon.com Signed-off-by: Roger Pau Monné roger@citrix.com

Re: [PATCH] kexec/kdump implementation for Xen PV domU

On Mon, Jul 29, 2013 at 07:15:43PM +0200, Daniel Kiper wrote: > Hi all, > > Here I am sending as attachments patches enabling kexec/kdump > support in Xen PV domU. Only x84_64 architecture is supported. > There is no support for i386 but some code could be easily reused. > Here is a description

Re: [PATCH] kexec/kdump implementation for Xen PV domU

On Mon, Jul 29, 2013 at 07:15:43PM +0200, Daniel Kiper wrote: Hi all, Here I am sending as attachments patches enabling kexec/kdump support in Xen PV domU. Only x84_64 architecture is supported. There is no support for i386 but some code could be easily reused. Here is a description of

Re: [Xen-devel] is kexec on Xen domU possible?

On Mon, Jul 22, 2013 at 11:33:15AM -0700, Greg KH wrote: > On Mon, Jul 22, 2013 at 11:24:46AM -0700, H. Peter Anvin wrote: > > On 07/22/2013 10:20 AM, Eric W. Biederman wrote: > > >>> > > >>> Also, in any virtualized environment the hypervisor can do a better job > > >>> for things like kdump,

Re: [Xen-devel] is kexec on Xen domU possible?

On Mon, Jul 22, 2013 at 11:33:15AM -0700, Greg KH wrote: On Mon, Jul 22, 2013 at 11:24:46AM -0700, H. Peter Anvin wrote: On 07/22/2013 10:20 AM, Eric W. Biederman wrote: Also, in any virtualized environment the hypervisor can do a better job for things like kdump, simply because it can

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

On Wed, Jul 10, 2013 at 12:34:58AM +0200, Sander Eikelenboom wrote: > > Tuesday, July 9, 2013, 5:05:54 PM, you wrote: > > > On Tue, Jul 09, 2013 at 10:48:40AM -0400, Konrad Rzeszutek Wilk wrote: > >> Then that should be discussed on grub2 to remove said check and modify > >> the code so that it

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

On Wed, Jul 10, 2013 at 12:34:58AM +0200, Sander Eikelenboom wrote: Tuesday, July 9, 2013, 5:05:54 PM, you wrote: On Tue, Jul 09, 2013 at 10:48:40AM -0400, Konrad Rzeszutek Wilk wrote: Then that should be discussed on grub2 to remove said check and modify the code so that it can

  1   2   >