Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-02 Thread Matthias Kaehlcke
Hi Greg, On Wed, Sep 02, 2020 at 08:07:44AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 01, 2020 at 01:21:43PM -0700, Matthias Kaehlcke wrote: > > diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile > > index da39bddb0604..2bd02388ca62 100644 > > --- a/driv

Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-02 Thread Matthias Kaehlcke
Hi Peter, On Wed, Sep 02, 2020 at 05:31:06AM +, Peter Chen wrote: > On 20-09-01 13:21:43, Matthias Kaehlcke wrote: > > The driver combo usb_hub_pwr/usb_hub_psupply allows to control > > the power supply of an onboard USB hub. > > > > The drivers address two iss

Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-01 Thread Matthias Kaehlcke
Hi Doug, On Tue, Sep 01, 2020 at 02:21:49PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 1, 2020 at 1:21 PM Matthias Kaehlcke wrote: > > > > The driver combo usb_hub_pwr/usb_hub_psupply allows to control > > the power supply of an onboard USB hub. > > &

Re: [PATCH] arm64: dts: qcom: sc7180: Add 'sustainable_power' for CPU thermal zones

2020-09-01 Thread Matthias Kaehlcke
On Tue, Sep 01, 2020 at 03:45:52PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 1, 2020 at 2:33 PM Matthias Kaehlcke wrote: > > > > Hi Doug, > > > > On Tue, Sep 01, 2020 at 01:19:10PM -0700, Doug Anderson wrote: > > > Hi, > > > >

Re: [PATCH] arm64: dts: qcom: sc7180: Add 'sustainable_power' for CPU thermal zones

2020-09-01 Thread Matthias Kaehlcke
Hi Doug, On Tue, Sep 01, 2020 at 01:19:10PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 1, 2020 at 10:07 AM Matthias Kaehlcke wrote: > > > > On Thu, Aug 13, 2020 at 11:30:33AM -0700, Matthias Kaehlcke wrote: > > > The 'sustainable_power' attribute provide

[RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-01 Thread Matthias Kaehlcke
Chandra Sadineni Signed-off-by: Ravi Chandra Sadineni Signed-off-by: Matthias Kaehlcke --- The driver currently only supports a single power supply. This should work for most/many configurations/hubs, support for multiple power supplies can be added later if needed. No DT bindings are included

Re: [PATCH] arm64: dts: qcom: sc7180: Add 'sustainable_power' for CPU thermal zones

2020-09-01 Thread Matthias Kaehlcke
On Thu, Aug 13, 2020 at 11:30:33AM -0700, Matthias Kaehlcke wrote: > The 'sustainable_power' attribute provides an estimate of the sustained > power that can be dissipated at the desired control temperature. One > could argue that this value is not necessarily the same for al

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-27 Thread Matthias Kaehlcke
Hi Satya, On Thu, Aug 27, 2020 at 08:37:33PM +0530, ska...@codeaurora.org wrote: > Hi Matthias, > > On 2020-08-26 22:10, Matthias Kaehlcke wrote: > > Hi Satya, > > > > On Wed, Aug 26, 2020 at 09:35:15PM +0530, ska...@codeaurora.org wrote: > > > Hi Matthi

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-26 Thread Matthias Kaehlcke
Hi Satya, On Wed, Aug 26, 2020 at 09:35:15PM +0530, ska...@codeaurora.org wrote: > Hi Matthias, > > On 2020-08-25 22:08, Matthias Kaehlcke wrote: > > On Tue, Aug 25, 2020 at 06:42:28PM +0530, ska...@codeaurora.org wrote: > > > On 2020-08-21 22:52, Matthias Kaehlcke wrote

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-25 Thread Matthias Kaehlcke
On Tue, Aug 25, 2020 at 06:42:28PM +0530, ska...@codeaurora.org wrote: > On 2020-08-21 22:52, Matthias Kaehlcke wrote: > > On Thu, Aug 20, 2020 at 07:21:06PM +0530, satya priya wrote: > > > Add sleep pin ctrl for BT uart, and also change the bias > > > configuratio

Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

2020-08-24 Thread Matthias Kaehlcke
On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote: > For disabled paths the 'interconnect_summary' in debugfs currently shows > the orginally requested bandwidths. This is confusing, since the bandwidth > requests aren't active. Instead show the bandwidths for disable

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-21 Thread Matthias Kaehlcke
On Thu, Aug 20, 2020 at 07:21:06PM +0530, satya priya wrote: > Add sleep pin ctrl for BT uart, and also change the bias > configuration to match Bluetooth module. > > Signed-off-by: satya priya > Reviewed-by: Akash Asthana > --- > Changes in V2: > - This patch adds sleep state for BT UART.

Re: [PATCH V3 1/3] arm64: dts: sc7180: Add wakeup support over UART RX

2020-08-21 Thread Matthias Kaehlcke
On Thu, Aug 20, 2020 at 07:21:05PM +0530, satya priya wrote: > Add the necessary pinctrl and interrupts to make UART > wakeup capable. > > Signed-off-by: satya priya > Reviewed-by: Akash Asthana > --- > Changes in V2: > - As per Matthias's comment added wakeup support for all the UARTs >of

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-21 Thread Matthias Kaehlcke
On Thu, Aug 20, 2020 at 05:49:53PM +0530, ska...@codeaurora.org wrote: > Hi Matthias, > > On 2020-08-19 21:43, Matthias Kaehlcke wrote: > > On Wed, Aug 19, 2020 at 07:19:25PM +0530, ska...@codeaurora.org wrote: > > > On 2020-08-17 23:31, Matthias Kaehlcke wrote: > >

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-19 Thread Matthias Kaehlcke
On Wed, Aug 19, 2020 at 07:19:25PM +0530, ska...@codeaurora.org wrote: > On 2020-08-17 23:31, Matthias Kaehlcke wrote: > > On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > > > Add sleep pin ctrl for BT uart, and also change the bias > > > configuratio

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-17 Thread Matthias Kaehlcke
On Mon, Aug 17, 2020 at 11:01:58AM -0700, Matthias Kaehlcke wrote: > On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > > Add sleep pin ctrl for BT uart, and also change the bias > > configuration to match Bluetooth module. > > > > Signed-off-by: satya priya

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-17 Thread Matthias Kaehlcke
On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > Add sleep pin ctrl for BT uart, and also change the bias > configuration to match Bluetooth module. > > Signed-off-by: satya priya > --- > Changes in V2: > - This patch adds sleep state for BT UART. Newly added in V2. > >

Re: [PATCH V2 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue

2020-08-17 Thread Matthias Kaehlcke
On Fri, Jul 24, 2020 at 09:28:02AM +0530, satya priya wrote: > As a part of system suspend we call uart_port_suspend from the > Serial driver, which calls set_mctrl passing mctrl as NULL. This > makes RFR high(NOT_READY) during suspend. > > Due to this BT SoC is not able to send wakeup bytes to

[PATCH] arm64: dts: qcom: sc7180: Add 'sustainable_power' for CPU thermal zones

2020-08-13 Thread Matthias Kaehlcke
hout heat sink or other passive cooling elements. Signed-off-by: Matthias Kaehlcke --- If maintainers think 'sustainable_power' should be specified at device level (with which I conceptually agree) I'm fine with doing that, just seemed it could be useful to have a reasonable 'default' at SoC l

Re: [PATCH v2 1/3] usb: dwc3: core: Host wake up support from system suspend

2020-08-13 Thread Matthias Kaehlcke
On Thu, Jul 09, 2020 at 12:40:15AM +0530, Sandeep Maheswaram wrote: > Avoiding phy powerdown in host mode so that it can be wake up by devices. > Added need_phy_for_wakeup flag to distinugush resume path and hs_phy_flags > to check connection status and set phy mode and configure interrupts. > >

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-08-12 Thread Matthias Kaehlcke
On Wed, Aug 12, 2020 at 04:26:08PM +0530, sbh...@codeaurora.org wrote: > On 2020-08-11 22:38, Matthias Kaehlcke wrote: > > On Tue, Jul 28, 2020 at 04:49:05PM +0530, sbh...@codeaurora.org wrote: > > > On 2020-07-28 00:40, Matthias Kaehlcke wrote: > > > > Hi, > &

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-11 Thread Matthias Kaehlcke
= 0 to drop > performance votes") > Reported-by: Sajida Bhanu > Signed-off-by: Rajendra Nayak Tested-by: Matthias Kaehlcke Originally-reported-by: Matthias Kaehlcke https://patchwork.kernel.org/patch/11675369/#23514895 :P

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-08-11 Thread Matthias Kaehlcke
On Tue, Jul 28, 2020 at 04:49:05PM +0530, sbh...@codeaurora.org wrote: > On 2020-07-28 00:40, Matthias Kaehlcke wrote: > > Hi, > > > > On Mon, Jul 27, 2020 at 12:20:38PM +0530, sbh...@codeaurora.org wrote: > > > On 2020-07-24 22:40, Matthias Ka

[PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

2020-07-29 Thread Matthias Kaehlcke
For disabled paths the 'interconnect_summary' in debugfs currently shows the orginally requested bandwidths. This is confusing, since the bandwidth requests aren't active. Instead show the bandwidths for disabled paths/requests as zero. Signed-off-by: Matthias Kaehlcke --- drivers/interconnect

Re: [PATCH 6/6] arm64: dts: qcom: sc7180: Increase the number of interconnect cells

2020-07-27 Thread Matthias Kaehlcke
d-off-by: Sibi Sankar > Signed-off-by: Georgi Djakov Tested-by: Matthias Kaehlcke Reviewed-by: Matthias Kaehlcke

Re: [PATCH 5/6] interconnect: qcom: sc7180: Replace xlate with xlate_extended

2020-07-27 Thread Matthias Kaehlcke
eorgi Djakov Tested-by: Matthias Kaehlcke Reviewed-by: Matthias Kaehlcke

Re: [PATCH 4/6] arm64: dts: qcom: sdm845: Increase the number of interconnect cells

2020-07-27 Thread Matthias Kaehlcke
ndpoints. > > Tested-by: Sibi Sankar > Reviewed-by: Sibi Sankar > > https://patchwork.kernel.org/patch/11655409/ > I'll replace the tag ids with the > macros once ^^ lands. Great, I was going to ask about that :) Reviewed-by: Matthias Kaehlcke

Re: [PATCH 3/6] interconnect: qcom: sdm845: Replace xlate with xlate_extended

2020-07-27 Thread Matthias Kaehlcke
On Thu, Jul 23, 2020 at 04:09:39PM +0300, Georgi Djakov wrote: > Use the qcom_icc_xlate_extended() in order to parse tags, that are > specified as an additional arguments to the path endpoints in DT. > > Signed-off-by: Georgi Djakov Reviewed-by: Matthias Kaehlcke

Re: [PATCH 2/6] interconnect: qcom: Implement xlate_extended() to parse tags

2020-07-27 Thread Matthias Kaehlcke
On Thu, Jul 23, 2020 at 04:09:38PM +0300, Georgi Djakov wrote: > Implement a function to parse the arguments of the "interconnects" DT > property and populate the interconnect path tags if this information > is available. > > Signed-off-by: Georgi Djakov > --- >

Re: [PATCH 1/6] interconnect: Introduce xlate_extended() callback

2020-07-27 Thread Matthias Kaehlcke
> as tag information. Let's create another callback xlate_extended() for the > cases where providers want also populate the tagging data. > > Signed-off-by: Georgi Djakov Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke

Re: [PATCH v11 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-27 Thread Matthias Kaehlcke
eswaram > Signed-off-by: Chandana Kishori Chiluveru Reviewed-by: Matthias Kaehlcke

Re: [PATCH v10 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-27 Thread Matthias Kaehlcke
On Mon, Jul 27, 2020 at 12:17:19PM -0700, Matthias Kaehlcke wrote: > On Thu, Jul 23, 2020 at 11:57:36PM +0530, Sandeep Maheswaram wrote: > > Add interconnect support in dwc3-qcom driver to vote for bus > > bandwidth. > > > > This requires for two different paths - fro

Re: [PATCH v10 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-27 Thread Matthias Kaehlcke
eswaram > Signed-off-by: Chandana Kishori Chiluveru Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-07-27 Thread Matthias Kaehlcke
Hi, On Mon, Jul 27, 2020 at 12:20:38PM +0530, sbh...@codeaurora.org wrote: > On 2020-07-24 22:40, Matthias Kaehlcke wrote: > > Hi Shaik, > > > > On Tue, Jul 21, 2020 at 04:16:21PM +0530, Shaik Sajida Bhanu wrote: > > > From: Pradeep P V K > > > &g

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-07-24 Thread Matthias Kaehlcke
Hi Shaik, On Tue, Jul 21, 2020 at 04:16:21PM +0530, Shaik Sajida Bhanu wrote: > From: Pradeep P V K > > Add the bandwidth domain supporting performance state and > the corresponding OPP tables for the sdhc device on sc7180. > > Signed-off-by: Pradeep P V K > Signed-off-by: Shaik Sajida Bhanu

Re: [PATCH v10 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-23 Thread Matthias Kaehlcke
Hi Sandeep, On Thu, Jul 23, 2020 at 11:57:36PM +0530, Sandeep Maheswaram wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB to > DDR. The other is from APPS to USB. > > Signed-off-by: Sandeep Maheswaram >

Re: [PATCH v2 2/3] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag

2020-07-21 Thread Matthias Kaehlcke
Hi Sandeep, On Thu, Jul 09, 2020 at 12:40:16AM +0530, Sandeep Maheswaram wrote: > configure interrupts based on hs_phy_flag. Set genpd active wakeup flag > for usb gdsc if wakeup capable devices are connected. as Stephen remarked, please describe why this patch is doing what it is doing. >

Re: [PATCH v2 1/3] usb: dwc3: core: Host wake up support from system suspend

2020-07-21 Thread Matthias Kaehlcke
Hi Sandeep, On Thu, Jul 09, 2020 at 12:40:15AM +0530, Sandeep Maheswaram wrote: > Avoiding phy powerdown in host mode so that it can be wake up by devices. > Added need_phy_for_wakeup flag to distinugush resume path and hs_phy_flags > to check connection status and set phy mode and configure

Re: [PATCH v9 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-21 Thread Matthias Kaehlcke
y: Sandeep Maheswaram > Signed-off-by: Chandana Kishori Chiluveru > Reviewed-by: Matthias Kaehlcke ^ Please remove this tag for now (should have requested this earlier). It seems we are very close, but apparently the review is still/again ongoing. > --- > d

Re: [PATCH] soc: qcom: geni: Fix NULL pointer dereference

2020-07-17 Thread Matthias Kaehlcke
ce_node *parent; > struct device_node *child; > + struct platform_device *wrapper_pdev; nit: since there is no other 'pdev' in this function you could just name it 'pdev', which is less clunky. The variable is only used immediately after it is assigned, so it's clear from the context that it refers to the 'wrapper'. Reviewed-by: Matthias Kaehlcke

Re: [PATCH] drm: msm: a6xx: fix gpu failure after system resume

2020-07-14 Thread Matthias Kaehlcke
ew iterations without this patch. Reported-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke On which tree is this patch based on? I had to apply it manually because 'git am' is unhappy when I try to apply it: error: sha1 information is lacking or useless (drivers/gpu/drm/msm/adreno/a6xx_g

Re: [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-14 Thread Matthias Kaehlcke
On Tue, Jul 14, 2020 at 04:39:47PM +0530, kalya...@codeaurora.org wrote: > On 2020-07-14 06:42, Matthias Kaehlcke wrote: > > On Thu, Jun 18, 2020 at 07:38:41PM +0530, Kalyan Thota wrote: > > > This change adds support to scale src clk and bandwidth as > > > p

Re: [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 07:38:41PM +0530, Kalyan Thota wrote: > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. > > Changes in v1: > - Address

Re: [PATCH 3/3] arm64: dts: sc7180: Add OPP tables and power-domains for venus

2020-07-13 Thread Matthias Kaehlcke
On Thu, Jul 02, 2020 at 02:26:14PM +0530, Rajendra Nayak wrote: > > On 7/1/2020 10:24 PM, Matthias Kaehlcke wrote: > > On Wed, Jul 01, 2020 at 05:10:38PM +0530, Rajendra Nayak wrote: > > > Add the OPP tables in order to be able to vote on the performance state &g

Re: [PATCH V1] mmc: sdhci-msm: Set IO pins in low power state during suspend

2020-07-10 Thread Matthias Kaehlcke
Hi, On Fri, Jul 10, 2020 at 04:28:36PM +0530, Veerabhadrarao Badiganti wrote: > Hi Mathias, > > On 7/10/2020 6:22 AM, Matthias Kaehlcke wrote: > > Hi, > > > > On Wed, Jul 08, 2020 at 06:41:20PM +0530, Veerabhadrarao Badiganti wrote: > > > Configure SDHC IO pi

Re: [PATCH V1] mmc: sdhci-msm: Set IO pins in low power state during suspend

2020-07-09 Thread Matthias Kaehlcke
Hi, On Wed, Jul 08, 2020 at 06:41:20PM +0530, Veerabhadrarao Badiganti wrote: > Configure SDHC IO pins with low power configuration when the driver > is in suspend state. > > Signed-off-by: Veerabhadrarao Badiganti > --- > drivers/mmc/host/sdhci-msm.c | 17 + > 1 file changed,

Re: [PATCH v8 2/2] arm64: dts: qcom: sc7180: Add maximum speed property for DWC3 USB node

2020-07-09 Thread Matthias Kaehlcke
}; > }; It shouldn't be strictly necessary if you use super-speed as default max-speed in the driver, but it also does no harm. Reviewed-by: Matthias Kaehlcke You might want to add it for other platforms too.

Re: [PATCH v8 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-09 Thread Matthias Kaehlcke
> DDR slave. The other is from APPS master to USB slave. > > Signed-off-by: Sandeep Maheswaram > Signed-off-by: Chandana Kishori Chiluveru > Reviewed-by: Matthias Kaehlcke > --- > drivers/usb/dwc3/dwc3-qcom.c | 127 > ++- > 1 file

Re: [PATCH v8 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-09 Thread Matthias Kaehlcke
> > Signed-off-by: Sandeep Maheswaram > Signed-off-by: Chandana Kishori Chiluveru > Reviewed-by: Matthias Kaehlcke > --- > drivers/usb/dwc3/dwc3-qcom.c | 127 > ++- > 1 file changed, 125 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH 1/2] dt-bindings: interconnect: Add generic qcom bindings

2020-07-09 Thread Matthias Kaehlcke
On Mon, Jun 22, 2020 at 09:05:14PM -0700, Mike Tipton wrote: > Add generic qcom interconnect bindings that are common across platforms. In > particular, these include QCOM_ICC_TAG_* macros that clients can use when > calling icc_set_tag(). > > Signed-off-by: Mike Tipton > --- >

Re: [PATCH] tty: serial: qcom-geni-serial: Drop the icc bw votes in suspend for console

2020-07-09 Thread Matthias Kaehlcke
e the sc7180 > is the interconnect BW votes, which we certainly don't need when > the system is in suspend. So in the suspend handler mark them as > ACTIVE_ONLY (0x3) and on resume switch them back to the ALWAYS tag (0x7) > > Signed-off-by: Rajendra Nayak Tested-by: Matthias Kaehlcke

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-07 Thread Matthias Kaehlcke
On Tue, Jul 07, 2020 at 10:41:24AM +0530, Sandeep Maheswaram (Temp) wrote: > > On 7/1/2020 4:12 AM, Matthias Kaehlcke wrote: > > On Tue, Jun 16, 2020 at 01:38:49PM -0700, Matthias Kaehlcke wrote: > > > On Tue, Jun 16, 2020 at 10:22:47AM +0530, Sandeep Maheswaram (Temp) wrote:

Re: [PATCH v2 2/4] drm/msm: dsi: Use OPP API to set clk/perf state

2020-07-06 Thread Matthias Kaehlcke
t;byte"); > + if (IS_ERR(msm_host->opp_table)) > + return PTR_ERR(msm_host->opp_table); > + /* OPP table is optional */ > + ret = dev_pm_opp_of_add_table(>dev); > + if (!ret) { > + msm_host->has_opp_table = true; > + } else if (ret != -ENODEV) { > + dev_err(>dev, "invalid OPP table in device tree\n"); dev_pm_opp_put_clkname(msm_host->opp_table); > + return ret; > + } With the missing _put_clkname() fixed: Reviewed-by: Matthias Kaehlcke

Re: [PATCH 3/3] arm64: dts: sc7180: Add qspi opps and power-domains

2020-07-06 Thread Matthias Kaehlcke
On Fri, Jul 03, 2020 at 03:11:33PM +0530, Rajendra Nayak wrote: > Add the power domain supporting performance state and the corresponding > OPP tables for the qspi device on sc7180 > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 2/3] arm64: dts: sdm845: Add qspi opps and power-domains

2020-07-06 Thread Matthias Kaehlcke
On Fri, Jul 03, 2020 at 03:11:32PM +0530, Rajendra Nayak wrote: > Add the power domain supporting performance state and the corresponding > OPP tables for the qspi device on sdm845 > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-01 Thread Matthias Kaehlcke
On Wed, Jul 01, 2020 at 01:13:34PM -0400, Jonathan Marek wrote: > On 7/1/20 1:12 PM, Matthias Kaehlcke wrote: > > Hi Jonathan, > > > > On Tue, Jun 30, 2020 at 11:08:41PM -0400, Jonathan Marek wrote: > > > Check for EPROBE_DEFER instead of silently not using icc

Re: [PATCH] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-01 Thread Matthias Kaehlcke
Hi Jonathan, On Tue, Jun 30, 2020 at 11:08:41PM -0400, Jonathan Marek wrote: > Check for EPROBE_DEFER instead of silently not using icc if the msm driver > probes before the interconnect driver. Agreed with supporting deferred ICC probing. > Only check for EPROBE_DEFER because of_icc_get can

Re: [PATCH 3/3] arm64: dts: sc7180: Add OPP tables and power-domains for venus

2020-07-01 Thread Matthias Kaehlcke
On Wed, Jul 01, 2020 at 05:10:38PM +0530, Rajendra Nayak wrote: > Add the OPP tables in order to be able to vote on the performance state > of a power-domain > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 35 +-- > 1 file

Re: [PATCH 2/3] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-01 Thread Matthias Kaehlcke
On Wed, Jul 01, 2020 at 05:10:37PM +0530, Rajendra Nayak wrote: > Add the OPP tables in order to be able to vote on the performance state of > a power-domain. > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 2/4] drm/msm: dsi: Use OPP API to set clk/perf state

2020-07-01 Thread Matthias Kaehlcke
On Tue, Jun 30, 2020 at 05:26:14PM +0530, Rajendra Nayak wrote: > On SDM845 DSI needs to express a perforamnce state nit: performance > requirement on a power domain depending on the clock rates. > Use OPP table from DT to register with OPP framework and use > dev_pm_opp_set_rate() to set the

Re: [PATCH 4/4] arm64: dts: sc7180: Add DSI and MDP OPP tables and power-domains

2020-07-01 Thread Matthias Kaehlcke
On Tue, Jun 30, 2020 at 05:26:16PM +0530, Rajendra Nayak wrote: > Add the OPP tables for DSI and MDP based on the perf state/clk > requirements, and add the power-domains property to specify the > scalable power domain. > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 3/4] arm64: dts: sdm845: Add DSI and MDP OPP tables and power-domains

2020-07-01 Thread Matthias Kaehlcke
operating-points-v2 = <_opp_table>; > + power-domains = < SDM845_CX>; > > phys = <_phy>; > phy-names = "dsi"; > @@ -3450,6 +3507,8 @@ > "core", > "iface", > "bus"; > + operating-points-v2 = <_opp_table>; > + power-domains = < SDM845_CX>; > > phys = <_phy>; > phy-names = "dsi"; Reviewed-by: Matthias Kaehlcke

Re: [PATCH 4/4] arm64: dts: sc7180: Add sdhc opps and power-domains

2020-06-30 Thread Matthias Kaehlcke
On Tue, Jun 30, 2020 at 02:15:12PM +0530, Rajendra Nayak wrote: > Add the power domain supporting performance state and the corresponding > OPP tables for the sdhc device on sc7180. > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 3/4] arm64: dts: sdm845: Add sdhc opps and power-domains

2020-06-30 Thread Matthias Kaehlcke
On Tue, Jun 30, 2020 at 02:15:11PM +0530, Rajendra Nayak wrote: > Add the power domain supporting performance state and the corresponding > OPP tables for the sdhc device on sdm845. > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 2/4] arm64: dts: sc7180: Add OPP table for all qup devices

2020-06-30 Thread Matthias Kaehlcke
port scaling and uses a fixed clock. > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke

Re: [PATCH 1/4] arm64: dts: sdm845: Add OPP table for all qup devices

2020-06-30 Thread Matthias Kaehlcke
port scaling and uses a fixed clock. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-06-30 Thread Matthias Kaehlcke
On Tue, Jun 16, 2020 at 01:38:49PM -0700, Matthias Kaehlcke wrote: > On Tue, Jun 16, 2020 at 10:22:47AM +0530, Sandeep Maheswaram (Temp) wrote: > > > > On 6/16/2020 1:12 AM, Matthias Kaehlcke wrote: > > > On Thu, Jun 04, 2020 at 04:16:31AM -0700, Stephen Boyd wrote:

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-25 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > >

Re: [PATCH v3 04/17] arm64: dts: sc7180: Add OPP table for all qup devices

2020-06-25 Thread Matthias Kaehlcke
Hi Rajendra, On Tue, Apr 28, 2020 at 07:02:52PM +0530, Rajendra Nayak wrote: > qup has a requirement to vote on the performance state of the CX domain > in sc7180 devices. Add OPP tables for these and also add power-domains > property for all qup instances. > > Signed-off-by: Rajendra Nayak >

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > > > Wait, so *some* of the series should go together but not other bits? &g

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:39:48AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > > > > Aren't there dependencies on earlier patches in the series? > > &

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:09:33AM -0700, Matthias Kaehlcke wrote: > > Hi Mark, > > > > do you plan to land this in your tree? > > > > I know you hate contentless pings, but since you acked this patch

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
> Signed-off-by: Rajendra Nayak > Reviewed-by: Matthias Kaehlcke > Acked-by: Mark Brown > Cc: Alok Chauhan > Cc: Akash Asthana > Cc: linux-...@vger.kernel.org > --- > No functional change in v6, rebased over 5.8-rc1 > > drivers/spi/spi-qcom-qspi.c | 28 +++

Re: [PATCH v3 2/6] drm: msm: a6xx: send opp instead of a frequency

2020-06-24 Thread Matthias Kaehlcke
Hi, On Thu, Jun 18, 2020 at 10:52:09AM -0700, Rob Clark wrote: > On Fri, Jun 5, 2020 at 9:26 PM Sharat Masetty wrote: > > > > This patch changes the plumbing to send the devfreq recommended opp rather > > than the frequency. Also consolidate and rearrange the code in a6xx to set > > the GPU

Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-22 Thread Matthias Kaehlcke
nkar Reviewed-by: Matthias Kaehlcke

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-18 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 11:33:49AM -0600, Rob Herring wrote: > On Thu, Jun 18, 2020 at 10:51 AM Matthias Kaehlcke wrote: > > > > On Thu, Jun 18, 2020 at 05:58:20PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Jun 18, 2020 at 08:45:55AM -0700, Matthias Kaehlck

Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-18 Thread Matthias Kaehlcke
On Wed, Jun 17, 2020 at 10:13:21PM +0530, Sibi Sankar wrote: > On 2020-06-17 03:41, Matthias Kaehlcke wrote: > > Hi Sibi, > > > > after doing the review I noticed that Viresh replied on the cover letter > > that he picked the series up for v5.9, so I'm not sure if it m

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-18 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 05:58:20PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 18, 2020 at 08:45:55AM -0700, Matthias Kaehlcke wrote: > > Hi Greg, > > > > On Thu, Jun 18, 2020 at 10:14:43AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jun 03, 2020 at 12:09:

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-18 Thread Matthias Kaehlcke
Hi Greg, On Thu, Jun 18, 2020 at 10:14:43AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 03, 2020 at 12:09:52AM +0530, Sandeep Maheswaram wrote: > > Export the symbol device_is_bound so that it can be used by the modules. > > What modules need this? drivers/usb/dwc3/dwc3-qcom.c (and probably

Re: [PATCH v6 0/6] DVFS for IO devices on sdm845 and sc7180

2020-06-17 Thread Matthias Kaehlcke
What is the plan for landing these, it seems not all must/should go through the QCOM tree. My guesses: tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state spi: spi-geni-qcom: Use OPP API to set clk/perf state QCOM tree due to shared dependency on change in

Re: [PATCH] usb: dwc3: qcom: Make sure core device is fully initialized before it is used

2020-06-17 Thread Matthias Kaehlcke
Hi Stephen, On Wed, Jun 17, 2020 at 12:49:13PM -0700, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2020-06-16 13:37:37) > > dwc3_qcom_of_register_core() uses of_platform_populate() to add > > the dwc3 core device. The driver core will try to probe the device, > > however

Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-16 Thread Matthias Kaehlcke
Hi Sibi, after doing the review I noticed that Viresh replied on the cover letter that he picked the series up for v5.9, so I'm not sure if it makes sense to send a v7. On Wed, Jun 17, 2020 at 02:35:00AM +0530, Sibi Sankar wrote: > > > @@ -112,7 +178,7 @@ static int

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-16 Thread Matthias Kaehlcke
ev->p && klist_node_attached(>p->knode_driver); > } > +EXPORT_SYMBOL_GPL(device_is_bound); > > static void driver_bound(struct device *dev) > { Reviewed-by: Matthias Kaehlcke

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-06-16 Thread Matthias Kaehlcke
On Tue, Jun 16, 2020 at 10:22:47AM +0530, Sandeep Maheswaram (Temp) wrote: > > On 6/16/2020 1:12 AM, Matthias Kaehlcke wrote: > > On Thu, Jun 04, 2020 at 04:16:31AM -0700, Stephen Boyd wrote: > > > Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09) > > > > O

[PATCH] usb: dwc3: qcom: Make sure core device is fully initialized before it is used

2020-06-16 Thread Matthias Kaehlcke
that the core device is actually bound to its driver before using it, defer probing of the dwc3_qcom device if the core device isn't ready (yet). Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver"). Signed-off-by: Matthias Kaehlcke --- depends on: https://lore.kernel.org

Re: [PATCH V4 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support

2020-06-15 Thread Matthias Kaehlcke
Sankar Reviewed-by: Matthias Kaehlcke Do you plan to send also patches that add the necessary DT entries? I'm particularly interested in SC7180.

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-06-15 Thread Matthias Kaehlcke
On Thu, Jun 04, 2020 at 04:16:31AM -0700, Stephen Boyd wrote: > Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09) > > > > On 6/3/2020 11:06 PM, Stephen Boyd wrote: > > > Quoting Sandeep Maheswaram (2020-03-31 22:15:43) > > >> diff --git a/drivers/usb/dwc3/dwc3-qcom.c

Re: [PATCH v6 5/5] cpufreq: qcom: Disable fast switch when scaling DDR/L3

2020-06-15 Thread Matthias Kaehlcke
On Sat, Jun 06, 2020 at 03:03:32AM +0530, Sibi Sankar wrote: > Disable fast switch when the opp-tables required for scaling DDR/L3 > are populated. > > Signed-off-by: Sibi Sankar not sure a separate patch is needed for this, but anyway: Reviewed-by: Matthias Kaehlcke

Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-15 Thread Matthias Kaehlcke
Hi Sibi, On Sat, Jun 06, 2020 at 03:03:31AM +0530, Sibi Sankar wrote: > Add support to parse optional OPP table attached to the cpu node when > the OPP bandwidth values are populated. This allows for scaling of > DDR/L3 bandwidth levels with frequency change. > > Signed-off-by: Sibi Sankar >

Re: [PATCH v6 3/5] OPP: Add and export helper to set bandwidth

2020-06-15 Thread Matthias Kaehlcke
On Sat, Jun 06, 2020 at 03:03:30AM +0530, Sibi Sankar wrote: > Add and export 'dev_pm_opp_set_bw' to set the bandwidth > levels associated with an OPP. > > Signed-off-by: Sibi Sankar Reviewed-by: Matthias Kaehlcke

[PATCH] Bluetooth: hci_qca: Simplify determination of serial clock on/off state from votes

2020-06-06 Thread Matthias Kaehlcke
. Signed-off-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 836949d827ee9..997ddab26a33b 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers

Re: [PATCH 1/3] Bluetooth: hci_qca: Only remove TX clock vote after TX is completed

2020-06-06 Thread Matthias Kaehlcke
Hi Bala, On Sat, Jun 06, 2020 at 06:23:13PM +0530, bgoda...@codeaurora.org wrote: > Hi Matthias, > > On 2020-06-06 00:16, Matthias Kaehlcke wrote: > > qca_suspend() removes the vote for the UART TX clock after > > writing an IBS sleep request to the serial buffer. This i

Re: [PATCH 2/3] Bluetooth: hci_qca: Skip serdev wait when no transfer is pending

2020-06-06 Thread Matthias Kaehlcke
Hi Bala, On Sat, Jun 06, 2020 at 06:27:59PM +0530, bgoda...@codeaurora.org wrote: > Hi matthias, > > On 2020-06-06 00:16, Matthias Kaehlcke wrote: > > qca_suspend() calls serdev_device_wait_until_sent() regardless of > > whether a transfer is pending. While it does

[PATCH 3/3] Bluetooth: hci_qca: Refactor error handling in qca_suspend()

2020-06-05 Thread Matthias Kaehlcke
If waiting for IBS sleep times out jump to the error handler, this is easier to read than multiple 'if' branches and a fall through to the error handler. Signed-off-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

[PATCH 0/3]

2020-06-05 Thread Matthias Kaehlcke
This series includes a fix for a possible race in qca_suspend() and some minor refactoring of the same function. Matthias Kaehlcke (3): Bluetooth: hci_qca: Only remove TX clock vote after TX is completed Bluetooth: hci_qca: Skip serdev wait when no transfer is pending Bluetooth: hci_qca

[PATCH 2/3] Bluetooth: hci_qca: Skip serdev wait when no transfer is pending

2020-06-05 Thread Matthias Kaehlcke
() is needed. Signed-off-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index b1d82d32892e9..90ffd8ca1fb0d 100644 --- a/drivers/bluetooth/hci_qca.c +++ b

[PATCH 1/3] Bluetooth: hci_qca: Only remove TX clock vote after TX is completed

2020-06-05 Thread Matthias Kaehlcke
of the vote being removed in case of an aborted suspend due to a failure of entering IBS sleep. Fixes: 41d5b25fed0a0 ("Bluetooth: hci_qca: add PM support") Signed-off-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH V2 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support

2020-06-04 Thread Matthias Kaehlcke
On Thu, Jun 04, 2020 at 04:44:42PM +0530, Pradeep P V K wrote: > Interconnect bandwidth scaling support is now added as a > part of OPP [1]. So, make sure interconnect driver is ready > before handling interconnect scaling. > > This change is based on > [1] [Patch v8] Introduce OPP bandwidth

Re: [PATCH V1 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support

2020-06-03 Thread Matthias Kaehlcke
Hi Pradeep, On Wed, Jun 03, 2020 at 02:39:35PM +0530, Pradeep P V K wrote: > Interconnect bandwidth scaling support is now added as a > part of OPP [1]. So, make sure interconnect driver is ready > before handling interconnect scaling. > > This change is based on > [1] [Patch v8] Introduce OPP

Re: [PATCH v4] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-29 Thread Matthias Kaehlcke
my 'Reviewed-by' tag from v2/v3), unless the new patch has substantial changes. Reviewed-by: Matthias Kaehlcke

<    1   2   3   4   5   6   7   8   9   10   >