Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Matthias Schiffer
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote: > On Wed, 31 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > > wrote: > > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > > On Wed, Ma

Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:39 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 3:37 PM Matthias Schiffer > wrote: > > On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > > > wrote: &

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > wrote: > > > > All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as > > a default instead of listing each new module individually. >

Re: [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:35 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:39 PM Matthias Schiffer > wrote: > > > > The driver was registering IRQ 0 when no IRQ was set. This leads to > > warnings with newer kernels. > > > > Clear the resource

Re: (EXT) Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > wrote: > > > > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > > causes warnings with newer kernels. > > > > Pr

[PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This causes warnings with newer kernels. Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a missing IRQ properly. Signed-off-by: Matthias Schiffer --- drivers/gpio/gpio-tqmx86.c | 6 +++--- 1 file

[PATCH 0/3] tqmx86: TQMxE40M support

2021-03-31 Thread Matthias Schiffer
This fixes a bug in the IRQ setup of the tqmx86 MFD / GPIO drivers and adds support for our upcoming Elkhart Lake module TQMxE40M (as well as future SoMs). As patch 2 depends on patch 1, it would make sense to push the whole series through the same tree. Matthias Schiffer (3): gpio: tqmx86

[PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as a default instead of listing each new module individually. Signed-off-by: Matthias Schiffer --- drivers/mfd/tqmx86.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/tqmx86.c b

[PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

2021-03-31 Thread Matthias Schiffer
The driver was registering IRQ 0 when no IRQ was set. This leads to warnings with newer kernels. Clear the resource flags, so no resource is registered at all in this case. Signed-off-by: Matthias Schiffer --- drivers/mfd/tqmx86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Matthias Schiffer
e759cda51b ("l2tp: use standard API for warning log messages") Signed-off-by: Matthias Schiffer --- v2: - Add counter for invalid packets - Reduce loglevel of more messages that can be abused for log spam include/uapi/linux/l2tp.h | 1 + net/l2tp/l

[PATCH v2 2/3] power: supply: bq27xxx: fix power_avg for newer ICs

2021-03-03 Thread Matthias Schiffer
to extend it to store both a signed value and an error code. Always getting an up-to-date value may be desirable anyways, as it avoids inconsistent current and power readings when switching between charging and discharging. Signed-off-by: Matthias Schiffer --- v2: fixed units in commit message

[PATCH v2 3/3] power: supply: bq27xxx: make status more robust

2021-03-03 Thread Matthias Schiffer
ce known to Linux We can solve both issues by deriving the status from the current instead of the flags field. The flags are now only used to distinguish "full" from "not charging", and to determine the sign of the current on BQ27XXX_O_ZERO devices. Signed-off-by

[PATCH v2 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-03-03 Thread Matthias Schiffer
ssume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer --- v2: no changes drivers/power/supply/bq27xxx_battery.c | 2 +- 1 file change

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-03-01 Thread Matthias Schiffer
On 2/23/21 10:47 AM, Tom Parkin wrote: On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote: On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: This will not be sufficient for my usecase: To stay compatible with older versions of fastd, I can't set the T flag in the first

Re: [PATCH 2/3] power: supply: bq27xxx: fix power_avg

2021-02-24 Thread Matthias Schiffer
On Tue, 2021-02-23 at 15:11 +0100, Matthias Schiffer wrote: > On all newer bq27xxx ICs, the AveragePower register contains a signed > value; in addition to handling the raw value as unsigned, the driver > code also didn't convert it to µW as expected. > > At least for the BQ28Z610

[PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-02-23 Thread Matthias Schiffer
ssume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer --- @Andreas Kemnade: It would be great to get a confirmation that the Openmoko battery

[PATCH 3/3] power: supply: bq27xxx: make status more robust

2021-02-23 Thread Matthias Schiffer
ce known to Linux We can solve both issues by deriving the status from the current instead of the flags field. The flags are now only used to distinguish "full" from "not charging", and to determine the sign of the current on BQ27XXX_O_ZERO devices. Signed-off-by: Matt

[PATCH 2/3] power: supply: bq27xxx: fix power_avg

2021-02-23 Thread Matthias Schiffer
to extend it to store both a signed value and an error code. Always getting an up-to-date value may be desirable anyways, as it avoids inconsistent current and power readings when switching between charging and discharging. Signed-off-by: Matthias Schiffer --- drivers/power/supply/bq27xxx_battery.c

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Matthias Schiffer
On 2/22/21 12:49 PM, Tom Parkin wrote: On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: On 2/19/21 9:12 PM, Tom Parkin wrote: On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log mes

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-20 Thread Matthias Schiffer
Hi Tom, On 2/19/21 9:12 PM, Tom Parkin wrote: Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it was possible for userspace applications to use

[PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-19 Thread Matthias Schiffer
TP version are checked before the T flag. Reduce all warnings debug level when packets are passed to userspace. Fixes: 5ee759cda51b ("l2tp: use standard API for warning log messages") Signed-off-by: Matthias Schiffer --- I'm unsure what to do about the pr_warn_ratelimited() in l2tp_rec

[PATCH] dt-bindings: vendor-prefixes: correct the spelling of TQ-Systems GmbH

2020-12-07 Thread Matthias Schiffer
From: Max Merchel "TQ-Systems" is written with a dash, as can be seen on https://www.tq-group.com/en/imprint/ Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 1/2] ARM: dts: imx7-tqma7: add SPI-NOR flash

2020-10-30 Thread Matthias Schiffer
The SPI-NOR flash on the SoM was missing from the device tree. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++ 1 file changed, 30 insertions(+) v2: change node name to flash@0 diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch

[PATCH v2 2/2] ARM: dts: imx7-mba7: add default SPI-NOR flash partition layout

2020-10-30 Thread Matthias Schiffer
Add the partition layout also used by the bootloader. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 32 1 file changed, 32 insertions(+) v2: no changes diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi

Re: [PATCH 01/13] dt-bindings: arm: fsl: update TQ-Systems SoMs and boards based on i.MX7

2020-10-22 Thread Matthias Schiffer
On Fri, 2020-09-18 at 13:29 +0200, Matthias Schiffer wrote: > Introduce compatible strings for the TQMa7x SoMs. > > Signed-off-by: Matthias Schiffer Hello Shawn, what is the status of this patch series? I've found the series marked as "archived" in patchwork [1], but I c

[PATCH] tty: serial: imx: disable TXDC IRQ in imx_uart_shutdown() to avoid IRQ storm

2020-09-25 Thread Matthias Schiffer
errupt, but this register write is ineffective. This results in an interrupt storm. To disable all interrupts in the same place, and to avoid setting UCR4 twice, clearing UCR4_OREN is moved below del_timer_sync() as well; this should be harmless. Signed-off-by: Matthias Schiffer --- While debugging t

[PATCH 09/13] ARM: dts: imx7-mba7: add audio support

2020-09-18 Thread Matthias Schiffer
The MBa7x is equipped with a TI TLV320AIC3204 audio codec. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 38 +++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7

[PATCH 07/13] ARM: dts: imx7-mba7: configure watchdog

2020-09-18 Thread Matthias Schiffer
The external watchdog reset is necessary, as the internal reset is unreliable on i.MX7. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi

[PATCH 11/13] ARM: dts: imx7-mba7: enable RS485 on UART7

2020-09-18 Thread Matthias Schiffer
The UART7 interface is connected to a full-duplex RS485 transceiver. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi index f1e50bcd21a5..cd29844bc76b

[PATCH 02/13] ARM: dts: imx7-tqma7: add SPI-NOR flash

2020-09-18 Thread Matthias Schiffer
The SPI-NOR flash on the SoM was missing from the device tree. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi index

[PATCH 12/13] ARM: dts: imx7-mba7: specify USB over-current polarity

2020-09-18 Thread Matthias Schiffer
Add over-current-active-low to usbotg1. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi index cd29844bc76b..52b8f66f9982 100644 --- a/arch/arm/boot/dts

[PATCH 10/13] ARM: dts: imx7-mba7: add default SPI-NOR flash partition layout

2020-09-18 Thread Matthias Schiffer
Add the partition layout also used by the bootloader. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi index

[PATCH 05/13] ARM: dts: imx7-mba7: remove unsupported PHY LED setup

2020-09-18 Thread Matthias Schiffer
These properties were never supported by the DP83867, and a patch implementing them was rejected in favor of a different solution. Remove them. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 4 arch/arm/boot/dts/imx7d-mba7.dts | 4 2 files changed, 8 deletions

[PATCH 13/13] ARM: dts: imx7-mba7: set dr_mode to otg on usbotg1

2020-09-18 Thread Matthias Schiffer
USBOTG1 has a Micro-USB port that can be used in host mode (using an OTG cable) or device mode. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7

[PATCH 06/13] ARM: dts: imx7-mba7: disable ethernet PHY clock outputs

2020-09-18 Thread Matthias Schiffer
The clock outputs are not connected. Disable them to improve EMI behaviour. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 1 + arch/arm/boot/dts/imx7d-mba7.dts | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts

[PATCH 01/13] dt-bindings: arm: fsl: update TQ-Systems SoMs and boards based on i.MX7

2020-09-18 Thread Matthias Schiffer
Introduce compatible strings for the TQMa7x SoMs. Signed-off-by: Matthias Schiffer --- Documentation/devicetree/bindings/arm/fsl.yaml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree

[PATCH 08/13] ARM: dts: imx7-mba7: update MMC aliases

2020-09-18 Thread Matthias Schiffer
Together with the recently merged support for alias-based MMC host numbering, this makes the MMC devices names match what the bootloader expects. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 03/13] ARM: dts: imx7-mba7: update compatible strings

2020-09-18 Thread Matthias Schiffer
Include the SoM compatible string. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7d-mba7.dts | 2 +- arch/arm/boot/dts/imx7s-mba7.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d-mba7.dts b/arch/arm/boot/dts/imx7d-mba7.dts index

[PATCH 04/13] ARM: dts: imx7-mba7: drop incorrect num-chipselects property

2020-09-18 Thread Matthias Schiffer
This property was never set correctly; it should have been num-cs. As num-cs support is being removed as well, simply drop it. Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7-mba7.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm

Re: [PATCH] drm: fsl-dcu: enable PIXCLK on LS1021A

2020-09-18 Thread Matthias Schiffer
On Fri, 2020-08-21 at 15:41 +0200, Stefan Agner wrote: > Hi Matthias, > > On 2020-08-20 12:58, Matthias Schiffer wrote: > > The PIXCLK needs to be enabled in SCFG before accessing the DCU on LS1021A, > > or the access will hang. > > Hm, this seems a rather ad-hoc acce

[PATCH net] net: dsa: microchip: ksz8795: really set the correct number of ports

2020-09-16 Thread Matthias Schiffer
driver (which completely broke probing, as the CPU port index was always failing the num_ports check). Fixes: af199a1a9cb0 ("net: dsa: microchip: set the correct number of ports") Signed-off-by: Matthias Schiffer --- drivers/net/dsa/microchip/ksz8795.c | 2 +- 1 file changed, 1 inser

[PATCH] i2c: mxs: use MXS_DMA_CTRL_WAIT4END instead of DMA_CTRL_ACK

2020-09-11 Thread Matthias Schiffer
: rename custom flag") Signed-off-by: Matthias Schiffer --- I'm a bit out of my depth here - I have no idea what these flags are supposed to do. Looking at ceeeb99cd821, this is what I came up with, and it fixes I2C communication with multiple devices (an EEPROM and a PCF85063TP RTC) on one of o

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-11 Thread Matthias Schiffer
On Thu, 2020-09-10 at 17:00 +0200, Andrew Lunn wrote: > > I propose that at least these HW modes should be available (and > > documented) for ethernet PHY controlled LEDs: > > mode to determine link on: > > - `link` > > mode for activity (these should blink): > > - `activity` (both rx

Re: [PATCH] of: skip disabled CPU nodes

2020-09-09 Thread Matthias Schiffer
On Thu, 2020-08-27 at 09:10 +0200, Matthias Schiffer wrote: > On Wed, 2020-08-26 at 13:26 -0600, Rob Herring wrote: > > On Wed, Aug 26, 2020 at 8:47 AM Frank Rowand < > > frowand.l...@gmail.com> > > wrote: > > > > > > Hi Rob, > > > >

[PATCH v3 2/3] ARM: dts: imx6qdl: tqma6: remove obsolete fsl,spi-num-chipselects

2020-09-07 Thread Matthias Schiffer
This property is unneeded and not supported by the spi-imx driver. Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- v3: split patch v2: drop fsl,spi-num-chipselects instead of replacing with num-cs arch/arm/boot/dts/imx6qdl-tqma

[PATCH v3 3/3] ARM: dts: imx6qdl: tqma6: fix LM75 compatible string

2020-09-07 Thread Matthias Schiffer
Specify the National LM75 sensor including its vendor name, as mandated by the binding docs. Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- v3: split patch arch/arm/boot/dts/imx6qdl-tqma6a.dtsi | 2 +- arch/arm/boot/d

[PATCH v3 1/3] ARM: dts: imx6qdl: tqma6: fix indentation

2020-09-07 Thread Matthias Schiffer
The PMIC configuration is indented one level too deep. Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- v3: extended commit message v2: no changes arch/arm/boot/dts/imx6qdl-tqma6.dtsi | 188 +-- 1 file c

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-07 Thread Matthias Schiffer
On Fri, 2020-09-04 at 12:42 -0300, Fabio Estevam wrote: > Hi Mark, > > On Fri, Sep 4, 2020 at 12:05 PM Mark Brown > wrote: > > > > On Fri, Sep 04, 2020 at 04:34:43PM +0200, Matthias Schiffer wrote: > > > > > Nevertheless, I don't see why we should delibe

Re: (EXT) Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-04 Thread Matthias Schiffer
On Fri, 2020-09-04 at 10:57 -0300, Fabio Estevam wrote: > On Fri, Sep 4, 2020 at 10:02 AM Matthias Schiffer > wrote: > > > This would make num_chipselect default to 1 again (set by > > __spi_alloc_controller()), breaking every i.MX board that uses more > > than 1 n

Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-04 Thread Matthias Schiffer
On Fri, 2020-09-04 at 09:35 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Thu, Sep 3, 2020 at 11:40 AM Matthias Schiffer > wrote: > > > > The num-cs property is not considered useful, and no in-tree Device > > Trees define it for spi-imx. > > > &g

Re: spi-imx: correct interpretation of num-cs DT property?

2020-09-03 Thread Matthias Schiffer
On Thu, 2020-09-03 at 14:22 +0100, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Sep 03, 2020 at 11:22:20AM +0200, Matthias Schiffer wrote: > > > - If num-cs is set, use that > > - If num-cs is unset, use the number of cs-gpios > > - If n

[PATCH v2 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-09-03 Thread Matthias Schiffer
- Fix national,lm75 compatible string - Remove obsolete fsl,spi-num-chipselects Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- v2: drop fsl,spi-num-chipselects instead of replacing with num-cs arch/arm/boot/dts/imx6qdl-tqma6

[PATCH v2 1/2] ARM: dts: imx6qdl: tqma6: fix indentation

2020-09-03 Thread Matthias Schiffer
Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- v2: no changes arch/arm/boot/dts/imx6qdl-tqma6.dtsi | 188 +-- 1 file changed, 94 insertions(+), 94 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tqm

[PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-03 Thread Matthias Schiffer
(for example the i.MX27 has 3 CS pins on CSPI1 and CSPI2, and only a single CS on CSPI3). Attempting to use the nonexisting CS pin would be an easy to notice DT misconfiguration; making the driver catch this doesn't seem worthwhile. Signed-off-by: Matthias Schiffer --- drivers/spi/spi-imx.c | 13

spi-imx: correct interpretation of num-cs DT property?

2020-09-03 Thread Matthias Schiffer
Hi, I've recently had a discussion about the correct way for an SPI driver to handle the num-cs property: https://lkml.org/lkml/2020/8/25/184 Since 8cdcd8aeee281 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors"), the logic of the spi-imx driver is somewhat confusing: If fewer than 3 cs-gpios

[PATCH 1/2] ASoC: codec: tlv320aic32x4: fix missing aic32x4_disable_regulators() in error path

2020-09-02 Thread Matthias Schiffer
The regulators need to be disabled in the aic32x4_register_clocks() failure case as well. Fixes: 9d4befff5a95 ("ASoC: codec: tlv3204: Moving GPIO reset and add ADC reset") Signed-off-by: Matthias Schiffer --- sound/soc/codecs/tlv320aic32x4.c | 10 +++--- 1 file changed, 7 insert

[PATCH 2/2] ASoC: codec: tlv320aic32x4: do software reset before clock registration

2020-09-02 Thread Matthias Schiffer
, so the reset in aic32x4_component_probe() was happening too late. Signed-off-by: Matthias Schiffer --- sound/soc/codecs/tlv320aic32x4.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index

[PATCH mmc-next v4 2/2] mmc: allow setting slot index via device tree alias

2020-09-01 Thread Matthias Schiffer
.html . Based-on-patch-by: Sascha Hauer Link: https://lkml.org/lkml/2020/8/5/194 Signed-off-by: Matthias Schiffer --- v4: - minor adjustments to commit message v3: - remove unneeded mmcblock changes - remove most helper functions to simplify code - extended commit message v2: - fix missing symbols

[PATCH mmc-next v4 1/2] dt-bindings: mmc: document alias support

2020-09-01 Thread Matthias Schiffer
As for I2C and SPI, it now is possible to reserve a fixed index for mmc/mmcblk devices. Signed-off-by: Matthias Schiffer --- v4: moved alias documentation from example to description v3: new patch Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 4 1 file changed, 4

Re: [PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example

2020-08-31 Thread Matthias Schiffer
On Fri, 2020-08-28 at 16:24 -0600, Rob Herring wrote: > On Tue, Aug 25, 2020 at 03:44:40PM +0200, Matthias Schiffer wrote: > > As for I2C and SPI, it now is possible to reserve a fixed index for > > mmc/mmcblk devices. > > > > Signed-off-by: Matthias Schiffer > &g

Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-27 Thread Matthias Schiffer
On Wed, 2020-08-26 at 10:49 -0300, Fabio Estevam wrote: > On Wed, Aug 26, 2020 at 10:13 AM Matthias Schiffer > wrote: > > > Using GPIOs for chipselect would require different pinmuxing. Also, > > why > > use GPIOs, when the SPI controller has this built in

Re: (EXT) Re: (EXT) Re: [PATCH] of: skip disabled CPU nodes

2020-08-27 Thread Matthias Schiffer
On Wed, 2020-08-26 at 13:26 -0600, Rob Herring wrote: > On Wed, Aug 26, 2020 at 8:47 AM Frank Rowand > wrote: > > > > Hi Rob, > > > > On 2020-08-26 08:54, Matthias Schiffer wrote: > > > On Wed, 2020-08-26 at 08:01 -0500, Frank Rowand wrote: > > >

Re: (EXT) Re: [PATCH] of: skip disabled CPU nodes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 08:01 -0500, Frank Rowand wrote: > On 2020-08-26 07:02, Matthias Schiffer wrote: > > Allow disabling CPU nodes using status = "disabled". > > > > This allows a bootloader to change the number of available CPUs > > (for > > example

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 10:01 -0300, Fabio Estevam wrote: > On Wed, Aug 26, 2020 at 8:54 AM Matthias Schiffer > wrote: > > > Before 8cdcd8aeee281, num_chipselect was set to 3 for spi0 and to 1 > > for > > spi1 in arch/arm/mach-imx/mach-mx31lite.c. My understanding is

[PATCH] of: skip disabled CPU nodes

2020-08-26 Thread Matthias Schiffer
re the CPU nodes are referenced, e.g. a cooling map). Signed-off-by: Matthias Schiffer --- drivers/of/base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index ea44fea99813..d547e9deced1 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -79

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 07:59 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Wed, Aug 26, 2020 at 7:32 AM Matthias Schiffer > wrote: > > > But the previous platform data that was removed in 8cdcd8aeee281 > > ("spi: > > imx/fsl-lpspi: Convert to G

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 12:32 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > > wrote: > > > > > Makes sense. Does the following logic sound correct? > &

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > wrote: > > > Makes sense. Does the following logic sound correct? > > > > - If num-cs is set, use that (and add it to the docs) > > I would not add nu

Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:24 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Tue, Aug 25, 2020 at 4:22 AM Matthias Schiffer > wrote: > > > Hmm, unless I'm overlooking something, this is not going to work: > > > > - spi_get_gpio_descs() s

[PATCH mmc-next v3 2/2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
/msg26588.html . Based-on-patch-by: Sascha Hauer Link: https://lkml.org/lkml/2020/8/5/194 Signed-off-by: Matthias Schiffer --- v3: - remove unneeded mmcblock changes - remove most helper functions to simplify code - extended commit message v2: - fix missing symbols for modular mmcblock drivers

[PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example

2020-08-25 Thread Matthias Schiffer
As for I2C and SPI, it now is possible to reserve a fixed index for mmc/mmcblk devices. Signed-off-by: Matthias Schiffer --- v3: new patch Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings

Re: (EXT) Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 14:27 +0200, Ulf Hansson wrote: > On Tue, 25 Aug 2020 at 14:00, Matthias Schiffer > wrote: > > > > On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > > > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > > > On Thu,

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > > wrote: > > > --- a/drivers/mmc/core/host.c > > > +++ b/drivers/mmc/core/host.c > >

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > > wrote: > > > + > > > +static void __init mmc_of_reserve_idx(void) > > > +{ > &

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > wrote: > > > > As with GPIO, UART and others, allow specifying the device index > > via the > > aliases node in the device tree. > > > > On embe

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-07-28 at 17:05 +0200, Marek Behún wrote: > Hi, > > this is v4 of my RFC adding support for LEDs connected to Marvell > PHYs. > > Please note that if you want to test this, you still need to first > apply > the patch adding the LED private triggers support from Pavel's tree. >

Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Matthias Schiffer
On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer > wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > index 9513020ddd1a..7aaae

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-24 Thread Matthias Schiffer
On Fri, 2020-08-21 at 13:39 +0200, Ulf Hansson wrote: > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > wrote: > > > > As with GPIO, UART and others, allow specifying the device index > > via the > > aliases node in the device tree. > > > > On embe

[PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-24 Thread Matthias Schiffer
- Fix national,lm75 compatible string - Replace obsolete fsl,spi-num-chipselects with num-cs Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx6qdl-tqma6.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-tqma6a.dtsi | 2 +-

[PATCH 1/2] ARM: dts: imx6qdl: tqma6: fix indentation

2020-08-24 Thread Matthias Schiffer
Fixes: cac849e9bbc8 ("ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM") Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx6qdl-tqma6.dtsi | 188 +-- 1 file changed, 94 insertions(+), 94 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi b/arch/ar

Re: (EXT) Re: [PATCH net-next 2/2] net: phy: dp83867: apply ti, led-function and ti, led-ctrl to registers

2020-08-24 Thread Matthias Schiffer
On Sat, 2020-08-22 at 18:08 +0200, Andrew Lunn wrote: > On Fri, Aug 21, 2020 at 09:21:46AM +0200, Matthias Schiffer wrote: > > These DT bindings are already in use by the imx7-mba7 DTS, but they > > were > > not supported by the PHY driver so far. > > > >

[PATCH net-next 1/2] dt-bindings: dp83867: add ti,led-function and ti,led-ctrl properties

2020-08-21 Thread Matthias Schiffer
. Signed-off-by: Matthias Schiffer --- .../devicetree/bindings/net/ti,dp83867.yaml | 18 ++ include/dt-bindings/net/ti-dp83867.h | 60 +++ 2 files changed, 78 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree

[PATCH net-next 2/2] net: phy: dp83867: apply ti,led-function and ti,led-ctrl to registers

2020-08-21 Thread Matthias Schiffer
These DT bindings are already in use by the imx7-mba7 DTS, but they were not supported by the PHY driver so far. Signed-off-by: Matthias Schiffer --- drivers/net/phy/dp83867.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers

[PATCH 2/2] ASoC: fsl-asoc-card: add support for TLV320AIC32x4 codec

2020-08-21 Thread Matthias Schiffer
The TLV320AIC32x4 is commonly used on TQ-Systems starterkit mainboards for i.MX-based SoMs (i.MX6Q/DL, i.MX6UL, i.MX7) and LS1021A. Signed-off-by: Matthias Schiffer --- sound/soc/fsl/Kconfig | 2 +- sound/soc/fsl/fsl-asoc-card.c | 4 2 files changed, 5 insertions(+), 1 deletion

[PATCH 1/2] ASoC: bindings: fsl-asoc-card: add compatible string for TLV320AIC32x4 codec

2020-08-21 Thread Matthias Schiffer
The TLV320AIC32x4 is commonly used on TQ-Systems starterkit mainboards for i.MX-based SoMs (i.MX6Q/DL, i.MX6UL, i.MX7) and LS1021A. Signed-off-by: Matthias Schiffer --- Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH] drm: fsl-dcu: enable PIXCLK on LS1021A

2020-08-20 Thread Matthias Schiffer
The PIXCLK needs to be enabled in SCFG before accessing the DCU on LS1021A, or the access will hang. Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 25 +++ drivers/gpu/drm/fsl-dcu

[PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-20 Thread Matthias Schiffer
-on-patch-by: Sascha Hauer Link: https://lkml.org/lkml/2020/8/5/194 Signed-off-by: Matthias Schiffer --- v2: fix missing symbols for modular mmcblock drivers/mmc/core/block.c | 13 +++-- drivers/mmc/core/core.c | 40 drivers/mmc/core/core.h | 3

[PATCH mmc-next] mmc: allow setting slot index via device tree alias

2020-08-19 Thread Matthias Schiffer
-on-patch-by: Sascha Hauer Signed-off-by: Matthias Schiffer Link: https://lkml.org/lkml/2020/8/5/194 --- drivers/mmc/core/block.c | 13 +++-- drivers/mmc/core/core.c | 38 ++ drivers/mmc/core/core.h | 3 +++ drivers/mmc/core/host.c | 15

Re: (EXT) Re: (EXT) Re: Consistent block device references for root= cmdline

2020-07-29 Thread Matthias Schiffer
On Tue, 2020-07-07 at 16:14 +0200, Ulf Hansson wrote: > On Thu, 11 Jun 2020 at 13:20, Matthias Schiffer > wrote: > > > > On Wed, 2020-06-10 at 16:52 +0200, Ulf Hansson wrote: > > > On Wed, 10 Jun 2020 at 15:15, Matthias Schiffer > > >

[PATCH v3] arm: dts: imx7: add QSPI

2020-07-29 Thread Matthias Schiffer
In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add the QSPI controller to imx7s.dtsi. Based-on-patch-by: Han Xu Signed-off-by: Matthias Schiffer --- v3: - reverted node name change v2: - renamed node and label - reordered properties arch/arm/boot/dts/imx7s.dtsi | 13

Re: [PATCH v2] arm: dts: imx7: add QSPI

2020-07-29 Thread Matthias Schiffer
On Wed, 2020-07-29 at 09:11 +0200, Matthias Schiffer wrote: > In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add > the > QSPI controller to imx7s.dtsi. > > Based-on-patch-by: Han Xu > Signed-off-by: Matthias Schiffer > --- > > v2: > - rename

[PATCH v2] arm: dts: imx7: add QSPI

2020-07-29 Thread Matthias Schiffer
In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add the QSPI controller to imx7s.dtsi. Based-on-patch-by: Han Xu Signed-off-by: Matthias Schiffer --- v2: - renamed node and label - reordered properties (as suggested by Marco Felsch) arch/arm/boot/dts/imx7s.dtsi | 13

Re: (EXT) Re: [PATCH] arm: dts: imx7: add QSPI

2020-07-28 Thread Matthias Schiffer
On Tue, 2020-07-28 at 15:51 +0200, Marco Felsch wrote: > Hi Matthias, > > thanks for the patch. > > On 20-07-28 13:28, Matthias Schiffer wrote: > > In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, > > add the > > QSPI controller to imx7s.dtsi. &

[PATCH] arm: dts: imx7: add QSPI

2020-07-28 Thread Matthias Schiffer
In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add the QSPI controller to imx7s.dtsi. Based-on-patch-by: Han Xu Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/imx7s.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b

[PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range

2020-07-28 Thread Matthias Schiffer
failed with error -12 Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC") Signed-off-by: Matthias Schiffer --- arch/arm/boot/dts/ls1021a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/ar

Re: (EXT) Re: [PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

2020-06-29 Thread Matthias Schiffer
On Mon, 2020-06-29 at 13:02 +, tudor.amba...@microchip.com wrote: > Hi, Matthias, > > On 6/10/20 12:16 PM, Matthias Schiffer wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > From:

[PATCH RESEND v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-12 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- v2: - removed vrefresh - added connector_type drive

[PATCH RESEND v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-12 Thread Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- v2: no changes .../devicetree/bindings/display/panel/panel-simple.yaml | 4 1 file changed, 4

[PATCH RESEND v2 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33

2020-06-12 Thread Matthias Schiffer
From: Matthias Schiffer This adds a few panels TQ-Systems uses with various starterkit mainboards. Device trees actually using these panels will be added with a later submission. Matthias Schiffer (2): dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 dt

[PATCH RESEND v2 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-12 Thread Matthias Schiffer
From: Max Merchel Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to panel-simple. Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- v2: - added connector_type - fixed bus_format drivers/gpu/drm/panel/panel-simple.c | 15 +++ 1

  1   2   3   >