Re:

2019-03-21 Thread Maxim Levitsky
threads and redistribute the work. > > F. Note though that SPDK doesn't support sharing the device between host and the guests, it takes over the nvme device, thus it makes the kernel nvme driver unbind from it. My driver creates a polling thread per guest, but its trivial to add option to use the same polling thread for many guests if there need for that. Best regards, Maxim Levitsky

Re:

2019-03-20 Thread Maxim Levitsky
On Wed, 2019-03-20 at 11:03 +, Felipe Franciosi wrote: > > On Mar 19, 2019, at 2:41 PM, Maxim Levitsky wrote: > > > > Date: Tue, 19 Mar 2019 14:45:45 +0200 > > Subject: [PATCH 0/9] RFC: NVME VFIO mediated device > > > > Hi everyone! > > > >

Re: your mail

2019-03-20 Thread Maxim Levitsky
On Wed, 2019-03-20 at 11:03 -0600, Keith Busch wrote: > On Wed, Mar 20, 2019 at 06:30:29PM +0200, Maxim Levitsky wrote: > > Or instead I can use the block backend, > > (but note that currently the block back-end doesn't support polling which is > > critical for the performan

Re: [PATCH 0/9] RFC: NVME VFIO mediated device

2019-03-20 Thread Maxim Levitsky
On Wed, 2019-03-20 at 08:08 -0700, Bart Van Assche wrote: > On Tue, 2019-03-19 at 16:41 +0200, Maxim Levitsky wrote: > > * Polling kernel thread is used. The polling is stopped after a > > predefined timeout (1/2 sec by default). > > Support for all interrupt driven mode is

Re: your mail

2019-03-20 Thread Maxim Levitsky
On Tue, 2019-03-19 at 23:49 +, Chaitanya Kulkarni wrote: > Hi Keith, > On 03/19/2019 08:21 AM, Keith Busch wrote: > > On Tue, Mar 19, 2019 at 04:41:07PM +0200, Maxim Levitsky wrote: > > >-> Share the NVMe device between host and guest. > > > Even in

Re: [PATCH 0/9] RFC: NVME VFIO mediated device

2019-03-20 Thread Maxim Levitsky
On Wed, 2019-03-20 at 08:28 -0700, Bart Van Assche wrote: > On Tue, 2019-03-19 at 16:41 +0200, Maxim Levitsky wrote: > > * All guest memory is mapped into the physical nvme device > >but not 1:1 as vfio-pci would do this. > >This allows very efficient DMA. > >

Re: your mail

2019-03-20 Thread Maxim Levitsky
On Tue, 2019-03-19 at 09:22 -0600, Keith Busch wrote: > On Tue, Mar 19, 2019 at 04:41:07PM +0200, Maxim Levitsky wrote: > > -> Share the NVMe device between host and guest. > > Even in fully virtualized configurations, > > some partitions of nvme device

Re: [PATCH 7/9] nvme/core: add mdev interfaces

2019-03-20 Thread Maxim Levitsky
On Wed, 2019-03-20 at 11:46 +, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2019 at 04:41:14PM +0200, Maxim Levitsky wrote: > > +int nvme_core_register_mdev_driver(struct nvme_mdev_driver *driver_ops) > > +{ > > + struct nvme_ctrl *ctrl; > > + > &

[PATCH 0/9] RFC: NVME VFIO mediated device

2019-03-19 Thread Maxim Levitsky
Oops, I placed the subject in the wrong place. Best regards, Maxim Levitsky On Tue, 2019-03-19 at 16:41 +0200, Maxim Levitsky wrote: > Date: Tue, 19 Mar 2019 14:45:45 +0200 > Subject: [PATCH 0/9] RFC: NVME VFIO mediated device > > Hi everyone! > > In this patch se

[PATCH 9/9] nvme/pci: implement the mdev external queue allocation interface

2019-03-19 Thread Maxim Levitsky
Note that currently the number of hw queues reserved for mdev, has to be pre determined on module load. (I used to allocate the queues dynamicaly on demand, but recent changes to allocate polled/read queues made this somewhat difficult, so I dropped this for now) Signed-off-by: Maxim Levitsky

[PATCH 7/9] nvme/core: add mdev interfaces

2019-03-19 Thread Maxim Levitsky
-by: Maxim Levitsky --- drivers/nvme/host/core.c | 125 ++- drivers/nvme/host/nvme.h | 54 +++-- 2 files changed, 172 insertions(+), 7 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index e1cef428c7e9..90561973bce9 100644

[PATCH 5/9] nvme/pci: add known admin effects to augument admin effects log page

2019-03-19 Thread Maxim Levitsky
Add known admin effects even if hardware has known admin effects page, since hardware can't be ever trusted to report sane values. (on my Intel DC P3700, it reports no side effects for namespace format) Signed-off-by: Maxim Levitsky --- drivers/nvme/host/core.c | 4 ++-- 1 file changed, 2

[PATCH 6/9] nvme/pci: init shadow doorbell after each reset

2019-03-19 Thread Maxim Levitsky
The spec states "The settings are not retained across a Controller Level Reset" Therefore the driver must enable the shadow doorbell, after each reset. This was caught while testing the nvme driver over upcoming nvme-mdev device Signed-off-by: Maxim Levitsky --- drivers/nvme/host

[PATCH 4/9] nvme/pci: use the NVME_CTRL_SUSPENDED state

2019-03-19 Thread Maxim Levitsky
When enteriing low power state, the nvme driver will now inform the core with the NVME_CTRL_SUSPENDED state which will allow mdev driver to act on this information Signed-off-by: Maxim Levitsky --- drivers/nvme/host/pci.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 3/9] nvme/core: add NVME_CTRL_SUSPENDED controller state

2019-03-19 Thread Maxim Levitsky
This state will be used by a controller that is going to suspended state, and will later be used by mdev framework to detect this and flush its queues Signed-off-by: Maxim Levitsky --- drivers/nvme/host/core.c | 15 +++ drivers/nvme/host/nvme.h | 1 + 2 files changed, 16 insertions

[PATCH 1/9] vfio/mdev: add .request callback

2019-03-19 Thread Maxim Levitsky
This will allow the hotplug to be enabled for mediated devices Signed-off-by: Maxim Levitsky --- drivers/vfio/mdev/vfio_mdev.c | 11 +++ include/linux/mdev.h | 4 2 files changed, 15 insertions(+) diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c

[PATCH 2/9] nvme/core: add some more values from the spec

2019-03-19 Thread Maxim Levitsky
This adds few defines from the spec, that will be used in the nvme-mdev driver Signed-off-by: Maxim Levitsky --- include/linux/nvme.h | 88 ++-- 1 file changed, 68 insertions(+), 20 deletions(-) diff --git a/include/linux/nvme.h b/include/linux/nvme.h

[no subject]

2019-03-19 Thread Maxim Levitsky
bit host/guest combination was lightly tested too. In addition to that, the virtual device was tested with nested guest, by passing the virtual device to it, using pci passthrough, qemu userspace nvme driver, and spdk PS: I used to contribute to the kernel as a hobby using the maximlevit.

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-05 Thread Maxim Levitsky
On Sun, 2018-11-04 at 11:40 -0500, Vitaly Mayatskih wrote: > On Sun, Nov 4, 2018 at 6:57 AM Maxim Levitsky wrote: > > > Hi! > > I am also working in this area, and so I am very intersted in this driver. > > > > > 1 171k 151k 148k 151k 195k 187k 175k &

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-05 Thread Maxim Levitsky
On Sun, 2018-11-04 at 11:40 -0500, Vitaly Mayatskih wrote: > On Sun, Nov 4, 2018 at 6:57 AM Maxim Levitsky wrote: > > > Hi! > > I am also working in this area, and so I am very intersted in this driver. > > > > > 1 171k 151k 148k 151k 195k 187k 175k &

Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all

2017-11-04 Thread Maxim Levitsky
huge pages in the kernel config didn't make a difference. VT-d was enabled during the tests (intel_iommu=on,igfx_off) if that would make any difference, but no VM was started when I run the above script, in fact I run it just after the system booted. Best regards, Maxim Levitsky

Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all

2017-11-04 Thread Maxim Levitsky
huge pages in the kernel config didn't make a difference. VT-d was enabled during the tests (intel_iommu=on,igfx_off) if that would make any difference, but no VM was started when I run the above script, in fact I run it just after the system booted. Best regards, Maxim Levitsky

Re: Collapse all Print all In new window Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all.

2017-11-03 Thread Maxim Levitsky
Sorry for garbaged title - I copy & pased from older mail which I by mistake sent in HTML (had to use gmail web interface here) Beset regards, Maxim Levitsky On Sat, Nov 4, 2017 at 1:31 AM, Maxim Levitsky <maximlevit...@gmail.com> wrote: > Hi! > > My system has 64

Re: Collapse all Print all In new window Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all.

2017-11-03 Thread Maxim Levitsky
Sorry for garbaged title - I copy & pased from older mail which I by mistake sent in HTML (had to use gmail web interface here) Beset regards, Maxim Levitsky On Sat, Nov 4, 2017 at 1:31 AM, Maxim Levitsky wrote: > Hi! > > My system has 64G of ram and I want to create 32

Collapse all Print all In new window Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all.

2017-11-03 Thread Maxim Levitsky
in the kernel config didn't make a difference. VT-d was enabled during the tests (intel_iommu=on,igfx_off) is that would make any difference, but no VM was started when I run the above script, in fact I run it just after the system booted. Best regards, Maxim Levitsky

Collapse all Print all In new window Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all.

2017-11-03 Thread Maxim Levitsky
in the kernel config didn't make a difference. VT-d was enabled during the tests (intel_iommu=on,igfx_off) is that would make any difference, but no VM was started when I run the above script, in fact I run it just after the system booted. Best regards, Maxim Levitsky

Re: Mellanox Technologies MT23108 causes #MC exceptions under heavy load

2015-03-06 Thread Maxim Levitsky
False alarm, had exactly the same failure with infiniband disabled. Best regards, Maxim Levitsky On Fri, Mar 6, 2015 at 5:35 AM, Maxim Levitsky wrote: > We are running CPU and network heavy test on marmot.pdl.cmu.edu cluster. > It has Mellanox Technologies MT23108 InfiniHost cont

Re: Mellanox Technologies MT23108 causes #MC exceptions under heavy load

2015-03-06 Thread Maxim Levitsky
False alarm, had exactly the same failure with infiniband disabled. Best regards, Maxim Levitsky On Fri, Mar 6, 2015 at 5:35 AM, Maxim Levitsky maximlevit...@gmail.com wrote: We are running CPU and network heavy test on marmot.pdl.cmu.edu cluster. It has Mellanox Technologies MT23108

Mellanox Technologies MT23108 causes #MC exceptions under heavy load

2015-03-05 Thread Maxim Levitsky
and tested current HEAD of the vanilla kernel (99aedde0869ce194539166ac5a4d2e1a20995348) 4.0.0-rc2 but this happens even on 2.6.38 (which was in one of their stock kernel images). Best regards, Maxim Levitsky The kernel log of failure captured via serial console: [ 297.575167] ib0: can't

Mellanox Technologies MT23108 causes #MC exceptions under heavy load

2015-03-05 Thread Maxim Levitsky
and tested current HEAD of the vanilla kernel (99aedde0869ce194539166ac5a4d2e1a20995348) 4.0.0-rc2 but this happens even on 2.6.38 (which was in one of their stock kernel images). Best regards, Maxim Levitsky The kernel log of failure captured via serial console: [ 297.575167] ib0: can't

Re: [PATCH v2] memstick: rtsx: fix ms card data transfer bug

2014-01-24 Thread Maxim Levitsky
ought an laptop with this card reader. So as soon as I have some time, I will too test this code Really big thanks for writing this driver! Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH v2] memstick: rtsx: fix ms card data transfer bug

2014-01-24 Thread Maxim Levitsky
an laptop with this card reader. So as soon as I have some time, I will too test this code Really big thanks for writing this driver! Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] memstick: fix unreachable state in h_msb_read_page() in ms_block.c

2013-11-02 Thread Maxim Levitsky
sizeof(struct ms_status_register))) > return 0; > > - msb->state = MSB_RP_RECEIVE_OOB_READ; > + msb->state = MSB_RP_RECIVE_STATUS_REG; > return 0; > > case MSB_RP_RECIVE_STATUS_REG: This is indeed a bug here. Probab

Re: [PATCH] memstick: fix unreachable state in h_msb_read_page() in ms_block.c

2013-11-02 Thread Maxim Levitsky
also welcome to write a driver for xD portion of the card reader too. I back then implemented all the generic support, and you only need to expose an NAND driver (look at r852.c for my code). -- Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux

Driver for memestick standard cards

2013-07-08 Thread Maxim Levitsky
Hi! I now properly updated this driver and tested against 3.10, fixed a bunch of new checkpatch errors. Could you merge this to 3.10? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Driver for memestick standard cards

2013-07-08 Thread Maxim Levitsky
Hi! I now properly updated this driver and tested against 3.10, fixed a bunch of new checkpatch errors. Could you merge this to 3.10? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Fixes for ms_block

2012-10-08 Thread Maxim Levitsky
Hi, I finally found time to send the fix for the compile issue on m68k Among with small cosmetic fix to remove unused field that slipped thorough. Do you know if my driver will be merged in 3.7 or later? I hope that the compile issue which I should have handled earlier is not to blame. -- To

[PATCH 1/2] memstick: remove unused field from state struct.

2012-10-08 Thread Maxim Levitsky
Oops, I forgot that I have thet field there already. Just save memory by not allocating it. Signed-off-by: Maxim Levitsky --- drivers/memstick/core/ms_block.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memstick/core/ms_block.h b/drivers/memstick/core

[PATCH 2/2] memstick: ms_block: fix complile issue.

2012-10-08 Thread Maxim Levitsky
to ms_block.c. Cfr. memstick.c and mspro_block.c, who already have their own definition. CC: Geert Uytterhoeven Signed-off-by: Maxim Levitsky --- drivers/memstick/core/ms_block.c |2 +- drivers/memstick/core/ms_block.h |2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 2/2] memstick: ms_block: fix complile issue.

2012-10-08 Thread Maxim Levitsky
to ms_block.c. Cfr. memstick.c and mspro_block.c, who already have their own definition. CC: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/memstick/core/ms_block.c |2 +- drivers/memstick/core/ms_block.h |2 -- 2 files changed, 1

[PATCH 1/2] memstick: remove unused field from state struct.

2012-10-08 Thread Maxim Levitsky
Oops, I forgot that I have thet field there already. Just save memory by not allocating it. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/memstick/core/ms_block.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memstick/core/ms_block.h b

Fixes for ms_block

2012-10-08 Thread Maxim Levitsky
Hi, I finally found time to send the fix for the compile issue on m68k Among with small cosmetic fix to remove unused field that slipped thorough. Do you know if my driver will be merged in 3.7 or later? I hope that the compile issue which I should have handled earlier is not to blame. -- To

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-10-01 Thread Maxim Levitsky
On Sat, 2012-09-29 at 19:20 +0200, Geert Uytterhoeven wrote: > On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky > wrote: > > --- /dev/null > > +++ b/drivers/memstick/core/ms_block.c > > > +#define pr_fmt(fmt) DRIVER_NAME ": " fmt > > + > > +#inc

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-10-01 Thread Maxim Levitsky
On Sat, 2012-09-29 at 19:20 +0200, Geert Uytterhoeven wrote: On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky maximlevit...@gmail.com wrote: --- /dev/null +++ b/drivers/memstick/core/ms_block.c +#define pr_fmt(fmt) DRIVER_NAME : fmt + +#include linux/module.h +#include linux

Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()

2012-09-29 Thread Maxim Levitsky
On Sun, 2012-09-30 at 00:10 +0200, Maxim Levitsky wrote: > On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote: > > We need to free "overwrite_flags" before returning. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/memstick/c

Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()

2012-09-29 Thread Maxim Levitsky
anagment_flag = extra.management_flag; Indeed. I need to be more careful with this, I'll do another review of the code, maybe I spot anything else. Acked-by: Maxim Levitsky Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [patch 1/2] memstick: use after free in msb_disk_release()

2012-09-29 Thread Maxim Levitsky
kfree(msb); > disk->private_data = NULL; > idr_remove(_disk_idr, msb->disk_id); > + kfree(msb); > put_disk(disk); > } > } Oops, I added this bug in latest iterati

Re: [patch 1/2] memstick: use after free in msb_disk_release()

2012-09-29 Thread Maxim Levitsky
= NULL; idr_remove(msb_disk_idr, msb-disk_id); + kfree(msb); put_disk(disk); } } Oops, I added this bug in latest iteration, when removed support for major. Acked-by: Maxim Levitsky maximlevit...@gmail.com

Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()

2012-09-29 Thread Maxim Levitsky
with this, I'll do another review of the code, maybe I spot anything else. Acked-by: Maxim Levitsky maximlevit...@gmail.com Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()

2012-09-29 Thread Maxim Levitsky
On Sun, 2012-09-30 at 00:10 +0200, Maxim Levitsky wrote: On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote: We need to free overwrite_flags before returning. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/memstick/core/ms_block.c b/drivers

[PATCH] scatterlist: refactor the sg_nents

2012-09-27 Thread Maxim Levitsky
Replace 'while' with 'for' as suggested by Tejun Heo Signed-off-by: Maxim Levitsky --- lib/scatterlist.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 5cd9cdc..3675452b 100644 --- a/lib/scatterlist.c +++ b/lib

[PATCH] scatterlist: refactor the sg_nents

2012-09-27 Thread Maxim Levitsky
Replace 'while' with 'for' as suggested by Tejun Heo Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- lib/scatterlist.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 5cd9cdc..3675452b 100644 --- a/lib

[PATCH 1/2] scatterlist: add sg_nents

2012-09-26 Thread Maxim Levitsky
Useful helper to know the number of entries in scatterlist. Signed-off-by: Maxim Levitsky --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux

[PATCH v3 memstick: support for legacy sony memsticks

2012-09-26 Thread Maxim Levitsky
Hi, I am sending an updated version of the driver, this time addressing comments by Tejun Heo Changes since V2: * Removed the mutex kludge - ordered worqueue indeed works well * Removed manul major/minor handling * Gave more specific names to two sg helpers. Changes from V1: * Replaced

[PATCH v3 memstick: support for legacy sony memsticks

2012-09-26 Thread Maxim Levitsky
Hi, I am sending an updated version of the driver, this time addressing comments by Tejun Heo Changes since V2: * Removed the mutex kludge - ordered worqueue indeed works well * Removed manul major/minor handling * Gave more specific names to two sg helpers. Changes from V1: * Replaced

[PATCH 1/2] scatterlist: add sg_nents

2012-09-26 Thread Maxim Levitsky
Useful helper to know the number of entries in scatterlist. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/linux/scatterlist.h b

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 12:38 -0700, Tejun Heo wrote: > Hello, Maxim. > > On Tue, Sep 25, 2012 at 09:26:13PM +0200, Maxim Levitsky wrote: > > > Probably not the best idea to use a name this generic in driver code. > > > linux/scatterlist.h likely might wanna use th

Re: [PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 12:40 -0700, Tejun Heo wrote: > On Tue, Sep 25, 2012 at 09:34:39PM +0200, Maxim Levitsky wrote: > > But this just adds the WQ_UNBOUND. Dunno, without lock I had several > > crashes, that for high level of confidence caused by by parallel > > execution

Re: [PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
in parallel. (and then the I didn't even had by mistake the code that sets it to NULL in msb_stop, so I really fail to see how that could happen due internal bug in my code. > > Thanks. > -- Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 11:25 -0700, Tejun Heo wrote: > Hello, > > On Tue, Sep 25, 2012 at 10:38:46AM +0200, Maxim Levitsky wrote: > > diff --git a/drivers/memstick/core/ms_block.c > > b/drivers/memstick/core/ms_block.c > > new file mode 100644 > > index 0

[PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
as requested * Made functions static, fixed most whitespace issues (I hope all), and I hope addressed all other comments by Andrew Morton. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

[PATCH 1/2] scatterlist: add sg_nents

2012-09-25 Thread Maxim Levitsky
Useful helper to know the number of entries in scatterlist. Signed-off-by: Maxim Levitsky --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux

[PATCH 1/2] scatterlist: add sg_nents

2012-09-25 Thread Maxim Levitsky
Useful helper to know the number of entries in scatterlist. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/linux/scatterlist.h b

[PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
as requested * Made functions static, fixed most whitespace issues (I hope all), and I hope addressed all other comments by Andrew Morton. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 11:25 -0700, Tejun Heo wrote: Hello, On Tue, Sep 25, 2012 at 10:38:46AM +0200, Maxim Levitsky wrote: diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c new file mode 100644 index 000..318e40b --- /dev/null +++ b/drivers

Re: [PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
in msb_stop, so I really fail to see how that could happen due internal bug in my code. Thanks. -- Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 memstick: support for legacy sony memsticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 12:40 -0700, Tejun Heo wrote: On Tue, Sep 25, 2012 at 09:34:39PM +0200, Maxim Levitsky wrote: But this just adds the WQ_UNBOUND. Dunno, without lock I had several crashes, that for high level of confidence caused by by parallel execution of work items. Once I added

Re: [PATCH 2/2] memstick: add support for legacy memorysticks

2012-09-25 Thread Maxim Levitsky
On Tue, 2012-09-25 at 12:38 -0700, Tejun Heo wrote: Hello, Maxim. On Tue, Sep 25, 2012 at 09:26:13PM +0200, Maxim Levitsky wrote: Probably not the best idea to use a name this generic in driver code. linux/scatterlist.h likely might wanna use the name. Lets not go this route again

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 20:19 +0200, Maxim Levitsky wrote: > On Mon, 2012-09-24 at 11:05 -0700, Tejun Heo wrote: > > Hello, > > > > On Mon, Sep 24, 2012 at 05:09:23PM +0200, Maxim Levitsky wrote: > > > > Now that my exams done > > > > Can you spare

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 11:05 -0700, Tejun Heo wrote: > Hello, > > On Mon, Sep 24, 2012 at 05:09:23PM +0200, Maxim Levitsky wrote: > > > Now that my exams done > > > Can you spare me from using a workqueue? > > I'd much prefer if you convert to workqueue.

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 16:59 +0200, Maxim Levitsky wrote: > On Thu, 2012-09-20 at 10:53 -0700, Tejun Heo wrote: > > On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote: > > > There can't be races in the driver, since it contains a single thread > > > that

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Thu, 2012-09-20 at 10:53 -0700, Tejun Heo wrote: > On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote: > > There can't be races in the driver, since it contains a single thread > > that does all the IO it got from block layer. > > The thread is awaken each time

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Thu, 2012-09-20 at 10:53 -0700, Tejun Heo wrote: On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote: There can't be races in the driver, since it contains a single thread that does all the IO it got from block layer. The thread is awaken each time the request function

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 16:59 +0200, Maxim Levitsky wrote: On Thu, 2012-09-20 at 10:53 -0700, Tejun Heo wrote: On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote: There can't be races in the driver, since it contains a single thread that does all the IO it got from block layer

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 11:05 -0700, Tejun Heo wrote: Hello, On Mon, Sep 24, 2012 at 05:09:23PM +0200, Maxim Levitsky wrote: Now that my exams done Can you spare me from using a workqueue? I'd much prefer if you convert to workqueue. The point is that using current model I

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-24 Thread Maxim Levitsky
On Mon, 2012-09-24 at 20:19 +0200, Maxim Levitsky wrote: On Mon, 2012-09-24 at 11:05 -0700, Tejun Heo wrote: Hello, On Mon, Sep 24, 2012 at 05:09:23PM +0200, Maxim Levitsky wrote: Now that my exams done Can you spare me from using a workqueue? I'd much prefer if you

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-19 Thread Maxim Levitsky
On Wed, 2012-09-19 at 14:52 -0700, Andrew Morton wrote: > On Wed, 19 Sep 2012 16:19:02 +0300 > Maxim Levitsky wrote: > > > Based partially on MS standard spec quotes from Alex Dubov. > > > > As any code that works with user data this driver isn't > >

[no subject]

2012-09-19 Thread Maxim Levitsky
Hi, This is a revised generic driver for memstick standard cards, that I posted a year ago. I removed the scatter-gather list abuse from it, but otherwice its unchanged. I tested it quite a lot here and everything is fine. Could you merge it? Best regards, Maxim Levitsky

[no subject]

2012-09-19 Thread Maxim Levitsky
Hi, This is a revised generic driver for memstick standard cards, that I posted a year ago. I removed the scatter-gather list abuse from it, but otherwice its unchanged. I tested it quite a lot here and everything is fine. Could you merge it? Best regards, Maxim Levitsky

Re: [PATCH] memstick: add support for legacy memorysticks

2012-09-19 Thread Maxim Levitsky
On Wed, 2012-09-19 at 14:52 -0700, Andrew Morton wrote: On Wed, 19 Sep 2012 16:19:02 +0300 Maxim Levitsky maximlevit...@gmail.com wrote: Based partially on MS standard spec quotes from Alex Dubov. As any code that works with user data this driver isn't recommended to use to write

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-13 Thread Maxim Levitsky
nt IDs, thus I placed them in this file. You just need to write a NAND driver exposing raw flash, and my sm_ftl will take care of wear leveling and everything else. If any questions, bug-reports, just notes, I glad to hear about this. Best regards, Maxim Levitsky -- To unsubscribe from this list: se

Re: [bisected] nouveau: "Failed to idle channel x" after resume

2012-08-13 Thread Maxim Levitsky
confirm exactly the same thing. Here suspend takes more that 10 seconds: [ 2165.363878] nouveau [ DRM][:01:00.0] suspending fbcon... [ 2165.363885] nouveau [ DRM][:01:00.0] suspending display... [ 2165.475791] sd 0:0:0:0: [sda] Stopping disk [ 2166.396877] nouveau [ DRM][:01:00

Re: [bisected] nouveau: Failed to idle channel x after resume

2012-08-13 Thread Maxim Levitsky
, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-13 Thread Maxim Levitsky
glad to hear about this. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [bisected] nouveau: "Failed to idle channel x" after resume

2012-08-06 Thread Maxim Levitsky
On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: > On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote: > > On Thu, Jul 5, 2012 at 11:24 PM, Martin Nyhus wrote: > > > > > > On Mon, 11 Jun 2012 23:18:42 +0200 Martin Nyhus wrote: > > > > aft

Re: [bisected] nouveau: Failed to idle channel x after resume

2012-08-06 Thread Maxim Levitsky
On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote: On Thu, Jul 5, 2012 at 11:24 PM, Martin Nyhus martin.ny...@gmx.com wrote: On Mon, 11 Jun 2012 23:18:42 +0200 Martin Nyhus wrote: after resuming from suspend nouveau

Re: [bisected] nouveau: "Failed to idle channel x" after resume

2012-08-04 Thread Maxim Levitsky
eau/2011-January/007358.html > . If I can do anything else > to help, I will be glad to. Added nouv...@lists.freedesktop.org> I confirm the same issue here. will try to do dig it. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [bisected] nouveau: Failed to idle channel x after resume

2012-08-04 Thread Maxim Levitsky
it. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Maxim Levitsky
reference take a look at http://lkml.org/lkml/2007/3/17/155 I remember that I did about 1500 reboots to try to fix this. (According to hard disk's 'smart' statistics) Suggestion: the speaker usually is quite loud, thus it can be annoying to use for morse code or so. Why not to use keyboard leds for thi

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Maxim Levitsky
for this purpose? (USB keyboard probably isn't an option, but user can always pull an old PC keyboard out of closet, and use it) Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Access MSR functions in userspace?

2008-02-05 Thread Maxim Levitsky
/msr Take look at $LINUX_SOURCES/arch/x86/kernel/msr.c to learn how to use it. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

Re: [git pull] x86 arch updates for v2.6.25

2008-02-04 Thread Maxim Levitsky
tree was merged several times, but I don't see kgdb included in latest mainline -git. So just one question, will it be included or no? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [git pull] x86 arch updates for v2.6.25

2008-02-04 Thread Maxim Levitsky
or no? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ACPI: Add sysfs interface for acpi device wakeup

2008-01-09 Thread Maxim Levitsky
devices. Probably it is even better to link this code to PCI code, so PCI drivers will be aware of ACPI. For example it will fix the 'EHCI instantly wakes up the system from S4' on my system, since here USB doesn't wake up anything from S4, and ACPI tables correctly show that. If ehci driver w

Re: [PATCH] ACPI: Add sysfs interface for acpi device wakeup

2008-01-09 Thread Maxim Levitsky
, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Why is deleting (or reading) files not counted as IO-Wait in top?

2008-01-02 Thread Maxim Levitsky
duction. I did few tests that showed almost 50% slowdown when running another task in that iowait time. It is not longer a problem with CFS. Regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: Why is deleting (or reading) files not counted as IO-Wait in top?

2008-01-02 Thread Maxim Levitsky
. It is not longer a problem with CFS. Regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-26 Thread Maxim Levitsky
> and a new syscall of some sorts I suspect; "flush all caches" is a ring > 0 operation (and you probably need to do it in an ipi anyway on all > cpus) > I think that PAT support will help a lot. How about opening/mmaping /dev/mem, and setting uncacheable attribute there. Ac

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-26 Thread Maxim Levitsky
support will help a lot. How about opening/mmaping /dev/mem, and setting uncacheable attribute there. Actually it is even possible today with MTRRs. Regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: 2.6.24-rc3-git4 NFS crossmnt regression [SOLVED]

2007-12-11 Thread Maxim Levitsky
On Wednesday 12 December 2007 04:15:59 Andrew Morton wrote: > On Wed, 12 Dec 2007 04:01:56 +0200 Maxim Levitsky <[EMAIL PROTECTED]> wrote: > > > > > > > argh, this is getting bad. > > > > > > Can you please test the below patch

<    1   2   3   4   5   6   7   >