Re: power9 NUMA crash while reading debugfs imc_cmd

2019-06-29 Thread Michael Ellerman
Qian Cai writes: > On Fri, 2019-06-28 at 17:19 +0530, Anju T Sudhakar wrote: >> On 6/28/19 9:04 AM, Qian Cai wrote: >> > >> > > On Jun 27, 2019, at 11:12 PM, Michael Ellerman >> > > wrote: >> > > >> > > Qian Cai wr

Re: [PATCH] selftests/powerpc: ppc_asm.h: typo in the header guard

2019-06-27 Thread Michael Ellerman
Denis Efremov writes: > The guard macro __PPC_ASM_H in the header ppc_asm.h > doesn't match the #ifndef macro _PPC_ASM_H. The patch > makes them the same. > > Signed-off-by: Denis Efremov > --- > tools/testing/selftests/powerpc/stringloops/asm/ppc_asm.h | 2 +- > 1 file changed, 1 insertion(+),

Re: power9 NUMA crash while reading debugfs imc_cmd

2019-06-27 Thread Michael Ellerman
Qian Cai writes: > Read of debugfs imc_cmd file for a memory-less node will trigger a crash below > on this power9 machine which has the following NUMA layout. What type of machine is it? cheers > I don't understand why I only saw it recently on linux-next where it > was tested everyday. I can

Re: [PATCH] recordmcount: Fix spurious mcount entries on powerpc

2019-06-27 Thread Michael Ellerman
Satheesh Rajendran writes: > On Thu, Jun 27, 2019 at 12:08:01AM +0530, Naveen N. Rao wrote: >> The recent change enabling HAVE_C_RECORDMCOUNT on powerpc started >> showing the following issue: >> >> # modprobe kprobe_example >>ftrace-powerpc: Not expected bl: opcode is 3c4c0001 >>

Re: [PATCH] recordmcount: Fix spurious mcount entries on powerpc

2019-06-27 Thread Michael Ellerman
Steven Rostedt writes: > On Thu, 27 Jun 2019 15:55:47 +1000 > Michael Ellerman wrote: > >> Steve are you OK if I merge this via the powerpc tree? I'll reword the >> commit message so that it makes sense coming prior to the commit >> mentioned above. > > Yes,

Re: [PATCH] recordmcount: Fix spurious mcount entries on powerpc

2019-06-26 Thread Michael Ellerman
"Naveen N. Rao" writes: > The recent change enabling HAVE_C_RECORDMCOUNT on powerpc started > showing the following issue: > > # modprobe kprobe_example >ftrace-powerpc: Not expected bl: opcode is 3c4c0001 >WARNING: CPU: 0 PID: 227 at kernel/trace/ftrace.c:2001 > ftrace_bug+0x90/0x318

Re: [PATCH] powerpc/64s/radix: Define arch_ioremap_p4d_supported()

2019-06-26 Thread Michael Ellerman
h that creates the requirement for arch_ioremap_p4d_supported(). Andrew might do that for you, or you could send a v2. This looks fine from a powerpc POV: Acked-by: Michael Ellerman cheers > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: "Aneesh Kumar K.V" >

CVE-2019-12817: Linux kernel: powerpc: Unrelated processes may be able to read/write to each other's virtual memory

2019-06-24 Thread Michael Ellerman
The Linux kernel for powerpc since 4.17 has a bug where unrelated processes may be able to read/write to each other's virtual memory under certain conditions. This bug only affects machines using 64-bit CPUs with the hash page table MMU, see below for more detail on affected CPUs. To trigger the

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-23 Thread Michael Ellerman
On Thu, 2019-06-13 at 08:24:46 UTC, Christoph Hellwig wrote: > With the strict dma mask checking introduced with the switch to > the generic DMA direct code common wifi chips on 32-bit powerbooks > stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds > to allow them to reliably

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-5 tag

2019-06-22 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull some more powerpc fixes for 5.2. This is a frustratingly large batch at rc5. Some of these were sent earlier but were missed by me due to being distracted by other things, and some took a while to track down due to needing

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-20 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Wed, 2019-06-19 at 22:32 +1000, Michael Ellerman wrote: >> Christoph Hellwig writes: >> > Any chance this could get picked up to fix the regression? >> >> Was hoping Ben would Ack it. He's still powermac maintainer :) >>

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-19 Thread Michael Ellerman
Christoph Hellwig writes: > Any chance this could get picked up to fix the regression? Was hoping Ben would Ack it. He's still powermac maintainer :) I guess he OK'ed it in the other thread, will add it to my queue. cheers > On Thu, Jun 13, 2019 at 10:24:46AM +0200, Christoph Hellwig wrote:

Re: [PATCH 4/7] powerpc/ftrace: Additionally nop out the preceding mflr with -mprofile-kernel

2019-06-18 Thread Michael Ellerman
Hi Naveen, Sorry I meant to reply to this earlier .. :/ "Naveen N. Rao" writes: > With -mprofile-kernel, gcc emits 'mflr r0', followed by 'bl _mcount' to > enable function tracing and profiling. So far, with dynamic ftrace, we > used to only patch out the branch to _mcount(). However, mflr is >

Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU

2019-06-18 Thread Michael Ellerman
Christophe Leroy writes: > Le 11/06/2019 à 17:47, Christophe Leroy a écrit : >> The patch referenced below moved the loading of segment registers >> out of load_up_mmu() in order to do it earlier in the boot sequence. >> However, the secondary CPU still needs it to be done when loading up >> the

Re: [PATCH v2] perf ioctl: Add check for the sample_period value

2019-06-18 Thread Michael Ellerman
Ravi Bangoria writes: > Peter / mpe, > > Is the v2 looks good? If so, can anyone of you please pick this up. I usually wouldn't take it, it's generic perf code. Unless peter/ingo/acme tell me otherwise. It's sort of a bug fix for 0819b2e30ccb, should it have a fixes and/or stable tag? Fixes:

Re: [PATCH] selftests/powerpc: Add missing newline at end of file

2019-06-18 Thread Michael Ellerman
Geert Uytterhoeven writes: > "git diff" says: > > \ No newline at end of file > > after modifying the file. Is that a problem? Just curious because it was presumably me that broke it :) cheers > diff --git a/tools/testing/selftests/powerpc/mm/.gitignore >

Re: [PATCH v1 1/6] mm: Section numbers use the type "unsigned long"

2019-06-18 Thread Michael Ellerman
Andrew Morton writes: > On Sat, 15 Jun 2019 10:06:54 +0200 Christophe Leroy > wrote: >> Le 14/06/2019 à 21:00, Andrew Morton a écrit : >> > On Fri, 14 Jun 2019 12:01:09 +0200 David Hildenbrand >> > wrote: >> > >> >> We are using a mixture of "int" and "unsigned long". Let's make this >> >>

Re: [PATCH] powerpc/32: fix build failure on book3e with KVM

2019-06-16 Thread Michael Ellerman
On Thu, 2019-05-23 at 08:39:27 UTC, Christophe Leroy wrote: > Build failure was introduced by the commit identified below, > due to missed macro expension leading to wrong called function's name. > > arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': >

Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU

2019-06-16 Thread Michael Ellerman
On Tue, 2019-06-11 at 15:47:20 UTC, Christophe Leroy wrote: > The patch referenced below moved the loading of segment registers > out of load_up_mmu() in order to do it earlier in the boot sequence. > However, the secondary CPU still needs it to be done when loading up > the MMU. > > Reported-by:

Re: [PATCH] powerpc/booke: fix fast syscall entry on SMP

2019-06-16 Thread Michael Ellerman
On Thu, 2019-06-13 at 13:52:30 UTC, Christophe Leroy wrote: > Use r10 instead of r9 to calculate CPU offset as r9 contains > the value from SRR1 which is used later. > > Fixes: 1a4b739bbb4f ("powerpc/32: implement fast entry for syscalls on BOOKE") > Signed-off-by: Christophe Leroy Applied to

Re: [PATCH] ocxl: do not use C++ style comments in uapi header

2019-06-15 Thread Michael Ellerman
On Tue, 2019-06-04 at 11:16:32 UTC, Masahiro Yamada wrote: > Linux kernel tolerates C++ style comments these days. Actually, the > SPDX License tags for .c files start with //. > > On the other hand, uapi headers are written in more strict C, where > the C++ comment style is forbidden. > >

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-4 tag

2019-06-15 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull some more powerpc fixes for 5.2: The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in the git repository at:

Re: [PATCH] powerpc: Enable kernel XZ compression option on PPC_85xx

2019-06-13 Thread Michael Ellerman
Daniel Axtens writes: > Pawel Dembicki writes: > >> Enable kernel XZ compression option on PPC_85xx. Tested with >> simpleImage on TP-Link TL-WDR4900 (Freescale P1014 processor). >> >> Suggested-by: Christian Lamparter >> Signed-off-by: Pawel Dembicki >> --- >> arch/powerpc/Kconfig | 2 +- >>

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-11 Thread Michael Ellerman
On Mon, 2019-06-03 at 13:00:51 UTC, Christophe Leroy wrote: > When booting through OF, setup_disp_bat() does nothing because > disp_BAT are not set. By change, it used to work because BOOTX > buffer is mapped 1:1 at address 0x8100 by the bootloader, and > btext_setup_display() sets virt addr

Re: [PATCH v3] powerpc: fix kexec failure on book3s/32

2019-06-11 Thread Michael Ellerman
On Mon, 2019-06-03 at 08:20:28 UTC, Christophe Leroy wrote: > In the old days, _PAGE_EXEC didn't exist on 6xx aka book3s/32. > Therefore, allthough __mapin_ram_chunk() was already mapping kernel > text with PAGE_KERNEL_TEXT and the rest with PAGE_KERNEL, the entire > memory was executable. Part of

Re: [PATCH] Powerpc/Watchpoint: Restore nvgprs while returning from exception

2019-06-06 Thread Michael Ellerman
Ravi Bangoria writes: > Powerpc hw triggers watchpoint before executing the instruction. > To make trigger-after-execute behavior, kernel emulates the > instruction. If the instruction is 'load something into non- > volatile register', exception handler should restore emulated > register state

Re: [RFC V2] mm: Generalize notify_page_fault()

2019-06-05 Thread Michael Ellerman
Anshuman Khandual writes: > Similar notify_page_fault() definitions are being used by architectures > duplicating much of the same code. This attempts to unify them into a > single implementation, generalize it and then move it to a common place. > kprobes_built_in() can detect CONFIG_KPROBES,

Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-05 Thread Michael Ellerman
"Martin K. Petersen" writes: > Nathan, > >> clang warns: >> >> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used >> uninitialized whenever switch case is taken [-Wsometimes-uninitialized] >> case IBMVSCSI_HOST_ACTION_NONE: >> ^ >

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-06-03 Thread Michael Ellerman
"powerpc/perf: Fix oops when kthread >> >> execs user process") >> >> >> >> Reported-by: Ravi Bangoria >> >> Reported-by: Young Xiao <92siuy...@gmail.com> >> >> Cc: Ravi Bangoria >> >> Cc: Naveen N. Rao >>

Re: [PATCH 1/2] powerpc/lib: fix redundant inclusion of quad.o

2019-06-03 Thread Michael Ellerman
On Mon, 2019-05-13 at 10:00:14 UTC, Christophe Leroy wrote: > quad.o is only for PPC64, and already included in obj64-y, > so it doesn't have to be in obj-y > > Fixes: 31bfdb036f12 ("powerpc: Use instruction emulation infrastructure to > handle alignment faults") > Signed-off-by: Christophe

Re: [PATCH -next] powerpc/book3s64: Make some symbols static

2019-06-03 Thread Michael Ellerman
On Sat, 2019-05-04 at 10:24:27 UTC, YueHaibing wrote: > Fix sparse warnings: > > arch/powerpc/mm/book3s64/radix_pgtable.c:326:13: warning: symbol > 'radix_init_pgtable' was not declared. Should it be static? > arch/powerpc/mm/book3s64/hash_native.c:48:1: warning: symbol > 'native_tlbie_lock'

Re: [PATCH] dlpar: Fix a missing-check bug in dlpar_parse_cc_property()

2019-06-03 Thread Michael Ellerman
On Sun, 2019-05-26 at 02:42:40 UTC, Gen Zhang wrote: > In dlpar_parse_cc_property(), 'prop->name' is allocated by kstrdup(). > kstrdup() may return NULL, so it should be checked and handle error. > And prop should be freed if 'prop->name' is NULL. > > Signed-off-by: Gen Zhang > Acked-by: Nathan

Re: [PATCH -next] misc: ocxl: Make ocxl_remove static

2019-06-03 Thread Michael Ellerman
On Sat, 2019-05-04 at 10:27:20 UTC, YueHaibing wrote: > Fix sparse warning: > > drivers/misc/ocxl/pci.c:44:6: warning: > symbol 'ocxl_remove' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > Acked-by: Andrew Donnellan Applied to powerpc next,

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-06-03 Thread Michael Ellerman
On Fri, 2019-04-19 at 15:34:13 UTC, Greg Kurz wrote: > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > has the effect of incrementing the reference count of the PCI device, as > explained in drivers/pci/search.c: > > * Given a PCI domain, bus, and slot/function

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-3 tag

2019-06-02 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull some more powerpc fixes for 5.2: The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the git repository at:

Re: [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-02 Thread Michael Ellerman
Hi Nathan, Nathan Chancellor writes: > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^ >

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-28 Thread Michael Ellerman
Will Deacon writes: > On Tue, May 28, 2019 at 04:01:03PM +0200, Peter Zijlstra wrote: >> On Tue, May 28, 2019 at 08:31:29PM +0800, Young Xiao wrote: >> > When a kthread calls call_usermodehelper() the steps are: >> > 1. allocate current->mm >> > 2. load_elf_binary() >> > 3. populate

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-28 Thread Michael Ellerman
Peter Zijlstra writes: > On Tue, May 28, 2019 at 08:31:29PM +0800, Young Xiao wrote: >> When a kthread calls call_usermodehelper() the steps are: >> 1. allocate current->mm >> 2. load_elf_binary() >> 3. populate current->thread.regs >> >> While doing this, interrupts are not disabled. If

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-28 Thread Michael Ellerman
Mathieu Malaterre writes: > Fix warnings treated as errors with W=1: > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre > --- > v2: as suggested prefer

Re: [PATCH 1/2] perf ioctl: Add check for the sample_period value

2019-05-28 Thread Michael Ellerman
Ravi Bangoria writes: > On 5/13/19 2:26 PM, Peter Zijlstra wrote: >> On Mon, May 13, 2019 at 09:42:13AM +0200, Peter Zijlstra wrote: >>> On Sat, May 11, 2019 at 08:12:16AM +0530, Ravi Bangoria wrote: Add a check for sample_period value sent from userspace. Negative value does not make

Re: [PATCH v3 14/16] powerpc/32: implement fast entry for syscalls on BOOKE

2019-05-27 Thread Michael Ellerman
Christophe Leroy writes: > Le 23/05/2019 à 09:00, Christophe Leroy a écrit : > > [...] > >>> arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': >>> arch/powerpc/kernel/head_fsl_booke.S:416: undefined reference to >>> `kvmppc_handler_BOOKE_INTERRUPT_SYSCALL_SPRN_SRR1' >>>

Re: [PATCH v3 3/3] tests: add close_range() tests

2019-05-27 Thread Michael Ellerman
Christian Brauner writes: > This adds basic tests for the new close_range() syscall. > - test that no invalid flags can be passed > - test that a range of file descriptors is correctly closed > - test that a range of file descriptors is correctly closed if there there > are already closed file

Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-27 Thread Michael Ellerman
"Rafael J. Wysocki" writes: > On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: >> The declaration for pfn_is_nosave is only available in >> kernel/power/power.h. Since this function can be override in arch, >> expose it globally. Having a prototype will make sure to avoid warning

Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-27 Thread Michael Ellerman
+ > kernel/power/power.h | 2 -- > 4 files changed, 2 insertions(+), 3 deletions(-) Looks fine to me. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH 2/2] powerpc/perf: Fix mmcra corruption by bhrb_filter

2019-05-24 Thread Michael Ellerman
On Sat, 2019-05-11 at 02:42:17 UTC, Ravi Bangoria wrote: > Consider a scenario where user creates two events: > > 1st event: > attr.sample_type |= PERF_SAMPLE_BRANCH_STACK; > attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY; > fd = perf_event_open(attr, 0, 1, -1, 0); > > This

Re: [PATCH 10/18] locking/atomic: powerpc: use s64 for atomic64

2019-05-23 Thread Michael Ellerman
on the generic defintion of atomic64_t, this > still returns long on 64-bit. This will be converted in a subsequent > patch. > > Otherwise, there should be no functional change as a result of this > patch. > > Signed-off-by: Mark Rutland > Cc: Michael Ellerman > Cc:

Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s

2019-05-21 Thread Michael Ellerman
@@ -4,7 +4,6 @@ > > config OCXL_BASE > bool > - default n > select PPC_COPRO_BASE > > config OCXL Acked-by: Michael Ellerman (ocxl) cheers

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-21 Thread Michael Ellerman
Masahiro Yamada writes: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > wrote: >> Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : >> > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error >> > with gcc 9.1.1: >> > >> >arch/powerpc/mm/book3s64/radix_tlb.c: In function

Re: PROBLEM: Power9: kernel oops on memory hotunplug from ppc64le guest

2019-05-19 Thread Michael Ellerman
Bharata B Rao writes: > On Thu, May 16, 2019 at 07:44:20PM +0530, srikanth wrote: >> Hello, >> >> On power9 host, performing memory hotunplug from ppc64le guest results in >> kernel oops. >> >> Kernel used : https://github.com/torvalds/linux/tree/v5.1 built using >> ppc64le_defconfig for host

Re: [PATCH] powerpc/32s: fix flush_hash_pages() on SMP

2019-05-18 Thread Michael Ellerman
On Thu, 2019-05-09 at 12:59:38 UTC, Christophe Leroy wrote: > flush_hash_pages() runs with data translation off, so current > task_struct has to be accesssed using physical address. > > Reported-by: Erhard F. > Fixes: f7354ccac844 ("powerpc/32: Remove CURRENT_THREAD_INFO and rename > TI_CPU") >

Re: [PATCH] powerpc: Remove double free

2019-05-18 Thread Michael Ellerman
On Wed, 2019-05-15 at 09:07:50 UTC, "Tobin C. Harding" wrote: > kfree() after kobject_put(). Who ever wrote this was on crack. > > Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") > Signed-off-by: Tobin C. Harding Applied to powerpc fixes, thanks.

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-2 tag

2019-05-18 Thread Michael Ellerman
): powerpc/32s: fix flush_hash_pages() on SMP Michael Ellerman (1): powerpc/mm: Fix crashes with hugepages & 4K pages Tobin C. Harding (1): powerpc/cacheinfo: Remove double free arch/powerpc/include/asm/book3s/64/hash.h | 6 -- arch/powerpc/kernel/cacheinfo.c

Re: PROBLEM: Power9: kernel oops on memory hotunplug from ppc64le guest

2019-05-17 Thread Michael Ellerman
srikanth writes: > Hello, > > On power9 host, performing memory hotunplug from ppc64le guest results > in kernel oops. Thanks for the report. Did this used to work in the past? If so what is the last version that worked? > Kernel used : https://github.com/torvalds/linux/tree/v5.1 built using

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-05-14 Thread Michael Ellerman
Greg Kurz writes: > Michael, > > Any comments on this patch ? Should I repost with a shorter comment > as suggested by Alexey ? No the longer comment seems fine to me. I'm not a big fan of the patch, it's basically a hack :) But for a backportable fix I guess it is OK. I would be happier

Re: [PATCH stable 4.9] powerpc/lib: fix code patching during early init on PPC32

2019-05-14 Thread Michael Ellerman
Christophe Leroy writes: > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789] > > On powerpc32, patch_instruction() is called by apply_feature_fixups() > which is called from early_init() > > There is the following note in front of early_init(): > * Note that the kernel may

Re: [RESEND PATCH] powerpc/pseries: Fix cpu_hotplug_lock acquisition in resize_hpt

2019-05-14 Thread Michael Ellerman
"Gautham R. Shenoy" writes: > From: "Gautham R. Shenoy" > > Subject: Re: [RESEND PATCH] powerpc/pseries: Fix cpu_hotplug_lock acquisition > in resize_hpt ps. A "RESEND" implies the patch is unchanged and you're just resending it because it was ignored. In this case it should have just been

Re: [RESEND PATCH] powerpc/pseries: Fix cpu_hotplug_lock acquisition in resize_hpt

2019-05-14 Thread Michael Ellerman
"Gautham R. Shenoy" writes: > From: "Gautham R. Shenoy" > > During a memory hotplug operations involving resizing of the HPT, we > invoke a stop_machine() to perform the resizing. In this code path, we > end up recursively taking the cpu_hotplug_lock, first in > memory_hotplug_begin() and then

Re: [PATCH 2/2] powerpc/8xx: Add microcode patch to move SMC parameter RAM.

2019-05-14 Thread Michael Ellerman
Christophe Leroy writes: > Some SCC functions like the QMC requires an extended parameter RAM. > On modern 8xx (ie 866 and 885), SPI area can already be relocated, > allowing the use of those functions on SCC2. But SCC3 and SCC4 > parameter RAM collide with SMC1 and SMC2 parameter RAMs. > > This

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-14 Thread Michael Ellerman
Borislav Petkov writes: > On Fri, May 10, 2019 at 04:13:20PM +0200, Borislav Petkov wrote: >> On Fri, May 10, 2019 at 08:50:52PM +1000, Michael Ellerman wrote: >> > Yeah that looks better to me. I didn't think about the case where EDAC >> > core is modular. >> >

Re: [PATCH v3] fs/proc: add VmTaskSize field to /proc/$$/status

2019-05-14 Thread Michael Ellerman
Yury Norov writes: > On Fri, May 10, 2019 at 01:32:22PM +1000, Michael Ellerman wrote: >> Yury Norov writes: >> > On Tue, May 07, 2019 at 08:54:31AM -0400, Rafael Aquini wrote: >> >> On Mon, May 06, 2019 at 11:53:43AM -0400, Joel Savitz wrote: >> >> >

Re: [PATCH RESEND] powerpc: add simd.h implementation specific to PowerPC

2019-05-13 Thread Michael Ellerman
Shawn Landden writes: > It is safe to do SIMD in an interrupt on PowerPC. No it's not sorry :) > Only disable when there is no SIMD available > (and this is a static branch). > > Tested and works with the WireGuard (Zinc) patch I wrote that needs this. > Also improves performance of the crypto

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-13 Thread Michael Ellerman
Dmitry Vyukov writes: > From: Arnd Bergmann > Date: Sat, May 11, 2019 at 2:51 AM > To: Dmitry Vyukov > Cc: Nick Kossifidis, Christoph Hellwig, Linus Torvalds, Andrew Morton, > linux-arch, Linux Kernel Mailing List, linuxppc-dev > >> On Fri, May 10, 2019 at 6:53 AM Dmitry Vyukov wrote: >> > > >>

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-10 Thread Michael Ellerman
Borislav Petkov writes: > On Thu, May 09, 2019 at 04:55:34PM +0200, Borislav Petkov wrote: >> On Fri, May 10, 2019 at 12:52:05AM +1000, Michael Ellerman wrote: >> > Thanks. It would be nice if you could send it as a fix for 5.2, it's the >> > last thing blocking on

RE: [PATCH] vsprintf: Do not break early boot with probing addresses

2019-05-10 Thread Michael Ellerman
David Laight writes: > From: Michal Suchánek >> Sent: 09 May 2019 14:38 > ... >> > The problem is the combination of some new code called via printk(), >> > check_pointer() which calls probe_kernel_read(). That then calls >> > allow_user_access() (PPC_KUAP) and that uses mmu_has_feature() too

Re: [PATCH v3] fs/proc: add VmTaskSize field to /proc/$$/status

2019-05-09 Thread Michael Ellerman
Yury Norov writes: > On Tue, May 07, 2019 at 08:54:31AM -0400, Rafael Aquini wrote: >> On Mon, May 06, 2019 at 11:53:43AM -0400, Joel Savitz wrote: >> > There is currently no easy and architecture-independent way to find the >> > lowest unusable virtual address available to a process without >> >

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-09 Thread Michael Ellerman
Borislav Petkov writes: > On Mon, May 06, 2019 at 08:50:45AM +0200, Johannes Thumshirn wrote: >> Acked-by: Johannes Thumshirn > > Queued, thanks. Thanks. It would be nice if you could send it as a fix for 5.2, it's the last thing blocking one of my allmodconfig builds. But if you don't think it

Re: [PATCH] powerpc: restore current_thread_info()

2019-05-07 Thread Michael Ellerman
Yury Norov writes: > On Tue, May 07, 2019 at 11:58:56PM +0100, Al Viro wrote: >> On Tue, May 07, 2019 at 03:51:21PM -0700, Yury Norov wrote: >> > Commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK") >> > removes the function current_thread_info(). It's wrong because the >> >

Re: [PATCH linux-next v10 5/7] powerpc: define syscall_get_error()

2019-05-06 Thread Michael Ellerman
e generic > ptrace API with PTRACE_GET_SYSCALL_INFO request. > > Cc: Michael Ellerman > Cc: Elvira Khabirova > Cc: Eugene Syromyatnikov > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Oleg Nesterov > Cc: Andy Lutomirski > Cc: linuxppc-...@lists.ozlabs.org

Re: [PATCH v2 03/15] powerpc/mm: convert Book3E 64 to pte_fragment

2019-05-06 Thread Michael Ellerman
Christophe Leroy writes: > Le 26/04/2019 à 17:58, Christophe Leroy a écrit : >> Book3E 64 is the only subarch not using pte_fragment. In order >> to allow refactorisation, this patch converts it to pte_fragment. >> >> Reviewed-by: Aneesh Kumar K.V >> Signed-off-by: Christophe Leroy >> --- >>

[GIT PULL] Please pull powerpc/linux.git powerpc-5.1-7 tag

2019-05-04 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull one more powerpc fix for 5.1: The following changes since commit 7a3a4d763837d3aa654cd1059030950410c04d77: powerpc/mm_iommu: Allow pinning large regions (2019-04-17 21:36:51 +1000) are available in the git repository at:

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Michael Ellerman
Joe Perches writes: > On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: >> On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: >> > Fix fallout too. >> > >> > Signed-off-by: Joe Perches >> >> Applied to powerpc next,

Re: [PATCH] powerpc/book3e: drop BUG_ON() in map_kernel_page()

2019-05-03 Thread Michael Ellerman
On Thu, 2019-03-28 at 13:03:45 UTC, Christophe Leroy wrote: > early_alloc_pgtable() never returns NULL as it panics on failure. > > This patch drops the three BUG_ON() which check the non nullity > of early_alloc_pgtable() returned value. > > Signed-off-by: Christophe Leroy Applied to powerpc

Re: [PATCH 08/14] powerpc: entry: Remove unneeded need_resched() loop

2019-05-03 Thread Michael Ellerman
chmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-...@lists.ozlabs.org Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/90437bffa5f9b1440ba03e023f4875d1 cheers

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Michael Ellerman
On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1e496391a8452101308a23b7395cdd49 cheers

[PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-02 Thread Michael Ellerman
ined! We don't want to export those symbols just for this driver, so make the driver only configurable as a built-in. This seems to have been broken since at least commit c92132f59806 ("edac/85xx: Add PCIe error interrupt edac support") (Nov 2013). Signed-off-by: Michael Ellerman ---

Re: [PATCH 037/114] arch: powerpc: Kconfig: pedantic formatting

2019-04-28 Thread Michael Ellerman
"Enrico Weigelt, metux IT consult" writes: > Formatting of Kconfig files doesn't look so pretty, so let the > Great White Handkerchief come around and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/powerpc/Kconfig | 28

Re: [PATCH] x86/mpx: fix recursive munmap() corruption

2019-04-20 Thread Michael Ellerman
Thomas Gleixner writes: > On Mon, 1 Apr 2019, Dave Hansen wrote: >> diff -puN mm/mmap.c~mpx-rss-pass-no-vma mm/mmap.c >> --- a/mm/mmap.c~mpx-rss-pass-no-vma 2019-04-01 06:56:53.409411123 -0700 >> +++ b/mm/mmap.c 2019-04-01 06:56:53.423411123 -0700 >> @@ -2731,9 +2731,17 @@ int

Re: [PATCH 4.9 20/76] powerpc/64: Disable the speculation barrier from the command line

2019-04-17 Thread Michael Ellerman
lation barrier can be disabled from the command line >> with the parameter: "nospectre_v1". >> >> Signed-off-by: Diana Craciun >> Signed-off-by: Michael Ellerman >> Signed-off-by: Sasha Levin >> --- >> arch/powerpc/kernel/security.c | 12 ++

Re: [PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-04-08 Thread Michael Ellerman
Carlos O'Donell writes: > On 4/8/19 3:20 PM, Tulio Magno Quites Machado Filho wrote: >> Carlos O'Donell writes: >> >>> On 4/5/19 5:16 AM, Florian Weimer wrote: * Carlos O'Donell: > It is valuable that it be a trap, particularly for constant pools because > it means that a jump into

Re: [PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-04-02 Thread Michael Ellerman
Mathieu Desnoyers writes: > Hi Carlos, > > - On Mar 22, 2019, at 4:09 PM, Carlos O'Donell codon...@redhat.com wrote: ... > > [...] >>> +++ b/sysdeps/unix/sysv/linux/powerpc/bits/rseq.h > [...] >>> +/* Signature required before each abort handler code. */ >>> +#define RSEQ_SIG 0x53053053 >>

Re: linux-next: build failure after merge of the sound-asoc tree

2019-04-01 Thread Michael Ellerman
Mark Brown writes: > On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote: >> Mark Brown writes: > >> > Hrm, seems PowerPC is still not using the common clock API - is there >> > any plan for that? There are some ASoC PowerPC uses so it's going to b

Re: linux-next: build failure after merge of the sound-asoc tree

2019-03-26 Thread Michael Ellerman
Mark Brown writes: > On Tue, Mar 26, 2019 at 01:33:49PM +1100, Stephen Rothwell wrote: > >> After merging the sound-asoc tree, today's linux-next build (powerpc >> allyesconfig) failed like this: > >> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare': >>

Re: [PATCH v2] powerpc/8xx: fix possible object reference leak

2019-03-25 Thread Michael Ellerman
ease within this function. > > Fixes: a8db8cf0d894 ("irq_domain: Replace irq_alloc_host() with > revmap-specific initializers") > Signed-off-by: Wen Yang > Suggested-by: Christophe Leroy > Reviewed-by: Peng Hao > Cc: Vitaly Bordug > Cc: Benjamin Herre

[GIT PULL] Please pull powerpc/linux.git powerpc-5.1-3 tag

2019-03-22 Thread Michael Ellerman
: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations Christophe Leroy (1): powerpc/6xx: fix setup and use of SPRN_SPRG_PGDIR for hash32 Michael Ellerman (2): powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038 powerpc/security: Fix spectre_v2 reporting arch

Re: [PATCH] printk: Add caller information to printk() output.

2019-03-21 Thread Michael Ellerman
Petr Mladek writes: > On Thu 2019-03-21 13:59:53, Michael Ellerman wrote: >> Tetsuo Handa writes: >> ... >> > From 91f85d2bd494df2f73c605d8b4747e8cc0a61ae2 Mon Sep 17 00:00:00 2001 >> > From: Tetsuo Handa >> > Date: Tue, 18 Dec 2018 05:53:04 +090

Re: [PATCH] printk: Add caller information to printk() output.

2019-03-20 Thread Michael Ellerman
Hi Tetsuo, Thanks for implementing this, it's really helpful. Tetsuo Handa writes: ... > From 91f85d2bd494df2f73c605d8b4747e8cc0a61ae2 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Tue, 18 Dec 2018 05:53:04 +0900 > Subject: [PATCH] printk: Add caller information to printk() output. > >

Re: powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038

2019-03-20 Thread Michael Ellerman
On Wed, 2019-03-13 at 13:14:38 UTC, Michael Ellerman wrote: > Jakub Drnec reported: > Setting the realtime clock can sometimes make the monotonic clock go > back by over a hundred years. Decreasing the realtime clock across > the y2k38 threshold is one reliable way to reproduc

Re: [PATCH] powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038

2019-03-14 Thread Michael Ellerman
Arnd Bergmann writes: > On Wed, Mar 13, 2019 at 2:14 PM Michael Ellerman wrote: > >> That causes CLOCK_MONOTONIC to jump ahead by ~4 billion seconds which >> it is not meant to do. Worse, if the time is then set back before the >> Y2038 boundary CLOCK_MONOTONIC will jum

[PATCH] powerpc/vdso64: Fix CLOCK_MONOTONIC inconsistencies across Y2038

2019-03-13 Thread Michael Ellerman
TCH] powerpc: vdso fixes (take #2)") Cc: sta...@vger.kernel.org # v2.6.15+ Link: http://lkml.kernel.org/r/hac.zfes.62bwlnvavmp.1st...@seznam.cz Reported-by: Jakub Drnec Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/vdso_datapage.h | 8 arch/powerpc/kernel/vdso64/gettimeofda

[GIT PULL] Please pull powerpc/linux.git powerpc-5.1-1 tag

2019-03-07 Thread Michael Ellerman
powerpc: Remove trailing semicolon after curly brace Move static keyword at beginning of declaration Matteo Croce (1): powerpc/hvsi: Fix spelling mistake: "lenght" should be "length" Michael Ellerman (19): powerpc: Stop using pr_cont() in __die() p

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-06 Thread Michael Ellerman
Linus Torvalds writes: > On Mon, Mar 4, 2019 at 2:24 AM Michael Ellerman wrote: >> >> Without wading into the rest of the discussion, this does raise an >> interesting point, ie. what about eg. rwlock's? >> >> They're basically equivalent to spinlocks, and s

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-04 Thread Michael Ellerman
Nicholas Piggin writes: > Will Deacon's on March 2, 2019 12:03 am: >> In preparation for removing all explicit mmiowb() calls from driver >> code, implement a tracking system in asm-generic based loosely on the >> PowerPC implementation. This allows architectures with a non-empty >> mmiowb()

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-03 Thread Michael Ellerman
Nicholas Piggin writes: > Michael Ellerman's on March 3, 2019 7:26 pm: >> Nicholas Piggin writes: ... >>> what was broken about the powerpc one, which is basically: >>> >>> static inline void mmiowb_set_pending(void) >>> { >>> struct mmiowb_state *ms = __mmiowb_state(); >>>

Re: [v2] powerpc/mm: fix "section_base" set but not used

2019-03-03 Thread Michael Ellerman
On Fri, 2019-03-01 at 14:20:40 UTC, Qian Cai wrote: > The commit 24b6d4164348 ("mm: pass the vmem_altmap to vmemmap_free") > removed a line in vmemmap_free(), > > altmap = to_vmem_altmap((unsigned long) section_base); > > but left a variable no longer used. > > arch/powerpc/mm/init_64.c: In

Re: powerpc/32: Clear on-stack exception marker upon exception return

2019-03-03 Thread Michael Ellerman
On Wed, 2019-02-27 at 11:45:30 UTC, Christophe Leroy wrote: > Clear the on-stack STACK_FRAME_REGS_MARKER on exception exit in order > to avoid confusing stacktrace like the one below. > > Call Trace: > [c0e9dca0] [c01c42a0] print_address_description+0x64/0x2bc (unreliable) > [c0e9dcd0] [c01c4684]

Re: powerpc: fix "sz" set but not used

2019-03-03 Thread Michael Ellerman
On Thu, 2019-02-28 at 02:35:05 UTC, Qian Cai wrote: > arch/powerpc/mm/hugetlbpage-hash64.c: In function '__hash_page_huge': > arch/powerpc/mm/hugetlbpage-hash64.c:29:28: warning: variable 'sz' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Qian Cai Applied to powerpc next,

Re: [1/2] powerpc: remove nargs from __SYSCALL

2019-03-03 Thread Michael Ellerman
On Wed, 2019-01-02 at 15:02:03 UTC, Firoz Khan wrote: > The __SYSCALL macro's arguments are system call number, > system call entry name and number of arguments for the > system call. > > Argument- nargs in __SYSCALL(nr, entry, nargs) is neither > calculated nor used anywhere. So it would be

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-03 Thread Michael Ellerman
Nicholas Piggin writes: > Will Deacon's on March 2, 2019 12:03 am: >> In preparation for removing all explicit mmiowb() calls from driver >> code, implement a tracking system in asm-generic based loosely on the >> PowerPC implementation. This allows architectures with a non-empty >> mmiowb()

Re: [PATCH 00/20] Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb())

2019-03-02 Thread Michael Ellerman
Linus Torvalds writes: > Love the acronym, and the series looks good to me. > > Michael - can you check (or maybe you already did?) that this works > for ppc too, and doesn't have any gotcha's? Yeah it looks fine to me. I gave it a quick boot with a patch to count how many mb()s we actually

Re: [PATCH 12/20] powerpc/mmiowb: Hook up mmwiob() implementation to asm-generic code

2019-03-02 Thread Michael Ellerman
werpc/include/asm/mmiowb.h Thanks for fixing our bugs for us, I owe you some more beers :) I meant to reply to your previous series saying that we could just use more space in the paca, but you obviously worked that out yourself. I'll run this through our builders and do some boot tests but I l

<    5   6   7   8   9   10   11   12   13   14   >