Re: [PATCH] drivers: mcb: use symbol namespaces

On 16.10.19 12:01, Johannes Thumshirn wrote: > Now that we have symbol namespaces, use them in MCB to not pollute the > default namespace with MCB internals. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Michael Moese > --- > drivers/gpio/gpio-menz127.c

Re: [PATCH] 8250-men-mcb: fix error checking when get_num_ports returns -ENODEV

being less than zero to check for -ve error returns. Addresses-Coverity: ("Unsigned compared against 0") Fixes: e2fea54e4592 ("8250-men-mcb: add support for 16z025 and 16z057") Signed-off-by: Colin Ian King This looks more than reasonable to me, thanks. Reviewed-by: Michael Mo

Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

On Mon, Jul 16, 2018 at 09:25:10AM +0200, Johannes Thumshirn wrote: > Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Michael Moese > > --- > Changes to v1: > * Sorted includes alphabetically

Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

On Mon, Jul 16, 2018 at 09:25:10AM +0200, Johannes Thumshirn wrote: > Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Michael Moese > > --- > Changes to v1: > * Sorted includes alphabetically

Re: LTP CVE cve-2017-17053 test failed on x86_64 device

Hi, On Wed, Jun 20, 2018 at 12:14:22PM +0530, Naresh Kamboju wrote: > Test FAIL case output, > tst_test.c:1015: INFO: Timeout per run is 0h 15m 00s > tst_taint.c:88: BROK: Kernel is already tainted: 512 The kernel is already tainted. In this case, the test refuses to run, because it could not

Re: LTP CVE cve-2017-17053 test failed on x86_64 device

Hi, On Wed, Jun 20, 2018 at 12:14:22PM +0530, Naresh Kamboju wrote: > Test FAIL case output, > tst_test.c:1015: INFO: Timeout per run is 0h 15m 00s > tst_taint.c:88: BROK: Kernel is already tainted: 512 The kernel is already tainted. In this case, the test refuses to run, because it could not

[PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese <mmo...@suse.de> Reported-by: Ben Turner &l

[PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese Reported-by: Ben Turner Tested-by: Ben Turner --- Sorry

Re: [PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Hi, sorry.. my bad. Not my day today. I forgot to commit :/ I'll resend. On Mon, Mar 05, 2018 at 05:17:04PM +0200, Andy Shevchenko wrote: > On Mon, Mar 5, 2018 at 10:22 AM, Michael Moese <mmo...@suse.de> wrote: > > Add support for two MEN UARTs (16z025 and 16z057) to the > >

Re: [PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Hi, sorry.. my bad. Not my day today. I forgot to commit :/ I'll resend. On Mon, Mar 05, 2018 at 05:17:04PM +0200, Andy Shevchenko wrote: > On Mon, Mar 5, 2018 at 10:22 AM, Michael Moese wrote: > > Add support for two MEN UARTs (16z025 and 16z057) to the > > 8250_men_mcb driver.

[PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese <mmo...@suse.de> Reported-by: Ben Turner &l

[PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese Reported-by: Ben Turner Tested-by: Ben Turner

[PATCH v2] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese <mmo...@suse.de> Reported-by: Ben Turner &l

[PATCH v2] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese Reported-by: Ben Turner Tested-by: Ben Turner

Re: [PATCH] 8250-men-mcb: add support for 16z025 and 16z057

Hi, Thanks for your comments. Let me briefly respond. On Tue, Feb 27, 2018 at 07:57:34PM +0200, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 5:31 PM, Michael Moese <mmo...@suse.de> wrote: > > - else if (strncmp(mdev->bus->name, "F216", 4) == 0) > &g

Re: [PATCH] 8250-men-mcb: add support for 16z025 and 16z057

Hi, Thanks for your comments. Let me briefly respond. On Tue, Feb 27, 2018 at 07:57:34PM +0200, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 5:31 PM, Michael Moese wrote: > > - else if (strncmp(mdev->bus->name, "F216", 4) == 0) > > + else if (str

[PATCH] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese <mmo...@suse.de> Reported-by: Ben Turner &l

[PATCH] 8250-men-mcb: add support for 16z025 and 16z057

Add support for two MEN UARTs (16z025 and 16z057) to the 8250_men_mcb driver. The 16z025 consists of up to four ports, the 16z057 has exactly four ports. Apart from that, all of them share the Port settings. Signed-off-by: Michael Moese Reported-by: Ben Turner Tested-by: Ben Turner

Re: [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci

Looks good. Reviewed-by: Michael Moese <mmo...@suse.de> On Tue, Feb 27, 2018 at 02:30:18PM +0100, Johannes Thumshirn wrote: > Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead > of the MEN one. Add it to the PCI ID table so the driver automaticall

Re: [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci

Looks good. Reviewed-by: Michael Moese On Tue, Feb 27, 2018 at 02:30:18PM +0100, Johannes Thumshirn wrote: > Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead > of the MEN one. Add it to the PCI ID table so the driver automatically > attaches to it. >

[PATCH] Introduce dmam_zalloc_coherent()

dmam_zalloc_coherent(), exactly like the implementation of dma_zalloc_coherent(). Signed-off-by: Michael Moese <michael.mo...@men.de> --- include/linux/dma-mapping.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h

[PATCH] Introduce dmam_zalloc_coherent()

dmam_zalloc_coherent(), exactly like the implementation of dma_zalloc_coherent(). Signed-off-by: Michael Moese --- include/linux/dma-mapping.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 03c0196a6f24..cf6cbda76ee2

[PATCH v2 1/2] mcb: introduce mcb_get_resource()

From: Johannes Thumshirn Introduce mcb_get_resource() as a common accessor to a mcb device's memory or IRQ resources. Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-core.c | 20 +++- include/linux/mcb.h| 2 ++ 2 files

[PATCH v2 1/2] mcb: introduce mcb_get_resource()

From: Johannes Thumshirn Introduce mcb_get_resource() as a common accessor to a mcb device's memory or IRQ resources. Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-core.c | 20 +++- include/linux/mcb.h| 2 ++ 2 files changed, 21 insertions(+), 1 deletion(-) diff

[PATCH v2 2/2] Introduce 8250_men_mcb

. Additional values for other boards will be added later. This v2 has some whitespace fixes, I screwed this up yesterday. Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/tty/serial/8250/8250_men_mcb.c | 118 + drivers/tty/serial/8250/K

[PATCH v2 2/2] Introduce 8250_men_mcb

. Additional values for other boards will be added later. This v2 has some whitespace fixes, I screwed this up yesterday. Signed-off-by: Michael Moese --- drivers/tty/serial/8250/8250_men_mcb.c | 118 + drivers/tty/serial/8250/Kconfig| 11 +++ drivers/tty

[PATCH] MCB: add support for SC31 to mcb-lpc

This patch adds the resources and DMI ID's for the MEN SC31, which uses a different address region to map the LPC bus than the one used for the existing SC24. Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-lpc.c | 15 +++ 1 file changed, 15 inse

[PATCH] MCB: add support for SC31 to mcb-lpc

This patch adds the resources and DMI ID's for the MEN SC31, which uses a different address region to map the LPC bus than the one used for the existing SC24. Signed-off-by: Michael Moese --- drivers/mcb/mcb-lpc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mcb

[PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

From: Andreas Werner Signed-off-by: Andreas Werner --- drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index

[PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

From: Andreas Werner Signed-off-by: Andreas Werner --- drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 1cf74aa4ebd9..87e496eeefb1 100644 ---

[PATCH] mcb: fix compiler warning logical-op in mcb-parse.c

The expression was clearly wrong, the logical AND of expressions must be changed to a logical OR. Reported-by: David Binderman <dcb...@hotmail.com> Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] mcb: fix compiler warning logical-op in mcb-parse.c

The expression was clearly wrong, the logical AND of expressions must be changed to a logical OR. Reported-by: David Binderman Signed-off-by: Michael Moese --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb

[PATCH v2 2/2] Add a dma_device to mcb_device

. Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-core.c | 1 + include/linux/mcb.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index 5306966..921a5d2 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core

[PATCH v2 2/2] Add a dma_device to mcb_device

. Signed-off-by: Michael Moese --- drivers/mcb/mcb-core.c | 1 + include/linux/mcb.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index 5306966..921a5d2 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core.c @@ -233,6 +233,7 @@ int mcb_de

[PATCH v2 1/2] Enable PCI bus mastering by default

In order to successfully perform DMA operations on PCI devices, it is necessary to enble PCI bus mastering, so enable it by default. Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mcb/mcb-pci.c b/d

[PATCH v2 1/2] Enable PCI bus mastering by default

In order to successfully perform DMA operations on PCI devices, it is necessary to enble PCI bus mastering, so enable it by default. Signed-off-by: Michael Moese --- drivers/mcb/mcb-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c index

[PATCH v2 0/2] Add (PCI) DMA support to MCB.

-based MCB devices. The second patch adds a dma_device to the mcb_device for all devices as a shortcut to mcb_device->bus->carrier. Michael Moese (2): Enable PCI bus mastering by default Add a dma_device to mcb_device drivers/mcb/mcb-core.c | 1 + drivers/mcb/mcb-pci.c | 1 + include

[PATCH v2 0/2] Add (PCI) DMA support to MCB.

-based MCB devices. The second patch adds a dma_device to the mcb_device for all devices as a shortcut to mcb_device->bus->carrier. Michael Moese (2): Enable PCI bus mastering by default Add a dma_device to mcb_device drivers/mcb/mcb-core.c | 1 + drivers/mcb/mcb-pci.c | 1 + include

[Add PCI DMA support to MCB 0/2]

This small series of two patches enable (PCI) DMA support in MCB. The first patch enables PCI bus mastering by default for all PCI-based MCB devices. The second patch adds a dma_device to the mcb_device for all devices as a shortcut to mcb_device->bus->carrier. Michael Moese (2): Enab

[Add PCI DMA support to MCB 2/2] Add a dma_device to mcb_device

Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-core.c | 1 + include/linux/mcb.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index 5306966..e74bfea 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/m

[Add PCI DMA support to MCB 0/2]

This small series of two patches enable (PCI) DMA support in MCB. The first patch enables PCI bus mastering by default for all PCI-based MCB devices. The second patch adds a dma_device to the mcb_device for all devices as a shortcut to mcb_device->bus->carrier. Michael Moese (2): Enab

[Add PCI DMA support to MCB 2/2] Add a dma_device to mcb_device

Signed-off-by: Michael Moese --- drivers/mcb/mcb-core.c | 1 + include/linux/mcb.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index 5306966..e74bfea 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core.c @@ -233,6 +233,7

[Add PCI DMA support to MCB 1/2] Enable PCI bus mastering by default

Signed-off-by: Michael Moese <michael.mo...@men.de> --- drivers/mcb/mcb-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c index b15a034..af4d2f2 100644 --- a/drivers/mcb/mcb-pci.c +++ b/drivers/mcb/mcb-pci.c @@ -46,6 +46,7 @@ stat

[Add PCI DMA support to MCB 1/2] Enable PCI bus mastering by default

Signed-off-by: Michael Moese --- drivers/mcb/mcb-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c index b15a034..af4d2f2 100644 --- a/drivers/mcb/mcb-pci.c +++ b/drivers/mcb/mcb-pci.c @@ -46,6 +46,7 @@ static int mcb_pci_probe(struct pci_dev

[RFC PATCH] powerpc: add ioremap_wt

Allow for IO memory to be mapped cacheable for performing PCI read bursts. Signed-off-by: Michael Moese --- arch/powerpc/include/asm/io.h | 3 +++ arch/powerpc/mm/pgtable_32.c | 8 2 files changed, 11 insertions(+) diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm

[RFC PATCH] powerpc: add ioremap_wt

Allow for IO memory to be mapped cacheable for performing PCI read bursts. Signed-off-by: Michael Moese michael.mo...@men.de --- arch/powerpc/include/asm/io.h | 3 +++ arch/powerpc/mm/pgtable_32.c | 8 2 files changed, 11 insertions(+) diff --git a/arch/powerpc/include/asm/io.h b/arch