Re: [PATCH] Unexport LANG env variable

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 14:40 Alexey Brodkin napsal(a): > In those cases when we parse output of standard utilities like readelf > etc we rely on a particular sentences. For example for ARC we extract > an entry-point from vmlinux like that: > -->8 > readelf -h

Re: [PATCH] Unexport LANG env variable

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 14:40 Alexey Brodkin napsal(a): > In those cases when we parse output of standard utilities like readelf > etc we rely on a particular sentences. For example for ARC we extract > an entry-point from vmlinux like that: > -->8 > readelf -h

Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro

2017-06-14 Thread Michal Marek
n-raw >>> - Updated commit message >>> >>> scripts/Kbuild.include | 9 +++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >> >> Acked-by: Masahiro Yamada <yamada.masah...@socionext.com> >> (if nothing better pops up) > > Acked-by: Arnd Bergmann <a...@arndb.de> Acked-by: Michal Marek <mma...@suse.com> > Regarding the naming, __cc-option might be better than cc-option-raw, > but the current version is fine too. I have no strong opinion either way :). Michal

Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro

2017-06-14 Thread Michal Marek
ro name from Add cc-option-no-kbuild to cc-option-raw >>> - Added compiler as parameter to the macro >>> - Reworked cc-option to make use of cc-option-raw >>> - Updated commit message >>> >>> scripts/Kbuild.include | 9 +++-- >>> 1 file

Re: [PATCH v2] Kbuild: tiny correction on `make help`

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 09:08 Cao jin napsal(a): > > > On 06/14/2017 09:15 AM, Masahiro Yamada wrote: >> 2017-06-13 18:52 GMT+09:00 Cao jin : >>> Yamada-san, >>> >>> I have a question on the current top level Makefile. There are >>> following lines, I have trouble to

Re: [PATCH v2] Kbuild: tiny correction on `make help`

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 09:08 Cao jin napsal(a): > > > On 06/14/2017 09:15 AM, Masahiro Yamada wrote: >> 2017-06-13 18:52 GMT+09:00 Cao jin : >>> Yamada-san, >>> >>> I have a question on the current top level Makefile. There are >>> following lines, I have trouble to understand "firstword

Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro

2017-06-13 Thread Michal Marek
On 2017-06-13 02:55, Matthias Kaehlcke wrote: > cc-option uses KBUILD_CFLAGS and KBUILD_CPPFLAGS when it determines > whether an option is supported or not. This is fine for options used to > build the kernel itself, however some components like the x86 boot code > use a different set of flags. >

Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro

2017-06-13 Thread Michal Marek
On 2017-06-13 02:55, Matthias Kaehlcke wrote: > cc-option uses KBUILD_CFLAGS and KBUILD_CPPFLAGS when it determines > whether an option is supported or not. This is fine for options used to > build the kernel itself, however some components like the x86 boot code > use a different set of flags. >

Re: [PATCH] kbuild: simplify silent build (-s) detection

2017-05-19 Thread Michal Marek
On 2017-05-19 06:28, Masahiro Yamada wrote: > This allows to detect -s option without checking GNU Make version. > > As commit e36aaea28972 ("kbuild: Fix silent builds with make-4") > pointed out, GNU Make 4.x changed the way/order it presents the > command line options into MAKEFLAGS. > > In

Re: [PATCH] kbuild: simplify silent build (-s) detection

2017-05-19 Thread Michal Marek
On 2017-05-19 06:28, Masahiro Yamada wrote: > This allows to detect -s option without checking GNU Make version. > > As commit e36aaea28972 ("kbuild: Fix silent builds with make-4") > pointed out, GNU Make 4.x changed the way/order it presents the > command line options into MAKEFLAGS. > > In

Re: [RFC] Increase Minimal GNU Make version for Linux Kernel from 3.80 to 3.81

2017-05-03 Thread Michal Marek
On 2017-05-03 08:46, Masahiro Yamada wrote: > Hello Linus and Kbuild developers. > > > Documentation/process/changes.rst says the minimal version > of GNU Make is 3.80, but actually building the kernel > with this version has been broken for a long time. > > Specifically, it got broken by

Re: [RFC] Increase Minimal GNU Make version for Linux Kernel from 3.80 to 3.81

2017-05-03 Thread Michal Marek
On 2017-05-03 08:46, Masahiro Yamada wrote: > Hello Linus and Kbuild developers. > > > Documentation/process/changes.rst says the minimal version > of GNU Make is 3.80, but actually building the kernel > with this version has been broken for a long time. > > Specifically, it got broken by

Re: [RFC-b PATCH] kbuild: redefine __FILE__ as relative path from $(srctree) if possible

2017-04-21 Thread Michal Marek
Dne 21.4.2017 v 21:36 Masahiro Yamada napsal(a): > Since Kbuild runs in the objtree, __FILE__ can be a very long path > depending of $(srctree). > > Commit 9da0763bdd82 ("kbuild: Use relative path when building in a > subdir of the source tree") made the situation better for cases > where objtree

Re: [RFC-b PATCH] kbuild: redefine __FILE__ as relative path from $(srctree) if possible

2017-04-21 Thread Michal Marek
Dne 21.4.2017 v 21:36 Masahiro Yamada napsal(a): > Since Kbuild runs in the objtree, __FILE__ can be a very long path > depending of $(srctree). > > Commit 9da0763bdd82 ("kbuild: Use relative path when building in a > subdir of the source tree") made the situation better for cases > where objtree

Re: [PATCH 0/5] Fix dead URLs to ftp.kernel.org

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 07:47 SeongJae Park napsal(a): > URLs to `ftp.kernel.org` exist here and there though `ftp.kernel.org` is > already dead [0]. This patchset fixes those URLs to use `www.kernel.org` > instead. > > The change is splitted into multiple patches for independent review and merge > of

Re: [PATCH 0/5] Fix dead URLs to ftp.kernel.org

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 07:47 SeongJae Park napsal(a): > URLs to `ftp.kernel.org` exist here and there though `ftp.kernel.org` is > already dead [0]. This patchset fixes those URLs to use `www.kernel.org` > instead. > > The change is splitted into multiple patches for independent review and merge > of

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 09:58 Sebastian Andrzej Siewior napsal(a): > On 2017-03-24 13:35:40 [+0800], Chao Peng wrote: >> > kernel kernel sizetime in decompress_kernel > compressed (gzip)3.3M 53ms > uncompressed 14M3ms >>

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 09:58 Sebastian Andrzej Siewior napsal(a): > On 2017-03-24 13:35:40 [+0800], Chao Peng wrote: >> > kernel kernel sizetime in decompress_kernel > compressed (gzip)3.3M 53ms > uncompressed 14M3ms >>

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-24 Thread Michal Marek
On 2017-03-23 13:51, Chao Peng wrote: > Compressed kernel has its own drawback: uncompressing takes time. Even > though the time is short enough to ignore for most cases but for cases that > time is critical this is still a big number. In our on-going optimization > for kernel boot time, the

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-24 Thread Michal Marek
On 2017-03-23 13:51, Chao Peng wrote: > Compressed kernel has its own drawback: uncompressing takes time. Even > though the time is short enough to ignore for most cases but for cases that > time is critical this is still a big number. In our on-going optimization > for kernel boot time, the

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path

2017-03-15 Thread Michal Marek
Dne 15.3.2017 v 15:51 Tom Rini napsal(a): > I found https://patchwork.kernel.org/patch/9442211/ today and I see that > it was brought up again just before I sent my patch. I just want to > point out that 9442211 doesn't address arm, arc, and sh and they will > still not have a functional rpm

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path

2017-03-15 Thread Michal Marek
Dne 15.3.2017 v 15:51 Tom Rini napsal(a): > I found https://patchwork.kernel.org/patch/9442211/ today and I see that > it was brought up again just before I sent my patch. I just want to > point out that 9442211 doesn't address arm, arc, and sh and they will > still not have a functional rpm

Re: Kbuild maintainership

2017-03-13 Thread Michal Marek
On 2017-03-11 06:45, Masahiro Yamada wrote: > Hi Michal, > > 2017-03-10 19:15 GMT+09:00 Michal Marek <mma...@suse.com>: >> On 2017-03-10 10:17, Stephen Rothwell wrote: >>> I assume that I will get a request to change the kbuild-current and >>> kbuilt tre

Re: Kbuild maintainership

2017-03-13 Thread Michal Marek
On 2017-03-11 06:45, Masahiro Yamada wrote: > Hi Michal, > > 2017-03-10 19:15 GMT+09:00 Michal Marek : >> On 2017-03-10 10:17, Stephen Rothwell wrote: >>> I assume that I will get a request to change the kbuild-current and >>> kbuilt trees in linux-next soon.

Re: [PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 18:58 Will Deacon napsal(a): > Hi Michael, > > On Tue, Nov 22, 2016 at 10:34:29PM +0100, Michal Marek wrote: >> The KBUILD_IMAGE variable is used by the rpm and deb-pkg targets, which >> expect it to point to the image file in the build directory. The &

Re: [PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 18:58 Will Deacon napsal(a): > Hi Michael, > > On Tue, Nov 22, 2016 at 10:34:29PM +0100, Michal Marek wrote: >> The KBUILD_IMAGE variable is used by the rpm and deb-pkg targets, which >> expect it to point to the image file in the build directory. The &

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
On 2017-03-10 10:17, Stephen Rothwell wrote: > I assume that I will get a request to change the kbuild-current and > kbuilt trees in linux-next soon. In the meantime, should I remove the > current ones? There is one genksyms fix in kbuild.git#kbuild which is not in mainline. Masahiro, can you

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
On 2017-03-10 10:17, Stephen Rothwell wrote: > I assume that I will get a request to change the kbuild-current and > kbuilt trees in linux-next soon. In the meantime, should I remove the > current ones? There is one genksyms fix in kbuild.git#kbuild which is not in mainline. Masahiro, can you

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 03:07 Masahiro Yamada napsal(a): > Hello Kbuild contributors, > > > As you may notice, Michal has been busy since the beginning > of this year, and it has been getting difficult for him to > work on Kbuild on his regular basis. Yes, that's unfortunately the case. > Michal sent

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 03:07 Masahiro Yamada napsal(a): > Hello Kbuild contributors, > > > As you may notice, Michal has been busy since the beginning > of this year, and it has been getting difficult for him to > work on Kbuild on his regular basis. Yes, that's unfortunately the case. > Michal sent

[GIT PULL] kbuild fix for v4.10-rc3

2017-01-06 Thread Michal Marek
: Clear any CPP defines before declaring the functions (2017-01-05 12:57:42 +0100) Michal Marek (1): asm-prototypes: Clear any CPP defines before declaring the functions include/asm-generic/asm-prototypes.h | 6 ++ 1 file

[GIT PULL] kbuild fix for v4.10-rc3

2017-01-06 Thread Michal Marek
: Clear any CPP defines before declaring the functions (2017-01-05 12:57:42 +0100) Michal Marek (1): asm-prototypes: Clear any CPP defines before declaring the functions include/asm-generic/asm-prototypes.h | 6 ++ 1 file

Re: [PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-05 Thread Michal Marek
On 2017-01-05 10:33, Borislav Petkov wrote: > On Tue, Jan 03, 2017 at 03:14:54PM +0100, Michal Marek wrote: >> During real build, this manifests itself by genksyms segfaulting. >> >> Reported-by: Borislav Petkov <b...@alien8.de> > > ... -and-tested-by: ... > &

Re: [PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-05 Thread Michal Marek
On 2017-01-05 10:33, Borislav Petkov wrote: > On Tue, Jan 03, 2017 at 03:14:54PM +0100, Michal Marek wrote: >> During real build, this manifests itself by genksyms segfaulting. >> >> Reported-by: Borislav Petkov > > ... -and-tested-by: ... > > For all three. &g

[PATCH 2/3] genksyms: Fix segfault with invalid declarations

2017-01-03 Thread Michal Marek
The last one was a real-life bug with include/asm-generic/asm-prototypes.h on x86_64. Reported-by: Borislav Petkov <b...@alien8.de> Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/genksyms/parse.y | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/genksyms/parse

[PATCH 2/3] genksyms: Fix segfault with invalid declarations

2017-01-03 Thread Michal Marek
The last one was a real-life bug with include/asm-generic/asm-prototypes.h on x86_64. Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.y | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/genksyms/parse.y b/scripts/genksyms/parse.y index 4fba255e54ae

[PATCH 3/3] genksyms: Regenerate parser

2017-01-03 Thread Michal Marek
Regenerate the parser after 309d4cef4667 ("genksyms: Fix segfault with invalid declarations"). Reported-by: Reported-by: Borislav Petkov <b...@alien8.de> Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/genksyms/parse.tab.c_shipped | 474 +

[PATCH 3/3] genksyms: Regenerate parser

2017-01-03 Thread Michal Marek
Regenerate the parser after 309d4cef4667 ("genksyms: Fix segfault with invalid declarations"). Reported-by: Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.tab.c_shipped | 474 +-- 1 file changed, 234 insertio

[PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-03 Thread Michal Marek
); ^ ... During real build, this manifests itself by genksyms segfaulting. Reported-by: Borislav Petkov <b...@alien8.de> Cc: Adam Borowski <kilob...@angband.pl> Signed-off-by: Michal Marek <mma...@suse.com> --- include/asm-generic/asm-prototypes.h

[PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-03 Thread Michal Marek
); ^ ... During real build, this manifests itself by genksyms segfaulting. Reported-by: Borislav Petkov Cc: Adam Borowski Signed-off-by: Michal Marek --- include/asm-generic/asm-prototypes.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/asm

Re: default 0 if KASAN expression not working in kbuild

2016-12-19 Thread Michal Marek
On 2016-12-15 19:09, Nikolay Borisov wrote: > Hello, > > I was doing some kasan-related debugging and when I enabled it I started > getting warnings for large stackframes. So CONFIG_FRAME_WARN has : > > int "Warn for stack frames larger than (needs gcc 4.4)" > range 0 8192 > default 0 if

Re: default 0 if KASAN expression not working in kbuild

2016-12-19 Thread Michal Marek
On 2016-12-15 19:09, Nikolay Borisov wrote: > Hello, > > I was doing some kasan-related debugging and when I enabled it I started > getting warnings for large stackframes. So CONFIG_FRAME_WARN has : > > int "Warn for stack frames larger than (needs gcc 4.4)" > range 0 8192 > default 0 if

Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

2016-12-19 Thread Michal Marek
On 2016-12-18 13:35, Cheah Kok Cheong wrote: > If no duplicates found, inform user. > > Signed-off-by: Cheah Kok Cheong > --- > scripts/checkincludes.pl | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/scripts/checkincludes.pl

Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

2016-12-19 Thread Michal Marek
On 2016-12-18 13:35, Cheah Kok Cheong wrote: > If no duplicates found, inform user. > > Signed-off-by: Cheah Kok Cheong > --- > scripts/checkincludes.pl | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl > index

[GIT PULL] kconfig update for v4.10-rc1

2016-12-17 Thread Michal Marek
Hi Linus, please pull these kconfig bits for v4.10-rc1: - make xconfig gui fixes - make nconfig fix for options with long prompts - fix make nconfig warning when pkg-config forces -D_GNU_SOURCE Michal The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1

[GIT PULL] kbuild updates for v4.10-rc1

2016-12-17 Thread Michal Marek
): x86/kbuild: enable modversions for symbols exported from asm Ard Biesheuvel (1): scripts/kallsyms: remove last remnants of --page-offset option Michal Marek (1): genksyms: Regenerate parser Nicholas Piggin (7): kbuild: kallsyms allow 3-pass generation if symbols size has

[GIT PULL] kconfig update for v4.10-rc1

2016-12-17 Thread Michal Marek
Hi Linus, please pull these kconfig bits for v4.10-rc1: - make xconfig gui fixes - make nconfig fix for options with long prompts - fix make nconfig warning when pkg-config forces -D_GNU_SOURCE Michal The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1

[GIT PULL] kbuild updates for v4.10-rc1

2016-12-17 Thread Michal Marek
): x86/kbuild: enable modversions for symbols exported from asm Ard Biesheuvel (1): scripts/kallsyms: remove last remnants of --page-offset option Michal Marek (1): genksyms: Regenerate parser Nicholas Piggin (7): kbuild: kallsyms allow 3-pass generation if symbols size has

[GIT PULL] kbuild misc updates for v4.10-rc1

2016-12-17 Thread Michal Marek
host-arch debs Andrew F. Davis (1): Coccinelle: Add misc/boolconv.cocci Anton Tikhomirov (1): kbuild/mkspec: avoid using brace expansion Michal Marek (1): Merge branch 'kbuild/rc-fixes' into kbuild/misc Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules

[GIT PULL] kbuild misc updates for v4.10-rc1

2016-12-17 Thread Michal Marek
host-arch debs Andrew F. Davis (1): Coccinelle: Add misc/boolconv.cocci Anton Tikhomirov (1): kbuild/mkspec: avoid using brace expansion Michal Marek (1): Merge branch 'kbuild/rc-fixes' into kbuild/misc Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:15, Michal Marek wrote: > A minimal example would be > > t1.c: > struct s1; > struct s2 { > int i; > } > struct s3 { > struct s1 *ptr1; > struct s2 *ptr2; > } > void foo(struct s3*); > EXPORT_SYMBOL(foo); > > t2.c:

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:15, Michal Marek wrote: > A minimal example would be > > t1.c: > struct s1; > struct s2 { > int i; > } > struct s3 { > struct s1 *ptr1; > struct s2 *ptr2; > } > void foo(struct s3*); > EXPORT_SYMBOL(foo); > > t2.c:

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 11:02, Dodji Seketeli wrote: > Michal Marek <mma...@suse.com> a écrit: > >>> Libabigail does a "whole binary" analysis of types. >>> >>> So, consider the point of use of the type 'struct s1*'. Even if 'struct >>> s' is just

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 11:02, Dodji Seketeli wrote: > Michal Marek a écrit: > >>> Libabigail does a "whole binary" analysis of types. >>> >>> So, consider the point of use of the type 'struct s1*'. Even if 'struct >>> s' is just forward-

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:36, Dodji Seketeli wrote: > Michal Marek <mma...@suse.com> a écrit: > > [...] > >> A minimal example would be >> >> t1.c: >> struct s1; >> struct s2 { >> int i; >> } >> struct s3 { >>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:36, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> A minimal example would be >> >> t1.c: >> struct s1; >> struct s2 { >> int i; >> } >> struct s3 { >> struct s1 *ptr1; >>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 09:58, Dodji Seketeli wrote: > Michal Marek <mma...@suse.com> a écrit: > > [...] > >> Does the abidiff tool handle the case when an exported symbol is moved >> between .c files? This is always a mess with genksyms, because the two >> .c fi

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 09:58, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> Does the abidiff tool handle the case when an exported symbol is moved >> between .c files? This is always a mess with genksyms, because the two >> .c files have different includ

Re: [PATCH v3 1/1] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 11.12.2016 v 02:09 Adam Borowski napsal(a): > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be

Re: [PATCH v3 1/1] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 11.12.2016 v 02:09 Adam Borowski napsal(a): > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be

Re: [PATCH 2/2] kbuild: make modversion for exported asm symbols more convivial

2016-12-13 Thread Michal Marek
Dne 8.12.2016 v 05:24 Nicolas Pitre napsal(a): > Rather than having an asm-prototypes.h file where C prototypes for exported > asm symbols are centralized, let's have some macros that can be used > directly in the code where those symbols are exported for genksyms > consumption. Either the

Re: [PATCH 2/2] kbuild: make modversion for exported asm symbols more convivial

2016-12-13 Thread Michal Marek
Dne 8.12.2016 v 05:24 Nicolas Pitre napsal(a): > Rather than having an asm-prototypes.h file where C prototypes for exported > asm symbols are centralized, let's have some macros that can be used > directly in the code where those symbols are exported for genksyms > consumption. Either the

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 9.12.2016 v 23:46 Dodji Seketeli napsal(a): > Hello, > > Nicholas Piggin a écrit: > > [...] > >> That said, a dwarf based checker tool should be able to do as good a job >> (maybe a bit better because report is very informative and it may pick up >> compiler alignments

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 9.12.2016 v 23:46 Dodji Seketeli napsal(a): > Hello, > > Nicholas Piggin a écrit: > > [...] > >> That said, a dwarf based checker tool should be able to do as good a job >> (maybe a bit better because report is very informative and it may pick up >> compiler alignments or padding options).

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Michal Marek
Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a): > Michal Marek <mma...@suse.com> writes: >> Please use the KBUILD_OUTPUT variable and not O. > Well, I can't as far as I know. I tried, see below ... > > Explanation : > - if I add just below the line "j=${i/\.[cS]

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Michal Marek
Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a): > Michal Marek writes: >> Please use the KBUILD_OUTPUT variable and not O. > Well, I can't as far as I know. I tried, see below ... > > Explanation : > - if I add just below the line "j=${i/\.[cS]/\.o}" the foll

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check doesn't work, and >>

Re: [PATCH] scripts/kallsyms: remove last remnants of --page-offset option

2016-12-11 Thread Michal Marek
On Fri, Nov 25, 2016 at 08:43:55AM +, Ard Biesheuvel wrote: > On 28 October 2016 at 18:09, Ard Biesheuvel wrote: > > The implementation of the --page-offset kallsyms command line option has > > been removed, so remove it from the usage string as well. > > > >

Re: [PATCH] scripts/kallsyms: remove last remnants of --page-offset option

2016-12-11 Thread Michal Marek
On Fri, Nov 25, 2016 at 08:43:55AM +, Ard Biesheuvel wrote: > On 28 October 2016 at 18:09, Ard Biesheuvel wrote: > > The implementation of the --page-offset kallsyms command line option has > > been removed, so remove it from the usage string as well. > > > > Signed-off-by: Ard Biesheuvel >

Re: [PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

2016-12-11 Thread Michal Marek
On Wed, Nov 23, 2016 at 02:12:58PM +0530, Vaishali Thakkar wrote: > Few changes to improve the results given by the irqf_oneshot.cocci: > > - Change in the matching rules to eliminate false postives in the > patch mode > - Change in the context mode to eliminate false postives in the >

Re: [PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

2016-12-11 Thread Michal Marek
On Wed, Nov 23, 2016 at 02:12:58PM +0530, Vaishali Thakkar wrote: > Few changes to improve the results given by the irqf_oneshot.cocci: > > - Change in the matching rules to eliminate false postives in the > patch mode > - Change in the context mode to eliminate false postives in the >

Re: [PATCH] kbuild: cmd_export_list: tighten the sed script

2016-12-11 Thread Michal Marek
On Wed, Nov 16, 2016 at 07:28:39PM -0500, Nicolas Pitre wrote: > > When LTO is used, some ___ksymtab_string sections are seen by this sed > script, creating lines containing a single ) such as: > > EXPORT(foo) > ) > ) > EXPORT(bar) > > Let's make it so the + character is also required for any

Re: [PATCH] kbuild: cmd_export_list: tighten the sed script

2016-12-11 Thread Michal Marek
On Wed, Nov 16, 2016 at 07:28:39PM -0500, Nicolas Pitre wrote: > > When LTO is used, some ___ksymtab_string sections are seen by this sed > script, creating lines containing a single ) such as: > > EXPORT(foo) > ) > ) > EXPORT(bar) > > Let's make it so the + character is also required for any

Re: [PATCH] kbuild/mkspec: avoid using brace expansion

2016-12-11 Thread Michal Marek
On Tue, Oct 25, 2016 at 06:00:44PM +0900, Anton Tikhomirov wrote: > Brace expansion might not work properly if _buildshell RPM macro > points to a shell other than bash. Particularly, with _bulidshell > defined to /bin/dash it leads to broken build and source symlinks. > > Signed-off-by: Anton

Re: [PATCH] kbuild/mkspec: avoid using brace expansion

2016-12-11 Thread Michal Marek
On Tue, Oct 25, 2016 at 06:00:44PM +0900, Anton Tikhomirov wrote: > Brace expansion might not work properly if _buildshell RPM macro > points to a shell other than bash. Particularly, with _bulidshell > defined to /bin/dash it leads to broken build and source symlinks. > > Signed-off-by: Anton

Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

2016-12-10 Thread Michal Marek
On Mon, Oct 17, 2016 at 11:52:24AM -0500, Andrew F. Davis wrote: > Add a script to check for unneeded conversions to bool. > > Signed-off-by: Andrew F. Davis > Acked-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal

Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

2016-12-10 Thread Michal Marek
On Mon, Oct 17, 2016 at 11:52:24AM -0500, Andrew F. Davis wrote: > Add a script to check for unneeded conversions to bool. > > Signed-off-by: Andrew F. Davis > Acked-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal

Re: [PATCH v4] Fixes for compiling with clang

2016-12-02 Thread Michal Marek
On 2016-12-01 19:13, Peter Foley wrote: > On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek <mma...@suse.com> wrote: >> Dne 28.11.2016 v 07:44 Peter Foley napsal(a): >> This adds new -Wno-* options also for the gcc case, is there a reason >> for this? Also, the -Wno-missin

Re: [PATCH v4] Fixes for compiling with clang

2016-12-02 Thread Michal Marek
On 2016-12-01 19:13, Peter Foley wrote: > On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek wrote: >> Dne 28.11.2016 v 07:44 Peter Foley napsal(a): >> This adds new -Wno-* options also for the gcc case, is there a reason >> for this? Also, the -Wno-missing-fiel

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 14:58, Arnd Bergmann wrote: > On Tuesday, November 29, 2016 9:14:46 AM CET Linus Torvalds wrote: >> On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds >> wrote: >>> >>> So quite frankly, I don't want to make our kernel sources worse due to >>> broken shit

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 14:58, Arnd Bergmann wrote: > On Tuesday, November 29, 2016 9:14:46 AM CET Linus Torvalds wrote: >> On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds >> wrote: >>> >>> So quite frankly, I don't want to make our kernel sources worse due to >>> broken shit tools getting something wrong

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 05:13, Don Zickus wrote: > Sorry for chiming in late, but yes RHEL is a big user of MODVERSIONS for our > kabi protection work. Despite our best intentions we still have lots of > partners and customers that provide value-add out-of-tree drivers to their > customers. These module

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 05:13, Don Zickus wrote: > Sorry for chiming in late, but yes RHEL is a big user of MODVERSIONS for our > kabi protection work. Despite our best intentions we still have lots of > partners and customers that provide value-add out-of-tree drivers to their > customers. These module

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 04:39, Nicholas Piggin wrote: > On Thu, 01 Dec 2016 02:35:54 + > Ben Hutchings wrote: >> As I understand it, genksyms incorporates the definitions of a >> function's parameter and return types - not just their names - and all >> the types they refer to,

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 04:39, Nicholas Piggin wrote: > On Thu, 01 Dec 2016 02:35:54 + > Ben Hutchings wrote: >> As I understand it, genksyms incorporates the definitions of a >> function's parameter and return types - not just their names - and all >> the types they refer to, recursively. So a

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > -

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > -

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it >> >> The actual logic

Re: [PATCH v4] Fixes for compiling with clang

2016-11-29 Thread Michal Marek
Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > Fix reversed conditional checking if HOSTCC is clang. > Suppress warnings about unsupported optimization options. > Suppress warnings about unused functions, as they are generated for > every module and are therefore far too spammy. > Disable clang's

Re: [PATCH v4] Fixes for compiling with clang

2016-11-29 Thread Michal Marek
Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > Fix reversed conditional checking if HOSTCC is clang. > Suppress warnings about unsupported optimization options. > Suppress warnings about unused functions, as they are generated for > every module and are therefore far too spammy. > Disable clang's

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-29 Thread Michal Marek
On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote: > [Dropped Yann.] > > On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote: > > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote: > > > The Makefile does not specify -D_GNU_SOURCE. Ar

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-29 Thread Michal Marek
On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote: > [Dropped Yann.] > > On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote: > > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote: > > > The Makefile does not specify -D_GNU_SOURCE. Ar

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri,

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri, 2016-11-25 at 10:01 -0800,

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-28 Thread Michal Marek
Dne 27.11.2016 v 17:28 Cheah Kok Cheong napsal(a): > Fix below warning when make nconfig is run initially > or after make clean. > > HOSTCC scripts/kconfig/nconf.o > scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined > #define _GNU_SOURCE > ^ > :0:0: note: this is the location of

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-28 Thread Michal Marek
Dne 27.11.2016 v 17:28 Cheah Kok Cheong napsal(a): > Fix below warning when make nconfig is run initially > or after make clean. > > HOSTCC scripts/kconfig/nconf.o > scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined > #define _GNU_SOURCE > ^ > :0:0: note: this is the location of

Re: [PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-25 Thread Michal Marek
Dne 25.11.2016 v 13:12 Riku Voipio napsal(a): > On 22 November 2016 at 23:34, Michal Marek <mma...@suse.com> wrote: >> The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so >> the workaround is no longer needed. >> >> Signed-off-by: Michal Marek

Re: [PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-25 Thread Michal Marek
Dne 25.11.2016 v 13:12 Riku Voipio napsal(a): > On 22 November 2016 at 23:34, Michal Marek wrote: >> The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so >> the workaround is no longer needed. >> >> Signed-off-by: Michal Marek >> --- > Thanks

  1   2   3   4   5   6   7   8   9   10   >