Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Thu, Mar 16, 2017 at 02:33:25PM +0100, Michal Sojka wrote: >> On Thu, Mar 16 2017, Greg KH wrote: >> > On Thu, Mar 16, 2017 at 01:45:50PM +0100, Michal Sojka wrote: >> >> On Thu, Mar 16 2017, Greg KH wrote: >> >>

Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Thu, Mar 16, 2017 at 02:33:25PM +0100, Michal Sojka wrote: >> On Thu, Mar 16 2017, Greg KH wrote: >> > On Thu, Mar 16, 2017 at 01:45:50PM +0100, Michal Sojka wrote: >> >> On Thu, Mar 16 2017, Greg KH wrote: >> >>

[PATCH v2 1/3] uio: Allow handling of non page-aligned memory regions

d provided that they initialize struct uio_info (which contains uio_mem) with zeros. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio.c | 2 +- include/linux/uio_driver.h | 13 - 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/uio/uio.c b/d

[PATCH v2 1/3] uio: Allow handling of non page-aligned memory regions

d provided that they initialize struct uio_info (which contains uio_mem) with zeros. Signed-off-by: Michal Sojka --- drivers/uio/uio.c | 2 +- include/linux/uio_driver.h | 13 - 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index fb

[PATCH v2 2/3] uio_mf624: Refactor memory info initialization

No functional changes. Move initialization of struct uio_mem to a function. This will allow the next commit to change the initialization code at a single place rather that at three different places. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio_mf624.

[PATCH v2 3/3] uio_mf624: Align memory regions to page size and set correct offsets

ed offs field to the offset of the mf264 registers within the page so that userspace can find the address of the mmap()ed register by reading /sys/class/uio/uio?/maps/map?/offset. Tested with real mf624 card. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio_mf624.c |

[PATCH v2 2/3] uio_mf624: Refactor memory info initialization

No functional changes. Move initialization of struct uio_mem to a function. This will allow the next commit to change the initialization code at a single place rather that at three different places. Signed-off-by: Michal Sojka --- drivers/uio/uio_mf624.c | 44

[PATCH v2 3/3] uio_mf624: Align memory regions to page size and set correct offsets

ed offs field to the offset of the mf264 registers within the page so that userspace can find the address of the mmap()ed register by reading /sys/class/uio/uio?/maps/map?/offset. Tested with real mf624 card. Signed-off-by: Michal Sojka --- drivers/uio/uio_mf624.c | 8 ++-- 1 file changed,

Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Thu, Mar 16, 2017 at 01:45:50PM +0100, Michal Sojka wrote: >> On Thu, Mar 16 2017, Greg KH wrote: >> > On Tue, Mar 07, 2017 at 03:09:46PM +0100, Michal Sojka wrote: >> >> Since commit b65502879556 ("uio: we cannot

Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Thu, Mar 16, 2017 at 01:45:50PM +0100, Michal Sojka wrote: >> On Thu, Mar 16 2017, Greg KH wrote: >> > On Tue, Mar 07, 2017 at 03:09:46PM +0100, Michal Sojka wrote: >> >> Since commit b65502879556 ("uio: we cannot

Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Tue, Mar 07, 2017 at 03:09:46PM +0100, Michal Sojka wrote: >> Since commit b65502879556 ("uio: we cannot mmap unaligned page >> contents") addresses and sizes of UIO memory regions must be >> page-aligned. If the address

Re: [PATCH 1/3] uio: Allow handling of non page-aligned memory regions

On Thu, Mar 16 2017, Greg KH wrote: > On Tue, Mar 07, 2017 at 03:09:46PM +0100, Michal Sojka wrote: >> Since commit b65502879556 ("uio: we cannot mmap unaligned page >> contents") addresses and sizes of UIO memory regions must be >> page-aligned. If the address

[PATCH 3/3] uio_mf624: Align memory regions to page size

Without that, one cannot mmap() the registers to user-space, at least since commit b65502879556 ("uio: we cannot mmap unaligned page contents"). Tested with real mf624 card. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio_mf624.c | 8 ++-- 1 file chang

[PATCH 1/3] uio: Allow handling of non page-aligned memory regions

its value is reported via sysfs. Drivers for hardware with page-aligned BARs need not to be modified provided that they initialize struct uio_info with zeros. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio.c | 2 +- include/linux/uio_driver.h | 13 ++

[PATCH 3/3] uio_mf624: Align memory regions to page size

Without that, one cannot mmap() the registers to user-space, at least since commit b65502879556 ("uio: we cannot mmap unaligned page contents"). Tested with real mf624 card. Signed-off-by: Michal Sojka --- drivers/uio/uio_mf624.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH 1/3] uio: Allow handling of non page-aligned memory regions

its value is reported via sysfs. Drivers for hardware with page-aligned BARs need not to be modified provided that they initialize struct uio_info with zeros. Signed-off-by: Michal Sojka --- drivers/uio/uio.c | 2 +- include/linux/uio_driver.h | 13 - 2 files changed, 9

[PATCH 2/3] uio_mf624: Refactor memory info initialization

No functional changes. Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- drivers/uio/uio_mf624.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/uio/uio_mf624.c b/drivers/uio/uio_mf624.c index d1f95a

[PATCH 2/3] uio_mf624: Refactor memory info initialization

No functional changes. Signed-off-by: Michal Sojka --- drivers/uio/uio_mf624.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/uio/uio_mf624.c b/drivers/uio/uio_mf624.c index d1f95a1567bb..8f30fa1af2ab 100644

error: 'struct net_device' has no member named 'nf_hooks_ingress'

Hi, On Tue, Oct 04 2016, Sergey Senozhatsky wrote: > On (09/27/16 19:03), Sergey Senozhatsky wrote: >> Hello, >> >> On (09/27/16 16:40), Stephen Rothwell wrote: >> > >> > Changes since 20160923: >> > >> >> seems that commit e3b37f11e6e4e6b6 ("netfilter: replace list_head with >> single linked

error: 'struct net_device' has no member named 'nf_hooks_ingress'

Hi, On Tue, Oct 04 2016, Sergey Senozhatsky wrote: > On (09/27/16 19:03), Sergey Senozhatsky wrote: >> Hello, >> >> On (09/27/16 16:40), Stephen Rothwell wrote: >> > >> > Changes since 20160923: >> > >> >> seems that commit e3b37f11e6e4e6b6 ("netfilter: replace list_head with >> single linked

[PATCH] kconfig: Fix copy error

Signed-off-by: Michal Sojka --- scripts/kconfig/expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c index 667d1aa..cbf4996 100644 --- a/scripts/kconfig/expr.c +++ b/scripts/kconfig/expr.c @@ -1113,7 +1113,7 @@ void expr_print

[PATCH] kconfig: Fix copy error

Signed-off-by: Michal Sojka <sojk...@fel.cvut.cz> --- scripts/kconfig/expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c index 667d1aa..cbf4996 100644 --- a/scripts/kconfig/expr.c +++ b/scripts/kconfig/expr.c @@ -

Re: error: implicit declaration of function 'zero_bytemask'

On 7. října 2015 15:29:28 CEST, Chris Metcalf wrote: >On 10/07/2015 08:53 AM, Michal Sojka wrote: >> Dear Chris, >> >> the following commit breaks my Linux build. >> >> commit 990486c8af044f89bddfbde1d1cf9fde449bedbf >> Author: Chris Metcalf

error: implicit declaration of function 'zero_bytemask'

Dear Chris, the following commit breaks my Linux build. commit 990486c8af044f89bddfbde1d1cf9fde449bedbf Author: Chris Metcalf Date: Tue Oct 6 12:37:41 2015 -0400 strscpy: zero any trailing garbage bytes in the destination It's possible that the

error: implicit declaration of function 'zero_bytemask'

Dear Chris, the following commit breaks my Linux build. commit 990486c8af044f89bddfbde1d1cf9fde449bedbf Author: Chris Metcalf Date: Tue Oct 6 12:37:41 2015 -0400 strscpy: zero any trailing garbage bytes in the destination It's

Re: error: implicit declaration of function 'zero_bytemask'

On 7. října 2015 15:29:28 CEST, Chris Metcalf <cmetc...@ezchip.com> wrote: >On 10/07/2015 08:53 AM, Michal Sojka wrote: >> Dear Chris, >> >> the following commit breaks my Linux build. >> >> commit 990486c8af044f89bddfbde1d1cf9fde449bedbf >>

Re: [PATCH v3] powerpc32: memset: only use dcbz once cache is enabled

On Mon, Sep 14 2015, Christophe Leroy wrote: > memset() uses instruction dcbz to speed up clearing by not wasting time > loading cache line with data that will be overwritten. > Some platform like mpc52xx do no have cache active at startup and > can therefore not use memset(). Allthough no part of

Re: [PATCH v3] powerpc32: memset: only use dcbz once cache is enabled

On Mon, Sep 14 2015, Christophe Leroy wrote: > memset() uses instruction dcbz to speed up clearing by not wasting time > loading cache line with data that will be overwritten. > Some platform like mpc52xx do no have cache active at startup and > can therefore not use memset(). Allthough no part of

Re: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled

e is already enabled. > > Once the initial MMU is setup, in machine_init() we patch memcpy() > by replacing the temporary 'dcbt' by 'dcbz' > > Reported-by: Michal Sojka > Signed-off-by: Christophe Leroy > --- > @Michal, can you please test it ? Yes, it works. Tested-by: M

Re: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled

e is already enabled. > > Once the initial MMU is setup, in machine_init() we patch memcpy() > by replacing the temporary 'dcbt' by 'dcbz' > > Reported-by: Michal Sojka <sojk...@fel.cvut.cz> > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> > --- > @Michal,

[PATCH] Update help of CONFIG_MTD_OF_PARTS

to point to the right place. Signed-off-by: Michal Sojka --- drivers/mtd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 94b8210..fa8371a 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -133,7 +133,7 @@ config

[PATCH] Update help of CONFIG_MTD_OF_PARTS

to point to the right place. Signed-off-by: Michal Sojka sojk...@fel.cvut.cz --- drivers/mtd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 94b8210..fa8371a 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig

Linker error in function sys_bpf: undefined reference to `anon_inode_getfd'

Hi Alexei, the following commit causes a failure of my linux build. commit 99c55f7d47c0dc6fc64729f37bf435abf43f4c60 Author: Alexei Starovoitov Date: Fri Sep 26 00:16:57 2014 -0700 bpf: introduce BPF syscall and maps The error is:

Linker error in function sys_bpf: undefined reference to `anon_inode_getfd'

Hi Alexei, the following commit causes a failure of my linux build. commit 99c55f7d47c0dc6fc64729f37bf435abf43f4c60 Author: Alexei Starovoitov a...@plumgrid.com Date: Fri Sep 26 00:16:57 2014 -0700 bpf: introduce BPF syscall and maps The error is:

Re: [PATCH v6 2/4] usb: gadget: Refactor request completion

On Mon, Sep 29 2014, Robert Baldyga wrote: > Hi, > > On 09/24/2014 10:43 PM, Michal Sojka wrote: >> Use the recently introduced usb_gadget_giveback_request() in favor of >> direct invocation of the completion routine. >> >> All places in drivers/usb/ match

Re: [PATCH v6 2/4] usb: gadget: Refactor request completion

On Mon, Sep 29 2014, Robert Baldyga wrote: Hi, On 09/24/2014 10:43 PM, Michal Sojka wrote: Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching [-.]complete( were replaced with a call

[PATCH v6 3/4] usb: Rename usb-common.c

ently, usb-common.o comprises only common.o. Signed-off-by: Michal Sojka --- drivers/usb/common/Makefile | 4 +- drivers/usb/common/common.c | 144 drivers/usb/common/usb-common.c | 144 3 files changed, 147

[PATCH v6 4/4] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

[PATCH v6 2/4] usb: gadget: Refactor request completion

nd runtime-tested for musb. Signed-off-by: Michal Sojka --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3/gadget.c | 2 +- drivers/usb/gadget/udc/amd5536udc.c | 2 +- drivers/usb/gadget/udc/at91_udc.c

[PATCH v6 0/4] LED triggers for USB host and device

single file in usb/common/ (Felipe Balbi). - UDC drivers refactored so that LED trigger works for all of them. Changes from v1: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (4): usb: gadget: Int

[PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

All USB peripheral controller drivers call completion routines directly. This patch adds usb_gadget_giveback_request() which will be used instead of direct invocation in the next patch. The goal here is to have a place where common functionality can be added. Signed-off-by: Michal Sojka

[PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

All USB peripheral controller drivers call completion routines directly. This patch adds usb_gadget_giveback_request() which will be used instead of direct invocation in the next patch. The goal here is to have a place where common functionality can be added. Signed-off-by: Michal Sojka so

[PATCH v6 0/4] LED triggers for USB host and device

in usb/common/ (Felipe Balbi). - UDC drivers refactored so that LED trigger works for all of them. Changes from v1: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (4): usb: gadget: Introduce

[PATCH v6 4/4] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

[PATCH v6 2/4] usb: gadget: Refactor request completion

for musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3/gadget.c | 2 +- drivers/usb/gadget/udc/amd5536udc.c | 2 +- drivers/usb/gadget/udc/at91_udc.c

[PATCH v6 3/4] usb: Rename usb-common.c

-common.o comprises only common.o. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/common/Makefile | 4 +- drivers/usb/common/common.c | 144 drivers/usb/common/usb-common.c | 144 3 files changed, 147

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

Dear Felipe, On Wed, Sep 17 2014, Felipe Balbi wrote: > On Wed, Sep 17, 2014 at 09:21:11AM +0200, Michal Sojka wrote: >> All USB peripheral controller drivers called completion routines >> directly. This patch moves the completion call from drivers to >> usb_gadget_givebac

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

Dear Felipe, On Wed, Sep 17 2014, Felipe Balbi wrote: On Wed, Sep 17, 2014 at 09:21:11AM +0200, Michal Sojka wrote: All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have

[PATCH v5 3/3] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

[PATCH v5 1/3] usb: gadget: Refactor request completion

e replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc

[PATCH v5 2/3] usb: Rename usb-common.c

ently, usb-common.o comprises only common.o. Signed-off-by: Michal Sojka --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c => common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c => common.c} (1

[PATCH v5 0/3] LED triggers for USB host and device

rom v1: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (3): usb: gadget: Refactor request completion usb: Rename usb-common.c usb: Add LED triggers for USB activity drivers/usb/Kcon

[PATCH v5 2/3] usb: Rename usb-common.c

-common.o comprises only common.o. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c = common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c = common.c} (100%) diff

[PATCH v5 0/3] LED triggers for USB host and device

: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (3): usb: gadget: Refactor request completion usb: Rename usb-common.c usb: Add LED triggers for USB activity drivers/usb/Kconfig

[PATCH v5 3/3] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

[PATCH v5 1/3] usb: gadget: Refactor request completion

with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3

[PATCH v5 2/3] usb: Rename usb-common.c

ently, usb-common.o comprises only common.o. Signed-off-by: Michal Sojka --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c => common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c => common.c} (1

[PATCH v5 1/3] usb: gadget: Refactor request completion

e replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc

[PATCH v5 0/3] LED triggers for USB host and device

ved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (3): usb: gadget: Refactor request completion usb: Rename usb-common.c usb: Add LED triggers for USB activity drivers/usb/Kconfig | 10 + drivers/usb/chipidea/ud

[PATCH v5 3/3] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

Re: [PATCH v4 3/3] usb: Add LED triggers for USB activity

On Wed, Aug 27 2014, Greg Kroah-Hartman wrote: > On Wed, Aug 27, 2014 at 10:58:00PM +0200, Michal Sojka wrote: >> With this patch, USB activity can be signaled by blinking a LED. There >> are two triggers, one for activity on USB host and one for USB gadget. >> >&g

Re: [PATCH v4 3/3] usb: Add LED triggers for USB activity

On Wed, Aug 27 2014, Greg Kroah-Hartman wrote: On Wed, Aug 27, 2014 at 10:58:00PM +0200, Michal Sojka wrote: With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host

[PATCH v5 3/3] usb: Add LED triggers for USB activity

to the trigger): - __usb_hcd_giveback_urb():10 - 25 µs - usb_gadget_giveback_request(): 2 - 6 µs Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig | 10 +++ drivers/usb/common/Makefile | 1 + drivers/usb/common/led.c | 57

[PATCH v5 1/3] usb: gadget: Refactor request completion

with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3

[PATCH v5 0/3] LED triggers for USB host and device

Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (3): usb: gadget: Refactor request completion usb: Rename usb-common.c usb: Add LED triggers for USB activity drivers/usb/Kconfig | 10 + drivers/usb/chipidea/udc.c

[PATCH v5 2/3] usb: Rename usb-common.c

-common.o comprises only common.o. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c = common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c = common.c} (100%) diff

[PATCH v4 0/3] LED triggers for USB host and device

ile in usb/common/ (Felipe Balbi). - UDC drivers refactored so that LED trigger works for all of them. Changes from v1: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (2): usb: gadget: Refactor requ

[PATCH v4 3/3] usb: Add LED triggers for USB activity

With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka --- drivers/usb/Kconfig | 11

[PATCH v4 2/3] usb: Rename usb-common.c

ently, usb-common.o comprises only common.o. Signed-off-by: Michal Sojka --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c => common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c => common.c} (1

[PATCH v4 1/3] usb: gadget: Refactor request completion

e replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

On Wed, Aug 27 2014, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. &g

[PATCH v3 0/2] LED triggers for USB host and device

Changes from v1: - Moved from drivers/leds/ to drivers/usb/ - Improved Kconfig help - Linked with other modules rather than being standalone modules Michal Sojka (2): usb: gadget: Refactor request completion usb: Add LED triggers for USB activity drivers/usb/Kconfig | 11

[PATCH v3 2/2] usb: Add LED triggers for USB activity

With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka --- drivers/usb/Kconfig

[PATCH v3 1/2] usb: gadget: Refactor request completion

e replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc

[PATCH v3 2/2] usb: Add LED triggers for USB activity

With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig

[PATCH v3 1/2] usb: gadget: Refactor request completion

with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3

[PATCH v3 0/2] LED triggers for USB host and device

Changes from v1: - Moved from drivers/leds/ to drivers/usb/ - Improved Kconfig help - Linked with other modules rather than being standalone modules Michal Sojka (2): usb: gadget: Refactor request completion usb: Add LED triggers for USB activity drivers/usb/Kconfig | 11

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

On Wed, Aug 27 2014, Michal Sojka wrote: All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb

[PATCH v4 1/3] usb: gadget: Refactor request completion

with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/chipidea/udc.c | 6 +++--- drivers/usb/dwc2/gadget.c | 6 +++--- drivers/usb/dwc3

[PATCH v4 2/3] usb: Rename usb-common.c

-common.o comprises only common.o. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/common/Makefile | 4 +++- drivers/usb/common/{usb-common.c = common.c} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename drivers/usb/common/{usb-common.c = common.c} (100%) diff

[PATCH v4 3/3] usb: Add LED triggers for USB activity

With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig

[PATCH v4 0/3] LED triggers for USB host and device

in usb/common/ (Felipe Balbi). - UDC drivers refactored so that LED trigger works for all of them. Changes from v1: - Moved from drivers/leds/ to drivers/usb/. - Improved Kconfig help. - Linked with other modules rather than being standalone modules. Michal Sojka (2): usb: gadget: Refactor request

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

Hi Bryan, thanks for the review. See some comments below. On Sat, Aug 23 2014, Bryan Wu wrote: > On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: >> With this patch, USB host activity can be signaled by blinking a LED. >> >> This should work with all host controllers.

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

Hi Bryan, thanks for the review. See some comments below. On Sat, Aug 23 2014, Bryan Wu wrote: On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka so...@merica.cz wrote: With this patch, USB host activity can be signaled by blinking a LED. This should work with all host controllers. Tested only

[PATCH v2 1/3] usb: Add missing #include

linux/usb/hcd.h needs the definition of struct usb_bus. Signed-off-by: Michal Sojka --- include/linux/usb/hcd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index 485cd5e..b43f0fe 100644 --- a/include/linux/usb/hcd.h +++ b/include/linux

[PATCH v2 0/3] LED triggers for USB host and device

This adds LED triggers for USB host and device. Changes from v1: - Moved from drivers/leds/ to drivers/usb/ - Improved Kconfig help - Linked with other modules rather than being standalone modules Michal Sojka (3): usb: Add missing #include usb: Add LED trigger for USB host activity usb

[PATCH v2 2/3] usb: Add LED trigger for USB host activity

With this patch, USB host activity can be signaled by blinking a LED. This should work with all host controllers. Tested only with musb. Signed-off-by: Michal Sojka --- drivers/usb/core/Kconfig | 9 + drivers/usb/core/Makefile | 1 + drivers/usb/core/hcd.c| 2 ++ drivers/usb

[PATCH v2 3/3] usb: Add LED trigger for USB gadget activity

-off-by: Michal Sojka --- drivers/usb/gadget/Kconfig | 12 drivers/usb/gadget/udc/Makefile | 5 - drivers/usb/gadget/udc/led.c| 38 ++ drivers/usb/musb/musb_gadget.c | 5 +++-- include/linux/usb/gadget.h | 10 ++ 5 files

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

On Fri, Aug 22 2014, Greg Kroah-Hartman wrote: > On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote: >> On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka wrote: >> > With this patch, USB gadget activity can be signaled by blinking a LED. >> > >> > Since t

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

Hi Felipe, On Fri, Aug 22 2014, Felipe Balbi wrote: > Hi, > > On Fri, Aug 22, 2014 at 01:53:12PM +0200, Michal Sojka wrote: >> With this patch, USB gadget activity can be signaled by blinking a LED. >> >> Since there is no generic code where to put the trigger for a

[PATCH 2/2] leds: usb: Add LED trigger for USB host activity

With this patch, USB host activity can be signaled by blinking a LED. This should work with all host controllers. Tested only with musb. Signed-off-by: Michal Sojka --- drivers/leds/trigger/Kconfig | 8 ++ drivers/leds/trigger/Makefile | 1 + drivers/leds/trigger

[PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

-off-by: Michal Sojka --- drivers/leds/trigger/Kconfig | 8 ++ drivers/leds/trigger/Makefile| 1 + drivers/leds/trigger/ledtrig-usbgadget.c | 45 drivers/usb/musb/musb_gadget.c | 6 +++-- include/linux/leds.h

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

Hi Felipe, On Fri, Aug 22 2014, Felipe Balbi wrote: Hi, On Fri, Aug 22, 2014 at 01:53:12PM +0200, Michal Sojka wrote: With this patch, USB gadget activity can be signaled by blinking a LED. Since there is no generic code where to put the trigger for all USB controllers, each USB

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

On Fri, Aug 22 2014, Greg Kroah-Hartman wrote: On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote: On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka so...@merica.cz wrote: With this patch, USB gadget activity can be signaled by blinking a LED. Since there is no generic code where to put

[PATCH v2 3/3] usb: Add LED trigger for USB gadget activity

-off-by: Michal Sojka so...@merica.cz --- drivers/usb/gadget/Kconfig | 12 drivers/usb/gadget/udc/Makefile | 5 - drivers/usb/gadget/udc/led.c| 38 ++ drivers/usb/musb/musb_gadget.c | 5 +++-- include/linux/usb/gadget.h | 10

[PATCH v2 2/3] usb: Add LED trigger for USB host activity

With this patch, USB host activity can be signaled by blinking a LED. This should work with all host controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/core/Kconfig | 9 + drivers/usb/core/Makefile | 1 + drivers/usb/core/hcd.c| 2

[PATCH v2 0/3] LED triggers for USB host and device

This adds LED triggers for USB host and device. Changes from v1: - Moved from drivers/leds/ to drivers/usb/ - Improved Kconfig help - Linked with other modules rather than being standalone modules Michal Sojka (3): usb: Add missing #include usb: Add LED trigger for USB host activity usb

[PATCH v2 1/3] usb: Add missing #include

linux/usb/hcd.h needs the definition of struct usb_bus. Signed-off-by: Michal Sojka so...@merica.cz --- include/linux/usb/hcd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index 485cd5e..b43f0fe 100644 --- a/include/linux/usb/hcd.h +++ b

[PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

-off-by: Michal Sojka so...@merica.cz --- drivers/leds/trigger/Kconfig | 8 ++ drivers/leds/trigger/Makefile| 1 + drivers/leds/trigger/ledtrig-usbgadget.c | 45 drivers/usb/musb/musb_gadget.c | 6 +++-- include/linux/leds.h

[PATCH 2/2] leds: usb: Add LED trigger for USB host activity

With this patch, USB host activity can be signaled by blinking a LED. This should work with all host controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/leds/trigger/Kconfig | 8 ++ drivers/leds/trigger/Makefile | 1 + drivers

  1   2   >