Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-09-10 Thread Mike Qiu
ag to show it is in such stat, this maybe also happens when driver is in remove stat. Thanks, Mike -- james s On 7/31/2014 10:16 PM, Mike Qiu wrote: On 07/17/2014 02:32 PM, Mike Qiu wrote: Hi, all How about this patch ? Any idea ? In IBM Power servers, when hardware error occurs during probe

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-09-10 Thread Mike Qiu
it is in such stat, this maybe also happens when driver is in remove stat. Thanks, Mike -- james s On 7/31/2014 10:16 PM, Mike Qiu wrote: On 07/17/2014 02:32 PM, Mike Qiu wrote: Hi, all How about this patch ? Any idea ? In IBM Power servers, when hardware error occurs during probe state, EEH

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-31 Thread Mike Qiu
On 07/17/2014 02:32 PM, Mike Qiu wrote: Hi, all How about this patch ? Any idea ? In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which will call pci_disable_device(). But driver's probe function also call

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-31 Thread Mike Qiu
On 07/17/2014 02:32 PM, Mike Qiu wrote: Hi, all How about this patch ? Any idea ? In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which will call pci_disable_device(). But driver's probe function also call

Re: WARNING: at kernel/cpuset.c:1139

2014-07-23 Thread Mike Qiu
On 07/24/2014 08:27 AM, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config changes") introduce the below warning in my server.

Re: WARNING: at kernel/cpuset.c:1139

2014-07-23 Thread Mike Qiu
On 07/24/2014 08:27 AM, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut

WARNING: at kernel/cpuset.c:1139

2014-07-22 Thread Mike Qiu
commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config changes") introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 [ 35.652142] Modules linked in: ebtable_nat xt_CHECKSUM bridge stp

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
On 07/22/2014 10:51 PM, Mike Qiu wrote: In ata_sas_port_alloc(), it haven't initialized scsi_host field in ata_port, although scsi_host is in parameters list and unused in this function. With commit 1871ee134b73 ("libata: support the ata host which implements a queue depth less th

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
I have tested with the ipr IOA, passed. Reviewed-and Tested-by: Mike Qiu On 07/23/2014 04:11 AM, Tejun Heo wrote: Hello, Can you please test the following patch? diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index d19c37a7..773f4e6 100644 --- a/drivers/ata/libata-core.c

Re: [PATCH 1/2] libata: Fix scsi_host can_queue issue in ata_qc_new()

2014-07-22 Thread Mike Qiu
On 07/22/2014 11:42 PM, Tejun Heo wrote: Hello, (cc'ing Dan) On Tue, Jul 22, 2014 at 10:50:19AM -0400, Mike Qiu wrote: The can_queue in scsi_host can be more than ATA_MAX_QUEUE (32), for example, in ipr, it can be 100 or more. Also, some drivers, like ipr driver, haven't filled the field

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
[+cc Wendy, Brian King, Stephen] On 07/22/2014 10:51 PM, Mike Qiu wrote: In ata_sas_port_alloc(), it haven't initialized scsi_host field in ata_port, although scsi_host is in parameters list and unused in this function. With commit 1871ee134b73 ("libata: support the ata host which imple

[PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
read+0x184/0x600 .kthread+0x10c/0x130 .ret_from_kernel_thread+0x58/0x7c While scsi_host is unused in ata_sas_port_alloc(), better to set it in ata_sas_port_alloc() instead of in driver. Signed-off-by: Mike Qiu --- drivers/ata/libata-scsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH 1/2] libata: Fix scsi_host can_queue issue in ata_qc_new()

2014-07-22 Thread Mike Qiu
The can_queue in scsi_host can be more than ATA_MAX_QUEUE (32), for example, in ipr, it can be 100 or more. Also, some drivers, like ipr driver, haven't filled the field scsi_host in ata_port, and will lead a call trace, so add check for that. Signed-off-by: Mike Qiu --- drivers/ata/libata

[PATCH 1/2] libata: Fix scsi_host can_queue issue in ata_qc_new()

2014-07-22 Thread Mike Qiu
The can_queue in scsi_host can be more than ATA_MAX_QUEUE (32), for example, in ipr, it can be 100 or more. Also, some drivers, like ipr driver, haven't filled the field scsi_host in ata_port, and will lead a call trace, so add check for that. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com

[PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
/0x600 .kthread+0x10c/0x130 .ret_from_kernel_thread+0x58/0x7c While scsi_host is unused in ata_sas_port_alloc(), better to set it in ata_sas_port_alloc() instead of in driver. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- drivers/ata/libata-scsi.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
[+cc Wendy, Brian King, Stephen] On 07/22/2014 10:51 PM, Mike Qiu wrote: In ata_sas_port_alloc(), it haven't initialized scsi_host field in ata_port, although scsi_host is in parameters list and unused in this function. With commit 1871ee134b73 (libata: support the ata host which implements

Re: [PATCH 1/2] libata: Fix scsi_host can_queue issue in ata_qc_new()

2014-07-22 Thread Mike Qiu
On 07/22/2014 11:42 PM, Tejun Heo wrote: Hello, (cc'ing Dan) On Tue, Jul 22, 2014 at 10:50:19AM -0400, Mike Qiu wrote: The can_queue in scsi_host can be more than ATA_MAX_QUEUE (32), for example, in ipr, it can be 100 or more. Also, some drivers, like ipr driver, haven't filled the field

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
I have tested with the ipr IOA, passed. Reviewed-and Tested-by: Mike Qiu qiud...@linux.vnet.ibm.com On 07/23/2014 04:11 AM, Tejun Heo wrote: Hello, Can you please test the following patch? diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index d19c37a7..773f4e6 100644

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

2014-07-22 Thread Mike Qiu
On 07/22/2014 10:51 PM, Mike Qiu wrote: In ata_sas_port_alloc(), it haven't initialized scsi_host field in ata_port, although scsi_host is in parameters list and unused in this function. With commit 1871ee134b73 (libata: support the ata host which implements a queue depth less than 32

WARNING: at kernel/cpuset.c:1139

2014-07-22 Thread Mike Qiu
commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 [ 35.652142] Modules linked in: ebtable_nat xt_CHECKSUM bridge stp

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Mike Qiu
On 07/17/2014 10:15 PM, Joe Lawrence wrote: [ +cc linux-pci and Bjorn, comments inline/below ... ] On Thu, 17 Jul 2014 02:32:31 -0400 Mike Qiu wrote: In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which

[PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Mike Qiu
.ret_from_kernel_thread+0x5c/0x80 Signed-off-by: Mike Qiu --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 59 +++ 2 files changed, 55 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h index 434e903..0c7bad9

[PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Mike Qiu
.ret_from_kernel_thread+0x5c/0x80 Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 59 +++ 2 files changed, 55 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Mike Qiu
On 07/17/2014 10:15 PM, Joe Lawrence wrote: [ +cc linux-pci and Bjorn, comments inline/below ... ] On Thu, 17 Jul 2014 02:32:31 -0400 Mike Qiu qiud...@linux.vnet.ibm.com wrote: In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected

Re: Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-07-15 Thread Mike Qiu
On 07/15/2014 04:41 PM, Jens Axboe wrote: On 15/07/2014, at 10.14, Mike Qiu wrote: My Power7 box boot fail with commit: 254c4407cb84a6dec90336054615b0f0e996bb7c bio: modify __bio_add_page() to accept pages that don't start a new segment Just revert it will works for me. I have reverted

Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-07-15 Thread Mike Qiu
My Power7 box boot fail with commit: 254c4407cb84a6dec90336054615b0f0e996bb7c bio: modify __bio_add_page() to accept pages that don't start a new segment Just revert it will works for me. See below: [ 22.659431] [ cut here ] [ 22.659437] kernel BUG at

Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-07-15 Thread Mike Qiu
My Power7 box boot fail with commit: 254c4407cb84a6dec90336054615b0f0e996bb7c bio: modify __bio_add_page() to accept pages that don't start a new segment Just revert it will works for me. See below: [ 22.659431] [ cut here ] [ 22.659437] kernel BUG at

Re: Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-07-15 Thread Mike Qiu
On 07/15/2014 04:41 PM, Jens Axboe wrote: On 15/07/2014, at 10.14, Mike Qiu qiud...@linux.vnet.ibm.com wrote: My Power7 box boot fail with commit: 254c4407cb84a6dec90336054615b0f0e996bb7c bio: modify __bio_add_page() to accept pages that don't start a new segment Just revert it will works

Re: [PATCH v2] powerpc: Avoid circular dependency with zImage.%

2014-06-11 Thread Mike Qiu
This v2 patch is good, Tested-by: Mike Qiu On 06/11/2014 11:40 PM, Michal Marek wrote: The rule to create the final images uses a zImage.% pattern. Unfortunately, this also matches the names of the zImage.*.lds linker scripts, which appear as a dependency of the final images. This somehow

Re: [PATCH v2] powerpc: Avoid circular dependency with zImage.%

2014-06-11 Thread Mike Qiu
This v2 patch is good, Tested-by: Mike Qiu qiud...@linux.vnet.ibm.com On 06/11/2014 11:40 PM, Michal Marek wrote: The rule to create the final images uses a zImage.% pattern. Unfortunately, this also matches the names of the zImage.*.lds linker scripts, which appear as a dependency

Re: [RFC 08/10] irqdomain: Refactor irq_domain_associate_many()

2013-06-17 Thread Mike Qiu
于 2013/6/10 8:49, Grant Likely 写道: Originally, irq_domain_associate_many() was designed to unwind the mapped irqs on a failure of any individual association. However, that proved to be a problem with certain IRQ controllers. Some of them only support a subset of irqs, and will fail when

Re: [RFC 08/10] irqdomain: Refactor irq_domain_associate_many()

2013-06-17 Thread Mike Qiu
于 2013/6/10 8:49, Grant Likely 写道: Originally, irq_domain_associate_many() was designed to unwind the mapped irqs on a failure of any individual association. However, that proved to be a problem with certain IRQ controllers. Some of them only support a subset of irqs, and will fail when

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-05-22 Thread Mike Qiu
于 2013/5/22 8:15, Benjamin Herrenschmidt 写道: On Tue, 2013-05-21 at 16:45 +0200, Alexander Gordeev wrote: On Tue, Jan 15, 2013 at 03:38:53PM +0800, Mike Qiu wrote: The test results is shown by 'cat /proc/interrups': CPU0 CPU1 CPU2 CPU3 16: 240458 261601

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-05-22 Thread Mike Qiu
于 2013/5/22 8:15, Benjamin Herrenschmidt 写道: On Tue, 2013-05-21 at 16:45 +0200, Alexander Gordeev wrote: On Tue, Jan 15, 2013 at 03:38:53PM +0800, Mike Qiu wrote: The test results is shown by 'cat /proc/interrups': CPU0 CPU1 CPU2 CPU3 16: 240458 261601

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-27 Thread Mike Qiu
于 2013/4/27 17:28, Chen Gang F T 写道: On 2013年04月26日 11:54, Mike Qiu wrote: 于 2013/4/26 11:42, Chen Gang 写道: On 2013年04月26日 11:25, Chen Gang wrote: On 2013年04月26日 11:08, Mike Qiu wrote: 于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-27 Thread Mike Qiu
于 2013/4/27 17:28, Chen Gang F T 写道: On 2013年04月26日 11:54, Mike Qiu wrote: 于 2013/4/26 11:42, Chen Gang 写道: On 2013年04月26日 11:25, Chen Gang wrote: On 2013年04月26日 11:08, Mike Qiu wrote: 于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 11:42, Chen Gang 写道: On 2013年04月26日 11:25, Chen Gang wrote: On 2013年04月26日 11:08, Mike Qiu wrote: 于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д��: On 2013��04��26�� 09:18, Chen Gang wrote: On 2013��04��26�� 09:06, Chen

Re: "attempt to move .org backwards" still show up

2013-04-25 Thread Mike Qiu
于 2013/4/25 14:25, Paul Mackerras 写道: On Thu, Apr 25, 2013 at 12:05:54PM +0800, Mike Qiu wrote: This has block my work now So I hope you can take a look ASAP Thanks :) Mike As a quick fix, turn on CONFIG_KVM_BOOK3S_64_HV. That will eliminate the immediate problem. Thanks got it, I will have

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д��: On 2013��04��26�� 09:18, Chen Gang wrote: On 2013��04��26�� 09:06, Chen Gang wrote: CFAR is the Come From Register. It saves the location of the last branch and is hence overwritten

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 9:36, Chen Gang 写道: > On 2013年04月26日 09:18, Chen Gang wrote: >> On 2013年04月26日 09:06, Chen Gang wrote: CFAR is the Come From Register. It saves the location of the last > branch and is hence overwritten by any branch. > >>> Do we process it just like others done (e.g.

Re: "attempt to move .org backwards" still show up

2013-04-25 Thread Mike Qiu
于 2013/4/25 19:16, Chen Gang 写道: On 2013年04月25日 14:25, Paul Mackerras wrote: On Thu, Apr 25, 2013 at 12:05:54PM +0800, Mike Qiu wrote: This has block my work now So I hope you can take a look ASAP Thanks :) Mike As a quick fix, turn on CONFIG_KVM_BOOK3S_64_HV. That will eliminate

Re: [PATCH] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/25 16:21, Chen Gang 写道: Hello Mike: Please try this patch, at least it can pass compiling with the config file which you provided under my cross-compiling envrionments. I do not give a running test now, so better to try to run the new kernel with this patch. OK, I will use your

Re: [PATCH] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/25 16:21, Chen Gang 写道: Hello Mike: Please try this patch, at least it can pass compiling with the config file which you provided under my cross-compiling envrionments. I do not give a running test now, so better to try to run the new kernel with this patch. OK, I will use your

Re: attempt to move .org backwards still show up

2013-04-25 Thread Mike Qiu
于 2013/4/25 19:16, Chen Gang 写道: On 2013年04月25日 14:25, Paul Mackerras wrote: On Thu, Apr 25, 2013 at 12:05:54PM +0800, Mike Qiu wrote: This has block my work now So I hope you can take a look ASAP Thanks :) Mike As a quick fix, turn on CONFIG_KVM_BOOK3S_64_HV. That will eliminate

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 9:36, Chen Gang 写道: On 2013年04月26日 09:18, Chen Gang wrote: On 2013年04月26日 09:06, Chen Gang wrote: CFAR is the Come From Register. It saves the location of the last branch and is hence overwritten by any branch. Do we process it just like others done (e.g. 0x300, 0xe00, 0xe20

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д��: On 2013��04��26�� 09:18, Chen Gang wrote: On 2013��04��26�� 09:06, Chen Gang wrote: CFAR is the Come From Register. It saves the location of the last branch and is hence overwritten

Re: attempt to move .org backwards still show up

2013-04-25 Thread Mike Qiu
于 2013/4/25 14:25, Paul Mackerras 写道: On Thu, Apr 25, 2013 at 12:05:54PM +0800, Mike Qiu wrote: This has block my work now So I hope you can take a look ASAP Thanks :) Mike As a quick fix, turn on CONFIG_KVM_BOOK3S_64_HV. That will eliminate the immediate problem. Thanks got it, I will have

Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area

2013-04-25 Thread Mike Qiu
于 2013/4/26 11:42, Chen Gang 写道: On 2013年04月26日 11:25, Chen Gang wrote: On 2013年04月26日 11:08, Mike Qiu wrote: 于 2013/4/26 10:06, Chen Gang 写道: On 2013年04月26日 10:03, Mike Qiu wrote: �� 2013/4/26 9:36, Chen Gang д��: On 2013��04��26�� 09:18, Chen Gang wrote: On 2013��04��26�� 09:06, Chen

Re: "attempt to move .org backwards" still show up

2013-04-24 Thread Mike Qiu
于 2013/4/25 9:05, Chen Gang 写道: On 2013年04月24日 20:47, Mike wrote: 在 2013-04-24三的 20:37 +1000,Michael Neuling写道: Mike Qiu wrote: 于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I compile the source code

Re: "attempt to move .org backwards" still show up

2013-04-24 Thread Mike Qiu
于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. Hi Mike, It depends on what your .config is. What defconfig are you building

Re: "attempt to move .org backwards" still show up

2013-04-24 Thread Mike Qiu
于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. Hi Mike, It depends on what your .config is. What defconfig are you building? I

"attempt to move .org backwards" still show up

2013-04-24 Thread Mike Qiu
Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. [root@feng linux]# make -j60 CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h

attempt to move .org backwards still show up

2013-04-24 Thread Mike Qiu
Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. [root@feng linux]# make -j60 CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h

Re: attempt to move .org backwards still show up

2013-04-24 Thread Mike Qiu
于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. Hi Mike, It depends on what your .config is. What defconfig are you building? I

Re: attempt to move .org backwards still show up

2013-04-24 Thread Mike Qiu
于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I compile the source code in Power7 platform use the newest upstream kernel. Hi Mike, It depends on what your .config is. What defconfig are you building

Re: attempt to move .org backwards still show up

2013-04-24 Thread Mike Qiu
于 2013/4/25 9:05, Chen Gang 写道: On 2013年04月24日 20:47, Mike wrote: 在 2013-04-24三的 20:37 +1000,Michael Neuling写道: Mike Qiu qiud...@linux.vnet.ibm.com wrote: 于 2013/4/24 16:31, Michael Ellerman 写道: On Wed, Apr 24, 2013 at 04:22:53PM +0800, Mike Qiu wrote: Hi all I get an error message when I

[PATCH] PowerNV/PCI: Fix NULL PCI controller

2013-04-17 Thread Mike Qiu
In pnv_pci_read_config() or pnv_pci_write_config(), we never check if the PCI controller is valid before converting that into platform dependent one, this is very dangerous. To avoid this potential risks, the patch check PCI controller first before use it. Signed-off-by: Mike Qiu --- arch

[PATCH] PowerNV/PCI: Fix NULL PCI controller

2013-04-17 Thread Mike Qiu
In pnv_pci_read_config() or pnv_pci_write_config(), we never check if the PCI controller is valid before converting that into platform dependent one, this is very dangerous. To avoid this potential risks, the patch check PCI controller first before use it. Signed-off-by: Mike Qiu qiud

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-05 Thread Mike Qiu
于 2013/3/6 13:42, Michael Ellerman 写道: On Wed, Mar 06, 2013 at 01:34:58PM +0800, Mike Qiu wrote: 于 2013/3/6 11:54, Michael Ellerman 写道: On Tue, Mar 05, 2013 at 03:19:57PM +0800, Mike Qiu wrote: 于 2013/3/5 10:23, Michael Ellerman 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-05 Thread Mike Qiu
于 2013/3/6 13:42, Michael Ellerman 写道: On Wed, Mar 06, 2013 at 01:34:58PM +0800, Mike Qiu wrote: 于 2013/3/6 11:54, Michael Ellerman 写道: On Tue, Mar 05, 2013 at 03:19:57PM +0800, Mike Qiu wrote: 于 2013/3/5 10:23, Michael Ellerman 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-04 Thread Mike Qiu
于 2013/3/5 10:41, Paul Mundt 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote: Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. +int irq_create_mapping_many(struct

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-04 Thread Mike Qiu
于 2013/3/5 10:23, Michael Ellerman 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote: Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. Signed-off-by: Mike Qiu

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-04 Thread Mike Qiu
于 2013/3/5 10:23, Michael Ellerman 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote: Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. Signed-off-by: Mike Qiu qiud

Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-03-04 Thread Mike Qiu
于 2013/3/5 10:41, Paul Mundt 写道: On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote: Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. +int irq_create_mapping_many(struct

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-03-03 Thread Mike Qiu
于 2013/3/1 11:54, Michael Ellerman 写道: On Fri, Mar 01, 2013 at 11:08:45AM +0800, Mike wrote: Hi all Any comments? or any questions about my patchset? You were going to get some performance numbers that show a definite benefit for using more than one MSI. Yes, but my patch just enable the

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-03-03 Thread Mike Qiu
于 2013/3/1 11:54, Michael Ellerman 写道: On Fri, Mar 01, 2013 at 11:08:45AM +0800, Mike wrote: Hi all Any comments? or any questions about my patchset? You were going to get some performance numbers that show a definite benefit for using more than one MSI. Yes, but my patch just enable the

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-02-03 Thread Mike Qiu
2013/2/4 13:56, Michael Ellerman: On Mon, 2013-02-04 at 11:49 +0800, Mike Qiu wrote: On Tue, 2013-01-15 at 15:38 +0800, Mike Qiu wrote: Currently, multiple MSI feature hasn't been enabled in pSeries, These patches try to enbale this feature. Hi Mike, These patches have been tested by using

Re: [PATCH 0/3] Enable multiple MSI feature in pSeries

2013-02-03 Thread Mike Qiu
2013/2/4 13:56, Michael Ellerman: On Mon, 2013-02-04 at 11:49 +0800, Mike Qiu wrote: On Tue, 2013-01-15 at 15:38 +0800, Mike Qiu wrote: Currently, multiple MSI feature hasn't been enabled in pSeries, These patches try to enbale this feature. Hi Mike, These patches have been tested by using

[PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-01-14 Thread Mike Qiu
Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. Signed-off-by: Mike Qiu --- include/linux/irq.h |2 + include/linux/irqdomain.h |3 ++ kernel/irq/irqdomain.c

[PATCH 0/3] Enable multiple MSI feature in pSeries

2013-01-14 Thread Mike Qiu
check exceptions Mike Qiu (3): irq: Set multiple MSI descriptor data for multiple IRQs irq: Add hw continuous IRQs map to virtual continuous IRQs support powerpc/pci: Enable pSeries multiple MSI feature arch/powerpc/kernel/msi.c|4 -- arch/powerpc/platforms/pseries/msi.c | 62

[PATCH 1/3] irq: Set multiple MSI descriptor data for multiple IRQs

2013-01-14 Thread Mike Qiu
Multiple MSI only requires the IRQ in msi_desc entry to be set as the value of irq_base. This patch implements the above mentioned technique. Signed-off-by: Mike Qiu --- include/linux/irq.h |2 ++ kernel/irq/chip.c | 40 ++-- 2 files changed, 32

[PATCH 3/3] powerpc/pci: Enable pSeries multiple MSI feature

2013-01-14 Thread Mike Qiu
PCI devices support MSI, MSIX as well as multiple MSI. But pSeries does not support multiple MSI yet. This patch enable multiple MSI feature in pSeries. Signed-off-by: Mike Qiu --- arch/powerpc/kernel/msi.c|4 -- arch/powerpc/platforms/pseries/msi.c | 62

[PATCH 1/3] irq: Set multiple MSI descriptor data for multiple IRQs

2013-01-14 Thread Mike Qiu
Multiple MSI only requires the IRQ in msi_desc entry to be set as the value of irq_base. This patch implements the above mentioned technique. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- include/linux/irq.h |2 ++ kernel/irq/chip.c | 40

[PATCH 3/3] powerpc/pci: Enable pSeries multiple MSI feature

2013-01-14 Thread Mike Qiu
PCI devices support MSI, MSIX as well as multiple MSI. But pSeries does not support multiple MSI yet. This patch enable multiple MSI feature in pSeries. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- arch/powerpc/kernel/msi.c|4 -- arch/powerpc/platforms/pseries/msi.c

[PATCH 0/3] Enable multiple MSI feature in pSeries

2013-01-14 Thread Mike Qiu
0 0 Machine check exceptions Mike Qiu (3): irq: Set multiple MSI descriptor data for multiple IRQs irq: Add hw continuous IRQs map to virtual continuous IRQs support powerpc/pci: Enable pSeries multiple MSI feature arch/powerpc/kernel/msi.c|4 -- arch/powerpc

[PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support

2013-01-14 Thread Mike Qiu
Adding a function irq_create_mapping_many() which can associate multiple MSIs to a continous irq mapping. This is needed to enable multiple MSI support for pSeries. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- include/linux/irq.h |2 + include/linux/irqdomain.h |3

[PATCH] No need to call irq_domain_legacy_revmap() for twice

2012-09-24 Thread Mike Qiu
irq_domain_legacy_revmap() to do same check in irq_create_mapping() again. The patch removes the duplicate call. Signed-off-by: Mike Qiu --- kernel/irq/irqdomain.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 49a7772..286d672

[PATCH] No need to call irq_domain_legacy_revmap() for twice

2012-09-24 Thread Mike Qiu
irq_domain_legacy_revmap() to do same check in irq_create_mapping() again. The patch removes the duplicate call. Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com --- kernel/irq/irqdomain.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c