these particular nodes aren't supported on RPM and are purely
local, we should just change their mas_rpm_id to -1 to avoid any
requests being sent for these master IDs.
Signed-off-by: Georgi Djakov
Reviewed-by: Mike Tipton
---
v2:
* Keep the nodes and just set the IDs to -1, as suggested by Mike
this by replacing the IDs,
with the default "-1" in which case no requests are sent.
Signed-off-by: Georgi Djakov
Reviewed-by: Mike Tipton
On 11/11/2020 2:07 AM, Georgi Djakov wrote:
The following errors are noticed during boot on a QCS404 board:
[2.926647] qcom_icc_rpm_smd_send mas 6 error -6
[2.934573] qcom_icc_rpm_smd_send mas 8 error -6
These errors show when we try to configure the GPU and display nodes,
which are
;
+ const struct qcom_icc_bcm *bcm_b = list_entry(b, struct qcom_icc_bcm,
list);
+
+ return bcm_a->aux_data.vcd - bcm_b->aux_data.vcd;
}
static u64 bcm_div(u64 num, u32 base)
Reviewed-by: Mike Tipton
nodes into their respective
NoCs")
Reported-by: Amit Pundir
Signed-off-by: Georgi Djakov
---
drivers/interconnect/qcom/sdm845.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Mike Tipton
Currently, bcm-voter always assumes requests are made in KBps and that
BCM HW always wants them in Bps, so it always scales the requests by
1000. However, certain use cases and BCMs may use different units.
Thus, add support for BCM-specific scaling factors.
Signed-off-by: Mike Tipton
Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.
Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh
support")
Signed-off-by: Mike Tipton
--
Add generic qcom interconnect bindings that are common across platforms. In
particular, these include QCOM_ICC_TAG_* macros that clients can use when
calling icc_set_tag().
Signed-off-by: Mike Tipton
Acked-by: Rob Herring
---
drivers/interconnect/qcom/icc-rpmh.h| 18
Add "qcom,tcs-wait" property to set which TCS should wait for completion
when triggering.
Signed-off-by: Mike Tipton
Reviewed-by: Rob Herring
---
.../bindings/interconnect/qcom,bcm-voter.yaml | 20 +++
1 file changed, 20 insertions(+)
diff --git a/Documentation/
and allow for certain operations to occur in parallel
with the WAKE TCS triggering. This is only safe in very specific
situations. Keep the default behavior of always waiting, but allow it to
be overridden in devicetree.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 32
the sleep entry latency.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/bcm-voter.c
b/drivers/interconnect/qcom/bcm-voter.c
index f7db2b900599..d58b08f1f495 100644
--- a/drivers
qcom,icc.h bindings
- New patch for documenting qcom,tcs-wait property
- Update bcm_div() 'base' parameter from u64 to u32
Mike Tipton (6):
interconnect: qcom: Fix small BW votes being truncated to zero
dt-bindings: interconnect: Add generic qcom bindings
dt-bindings: interconnect: Add property
the sleep entry latency.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/bcm-voter.c
b/drivers/interconnect/qcom/bcm-voter.c
index 4bba3b42b648..d95725b9208c 100644
--- a/drivers
and allow for certain operations to occur in parallel
with the WAKE TCS triggering. This is only safe in very specific
situations. Keep the default behavior of always waiting, but allow it to
be overridden in devicetree.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 32
Currently, bcm-voter always assumes requests are made in KBps and that
BCM HW always wants them in Bps, so it always scales the requests by
1000. However, certain use cases and BCMs may use different units.
Thus, add support for BCM-specific scaling factors.
Signed-off-by: Mike Tipton
Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.
Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh
support")
Signed-off-by: Mike Tipton
--
Add "qcom,tcs-wait" property to set which TCS should wait for completion
when triggering.
Signed-off-by: Mike Tipton
---
.../bindings/interconnect/qcom,bcm-voter.yaml | 20 +++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/interconnec
Add generic qcom interconnect bindings that are common across platforms. In
particular, these include QCOM_ICC_TAG_* macros that clients can use when
calling icc_set_tag().
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/icc-rpmh.h| 18 ++
include/dt-bindings
() 'base' parameter from u64 to u32
Mike Tipton (6):
dt-bindings: interconnect: Add generic qcom bindings
dt-bindings: interconnect: Add property to set BCM TCS wait behavior
interconnect: qcom: Support bcm-voter-specific TCS wait behavior
interconnect: qcom: Only wait for completion in AMC
On 7/30/2020 12:07 PM, Saravana Kannan wrote:
On Mon, Jul 27, 2020 at 11:18 PM Mike Tipton wrote:
On 7/22/2020 10:07 AM, Saravana Kannan wrote:
On Wed, Jul 22, 2020 at 4:01 AM Georgi Djakov wrote:
The bootloaders often do some initial configuration of the interconnects
in the system
On 7/22/2020 10:07 AM, Saravana Kannan wrote:
On Wed, Jul 22, 2020 at 4:01 AM Georgi Djakov wrote:
The bootloaders often do some initial configuration of the interconnects
in the system and we want to keep this configuration until all consumers
have probed and expressed their bandwidth needs.
On 6/29/2020 5:30 PM, Mike Tipton wrote:
For test and debug purposes, it's often necessary to enable or disable
clocks from shell. Add a new debugfs file (clk_prepare_enable) that
calls clk_prepare_enable() when writing "1" and clk_disable_unprepare()
when writing "0".
Th
On 7/10/2020 9:31 AM, Rob Herring wrote:
On Thu, Jul 09, 2020 at 06:56:48PM -0700, Mike Tipton wrote:
Add "qcom,tcs-wait" property to set which TCS should wait for completion
when triggering.
Signed-off-by: Mike Tipton
---
.../bindings/interconnect/qcom,bcm-voter.yaml
On 7/9/2020 4:07 AM, Georgi Djakov wrote:
The interconnect controller hardware may support querying the current
bandwidth settings, so add a callback for providers to implement this
functionality if supported.
Signed-off-by: Georgi Djakov
---
drivers/interconnect/core.c | 3 ++-
On 7/9/2020 4:07 AM, Georgi Djakov wrote:
The bootloaders often do some initial configuration of the interconnects
in the system and we want to keep this configuration until all consumers
have probed and expressed their bandwidth needs. This is because we don't
want to change the configuration
(-)
Reviewed-by: Mike Tipton
diff --git a/drivers/interconnect/qcom/msm8916.c
b/drivers/interconnect/qcom/msm8916.c
index e94f3c5228b7..42c6c5581662 100644
--- a/drivers/interconnect/qcom/msm8916.c
+++ b/drivers/interconnect/qcom/msm8916.c
@@ -197,13 +197,13 @@ DEFINE_QNODE(pcnoc_int_0
the sleep entry latency.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/bcm-voter.c
b/drivers/interconnect/qcom/bcm-voter.c
index 4bba3b42b648..d95725b9208c 100644
--- a/drivers
and allow for certain operations to occur in parallel
with the WAKE TCS triggering. This is only safe in very specific
situations. Keep the default behavior of always waiting, but allow it to
be overridden in devicetree.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 32
These changes are mostly unrelated, but there are some dependencies
between them.
v2:
- New patch for generic qcom,icc.h bindings
- New patch for documenting qcom,tcs-wait property
- Update bcm_div() 'base' parameter from u64 to u32
Mike Tipton (6):
dt-bindings: interconnect: Add generic qcom
Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.
Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh
support")
Signed-off-by: Mike Tipton
--
Add "qcom,tcs-wait" property to set which TCS should wait for completion
when triggering.
Signed-off-by: Mike Tipton
---
.../bindings/interconnect/qcom,bcm-voter.yaml | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/interconnec
Currently, bcm-voter always assumes requests are made in KBps and that
BCM HW always wants them in Bps, so it always scales the requests by
1000. However, certain use cases and BCMs may use different units.
Thus, add support for BCM-specific scaling factors.
Signed-off-by: Mike Tipton
Add generic qcom interconnect bindings that are common across platforms. In
particular, these include QCOM_ICC_TAG_* macros that clients can use when
calling icc_set_tag().
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/icc-rpmh.h| 18 ++
include/dt-bindings
On 7/9/2020 8:35 AM, Matthias Kaehlcke wrote:
On Mon, Jun 22, 2020 at 09:05:14PM -0700, Mike Tipton wrote:
Add generic qcom interconnect bindings that are common across platforms. In
particular, these include QCOM_ICC_TAG_* macros that clients can use when
calling icc_set_tag().
Signed-off
On 7/2/2020 4:11 AM, Georgi Djakov wrote:
Hi Mike,
On 6/23/20 07:08, Mike Tipton wrote:
Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.
Fixes: 976daac4a1c5
On 7/2/2020 2:02 AM, Georgi Djakov wrote:
Hi Mike,
On 6/23/20 07:08, Mike Tipton wrote:
Currently, all bcm-voters set tcs_cmd::wait=true for the last VCD
command in each TCS (AMC, WAKE, and SLEEP). However, some bcm-voters
don't need the completion and instead need to optimize for latency
only support it when the code
has been modified to #define CLOCK_ALLOW_WRITE_DEBUGS.
Signed-off-by: Mike Tipton
---
drivers/clk/clk.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 236923b25543.
the sleep entry latency.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/bcm-voter.c
b/drivers/interconnect/qcom/bcm-voter.c
index e9f66f5c8a91..bb83ce7554b7 100644
--- a/drivers
Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.
Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh
support")
Signed-off-by: Mike Tipton
--
Currently, bcm-voter always assumes requests are made in KBps and that
BCM HW always wants them in Bps, so it always scales the requests by
1000. However, certain use cases and BCMs may use different units.
Thus, add support for BCM-specific scaling factors.
Signed-off-by: Mike Tipton
These changes are mostly unrelated, but there are some dependencies
between them.
Mike Tipton (4):
interconnect: qcom: Support bcm-voter-specific TCS wait behavior
interconnect: qcom: Only wait for completion in AMC/WAKE by default
interconnect: qcom: Add support for per-BCM scaling factors
and allow for certain operations to occur in parallel
with the WAKE TCS triggering. This is only safe in very specific
situations. Keep the default behavior of always waiting, but allow it to
be overridden in devicetree.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/bcm-voter.c | 32
Replace internal bucket/tag macros with those defined in dt-bindings.
Signed-off-by: Mike Tipton
---
drivers/interconnect/qcom/icc-rpmh.h | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/interconnect/qcom/icc-rpmh.h
b/drivers/interconnect/qcom/icc
Add generic qcom interconnect bindings that are common across platforms. In
particular, these include QCOM_ICC_TAG_* macros that clients can use when
calling icc_set_tag().
Signed-off-by: Mike Tipton
---
include/dt-bindings/interconnect/qcom,icc.h | 26 +
1 file changed, 26
Add common dt-bindings to replace internal macros.
Mike Tipton (2):
dt-bindings: interconnect: Add generic qcom bindings
interconnect: qcom: Don't redefine bucket/tag macros
drivers/interconnect/qcom/icc-rpmh.h| 18 ++
include/dt-bindings/interconnect/qcom,icc.h | 26
45 matches
Mail list logo
