l.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/dso.c | 2 ++
tools/perf/util/dso.h | 1 +
tools/perf/util/mac
Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index b0ff56332134..3f1431bf71bd 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util
: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/dso.c | 2 ++
tools/perf/util/dso.h | 1 +
tools/perf/util/machine.c | 17 +---
tools/perf/util/srcline.c | 66 +++
tools/perf/util/srcline.h | 7 +
5 files changed, 90
.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/machine.c | 15 +++
tools/perf/util/srcline.c | 16 +---
2 files changed, 8 insertions(+), 23 deleti
#1.66% of all branches
( +- 0.19% )
0.114222393 seconds time elapsed
( +- 1.19% )
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools
.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Cc: Ingo Molnar <mi...@kernel.org>
Suggested-by: Ingo Molnar <mi...@kernel.org>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/Documentation/perf-report.txt |
Molnar
Signed-off-by: Milian Wolff
---
tools/perf/Documentation/perf-report.txt | 3 ++-
tools/perf/Documentation/perf-script.txt | 3 ++-
tools/perf/util/symbol.c | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation/perf-report.txt
b
[.] cabs
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
(inlined)
12.29% 0.00% cpp-inlining cpp-inlining [.]
std::linear_congruential_engine::operator() (inlined)
0.52% 0.52% cpp-inlining libm-2.25.so [.] cabs
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-b
Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 117 +++-
1 file changed, 60
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 117 +++-
1 file changed, 60 insertions(+), 57 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 3f1431bf71bd..782de047c902 100644
--- a/tools/perf/util
Carvalho de Melo <a...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Yao Jin <yao@linux.intel.com>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
Note how most of the large offset values are now gone. Most notably,
we g
hello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 10 +++---
tools/perf/util/sort.c | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/callchain.c
: Yao Jin
Cc: Jiri Olsa
Signed-off-by: Milian Wolff
Note how most of the large offset values are now gone. Most notably,
we get proper srcline resolution for the random.h and complex headers.
---
tools/perf/util/sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/
. This allows us to efficiently lookup
the symbol for a given name without first having to append the
suffix before the lookup.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 10
o Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/per
hypot_finite+163
4.13% 0.00% [.] __hypot_finite
__hypot_finite+18446603487892193443
...
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
t
On Donnerstag, 5. Oktober 2017 06:08:29 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote:
> > This also removes the symbol name from the srcline column,
> > more on this below.
> >
> > This ensures we use the correct srcline, whi
On Donnerstag, 5. Oktober 2017 06:08:29 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote:
> > This also removes the symbol name from the srcline column,
> > more on this below.
> >
> > This ensures we use the correct srcline, whi
On Donnerstag, 5. Oktober 2017 05:43:38 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:57PM +0200, Milian Wolff wrote:
> > When no inlined frames could be found for a given address,
> > we did not store this information anywhere. That means we
> > potentially do the
On Donnerstag, 5. Oktober 2017 05:43:38 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:57PM +0200, Milian Wolff wrote:
> > When no inlined frames could be found for a given address,
> > we did not store this information anywhere. That means we
> > potentially do the
On Donnerstag, 5. Oktober 2017 05:35:29 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:50PM +0200, Milian Wolff wrote:
> > The inline_node structs are maintained by the new dso->inlines
> > tree. This in turn keeps ownership of the fake symbols and
> > src
On Donnerstag, 5. Oktober 2017 05:35:29 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:50PM +0200, Milian Wolff wrote:
> > The inline_node structs are maintained by the new dso->inlines
> > tree. This in turn keeps ownership of the fake symbols and
> > src
On Donnerstag, 5. Oktober 2017 03:56:13 CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Sun, Oct 01, 2017 at 04:30:48PM +0200, Milian Wolff wrote:
> > This is a requirement to create real callchain entries for inlined
> > frames.
> >
> > Since the list of inlines u
On Donnerstag, 5. Oktober 2017 03:56:13 CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Sun, Oct 01, 2017 at 04:30:48PM +0200, Milian Wolff wrote:
> > This is a requirement to create real callchain entries for inlined
> > frames.
> >
> > Since the list of inlines u
.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/ui/browsers/hists.c | 180 +++-
tools/perf/ui/stdio/hist.c | 77 +
tools/perf/util/evsel_fprintf.c |
of the srcline and handle deletion properly.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-o
The follow-up commits will make inline frames first-class citizens
in the callchain, thereby obsoleting all of this special code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/ui/browsers/hists.c
of the srcline and handle deletion properly.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 31 +--
tools/perf/util/callchain.h | 6 --
tools/perf
inline_node__delete.
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by:
inline_node__delete.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 93 ---
tools/perf/util/srcline.h | 7 +++-
tools/perf/util/symbol.h
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo.
t;yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 54 +++
tools/perf/util/srcline.h | 3 +--
2 files changed, 41 insertions(+), 16 deletions(-)
diff --git a/tools/perf/util/s
: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao....@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/dso.c | 3 +++
tools/perf/util/dso.h | 1 +
tools/perf/util/machine.c | 37 ++
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/callchain.c b
inline node and reuse
it for different callchain entries.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 54 +++
tools/perf/util
mes. The advantage
of this approach is that all existing users of the callchain API can
now transparently display inlined frames without having to patch
their code.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wo
[.] cabs
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
(inlined)
12.29% 0.00% cpp-inlining cpp-inlining [.]
std::linear_congruential_engine::operator() (inlined)
0.52% 0.52% cpp-inlining libm-2.25.so [.] cabs
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-b
hello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 10 +++---
tools/perf/util/sort.c | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/callchain.c
c: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
. This allows us to efficiently lookup
the symbol for a given name without first having to append the
suffix before the lookup.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 10
Signed-off-by: Milian Wolff
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index f2c6c5ee11e8..5b9e89257aa7 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools
std::abs (inlined)
std::__complex_abs (inlined)
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com&
Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index c6a033ba2b73..261823ae2ea4 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util
Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 117 +++-
1 file changed, 60
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 117 +++-
1 file changed, 60 insertions(+), 57 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 261823ae2ea4..48d2869025b3 100644
--- a/tools/perf/util
l.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/dso.c | 2 ++
tools/perf/util/dso.h | 1 +
tools/perf/util/mac
: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/dso.c | 2 ++
tools/perf/util/dso.h | 1 +
tools/perf/util/machine.c | 17 +---
tools/perf/util/srcline.c | 66 +++
tools/perf/util/srcline.h | 7 +
5 files changed, 90
.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/machine.c | 15 +++
tools/perf/util/srcline.c | 18 ++
2 files changed, 9 insertions(+), 24 d
#1.66% of all branches
( +- 0.19% )
0.114222393 seconds time elapsed
( +- 1.19% )
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools
.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Cc: Ingo Molnar <mi...@kernel.org>
Suggested-by: Ingo Molnar <mi...@kernel.org>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/Documentation/perf-report.txt |
Molnar
Signed-off-by: Milian Wolff
---
tools/perf/Documentation/perf-report.txt | 3 ++-
tools/perf/Documentation/perf-script.txt | 3 ++-
tools/perf/util/symbol.c | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation/perf-report.txt
b
o Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/per
hypot_finite+163
4.13% 0.00% [.] __hypot_finite
__hypot_finite+18446603487892193443
...
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
t
initial patch up into two to simplify reviewing. It also adds a
comment to clarify the lifetime handling of fake symbols and aliased non-fake
symbols, based on the feedback by Namhyung.
v2 fixes some issues reported by Namhyung or found by me in further
testing, adds caching and enables inline frame
of fake symbols and aliased non-fake
symbols, based on the feedback by Namhyung.
v2 fixes some issues reported by Namhyung or found by me in further
testing, adds caching and enables inline frames by default.
Milian Wolff (15):
perf report: remove code to handle inline frames from browsers
perf u
On Dienstag, 19. September 2017 14:27:19 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > +void inlines__tree_insert(struct rb_root *tree, struct inline_node
> > *inlines) +{
> > + struct rb_node **p = >rb_nod
On Dienstag, 19. September 2017 14:27:19 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > +void inlines__tree_insert(struct rb_root *tree, struct inline_node
> > *inlines) +{
> > + struct rb_node **p = >rb_nod
On Dienstag, 19. September 2017 14:27:27 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
> > The inlined frames use a fake symbol that is maintained by
> > inline_node which in turn is maintained by the dso->inlines tree.
> > This tree
On Dienstag, 19. September 2017 14:27:27 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
> > The inlined frames use a fake symbol that is maintained by
> > inline_node which in turn is maintained by the dso->inlines tree.
> > This tree
On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr);
> > +// parse inlined frames for the given address
On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr);
> > +// parse inlined frames for the given address
On Monday, September 18, 2017 1:56:19 PM CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:49PM +0200, Milian Wolff wrote:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
>
> s
On Monday, September 18, 2017 1:56:19 PM CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:49PM +0200, Milian Wolff wrote:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
>
> s
ve in your commit message is outdated:
https://github.com/brendangregg/FlameGraph/commit/
4b7b3169ed303d33fb710e1b9de235b84cc119d3
I.e. with a recent FlameGraph, you can generate flame graphs for different
events just fine, without any intermediate step.
Cheers
--
Milian Wolff | milian.wo...@kdab.com
ve in your commit message is outdated:
https://github.com/brendangregg/FlameGraph/commit/
4b7b3169ed303d33fb710e1b9de235b84cc119d3
I.e. with a recent FlameGraph, you can generate flame graphs for different
events just fine, without any intermediate step.
Cheers
--
Milian Wolff | milian.wo...@kdab.com
Commit-ID: dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0
Gitweb: http://git.kernel.org/tip/dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Tue, 12 Sep 2017 17:25:23 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0
Gitweb: http://git.kernel.org/tip/dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0
Author: Milian Wolff
AuthorDate: Tue, 12 Sep 2017 17:25:23 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 12 Sep 2017 12:49:13 -0300
perf stat
Commit-ID: 3192f1ed3dd3a6883d5ae31bf2ff69984ea0fd54
Gitweb: http://git.kernel.org/tip/3192f1ed3dd3a6883d5ae31bf2ff69984ea0fd54
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Mon, 11 Sep 2017 13:14:22 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 3192f1ed3dd3a6883d5ae31bf2ff69984ea0fd54
Gitweb: http://git.kernel.org/tip/3192f1ed3dd3a6883d5ae31bf2ff69984ea0fd54
Author: Milian Wolff
AuthorDate: Mon, 11 Sep 2017 13:14:22 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 12 Sep 2017 12:48:54 -0300
perf tools
Commit-ID: df90cc41d662ad5f700afc042df43e57ce1ed0a4
Gitweb: http://git.kernel.org/tip/df90cc41d662ad5f700afc042df43e57ce1ed0a4
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 6 Sep 2017 17:02:09 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
CommitD
Commit-ID: df90cc41d662ad5f700afc042df43e57ce1ed0a4
Gitweb: http://git.kernel.org/tip/df90cc41d662ad5f700afc042df43e57ce1ed0a4
Author: Milian Wolff
AuthorDate: Wed, 6 Sep 2017 17:02:09 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 12 Sep 2017 12:34:02 -0300
perf tests
1 context-switches #0.003 M/sec
0 cpu-migrations#0.000 K/sec
50 page-faults #0.140 M/sec
1269602 cycles#3.554 GHz
654278 instructions #0
1 context-switches #0.003 M/sec
0 cpu-migrations#0.000 K/sec
50 page-faults #0.140 M/sec
1269602 cycles#3.554 GHz
654278 instructions #0.5
On Monday, September 11, 2017 4:33:12 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> > On 9/11/17 4:14 AM, Milian Wolff wrote:
> > > Previously the part behind "perf-" was interpreted as an internal
>
On Monday, September 11, 2017 4:33:12 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> > On 9/11/17 4:14 AM, Milian Wolff wrote:
> > > Previously the part behind "perf-" was interpreted as an internal
>
structions #0.81 insn per cycle
# 0.76 stalled cycles
per insn
145,166 branches # 259.321 M/sec
7,726 branch-misses #5.
structions #0.81 insn per cycle
# 0.76 stalled cycles
per insn
145,166 branches # 259.321 M/sec
7,726 branch-misses #5.
y...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao....@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/perf.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/perf/perf.c b/t
g newline at the end of the error message.
With this patch applied, the above works properly:
~
$ ./perf-custom-suffix list
List of pre-defined events (to be used in -e):
...
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Mili
On Freitag, 8. September 2017 15:26:42 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu:
> > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote:
> > > +++ b/tools/perf/ui/progress.c
> > > @@ -25,7 +25,7
On Freitag, 8. September 2017 15:26:42 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu:
> > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote:
> > > +++ b/tools/perf/ui/progress.c
> > > @@ -25,7 +25,7
id ui_progress__init(struct ui_progress *p, u64 total, const char *title)
> {
> p->curr = 0;
> - p->next = p->step = total / 16;
> + p->next = p->step = total / 16 ?: 1;
> p->total = total;
> p->title = title;
This is a GNU extension,
ui_progress *p, u64 total, const char *title)
> {
> p->curr = 0;
> - p->next = p->step = total / 16;
> + p->next = p->step = total / 16 ?: 1;
> p->total = total;
> p->title = title;
This is a GNU extension, does this compile with clang
But ilist->symbol is a dangling pointer so accessing ->inlined would
> be a problem, no?
Sorry, but I can't follow. Why would it be a dangling pointer? Note, again,
that I've tested this with both valgrind and ASAN and neither reports any
issues about this code.
> > If you have sugge
But ilist->symbol is a dangling pointer so accessing ->inlined would
> be a problem, no?
Sorry, but I can't follow. Why would it be a dangling pointer? Note, again,
that I've tested this with both valgrind and ASAN and neither reports any
issues about this code.
> > If you have sugge
nested extern declaration of
‘unwind__get_entries’ [-Werror=nested-externs]
~~
Fix this compile error by specificing an explicit include of perf's
unwind.h in the util folder.
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Ki
nested extern declaration of
‘unwind__get_entries’ [-Werror=nested-externs]
~~
Fix this compile error by specificing an explicit include of perf's
unwind.h in the util folder.
Signed-off-by: Milian Wolff
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Cc: Jiri Ols
.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/ui/browsers/hists.c | 180 +++-
tools/perf/ui/stdio/hist.c | 77 +
tools/perf/util/evsel_fprintf.c |
The follow-up commits will make inline frames first-class citizens
in the callchain, thereby obsoleting all of this special code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/ui/browsers/hists.c
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo.
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/callchain.c b
llo.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/dso.c | 2 +
tools/perf/util/dso.h | 1 +
tools/perf/util/machine.c | 37 +
tools/perf/util/srcline.c | 186
all existing users of the callchain API can
now transparently display inlined frames without having to patch
their code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/dso.c | 2 +
tools/perf/util/ds
c: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Milian Wolff
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index f2c6c5ee11e8..5b9e89257aa7 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools
hello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 10 +++---
tools/perf/util/sort.c | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/callchain.c
. This allows us to efficiently lookup
the symbol for a given name without first having to append the
suffix before the lookup.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 10
of the srcline and handle deletion properly.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-o
201 - 300 of 571 matches
Mail list logo
