[PATCH v2 7/7] dt-bindings: iio: adc: max1027: Document max12xx series compatibles

2019-10-03 Thread Miquel Raynal
Update the bindings documentation with new Maxim ADCs compatibles. Signed-off-by: Miquel Raynal --- .../devicetree/bindings/iio/adc/max1027-adc.txt| 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b

[PATCH v2 6/7] dt-bindings: iio: adc: max1027: Mark interrupts as optional

2019-10-03 Thread Miquel Raynal
o turn them optional. Signed-off-by: Miquel Raynal --- Documentation/devicetree/bindings/iio/adc/max1027-adc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt index e680c6

[PATCH v2 4/7] iio: adc: max1027: Prepare the introduction of different resolutions

2019-10-03 Thread Miquel Raynal
d of hardcoding it everywhere. Also reorganize just a bit the macros at the top to avoid repeating tens of lines when adding support for a new chip. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 78 ++- 1 file changed, 36 insertions(+), 42 del

[PATCH v2 3/7] iio: adc: max1027: Reset the device at probe time

2019-10-03 Thread Miquel Raynal
All the registers are configured by the driver, let's reset the chip at probe time, avoiding any conflict with a possible earlier configuration. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iio/adc/max102

[PATCH v2 2/7] iio: adc: max1027: Make it optional to use interrupts

2019-10-03 Thread Miquel Raynal
are not inquired in the device tree. This has the effect to prevent triggered buffers use though. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 57 +-- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/iio/adc/max1027.c b/dri

[PATCH v2 0/7] Introduce max12xx ADC support

2019-10-03 Thread Miquel Raynal
ree compatibles from patch 4 (the preparation patch) to add these lines back in patch 5 (the actual introduction). Miquel Raynal (7): iio: adc: max1027: Add debugfs register read support iio: adc: max1027: Make it optional to use interrupts iio: adc: max1027: Reset the device at probe time

Re: [PATCH 4/7] iio: adc: max1027: Prepare the introduction of different resolutions

2019-10-02 Thread Miquel Raynal
Hello, Miquel Raynal wrote on Wed, 2 Oct 2019 14:30:22 +0200: > Maxim's max1027/29/31 series returns the measured voltages with a > resolution of 10 bits. There is a very similar series, max1227/29/31 > which works very similarly but uses a resolution of 12 bits. Prepare >

[PATCH 2/7] iio: adc: max1027: Make it optional to use interrupts

2019-10-02 Thread Miquel Raynal
are not inquired in the device tree. This has the effect to prevent triggered buffers use though. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 57 +-- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/iio/adc/max1027.c b/dri

[PATCH 5/7] iio: adc: max1027: Introduce 12-bit devices support

2019-10-02 Thread Miquel Raynal
Maxim's max12xx series is very similar to the max10xx series, with the difference of the measurements depth which is upgraded from 10 to 12 bits per channel. Everything else looks the same. Signed-off-by: Miquel Raynal --- drivers/iio/adc/Kconfig | 4 ++-- drivers/iio/adc/max1027.c

[PATCH 6/7] dt-bindings: iio: adc: max1027: Mark interrupts as optional

2019-10-02 Thread Miquel Raynal
o turn them optional. Signed-off-by: Miquel Raynal --- Documentation/devicetree/bindings/iio/adc/max1027-adc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt index e680c6

[PATCH 3/7] iio: adc: max1027: Reset the device at probe time

2019-10-02 Thread Miquel Raynal
All the registers are configured by the driver, let's reset the chip at probe time, avoiding any conflict with a possible earlier configuration. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iio/adc/max102

[PATCH 1/7] iio: adc: max1027: Add debugfs register read support

2019-10-02 Thread Miquel Raynal
Until now, only write operations were supported. Force two bytes read operation when reading from this register (might be wrong when reading the temperature, but will work with any other value). Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 7 +-- 1 file changed, 5 insertions

[PATCH 7/7] dt-bindings: iio: adc: max1027: Document max12xx series compatibles

2019-10-02 Thread Miquel Raynal
Update the bindings documentation with new Maxim ADCs compatibles. Signed-off-by: Miquel Raynal --- .../devicetree/bindings/iio/adc/max1027-adc.txt| 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b

[PATCH 0/7] Introduce max12xx ADC support

2019-10-02 Thread Miquel Raynal
not wired (which is absolutely fine for this chip), I also updated the driver and the bindings to support optional interrupts. In this case, triggered buffers are not available and the user must poll the value from sysfs. Thanks, Miquèl Miquel Raynal (7): iio: adc: max1027: Add debugfs registe

[PATCH 4/7] iio: adc: max1027: Prepare the introduction of different resolutions

2019-10-02 Thread Miquel Raynal
eter instead of hardcoding it everywhere. Also reorganize just a bit the macros at the top to avoid repeating tens of lines when adding support for a new chip. Signed-off-by: Miquel Raynal --- drivers/iio/adc/max1027.c | 81 +++ 1 file changed, 39 insertions(+), 42 del

Re: [v7 1/2] mtd: rawnand: Add new Cadence NAND driver to MTD subsystem (fwd)

2019-09-25 Thread Miquel Raynal
References: <20190918123115.30510-1-pio...@cadence.com> > TO: Piotr Sroka > CC: Kazuhiro Kasai , Piotr Sroka > , Miquel Raynal , Richard > Weinberger , David Woodhouse , Brian > Norris , Marek Vasut , > Vignesh Raghavendra , Mauro Carvalho Chehab > , "Davi

Re: [PATCH] - change calculating of position page containing BBM

2019-09-19 Thread Miquel Raynal
Hello, Schrempf Frieder wrote on Thu, 19 Sep 2019 13:15:08 +: > On 19.09.19 14:58, Miquel Raynal wrote: > > Hi Piotr, > > > > Piotr Sroka wrote on Thu, 19 Sep 2019 13:41:35 > > +0100: > > > >> Change calculating of position page containing BBM

Re: [PATCH] - change calculating of position page containing BBM

2019-09-19 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Thu, 19 Sep 2019 13:41:35 +0100: > Change calculating of position page containing BBM > > If none of BBM flags is set then function nand_bbm_get_next_page > reports EINVAL. It causes that BBM is not read at all during scanning > factory bad blocks. The result is

Re: [PATCH] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe()

2019-09-19 Thread Miquel Raynal
Hi Greg, Greg Kroah-Hartman wrote on Thu, 19 Sep 2019 13:29:37 +0200: > On Thu, Sep 19, 2019 at 11:10:14AM +0200, Miquel Raynal wrote: > > Hi Markus, > > > > Markus Elfring wrote on Wed, 18 Sep 2019 > > 14:50:27 +0200: > > > > > From: Markus Elfr

Re: [PATCH] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe()

2019-09-19 Thread Miquel Raynal
Hi Markus, Markus Elfring wrote on Wed, 18 Sep 2019 14:50:27 +0200: > From: Markus Elfring > Date: Wed, 18 Sep 2019 14:37:34 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Mar

Re: [v5 2/2] dt-bindings: mtd: Add Cadence NAND controller driver

2019-09-13 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Wed, 11 Sep 2019 16:04:24 +0100: > Hi Miquel > > The 08/30/2019 11:46, Miquel Raynal wrote: > >EXTERNAL MAIL > > > > > >Hi Piotr, > > > >Piotr Sroka wrote on Thu, 25 Jul 2019 15:59:55 > >+0100: > > &

Re: [PATCH] mtd: rawnand: fix spelling mistake "gravepagess" -> "gravepages"

2019-09-13 Thread Miquel Raynal
Hi Colin, Colin King wrote on Fri, 13 Sep 2019 10:22:43 +0100: > From: Colin Ian King > > There is a spelling mistake in a NS_ERR error message. Fix it. A Fixes tag would be great! > > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/nandsim.c | 2 +- > 1 file changed, 1 inserti

Re: [v5 1/2] mtd: nand: Add new Cadence NAND driver to MTD subsystem

2019-09-11 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Wed, 11 Sep 2019 10:43:56 +0100: > The 08/30/2019 11:46, Miquel Raynal wrote: > >EXTERNAL MAIL > > > > > >Hi Piotr, > > > >Piotr Sroka wrote on Thu, 25 Jul 2019 16:00:12 > >+0100: > > > >Subject should be

Re: [PATCH -next 01/15] thermal: armada: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Miquel Raynal
/* First memory region points towards the status register */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(&pdev->dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] Add support for Macronix NAND randomizer

2019-08-30 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Thu, 29 Aug 2019 17:07:51 +0800: > Hi Miquel, > > > > > > > > If subpage write not available with hardware ECC, for example, > > > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and > > > randomizer function is recommended for high-reliabil

Re: [v5 1/2] mtd: nand: Add new Cadence NAND driver to MTD subsystem

2019-08-30 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Thu, 25 Jul 2019 16:00:12 +0100: Subject should be: mtd: rawnand: Last few nits in your driver which overall looks good (see below). Now I'm waiting for Rob's ack on the bindings. This driver should be a good candidate for 5.5. > Add new Cadence NAND driver to M

Re: [v5 2/2] dt-bindings: mtd: Add Cadence NAND controller driver

2019-08-30 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Thu, 25 Jul 2019 15:59:55 +0100: > Document the bindings used by Cadence NAND controller driver > > Signed-off-by: Piotr Sroka > --- > Changes for v5: > - replace "_" by "-" in all properties > - change compatible name from cdns,hpnfc to cdns,hp-nfc > Changes for

Re: [PATCH] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips

2019-08-29 Thread Miquel Raynal
On Mon, 2019-08-26 at 19:57:56 UTC, Kamal Dasu wrote: > From: Claire Lin > > In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation > while correcting erased page bitflip. > > Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips") > Signed-off-by: Claire Lin

[GIT PULL] mtd: Fixes for -rc7

2019-08-29 Thread Miquel Raynal
Hello Linus, This is hopefully the last MTD fixes PR for the 5.3 cycle with a single change to avoid build failures when compiling Hyperbus support. Thanks, Miquèl The following changes since commit a55aa89aab90fae7c815b0551b07be37db359d76: Linux 5.3-rc6 (2019-08-25 12:01:23 -0700) are avai

Re: [PATCH] mtd: hyperbus: fix dependency and build error

2019-08-29 Thread Miquel Raynal
[drivers/mtd/hyperbus/hyperbus-core.ko] > undefined! > > Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") > Signed-off-by: Randy Dunlap > Cc: Vignesh Raghavendra > Cc: Miquel Raynal > Cc: Geert Uytterhoeven > Cc: linux-...@lists.infradead.org > Ac

Re: [PATCH] mtd: onenand_base: Fix a memory leak bug

2019-08-26 Thread Miquel Raynal
On Sun, 2019-08-18 at 15:52:49 UTC, Wenwen Wang wrote: > In onenand_scan(), if CONFIG_MTD_ONENAND_VERIFY_WRITE is defined, > 'this->verify_buf' is allocated through kzalloc(). However, it is not > deallocated in the following execution, if the allocation for > 'this->oob_buf' fails, leading to a me

Re: [PATCH v2] mtd: rawnand: Fix a memory leak bug

2019-08-26 Thread Miquel Raynal
On Mon, 2019-08-19 at 02:46:04 UTC, Wenwen Wang wrote: > In nand_scan_bbt(), a temporary buffer 'buf' is allocated through > vmalloc(). However, if check_create() fails, 'buf' is not deallocated, > leading to a memory leak bug. To fix this issue, free 'buf' before > returning the error. > > Signed

Re: [PATCH v7 1/2] mtd: rawnand: Add Macronix raw NAND controller driver

2019-08-26 Thread Miquel Raynal
On Mon, 2019-08-19 at 07:19:08 UTC, Mason Yang wrote: > Add a driver for Macronix raw NAND controller. > > Signed-off-by: Mason Yang Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH trivial] mtd: nand: fix typo, s/erasablocks/eraseblocks

2019-08-26 Thread Miquel Raynal
On Fri, 2019-08-23 at 15:39:37 UTC, wrote: > From: Tudor Ambarus > > Signed-off-by: Tudor Ambarus Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH v7 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-08-26 Thread Miquel Raynal
On Mon, 2019-08-19 at 07:19:09 UTC, Mason Yang wrote: > Document the bindings used by the Macronix raw NAND controller. > > Signed-off-by: Mason Yang > Reviewed-by: Rob Herring Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH 12/16] mtd: rawnand: remove w90x900 driver

2019-08-26 Thread Miquel Raynal
On Fri, 2019-08-09 at 20:27:40 UTC, Arnd Bergmann wrote: > The ARM w90x900 platform is getting removed, so this driver is obsolete. > > Signed-off-by: Arnd Bergmann > Reviewed-by: Boris Brezillon Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Mique

Re: [PATCH] mtd: rawnand: sharpsl: add include guard to linux/mtd/sharpsl.h

2019-08-26 Thread Miquel Raynal
On Tue, 2019-08-20 at 02:50:57 UTC, Masahiro Yamada wrote: > Add a header include guard just in case. > > Signed-off-by: Masahiro Yamada Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH] Add support for Macronix NAND randomizer

2019-08-26 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Mon, 26 Aug 2019 10:52:31 +0800: > Hi Miquel, > > > > Mason Yang wrote on Tue, 20 Aug 2019 13:53:48 > > +0800: > > > > > Macronix NANDs support randomizer operation for user data scrambled, > > > which can be enabled with a SET_FEATURE. > > > > > >

Re: [PATCH] Add support for Macronix NAND randomizer

2019-08-24 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Tue, 20 Aug 2019 13:53:48 +0800: > Macronix NANDs support randomizer operation for user data scrambled, > which can be enabled with a SET_FEATURE. > > User data written to the NAND device without randomizer is still readable > after randomizer function enabled. > T

Re: [v5 1/2] mtd: nand: Add new Cadence NAND driver to MTD subsystem

2019-08-24 Thread Miquel Raynal
Hi Dmitry, Dmitry Osipenko wrote on Thu, 25 Jul 2019 18:11:43 +0300: > 25.07.2019 18:00, Piotr Sroka пишет: > > Add new Cadence NAND driver to MTD subsystem > > > > Signed-off-by: Piotr Sroka > > --- > > Changes for v5: > > - fix "ecc config strength" field size > > - remove unused macros > >

Re: [PATCH] mtd: hyperbus: fix dependency and build error

2019-08-24 Thread Miquel Raynal
source" [drivers/mtd/hyperbus/hyperbus-core.ko] > undefined! > > Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") > Signed-off-by: Randy Dunlap > Cc: Vignesh Raghavendra > Cc: Miquel Raynal > Cc: Geert Uytterhoeven > Cc: linux-...@lists.infra

Re: [PATCH v5 1/4] clk: core: link consumer with clock driver

2019-08-24 Thread Miquel Raynal
Hi Stephen, Stephen Boyd wrote on Wed, 14 Aug 2019 17:03:00 -0700: > Quoting Miquel Raynal (2019-05-21 05:51:10) > > One major concern when, for instance, suspending/resuming a platform > > is to never access registers before the underlying clock has been > > resumed, other

Re: [EXT] Re: [PATCH 4/8] mtd: spinand: enabled parameter page support

2019-08-19 Thread Miquel Raynal
Hi Boris, Another question for you :) "Shivamurthy Shastri (sshivamurthy)" wrote on Mon, 19 Aug 2019 08:51:52 +: > Hi Miquel, > > > > > Hi Shiva, > > > > shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:17 +0200: > > > > "mtd: spinand: enable parameter page support" > > > >

Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-08-19 Thread Miquel Raynal
Hi Boris, I need your opinion on the question below. "Shivamurthy Shastri (sshivamurthy)" wrote on Mon, 19 Aug 2019 09:03:38 +: > Hi Miquel, > > > > > Hi Shiva, > > > > shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > > > > > From: Shivamurthy Shastri > > > >

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-19 Thread Miquel Raynal
t is up to Zhang or Eduardo to take the patches. > > Sorry for the delay, I don't manage a tree for this driver, I'll let Zhang or Eduardo take the patch with my Acked-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] mtd: rawnand: ingenic: fix devm_platform_ioremap_resource.cocci warnings

2019-08-07 Thread Miquel Raynal
On Mon, 2019-07-22 at 23:39:34 UTC, Julia Lawall wrote: > From: kbuild test robot > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:330:1-9: WARNING: Use > devm_platform_ioremap_resource for cs -> base > > Use devm_platform_ioremap_resource helper which wraps > platform_get_resource() and d

Re: [PATCH] mtd: rawnand: r852: Use dev_get_drvdata

2019-08-07 Thread Miquel Raynal
On Tue, 2019-07-23 at 12:47:27 UTC, Chuhong Yuan wrote: > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel

Re: [PATCH] mtd: rawnand: remove redundant assignment to variable ret

2019-08-07 Thread Miquel Raynal
On Wed, 2019-07-31 at 08:52:08 UTC, Colin King wrote: > From: Colin Ian King > > Variable ret is being initialized with a value that is never read > and ret is being re-assigned a little later on. The assignment is > redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH 8/8] mtd: spinand: micron: Enable micron flashes with multi-die

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:21 +0200: "with multiple dies" in the title > From: Shivamurthy Shastri > > Some of the Micron flashes has multi-die, and need to select the die have multiple dies and > each time while accessing

Re: [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes

2019-08-07 Thread Miquel Raynal
e. This is not readable enough, can you rephrase? Besides that you can add my Reviewed-by: Miquel Raynal > > Signed-off-by: Shivamurthy Shastri > --- > drivers/mtd/nand/spi/micron.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mtd/nand

Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > From: Shivamurthy Shastri > I am not sure the "turn implemenatation generic" title describes what you do. > Driver is redesigned using parameter page to support Micron SPI NAND > flashes. Redesigned is perhaps a

Re: [PATCH 5/8] mtd: spinand: micron: prepare for generalizing driver

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:18 +0200: > From: Shivamurthy Shastri > "mtd: spinand: micron: Rename helpers and structures to be more generic" > Generalize OOB layout structure and function names. Change the prefix of Micron driver's functions and struc

Re: [PATCH 4/8] mtd: spinand: enabled parameter page support

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:17 +0200: "mtd: spinand: enable parameter page support" > From: Shivamurthy Shastri > > Some of the SPI NAND devices has parameter page, which is similar to - have a > ONFI table. regular raw NA

Re: [PATCH 3/8] mtd: nand: create ONFI table parsing instance

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:16 +0200: > From: Shivamurthy Shastri "Create one generic ONFI table parsing instance" > > ONFI table parsing is common, as most of the variables are common > between raw and SPI NAND. The parsing function is instantiated in

Re: [PATCH 2/8] mtd: nand: move support functions for ONFI to nand/onfi.c

2019-08-07 Thread Miquel Raynal
Hi shiva.linuxwo...@gmail.com, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:15 +0200: > From: Shivamurthy Shastri "mtd: nand: move ONFI specific helpers to nand/onfi.c"? > > These functions are support functions for enabling ONFI standard and > common between raw NAND and SPI NA

Re: [PATCH 1/8] mtd: nand: move ONFI related functions to onfi.h

2019-08-07 Thread Miquel Raynal
Hi Shiva, shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:14 +0200: > From: Shivamurthy Shastri > > These functions will be used by both raw NAND and SPI NAND, which > supports ONFI like standards. This is not exactly what you do. Why not: mtd: nand: export ONFI related functions t

[GIT PULL] mtd: Fixes for 5.3-rc4

2019-08-04 Thread Miquel Raynal
Hello Linus, Here are three MTD fixes for the next -rc. Thanks, Miquèl The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.gi

Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-08-01 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Thu, 1 Aug 2019 17:32:04 +0800: > Hi Miquel, > > > > Document the bindings used by the Macronix raw NAND controller. > > > > > > Signed-off-by: Mason Yang > > > --- > > > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 > +

Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-08-01 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Thu, 1 Aug 2019 11:55:10 +0800: > Document the bindings used by the Macronix raw NAND controller. > > Signed-off-by: Mason Yang > --- > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++ > 1 file changed, 19 insertions(+) > create mod

Re: [PATCH v4 0/4] Add device links to clocks

2019-07-27 Thread Miquel Raynal
Hi Stephen, Miquel Raynal wrote on Mon, 17 Jun 2019 11:57:03 +0200: > Hi Stephen, > > Miquel Raynal wrote on Tue, 21 May 2019 > 11:46:44 +0200: > > > Hi Stephen, > > > > Stephen Boyd wrote on Thu, 11 Apr 2019 16:34:16 > > -0700: > > >

Re: linux-next: Fixes tag needs some work in the nand tree

2019-07-25 Thread Miquel Raynal
Hi Stephen, Stephen Rothwell wrote on Thu, 25 Jul 2019 21:07:24 +1000: > Hi all, > > In commit > > 0ade3f0f5877 ("mtd: rawnand: stm32_fmc2: avoid warnings when building with > W=1 option") > > Fixes tag > > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash > > h

Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Add of_node_put() before return

2019-07-23 Thread Miquel Raynal
return PTR_ERR(phy); > + } > > lane->dev = &pdev->dev; > lane->mode = PHY_MODE_INVALID; Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] dt-bindings: Ensure child nodes are of type 'object'

2019-07-16 Thread Miquel Raynal
-schema will enforce this on any child node definitions. > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: David Woodhouse > Cc: Brian Norris > Cc: Marek Vasut > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Linus Walleij > Cc: Maxime

Re: [PATCH] mtd: rawnand: stm32_fmc2: avoid warnings when building with W=1 option

2019-07-09 Thread Miquel Raynal
Hi Christophe, Christophe Kerello wrote on Tue, 9 Jul 2019 09:50:10 +0200: > On 7/1/19 9:11 AM, Miquel Raynal wrote: > > Hi Christophe, > > > > Christophe Kerello wrote on Fri, 21 Jun > > 2019 16:43:09 +0200: > > > >> This patch solves warn

Re: [PATCH] mtd: remove c++ comments from uapi header

2019-07-08 Thread Miquel Raynal
Hi Arnd, Arnd Bergmann wrote on Mon, 8 Jul 2019 14:49:39 +0200: > Checking the uapi headers now produces a warning with clang: > > ./usr/include/mtd/mtd-abi.h:116:28: error: // comments are not allowed in > this language [-Werror,-Wcomment] > > Change these into standard C comments here. >

Re: [PATCH] mtd: spinand: Fix max_bad_eraseblocks_per_lun info in memorg

2019-07-05 Thread Miquel Raynal
On Thu, 2019-06-06 at 17:07:55 UTC, Schrempf Frieder wrote: > From: Frieder Schrempf > > The 1Gb Macronix chip can have a maximum of 20 bad blocks, while > the 2Gb version has twice as many blocks and therefore the maximum > number of bad blocks is 40. > > The 4Gb GigaDevice GD5F4GQ4xA has twice

Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-07-05 Thread Miquel Raynal
On Sat, 2019-06-29 at 01:22:48 UTC, Paul Cercueil wrote: > If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, > which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: > > drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function > `ingenic_nand_remove': > ingenic_nand.c:(.text+0x177): u

Re: [PATCH] checkpatch: DT bindings vendor prefixes file yas been translated into yaml

2019-07-05 Thread Miquel Raynal
Hello, Miquel Raynal wrote on Fri, 5 Jul 2019 12:03:45 +0200: > The extension is now .yaml instead of .txt. > > Fixes: 8122de54602e ("dt-bindings: Convert vendor prefixes to json-schema") > Signed-off-by: Miquel Raynal > --- I am one month too late, didn't saw

[PATCH] checkpatch: DT bindings vendor prefixes file yas been translated into yaml

2019-07-05 Thread Miquel Raynal
The extension is now .yaml instead of .txt. Fixes: 8122de54602e ("dt-bindings: Convert vendor prefixes to json-schema") Signed-off-by: Miquel Raynal --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatc

Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-07-01 Thread Miquel Raynal
Hi Paul, One question below. Paul Cercueil wrote on Sat, 29 Jun 2019 03:22:48 +0200: > If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, > which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: > > drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function > `ingenic_nand_remove': >

Re: [PATCH v2 1/2] mtd: nand: Add Cadence NAND controller driver

2019-07-01 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Mon, 1 Jul 2019 10:51:45 +0100: [...] > >> >> > > >> >> >This driver is way too massive, I am pretty sure it can shrink a > >> >> >little bit more. > >> >> >[...] > >> >> > > >> >> I will try to make it shorer but it will be difucult to achive. It is > >> >> be

Re: [PATCH] mtd: onenand_base: Mark expected switch fall-through

2019-07-01 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Tue, 4 Jun 2019 09:17:37 -0500: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mtd/nand/onenand/onenand_base.c: In function ‘onen

Re: [PATCH v3 1/2] mtd: Add flag to indicate panic_write

2019-07-01 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Thu, 16 May 2019 12:41:46 -0400: > Added a flag to indicate a panic_write so that low level drivers can > use it to take required action where applicable, to ensure oops data > gets written to assigned mtd device. > > Signed-off-by: Kamal Dasu > --- Applied to na

Re: [PATCH v3] mtd: rawnand: Add Macronix NAND read retry support

2019-07-01 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Mon, 3 Jun 2019 10:42:04 +0800: > Add support for Macronix NAND read retry. > > Macronix NANDs support specific read operation for data recovery, > which can be enabled with a SET_FEATURE. > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table > to

Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size

2019-07-01 Thread Miquel Raynal
Hi Colin, Colin King wrote on Tue, 4 Jun 2019 11:58:59 +0100: > From: Colin Ian King > > The variable block_size is being assigned to itself and to > geo->ecc_chunk_size. Clean up the double assignment by removing > the assignment to itself. > > Addresses-Coverity: ("Evaluation order violat

Re: [PATCH v2 1/3] mtd: nand: raw: brcmnand: Refactored code to introduce helper functions

2019-07-01 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Tue, 4 Jun 2019 10:36:29 -0400: > Refactored NAND ECC and CMD address configuration code to use helper > functions. > > Signed-off-by: Kamal Dasu > --- Applied to nand/next, thanks. Miquèl

Re: [PATCH v4 1/2] mtd: Add flag to indicate panic_write

2019-07-01 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Tue, 18 Jun 2019 14:26:42 -0400: > Added a flag to indicate a panic_write so that low level drivers can > use it to take required action where applicable, to ensure oops data > gets written to assigned mtd device. > > Signed-off-by: Kamal Dasu > --- Applied to na

Re: [PATCH] mtd: rawnand: stm32_fmc2: avoid warnings when building with W=1 option

2019-07-01 Thread Miquel Raynal
Hi Christophe, Christophe Kerello wrote on Fri, 21 Jun 2019 16:43:09 +0200: > This patch solves warnings detected by setting W=1 when building. > > Warnings type detected: > drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function ‘stm32_fmc2_calc_timings’: > drivers/mtd/nand/raw/stm32_fmc2_nand.c:1

Re: [PATCH] mtd: rawnand: stm32_fmc2: avoid warnings when building with W=1 option

2019-07-01 Thread Miquel Raynal
Hi Christophe, Christophe Kerello wrote on Fri, 21 Jun 2019 16:43:09 +0200: > This patch solves warnings detected by setting W=1 when building. > > Warnings type detected: > drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function ‘stm32_fmc2_calc_timings’: > drivers/mtd/nand/raw/stm32_fmc2_nand.c:1

Re: [PATCH v2] mtd: spinand: Add initial support for Paragon PN26G0xA

2019-06-28 Thread Miquel Raynal
On Tue, 2019-06-18 at 17:08:05 UTC, Jeff Kletsky wrote: > From: Jeff Kletsky > > Add initial support for Paragon Technology > PN26G01Ax and PN26G02Ax SPI NAND > > Datasheets available at > http://www.xtxtech.com/upfile/2016082517274590.pdf > http://www.xtxtech.com/upfile/2016082517282329

Re: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 04:14:46 UTC, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read return

Re: [PATCH v2 14/27] mtd: nand: use kzalloc instead of kmalloc and memset

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 02:48:13 UTC, Fuqian Huang wrote: > Replace kmalloc followed by a memset with kzalloc. > > There is a recommendation to use zeroing allocator > rather than allocator followed by memset with 0 in > ./scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Signed-off-by: Fuqian H

Re: [PATCH v2] mtd: rawnand: stm32_fmc2: increase DMA completion timeouts

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 09:18:06 UTC, Christophe Kerello wrote: > From: Amelie Delaunay > > When the system is overloaded, DMA data transfer completion occurs after > 100ms. Increase the timeouts to let it the time to complete. > > Signed-off-by: Amelie Delaunay > Signed-off-by: Christophe Kerell

Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-06-28 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Fri, 28 Jun 2019 17:09:16 +0800: > Hi Miquel, > > > > > Please always Cc: Rob (robh...@kernel.org) when you send bindings > > related patches. > > Understood. thanks for your remind. > > > > > > > > > > > > > > +- reg: should contain 1 entri

Re: [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller

2019-06-28 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Fri, 28 Jun 2019 16:31:16 +0800: > Hi Miquel, > > > > > > > > > Add a driver for Macronix raw NAND controller. > > > > > > > > Could you pass userspace major MTD tests and can you > attach/mount/edit > > > > a UBI/UBIFS storage? > > > > >

Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-06-28 Thread Miquel Raynal
Hi Mason, Please always Cc: Rob (robh...@kernel.org) when you send bindings related patches. masonccy...@mxic.com.tw wrote on Fri, 28 Jun 2019 14:48:02 +0800: > Hi Miquel, > > > > Document the bindings used by the Macronix raw NAND controller. > > > > > > Signed-off-by: Mason Yang > > > --- >

Re: [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller

2019-06-28 Thread Miquel Raynal
Hi masonccy...@mxic.com.tw, masonccy...@mxic.com.tw wrote on Fri, 28 Jun 2019 14:01:55 +0800: > Hi Miquel, > > > > > Add a driver for Macronix raw NAND controller. > > > > Could you pass userspace major MTD tests and can you attach/mount/edit > > a UBI/UBIFS storage? > > mtd_debug passed

Re: linux-next: manual merge of the nand tree with Linus' tree

2019-06-27 Thread Miquel Raynal
Hi Stephen, Miquel Raynal wrote on Thu, 27 Jun 2019 16:51:37 +0200: > Hi Stephen, > > Stephen Rothwell wrote on Tue, 4 Jun 2019 > 10:54:18 +1000: > > > Hi all, > > > > Today's linux-next merge of the nand tree got a conflict in: > > >

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

2019-06-27 Thread Miquel Raynal
Hi Miquel, Miquel Raynal wrote on Thu, 27 Jun 2019 19:06:44 +0200: > Hello, > > Schrempf Frieder wrote on Tue, 25 Jun > 2019 07:04:06 +: > > > Hi liaoweixiong, > > > > On 25.06.19 05:08, Greg KH wrote: > > > On Tue, Jun 25, 2019 at 09:02:29A

Re: [PATCH 35/87] mtd: nand: replace kmalloc and memset with kzalloc in nand_bch.c

2019-06-27 Thread Miquel Raynal
Hi Fuqian, Fuqian Huang wrote on Fri, 28 Jun 2019 01:39:05 +0800: > kmalloc + memset(0) -> kzalloc > > Signed-off-by: Fuqian Huang > --- > drivers/mtd/nand/raw/nand_bch.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_bch.c b/drivers/mtd/

Re: [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller

2019-06-27 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Tue, 25 Jun 2019 14:10:55 +0800: > Add a driver for Macronix raw NAND controller. Could you pass userspace major MTD tests and can you attach/mount/edit a UBI/UBIFS storage? Looks pretty nice to me, a few comments below. > > Signed-off-by: Mason Yang > --- > d

Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-06-27 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Tue, 25 Jun 2019 14:10:56 +0800: > Document the bindings used by the Macronix raw NAND controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/mtd/mxic-nand.txt | 26 > ++ > 1 file changed, 26 insertions(+) > creat

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

2019-06-27 Thread Miquel Raynal
Hello, Schrempf Frieder wrote on Tue, 25 Jun 2019 07:04:06 +: > Hi liaoweixiong, > > On 25.06.19 05:08, Greg KH wrote: > > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > >> In case of the last page containing bitflips (ret > 0), > >> spinand_mtd_read() will return that nu

Re: [PATCH] mtd: rawnand: stm32_fmc2: increase DMA completion timeouts

2019-06-27 Thread Miquel Raynal
Hi Christophe, Christophe Kerello wrote on Fri, 21 Jun 2019 16:48:00 +0200: > When the system is overloaded, DMA data transfer completion occurs after > 100ms. Increase the timeouts to let it the time to complete. > > Signed-off-by: Amelie Delaunay The first SoB should be the author's. Either

Re: [PATCH] mtd: onenand_base: Mark expected switch fall-through

2019-06-27 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Wed, 26 Jun 2019 13:16:22 -0500: > Hi all, > > Friendly ping: > > Who can take this? I am queuing it right now, please be patient. Also for next time, the prefix should have been "mtd: onenand:" but that's ok, I edited the title. Thanks, Miquèl

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-27 Thread Miquel Raynal
Hi Paul, Miquel Raynal wrote on Mon, 17 Jun 2019 14:16:59 +0200: > Hello, > > Arnd Bergmann wrote on Mon, 17 Jun 2019 14:12:48 +0200: > > > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil wrote: > > > > > I think there's a better way to fix it, onl

Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2019-06-27 Thread Miquel Raynal
Hi Naga, Naga Sureshkumar Relli wrote on Tue, 18 Jun 2019 22:44:24 -0600: > On Mon, Jan 28, 2019 at 10:27:39AM +0100, Miquel Raynal wrote: > Hi Miquel, > > > Hi Naga, > > > > Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019 > > 06:04:53 +000

Re: [PATCH v2 1/2] mtd: nand: Add Cadence NAND controller driver

2019-06-27 Thread Miquel Raynal
Hi Piotr, Piotr Sroka wrote on Thu, 6 Jun 2019 16:19:51 +0100: > Hi Miquel > > > The 05/12/2019 14:24, Miquel Raynal wrote: > >EXTERNAL MAIL > > > > > >EXTERNAL MAIL > > > > > >Hi Piotr, > > > >Sorry for de delay. > > >

Re: [PATCH v2 1/3] mtd: nand: raw: brcmnand: Refactored code to introduce helper functions

2019-06-27 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Tue, 4 Jun 2019 10:36:29 -0400: > Refactored NAND ECC and CMD address configuration code to use helper > functions. > I'll take this series and edit myself the commit title but for next time please change the subject to "mtd: rawnand:" ;) Thanks, Miquèl

Re: [PATCH v3 2/2] mtd: nand: raw: brcmnand: When oops in progress use pio and interrupt polling

2019-06-27 Thread Miquel Raynal
Hi Richard, Richard Weinberger wrote on Tue, 11 Jun 2019 22:16:36 +0200: > On Tue, Jun 11, 2019 at 10:03 PM Kamal Dasu wrote: > > > > Richard, > > > > You have any other review comments/concerns with this patch, if not > > can you please sign off on it. > > I'm fine with that approach. > I h

<    1   2   3   4   5   6   7   8   9   10   >