Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Wed, Aug 26, 2020 at 09:33:29AM -0700, David Miller wrote: > From: Mira Ressel > Date: Wed, 26 Aug 2020 16:29:01 + > > > On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: > >> From: Mira Ressel > >> Date: Wed, 26 Aug 2020 15:20:00 +

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: > From: Mira Ressel > Date: Wed, 26 Aug 2020 15:20:00 + > > > I'm setting the peer->perm_addr, which would otherwise be zero, to its > > dev_addr, which has been either generated randomly by the kernel or

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Mon, Aug 24, 2020 at 10:25:45AM -0700, David Miller wrote: > From: Mira Ressel > Date: Mon, 24 Aug 2020 14:38:26 + > > > Set the perm_addr of veth devices to whatever MAC has been assigned to > > the device. Otherwise, it remains all zero,

[PATCH 2/2] vlan: Initialize dev->perm_addr

2020-08-24 Thread Mira Ressel
address. This has the added benefit of giving vlan devices the same link-local address as their parent device, which is common practice, and indeed precisely what happens automatically if the default eui64-based address generation is used. Signed-off-by: Mira Ressel --- net/8021q/vlan_netlink.c | 2

[PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-24 Thread Mira Ressel
link-local address. The new behaviour matches that of several other virtual interface types (such as gre), and as far as I can tell, perm_addr isn't used by any other code sites that are relevant to veth. Signed-off-by: Mira Ressel --- drivers/net/veth.c | 4 1 file changed, 4 insertions