Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test is actually

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test is actually

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-19 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-19 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some cleaning has also been done

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some cleaning has also been done

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-14 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 16:15:00 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch -

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-14 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 16:15:00 +0100 Nadia Derbey [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey [EMAIL PROTECTED] wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch - didn't find

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch - didn't find it in the hot fixes). OK, thanks for checking. Did you confirm that we don't have unneeded code in v

Re: [PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:54 +0100 [EMAIL PROTECTED] wrote: [PATCH 08/08] This patch is the enhancement as asked for by Yasunori: if msgmni is set to a negative value, register it back into the ipcns notifier chain. A new interface has been added to the notification

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:53 +0100 [EMAIL PROTECTED] wrote: [PATCH 07/08] This patch makes msgmni not recomputed anymore upon ipc namespace creation / removal or memory add/remove, as soon as it has been set from userland. As soon as msgmni

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
_PROC_FS=n Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/net/ip_fib.h | 13 - include/net/ipv6.h |6 +++--- 2 files changed, 15 insertions(+), 4 deletions(-) Index: linux-2.6.24-mm1/include/net/ip_fib.h

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
-by: Nadia Derbey [EMAIL PROTECTED] --- include/net/ip_fib.h | 13 - include/net/ipv6.h |6 +++--- 2 files changed, 15 insertions(+), 4 deletions(-) Index: linux-2.6.24-mm1/include/net/ip_fib.h === --- linux-2.6.24-mm1

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:53 +0100 [EMAIL PROTECTED] wrote: [PATCH 07/08] This patch makes msgmni not recomputed anymore upon ipc namespace creation / removal or memory add/remove, as soon as it has been set from userland. As soon as msgmni

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey [EMAIL PROTECTED] wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch - didn't find it in the hot fixes). OK, thanks for checking. Did you confirm that we don't have unneeded code in vmlinux

Re: [PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:54 +0100 [EMAIL PROTECTED] wrote: [PATCH 08/08] This patch is the enhancement as asked for by Yasunori: if msgmni is set to a negative value, register it back into the ipcns notifier chain. A new interface has been added to the notification

[PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-11 Thread Nadia . Derbey
registered. With that new interface we avoid taking care of the states changes in procfs. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h |1 include/linux/notifier.h |4 +++ ipc/ipc_sysctl.c

[PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-11 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24-mm1/ipc/ipc_sy

[PATCH 6/8] Recomputing msgmni on ipc namespace creation/removal

2008-02-11 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h

[PATCH 4/8] Recomputing msgmni on memory add / remove

2008-02-11 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h | 43 - include/linux/memory.h|1 ipc/Ma

[PATCH 5/8] Invoke the ipcns notifier chain as a work item

2008-02-11 Thread Nadia . Derbey
[PATCH 05/08] This patch makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia Derbey

[PATCH 3/8] Defining the slab_memory_callback priority as a constant

2008-02-11 Thread Nadia . Derbey
[PATCH 03/08] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[PATCH 0/8] Change default MSGMNI tunable to scale with lowmem (v3)

2008-02-11 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about being able to turn on/off automatic recomputing. (see message at http://lkml.org/lkml/2008/2/5/149). I actually introduced an intermediate solution: when msgmni is set by hand, it is uneregistered from the ipcns notifier chain (i.e.

[PATCH 2/8] Scaling msgmni to the number of ipc namespaces

2008-02-11 Thread Nadia . Derbey
[PATCH 02/08] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h |1 + ipc

[PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-11 Thread Nadia . Derbey
it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux-2.6.

[PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-11 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24-mm1/ipc/ipc_sysctl.c

[PATCH 6/8] Recomputing msgmni on ipc namespace creation/removal

2008-02-11 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc_namespace.h | 25

[PATCH 4/8] Recomputing msgmni on memory add / remove

2008-02-11 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc_namespace.h | 43 - include/linux/memory.h|1 ipc/Makefile

[PATCH 5/8] Invoke the ipcns notifier chain as a work item

2008-02-11 Thread Nadia . Derbey
[PATCH 05/08] This patch makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia Derbey

[PATCH 0/8] Change default MSGMNI tunable to scale with lowmem (v3)

2008-02-11 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about being able to turn on/off automatic recomputing. (see message at http://lkml.org/lkml/2008/2/5/149). I actually introduced an intermediate solution: when msgmni is set by hand, it is uneregistered from the ipcns notifier chain (i.e.

[PATCH 3/8] Defining the slab_memory_callback priority as a constant

2008-02-11 Thread Nadia . Derbey
[PATCH 03/08] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/memory.h |6 ++ mm/slub.c |2

[PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-11 Thread Nadia . Derbey
registered. With that new interface we avoid taking care of the states changes in procfs. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc_namespace.h |1 include/linux/notifier.h |4 +++ ipc/ipc_sysctl.c | 45

[PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-11 Thread Nadia . Derbey
it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux-2.6.24-mm1/include

[PATCH 2/8] Scaling msgmni to the number of ipc namespaces

2008-02-11 Thread Nadia . Derbey
[PATCH 02/08] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc_namespace.h |1 + ipc/msg.c

[PATCH 2.6.24-mm1] fix build error in arch/x86/mm/pgtable_32.c

2008-02-08 Thread Nadia Derbey
missing argument to pmd_free() calls. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- arch/x86/mm/pgtable_32.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6.24-mm1/arch/x86/mm/pgtabl

[PATCH 2.6.24-mm1] fix build error in arch/x86/mm/pgtable_32.c

2008-02-08 Thread Nadia Derbey
missing argument to pmd_free() calls. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- arch/x86/mm/pgtable_32.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6.24-mm1/arch/x86/mm/pgtable_32.c

Re: [RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-02-05 Thread Nadia Derbey
Yasunori Goto wrote: Thanks Nadia-san. I tested this patch set on my box. It works well. I have only one comment. --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sysctl.c

Re: [RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-02-05 Thread Nadia Derbey
Yasunori Goto wrote: Thanks Nadia-san. I tested this patch set on my box. It works well. I have only one comment. --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sysctl.c

[RFC][PATCH v2 6/7] Recomputing msgmni on ipc namespace creation/removal

2008-01-31 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h

[RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-01-31 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sy

[RFC][PATCH v2 5/7] Invoke the ipcns notifier chain as a work item

2008-01-31 Thread Nadia . Derbey
[PATCH 05/07] This patche makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia Derbey

[RFC][PATCH v2 4/7] Recomputing msgmni on memory add / remove

2008-01-31 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h| 38 ++ include/linux/memory.h |1 ipc/Makefile |3 +

[RFC][PATCH v2 2/7] Scaling msgmni to the number of ipc namespaces

2008-01-31 Thread Nadia . Derbey
[PATCH 02/07] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC][PATCH v2 3/7] Defining the slab_memory_callback priority as a constant

2008-01-31 Thread Nadia . Derbey
[PATCH 03/07] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[RFC][PATCH v2 1/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux-2.6.24/i

[RFC][PATCH v2 0/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about having a single callback on the hotplug memory notifier chain for the ipc subsystem. (see thread at http://lkml.org/lkml/2008/1/14/196). Cc'ing linux-mm since I'm adding a notifier block to the memory hotplug notifier chain. Also, Cc'ing

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
Pierre Peiffer wrote: Nadia Derbey wrote: [EMAIL PROTECTED] wrote: From: Pierre Peiffer <[EMAIL PROTECTED]> semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]> Acked-by: Serge Hallyn <[

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
[EMAIL PROTECTED] wrote: From: Pierre Peiffer <[EMAIL PROTECTED]> semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]> Acked-by: Serge Hallyn <[EMAIL PROTECTED]> --- ipc/sem.c |6 +++--- 1 file changed, 3

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
[EMAIL PROTECTED] wrote: From: Pierre Peiffer [EMAIL PROTECTED] semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer [EMAIL PROTECTED] Acked-by: Serge Hallyn [EMAIL PROTECTED] --- ipc/sem.c |6 +++--- 1 file changed, 3

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
Pierre Peiffer wrote: Nadia Derbey wrote: [EMAIL PROTECTED] wrote: From: Pierre Peiffer [EMAIL PROTECTED] semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer [EMAIL PROTECTED] Acked-by: Serge Hallyn [EMAIL PROTECTED

[RFC][PATCH v2 0/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about having a single callback on the hotplug memory notifier chain for the ipc subsystem. (see thread at http://lkml.org/lkml/2008/1/14/196). Cc'ing linux-mm since I'm adding a notifier block to the memory hotplug notifier chain. Also, Cc'ing

[RFC][PATCH v2 1/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux-2.6.24/include

[RFC][PATCH v2 2/7] Scaling msgmni to the number of ipc namespaces

2008-01-31 Thread Nadia . Derbey
[PATCH 02/07] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h |1 + ipc/msg.c

[RFC][PATCH v2 3/7] Defining the slab_memory_callback priority as a constant

2008-01-31 Thread Nadia . Derbey
[PATCH 03/07] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/memory.h |6 ++ mm/slub.c |2

[RFC][PATCH v2 4/7] Recomputing msgmni on memory add / remove

2008-01-31 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h| 38 ++ include/linux/memory.h |1 ipc/Makefile |3 +- ipc

[RFC][PATCH v2 6/7] Recomputing msgmni on ipc namespace creation/removal

2008-01-31 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h | 25

[RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-01-31 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sysctl.c

[RFC][PATCH v2 5/7] Invoke the ipcns notifier chain as a work item

2008-01-31 Thread Nadia . Derbey
[PATCH 05/07] This patche makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia Derbey

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Resending with the right address for the containers mailing list. So sorry... Nadia Derbey wrote: Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory hotplug notifications, I thought that comments from linux-mm people would be interesting. Also,

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug;

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
I'm realizing that I wrote Andrew's address wrong. So please if ever you're answering in this thread correct his address by hand. Sorry for that! Now if you find it more convenient that I start a new thread with the right address, please tell me and I'll do it. Regards, Nadia -- To

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug; +#endif }; I'm sorry,

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
I'm realizing that I wrote Andrew's address wrong. So please if ever you're answering in this thread correct his address by hand. Sorry for that! Now if you find it more convenient that I start a new thread with the right address, please tell me and I'll do it. Regards, Nadia -- To

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug; +#endif }; I'm sorry,

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug;

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory hotplug notifications, I thought that comments from linux-mm people would be interesting. Also,

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Resending with the right address for the containers mailing list. So sorry... Nadia Derbey wrote: Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory

[RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-14 Thread Nadia . Derbey
is registered into the memory hotplug notifier chain (it is unregistered when the ipc namespace is freed). That routine is then activated when memory is added or removed, in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h

[RFC PATCH 3/4] [RESEND] Defining the slab_memory_callback priority as a constant

2008-01-14 Thread Nadia . Derbey
[PATCH 03/04] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[RFC PATCH 2/4] [RESEND] Scaling msgmni to the number of ipc namespaces

2008-01-14 Thread Nadia . Derbey
[PATCH 02/04] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-14 Thread Nadia . Derbey
Resending the set of patches after Andrew's remark about the fact that we should take the lowmem into account, rather than the total ram. Also, these patches have been enhanced with memory hotplug management. Note: they now have to applied to 2.6.24-rc7. --- On large systems

[RFC PATCH 1/4] [RESEND] Scaling msgmni to the amount of lowmem

2008-01-14 Thread Nadia . Derbey
, but it also defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 +++--- ipc/msg.c

[RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-14 Thread Nadia . Derbey
is registered into the memory hotplug notifier chain (it is unregistered when the ipc namespace is freed). That routine is then activated when memory is added or removed, in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h| 25

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-14 Thread Nadia . Derbey
Resending the set of patches after Andrew's remark about the fact that we should take the lowmem into account, rather than the total ram. Also, these patches have been enhanced with memory hotplug management. Note: they now have to applied to 2.6.24-rc7. --- On large systems

[RFC PATCH 1/4] [RESEND] Scaling msgmni to the amount of lowmem

2008-01-14 Thread Nadia . Derbey
, but it also defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/msg.h | 14 +++--- ipc/msg.c | 44

[RFC PATCH 2/4] [RESEND] Scaling msgmni to the number of ipc namespaces

2008-01-14 Thread Nadia . Derbey
[PATCH 02/04] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h |1 + ipc/msg.c

[RFC PATCH 3/4] [RESEND] Defining the slab_memory_callback priority as a constant

2008-01-14 Thread Nadia . Derbey
[PATCH 03/04] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/memory.h |6 ++ mm/slub.c |2

[RFC PATCH 2/2] Scaling msgmni to the number of ipc namespaces

2007-12-11 Thread Nadia . Derbey
[PATCH 02/02] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC PATCH 1/2] Scaling msgmni to the system memory

2007-12-11 Thread Nadia . Derbey
defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h |6 +++--- ipc/msg.c | 20 ++-- 2

[RFC PATCH 0/2] Change default MSGMNI tunable to scale with system memory

2007-12-11 Thread Nadia . Derbey
On large systems we'd like to allow a larger number of message queues. In some cases up to 32K. However simply setting MSGMNI to a larger value may cause problems for smaller systems. The first patch of this series introduces a default maximum number of message queue ids that scales with the

[RFC PATCH 0/2] Change default MSGMNI tunable to scale with system memory

2007-12-11 Thread Nadia . Derbey
On large systems we'd like to allow a larger number of message queues. In some cases up to 32K. However simply setting MSGMNI to a larger value may cause problems for smaller systems. The first patch of this series introduces a default maximum number of message queue ids that scales with the

[RFC PATCH 2/2] Scaling msgmni to the number of ipc namespaces

2007-12-11 Thread Nadia . Derbey
[PATCH 02/02] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/ipc.h |1 + ipc/msg.c

[RFC PATCH 1/2] Scaling msgmni to the system memory

2007-12-11 Thread Nadia . Derbey
defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- include/linux/msg.h |6 +++--- ipc/msg.c | 20 ++-- 2 files

Re: [2.6 patch] make ipc/util.c:sysvipc_find_ipc() static

2007-10-25 Thread Nadia Derbey
_t pos, + loff_t *new_pos) { struct kern_ipc_perm *ipc; int total, id; Acked-by: Nadia Derbey <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [2.6 patch] make ipc/util.c:sysvipc_find_ipc() static

2007-10-25 Thread Nadia Derbey
, + loff_t *new_pos) { struct kern_ipc_perm *ipc; int total, id; Acked-by: Nadia Derbey [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: what is the rationale for "TAINT_USER"?

2007-10-12 Thread Nadia Derbey
Robert P. J. Day wrote: i can see what the theoretical purpose for it is here: http://kerneltrap.org/node/6656 but it's not clear how it can possibly be set from userland given that: $ grep -r TAINT_USER * include/linux/kernel.h:#define TAINT_USER (1<<6)

Re: what is the rationale for TAINT_USER?

2007-10-12 Thread Nadia Derbey
Robert P. J. Day wrote: i can see what the theoretical purpose for it is here: http://kerneltrap.org/node/6656 but it's not clear how it can possibly be set from userland given that: $ grep -r TAINT_USER * include/linux/kernel.h:#define TAINT_USER (16) kernel/panic.c:

Re: [RFC][PATCH -mm] IPC: fix error checking in all new xxx_lock() functions

2007-10-11 Thread Nadia Derbey
Pierre Peiffer wrote: In the new implementation of the [sem|shm|msg]_lock[_check]() routines, we use the return value of ipc_lock() in container_of() without any check. But ipc_lock may return a errcode. The use of this errcode in container_of() may alter this errcode, and we don't want this.

Re: [PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-11 Thread Nadia Derbey
Pierre Peiffer wrote: With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1. does not

Re: [PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-11 Thread Nadia Derbey
Pierre Peiffer wrote: With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1. does not

Re: [RFC][PATCH -mm] IPC: fix error checking in all new xxx_lock() functions

2007-10-11 Thread Nadia Derbey
Pierre Peiffer wrote: In the new implementation of the [sem|shm|msg]_lock[_check]() routines, we use the return value of ipc_lock() in container_of() without any check. But ipc_lock may return a errcode. The use of this errcode in container_of() may alter this errcode, and we don't want this.

  1   2   3   >