2013/4/23, Andrew Morton :
> On Thu, 18 Apr 2013 22:54:15 +0900 Namjae Jeon
> wrote:
>
>> Change Log:
>> v5: change to avoid compilation warning:
>> fs/fat/inode.c: In function 'fat_zero_falloc_area':
>> >> fs/fat/inode.c:169:11: warning: com
2013/4/23, Kent Overstreet :
> On Sat, Apr 20, 2013 at 01:40:02AM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
>> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
>> (block:
2013/4/19, Neil Armstrong :
> Since eMMC 4.3 a special boot mode operation was introduced to retrieve
> data from the eMMC device with a very simple procedure. Since the Linux
> kernel exports these device boot partitions, it may be useful to select
> the boot partition from the user space.
>
> The
2013/4/22, Jaegeuk Kim :
> 2013-04-20 (토), 01:27 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> Adding REQ_META for all the metadata requests can help in improving the
>> FS performance, if the underlying device supports TAGGING.
>> So, when considering the
2013/4/21 James Bottomley :
> On Sat, 2013-04-20 at 01:40 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
>> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
>> (block: add plug for
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, there is possibility that request's __data_len
field may overflow when max_discard_sectors greater than UINT_MAX >> 9
If multiple discard requests get merged, merged discard request's
size excee
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, it has been oberved that few drivers are
setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9)
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there
From: Namjae Jeon
linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
(block: add plug for blkdev_issue_discard )
For example,
1) DISCARD rq-1 with size size 4GB
2) DISCARD rq-2 with size size 1GB
If these 2 discard requests
From: Namjae Jeon
Add tracepoints to debug the various page write operation
like data pages, meta pages.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
---
fs/f2fs/checkpoint.c|2 +
fs/f2fs/data.c |2 +
fs/f2fs/segment.c
From: Namjae Jeon
Add tracepoints to debug checkpoint request.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
---
fs/f2fs/checkpoint.c|4
include/trace/events/f2fs.h | 22 ++
2 files changed, 26 insertions(+)
diff
From: Namjae Jeon
Add tracepoints for tracing the garbage collector
threads in f2fs with status of collection & type.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
---
fs/f2fs/gc.c|2 ++
include/trace/events/f2fs.h |
From: Namjae Jeon
Add tracepoints to debug the block allocation & fallocate.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
---
fs/f2fs/data.c |1 +
fs/f2fs/file.c |6 -
include/trace/events/f2fs.h |
From: Namjae Jeon
add tracepoints for tracing the truncate operations
like truncate node/data blocks, f2fs_truncate etc.
Tracepoints are added at entry and exit of operation
to trace the success & failure of operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: St
From: Namjae Jeon
Add tracepoints for page i/o operations and block allocation
tracing during page read operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
---
fs/f2fs/data.c | 16 +--
include/trace/events/f2fs.h | 63
From: Namjae Jeon
Add tracepoints in f2fs for tracing the syncing
operations like filesystem sync, file sync enter/exit.
It will helf to trace the code under debugging scenarios.
Also add tracepoints for tracing the various inode operations
like building inode, eviction of inode, link/unlike of
From: Namjae Jeon
Add tracepoints in f2fs filesystem for tracing the filesystem
operations for information/debugging purpose if needed. All the
tracepoints are clubbed with respect to functionalities.
Change Log:
v4: Modified the tracepoints as per the review comments of
Jaegeuk Kim. Following
From: Namjae Jeon
Adding REQ_META for all the metadata requests can help in improving the
FS performance, if the underlying device supports TAGGING.
So, when considering the submit_bio path for all the f2fs requests. We can
add REQ_META for all the META requests.
As a precursor to this change we
From: Namjae Jeon
The code conditions put inside the function is_multimedia_file are
reverse to the name i.e, we need to negate the return to actually
check if the file is a multimedia file. So, change the code and usage
path to align both the name and comparision conditions.
Signed-off-by
From: Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions.
Change Log:
v5: change to avoid compilation warning:
fs/fat/inode.c: In function 'fat_zero_falloc_area':
>> fs/fat/inode.c:169:11: warning: comparison of distinct pointer
types lacks a
2013/4/15, Adrian Hunter :
> On 13/04/13 16:38, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> https://lkml.org/lkml/2013/4/1/292
>> As per above discussion, there is possibility that request's __data_len
>> field may overflow when max_discard_sectors greate
From: Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions.
Change Log:
v4: Rework based on review comments.
Add check in fat_setattr to release fallocated blocks on a truncate
v3: Release preallocated blocks at file release.
With FALLOC_FL_KEEP_SIZE, there is no
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, there is possibility that request's __data_len
field may overflow when max_discard_sectors greater than UINT_MAX >> 9
If multiple discard requests get merged, merged discard request's
size excee
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, it has been oberved that few drivers are
setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9)
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there
From: Namjae Jeon
linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
(block: add plug for blkdev_issue_discard )
For example,
1) DISCARD rq-1 with size size 4GB
2) DISCARD rq-2 with size size 1GB
If these 2 discard requests
y: Wei Yongjun
Acked-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ping ?
2013/4/6 Namjae Jeon :
> From: Namjae Jeon
>
> Fix typo mistakes.
> 1. I think that it should be 'L' instead of 'V'.
> 2. and try to fix 'Front' instead of 'Frone'
>
> Signed-off-by: Namjae Jeon
> Signed-off-by: Amit Sah
2013/4/9 Jens Axboe :
> On Sun, Mar 31 2013, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> Add the documentation text for latency, target_latency & group_idle
>> tunnable parameters in the block/cfq-iosched.txt.
>> Also fix few typo(spelling) mistakes.
>
2013/4/9 Jaegeuk Kim :
> 2013-04-09 (화), 10:04 +0900, Namjae Jeon:
>> 2013/4/9, Steven Rostedt :
>> > On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote:
>> >> From: Namjae Jeon
>> >>
>> >> Add tracepoints in f2fs filesystem for tracing the
2013/4/9, Jason Hrycay :
> From: Jason Hrycay
>
> Move the f2fs_balance_fs out of the truncate_hole function and only
> perform that in punch_hole use case. The commit:
>
> ed60b1644e7f7e5dd67d21caf7e4425dff05dad0
>
> intended to do this but moved it into truncate_hole to cover more
> cases. H
2013/4/9, Steven Rostedt :
> On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> Add tracepoints in f2fs filesystem for tracing the filesystem
>> operations for information/debugging purpose if needed. All the
>> tracepoints are clubbe
2013/4/7, Max Filippov :
> On Sun, Apr 7, 2013 at 4:36 AM, Namjae Jeon wrote:
>>
>>
>> 2013/4/6 Max Filippov
>>>
>>> Hi Namjae,
>>>
>>> On Fri, Apr 5, 2013 at 11:57 AM, Namjae Jeon
>>> wrote:
>>> > Hi. Max.
>>&g
From: Namjae Jeon
Add tracepoints to debug checkpoint request.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|1 +
include/trace/events/f2fs.h | 18 ++
2 files changed, 19 insertions(+)
diff --git a/fs/f2fs/checkpoint.c b/fs
From: Namjae Jeon
Add tracepoints to debug the various page write operation
like data pages, meta pages.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|2 ++
fs/f2fs/data.c |2 ++
include/trace/events/f2fs.h | 62
From: Namjae Jeon
Add tracepoints to debug the block allocation & fallocate.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c |1 +
fs/f2fs/file.c |3 ++
include/trace/events/f2fs.h |
From: Namjae Jeon
Add tracepoints for tracing the garbage collector
threads in f2fs with status of collection & type.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/gc.c|2 ++
include/trace/events/f2fs.h | 20
2 files changed
From: Namjae Jeon
add tracepoints for tracing the truncate operations
like truncate node/data blocks, f2fs_truncate etc.
Tracepoints are added at entry and exit of operation
to trace the success & failure of operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/
From: Namjae Jeon
Add tracepoints for page i/o operations and block allocation
tracing during page read operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c |9 ++-
include/trace/events/f2fs.h | 61
From: Namjae Jeon
Add tracepoints in f2fs for tracing the syncing
operations like filesystem sync, file sync enter/exit.
It will helf to trace the code under debugging scenarios.
Also add tracepoints for tracing the various inode operations
like building inode, eviction of inode, link/unlink of
From: Namjae Jeon
Add tracepoints in f2fs filesystem for tracing the filesystem
operations for information/debugging purpose if needed. All the
tracepoints are clubbed with respect to functionalities.
Change Log:
v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
condition page
From: Namjae Jeon
Fix typo mistakes.
1. I think that it should be 'L' instead of 'V'.
2. and try to fix 'Front' instead of 'Frone'
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/data.c|2 +-
fs/f2fs/segment.h |2
Hi. Max.
I have a question.
Your mmc host driver set to host->max_discard_to by some value instead
of not zero ?
Thanks.
2013/4/5, Max Filippov :
> On Fri, Apr 5, 2013 at 5:53 AM, Shaohua Li wrote:
>> On Thu, Apr 04, 2013 at 06:00:18AM +0400, Max Filippov wrote:
>
> [...]
>
>>> the commit 0cfbc
as uptodate,
>
> 1. grab_cache_page locks the page,
> 2. read_node_page unlocks the page, and
> 3. lock_page is called for further process.
>
> Let's avoid this.
>
> Signed-off-by: Jaegeuk Kim
Yes, Looks good!
Reviewed-by: Namjae Jeon
Thanks.
> ---
--
To unsubscrib
addition, the victims are able to be selected by foreground GCs,
> since
>there is no need to read victim blocks during foreground GCs.
>
>By the fact that the foreground GC reclaims segments in a section
> unit, it'd
> be better to manage this bitmap based on the se
2013/4/1, Jaegeuk Kim :
> When allocating a new segment under the LFS mode, we should keep the
> section
> boundary.
>
> Signed-off-by: Jaegeuk Kim
You can add
Reviewed-by: Namjae Jeon
Thanks!
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-k
uk Kim
Looks good!
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2013/4/1, Jaegeuk Kim :
> In get_node_page, we do not need to call lock_page all the time.
>
> If the node page is cached as uptodate,
>
> 1. grab_cache_page locks the page,
> 2. read_node_page unlocks the page, and
> 3. lock_page is called for further process.
>
> Let's avoid this.
Instead of remo
2013/4/1, Jaegeuk Kim :
> The foreground GCs are triggered under not enough free sections.
> So, we should not skip moving valid blocks in the victim segments.
>
> Signed-off-by: Jaegeuk Kim
Looks good to me~
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: s
write_checkpoint(sbi, false);
> - else
> + mutex_unlock(&sbi->gc_mutex);
> + } else {
> f2fs_balance_fs(sbi);
> + }
We can remove { } of else because single line code is used.
Reviewed-by: Namjae Jeon
Thanks.
>
> r
2013/4/1, Jaegeuk Kim :
> This patch removes a bitmap for victim segments selected by foreground GC,
> and
> modifies the other bitmap for victim segments selected by background GC.
>
> 1) foreground GC bitmap
> : We don't need to manage this, since we just only one previous victim
> section
>
333f68127097c4fa1eda4b3913a22
>
> This patch adds a NULL pointer check in f2fs_write_data_pages() to
> avoid
> a possible NULL pointer dereference, in case if -
> mapping->a_ops->writepage -
> is NULL.
Yes, I agree. Looks better!
Reviewed-by: Namjae Jeon
Thanks.
>
>
2013/4/1, Jaegeuk Kim :
> A macro should not use duplicate parameter names.
>
> Signed-off-by: Jaegeuk Kim
Looks reasonable to me ~
Reviewed-by: Namjae Jeon
Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
2013/4/1, Jaegeuk Kim :
> Let's use a macro to get the total number of sections.
>
> Signed-off-by: Jaegeuk Kim
Looks reasonable to me~
Reviewed-by: Namjae Jeon
Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
types.
>
> So, this patch eliminates this inconsistency.
>
> Signed-off-by: Jaegeuk Kim
Looks good to me~
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Namjae Jeon
Add the documentation text for latency, target_latency & group_idle
tunnable parameters in the block/cfq-iosched.txt.
Also fix few typo(spelling) mistakes.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
Documentation/block/cfq-iosched.txt |
From: Namjae Jeon
In case of embedded devices, where /etc/ is mounted as 'read-only'.
We donot have the /etc/mtab file. So, checking if the device is already
mounted from this file is not sufficient.
Try to read /proc/mounts in case of failure from /etc/mtab.
Issue logs:
/dev/sdb4 /m
From: Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions.
Change Log:
v4: Rework based on review comments.
Add check in fat_setattr to release fallocated blocks on a truncate
v3: Release preallocated blocks at file release.
With FALLOC_FL_KEEP_SIZE, there is no
2013/3/28, Alexandru Gheorghiu :
> Use kmemdup instead of kzalloc and memcpy.
>
> Signed-off-by: Alexandru Gheorghiu
Looks good to me.
Acked-by: Namjae Jeon
Thanks~
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord
2013/3/28, Alexandru Gheorghiu :
> Used kmemdup instead of kzalloc and memcpy.
>
> Signed-off-by: Alexandru Gheorghiu
> ---
> fs/f2fs/node.c| 11 ---
> fs/f2fs/segment.c |3 +--
> 2 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
>
2013/3/28, Alexandru Gheorghiu :
> Used kmemdup instead of kzalloc followed by memcpy.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu
> ---
> fs/f2fs/segment.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment
> */
> -static inline void set_cold_file(struct f2fs_sb_info *sbi, struct inode
> *inode,
> +static inline void set_cold_files(struct f2fs_sb_info *sbi, struct inode
> *inode,
> const unsigned char *name)
> {
> int i;
> @@ -108,7 +109,7 @@ static inline void set_cold_file(str
2013/3/27, Jaegeuk Kim :
> 2013-03-27 (수), 09:57 +0900, Namjae Jeon:
>> 2013/3/27, Jaegeuk Kim :
>> > 2013-03-26 (화), 09:48 +0900, Namjae Jeon:
>> >> 2013/3/25, Jaegeuk Kim :
>> >> > This patch removes data_version check flow during the fsync call
2013/3/27, Jaegeuk Kim :
> 2013-03-26 (화), 09:48 +0900, Namjae Jeon:
>> 2013/3/25, Jaegeuk Kim :
>> > This patch removes data_version check flow during the fsync call.
>> > The original purpose for the use of data_version was to avoid writng
>> > inode
>&
entry
> miss.
> In order to avoid this, we don't need to drop the nat cache entry at this
> moment.
>
> Signed-off-by: Jaegeuk Kim
Looks good to me.
Reviewed-by: Namjae Jeon
Thanks~
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
2013/3/25, Jaegeuk Kim :
> This patch removes data_version check flow during the fsync call.
> The original purpose for the use of data_version was to avoid writng inode
> pages redundantly by the fsync calls repeatedly.
Hi Jaegeuk.
> However, when user can modify file meta and then call fsync, we
2013/3/25, Jaegeuk Kim :
> 2013-03-25 (월), 15:30 +0900, Namjae Jeon:
>> 2013/3/25, Jaegeuk Kim :
>> > We should handle errors during the recovery flow correctly.
>> > For example, if we get -ENOMEM, we should report a mount failure instead
>> > of
>>
2013/3/25, Jaegeuk Kim :
> We should handle errors during the recovery flow correctly.
> For example, if we get -ENOMEM, we should report a mount failure instead of
> conducting the remained mount procedure.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/f2fs.h | 2 +-
> fs/f2fs/recovery.c |
2013/3/19, Masanari Iida :
> Correct spelling typo in comments
>
> Signed-off-by: Masanari Iida
Acked-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
2013/3/19, Jaegeuk Kim :
> 2013-03-19 (화), 13:54 +0900, Namjae Jeon:
>> >
>> > - err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC);
>> > - if (err) {
>> > - f2fs_put_page(page, 1);
>> > - re
ned-off-by: Jaegeuk Kim
Looks good to me.
Reviewed-by: Namjae Jeon
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
>
> - err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC);
> - if (err) {
> - f2fs_put_page(page, 1);
> - return ERR_PTR(err);
> + if (PageUptodate(page)) {
> + unlock_page(page);
> + return page;
> }
> - unlock_page(page)
2013/3/18, Jaegeuk Kim :
> 2013-03-18 (월), 20:39 +0900, Namjae Jeon:
>> 2013/3/18, Jaegeuk Kim :
>> > If the return value of releasepage is equal to zero, the page cannot be
>> > reclaimed.
>> > Instead, we should return 1 in order to reclaim clean pages.
2013/3/18, Jaegeuk Kim :
> 2013-03-17 (일), 17:27 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> we can remove nid_free from new inode allocation part.
>> Since, nid_free is used to check if we need to free alloced nid
>> in case of failure.
>> Instead we
2013/3/18, James Bottomley :
> On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> Introduce msgbyte and statusbyte in the prints as part of the
>> result which is returned by the lower layer driver in response to
>> SCSI com
2013/3/18, Jaegeuk Kim :
> If the return value of releasepage is equal to zero, the page cannot be
> reclaimed.
> Instead, we should return 1 in order to reclaim clean pages.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/data.c | 4 +++-
> fs/f2fs/node.c | 13 +++--
> 2 files changed, 6
de_page with zero.
>
> Signed-off-by: Jaegeuk Kim
Reviewed-by: Namjae Jeon
Looks good to me~
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
2013/3/18, Jaegeuk Kim :
> The fsync call should be ended after flushing the in-device caches.
>
> Signed-off-by: Jaegeuk Kim
Reviewed-by: Namjae Jeon
Looks good!
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
2013/3/18, Jaegeuk Kim :
> 2013-03-18 (월), 18:29 +0900, Namjae Jeon:
>> 2013/3/18, Jaegeuk Kim :
>> > The build_free_nid should not add free nids over nm_i->max_nid.
>> > But, there was a hole that invalid free nid was added by the following
>> > scenario
2013/3/18, Jaegeuk Kim :
> The build_free_nid should not add free nids over nm_i->max_nid.
> But, there was a hole that invalid free nid was added by the following
> scenario.
>
> Let's suppose nm_i->max_nid = 150 and the last NAT page has 100 ~ 200 nids.
>
> build_free_nids
> - get_current_nat_p
2013/3/18, Jaegeuk Kim :
> 2013-03-17 (일), 17:27 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> In function check_nid_range, there is no need to trigger BUG_ON and make
>> kernel stop.
>> Instead it could just check and indicate the inode number to be EIN
2013/3/17, Steven Rostedt :
> On Sun, 2013-03-17 at 17:40 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> Add tracepoints for page i/o operations and block allocation
>> tracing during page read operation.
>>
>> Signed-off-by: Namjae Jeon
>> Si
From: Namjae Jeon
Add tracepoints to debug the various page write operation
like data pages, meta pages.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|2 ++
fs/f2fs/data.c |2 ++
include/trace/events/f2fs.h | 62
From: Namjae Jeon
Add tracepoints to debug the block allocation and fallocate.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c |1 +
fs/f2fs/file.c |3 ++
include/trace/events/f2fs.h | 76
From: Namjae Jeon
Add tracepoints for tracing the garbage collector
threads in f2fs with status of collection & type.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/gc.c|2 ++
include/trace/events/f2fs.h | 20
2 files changed
From: Namjae Jeon
Add tracepoints to debug checkpoint request.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|1 +
include/trace/events/f2fs.h | 18 ++
2 files changed, 19 insertions(+)
diff --git a/fs/f2fs/checkpoint.c b/fs
From: Namjae Jeon
Add tracepoints in f2fs for tracing the syncing
operations like filesystem sync, file sync enter/exit.
It will helf to trace the code under debugging scenarios.
Also add tracepoints for tracing the various inode operations
like building inode, eviction of inode, link/unlike of
From: Namjae Jeon
add tracepoints for tracing the truncate operations
like truncate node/data blocks, f2fs_truncate etc.
Tracepoints are added at entry and exit of operation
to trace the success & failure of operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/
From: Namjae Jeon
Add tracepoints for page i/o operations and block allocation
tracing during page read operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c | 11 ++--
include/trace/events/f2fs.h | 58
501 - 600 of 972 matches
Mail list logo
