From: Namjae Jeon
Add tracepoints in f2fs filesystem for tracing the filesystem
operations for information/debugging purpose if needed. All the
tracepoints are clubbed with respect to functionalities.
Namjae Jeon(7):
f2fs: add tracepoints for sync operations and inode operations
f2fs: add
From: Namjae Jeon
Introduce msgbyte and statusbyte in the prints as part of the
result which is returned by the lower layer driver in response to
SCSI command issued, in case of any error conditions.
Purpose of adding these prints is to convey, during any I/O
error case, which condition exactly
From: Namjae Jeon
In function check_nid_range, there is no need to trigger BUG_ON and make kernel
stop.
Instead it could just check and indicate the inode number to be EINVAL.
Update the return path in do_read_inode to use the return from check_nid_range.
Signed-off-by: Namjae Jeon
Signed-off
From: Namjae Jeon
we can remove nid_free from new inode allocation part.
Since, nid_free is used to check if we need to free alloced nid
in case of failure.
Instead we can directly call alloc_nid_failed from that point, as
there is no dependency in that path.
Signed-off-by: Namjae Jeon
Signed
From: Namjae Jeon
validate super block is not returning with proper values.
When failure from sb_bread it should reflect there is an EIO otherwise
it should return of EINVAL.
Returning, '1' is not conveying proper message as the return type.
Signed-off-by: Namjae Jeon
Signed-of
From: Namjae Jeon
make use of F2FS_NAME_LEN for name length checking,
change return conditions at few places, by assigning
storing the errorvalue in 'error' and making a common
exit path.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/xattr.c | 18 ++-
From: Namjae Jeon
Change f2fs so that a warning is emitted when an attempt is made to
mount a filesystem with the unsupported discard option.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/super.c |9 +
1 file changed, 9 insertions(+)
diff --git a/fs/f2fs
2013/3/14, Sergey Yanovich :
> MMC hosts are added asynchronously. We need to wait until detect returns to
> avoid failed root filesystem mounts.
> ---8<---
> VFS: Cannot open root device "mmcblk0p1" or unknown-block(0,0): error -6
> Please append a correct "root=" boot option; here are the availab
2013/3/12, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>> If so, probably, I didn't clear my opinion/suggestion, or misled
>>> you. Sorry about it.
>>>
>>> My opinion/suggestion is, "it should be before umount()".
>>> I.e. fallocate
2013/3/12, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>> This choose ->release(). BTW, we would also be able to do this only
>>> ->evict_inode(), although I'm not thinking yet which one is better.
>>>
>>> If you had conclusion, it would be nic
2013/3/9, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> static int fat_file_release(struct inode *inode, struct file *filp)
>> {
>> +struct super_block *sb = inode->i_sb;
>> +loff_t mmu_private_ideal = (inode->i_size + (sb->s_blocksize-1)) &am
Hi. Andrew.
>>
>> static int fat_file_release(struct inode *inode, struct file *filp)
>> {
>> +struct super_block *sb = inode->i_sb;
>> +loff_t mmu_private_ideal = (inode->i_size + (sb->s_blocksize-1)) &
>> +~(sb->s_blocksize-1);
>
> Stylistically, it looks
2013/3/8, Jaegeuk Kim :
> 2013-03-04 (월), 15:25 +0900, Namjae Jeon:
>> 2013/3/3, Jaegeuk Kim :
>> > We should not change the on-disk layout.
>> > Instead, simply we can deal with it by changing original condition
>> > check
>> > like below.
>>
&
2013/3/8, Jaegeuk Kim :
> 2013-03-04 (월), 15:10 +0900, Namjae Jeon:
>> 2013/3/3, Jaegeuk Kim :
>> > 2013-03-02 (토), 12:41 +0900, Namjae Jeon:
>> >> From: Namjae Jeon
>> >>
>> >> Actual dirty of pages will occur in f2fs_delete_entry
From: Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions.
Change Log:
v3: Release preallocated blocks at file release.
With FALLOC_FL_KEEP_SIZE, there is no way to distinguish if the mismatch
between i_size and no. of clusters allocated is a consequence of
2013/3/2, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> From: Namjae Jeon
>>
>> This patch set eliminates the client side ESTALE errors when a FAT
>> partition
>> exported over NFS has it's dentries evicted from the cache. The idea is
>> to
>> f
ux-fsde...@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-f2fs-de...@lists.sourceforge.net
>
> The maximum filename length supported in linux is 255 characters.
> So let's follow that.
>
> Signed-off-by: Namjae Jeon
> Signed-off-by: Amit Sahrawat
> Signed-off-by
2013/3/3, Jaegeuk Kim :
> 2013-03-02 (토), 12:41 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> Actual dirty of pages will occur in f2fs_delete_entry so move the
>> f2fs_balance_fs just before deletion.
>>
>> Signed-off-by: Namjae Jeon
>> Signed-off-
From: Namjae Jeon
Add descriptions about 'stale_rw' and 'nostale_ro' nfs options in
filesystem/vfat.txt
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
Documentation/filesystems/vfat.txt | 26 +-
From: Namjae Jeon
If the cache lookups fail,use the i_pos value to find the
directory entry of the inode and rebuild the inode.Since this
involves accessing the FAT media, do this only if the nostale_ro nfs
mount option is specified.
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
From: Namjae Jeon
This patch enables rebuilding of directory inodes which are not present
in the cache.This is done by traversing the disk clusters to find the
directory entry of the parent directory and using its i_pos to build the
inode.
The traversal is done by fat_scan_logstart() which is
From: Namjae Jeon
Define two nfs export_operation structures,one for 'stale_rw' mounts and
the other for 'nostale_ro'. The latter uses i_pos as a basis for encoding
and decoding file handles.
Also, assign i_pos to kstat->ino. The logic for rebuilding the inode is
added in
From: Namjae Jeon
Introduce helper function to get the block number and offset for a given
i_pos value. Use it in __fat_write_inode() now and later on in nfs.c
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
fs/fat/fat.h |7 +++
fs/fat
From: Namjae Jeon
Move fat_i_pos_read to fat.h so that it can be called from nfs.c in the
subsequent patches to encode the file handle.
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
fs/fat/fat.h | 14 ++
fs/fat/inode.c | 14
From: Namjae Jeon
Provide two possible values 'stale_rw' and 'nostale_ro' for
the -o nfs mount option.The first one allows all file operations but
does not reduce ESTALE errors on memory constrained systems. The second
one eliminates ESTALE errors but mounts the filesyst
From: Namjae Jeon
This patch set eliminates the client side ESTALE errors when a FAT partition
exported over NFS has it's dentries evicted from the cache. The idea is to
find the on-disk location_'i_pos' of the dirent of the inode that has been
evicted and use it to rebuild the
From: Namjae Jeon
In all the breaking conditions in get_node_path, 'n' is used to
track index in offset[] array, but while breaking out also, in all
paths n++ is done.
So, remove the ++ from breaking paths. Also, avoid
reset of 'level=0' in first case.
Signed-off-by: Namjae
From: Namjae Jeon
Since, maximum filename length supported in linux is 255 characters.
So, there is no need to reserve space for 256 characters in f2fs inode.
This aligns the filename length to NFS requests also which also
has a default limit of '255'.
Signed-off-by: Namjae Jeon
Sig
From: Namjae Jeon
Optimize and change return path in lookup_free_nid_list
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/node.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index e275218..e24f747 100644
From: Namjae Jeon
Actual dirty of pages will occur in f2fs_delete_entry so move the
f2fs_balance_fs just before deletion.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/namei.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/namei.c b
From: Namjae Jeon
Instead of checking for victim_segmap(FG_GC) OR
(gc_type == BG_GC) && victim_segmap(BG_GC);
to continue for the victim selection. The 2 conditions
can simply be merged and decision can directly be made using 'gc_type'.
Signed-off-by: Namjae Jeon
Signed-off
2013/2/27, Jaegeuk Kim :
> 2013-02-26 (화), 20:52 +0900, Namjae Jeon:
>> > @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn,
>> > pgoff_t
>> > index, int ro)
>> >alloc_nid_done(sbi, nids[i]);
>> >
2013/2/27, Jaegeuk Kim :
> Hi,
>
> 2013-02-26 (화), 18:35 +0900, Namjae Jeon:
>> 2013/2/26, Jaegeuk Kim :
>> > It must be set READ_SYNC not READA.
>> Hi Jaegeuk.
>> Could you please elaborate more?
>> Why we need to change READA to READ_SYNC over here, whe
> @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn, pgoff_t
> index, int ro)
> alloc_nid_done(sbi, nids[i]);
> mutex_unlock_op(sbi, NODE_NEW);
> done = true;
> - } else if (ro && i == level && level > 1)
2013/2/26, Jaegeuk Kim :
> It must be set READ_SYNC not READA.
Hi Jaegeuk.
Could you please elaborate more?
Why we need to change READA to READ_SYNC over here, when the purpose
was to read the node page in READ ahead mode.
Thanks.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/node.c | 2 +-
> 1
2013/2/19 Steven Rostedt :
> On Tue, 2013-02-19 at 11:33 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>
>> +TRACE_EVENT(f2fs_unlink_exit,
>> + TP_PROTO(struct dentry *dentry, int ret),
>> +
>> + TP_ARGS(dentry, ret),
>> +
>> + TP_STR
From: Namjae Jeon
Add tracepoints to debug checkpoint request.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|1 +
include/trace/events/f2fs.h | 18 ++
2 files changed, 19 insertions(+)
diff --git a/fs/f2fs/checkpoint.c b/fs
From: Namjae Jeon
Add tracepoints to debug the various page write operation
like data pages, meta pages.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/checkpoint.c|2 ++
fs/f2fs/data.c |2 ++
include/trace/events/f2fs.h | 62
From: Namjae Jeon
Add tracepoints for tracing the garbage collector
threads in f2fs.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/gc.c|2 ++
include/trace/events/f2fs.h | 20
2 files changed, 22 insertions(+)
diff --git a/fs
From: Namjae Jeon
Add tracepoints to debug the block allocation and fallocate.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c |1 +
fs/f2fs/file.c |3 ++
include/trace/events/f2fs.h | 76
From: Namjae Jeon
Add tracepoints for page i/o operations and block allocation
tracing during page read operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/data.c | 10 ++-
include/trace/events/f2fs.h | 68
From: Namjae Jeon
Add tracepoints for tracing the truncate operations
like truncate node/data blocks, f2fs_truncate etc.
Tracepoints are added at entry and exit of operation
to trace the success & failure of operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/
From: Namjae Jeon
Add tracepoints for tracing the various inode operations
like building inode, eviction of inode, link/unlike of
inodes.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/inode.c |3 ++
fs/f2fs/namei.c |3 ++
include/trace
From: Namjae Jeon
Add tracepoints in f2fs for tracing the syncing
operations like filesystem sync, file sync enter/exit.
It will helf to trace the code under debugging scenarios.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
---
fs/f2fs/file.c |3 ++
fs/f2fs/super.c
From: Namjae Jeon
Add tracepoints in f2fs filesystem for tracing the filesystem
operations for information/debugging purpose if needed. All the
tracepoints are clubbed with respect to functionalities.
Namjae Jeon(8):
f2fs: add tracepoints for sync operations
f2fs: add tracepoints for
2013/2/18 OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>> Hm. My concerns are compatibility and reliability. Although We can
>>> change on-disk format if need, but I don't think it can be compatible
>>> and reliable. If so, who wants to use it? I feel there is n
2013/2/18 OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>>> + if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) {
>>>> + *lenp = FAT_FID_SIZE_WITH_PARENT;
>>>> + return 255;
>>>> + } else
2013/2/18 OGAWA Hirofumi :
> Andrew Bartlett writes:
>
>>> >> First, Thanks for your interest !
>>> >> A mismatch between inode size and reserved blocks can be either due to
>>> >> pre-allocation (after our changes) or due to corruption (sudden unplug
>>> >> of media etc).
>>> >> We don’t think it
2013/2/18 OGAWA Hirofumi :
> OGAWA Hirofumi writes:
>
>>> +if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) {
>>> +*lenp = FAT_FID_SIZE_WITH_PARENT;
>>> +return 255;
>>> +} else if (len < FAT_FID_SIZE_WITHOUT_PARENT) {
>>> +*lenp = FAT_FID_SIZE_WITHOUT_PA
2013/2/18 OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> + if (MSDOS_SB(inode->i_sb)->options.nfs == FAT_NFS_NOSTALE_RO) {
>> + if (inode->i_ino == MSDOS_ROOT_INO)
>> + stat->ino = MSDOS_ROOT_INO;
>
> Can we simply set i_p
2013/2/18 OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> -nfs -- This option maintains an index (cache) of directory
>> - inodes by i_logstart which is used by the nfs-related code to
>> - improve look-ups.
>> +nfs= stale_rw|nostale_
From: Namjae Jeon
This patch is a follow up on below patch:
[PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63
Signed-off-by: Namjae Jeon
Signed-off-by: Vivek Trivedi
Acked-by: Steven Whitehouse
Acked-by: Sage Weil
---
fs
[snip]
>> >
>> > Thanks,
>> Hi Andrew.
>>
>> First, Thanks for your interest !
>> A mismatch between inode size and reserved blocks can be either due to
>> pre-allocation (after our changes) or due to corruption (sudden unplug
>> of media etc).
>> We don’t think it is right to include only read onl
2013/2/14, Andrew Bartlett :
> (apologies for the duplicate mail, I typo-ed the maintainers address)
>
> G'day,
>
> I've been looking into the patch "[v2] fat: editions to support
> fat_fallocate()" and I wonder if there is a way we can split this issue
> in two, so that we get at least some of the
2013/2/12, Dave Chinner :
> On Mon, Feb 11, 2013 at 05:25:58PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> This patch is a follow up on below patch:
>>
>> [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
>> commit: 216b6cbdcbd86b1d
From: Namjae Jeon
This patch is a follow up on below patch:
[PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63
Signed-off-by: Namjae Jeon
Signed-off-by: Vivek Trivedi
Acked-by: Steven Whitehouse
---
fs/btrfs/export.c |4
From: Namjae Jeon
Add descriptions about 'stale_rw' and 'nostale_ro' nfs options in
filesystem/vfat.txt
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
Documentation/filesystems/vfat.txt | 26 +-
From: Namjae Jeon
This patch enables rebuilding of directory inodes which are not present
in the cache.This is done by traversing the disk clusters to find the
directory entry of the parent directory and using its i_pos to build the
inode.
The traversal is done by fat_scan_logstart() which is
From: Namjae Jeon
If the cache lookups fail,use the i_pos value to find the
directory entry of the inode and rebuild the inode.Since this
involves accessing the FAT media, do this only if the nostale_ro nfs
mount option is specified.
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
From: Namjae Jeon
Define two nfs export_operation structures,one for 'stale_rw' mounts and
the other for 'nostale_ro'.The latter uses i_pos as a basis for encoding
and decoding file handles.
Also, assign i_pos to kstat->ino.The logic for rebuilding the inode is
added in
From: Namjae Jeon
Move fat_i_pos_read to fat.h so that it can be called from nfs.c in the
subsequent patches to encode the file handle.
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
fs/fat/fat.h | 14 ++
fs/fat/inode.c | 14
From: Namjae Jeon
Introduce helper function to get the block number and offset for a given
i_pos value. Use it in __fat_write_inode() now and later on in nfs.c
Signed-off-by: Namjae Jeon
Signed-off-by: Ravishankar N
Signed-off-by: Amit Sahrawat
---
fs/fat/fat.h |7 +++
fs/fat
From: Namjae Jeon
This patch set eliminates the client side ESTALE errors when a FAT partition
exported over NFS has it's dentries evicted from the cache. The idea is to
find the on-disk location_'i_pos' of the dirent of the inode that has been
evicted and use it to rebuild the
From: Namjae Jeon
Provide two possible values 'stale_rw' and 'nostale_ro' for
the -o nfs mount option.The first one allows all file operations but
does not reduce ESTALE errors on memory constrained systems. The second
one eliminates ESTALE errors but mounts the filesyst
2013/2/8, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>> And did this work correctly about f_pos for readdir?
>> Yes, sure. f_pos is work correctly about each directory entry. because
>> after name[0] == 0x00, there are no allocated directory entires.
>>>
>
2013/2/7, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> From: Namjae Jeon
>>
>> When doing lookups via fat_search_long(), we can stop checking for
>> further entries if we detect End of Directory, i.e. if (de->name[0] ==
>> 0x00).The current code traverses t
Hello.
I am considering the following subjects on f2fs. I'm not sure if it is
proper TOPIC.
Let me know opinions :)
1. Dynamic Control of GC Thread at User Level.
To cope with rapid increase in number of smart phone users and
increasing demands for different media application with Quality Of
Serv
2013/2/6, Jaegeuk Kim :
> Hi,
>
> How about this?
>
> 2013-02-05 (화), 23:24 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> After the commit 2184ad190a79ae2b40b5f5db1fbde5c22db6d310, it allowed
>> for naming GC threads based on the device.
>> i.e., if
From: Namjae Jeon
After the commit 2184ad190a79ae2b40b5f5db1fbde5c22db6d310, it allowed
for naming GC threads based on the device.
i.e., if we have F2FS formatted partition in different devices - we will
have their GC thread names after the device. But, when we have a case like
2 or more
2013/2/5, Namjae Jeon :
> 2013/2/5, Jaegeuk Kim :
>> Hi,
>>
>> 2013-02-05 (화), 14:28 +0900, Namjae Jeon:
>>> Hi Jaegeuk.
>>>
>>> Oops!, I was missing include header.
>>> Sorry, I will send v2 patch again.
>>
>> I got a bui
2013/2/5, Jaegeuk Kim :
> Hi,
>
> 2013-02-05 (화), 14:28 +0900, Namjae Jeon:
>> Hi Jaegeuk.
>>
>> Oops!, I was missing include header.
>> Sorry, I will send v2 patch again.
>
> I got a build error, and simply added the following header file in your
> p
Hi Jaegeuk.
Oops!, I was missing include header.
Sorry, I will send v2 patch again.
Thanks.
2013/2/4, Namjae Jeon :
> From: Namjae Jeon
>
> adding compat_ioctl to provide support for backward comptability - 32bit
> binary
> execution on 64bit kernel.
>
> Signed-off-by:
From: Namjae Jeon
When doing lookups via fat_search_long(), we can stop checking for
further entries if we detect End of Directory, i.e. if (de->name[0] ==
0x00).The current code traverses the cluster chain of a directory until a hit
is found or till the last cluster for that directory, ignor
From: Namjae Jeon
adding compat_ioctl to provide support for backward comptability - 32bit binary
execution on 64bit kernel.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/f2fs.h | 15 +++
fs/f2fs/file.c | 20
2 files changed, 35
2013/2/4, Jan Kara :
> On Sat 02-02-13 15:21:09, Namjae Jeon wrote:
>> Hi. Jan.
>>
>> Sorry for interrupt.
>> Have you taken this patch to your tree ? I can not find it..
>> or Is there any issue regarding this patch ?
> I had it in my tree but not in th
2013/2/4, Jaegeuk Kim :
> Hi,
>
> 2013-02-02 (토), 23:51 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> We can remove the call to find_get_page to get a page from the cache
>> and check for up-to-date, instead we can make use of grab_cache_page
>> part
on check and balance_fs
>
> 1. If f2fs is mounted with background_gc_off option, checking
> BG_GC is not redundant.
> 2. f2fs_balance_fs is checked in f2fs_gc, so this is also redundant.
>
> Signed-off-by: Changman Lee
> Signed-off-by: Namjae Jeon
> Signed-off-by: Ami
From: Namjae Jeon
Introduce accessor to get the sections based upon the block type
(node,dents...) and modify the functions : should_do_checkpoint,
has_not_enough_free_secs to use this accessor function to get
the node sections and dent sections.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit
From: Namjae Jeon
Instead of evaluating the free_sections and then deciding to return
true/false from that path. We can directly use the evaluation condition
for returning proper value.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/segment.h |6 ++
1 file
From: Namjae Jeon
Currently GC task is started for each f2fs formatted/mounted device.
But, when we check the task list, using 'ps', there is no distinguishing
factor between the tasks. So, name the task as per the block device just
like the flusher threads.
Also, remove the macro GC_T
From: Namjae Jeon
When gc thread creatio failed, mark gc_thread as NULL to avoid
crash while trying to stop invalid thread in
stop_gc_thread->kthread_stop.
Instead make it return from:
if (!gc_th)
return;
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/g
From: Namjae Jeon
When GC thread is running continously there is no need to call
f2fs_balance_fs unconditinally for garbage collection, instead
the garbage collection will be taken via. calling f2fs_gc in the
thread. So, we can move out the balance out of thread loop and
make it run initially
From: Namjae Jeon
We can remove the call to find_get_page to get a page from the cache
and check for up-to-date, instead we can make use of grab_cache_page
part itself to fetch the page from the cache.
So, removing the call and moving the PageUptodate at proper place, also
taken care of moving
Hi. Jan.
Sorry for interrupt.
Have you taken this patch to your tree ? I can not find it..
or Is there any issue regarding this patch ?
Thanks!
2013/1/22, Namjae Jeon :
> 2013/1/22, Jan Kara :
>> On Tue 22-01-13 09:45:09, Namjae Jeon wrote:
>>> 2013/1/21, Jan Kara :
>&g
2013/1/31, Jaegeuk Kim :
> 2013-01-30 (수), 22:47 +0900, Namjae Jeon:
>> From: Namjae Jeon
>>
>> After doing a write_checkpoint from garbage collection path if there is
>> still
>> need to do more garbage collection, gc_more label is used to jump and
>>
From: Namjae Jeon
In f2fs_inode_info structure, the description for data_version
has a typo mistake. It should be latest instead of lastes.
So, correcting that.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/f2fs.h |2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Namjae Jeon
We can remove unneeded label unlock_out, avoid unnecessary jump
and reorganize the returning conditions in this function.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/f2fs/node.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
From: Namjae Jeon
After doing a write_checkpoint from garbage collection path if there is still
need to do more garbage collection, gc_more label is used to jump and start
the process again. And in that process, first step before getting victim is to
check if there are not enough free sections
2013/1/28, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>>> Although checking several routines to check hang case you said, I
>>>> didn't find anything.
>>>> And There is no any race on test result also. Am I missing something ?
>>>> Let
2013/1/26, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> 2013/1/20, OGAWA Hirofumi :
>>> Namjae Jeon writes:
>>>
>>>> We rewrite patch as your suggestion using dummy inode. Would please
>>>> you review below patch code ?
>>>
>>
2013/1/22, Jan Kara :
> On Tue 22-01-13 09:45:09, Namjae Jeon wrote:
>> 2013/1/21, Jan Kara :
>> > @@ -,6 +2219,8 @@ int udf_read_extent_cache(struct inode *inode,
>> > loff_t
>> > bcount,
>> >*lbcount = iinfo->cached_e
2013/1/20, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> We rewrite patch as your suggestion using dummy inode. Would please
>> you review below patch code ?
>
> Looks like good as initial. Clean and shorter.
>
> Next is, we have to think about race. I.e. if real inod
2013/1/21, Jan Kara :
> On Sat 19-01-13 11:17:14, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> This patch implements extent caching in case of file reading.
>> While reading a file, currently, UDF reads metadata serially
>> which takes a lot of time depending
2013/1/21, Dan Carpenter :
> I sometimes write little user space programs to help me check my
> work. I've attached one.
>
> gcc test.c
> ./a.out
>
> regards,
> dan carpenter
>
Hi Dan.
Thanks for testcase. I understand fully.
list_for_each still use pos after removing pos in loop. So, we need to
u
2013/1/21, Jaegeuk Kim :
> 2013-01-21 (월), 00:32 -0800, Dmitry Torokhov:
>> On Sun, Jan 20, 2013 at 06:02:58PM +0300, Dan Carpenter wrote:
>> > This is calling list_del() inside a loop which is a problem when we try
>> > move to the next item on the list. I've converted it to use the _safe
>> > ve
2013/1/21, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> 2013/1/20, OGAWA Hirofumi :
>>> Namjae Jeon writes:
>>>
>>>> From: Namjae Jeon
>>>>
>>>> When searching a directory for names, we can stop checking for further
>>>
2013/1/20, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> From: Namjae Jeon
>>
>> When searching a directory for names, we can stop checking for further
>> entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The
>> current code traverses the c
2013/1/19, Cong Ding :
> On Sat, Jan 19, 2013 at 11:17:14AM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> This patch implements extent caching in case of file reading.
>> While reading a file, currently, UDF reads metadata serially
>> which takes a lot o
2013/1/21, Dan Carpenter :
> This is calling list_del() inside a loop which is a problem when we try
> move to the next item on the list. I've converted it to use the _safe
> version. And also, as a cleanup, I've converted it to use
> list_for_each_entry instead of list_for_each.
>
Hi Dan.
I can'
From: Namjae Jeon
When searching a directory for names, we can stop checking for further
entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The
current code traverses the cluster chain of a directory until a hit is
found or till the last cluster for that directory, ignoring
601 - 700 of 972 matches
Mail list logo
