Re: [PATCH 10/15] drivers/scsi/csiostor/csio_lnode.c: adjust duplicate test

2013-01-22 Thread Naresh Kumar Inna
> /* New VN-Port */ > spin_unlock_irq(>lock); > - csio_lnode_alloc(hw); > + ln = csio_lnode_alloc(hw); > spin_lock_irq(>lock); > if (!ln) { >

Re: [PATCH 10/15] drivers/scsi/csiostor/csio_lnode.c: adjust duplicate test

2013-01-22 Thread Naresh Kumar Inna
); + ln = csio_lnode_alloc(hw); spin_lock_irq(hw-lock); if (!ln) { csio_err(hw, -- Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] [SCSI] csiostor: Don't leak mem or fail to release firmware in csio_hw_flash_config()

2012-12-28 Thread Naresh Kumar Inna
mtype = FW_PARAMS_PARAM_Y_GET(*fw_cfg_param); > maddr = FW_PARAMS_PARAM_Z_GET(*fw_cfg_param) << 16; > @@ -2149,9 +2152,9 @@ csio_hw_flash_config(struct csio_hw *hw, u32 > *fw_cfg_param, char *path) > strncpy(path, "/lib/firmware/" CSIO_CF_FNAME, 64); >

Re: [PATCH] [SCSI] csiostor: Don't leak mem or fail to release firmware in csio_hw_flash_config()

2012-12-28 Thread Naresh Kumar Inna
*fw_cfg_param, char *path) strncpy(path, /lib/firmware/ CSIO_CF_FNAME, 64); } +leave: kfree(cfg_data); release_firmware(cf); - return ret; } Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list

Re: [patch] [SCSI] csiostor: remove unneeded memset()

2012-11-28 Thread Naresh Kumar Inna
+ 3) & ~3; /* should be multiple of 4 bytes */ > ae->len = htons(len); > - memset(ae->value, 0, len - 4); > memcpy(ae->value, val, len); > *ptr += len; > } > Acked-by: Naresh Kumar Inna Thanks, Naresh. -- To unsubscribe from this list: send

Re: [patch] [SCSI] csiostor: remove unneeded memset()

2012-11-28 Thread Naresh Kumar Inna
be multiple of 4 bytes */ ae-len = htons(len); - memset(ae-value, 0, len - 4); memcpy(ae-value, val, len); *ptr += len; } Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body