Re: [PATCH] PCI: Add quirk to initialize REG_BASE_ADDR to 0 for Broadcom TIGON3 chips.

2013-12-10 Thread Natarajan Gurumoorthy
Looks like we are going to abandon this patch and go with the original one line fix to drivers/net/ethenet/broadcom/tg3.c. Nat On Mon, Dec 9, 2013 at 4:32 PM, Bjorn Helgaas wrote: > On Mon, Dec 9, 2013 at 4:57 PM, Nat Gurumoorthy wrote: >> The new tg3 driver leaves REG_BASE_ADDR (PCI config

Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0

2013-12-10 Thread Natarajan Gurumoorthy
Michael, The only time I see crashes is after the tg3 driver has been loaded into the system. I our use case we are poking around /sys/devices/pci//config. I guess you will incorporate the original patch into the driver and we can abandon this patch. Regards Nat On Mon,

Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0

2013-12-10 Thread Natarajan Gurumoorthy
Michael, The only time I see crashes is after the tg3 driver has been loaded into the system. I our use case we are poking around /sys/devices/pci//config. I guess you will incorporate the original patch into the driver and we can abandon this patch. Regards Nat On Mon,

Re: [PATCH] PCI: Add quirk to initialize REG_BASE_ADDR to 0 for Broadcom TIGON3 chips.

2013-12-10 Thread Natarajan Gurumoorthy
Looks like we are going to abandon this patch and go with the original one line fix to drivers/net/ethenet/broadcom/tg3.c. Nat On Mon, Dec 9, 2013 at 4:32 PM, Bjorn Helgaas bhelg...@google.com wrote: On Mon, Dec 9, 2013 at 4:57 PM, Nat Gurumoorthy n...@google.com wrote: The new tg3 driver

Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0

2013-12-09 Thread Natarajan Gurumoorthy
Michael, We had crashes when the PCI config space got scanned via /sys/devices/pci/../config. I agree that this fix will not help if the scan happens before the tg3 driver gets loaded. Regards Nat On Mon, Dec 9, 2013 at 11:00 AM, Michael Chan wrote: > On Mon, 2013-12-09 at 10:43

Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0

2013-12-09 Thread Natarajan Gurumoorthy
Michael, We had crashes when the PCI config space got scanned via /sys/devices/pci/../config. I agree that this fix will not help if the scan happens before the tg3 driver gets loaded. Regards Nat On Mon, Dec 9, 2013 at 11:00 AM, Michael Chan mc...@broadcom.com wrote: On Mon,