Re: [PATCH 0/5] improve i2c probing

2005-08-19 Thread Nathan Lutchansky
On Thu, 18 Aug 2005, Greg KH wrote: > On Mon, Aug 15, 2005 at 01:51:06PM -0400, Nathan Lutchansky wrote: > > This patch series makes a couple of improvements to the i2c device > > probing process. > > > > These all generally look quite good, thanks. But it looks li

Re: [RFC][PATCH 2.6.13-rc6] add Dell Systems Management Base Driver (dcdbas) with sysfs support

2005-08-15 Thread Nathan Lutchansky
On Mon, Aug 15, 2005 at 10:10:28PM -0500, Michael E Brown wrote: > On Mon, 2005-08-15 at 21:29 -0400, Kyle Moffett wrote: > > On Aug 15, 2005, at 18:58:56, [EMAIL PROTECTED] wrote: > > >> Why can't you just implement the system management actions in > > >> the kernel driver? This is tantamount to

Re: [PATCH 4/5] add i2c_probe_device and i2c_remove_device

2005-08-15 Thread Nathan Lutchansky
On Tue, Aug 16, 2005 at 12:14:13AM +0200, Jean Delvare wrote: > > These functions can be used for special-purpose adapters, such as > > those on TV tuner cards, where we generally know in advance what > > devices are attached. This is important in cases where the adapter > > does not support probi

Re: [PATCH 1/5] call i2c_probe from i2c core

2005-08-15 Thread Nathan Lutchansky
On Mon, Aug 15, 2005 at 11:55:31PM +0200, Jean Delvare wrote: > You should probably be using the --no-index option of quilt 0.42 (if you > are using quilt as I presumed), as I heard Linus doesn't like these > index lines in the patches he receives. Ooh, thanks! > > if (driver->flags & I2C_DF_

Re: [PATCH 0/5] improve i2c probing

2005-08-15 Thread Nathan Lutchansky
On Mon, Aug 15, 2005 at 11:39:58PM +0200, Jean Delvare wrote: > > The second improvement (which is really the point of this patch set) > > is to add the functions i2c_probe_device and i2c_remove_device for > > directly creating and destroying i2c clients on a particular adapter: > > > > int i2

[PATCH 4/5] add i2c_probe_device and i2c_remove_device

2005-08-15 Thread Nathan Lutchansky
is important in cases where the adapter does not support probing or when probing is potentially dangerous to the connected devices. Signed-off-by: Nathan Lutchansky <[EMAIL PROTECTED]> drivers/i2c/i2c-core.c | 71 + include/linux/i2c.h

[PATCH 3/5] remove attach_adapter from misc i2c chip drivers

2005-08-15 Thread Nathan Lutchansky
The attach_adapter callback of most misc i2c chip drivers can be removed, now that the i2c core will implicitly call i2c_probe if the address data is present in the i2c_driver structure. Signed-off-by: Nathan Lutchansky <[EMAIL PROTECTED]> drivers/i2c/chips/ds1337.c |9 ++--- d

[PATCH 5/5] new flag to disable i2c probing for an adapter

2005-08-15 Thread Nathan Lutchansky
function to attach new clients. Signed-off-by: Nathan Lutchansky <[EMAIL PROTECTED]> drivers/i2c/i2c-core.c |3 +++ include/linux/i2c.h|4 2 files changed, 7 insertions(+) Index: linux-2.6.13-rc6+gregkh/drivers/i2c/i2c-

[PATCH 1/5] call i2c_probe from i2c core

2005-08-15 Thread Nathan Lutchansky
attach_adapter callback will still be called if it is present, but this makes it unnecessary for almost all in-tree i2c drivers. Signed-off-by: Nathan Lutchansky <[EMAIL PROTECTED]> Documentation/i2c/writing-clients | 58 -- drivers/i2c/i2c-

[PATCH 2/5] remove attach_adapter from i2c hwmon drivers

2005-08-15 Thread Nathan Lutchansky
The attach_adapter callback of every i2c hwmon driver can be removed, now that the i2c core will implicitly call i2c_probe if the address data is present in the i2c_driver structure. Signed-off-by: Nathan Lutchansky <[EMAIL PROTECTED]> drivers/hwmon/adm1021.c | 12 +++- d

[PATCH 0/5] improve i2c probing

2005-08-15 Thread Nathan Lutchansky
Hi everyone, This patch series makes a couple of improvements to the i2c device probing process. Currently, when a new i2c bus needs to be probed, the i2c subsystem calls the attach_adapter callback for each loaded i2c client driver, which must call the i2c_probe function with a list of addresses