[PATCH v12 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-04-20 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso Reviewed-by: Steven Price --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too

[PATCH v12 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-04-20 Thread Nicolas Boichat
on those GPUs. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso Reviewed-by: Steven Price --- (no changes since v9) Changes in v9: - Explain why devfreq needs to be disabled for GPUs with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: -

[PATCH v12 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-04-20 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v12 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-04-20 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat --- Changes in v12: - binding: Fix min/maxItems logic (Rob Herring) Changes in v11: - binding: power-domain-names not power-domainS-names Changes in v10: - Fix the binding

[PATCH v12 0/4] drm/panfrost: Add support for mt8183 GPU

2021-04-20 Thread Nicolas Boichat
omains. Changes in v2: - Use sram instead of mali_sram as SRAM supply name. - Rename mali@ to gpu@. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 d

Re: [PATCH v11 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-04-20 Thread Nicolas Boichat
On Tue, Apr 20, 2021 at 9:01 PM Rob Herring wrote: > > On Mon, Jan 25, 2021 at 7:18 PM Nicolas Boichat wrote: > > > > Define a compatible string for the Mali Bifrost GPU found in > > Mediatek's MT8183 SoCs. > > > > Signed-off-by: Nicolas Boichat > >

Re: [PATCH v11 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-04-20 Thread Nicolas Boichat
On Tue, Apr 20, 2021 at 11:33 PM Neil Armstrong wrote: > > On 26/01/2021 02:17, Nicolas Boichat wrote: > > Add a basic GPU node for mt8183. > > > > Signed-off-by: Nicolas Boichat > > --- > > The binding we use with out-of-tree Mali drivers includes more

Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings

2021-04-14 Thread Nicolas Boichat
On Wed, Apr 14, 2021 at 10:46 PM wrote: > > From: Matthias Brugger > > The dsi children don't have any reg property, Confused, see below. > so we don't need address and > size cells. This makes dtbs_check happy. > > CC: Hsin-Yi Wang > CC: Enric Balletbo i S

Re: [PATCH v8] vfs: fix copy_file_range regression in cross-fs copies

2021-04-08 Thread Nicolas Boichat
On Wed, Feb 24, 2021 at 6:44 PM Nicolas Boichat wrote: > > On Wed, Feb 24, 2021 at 6:22 PM Luis Henriques wrote: > > > > On Tue, Feb 23, 2021 at 08:00:54PM -0500, Olga Kornievskaia wrote: > > > On Mon, Feb 22, 2021 at 5:25 AM Luis Henriques wrote: > > > >

[for-stable-4.19 PATCH v2 2/2] lkdtm: don't move ctors to .rodata

2021-03-19 Thread Nicolas Boichat
-Hartman Cc: Kees Cook Acked-by: Kees Cook Signed-off-by: Mark Rutland Link: https://lore.kernel.org/r/20201207170533.10738-1-mark.rutl...@arm.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Nicolas Boichat --- (no changes since v1) drivers/misc/lkdtm/Makefile | 2 +- drivers/misc/lkdtm

[for-stable-4.19 PATCH v2 1/2] vmlinux.lds.h: Create section for protection against instrumentation

2021-03-19 Thread Nicolas Boichat
ute userspace with macro definitions"). We take the minimal approach here and just guard the new macro. Minor context conflicts in: arch/powerpc/kernel/vmlinux.lds.S include/asm-generic/vmlinux.lds.h include/linux/compiler.h] Signed-off-by: Nicolas Boichat --- Te

[for-stable-4.19 PATCH v2 0/2] Backport patches to fix KASAN+LKDTM with recent clang on ARM64

2021-03-19 Thread Nicolas Boichat
Backport 2 patches that are required to make KASAN+LKDTM work with recent clang (patch 2/2 has a complete description). Tested on our chromeos-4.19 branch. Also compile tested on x86-64 and arm64 with gcc this time around. Patch 1/2 adds a guard around noinstr that matches upstream, to prevent a

Re: [for-stable-4.19 PATCH 1/2] vmlinux.lds.h: Create section for protection against instrumentation

2021-03-19 Thread Nicolas Boichat
On Fri, Mar 19, 2021 at 7:55 PM Greg Kroah-Hartman wrote: > > On Fri, Mar 19, 2021 at 12:20:22PM +0100, Alexandre Chartre wrote: > > > > On 3/19/21 11:39 AM, Greg Kroah-Hartman wrote: > > > On Fri, Mar 19, 2021 at 07:54:15AM +0800, Nicolas Boichat wrote: &g

[for-stable-4.19 PATCH 2/2] lkdtm: don't move ctors to .rodata

2021-03-18 Thread Nicolas Boichat
-Hartman Cc: Kees Cook Acked-by: Kees Cook Signed-off-by: Mark Rutland Link: https://lore.kernel.org/r/20201207170533.10738-1-mark.rutl...@arm.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Nicolas Boichat --- drivers/misc/lkdtm/Makefile | 2 +- drivers/misc/lkdtm/rodata.c | 2 +- 2

[for-stable-4.19 PATCH 1/2] vmlinux.lds.h: Create section for protection against instrumentation

2021-03-18 Thread Nicolas Boichat
: context conflicts in: arch/powerpc/kernel/vmlinux.lds.S include/asm-generic/vmlinux.lds.h include/linux/compiler.h include/linux/compiler_types.h] Signed-off-by: Nicolas Boichat --- arch/powerpc/kernel/vmlinux.lds.S | 1 + include/asm-generic/sections.h| 3

[for-stable-4.19 PATCH 0/2] Backport patches to fix KASAN+LKDTM with recent clang on ARM64

2021-03-18 Thread Nicolas Boichat
Backport 2 patches that are required to make KASAN+LKDTM work with recent clang (patch 2/2 has a complete description). Tested on our chromeos-4.19 branch. Patch 1/2 is context conflict only, and 2/2 is a clean backport. These patches have been merged to 5.4 stable already. We might need to

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-03-03 Thread Nicolas Boichat
On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > On Thu, Feb 11, 2021 at 4:34 AM Nicolas Boichat wrote: > > > Many of the DSI flags have names opposite to their actual effects, > > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > > be disa

Re: [PATCH v8] vfs: fix copy_file_range regression in cross-fs copies

2021-02-24 Thread Nicolas Boichat
On Wed, Feb 24, 2021 at 6:22 PM Luis Henriques wrote: > > On Tue, Feb 23, 2021 at 08:00:54PM -0500, Olga Kornievskaia wrote: > > On Mon, Feb 22, 2021 at 5:25 AM Luis Henriques wrote: > > > > > > A regression has been reported by Nicolas Boichat, found while u

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-22 Thread Nicolas Boichat
On Mon, Feb 22, 2021 at 3:21 PM Andrzej Hajda wrote: > > Hi Nicolas, > > W dniu 22.02.2021 o 06:31, Nicolas Boichat pisze: > > On Mon, Feb 22, 2021 at 3:08 AM Laurent Pinchart > > wrote: > >> Hi Nicolas, > >> > >> Thank you for the patch.

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-21 Thread Nicolas Boichat
On Mon, Feb 22, 2021 at 3:08 AM Laurent Pinchart wrote: > > Hi Nicolas, > > Thank you for the patch. > > On Thu, Feb 11, 2021 at 11:33:55AM +0800, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects, > > e.g. MIPI_DSI_MODE_EOT

Re: [PATCH v7] vfs: fix copy_file_range regression in cross-fs copies

2021-02-21 Thread Nicolas Boichat
On Mon, Feb 22, 2021 at 3:57 AM Luis Henriques wrote: > > A regression has been reported by Nicolas Boichat, found while using the > copy_file_range syscall to copy a tracefs file. Before commit > 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the > k

Re: [PATCH v3] vfs: fix copy_file_range regression in cross-fs copies

2021-02-17 Thread Nicolas Boichat
On Thu, Feb 18, 2021 at 1:25 AM Luis Henriques wrote: > > A regression has been reported by Nicolas Boichat, found while using the > copy_file_range syscall to copy a tracefs file. Before commit > 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the > k

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Nicolas Boichat
On Mon, Feb 15, 2021 at 11:42 PM Luis Henriques wrote: > > Nicolas Boichat reported an issue when trying to use the copy_file_range > syscall on a tracefs file. It failed silently because the file content is > generated on-the-fly (reporting a size of zero) and copy_file_range nee

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-14 Thread Nicolas Boichat
On Mon, Feb 15, 2021 at 9:12 AM Ian Lance Taylor wrote: > > On Sun, Feb 14, 2021 at 4:38 PM Dave Chinner wrote: > > > > On Fri, Feb 12, 2021 at 03:54:48PM -0800, Darrick J. Wong wrote: > > > On Sat, Feb 13, 2021 at 10:27:26AM +1100, Dave Chinner wrote: > > > > > > > If you can't tell from

Re: [v2,2/3] thermal: mediatek: Add LVTS drivers for SoC theraml zones

2021-02-13 Thread Nicolas Boichat
On Fri, Jan 29, 2021 at 5:40 PM Michael Kao wrote: > > Add a LVTS (Low voltage thermal sensor) driver to report junction > temperatures in Mediatek SoC and register the maximum temperature > of sensors and each sensor as a thermal zone. > > Signed-off-by: Yu-Chia Chang > Signed-off-by: Michael

Re: [PATCH v3 1/3] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid

2021-02-13 Thread Nicolas Boichat
+Pi-Hsun Shih On Mon, Feb 8, 2021 at 9:42 AM Jitao Shi wrote: > > Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid. > > Signed-off-by: Jitao Shi I believe this patch (and the following) were actually authored by Pi-Hsun: https://crrev.com/c/2628812 . Would be best to keep the

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Nicolas Boichat
On Fri, Feb 12, 2021 at 3:46 PM Greg KH wrote: > > On Fri, Feb 12, 2021 at 12:44:00PM +0800, Nicolas Boichat wrote: > > Filesystems such as procfs and sysfs generate their content at > > runtime. This implies the file sizes do not usually match the > > amount of da

Re: [PATCH 6/6] vfs: Disallow copy_file_range on generated file systems

2021-02-11 Thread Nicolas Boichat
On Fri, Feb 12, 2021 at 12:59 PM Darrick J. Wong wrote: > > On Thu, Feb 11, 2021 at 08:53:47PM -0800, Darrick J. Wong wrote: > > On Fri, Feb 12, 2021 at 12:44:05PM +0800, Nicolas Boichat wrote: > > > copy_file_range (which calls generic_copy_file_checks) uses the > >

Re: [PATCH] fs: generic_copy_file_checks: Do not adjust count based on file size

2021-02-11 Thread Nicolas Boichat
On Thu, Jan 28, 2021 at 1:57 PM Darrick J. Wong wrote: > > On Thu, Jan 28, 2021 at 08:46:04AM +0800, Nicolas Boichat wrote: [snip] > > Okay, so, based on this and Al's reply, I see 2 things we can do: > > 1. Go should probably not use copy_file_range in a common library > &

[PATCH 6/6] vfs: Disallow copy_file_range on generated file systems

2021-02-11 Thread Nicolas Boichat
already present to handle older kernels). Signed-off-by: Nicolas Boichat --- fs/read_write.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/read_write.c b/fs/read_write.c index 0029ff2b0ca8..80322e89fb0a 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1485,6 +1485,9 @@ ssize_t

[PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-11 Thread Nicolas Boichat
such filesystems. Signed-off-by: Nicolas Boichat --- I first thought of adding a new field to struct file_operations, but that doesn't quite scale as every single file creation operation would need to be modified. include/linux/fs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fs.h b

[PATCH 2/6] proc: Add FS_GENERATED_CONTENT to filesystem flags

2021-02-11 Thread Nicolas Boichat
procfs content is generated at runtime. Signed-off-by: Nicolas Boichat --- fs/proc/root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/root.c b/fs/proc/root.c index c7e3b1350ef8..7ed715a0f807 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c @@ -282,7 +282,7

[PATCH 5/6] tracefs: Add FS_GENERATED_CONTENT to filesystem flags

2021-02-11 Thread Nicolas Boichat
tracefs content is generated at runtime. Signed-off-by: Nicolas Boichat --- fs/tracefs/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index 4b83cbded559..89980312c7a3 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -308,6 +308,7

[PATCH 4/6] debugfs: Add FS_GENERATED_CONTENT to filesystem flags

2021-02-11 Thread Nicolas Boichat
debugfs content is generated at runtime. Signed-off-by: Nicolas Boichat --- fs/debugfs/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index c35249497b9b..2bbc5e6d3041 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -279,6 +279,7

[PATCH 3/6] sysfs: Add FS_GENERATED_CONTENT to filesystem flags

2021-02-11 Thread Nicolas Boichat
sysfs content is generated at runtime. Signed-off-by: Nicolas Boichat --- fs/sysfs/mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index e747c135c1d1..7e367ae5edc1 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c @@ -91,7

[PATCH 0/6] Add generated flag to filesystem struct to block copy_file_range

2021-02-11 Thread Nicolas Boichat
https://lkml.org/lkml/2021/1/26/1736 Nicolas Boichat (6): fs: Add flag to file_system_type to indicate content is generated proc: Add FS_GENERATED_CONTENT to filesystem flags sysfs: Add FS_GENERATED_CONTENT to filesystem flags debugfs: Add FS_GENERATED_CONTENT to filesystem flags tracef

[PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-10 Thread Nicolas Boichat
Many of the DSI flags have names opposite to their actual effects, e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually be disabled. Fix this by including _NO_ in the flag names, e.g. MIPI_DSI_MODE_NO_EOT_PACKET. Signed-off-by: Nicolas Boichat --- I considered adding _DISABLE_

Re: [PATCH v4 03/22] media: camss: Replace trace_printk() with dev_dbg()

2021-02-05 Thread Nicolas Boichat
ality. > > Signed-off-by: Robert Foss > Suggested-by: Nicolas Boichat Thanks! Reviewed-by: Nicolas Boichat > --- > > Changes since v3: > - Nicolas: Create this patch > > > drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- > drivers/media/platform/q

Re: [PATCH v11 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-02-05 Thread Nicolas Boichat
On Sat, Feb 6, 2021 at 1:55 AM Rob Herring wrote: > > On Tue, 26 Jan 2021 09:17:56 +0800, Nicolas Boichat wrote: > > Define a compatible string for the Mali Bifrost GPU found in > > Mediatek's MT8183 SoCs. > > > > Signed-off-by: Nicolas Boichat > > --- &g

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > Hi Xin, > > Thanks for the patch. > > On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > > > Enable DSI EOTP feature for fixing some panel screen constance > > shift issue. > > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > >

Re: [BUG] copy_file_range with sysfs file as input

2021-02-03 Thread Nicolas Boichat
On Wed, Feb 3, 2021 at 5:04 PM Greg KH wrote: > > On Mon, Jan 25, 2021 at 03:54:31PM +0800, Nicolas Boichat wrote: > > Hi copy_file_range experts, > > > > We hit this interesting issue when upgrading Go compiler from 1.13 to > > 1.15 [1]. Basically we use Go's

Re: [PATCH] drm/mediatek: fine tune the data lane trail by project dts

2021-02-02 Thread Nicolas Boichat
On Mon, Feb 1, 2021 at 11:48 AM Jitao Shi wrote: > > Some panels or bridges require customized hs_da_trail time. > So add a property in devicetree for this panels and bridges. Since this changes the device tree, you also need to upload a binding document change. > > Signed-off-by: Jitao Shi >

Re: [PATCH v5 6/8] regulator: mt6359: Add support for MT6359 regulator

2021-01-28 Thread Nicolas Boichat
On Fri, Jan 22, 2021 at 7:27 PM Hsin-Hsiung Wang wrote: > > From: Wen Su > > The MT6359 is a regulator found on boards based on MediaTek MT6779 and > probably other SoCs. It is a so called pmic and connects as a slave to > SoC using SPI, wrapped inside the pmic-wrapper. > > Signed-off-by: Wen Su

Re: [PATCH] fs: generic_copy_file_checks: Do not adjust count based on file size

2021-01-27 Thread Nicolas Boichat
On Wed, Jan 27, 2021 at 7:38 AM Dave Chinner wrote: > > On Tue, Jan 26, 2021 at 01:50:22PM +0800, Nicolas Boichat wrote: > > copy_file_range (which calls generic_copy_file_checks) uses the > > inode file size to adjust the copy count parameter. This breaks > > with special

Re: [PATCH v3 05/22] media: camss: Refactor VFE HW version support

2021-01-27 Thread Nicolas Boichat
On Wed, Jan 27, 2021 at 10:56 PM Robert Foss wrote: > > In order to support Qualcomm ISP hardware architectures that diverge > from older architectures, the VFE subdevice driver needs to be refactored > to better abstract the different ISP architectures. > > Gen1 represents the CAMSS ISP

[PATCH] fs: generic_copy_file_checks: Do not adjust count based on file size

2021-01-26 Thread Nicolas Boichat
Fixes: 96e6e8f4a68d ("vfs: add missing checks to copy_file_range") Signed-off-by: Nicolas Boichat --- This can be reproduced with this simple test case: #define _GNU_SOURCE #include #include #include #include #include int main(int argc, char **argv) { int fd_in, fd

Re: [BUG] copy_file_range with sysfs file as input

2021-01-26 Thread Nicolas Boichat
On Tue, Jan 26, 2021 at 9:34 AM Dave Chinner wrote: > > On Mon, Jan 25, 2021 at 03:54:31PM +0800, Nicolas Boichat wrote: > > Hi copy_file_range experts, > > > > We hit this interesting issue when upgrading Go compiler from 1.13 to > > 1.15 [1]. Basically we use Go's

Re: [PATCH v10 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-26 Thread Nicolas Boichat
On Tue, Jan 26, 2021 at 3:27 AM Rob Herring wrote: > [...] > > + { > > + supply-names = "mali", "sram"; > > Not a documented property, nor should it be. > > Did you run this against dtbs_check with your schema changes? I did not, for some reasons I hit a strange issue (kernel build system

[PATCH v11 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-26 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v11 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-26 Thread Nicolas Boichat
on those GPUs. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso Reviewed-by: Steven Price --- Changes in v11: None Changes in v10: None Changes in v9: - Explain why devfreq needs to be disabled for GPUs with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ER

[PATCH v11 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-26 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso Reviewed-by: Steven Price --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts

[PATCH v11 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-26 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat --- Changes in v11: - binding: power-domain-names not power-domainS-names Changes in v10: - Fix the binding to make sure sram-supply property can be provided. Changes in v9

[PATCH v11 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-25 Thread Nicolas Boichat
and 3 power domains. Changes in v2: - Use sram instead of mali_sram as SRAM supply name. - Rename mali@ to gpu@. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_s

[BUG] copy_file_range with sysfs file as input

2021-01-25 Thread Nicolas Boichat
Hi copy_file_range experts, We hit this interesting issue when upgrading Go compiler from 1.13 to 1.15 [1]. Basically we use Go's `io.Copy` to copy the content of `/sys/kernel/debug/tracing/trace` to a temporary file. Under the hood, Go now uses `copy_file_range` syscall to optimize the copy

Re: [PATCH] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

2021-01-24 Thread Nicolas Boichat
On Mon, Jan 25, 2021 at 11:15 AM Hailong Fan wrote: > > When flipping the polarity will be generated interrupt under certain > circumstances, but GPIO external signal has not changed. > Then, mask the interrupt before polarity setting, and clear the > unexpected interrupt after trigger type

Re: [PATCH RESEND] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

2021-01-22 Thread Nicolas Boichat
On Fri, Jan 22, 2021 at 10:44 AM mtk15103 wrote: > > On Thu, 2021-01-21 at 20:13 +0800, Nicolas Boichat wrote: > > On Thu, Jan 21, 2021 at 8:09 PM mtk15103 wrote: > > > > > > On Thu, 2021-01-21 at 16:55 +0800, Nicolas Boichat wrote: > > > > O

Re: [PATCH RESEND] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

2021-01-21 Thread Nicolas Boichat
On Thu, Jan 21, 2021 at 8:09 PM mtk15103 wrote: > > On Thu, 2021-01-21 at 16:55 +0800, Nicolas Boichat wrote: > > On Thu, Jan 21, 2021 at 3:52 PM Hailong Fan > > wrote: > > > > > > When flipping the polarity will be generated interrupt under certain > >

Re: [PATCH RESEND] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

2021-01-21 Thread Nicolas Boichat
On Thu, Jan 21, 2021 at 3:52 PM Hailong Fan wrote: > > When flipping the polarity will be generated interrupt under certain > circumstances, but GPIO external signal has not changed. > Then, mask the interrupt before polarity setting, and clear the > unexpected interrupt after trigger type

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2021-01-20 Thread Nicolas Boichat
On Tue, Jan 12, 2021 at 4:59 PM Xin Ji wrote: > > Hi Rob Herring, thanks for the comments. > > On Mon, Jan 11, 2021 at 04:14:35PM -0600, Rob Herring wrote: > > On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote: > > > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > > >

Re: [PATCH next 12/15] arm64: dts: mediatek: mt8183: fix dtbs_check warning

2021-01-16 Thread Nicolas Boichat
On Sun, Jan 17, 2021 at 9:58 AM Nicolas Boichat wrote: > > On Sat, Jan 16, 2021 at 5:07 PM Chunfeng Yun > wrote: > > > > Harmonize node names, compatibles and properties. > > > > Signed-off-by: Chunfeng Yun > > --- > > arch/arm64/boot/dts/mediatek/

Re: [PATCH next 12/15] arm64: dts: mediatek: mt8183: fix dtbs_check warning

2021-01-16 Thread Nicolas Boichat
On Sat, Jan 16, 2021 at 5:07 PM Chunfeng Yun wrote: > > Harmonize node names, compatibles and properties. > > Signed-off-by: Chunfeng Yun > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 2/2] of/fdt: Make sure no-map does not remove already reserved regions

2021-01-15 Thread Nicolas Boichat
On Sat, Jan 16, 2021 at 1:30 AM Rob Herring wrote: > > On Fri, 15 Jan 2021 11:45:44 +, Quentin Perret wrote: > > From: Nicolas Boichat > > > > If the device tree is incorrectly configured, and attempts to > > define a "no-map" reserved memory tha

[PATCH v2] HID: google: Get HID report on probe to confirm tablet switch state

2021-01-14 Thread Nicolas Boichat
up. Signed-off-by: Nicolas Boichat --- Instead of all this manual parsing, it'd be easier to just call: hid_hw_request(hdev, report, HID_REQ_GET_REPORT); However, that fails silently as hdev->driver_input_lock is held during probe (or even some callbacks like input_configured. Changes in

Re: [PATCH] HID: google: Get HID report on probe to confirm tablet switch state

2021-01-14 Thread Nicolas Boichat
On Thu, Jan 14, 2021 at 8:15 PM Jiri Kosina wrote: > > On Thu, 24 Dec 2020, Nicolas Boichat wrote: > > > This forces reading the base folded status anytime the device is > > probed. > > Could you please provide a little bit more verbose changelog (namely what > is

[PATCH v10 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-12 Thread Nicolas Boichat
on those GPUs. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- (no changes since v9) Changes in v9: - Explain why devfreq needs to be disabled for GPUs with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: - Fix GPU ID in commit mess

[PATCH v10 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-12 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat --- Changes in v10: - Fix the binding to make sure sram-supply property can be provided. Changes in v6: - Rebased, actually tested with recent mesa driver. - No change

[PATCH v10 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-12 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change

[PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-12 Thread Nicolas Boichat
ent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 drm/panfrost: Add mt8183-mali compatible string .../bindings/gpu/arm,mali-bifros

[PATCH v10 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-12 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

Re: [PATCH v9 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-12 Thread Nicolas Boichat
On Tue, Jan 12, 2021 at 11:07 PM Rob Herring wrote: > > On Fri, Jan 08, 2021 at 09:10:08AM +0800, Nicolas Boichat wrote: > > Define a compatible string for the Mali Bifrost GPU found in > > Mediatek's MT8183 SoCs. > > > > Signed-off-by: Nicolas Boichat >

Re: [v5 3/3] thermal: mediatek: add another get_temp ops for thermal sensors

2021-01-10 Thread Nicolas Boichat
On Tue, Oct 13, 2020 at 6:24 PM Michael Kao wrote: > > Provide thermal zone to read thermal sensor > in the SoC. We can read all the thermal sensors > value in the SoC by the node /sys/class/thermal/ > > In mtk_thermal_bank_temperature, return -EAGAIN instead of -EACCESS > on the first read of

Re: [PATCH 2/3] soc: mediatek: pm-domains: Add domain regulator supply

2021-01-09 Thread Nicolas Boichat
On Thu, Jan 7, 2021 at 6:49 PM Hsin-Yi Wang wrote: > > Some power domains (eg. mfg) needs to turn on power supply before power > on. > > Signed-off-by: Hsin-Yi Wang Reviewed-by: Nicolas Boichat > --- > drivers/soc/mediatek/mt8183-pm-domains.h | 1 + > drivers/soc/m

[PATCH v9 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-07 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v9 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Nicolas Boichat
on those GPUs. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- Changes in v9: - Explain why devfreq needs to be disabled for GPUs with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: - Fix GPU ID in commit message Changes in v6: -

[PATCH v9 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-07 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat Reviewed-by: Alyssa Rosenzweig --- (no changes since v6) Changes in v6: - Rebased, actually tested with recent mesa driver. - No change Changes in v5: - Rename "2d&q

[PATCH v9 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-07 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change

[PATCH v9 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-07 Thread Nicolas Boichat
with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: - Fix GPU ID in commit message - Fix GPU ID in commit message Changes in v6: - Rebased, actually tested with recent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Media

Re: [PATCH v6 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Nicolas Boichat
On Thu, Jan 7, 2021 at 11:59 PM Steven Price wrote: > > On 05/01/2021 00:11, Nicolas Boichat wrote: > > GPUs with more than a single regulator (e.g. G-57 on MT8183) will > > require platform-specific handling, disable devfreq for now. > > Can you explain what actually

[PATCH v8 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-07 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v8 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: - Fix GPU ID in commit message

[PATCH v8 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-07 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change

[PATCH v8 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-07 Thread Nicolas Boichat
: - Fix GPU ID in commit message - Fix GPU ID in commit message Changes in v6: - Rebased, actually tested with recent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq

[PATCH v8 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-07 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat Reviewed-by: Alyssa Rosenzweig --- (no changes since v6) Changes in v6: - Rebased, actually tested with recent mesa driver. - No change Changes in v5: - Rename "2d&q

Re: [PATCH v7 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Nicolas Boichat
On Thu, Jan 7, 2021 at 4:31 PM Tomeu Vizoso wrote: > > On 1/7/21 9:26 AM, Nicolas Boichat wrote: > > GPUs with more than a single regulator (e.g. G72 on MT8183) will > > require platform-specific handling, disable devfreq for now. > > > > Signed-off-by: Nicolas Bo

[PATCH v7 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-07 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat Reviewed-by: Alyssa Rosenzweig --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - Rebased, actually tested with recent mesa driver. - No change Changes in v5

[PATCH v7 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-07 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - New change drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9

[PATCH v7 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-07 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v7 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-07 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change power domain name from 2d to core2. Changes in v4

[PATCH v7 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-07 Thread Nicolas Boichat
: - Rebased, actually tested with recent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 drm/panfrost: Add mt8183-mali compatible string .../bindi

Re: [PATCH v2 1/2] arm64: dts: mt8183: config dsi node

2021-01-06 Thread Nicolas Boichat
ke this, but maybe others have different opinions ,-) Reviewed-by: Nicolas Boichat > Signed-off-by: Hsin-Yi Wang > --- > Change: > v2: move compatible to board dts > --- > .../mediatek/mt8183-kukui-krane-sku176.dts| 5 +++ > .../arm64/boot/dts/mediatek/mt8183-kukui.d

Re: [PATCH 1/2] arm64: dts: mt8183: config dsi node

2021-01-06 Thread Nicolas Boichat
On Wed, Jan 6, 2021 at 6:47 PM Nicolas Boichat wrote: > > On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang wrote: > > > > Config dsi node for mt8183 kukui. Set panel and ports. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > .../arm6

Re: [PATCH 1/2] arm64: dts: mt8183: config dsi node

2021-01-06 Thread Nicolas Boichat
On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang wrote: > > Config dsi node for mt8183 kukui. Set panel and ports. > > Signed-off-by: Hsin-Yi Wang > --- > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 38 +++ > 1 file changed, 38 insertions(+) > > diff --git

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-06 Thread Nicolas Boichat
On Wed, Jan 6, 2021 at 4:41 PM Roger Lu wrote: > > Hi Nicolas, > > [snip] > > > > > > > + > > > > + /* Svs efuse parsing */ > > > > + ft_pgm = (svsp->efuse[0] >> 4) & GENMASK(3, 0); > > > > + > > > > + for (idx = 0; idx < svsp->bank_num; idx++) { > > > > + svsb =

Re: [PATCH v5 3/4] spmi: mediatek: Add support for MT6873/8192

2021-01-04 Thread Nicolas Boichat
On Wed, Dec 23, 2020 at 10:45 AM Hsin-Hsiung Wang wrote: > > Add spmi support for MT6873/8192. > > Signed-off-by: Hsin-Hsiung Wang > --- > drivers/spmi/Kconfig | 9 + > drivers/spmi/Makefile| 1 + > drivers/spmi/spmi-mtk-pmif.c | 504 +++ > 3

Re: [PATCH v6 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-04 Thread Nicolas Boichat
On Tue, Jan 5, 2021 at 8:34 AM Alyssa Rosenzweig wrote: > > > GPUs with more than a single regulator (e.g. G-57 on MT8183) will > > G72 Duh, sorry, yes. I will fix that in v7.

[PATCH v6 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-04 Thread Nicolas Boichat
Add support for MT8183's G-57 Bifrost. Signed-off-by: Nicolas Boichat --- Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change power domain name from 2d to core2. Changes in v4: - Add power domain names. Changes in v3

[PATCH v6 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-01-04 Thread Nicolas Boichat
Add a basic GPU node for mt8183. Signed-off-by: Nicolas Boichat --- The binding we use with out-of-tree Mali drivers includes more clocks, this is used for devfreq: the out-of-tree driver switches clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then switches clk_mux back

[PATCH v6 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-04 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G-57 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat --- Changes in v6: - New change drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v6 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-04 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat Reviewed-by: Alyssa Rosenzweig --- Changes in v6: - Rebased, actually tested with recent mesa driver. - No change Changes in v5: - Rename "2d" power domain

  1   2   3   4   5   6   >