Re: [PATCH net-next 3/3] net: core: Namespace-ify sysctl_rmem_max and sysctl_wmem_max

2021-01-20 Thread Nicolas Dichtel
Le 20/01/2021 à 14:28, Menglong Dong a écrit : [snip] >>> For that reason, make sysctl_wmem_max and sysctl_rmem_max >>> per-namespace. >> >> I think having those values be restricted by init netns is a desirable >> property. > > I just thought that having these values per-namespace can be more

Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)

2020-09-18 Thread Nicolas Dichtel
gt;> gcc --version > gcc (SUSE Linux) 7.5.0 I tried with a (very old) gcc and I did not reproduce this error: $ gcc --version gcc (Debian 4.9.2-10+deb8u2) 4.9.2 > > This patch: > > commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968 > Author: Nicolas Dichtel > Date: Wed May

Re: [PATCH] Remove ipvs v6 dependency on iptables

2020-08-28 Thread Nicolas Dichtel
Le 28/08/2020 à 00:07, Lach a écrit : > This dependency was added in 63dca2c0b0e7a92cb39d1b1ecefa32ffda201975, > because this commit had dependency on > ipv6_find_hdr, which was located in iptables-specific code > > But it is no longer required, because >

Re: [PATCH] net: sysctl: cleanup net_sysctl_init error exit paths

2019-09-18 Thread Nicolas Dichtel
Le 17/09/2019 à 17:53, George G. Davis a écrit : [snip] > Ping, "Linux 5.3" kernel has been released [1] and it appears that the > 5.4 merge window is open. The patch [2] remains unchanged since my initial > post. Please consider applying it. net-next is closed:

Re: [PATCH 2/2] net: ipv6: Fix a possible null-pointer dereference in vti6_link_config()

2019-07-26 Thread Nicolas Dichtel
Le 26/07/2019 à 10:03, Jia-Ju Bai a écrit : > In vti6_link_config(), there is an if statement on line 649 to check > whether rt is NULL: > if (rt) > > When rt is NULL, it is used on line 651: > ip6_rt_put(rt); > dst_release(>dst); > > Thus, a possible null-pointer dereference may

Re: [PATCH 1/2] net: ipv4: Fix a possible null-pointer dereference in inet_csk_rebuild_route()

2019-07-26 Thread Nicolas Dichtel
Le 26/07/2019 à 04:25, Jia-Ju Bai a écrit : > In inet_csk_rebuild_route(), rt is assigned to NULL on line 1071. > On line 1076, rt is used: > return >dst; > Thus, a possible null-pointer dereference may occur.> > To fix this bug, rt is checked before being used. > > This bug is found by a

Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation

2019-04-11 Thread Nicolas Dichtel
Le 11/04/2019 à 10:52, Rolf Eike Beer a écrit : > Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel: >> In case of cross-compilation, there may be two pkg-config tools, one for >> the host and one for the target. Enable to override the default name. >> &

[PATCH linux] objtool: fix pkg-config query in case of cross-compilation

2019-04-11 Thread Nicolas Dichtel
In case of cross-compilation, there may be two pkg-config tools, one for the host and one for the target. Enable to override the default name. Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location") Signed-off-by: Nicolas Dichtel --- Makefile | 3 ++- too

Re: [PATCH net-next v5] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-14 Thread Nicolas Dichtel
; static entries. > > Signed-off-by: Callum Sinclair Except two minor comments (see below), Acked-by: Nicolas Dichtel [snip] > +/* MRT6_FLUSH optional flags */ > +#define MRT6_FLUSH_MFC 1 /* Flush multicast entries */ > +#define MRT6_FLUSH_MFC_STATIC2 /*

Re: [PATCH net-next v4] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-13 Thread Nicolas Dichtel
Le 12/02/2019 à 04:12, Callum Sinclair a écrit : [snip] > /* Wipe the cache */ > - list_for_each_entry_safe(c, tmp, >mfc_cache_list, list) { > - if (!all && (c->mfc_flags & MFC_STATIC)) > - continue; > - rhltable_remove(>mfc_hash, >mnode,

Re: [PATCH net-next v3] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-11 Thread Nicolas Dichtel
Le 11/02/2019 à 04:54, Callum Sinclair a écrit : > v1 -> v2: > Implemented additional flags for static entries > v2 -> v3: > Cleaned up flag logic so any combination of routes can be cleared. > Fixed style errors > Fixed incorrect flag values nit: those lines are usually put after the '---', thus

Re: [PATCH net-next] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-08 Thread Nicolas Dichtel
Le 08/02/2019 à 15:43, Nikolay Aleksandrov a écrit : > On 08/02/2019 16:18, Nicolas Dichtel wrote: >> Le 08/02/2019 à 05:11, Callum Sinclair a écrit : >>> Currently the only way to clear the mfc cache was to delete the entries >> mfc stands for 'multicast forwarding cache',

Re: [PATCH net-next] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-08 Thread Nicolas Dichtel
Le 08/02/2019 à 05:11, Callum Sinclair a écrit : > Currently the only way to clear the mfc cache was to delete the entries mfc stands for 'multicast forwarding cache', so 'mfc cache' is a bit strange. > one by one using the MRT_DEL_MFC socket option or to destroy and > recreate the socket. Note

[PATCH net] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-14 Thread Nicolas Dichtel
k> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/netlink/genetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 6f02499ef007..b9ce82c9440f 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/

[PATCH net] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-14 Thread Nicolas Dichtel
nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called with a clone. Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()") Reported-by: Ben Hutchings Signed-off-by: Nicolas Dichtel --- n

Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in genlmsg_multicast_allns()

2018-03-14 Thread Nicolas Dichtel
Le 13/03/2018 à 01:04, Ben Hutchings a écrit : > On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.  If anyone has any objections, please let me know. >> >> ------ >> >> From: Nicolas Dichtel <nicolas.dich...@6

Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in genlmsg_multicast_allns()

2018-03-14 Thread Nicolas Dichtel
Le 13/03/2018 à 01:04, Ben Hutchings a écrit : > On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.  If anyone has any objections, please let me know. >> >> ------ >> >> From: Nicolas Di

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-26 Thread Nicolas Dichtel
Le 26/01/2018 à 09:36, Jiri Benc a écrit : > On Fri, 26 Jan 2018 00:34:51 +0100, Nicolas Dichtel wrote: >> Why meaningful? The user knows that the answer is like if if was done in >> another >> netns. It enables to have only one netlink socket instead of one per netns. >

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-26 Thread Nicolas Dichtel
Le 26/01/2018 à 09:36, Jiri Benc a écrit : > On Fri, 26 Jan 2018 00:34:51 +0100, Nicolas Dichtel wrote: >> Why meaningful? The user knows that the answer is like if if was done in >> another >> netns. It enables to have only one netlink socket instead of one per netns. >

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-25 Thread Nicolas Dichtel
Le 25/01/2018 à 23:30, Jiri Benc a écrit : > On Thu, 25 Jan 2018 15:20:59 +0100, Nicolas Dichtel wrote: >> Hmm, I don't agree. For me, it would be the correct answer. If user has a >> socket >> in ns_a and targets a RTM_GETLINK in ns_b, the answer he gets should be like

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-25 Thread Nicolas Dichtel
Le 25/01/2018 à 23:30, Jiri Benc a écrit : > On Thu, 25 Jan 2018 15:20:59 +0100, Nicolas Dichtel wrote: >> Hmm, I don't agree. For me, it would be the correct answer. If user has a >> socket >> in ns_a and targets a RTM_GETLINK in ns_b, the answer he gets should be like

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-25 Thread Nicolas Dichtel
Le 24/01/2018 à 17:35, Jiri Benc a écrit : > On Wed, 24 Jan 2018 16:24:34 +0100, Nicolas Dichtel wrote: >> I wonder if it would be possible to do something in the netlink framework, >> like >> NETLINK_LISTEN_ALL_NSID. >> Having some ancillary data at the netlink socke

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-25 Thread Nicolas Dichtel
Le 24/01/2018 à 17:35, Jiri Benc a écrit : > On Wed, 24 Jan 2018 16:24:34 +0100, Nicolas Dichtel wrote: >> I wonder if it would be possible to do something in the netlink framework, >> like >> NETLINK_LISTEN_ALL_NSID. >> Having some ancillary data at the netlink socke

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Nicolas Dichtel
Hi, Le 24/01/2018 à 15:26, Christian Brauner a écrit : > Hi, > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > RTM_NEWLINK will be sent out in a separate patch since there are more >

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Nicolas Dichtel
Hi, Le 24/01/2018 à 15:26, Christian Brauner a écrit : > Hi, > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > RTM_NEWLINK will be sent out in a separate patch since there are more >

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-24 Thread Nicolas Dichtel
Le 23/01/2018 à 18:08, Jiri Benc a écrit : > On Tue, 23 Jan 2018 17:37:11 +0100, Nicolas Dichtel wrote: >> When a virtual interface moves to another netns, the netlink RTM_DELLINK >> message >> contains the attribute IFLA_NEW_NETNSID, which identifies where the interface &

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-24 Thread Nicolas Dichtel
Le 23/01/2018 à 18:08, Jiri Benc a écrit : > On Tue, 23 Jan 2018 17:37:11 +0100, Nicolas Dichtel wrote: >> When a virtual interface moves to another netns, the netlink RTM_DELLINK >> message >> contains the attribute IFLA_NEW_NETNSID, which identifies where the interface &

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-23 Thread Nicolas Dichtel
Le 23/01/2018 à 11:26, Wolfgang Bumiller a écrit : > On Tue, Jan 23, 2018 at 10:30:09AM +0100, Jiri Benc wrote: >> On Mon, 22 Jan 2018 23:25:41 +0100, Christian Brauner wrote: >>> This is not necessarily true in scenarios where I move a network device >>> via RTM_NEWLINK + IFLA_NET_NS_PID into a

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-23 Thread Nicolas Dichtel
Le 23/01/2018 à 11:26, Wolfgang Bumiller a écrit : > On Tue, Jan 23, 2018 at 10:30:09AM +0100, Jiri Benc wrote: >> On Mon, 22 Jan 2018 23:25:41 +0100, Christian Brauner wrote: >>> This is not necessarily true in scenarios where I move a network device >>> via RTM_NEWLINK + IFLA_NET_NS_PID into a

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-23 Thread Nicolas Dichtel
Le 22/01/2018 à 23:06, Jiri Benc a écrit : [snip] > Btw, we have one missing piece here: when an interface is moved to a > name space that does not have netnsid attached, we want to find out > where the interface was moved to. But there's currently no reliable way > to do it. For veth, the other

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-23 Thread Nicolas Dichtel
Le 22/01/2018 à 23:06, Jiri Benc a écrit : [snip] > Btw, we have one missing piece here: when an interface is moved to a > name space that does not have netnsid attached, we want to find out > where the interface was moved to. But there's currently no reliable way > to do it. For veth, the other

Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""

2018-01-15 Thread Nicolas Dichtel
it. Reverting the revert will bring the bug back. >> >> Steffen, in the email where you asked me to revert that is the >> commit ID you referenced. > > I think there was a misunderstanding. I asked you to queue the > commit with that ID to stable on Dec 23 (this com

Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""

2018-01-15 Thread Nicolas Dichtel
to revert that is the >> commit ID you referenced. > > I think there was a misunderstanding. I asked you to queue the > commit with that ID to stable on Dec 23 (this commit ID is the > revert of the buggy patch). This commit was included to stable > on Jan 4 then: > > https://www.

Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-14 Thread Nicolas Dichtel
Le 13/06/2017 à 19:08, Julien Gomes a écrit : > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-14 Thread Nicolas Dichtel
Le 13/06/2017 à 19:08, Julien Gomes a écrit : > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH] kbuild: replace genhdr-y with generated-y, deprecating genhdr-y

2017-06-09 Thread Nicolas Dichtel
d catch. It eases the understanding of all those mechanisms. After the fix of the typo in the commitlog: Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

Re: [PATCH] kbuild: replace genhdr-y with generated-y, deprecating genhdr-y

2017-06-09 Thread Nicolas Dichtel
rstanding of all those mechanisms. After the fix of the typo in the commitlog: Acked-by: Nicolas Dichtel

Re: [PATCH v2] kbuild: skip install/check of headers right under uapi directories

2017-05-16 Thread Nicolas Dichtel
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories") > Reported-by: Dan Williams <dan.j.willi...@intel.com> > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Thank you for the patch. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

Re: [PATCH v2] kbuild: skip install/check of headers right under uapi directories

2017-05-16 Thread Nicolas Dichtel
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories") > Reported-by: Dan Williams > Signed-off-by: Masahiro Yamada Thank you for the patch. Acked-by: Nicolas Dichtel

Re: [PATCH v11 10/12] uapi: export all headers under uapi directories

2017-05-09 Thread Nicolas Dichtel
Le 08/05/2017 à 01:17, Masahiro Yamada a écrit : Hi Masahiro, [snip] > I will send pull-requests for v4.12 in a few days. > > I need to fix a complex conflict reported by > https://lkml.org/lkml/2017/4/10/1208 > > I rebased linux-kbuild/uapi on commit 13e0988140 > (dropping 08/12

Re: [PATCH v11 10/12] uapi: export all headers under uapi directories

2017-05-09 Thread Nicolas Dichtel
Le 08/05/2017 à 01:17, Masahiro Yamada a écrit : Hi Masahiro, [snip] > I will send pull-requests for v4.12 in a few days. > > I need to fix a complex conflict reported by > https://lkml.org/lkml/2017/4/10/1208 > > I rebased linux-kbuild/uapi on commit 13e0988140 > (dropping 08/12

[PATCH v11 12/12] arch/include: remove empty Kbuild files

2017-03-27 Thread Nicolas Dichtel
Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- arch/cris/include/arch-v10/arch/Kbuild | 1 - arch/cris/include/arch-v32/arch/Kbuild | 1 - arch/tile/include/arch/Kbuild | 1 - 3 files changed, 3 deletions(-) delete mode 100644 arch/cris/include/arch-v10/arch/

[PATCH v11 12/12] arch/include: remove empty Kbuild files

2017-03-27 Thread Nicolas Dichtel
Signed-off-by: Nicolas Dichtel --- arch/cris/include/arch-v10/arch/Kbuild | 1 - arch/cris/include/arch-v32/arch/Kbuild | 1 - arch/tile/include/arch/Kbuild | 1 - 3 files changed, 3 deletions(-) delete mode 100644 arch/cris/include/arch-v10/arch/Kbuild delete mode 100644 arch/cris

[PATCH v11 02/12] nios2: put setup.h in uapi

2017-03-27 Thread Nicolas Dichtel
This header file is exported, but from a userland pov, it's just a wrapper to asm-generic/setup.h. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Reviewed-by: Tobias Klauser <tklau...@distanz.ch> --- arch/nios2/include/uapi/asm/Kbuild | 1 + 1 file changed, 1 insertion(+)

[PATCH v11 09/12] smc_diag.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or directory #include Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/rdma/ib_verbs.h | 3 +-- include/uapi

[PATCH v11 10/12] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
flo...@6wind.com> for the tip to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas D

[PATCH v11 02/12] nios2: put setup.h in uapi

2017-03-27 Thread Nicolas Dichtel
This header file is exported, but from a userland pov, it's just a wrapper to asm-generic/setup.h. Signed-off-by: Nicolas Dichtel Reviewed-by: Tobias Klauser --- arch/nios2/include/uapi/asm/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/nios2/include/uapi/asm/Kbuild b/arch

[PATCH v11 09/12] smc_diag.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or directory #include Signed-off-by: Nicolas Dichtel --- include/rdma/ib_verbs.h | 3 +-- include/uapi/linux/smc_diag.h | 2 +- include/uapi

[PATCH v11 10/12] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas Dichtel Acked-by: Daniel Vetter

[PATCH v11 11/12] uapi: export all arch specifics directories

2017-03-27 Thread Nicolas Dichtel
of the specified arch. Note that only cris and tile have more directories than only asm: - arch-v[10|32] for cris; - arch for tile. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/kbuild/makefiles.txt | 15 +-- Makefile | 6 +++---

[PATCH v11 11/12] uapi: export all arch specifics directories

2017-03-27 Thread Nicolas Dichtel
of the specified arch. Note that only cris and tile have more directories than only asm: - arch-v[10|32] for cris; - arch for tile. Signed-off-by: Nicolas Dichtel --- Documentation/kbuild/makefiles.txt | 15 +-- Makefile | 6 +++--- arch/cris/include/uapi/asm

[PATCH v11 06/12] uapi: includes linux/types.h before exporting files

2017-03-27 Thread Nicolas Dichtel
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without #include Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/bcache.h | 2 +- include/uapi/linux/btrfs_tree.h | 2 ++ include/uapi/linux/cryptouser.h | 2 ++ include/uapi/linux/pr.h | 2 ++ i

[PATCH v11 07/12] btrfs_tree.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
IZE’ undeclared here (not in a function) __u8 uuid[BTRFS_UUID_SIZE]; ^ .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/u

[PATCH v11 04/12] Makefile.headersinst: cleanup input files

2017-03-27 Thread Nicolas Dichtel
After the last three patches, all exported headers are under uapi/, thus input-files2 are not needed anymore. The side effect is that input-files1-name is exactly header-y. Note also that input-files3-name is genhdr-y. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- s

[PATCH v11 06/12] uapi: includes linux/types.h before exporting files

2017-03-27 Thread Nicolas Dichtel
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without #include Signed-off-by: Nicolas Dichtel --- include/uapi/linux/bcache.h | 2 +- include/uapi/linux/btrfs_tree.h | 2 ++ include/uapi/linux/cryptouser.h | 2 ++ include/uapi/linux/pr.h | 2 ++ include/uapi/linux/qrtr.h | 1

[PATCH v11 07/12] btrfs_tree.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
IZE’ undeclared here (not in a function) __u8 uuid[BTRFS_UUID_SIZE]; ^ .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; Signed-off-by: Nicolas Dichtel --- include/uapi/linux/btrfs_tree.h | 1

[PATCH v11 04/12] Makefile.headersinst: cleanup input files

2017-03-27 Thread Nicolas Dichtel
After the last three patches, all exported headers are under uapi/, thus input-files2 are not needed anymore. The side effect is that input-files1-name is exactly header-y. Note also that input-files3-name is genhdr-y. Signed-off-by: Nicolas Dichtel --- scripts/Makefile.headersinst | 38

[PATCH v11 05/12] Makefile.headersinst: remove destination-y option

2017-03-27 Thread Nicolas Dichtel
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y for exported headers") but never used in-tree. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Acked-by: Paul Bolle <pebo...@tiscali.nl> --- Documentation/kbu

[PATCH v11 05/12] Makefile.headersinst: remove destination-y option

2017-03-27 Thread Nicolas Dichtel
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y for exported headers") but never used in-tree. Signed-off-by: Nicolas Dichtel Acked-by: Paul Bolle --- Documentation/kbuild/makefiles.txt | 23 --- scripts/Makefile.headersinst

[PATCH v11 03/12] x86: stop exporting msr-index.h to userland

2017-03-27 Thread Nicolas Dichtel
Even if this file was not in an uapi directory, it was exported because it was listed in the Kbuild file. Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") Suggested-by: Borislav Petkov <b...@alien8.de> CC: Ingo Molnar <mi...@kernel.org>

[PATCH v11 00/12] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
Patches #1 and #2 are just cleanup: some exported headers were still under a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was not under an uapi directory. After these three patches, all exported headers are under an uapi directory: path #4 stops searching files in non

[PATCH v11 01/12] h8300: put bitsperlong.h in uapi

2017-03-27 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- arch/h8300/include/asm/bitsperlong.h | 14 -- arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++ 2 files changed, 14 insertions(+), 14 del

[PATCH v11 03/12] x86: stop exporting msr-index.h to userland

2017-03-27 Thread Nicolas Dichtel
Even if this file was not in an uapi directory, it was exported because it was listed in the Kbuild file. Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") Suggested-by: Borislav Petkov CC: Ingo Molnar Signed-off-by: Nicolas Dichtel Acked-by: Ingo Mol

[PATCH v11 00/12] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
Patches #1 and #2 are just cleanup: some exported headers were still under a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was not under an uapi directory. After these three patches, all exported headers are under an uapi directory: path #4 stops searching files in non

[PATCH v11 01/12] h8300: put bitsperlong.h in uapi

2017-03-27 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel --- arch/h8300/include/asm/bitsperlong.h | 14 -- arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++ 2 files changed, 14 insertions(+), 14 deletions(-) delete mode 100644 arch/h8300

[PATCH v11 08/12] cryptouser.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) char cru_name[CRYPTO_MAX_ALG_NAME]; Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Acked-by: Herbert Xu

[PATCH v11 08/12] cryptouser.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) char cru_name[CRYPTO_MAX_ALG_NAME]; Signed-off-by: Nicolas Dichtel Acked-by: Herbert Xu --- include/linux/crypto.h | 2

Re: [PATCH v10 11/11] uapi: export all arch specifics directories

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:27, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dich...@6wind.com>: >> diff --git a/arch/cris/include/uapi/asm/Kbuild >> b/arch/cris/include/uapi/asm/Kbuild >> ind

Re: [PATCH v10 11/11] uapi: export all arch specifics directories

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:27, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel : >> diff --git a/arch/cris/include/uapi/asm/Kbuild >> b/arch/cris/include/uapi/asm/Kbuild >> index d0c5471856e0..b15bf6bc0e94 100644 >&

Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi

2017-03-27 Thread Nicolas Dichtel
Le 27/03/2017 à 07:31, Masahiro Yamada a écrit : [snip] >> -#endif /* __ASM_H8300_BITS_PER_LONG */ >> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h >> b/arch/h8300/include/uapi/asm/bitsperlong.h >> new file mode 100644 >> index ..e56cf72369b6 >> --- /dev/null >> +++

Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi

2017-03-27 Thread Nicolas Dichtel
Le 27/03/2017 à 07:31, Masahiro Yamada a écrit : [snip] >> -#endif /* __ASM_H8300_BITS_PER_LONG */ >> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h >> b/arch/h8300/include/uapi/asm/bitsperlong.h >> new file mode 100644 >> index ..e56cf72369b6 >> --- /dev/null >> +++

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:26, Masahiro Yamada a écrit : > Hi Nocolas, > > > 2017-03-24 18:03 GMT+09:00 Nicolas Dichtel <nicolas.dich...@6wind.com>: [snip] > > > As a whole, this series is amazing. Thanks for your great work! Thank you. And thank yo

Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:53, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dich...@6wind.com>: [snip] >> diff --git a/include/uapi/linux/btrfs_tree.h >> b/include/uapi/linux/btrfs_tree.h >> ind

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:26, Masahiro Yamada a écrit : > Hi Nocolas, > > > 2017-03-24 18:03 GMT+09:00 Nicolas Dichtel : [snip] > > > As a whole, this series is amazing. Thanks for your great work! Thank you. And thank you for taking time to review it. > &g

Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland

2017-03-27 Thread Nicolas Dichtel
Hi Masahiro, Le 27/03/2017 à 07:53, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel : [snip] >> diff --git a/include/uapi/linux/btrfs_tree.h >> b/include/uapi/linux/btrfs_tree.h >> index 6a261cb52d95..6a754ada59af 1006

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-24 Thread Nicolas Dichtel
Le 24/03/2017 à 09:42, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel <nicolas.dich...@6wind.com>: >> Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : >>> Patches #1 and #2 are just cleanup: some exported headers were sti

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-24 Thread Nicolas Dichtel
Le 24/03/2017 à 09:42, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel : >> Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : >>> Patches #1 and #2 are just cleanup: some exported headers were still under >>> a n

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-24 Thread Nicolas Dichtel
Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported heade

Re: [PATCH v10 00/11] uapi: export all headers under uapi directories

2017-03-24 Thread Nicolas Dichtel
Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported heade

[PATCH v10 10/11] uapi: export all headers under uapi directories

2017-03-14 Thread Nicolas Dichtel
flo...@6wind.com> for the tip to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas D

[PATCH v10 10/11] uapi: export all headers under uapi directories

2017-03-14 Thread Nicolas Dichtel
to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas Dichtel Acked-by: Daniel Vetter

[PATCH v10 03/11] x86: stop exporting msr-index.h to userland

2017-03-14 Thread Nicolas Dichtel
Even if this file was not in an uapi directory, it was exported because it was listed in the Kbuild file. Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") Suggested-by: Borislav Petkov <b...@alien8.de> CC: Ingo Molnar <mi...@kernel.org>

[PATCH v10 03/11] x86: stop exporting msr-index.h to userland

2017-03-14 Thread Nicolas Dichtel
Even if this file was not in an uapi directory, it was exported because it was listed in the Kbuild file. Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") Suggested-by: Borislav Petkov CC: Ingo Molnar Signed-off-by: Nicolas Dichtel Acked-by: Ingo Mol

[PATCH v10 05/11] Makefile.headersinst: remove destination-y option

2017-03-14 Thread Nicolas Dichtel
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y for exported headers") but never used in-tree. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Acked-by: Paul Bolle <pebo...@tiscali.nl> --- Documentation/kbu

[PATCH v10 05/11] Makefile.headersinst: remove destination-y option

2017-03-14 Thread Nicolas Dichtel
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y for exported headers") but never used in-tree. Signed-off-by: Nicolas Dichtel Acked-by: Paul Bolle --- Documentation/kbuild/makefiles.txt | 23 --- scripts/Makefile.headersinst

[PATCH v10 09/11] smc_diag.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or directory #include Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/rdma/ib_verbs.h | 3 +-- include/uapi

[PATCH v10 09/11] smc_diag.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or directory #include Signed-off-by: Nicolas Dichtel --- include/rdma/ib_verbs.h | 3 +-- include/uapi/linux/smc_diag.h | 2 +- include/uapi

[PATCH v10 07/11] btrfs_tree.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
IZE’ undeclared here (not in a function) __u8 uuid[BTRFS_UUID_SIZE]; ^ .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/u

[PATCH v10 07/11] btrfs_tree.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
IZE’ undeclared here (not in a function) __u8 uuid[BTRFS_UUID_SIZE]; ^ .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; Signed-off-by: Nicolas Dichtel --- include/uapi/linux/btrfs_tree.h | 1

[PATCH v10 06/11] uapi: includes linux/types.h before exporting files

2017-03-14 Thread Nicolas Dichtel
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without #include Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/bcache.h | 2 +- include/uapi/linux/btrfs_tree.h | 2 ++ include/uapi/linux/cryptouser.h | 2 ++ include/uapi/linux/pr.h | 2 ++ i

[PATCH v10 06/11] uapi: includes linux/types.h before exporting files

2017-03-14 Thread Nicolas Dichtel
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without #include Signed-off-by: Nicolas Dichtel --- include/uapi/linux/bcache.h | 2 +- include/uapi/linux/btrfs_tree.h | 2 ++ include/uapi/linux/cryptouser.h | 2 ++ include/uapi/linux/pr.h | 2 ++ include/uapi/linux/qrtr.h | 1

[PATCH v10 02/11] nios2: put setup.h in uapi

2017-03-14 Thread Nicolas Dichtel
This header file is exported, but from a userland pov, it's just a wrapper to asm-generic/setup.h. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Reviewed-by: Tobias Klauser <tklau...@distanz.ch> --- arch/nios2/include/uapi/asm/Kbuild | 1 + 1 file changed, 1 insertion(+)

[PATCH v10 02/11] nios2: put setup.h in uapi

2017-03-14 Thread Nicolas Dichtel
This header file is exported, but from a userland pov, it's just a wrapper to asm-generic/setup.h. Signed-off-by: Nicolas Dichtel Reviewed-by: Tobias Klauser --- arch/nios2/include/uapi/asm/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/nios2/include/uapi/asm/Kbuild b/arch

[PATCH v10 08/11] cryptouser.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) char cru_name[CRYPTO_MAX_ALG_NAME]; Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Acked-by: Herbert Xu

[PATCH v10 08/11] cryptouser.h: fix include from userland

2017-03-14 Thread Nicolas Dichtel
This patch prepares the uapi export by fixing the following error: .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) char cru_name[CRYPTO_MAX_ALG_NAME]; Signed-off-by: Nicolas Dichtel Acked-by: Herbert Xu --- include/linux/crypto.h | 2

[PATCH v10 01/11] h8300: put bitsperlong.h in uapi

2017-03-14 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- arch/h8300/include/asm/bitsperlong.h | 14 -- arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++ 2 files changed, 14 insertions(+), 14 del

[PATCH v10 01/11] h8300: put bitsperlong.h in uapi

2017-03-14 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel --- arch/h8300/include/asm/bitsperlong.h | 14 -- arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++ 2 files changed, 14 insertions(+), 14 deletions(-) delete mode 100644 arch/h8300

[PATCH v10 11/11] uapi: export all arch specifics directories

2017-03-14 Thread Nicolas Dichtel
of the specified arch. Note that only cris and tile have more directories than only asm: - arch-v[10|32] for cris; - arch for tile. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/kbuild/makefiles.txt | 15 +-- Makefile | 6 +++---

[PATCH v10 11/11] uapi: export all arch specifics directories

2017-03-14 Thread Nicolas Dichtel
of the specified arch. Note that only cris and tile have more directories than only asm: - arch-v[10|32] for cris; - arch for tile. Signed-off-by: Nicolas Dichtel --- Documentation/kbuild/makefiles.txt | 15 +-- Makefile | 6 +++--- arch/cris/include/uapi/asm

[PATCH v10 04/11] Makefile.headersinst: cleanup input files

2017-03-14 Thread Nicolas Dichtel
After the last three patches, all exported headers are under uapi/, thus input-files2 are not needed anymore. The side effect is that input-files1-name is exactly header-y. Note also that input-files3-name is genhdr-y. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- s

  1   2   3   4   5   6   7   >