[PATCH] ARM: dts: at91: at91sam9g45 family: reduce the trng register map size

2016-05-06 Thread Nicolas Ferre
No need to map 0x4000 bytes for the TRNG device: reduce it to 0x100. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91sam9g45.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-06 Thread Nicolas Ferre
+ compatible = "atmel,atmegaxx_captouch"; >>> + reg = <0x51>; >>> + interrupt-parent = <>; >>> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>; >>> + linux,keycodes = , , >>> + , , >>> + , , >>> + , ; >>> + autorepeat; >>> + }; > > cheers, > grant > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-06 Thread Nicolas Ferre
compatible = "atmel,atmegaxx_captouch"; >>> + reg = <0x51>; >>> + interrupt-parent = <>; >>> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>; >>> + linux,keycodes = , , >>> + , , >>> + , , >>> + , ; >>> + autorepeat; >>> + }; > > cheers, > grant > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-29 Thread Nicolas Ferre
> - if (np) { > - /* try dt phy registration */ > - err = of_mdiobus_register(bp->mii_bus, np); > - > - /* fallback to standard phy registration if no phy were > - * found during dt phy registration > - */ > - if (!err && !phy_find_first(bp->mii_bus)) { > - for (i = 0; i < PHY_MAX_ADDR; i++) { > - struct phy_device *phydev; > - > - phydev = mdiobus_scan(bp->mii_bus, i); > - if (IS_ERR(phydev)) { > - err = PTR_ERR(phydev); > - break; > - } > - } > - > - if (err) > - goto err_out_unregister_bus; > - } > - } else { > - if (pdata) > - bp->mii_bus->phy_mask = pdata->phy_mask; > - > - err = mdiobus_register(bp->mii_bus); > - } > + if (np) > + err = macb_mii_of_init(bp, np); > + else > + err = macb_mii_pdata_init(bp, pdata); > > if (err) > goto err_out_free_mdiobus; I'm okay with this. Thanks for having taken the initiative to implement it. Bye, -- Nicolas Ferre

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-29 Thread Nicolas Ferre
> - if (np) { > - /* try dt phy registration */ > - err = of_mdiobus_register(bp->mii_bus, np); > - > - /* fallback to standard phy registration if no phy were > - * found during dt phy registration > - */ > - if (!err && !phy_find_first(bp->mii_bus)) { > - for (i = 0; i < PHY_MAX_ADDR; i++) { > - struct phy_device *phydev; > - > - phydev = mdiobus_scan(bp->mii_bus, i); > - if (IS_ERR(phydev)) { > - err = PTR_ERR(phydev); > - break; > - } > - } > - > - if (err) > - goto err_out_unregister_bus; > - } > - } else { > - if (pdata) > - bp->mii_bus->phy_mask = pdata->phy_mask; > - > - err = mdiobus_register(bp->mii_bus); > - } > + if (np) > + err = macb_mii_of_init(bp, np); > + else > + err = macb_mii_pdata_init(bp, pdata); > > if (err) > goto err_out_free_mdiobus; I'm okay with this. Thanks for having taken the initiative to implement it. Bye, -- Nicolas Ferre

Re: [PATCH RFT v2 2/2] macb: kill PHY reset code

2016-04-29 Thread Nicolas Ferre
Le 29/04/2016 00:15, Sergei Shtylyov a écrit : > With the 'phylib' now being aware of the "reset-gpios" PHY node property, > there should be no need to frob the PHY reset in this driver anymore... > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com&

Re: [PATCH RFT v2 2/2] macb: kill PHY reset code

2016-04-29 Thread Nicolas Ferre
Le 29/04/2016 00:15, Sergei Shtylyov a écrit : > With the 'phylib' now being aware of the "reset-gpios" PHY node property, > there should be no need to frob the PHY reset in this driver anymore... > > Signed-off-by: Sergei Shtylyov Acked-by: Nicolas Ferre So I que

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nicolas Ferre
if (IS_ERR(phydev)) { > - err = PTR_ERR(phydev); > - break; > - } > - } > - > - if (err) > - goto err_out_unregister_bus; > - } > } else { > if (pdata) > bp->mii_bus->phy_mask = pdata->phy_mask; > -- Nicolas Ferre

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nicolas Ferre
if (IS_ERR(phydev)) { > - err = PTR_ERR(phydev); > - break; > - } > - } > - > - if (err) > - goto err_out_unregister_bus; > - } > } else { > if (pdata) > bp->mii_bus->phy_mask = pdata->phy_mask; > -- Nicolas Ferre

[GIT PULL] at91: dt for 4.7 #2

2016-04-27 Thread Nicolas Ferre
- sama5d4: definition of watchdog IRQ property - addition of the new shutdown controller to sama5d2 & sama5d2 Xplained Florian Vallee (1): ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description Nicolas Ferre (3):

[GIT PULL] at91: dt for 4.7 #2

2016-04-27 Thread Nicolas Ferre
- sama5d4: definition of watchdog IRQ property - addition of the new shutdown controller to sama5d2 & sama5d2 Xplained Florian Vallee (1): ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description Nicolas Ferre (3):

[GIT PULL] at91: defconfig for 4.7 #1

2016-04-27 Thread Nicolas Ferre
: multi_v7_defconfig: add HLCDC drivers as modules Nicolas Ferre (7): ARM: at91/defconfig: add the HDMA controller to sama5_defconfig ARM: at91/defconfig: add HLCDC driver to sama5_defconfig ARM: at91/defconfig: add PDMIC driver to sama5_defconfig ARM: multi_v7_defconfig: add Atmel watchdog

[GIT PULL] at91: defconfig for 4.7 #1

2016-04-27 Thread Nicolas Ferre
: multi_v7_defconfig: add HLCDC drivers as modules Nicolas Ferre (7): ARM: at91/defconfig: add the HDMA controller to sama5_defconfig ARM: at91/defconfig: add HLCDC driver to sama5_defconfig ARM: at91/defconfig: add PDMIC driver to sama5_defconfig ARM: multi_v7_defconfig: add Atmel watchdog

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-27 Thread Nicolas Ferre
aintaining this DT file, I think that I'll be informed if people try an unlikely arrangement of patches on this board. So either way, I'm okay. But I do think it's not worth thinking too much about this case. Bye, -- Nicolas Ferre

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-27 Thread Nicolas Ferre
aintaining this DT file, I think that I'll be informed if people try an unlikely arrangement of patches on this board. So either way, I'm okay. But I do think it's not worth thinking too much about this case. Bye, -- Nicolas Ferre

[PATCH 4/4] ARM: multi_v7_defconfig: add the Atmel sama5d2-compatible ADC driver

2016-04-26 Thread Nicolas Ferre
Add the new sama5d2-compatible ADC driver as a module. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6a62eb

[PATCH 3/4] ARM: multi_v7_defconfig: add the Atmel Audio microphone interface PDMIC

2016-04-26 Thread Nicolas Ferre
Add the Atmel Pulse Density Modulation Interface Controller (PDMIC) driver as a module. It's used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/c

[PATCH 4/4] ARM: multi_v7_defconfig: add the Atmel sama5d2-compatible ADC driver

2016-04-26 Thread Nicolas Ferre
Add the new sama5d2-compatible ADC driver as a module. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6a62ebbcae28..1aed38fd4337 100644

[PATCH 3/4] ARM: multi_v7_defconfig: add the Atmel Audio microphone interface PDMIC

2016-04-26 Thread Nicolas Ferre
Add the Atmel Pulse Density Modulation Interface Controller (PDMIC) driver as a module. It's used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm

[PATCH 1/4] ARM: multi_v7_defconfig: add Atmel watchdog timers

2016-04-26 Thread Nicolas Ferre
Add both Atmel watchdog timers to the multi_v7_defconfig. They are added as part of the kernel because it's a core piece of the system. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ar

[PATCH 2/4] ARM: multi_v7_defconfig: add Atmel ISI (Image Sensor Interface) driver

2016-04-26 Thread Nicolas Ferre
Add the Atmel Image Sensor Interface (ISI) VIDEO driver as a module. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig

[PATCH 1/4] ARM: multi_v7_defconfig: add Atmel watchdog timers

2016-04-26 Thread Nicolas Ferre
Add both Atmel watchdog timers to the multi_v7_defconfig. They are added as part of the kernel because it's a core piece of the system. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig

[PATCH 2/4] ARM: multi_v7_defconfig: add Atmel ISI (Image Sensor Interface) driver

2016-04-26 Thread Nicolas Ferre
Add the Atmel Image Sensor Interface (ISI) VIDEO driver as a module. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index d72ee27cecae

[PATCH] ARM: at91/defconfig: add PDMIC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add Pulse Density Modulation Interface Controller (PDMIC) driver compilation for sama5 default configuration. Is used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] ARM: at91/defconfig: add PDMIC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add Pulse Density Modulation Interface Controller (PDMIC) driver compilation for sama5 default configuration. Is used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs

[PATCH] ARM: at91/defconfig: add HLCDC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add the LCD DRM driver with all its dependencies: - the MFD driver - the backlight PWM - the simple panel driver Remove the CONFIG_FB as it is not needed on any sama5 device. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/sama5_defconfig | 9 +++--

[PATCH] ARM: at91/defconfig: add HLCDC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add the LCD DRM driver with all its dependencies: - the MFD driver - the backlight PWM - the simple panel driver Remove the CONFIG_FB as it is not needed on any sama5 device. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH] ARM: at91/defconfig: add the HDMA controller to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Selection of the HDMAC option is now needed to allow some sama5 devices to have the DMA driver compiled. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/ar

[PATCH] ARM: at91/defconfig: add the HDMA controller to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Selection of the HDMAC option is now needed to allow some sama5 devices to have the DMA driver compiled. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig

[PATCH] ARM: dts: at91: sama5d2: add slow clock to watchdog node

2016-04-26 Thread Nicolas Ferre
As the watchdog timer needs the slow clock, add it to the currently defined wdt node. Reported-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/boot/dts/sama5d2.dtsi | 1 + 1 file changed, 1 insertion(+)

[PATCH] ARM: dts: at91: sama5d2: add slow clock to watchdog node

2016-04-26 Thread Nicolas Ferre
As the watchdog timer needs the slow clock, add it to the currently defined wdt node. Reported-by: Alexandre Belloni Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d2.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2

[PATCH] ARM: dts: at91: sama5d2: add shutdown controller node

2016-04-26 Thread Nicolas Ferre
Add the SAMA5D2-Compatible Shutdown Controller node to sama5d2.dtsi and the use of it in the sama5d2 Xplained board dts file. Enable the RTC wakeup event and the "wake up" button support through the input "0" that is present on the board. Signed-off-by: Nicolas Ferre <

[PATCH] ARM: dts: at91: sama5d2: add shutdown controller node

2016-04-26 Thread Nicolas Ferre
Add the SAMA5D2-Compatible Shutdown Controller node to sama5d2.dtsi and the use of it in the sama5d2 Xplained board dts file. Enable the RTC wakeup event and the "wake up" button support through the input "0" that is present on the board. Signed-off-by: Nicolas Ferre --- ar

[PATCH] ARM: dts: at91: sama5d4: add watchdog interrupt property

2016-04-26 Thread Nicolas Ferre
The "interrupts" property is missing from the watchdog node. Add it with highest priority value of 7. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- arch/arm/boot/dts/sama5d4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/a

[PATCH] ARM: dts: at91: sama5d4: add watchdog interrupt property

2016-04-26 Thread Nicolas Ferre
The "interrupts" property is missing from the watchdog node. Add it with highest priority value of 7. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.

[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-26 Thread Nicolas Ferre
.@davemloft.net> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- Hi, Thanks for having reported this bug to me. I hope that we will be able to move forward for changing the phy reset code in the macb driver. I plan to queue this patch through arm-soc for 4.7. Thanks, best regar

[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-26 Thread Nicolas Ferre
Fix gpio active flag for the phy reset-gpios property. The line is active low instead of active high. Actually, this flags was never used by the macb driver. Reported-by: Sergei Shtylyov Cc: Andrew Lunn Cc: David Miller Signed-off-by: Nicolas Ferre --- Hi, Thanks for having reported this bug

[PATCH] ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description

2016-04-26 Thread Nicolas Ferre
rg # v4.4+ [nicolas.fe...@atmel.com: add commit message, changed subject] Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- Hi, I'll queue this patch in at91-4.7-dt branch. thanks, bye. arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description

2016-04-26 Thread Nicolas Ferre
ed subject] Signed-off-by: Nicolas Ferre --- Hi, I'll queue this patch in at91-4.7-dt branch. thanks, bye. arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfu

[PATCH] kbuild: fix call to adjust_autoksyms.sh when output directory specified

2016-04-25 Thread Nicolas Ferre
USED_KSYMS option is specified. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h") Cc: Nicolas Pitre <n...@linaro.org> Cc: Rusty Russell <ru...@rustcorp.com.au> --- Hi Nicolas, I found this issue while

[PATCH] kbuild: fix call to adjust_autoksyms.sh when output directory specified

2016-04-25 Thread Nicolas Ferre
USED_KSYMS option is specified. Signed-off-by: Nicolas Ferre Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h") Cc: Nicolas Pitre Cc: Rusty Russell --- Hi Nicolas, I found this issue while running on today's Linux-next with my ARM cross-compiler. I suspect it's the proper

Re: [PATCH 03/41] Documentation: arm: fix spelling mistakes

2016-04-25 Thread Nicolas Ferre
Le 25/04/2016 02:24, Eric Engestrom a écrit : > Signed-off-by: Eric Engestrom <e...@engestrom.ch> Hi, thanks for the patch: Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> > --- > Documentation/arm/Atmel/README | 2 +- > Documentation/arm/keystone/knav-

Re: [PATCH 03/41] Documentation: arm: fix spelling mistakes

2016-04-25 Thread Nicolas Ferre
Le 25/04/2016 02:24, Eric Engestrom a écrit : > Signed-off-by: Eric Engestrom Hi, thanks for the patch: Acked-by: Nicolas Ferre > --- > Documentation/arm/Atmel/README | 2 +- > Documentation/arm/keystone/knav-qmss.txt | 2 +- So, who will take care of this patch: c

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Nicolas Ferre
driver for Atmel PIO4 controller") > Cc: sta...@vger.kernel.org #v4.4 and later Yes, and I can add: Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> and more important: On a sama5d2 Xplained board: Tested-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thanks, bye. > ---

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Nicolas Ferre
r") > Cc: sta...@vger.kernel.org #v4.4 and later Yes, and I can add: Acked-by: Nicolas Ferre and more important: On a sama5d2 Xplained board: Tested-by: Nicolas Ferre Thanks, bye. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Nicolas Ferre
hsync_active | subdev->vsync_active | >>> + subdev->pclk_sample | ISC_PFE_CFG0_MODE_PROGRESSIVE; >>> + mask = ISC_PFE_CFG0_BPS_MASK | ISC_PFE_CFG0_HPOL_MASK | >>> + ISC_PFE_CFG0_VPOL_MASK | ISC_PFE_CFG0_PPOL_MASK | >>> + ISC_PFE_CFG0_MODE_MASK; >>> + >>> + regmap_update_bits(regmap, ISC_PFE_CFG0, mask, val); >>> + >>> + regmap_update_bits(regmap, ISC_RLP_CFG, ISC_RLP_CFG_MODE_MASK, >>> + current_fmt->reg_rlp_mode); >>> + >>> + regmap_update_bits(regmap, ISC_DCFG, ISC_DCFG_IMODE_MASK, >>> + current_fmt->reg_dcfg_imode); >>> + >>> + isc_set_pipeline(regmap, pipeline); >>> + >>> + /* Update profile */ >>> + regmap_update_bits(regmap, ISC_CTRLEN, >>> + ISC_CTRLEN_UPPRO_MASK, ISC_CTRLEN_UPPRO); >>> + >>> + regmap_read(regmap, ISC_CTRLSR, ); >>> + while (val & ISC_CTRLSR_UPPRO) { >>> + cpu_relax(); >>> + regmap_read(regmap, ISC_CTRLSR, ); >>> + } >> >> You need an exit condition here too in case the hardware gets stuck for some >> reason. It shouldn't happen in theory, and always does in practice :-) Absolutely. > Accept, I will add the number of iterations or a timer. Do you think > which is better? Is there any hints in the datasheet? Is the checking of CTRLSR is advised in the datasheet as well? Otherwise, you can contact the ISC designer to ask him what makes more sense to him. Laurent, thanks a lot for your valuable review! Bye, -- Nicolas Ferre

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Nicolas Ferre
current_fmt->reg_wb_cfg); >>> + regmap_update_bits(regmap, ISC_CFA_CFG, ISC_CFA_CFG_BAY_MASK, >>> + current_fmt->reg_cfa_cfg); >>> + } >>> + >>> + val |= subdev->hsync_active | subdev->

[RESEND PATCH] drm/panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
ameter is passed on the kernel cmdline. In some cases the user provided mode is preferred over the simple panel ones, which might result in unpredictable behavior. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Reviewed-by: Nicolas Ferre <nicolas.fe...@atmel.com> Tested

[RESEND PATCH] drm/panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
cases the user provided mode is preferred over the simple panel ones, which might result in unpredictable behavior. Signed-off-by: Boris Brezillon Reviewed-by: Nicolas Ferre Tested-by: Nicolas Ferre --- drivers/gpu/drm/panel/panel-simple.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
Le 28/05/2015 16:25, Boris Brezillon a écrit : > Hi Thierry, > > Could you have a look at this patch (a.k.a. ping) ? It's been a long time and... It seems that this patch doesn't apply anymore but: Reviewed-by: Nicolas Ferre <nicolas.fe...@atmel.com> So, I'm updating it and rese

Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
Le 28/05/2015 16:25, Boris Brezillon a écrit : > Hi Thierry, > > Could you have a look at this patch (a.k.a. ping) ? It's been a long time and... It seems that this patch doesn't apply anymore but: Reviewed-by: Nicolas Ferre So, I'm updating it and resending right now. Bye, > On

Re: [PATCH] tty/serial: atmel: fix hardware handshake selection

2016-04-15 Thread Nicolas Ferre
A controller can't drive RTS (as explain in the commit message). > Ensure that hardware flow control stays disabled when DMA is used and FIFOs > are not available. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Yes, I agree with the fix: Acked-by: N

Re: [PATCH] tty/serial: atmel: fix hardware handshake selection

2016-04-15 Thread Nicolas Ferre
A controller can't drive RTS (as explain in the commit message). > Ensure that hardware flow control stays disabled when DMA is used and FIFOs > are not available. > > Signed-off-by: Alexandre Belloni Yes, I agree with the fix: Acked-by: Nicolas Ferre We can also add the following

Re: [PATCH v6 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
tly accessed. > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Thanks for the quick rework Boris! Reviewed-by: Nicolas Ferre <nicolas.fe...@atmel.com> > --- > drivers/mtd/nand/atmel_nand.c | 50 > +++ > 1 fi

Re: [PATCH v6 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
tly accessed. > > Signed-off-by: Boris Brezillon Thanks for the quick rework Boris! Reviewed-by: Nicolas Ferre > --- > drivers/mtd/nand/atmel_nand.c | 50 > +++ > 1 file changed, 31 insertions(+), 19 deletions(-) > > diff --git a/dri

Re: [PATCH v5 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
C controller > + * waits for NAND_CMD_RNDOUTSTART after the NAND_CMD_RNDOUT. > + * Anyway, for small pages, the first ECC byte is at offset > + * 0 in the OOB area. >*/ > chip->cmdfunc(mtd, NAND_CMD_RNDOUT, > - mtd->writesize + eccpos[0], -1); > + mtd->writesize + oobregion.offset, -1); > } > > /* the ECC controller needs to read the ECC just after the data */ > - ecc_pos = oob + eccpos[0]; > + ecc_pos = oob + oobregion.offset; > chip->read_buf(mtd, ecc_pos, eccbytes); > > /* check if there's an error */ > -- Nicolas Ferre

Re: [PATCH v5 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
* waits for NAND_CMD_RNDOUTSTART after the NAND_CMD_RNDOUT. > + * Anyway, for small pages, the first ECC byte is at offset > + * 0 in the OOB area. >*/ > chip->cmdfunc(mtd, NAND_CMD_RNDOUT, > - mtd->writesize + eccpos[0], -1); > + mtd->writesize + oobregion.offset, -1); > } > > /* the ECC controller needs to read the ECC just after the data */ > - ecc_pos = oob + eccpos[0]; > + ecc_pos = oob + oobregion.offset; > chip->read_buf(mtd, ecc_pos, eccbytes); > > /* check if there's an error */ > -- Nicolas Ferre

Re: [PATCH v5 22/50] mtd: nand: atmel: switch to mtd_ooblayout_ops

2016-04-13 Thread Nicolas Ferre
Le 30/03/2016 18:14, Boris Brezillon a écrit : > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> It seems good: Reviewed-by: Nicolas Ferre <nicolas.

Re: [PATCH v5 22/50] mtd: nand: atmel: switch to mtd_ooblayout_ops

2016-04-13 Thread Nicolas Ferre
Le 30/03/2016 18:14, Boris Brezillon a écrit : > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. > > Signed-off-by: Boris Brezillon It seems good: Reviewed-by: Nicolas Ferre Bye, > --- > drivers/mtd/nand

Re: [PATCH 02/12] mtd: nand: atmel: rely on generic DT parsing done in nand_scan_ident()

2016-04-13 Thread Nicolas Ferre
y: Boris Brezillon <boris.brezil...@free-electrons.com> It seems okay: Reviewed-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thanks Boris, bye, > --- > drivers/mtd/nand/atmel_nand.c | 133 > +++--- > 1 file changed, 73 insertions(+), 60 delet

Re: [PATCH 02/12] mtd: nand: atmel: rely on generic DT parsing done in nand_scan_ident()

2016-04-13 Thread Nicolas Ferre
ezillon It seems okay: Reviewed-by: Nicolas Ferre Thanks Boris, bye, > --- > drivers/mtd/nand/atmel_nand.c | 133 > +++--- > 1 file changed, 73 insertions(+), 60 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/m

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:54, Sergei Shtylyov a écrit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > >>>> With the 'phylib' now being aware of the "reset-gpios" PHY node >>>> property, >>>> there should be no need to frob the

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:54, Sergei Shtylyov a écrit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > >>>> With the 'phylib' now being aware of the "reset-gpios" PHY node >>>> property, >>>> there should be no need to frob the

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:40, Andrew Lunn a écrit : > On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: >> Le 11/04/2016 04:28, Andrew Lunn a écrit : >>> On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >>>> With the 'phylib' now being aware

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:40, Andrew Lunn a écrit : > On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: >> Le 11/04/2016 04:28, Andrew Lunn a écrit : >>> On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >>>> With the 'phylib' now being aware

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
rrently works. > >>> You potentially need to add a new property and deprecate the old one. >> >>I would like to avoid that... > > You will need the agreement from the at91-vinco maintainer. If the at91-vinco has to be modified, you have my agreement that it can be modified. Bye, -- Nicolas Ferre

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
rrently works. > >>> You potentially need to add a new property and deprecate the old one. >> >>I would like to avoid that... > > You will need the agreement from the at91-vinco maintainer. If the at91-vinco has to be modified, you have my agreement that it can be modified. Bye, -- Nicolas Ferre

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
sed, but are now > going to be used and thus break... Flag was used and you are saying that it's taken into account in new code... So, what's the issue? I see a difference in the way the "value" of gpiod_* functions is used. There may be a misunderstanding here... Bye, -- Nicolas Ferre

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
rrect to me (I mean, with proper flag specification). > property, i.e. active low. The new code in the previous patch does > however take the flags into account. Did you check if there are any > device trees which have flags, which were never used, but are now > going to be used and thus break... Flag was used and you are saying that it's taken into account in new code... So, what's the issue? I see a difference in the way the "value" of gpiod_* functions is used. There may be a misunderstanding here... Bye, -- Nicolas Ferre

[GIT PULL] at91: dt for 4.7 #1

2016-03-29 Thread Nicolas Ferre
ler's node Cyrille Pitchen (1): ARM: dts: at91: sama5d2: add SFR node Ludovic Desroches (1): ARM: dts: at91: sama5d2: add chipid node Nicolas Ferre (1): ARM: dts: at91: sama5d2: add LCD controller .../devicetree/bindings/arm/atmel-at91.txt

[GIT PULL] at91: dt for 4.7 #1

2016-03-29 Thread Nicolas Ferre
ler's node Cyrille Pitchen (1): ARM: dts: at91: sama5d2: add SFR node Ludovic Desroches (1): ARM: dts: at91: sama5d2: add chipid node Nicolas Ferre (1): ARM: dts: at91: sama5d2: add LCD controller .../devicetree/bindings/arm/atmel-at91.txt

[GIT PULL] at91: soc for 4.7 #1

2016-03-29 Thread Nicolas Ferre
arch/arm/mach-at91/soc.h | 12 +++- 4 files changed, 97 insertions(+), 20 deletions(-) -- Nicolas Ferre

[GIT PULL] at91: soc for 4.7 #1

2016-03-29 Thread Nicolas Ferre
arch/arm/mach-at91/soc.h | 12 +++- 4 files changed, 97 insertions(+), 20 deletions(-) -- Nicolas Ferre

[PATCH v2 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
atmel.com> [nicolas.fe...@atmel.com: remove useless warnings] Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> [a...@arndb.de: suggest to use static functions to red

[PATCH v2 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
-by: Alexandre Belloni Acked-by: Rob Herring Signed-off-by: Nicolas Ferre [a...@arndb.de: suggest to use static functions to reduce scope] --- .../devicetree/bindings/arm/atmel-at91.txt | 4 ++ arch/arm/mach-at91/soc.c | 81 +- 2 files

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
> >> + >> +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid) >> +{ >> > > These should both be 'static', right? Absolutely. I modify this right now and repost a patch. Bye, -- Nicolas Ferre

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
> >> + >> +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid) >> +{ >> > > These should both be 'static', right? Absolutely. I modify this right now and repost a patch. Bye, -- Nicolas Ferre

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
Le 23/03/2016 14:47, Alexandre Belloni a écrit : > On 23/03/2016 at 12:22:49 +0100, Nicolas Ferre wrote : >> Le 18/03/2016 11:34, Alexandre Belloni a écrit : >>> On 18/03/2016 at 08:21:19 +0100, Ludovic Desroches wrote : >>>> So far, the CIDR and EXID regist

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
Le 23/03/2016 14:47, Alexandre Belloni a écrit : > On 23/03/2016 at 12:22:49 +0100, Nicolas Ferre wrote : >> Le 18/03/2016 11:34, Alexandre Belloni a écrit : >>> On 18/03/2016 at 08:21:19 +0100, Ludovic Desroches wrote : >>>> So far, the CIDR and EXID regist

Re: [PATCH] ARM: at91/dt: sama5d2: add LCD controller

2016-03-29 Thread Nicolas Ferre
Le 10/03/2016 14:31, Nicolas Ferre a écrit : > Note to myself: change the $subject line to: > ARM: dts: at91: sama5d2: add LCD controller > > :-) With $subject changed, queued in at91-4.7-dt branch. > Le 10/03/2016 14:25, Nicolas Ferre a écrit : >> Add LCD contr

Re: [PATCH] ARM: at91/dt: sama5d2: add LCD controller

2016-03-29 Thread Nicolas Ferre
Le 10/03/2016 14:31, Nicolas Ferre a écrit : > Note to myself: change the $subject line to: > ARM: dts: at91: sama5d2: add LCD controller > > :-) With $subject changed, queued in at91-4.7-dt branch. > Le 10/03/2016 14:25, Nicolas Ferre a écrit : >> Add LCD contr

Re: [PATCH] clockevents/drivers/timer-atmel-pit: fix double free_irq

2016-03-29 Thread Nicolas Ferre
ly against the > next tree of today. Sure, we can still take it now. We will certainly embed it in a future TC rework. Thanks. > So I will apply this to get rid of the warning. And if you manage not to > use the PIT during boot then we won't have the free_irq() mess which is > good. > > Sebastian > -- Nicolas Ferre

Re: [PATCH] clockevents/drivers/timer-atmel-pit: fix double free_irq

2016-03-29 Thread Nicolas Ferre
ly against the > next tree of today. Sure, we can still take it now. We will certainly embed it in a future TC rework. Thanks. > So I will apply this to get rid of the warning. And if you manage not to > use the PIT during boot then we won't have the free_irq() mess which is > good. > > Sebastian > -- Nicolas Ferre

Re: [PATCH] arm: at91: do not disable/enable clocks in a row

2016-03-29 Thread Nicolas Ferre
<alexandre.bell...@free-electrons.com> > Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Absolutely makes sense: Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thanks. &

Re: [PATCH] arm: at91: do not disable/enable clocks in a row

2016-03-29 Thread Nicolas Ferre
elloni > Acked-by: Alexandre Belloni > Signed-off-by: Sebastian Andrzej Siewior Absolutely makes sense: Acked-by: Nicolas Ferre Thanks. > --- > drivers/clocksource/tcb_clksrc.c | 33 + > 1 file changed, 29 insertions(+), 4 deletions(-) > &

Re: [PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

2016-03-24 Thread Nicolas Ferre
ework of Neil's patch that was standing for a long time in my backlog ;-). Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Bye, > --- > drivers/net/ethernet/cadence/macb.c | 59 > ++--- > 1 file changed, 49 insertions(+), 10 deletions(-) > >

Re: [PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

2016-03-24 Thread Nicolas Ferre
ing for a long time in my backlog ;-). Acked-by: Nicolas Ferre Bye, > --- > drivers/net/ethernet/cadence/macb.c | 59 > ++--- > 1 file changed, 49 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c > b/dr

Re: [PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR

2016-03-24 Thread Nicolas Ferre
nterrupt Disable Register > IMR: Interrupt Mask Register > > Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> > Fixes: bfbb92c44670 ("net: macb: Handle the RXUBR interrupt on all devices") Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thanks! > -

Re: [PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR

2016-03-24 Thread Nicolas Ferre
nterrupt Disable Register > IMR: Interrupt Mask Register > > Signed-off-by: Cyrille Pitchen > Fixes: bfbb92c44670 ("net: macb: Handle the RXUBR interrupt on all devices") Acked-by: Nicolas Ferre Thanks! > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-24 Thread Nicolas Ferre
Le 23/03/2016 22:11, Sebastian Reichel a écrit : > Hi Nicolas, > > On Wed, Mar 23, 2016 at 12:18:46PM +0100, Nicolas Ferre wrote: >> Le 16/03/2016 14:19, Nicolas Ferre a écrit : >>> This is a series to add driver for a new Atmel Shutdown Controller. This >>>

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-24 Thread Nicolas Ferre
Le 23/03/2016 22:11, Sebastian Reichel a écrit : > Hi Nicolas, > > On Wed, Mar 23, 2016 at 12:18:46PM +0100, Nicolas Ferre wrote: >> Le 16/03/2016 14:19, Nicolas Ferre a écrit : >>> This is a series to add driver for a new Atmel Shutdown Controller. This >>>

Re: [RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-23 Thread Nicolas Ferre
Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> I'll queue it in our upcoming at91-4.7-dt branch. Thanks! Bye, > --- > Documentation/devicetree/bindings/arm/atmel-at91.txt | 2 +- > arch/arm/boot/dts/sama5d

Re: [RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-23 Thread Nicolas Ferre
Le 17/03/2016 17:04, Ludovic Desroches a écrit : > From: Cyrille Pitchen > > This SFR node is looked up by the I2S controller driver to tune the > SFR_I2SCLKSEL register. > > Signed-off-by: Cyrille Pitchen > Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-23 Thread Nicolas Ferre
dings/arm/atmel-at91.txt | 4 ++ >> arch/arm/mach-at91/soc.c | 81 >> +- We may need to split this patch in 2 for going through separate arm-soc branches: what do you think Alexandre? Anyway, I can do it myself: no need to re-send a

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-23 Thread Nicolas Ferre
| 81 >> +- We may need to split this patch in 2 for going through separate arm-soc branches: what do you think Alexandre? Anyway, I can do it myself: no need to re-send a version: Acked-by: Nicolas Ferre We'll queue it in our upcoming at91-4.7-dt a

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-23 Thread Nicolas Ferre
Le 16/03/2016 14:19, Nicolas Ferre a écrit : > This is a series to add driver for a new Atmel Shutdown Controller. This new > IP > is extensible and some features will be added later (see the TODO section). > Its extensible nature led to write a new binding so that wake-up

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-23 Thread Nicolas Ferre
Le 16/03/2016 14:19, Nicolas Ferre a écrit : > This is a series to add driver for a new Atmel Shutdown Controller. This new > IP > is extensible and some features will be added later (see the TODO section). > Its extensible nature led to write a new binding so that wake-up

[GIT PULL] at91: fixes for 4.6 #1

2016-03-22 Thread Nicolas Ferre
don't disable hsmci regulator ARM: dts: at91: sama5d4 Xplained: don't disable hsmci regulator arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 2 files changed, 2 insertions(+) -- Nicolas Ferre

[GIT PULL] at91: fixes for 4.6 #1

2016-03-22 Thread Nicolas Ferre
don't disable hsmci regulator ARM: dts: at91: sama5d4 Xplained: don't disable hsmci regulator arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 2 files changed, 2 insertions(+) -- Nicolas Ferre

Re: [PATCH] ARM: at91/dt: sama5d3 xplained: don't disable hsmci regulator

2016-03-22 Thread Nicolas Ferre
> Fixes: 1b53e3416dd0 ("ARM: at91/dt: sama5d3 xplained: add fixed > regulator for vmmc0") > Cc: sta...@vger.kernel.org #4.3 and later Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Like the one about sama5d4 Xplained, I changed the $subject prefix and stacked both on to

<    3   4   5   6   7   8   9   10   11   12   >