Re: [PATCH] MIPS: mips-cm: CM regions are disabled at boot

2014-11-20 Thread Niklas Svensson
On 11/20/2014 01:34 PM, Paul Burton wrote: > On Thu, Nov 20, 2014 at 01:29:00PM +0100, Niklas Svensson wrote: >> Each CM_REGION_TARGET is set to disabled at boot, > > That part is true... > >> so there is no need to disable the matching >> CM_GCR_R

[PATCH] MIPS: mips-cm: CM regions are disabled at boot

2014-11-20 Thread Niklas Svensson
Each CM_REGION_TARGET is set to disabled at boot, so there is no need to disable the matching CM_GCR_REG explicitly. Signed-off-by: Niklas Svensson --- arch/mips/kernel/mips-cm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips

[PATCH] MIPS: mips-cm: CM regions are disabled at boot

2014-11-20 Thread Niklas Svensson
Each CM_REGION_TARGET is set to disabled at boot, so there is no need to disable the matching CM_GCR_REG explicitly. Signed-off-by: Niklas Svensson nikl...@axis.com --- arch/mips/kernel/mips-cm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/mips/kernel/mips-cm.c b/arch

Re: [PATCH] MIPS: mips-cm: CM regions are disabled at boot

2014-11-20 Thread Niklas Svensson
On 11/20/2014 01:34 PM, Paul Burton wrote: On Thu, Nov 20, 2014 at 01:29:00PM +0100, Niklas Svensson wrote: Each CM_REGION_TARGET is set to disabled at boot, That part is true... so there is no need to disable the matching CM_GCR_REG explicitly. ...however there is no guarantee

[PATCH RESEND] staging: skein: fixed sparse warnings related to static declarations

2014-11-19 Thread Niklas Svensson
'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson Acked-by: Jason Cooper --- drivers/staging/skein/skein_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein

[PATCH RESEND] staging: skein: fixed sparse warnings related to static declarations

2014-11-19 Thread Niklas Svensson
'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson n...@flawful.org Acked-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Niklas Svensson
On 11/08/2014 08:56 PM, Jason Cooper wrote: > On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: >> drivers/staging/skein/skein_generic.c:30:5: warning: symbol >> 'skein256_update' was not declared. Should it be static? >> drivers/staging/skein/skein_generic.c:

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Niklas Svensson
On 11/08/2014 08:56 PM, Jason Cooper wrote: On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol

[PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-08 Thread Niklas Svensson
'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson --- drivers/staging/skein/skein_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 60d16b6

[PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-08 Thread Niklas Svensson
'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson n...@flawful.org --- drivers/staging/skein/skein_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein

[PATCH] staging: comedi: fixing coding style problems

2014-08-06 Thread Niklas Svensson
"%s: %i microvolt, %li microsecond waveform attached\n", Task of Eudyptula challenge. Signed-off-by: Niklas Svensson --- drivers/staging/comedi/drivers/comedi_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/c

[PATCH] staging: comedi: fixing coding style problems

2014-08-06 Thread Niklas Svensson
microvolt, %li microsecond waveform attached\n, Task of Eudyptula challenge. Signed-off-by: Niklas Svensson n...@flawful.org --- drivers/staging/comedi/drivers/comedi_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b

[PATCH] drivers/staging/comedi/drivers/comedi_test.c: fixed coding style problems

2014-08-05 Thread Niklas Svensson
Fixed checkpatch.pl warnings Signed-off-by: Niklas Svensson --- drivers/staging/comedi/drivers/comedi_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c index 845a679

[PATCH] drivers/staging/comedi/drivers/comedi_test.c: fixed coding style problems

2014-08-05 Thread Niklas Svensson
Fixed checkpatch.pl warnings Signed-off-by: Niklas Svensson n...@flawful.org --- drivers/staging/comedi/drivers/comedi_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c