[PATCH] scsi: aacraid: error: testing array offset 'bus' after use

Fix possible indexing array of bound for >hba_map[bus][cid], where bus and cid boundary check happens later. Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/a

[PATCH] scsi: aacraid: error: testing array offset 'bus' after use

Fix possible indexing array of bound for >hba_map[bus][cid], where bus and cid boundary check happens later. Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") Signed-off-by: Nikola Pajkovsky --- drivers/scsi/aacraid/linit.c | 20 1 fil

[PATCH 1/3] scsi: aacraid: fix indentation errors

fix stupid indent error, no rocket science here. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/comminit.c | 6 +++--- drivers/scsi/aacraid/linit.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aacraid/comminit.c b/d

[PATCH 1/3] scsi: aacraid: fix indentation errors

fix stupid indent error, no rocket science here. Signed-off-by: Nikola Pajkovsky --- drivers/scsi/aacraid/comminit.c | 6 +++--- drivers/scsi/aacraid/linit.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid

[PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

aac_convert_sgraw2() kmalloc memory and return -1 on error, which should be -ENOMEM. However, nobody is checking return value, so with this change, -ENOMEM is propagated to upper layer. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/aachba.c | 10 +++---

[PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

aac_convert_sgraw2() kmalloc memory and return -1 on error, which should be -ENOMEM. However, nobody is checking return value, so with this change, -ENOMEM is propagated to upper layer. Signed-off-by: Nikola Pajkovsky --- drivers/scsi/aacraid/aachba.c | 10 +++--- 1 file changed, 7

[PATCH 2/3] scsi: aacraid: get rid of one level of indentation

other code has changed. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/aachba.c | 267 +- 1 file changed, 131 insertions(+), 136 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aa

[PATCH 2/3] scsi: aacraid: get rid of one level of indentation

other code has changed. Signed-off-by: Nikola Pajkovsky --- drivers/scsi/aacraid/aachba.c | 267 +- 1 file changed, 131 insertions(+), 136 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index a1a2c71e1626..3c3547

Re: [RFC] drm/amd/amdgpu: get rid of else branch

Christian König <christian.koe...@amd.com> writes: > Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: >> This is super simple elimination of else branch and I should >> probably even use unlikely in >> >> if (ring->count_dw < count_dw) { >>

Re: [RFC] drm/amd/amdgpu: get rid of else branch

Christian König writes: > Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: >> This is super simple elimination of else branch and I should >> probably even use unlikely in >> >> if (ring->count_dw < count_dw) { >> >> However, amdgpu_ri

[PATCH] drm/amd/amdgpu: get rid of else branch

else branch is pointless if it's right at the end of function and use unlikely() on err path. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff

[PATCH] drm/amd/amdgpu: get rid of else branch

else branch is pointless if it's right at the end of function and use unlikely() on err path. Signed-off-by: Nikola Pajkovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [PATCH 0/6] md: Fine-tuning for some function implementations

NeilBrown writes: > On Tue, May 02 2017, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Tue, 2 May 2017 16:12:34 +0200 >> >> Some update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring

Re: [PATCH 0/6] md: Fine-tuning for some function implementations

NeilBrown writes: > On Tue, May 02 2017, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Tue, 2 May 2017 16:12:34 +0200 >> >> Some update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring (6): >> Replace seven seq_printf() calls by

[RFC] drm/amd/amdgpu: get rid of else branch

This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks suspicious. On error, we still adding v to ring and keeping

[RFC] drm/amd/amdgpu: get rid of else branch

This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks suspicious. On error, we still adding v to ring and keeping

[tip:x86/cleanups] x86/pci-calgary: Fix iommu_free() comparison of unsigned expression >= 0

Commit-ID: 68dee8e2f2cacc54d038394e70d22411dee89da2 Gitweb: http://git.kernel.org/tip/68dee8e2f2cacc54d038394e70d22411dee89da2 Author: Nikola Pajkovsky <npajkov...@suse.cz> AuthorDate: Tue, 15 Nov 2016 09:47:49 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/cleanups] x86/pci-calgary: Fix iommu_free() comparison of unsigned expression >= 0

Commit-ID: 68dee8e2f2cacc54d038394e70d22411dee89da2 Gitweb: http://git.kernel.org/tip/68dee8e2f2cacc54d038394e70d22411dee89da2 Author: Nikola Pajkovsky AuthorDate: Tue, 15 Nov 2016 09:47:49 +0100 Committer: Thomas Gleixner CommitDate: Sat, 4 Feb 2017 09:27:06 +0100 x86/pci-calgary

[PATCH] iommu: fix iommu_free() comparison of unsigned expression >= 0

-calgary_64.c: In function ‘iommu_free’: arch/x86/kernel/pci-calgary_64.c:299:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (unlikely((dma_addr >= DMA_ERROR_CODE) && (dma_addr < badend))) { Fixes: 8fd524b355da ("x86: Kill bad_dma_addre

[PATCH] iommu: fix iommu_free() comparison of unsigned expression >= 0

-calgary_64.c: In function ‘iommu_free’: arch/x86/kernel/pci-calgary_64.c:299:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (unlikely((dma_addr >= DMA_ERROR_CODE) && (dma_addr < badend))) { Fixes: 8fd524b355da ("x86: Kill bad_dma_addre

Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()

Gu Zheng writes: > On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote: > >> Gu Zheng writes: >> >>> As we remove the target single node, so list_for_each is enought, in order >>> to >>> clean up, we use list_for_each_entry instead. >>

Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()

Gu Zheng guz.f...@cn.fujitsu.com writes: On 07/22/2013 11:36 PM, Nikola Pajkovsky wrote: Gu Zheng guz.f...@cn.fujitsu.com writes: As we remove the target single node, so list_for_each is enought, in order to clean up, we use list_for_each_entry instead. Signed-off-by: Gu Zheng guz.f

Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()

Gu Zheng writes: > As we remove the target single node, so list_for_each is enought, in order to > clean up, we use list_for_each_entry instead. > > Signed-off-by: Gu Zheng > --- > fs/f2fs/checkpoint.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode()

Gu Zheng guz.f...@cn.fujitsu.com writes: As we remove the target single node, so list_for_each is enought, in order to clean up, we use list_for_each_entry instead. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- fs/f2fs/checkpoint.c |5 ++--- 1 files changed, 2 insertions(+), 3

Re: [PATCH 1/1] Staging: bcm: Fix of various code style issues.

Severin Gsponer writes: > Changed comment style to C89 in Version.h > Fixed some whitespace issues in Typedefs.h > Changed comment style to C89 in vendorspecificextn.c > All issues found with checkpatch.pl > > Signed-off-by: Severin Gsponer > --- > drivers/staging/bcm/Typedefs.h |

Re: [PATCH 1/1] Staging: bcm: Fix of various code style issues.

Severin Gsponer svgspo...@gmail.com writes: Changed comment style to C89 in Version.h Fixed some whitespace issues in Typedefs.h Changed comment style to C89 in vendorspecificextn.c All issues found with checkpatch.pl Signed-off-by: Severin Gsponer svgspo...@gmail.com ---

Re: [PATCH] ipc: use list_for_each_entry for list traversing

Andrew Morton writes: > On Fri, 5 Apr 2013 15:42:11 +0200 Nikola Pajkovsky > wrote: > >> the ipc/msg.c code does all list operations by hand and it open-codes >> the accesses, instead of using for_each_entry. >> >> ... >> >> --- a/ipc/msg.c >

Re: [PATCH] ipc: use list_for_each_entry for list traversing

Andrew Morton a...@linux-foundation.org writes: On Fri, 5 Apr 2013 15:42:11 +0200 Nikola Pajkovsky npajk...@redhat.com wrote: the ipc/msg.c code does all list operations by hand and it open-codes the accesses, instead of using for_each_entry. ... --- a/ipc/msg.c +++ b/ipc/msg.c

[PATCH] ipc: use list_for_each_entry for list traversing

the ipc/msg.c code does all list operations by hand and it open-codes the accesses, instead of using for_each_entry. Signed-off-by: Nikola Pajkovsky --- ipc/msg.c | 35 --- 1 files changed, 8 insertions(+), 27 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c

[PATCH] ipc: use list_for_each_entry for list traversing

the ipc/msg.c code does all list operations by hand and it open-codes the accesses, instead of using for_each_entry. Signed-off-by: Nikola Pajkovsky npajk...@redhat.com --- ipc/msg.c | 35 --- 1 files changed, 8 insertions(+), 27 deletions(-) diff --git a/ipc

Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata

| 2 -- > 1 file changed, 2 deletions(-) Acked-by: Nikola Pajkovsky -- Nikola -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/5] BLOCK: rbd, return proper error from rbd_dev_probe_update_spec

tions(+), 1 deletion(-) Acked-by: Nikola Pajkovsky -- Nikola -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/5] BLOCK: rbd, return proper error from rbd_dev_probe_update_spec

deletion(-) Acked-by: Nikola Pajkovsky npajk...@redhat.com -- Nikola -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata

| 2 -- 1 file changed, 2 deletions(-) Acked-by: Nikola Pajkovsky npajk...@redhat.com -- Nikola -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] amd_iommu_init: remove __init from amd_iommu_erratum_746_workaround

e function .init.text:amd_iommu_erratum_746_workaround() The function iommu_init_pci() references the function __init amd_iommu_erratum_746_workaround(). This is often because iommu_init_pci lacks a __init annotation or the annotation of amd_iommu_erratum_746_workaround is wrong. Signed-off-by: Nikola

[PATCH] amd_iommu_init: remove __init from amd_iommu_erratum_746_workaround

.init.text:amd_iommu_erratum_746_workaround() The function iommu_init_pci() references the function __init amd_iommu_erratum_746_workaround(). This is often because iommu_init_pci lacks a __init annotation or the annotation of amd_iommu_erratum_746_workaround is wrong. Signed-off-by: Nikola Pajkovsky npajk

Re: i915_hangcheck_hung problem with 3.8-rc2+ (Linus's latest tree)

Daniel Vetter writes: > On Mon, Jan 14, 2013 at 7:58 AM, Nikola Pajkovsky wrote: >> Daniel Vetter writes: >> >>> On Fri, Jan 11, 2013 at 6:26 PM, Nikola Pajkovsky >>> wrote: >>>> bug still kicking even w/ (drm/i915: Revert shrinker changes f

Re: i915_hangcheck_hung problem with 3.8-rc2+ (Linus's latest tree)

Daniel Vetter daniel.vet...@ffwll.ch writes: On Mon, Jan 14, 2013 at 7:58 AM, Nikola Pajkovsky npajk...@redhat.com wrote: Daniel Vetter daniel.vet...@ffwll.ch writes: On Fri, Jan 11, 2013 at 6:26 PM, Nikola Pajkovsky npajk...@redhat.com wrote: bug still kicking even w/ (drm/i915: Revert

Re: i915_hangcheck_hung problem with 3.8-rc2+ (Linus's latest tree)

Dave Kleikamp writes: > On 01/09/2013 01:44 PM, Dave Kleikamp wrote: >> >> I can easily reproduce it running glxgears on 3.8-rc1 or 3.8-rc2. >> >> 00:02.0 VGA compatible controller [0300]: Intel Corporation Core >> Processor Integrated Graphics Controller [8086:0046] (rev 02) >> >> Thinkpad

Re: i915_hangcheck_hung problem with 3.8-rc2+ (Linus's latest tree)

Dave Kleikamp dave.kleik...@oracle.com writes: On 01/09/2013 01:44 PM, Dave Kleikamp wrote: I can easily reproduce it running glxgears on 3.8-rc1 or 3.8-rc2. 00:02.0 VGA compatible controller [0300]: Intel Corporation Core Processor Integrated Graphics Controller [8086:0046] (rev 02)

Re: WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

Daniel Vetter writes: > On Tue, Dec 11, 2012 at 1:31 PM, Nikola Pajkovsky wrote: >> looks like we still have some oops in i915. i915 maintainers do you have >> any ideas what's going on? I will try to trigger that oops later today >> and provide more information. >

WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

Hey folks, looks like we still have some oops in i915. i915 maintainers do you have any ideas what's going on? I will try to trigger that oops later today and provide more information. [10733.442608] WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

Hey folks, looks like we still have some oops in i915. i915 maintainers do you have any ideas what's going on? I will try to trigger that oops later today and provide more information. [10733.442608] WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

Re: WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437 i915_gem_object_pin+0x151/0x1a0()

Daniel Vetter daniel.vet...@ffwll.ch writes: On Tue, Dec 11, 2012 at 1:31 PM, Nikola Pajkovsky npajk...@redhat.com wrote: looks like we still have some oops in i915. i915 maintainers do you have any ideas what's going on? I will try to trigger that oops later today and provide more

[PATCH] udf: fix retun value on error path in udf_load_logicalvol

In case we detect a problem and bail out, we fail to set "ret" to a nonzero value, and udf_load_logicalvol will mistakenly report success. Signed-off-by: Nikola Pajkovsky --- fs/udf/super.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/udf/super.

[PATCH] udf: fix retun value on error path in udf_load_logicalvol

In case we detect a problem and bail out, we fail to set ret to a nonzero value, and udf_load_logicalvol will mistakenly report success. Signed-off-by: Nikola Pajkovsky npajk...@redhat.com --- fs/udf/super.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/udf