.
Authored-by: Gregory Nowak
Submitted-by: Okash Khawaja
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/sysfs-driver-speakup | 369 +++
1 file changed, 369 insertions(+)
create mode 100644 drivers/staging/speakup/sysfs-driver-speakup
diff --git a/drivers/staging/speakup/sysfs
.
Authored-by: Gregory Nowak
Submitted-by: Okash Khawaja
---
drivers/staging/speakup/sysfs-driver-speakup | 369 +++
1 file changed, 369 insertions(+)
create mode 100644 drivers/staging/speakup/sysfs-driver-speakup
diff --git a/drivers/staging/speakup/sysfs-driver-speakup
b/drivers
On Fri, Sep 20, 2019 at 8:46 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Sep 18, 2019 at 01:30:33PM -0700, Gregory Nowak wrote:
> > > Extra line between each attribute (before the "What:" line) would be
> > > nice.
> >
> > In a previous post above, you wrote:
> > On Mon, Sep 16, 2019 at 04:11:00PM
Ah it looks like the spaces after Description: need to be converted into tabs.
Thanks,
Okash
On Tue, Sep 17, 2019 at 10:35 PM Okash Khawaja wrote:
>
> Hi Greg,
>
> You're right, I got none of those emails. Thanks. Is it all taken care of?
>
> Best regards,
> Okash
>
>
On Sun, Sep 15, 2019 at 2:43 PM Greg Kroah-Hartman
wrote:
>
> On Sat, Sep 14, 2019 at 10:08:35PM +0100, Okash Khawaja wrote:
> > On Mon, Sep 9, 2019 at 3:55 AM Gregory Nowak wrote:
> > >
> > > On Sun, Sep 08, 2019 at 10:43:02AM +0100, Okash Khawaja wrote:
> >
On Mon, Sep 9, 2019 at 3:55 AM Gregory Nowak wrote:
>
> On Sun, Sep 08, 2019 at 10:43:02AM +0100, Okash Khawaja wrote:
> > Sorry, I have only now got round to working on this. It's not complete
> > yet but I have assimilated the feedback and converted subjective
> >
Next step will be to convert the format to match Documentation/ABI/
requirements.
Thanks,
Okash
On Wed, Aug 21, 2019 at 11:23 PM Gregory Nowak wrote:
>
> On Wed, Aug 21, 2019 at 09:39:25AM -0700, Okash Khawaja wrote:
> > Hi Greg N,
> >
> > Would like to send this as a patch as Gre
On Thu, Jul 25, 2019 at 3:49 AM John Covici wrote:
>
> I think the program is genmap, I have it in my init sequence, but I
> am not sure it does anything at this point.
>
> On Thu, 25 Jul 2019 00:04:07 -0400,
> Chris Brannon wrote:
> >
> > Gregory Nowak writes:
> >
> > > keymap
> > > I believe
On Fri, Jul 12, 2019 at 9:38 AM Greg Kroah-Hartman
wrote:
>
> On Sun, Jul 07, 2019 at 08:57:10AM +0200, Greg Kroah-Hartman wrote:
> > On Sat, Jul 06, 2019 at 08:08:57PM +0100, Okash Khawaja wrote:
> > > On Fri, 15 Mar 2019 20:18:31 -0700
> > > Greg Kroah-Hartman wr
On Fri, 15 Mar 2019 20:18:31 -0700
Greg Kroah-Hartman wrote:
> On Fri, Mar 15, 2019 at 01:01:27PM +0000, Okash Khawaja wrote:
> > Hi,
> >
> > We have made progress on the items in TODO file of speakup driver in
> > staging directory and wanted to get some clarity
Hi,
The v2 renames set_selection() and do_set_selection() to following
more explicit names:
set_selection_user() /* includes copying data from user space */
set_selection_kernel() /* no copying from user space */
The patches also update references to set_selection() to be
forever.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/selection.c | 212 +++-
drivers/staging/speakup/speakup.h | 1 +
3 files changed, 88 insertions
() and fixing for name change. It also
exports set_selection_kernel() and paste_selection().
These changes are used the following patch where speakup's selection
functionality calls into the above functions, thereby doing away with
parallel implementation.
Signed-off-by: Okash Khawaja
Reviewed
doing away with
parallel implementation.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/tty/vt/selection.c | 37 -
include/linux/selection.h | 3 +--
2 files changed, 25 insertions(+), 15 deletions(-)
diff
.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/selection.c | 212 +++-
drivers/staging/speakup/speakup.h | 1 +
3 files changed, 88 insertions(+), 126 deletions
Hi,
Speakup's selection functionality parallels that of
drivers/tty/vt/selection.c. This patch set replaces speakup's
implementation with calls to vt's selection code. This is one of the
remaining items in our TODO file and it's needed for moving speakup out
of staging.
Please note that in
On Tue, 19 Mar 2019 16:31:21 +
Alan Cox wrote:
> On Sat, 16 Mar 2019 10:35:43 +0100
> Samuel Thibault wrote:
>
> > Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit:
> > > Okash Khawaja writes:
> > > > Finally there is an issue w
On Fri, 15 Mar 2019 20:18:31 -0700
Greg Kroah-Hartman wrote:
> On Fri, Mar 15, 2019 at 01:01:27PM +0000, Okash Khawaja wrote:
> > Hi,
> >
> > We have made progress on the items in TODO file of speakup driver in
> > staging directory and wanted to get some clarity
Hi,
On Fri, 15 Mar 2019 18:19:39 -0700
Chris Brannon wrote:
> Okash Khawaja writes:
>
> > Finally there is an issue where text in output buffer sometimes gets
> > garbled on SMP systems, but we can continue working on it after the
> > driver is moved out of staging, i
Hi,
We have made progress on the items in TODO file of speakup driver in
staging directory and wanted to get some clarity on the remaining
items. Below is a summary of status of each item along with the quotes
from TODO file.
1. "The first issue has to do with the way speakup communicates
with
Hi,
This patch fixes endianness bug in btf_int_bits_seq_show(). Jakub
Kicinski pointed out in a separate patch review for bpftool ("bpf: btf:
add btf print functionality") that parsing of bitfield might not work
on big endian machine. Similar parsing is performed in
btf_int_bits_seq_show() and
Hi,
This patch fixes endianness bug in btf_int_bits_seq_show(). Jakub
Kicinski pointed out in a separate patch review for bpftool ("bpf: btf:
add btf print functionality") that parsing of bitfield might not work
on big endian machine. Similar parsing is performed in
btf_int_bits_seq_show() and
for the help in navigating potential pitfalls when
dealing with endianess and for the final solution.
Fixes: b00b8daec828 ("bpf: btf: Add pretty print capability for data with BTF
type info")
Signed-off-by: Okash Khawaja
---
kernel/bpf/btf.c | 32 +++---
for the help in navigating potential pitfalls when
dealing with endianess and for the final solution.
Fixes: b00b8daec828 ("bpf: btf: Add pretty print capability for data with BTF
type info")
Signed-off-by: Okash Khawaja
---
kernel/bpf/btf.c | 32 +++---
Hi,
This v3 contains incorporates feedback from v2, including a fix for big endian
when extracting bitfields. Below is a summary of all changes.
patch 1:
- use kernel integer types instead of stdint
patch 2:
- change stdint types to kernel equivalents
- remove variable ret from
Hi,
This v3 contains incorporates feedback from v2, including a fix for big endian
when extracting bitfields. Below is a summary of all changes.
patch 1:
- use kernel integer types instead of stdint
patch 2:
- change stdint types to kernel equivalents
- remove variable ret from
}
]
This patch uses json's {} and [] to imply struct/union and array. More
explicit information can be added later. For example, a command line
option can be introduced to print whether a key or value is struct
or union, name of a struct etc. This will however come at the expense
of duplicating info
mper introduced in previous patch to accomplish
the above. Indeed, btf-ful info is only displayed if btf data for the
given map is available. Otherwise existing output is displayed as-is.
Signed-off-by: Okash Khawaja
---
tools/bpf/bpftool/map.c | 207
}
]
This patch uses json's {} and [] to imply struct/union and array. More
explicit information can be added later. For example, a command line
option can be introduced to print whether a key or value is struct
or union, name of a struct etc. This will however come at the expense
of duplicating info
mper introduced in previous patch to accomplish
the above. Indeed, btf-ful info is only displayed if btf data for the
given map is available. Otherwise existing output is displayed as-is.
Signed-off-by: Okash Khawaja
---
tools/bpf/bpftool/map.c | 207
On Thu, Jun 21, 2018 at 12:22:52AM +0100, Song Liu wrote:
>
>
> > On Jun 20, 2018, at 1:30 PM, Okash Khawaja wrote:
> >
> > This patch modifies `bpftool map dump [-j|-p] id ` to json-
> > print and pretty-json-print map dump. It calls btf_dumper introduced in
&g
On Thu, Jun 21, 2018 at 12:22:52AM +0100, Song Liu wrote:
>
>
> > On Jun 20, 2018, at 1:30 PM, Okash Khawaja wrote:
> >
> > This patch modifies `bpftool map dump [-j|-p] id ` to json-
> > print and pretty-json-print map dump. It calls btf_dumper introduced in
&g
the usual
debug-less output is printed.
Signed-off-by: Okash Khawaja
Acked-by: Martin KaFai Lau
---
tools/bpf/bpftool/map.c | 94 ++--
1 file changed, 91 insertions(+), 3 deletions(-)
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
the usual
debug-less output is printed.
Signed-off-by: Okash Khawaja
Acked-by: Martin KaFai Lau
---
tools/bpf/bpftool/map.c | 94 ++--
1 file changed, 91 insertions(+), 3 deletions(-)
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
Hi,
This patch fixes kernel lockup shown by lockdep log below. Further
details are in patch header.
Samuel, please note that I removed initialisation of the static int
in_keyboard_notifier to zero as that is not required and reported as
error by checkpatch.
Thanks,
Okash
[ 1293.803242]
Hi,
This patch fixes kernel lockup shown by lockdep log below. Further
details are in patch header.
Samuel, please note that I removed initialisation of the static int
in_keyboard_notifier to zero as that is not required and reported as
error by checkpatch.
Thanks,
Okash
[ 1293.803242]
ypress inside timer context.
When not inside key press notifier callback, the behaviour will remain
the same as before this patch.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>
---
drivers/staging/spe
ypress inside timer context.
When not inside key press notifier callback, the behaviour will remain
the same as before this patch.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/main.c | 15 ---
1 file changed, 12 insertions(+), 3 del
ere stopped by speakup.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>
---
drivers/staging/speakup/spk_ttyio.c | 50
1 file changed, 50 insertions(+)
--- a/drivers/staging/spea
ere stopped by speakup.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/spk_ttyio.c | 50
1 file changed, 50 insertions(+)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -1
Testing has shown that lp* devices don't work correctly with speakup
just yet. That will require some additional work. Until then, this patch
removes code related to that.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thiba...@ens
Testing has shown that lp* devices don't work correctly with speakup
just yet. That will require some additional work. Until then, this patch
removes code related to that.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/spk_ttyio.c | 23
Testing has shown that lp* devices don't work correctly with speakup
just yet. That will require some additional work. Until then, this patch
removes code related to that.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c
Testing has shown that lp* devices don't work correctly with speakup
just yet. That will require some additional work. Until then, this patch
removes code related to that.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_ttyio.c | 23 +--
1 file changed, 1
This patch replaces call to tty_open_by_driver with a tty_kopen and
uses tty_kclose instead of tty_release_struct to close it.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c |4 ++--
1 file changed, 2 insertions(+), 2 del
This patch replaces call to tty_open_by_driver with a tty_kopen and
uses tty_kclose instead of tty_release_struct to close it.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_ttyio.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/staging/speakup
Hi,
I have updated the patches so that the exclusivity flag is in tty_port.
When closing the struct - by calling tty_release_struct - we also need
to reset the flag. One way to do that is to reset the flag inside
tty_release_struct function, regardless of whether the tty was opened
through
Hi,
I have updated the patches so that the exclusivity flag is in tty_port.
When closing the struct - by calling tty_release_struct - we also need
to reset the flag. One way to do that is to reset the flag inside
tty_release_struct function, regardless of whether the tty was opened
through
ommands like "echo foo >
/dev/ttyS0". They all correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/tty/tty_io.c | 100 ---
incl
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 del
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 deletions(-)
--- a/drivers/tty/tty_io.c
+++ b
ommands like "echo foo >
/dev/ttyS0". They all correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c | 100 ---
include/linux/tty.h | 21
On Tue, Jul 18, 2017 at 03:26:37PM +0300, Dan Carpenter wrote:
> > + if (tty) {
> > + /* drop kref from tty_driver_lookup_tty() */
> > + tty_kref_put(tty);
> > + tty = ERR_PTR(-EBUSY);
> > + } else { /* tty_init_dev returns tty with the
On Tue, Jul 18, 2017 at 03:26:37PM +0300, Dan Carpenter wrote:
> > + if (tty) {
> > + /* drop kref from tty_driver_lookup_tty() */
> > + tty_kref_put(tty);
> > + tty = ERR_PTR(-EBUSY);
> > + } else { /* tty_init_dev returns tty with the
On Mon, Jul 17, 2017 at 11:04:38PM +0100, Alan Cox wrote:
>
> > Sure. I can fix the tty->count mismatch based on Alan's suggestion. However
> > I don't understand why the exclusivity flag should belong to tty_port and
> > not tty_struct. It will be good to know why.
>
> We are trying to move
On Mon, Jul 17, 2017 at 11:04:38PM +0100, Alan Cox wrote:
>
> > Sure. I can fix the tty->count mismatch based on Alan's suggestion. However
> > I don't understand why the exclusivity flag should belong to tty_port and
> > not tty_struct. It will be good to know why.
>
> We are trying to move
This patch replaces call to tty_open_by_driver with a tty_kopen.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/s
This patch replaces call to tty_open_by_driver with a tty_kopen.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_ttyio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -158,7 +158,7
correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/tty/tty_io.c | 66 +++
include/linux/tty.h |4 +++
2 files changed, 65 inserti
correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c | 66 +++
include/linux/tty.h |4 +++
2 files changed, 65 insertions(+), 5 deletions(-)
--- a
Hi,
I have reworked the previous patch set. These are the changes:
1. Patch 1 fixes tty->count mismatch reported by check_tty_count when a
tty is kopened.
2. Patch 1 incorporates patch 4 in the previous patch set - it returns
-ENODEV when tty is not configured.
Thanks,
Okash
Hi,
I have reworked the previous patch set. These are the changes:
1. Patch 1 fixes tty->count mismatch reported by check_tty_count when a
tty is kopened.
2. Patch 1 incorporates patch 4 in the previous patch set - it returns
-ENODEV when tty is not configured.
Thanks,
Okash
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 del
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 deletions(-)
--- a/drivers/tty/tty_io.c
+++ b
> On 17 Jul 2017, at 13:31, Greg Kroah-Hartman <gre...@linuxfoundation.org>
> wrote:
>
>> On Thu, Jul 13, 2017 at 12:29:54PM +0100, Okash Khawaja wrote:
>>> On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote:
>>>
>>>> When openin
> On 17 Jul 2017, at 13:31, Greg Kroah-Hartman
> wrote:
>
>> On Thu, Jul 13, 2017 at 12:29:54PM +0100, Okash Khawaja wrote:
>>> On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote:
>>>
>>>> When opening from kernel, we don't use file po
-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/main.c |2 ++
drivers/staging/speakup/spk_ttyio.c |8 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2315,6 +
-by: Okash Khawaja
---
drivers/staging/speakup/main.c |2 ++
drivers/staging/speakup/spk_ttyio.c |8 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2315,6 +2315,7 @@ static void __exit
Hi,
These patches make sure that N_SPEAKUP is correctly unregistered when all
speakup related modules are unloaded, making sure the refcount correctly
represents the number of users.
Patch 1: simply adds functions to register and unregister ldisc, without
changing existing behaviour
This patch adds the above two functions and makes them available to
main.c where they will be called during init and exit functions of
main speakup module. Following patch will make use of them.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/spk_
Hi,
These patches make sure that N_SPEAKUP is correctly unregistered when all
speakup related modules are unloaded, making sure the refcount correctly
represents the number of users.
Patch 1: simply adds functions to register and unregister ldisc, without
changing existing behaviour
This patch adds the above two functions and makes them available to
main.c where they will be called during init and exit functions of
main speakup module. Following patch will make use of them.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_priv.h |2 ++
drivers/staging
Hi,
Let's deal with the ldisc refcount problem separately. Purpose of this
patch is to close tty safely, so I have removed the call to unregister
the ldisc. I will follow this up with a separate patch which addresses
the ldisc issue.
Thanks,
Okash
tty_ldisc_release, so speakup doesn't need to call it.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@
Hi,
Let's deal with the ldisc refcount problem separately. Purpose of this
patch is to close tty safely, so I have removed the call to unregister
the ldisc. I will follow this up with a separate patch which addresses
the ldisc issue.
Thanks,
Okash
tty_ldisc_release, so speakup doesn't need to call it.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_ttyio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -300,7 +300,7 @@ void
On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote:
>
> > When opening from kernel, we don't use file pointer. The count mismatch
> > is between tty->count and #fd's. So opening from kernel leads to #fd's
> > being less than tty->count. I thought this difference is relevant to
> >
On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote:
>
> > When opening from kernel, we don't use file pointer. The count mismatch
> > is between tty->count and #fd's. So opening from kernel leads to #fd's
> > being less than tty->count. I thought this difference is relevant to
> >
On Wed, Jul 12, 2017 at 07:25:22PM +0100, Alan Cox wrote:
> > spk_ttyio_initialise_ldisc is called separately for each module (e.g.
> > speakup_apollo, speakup_ltlk etc) when it is loaded. spk_ttyio_release
> > is also called separately for each module when it is unloaded. The ldisc
> > stays
On Wed, Jul 12, 2017 at 07:25:22PM +0100, Alan Cox wrote:
> > spk_ttyio_initialise_ldisc is called separately for each module (e.g.
> > speakup_apollo, speakup_ltlk etc) when it is loaded. spk_ttyio_release
> > is also called separately for each module when it is unloaded. The ldisc
> > stays
Hi,
On Mon, Jul 10, 2017 at 12:55:44PM +0100, Alan Cox wrote:
> On Fri, 7 Jul 2017 20:13:01 +0100
> Okash Khawaja <okash.khaw...@gmail.com> wrote:
>
> > Speakup opens tty using tty_open_by_driver. When closing, it calls
> > tty_ldisc_release but doesn't clos
Hi,
On Mon, Jul 10, 2017 at 12:55:44PM +0100, Alan Cox wrote:
> On Fri, 7 Jul 2017 20:13:01 +0100
> Okash Khawaja wrote:
>
> > Speakup opens tty using tty_open_by_driver. When closing, it calls
> > tty_ldisc_release but doesn't close and remove the tty itself. As a
> &
On Mon, Jul 10, 2017 at 01:33:07PM +0100, Okash Khawaja wrote:
> > If the tty counts are being misreported then it would be better to fix
> > the code to actually manage the counts properly. The core tty code is
> > telling you that the tty is not in a valid state. While thi
On Mon, Jul 10, 2017 at 01:33:07PM +0100, Okash Khawaja wrote:
> > If the tty counts are being misreported then it would be better to fix
> > the code to actually manage the counts properly. The core tty code is
> > telling you that the tty is not in a valid state. While thi
On Mon, Jul 10, 2017 at 06:21:37PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 10, 2017 at 11:31 AM, Okash Khawaja <okash.khaw...@gmail.com>
> wrote:
> > On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> >> On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawa
On Mon, Jul 10, 2017 at 06:21:37PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 10, 2017 at 11:31 AM, Okash Khawaja
> wrote:
> > On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> >> On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawaja
> >> wrote:
On Mon, Jul 10, 2017 at 12:52:33PM +0100, Alan Cox wrote:
> On Sun, 09 Jul 2017 12:41:53 +0100
> Okash Khawaja <okash.khaw...@gmail.com> wrote:
>
> > On Sat, Jul 08, 2017 at 10:38:03AM +0200, Greg Kroah-Hartman wrote:
> > > Overall, the idea looks sane to me.
On Mon, Jul 10, 2017 at 12:52:33PM +0100, Alan Cox wrote:
> On Sun, 09 Jul 2017 12:41:53 +0100
> Okash Khawaja wrote:
>
> > On Sat, Jul 08, 2017 at 10:38:03AM +0200, Greg Kroah-Hartman wrote:
> > > Overall, the idea looks sane to me. Keeping userspace from opening a
&
On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawaja <okash.khaw...@gmail.com> wrote:
>
> > +struct tty_struct *tty_kopen(dev_t device)
> > +{
> > + struct tty_struct *tty;
> > +
On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawaja wrote:
>
> > +struct tty_struct *tty_kopen(dev_t device)
> > +{
> > + struct tty_struct *tty;
> > + struct tty_driver *driver = NU
Hi,
On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> Above
> 1. take mutex
> 2. take reference
>
> Here:
> 1. give mutex back
> 2. give reference back
>
> I think we usually see symmetrical calls, i.e.
>
> 1. give reference back
> 2. give mutex back
>
> So, what did I
Hi,
On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> Above
> 1. take mutex
> 2. take reference
>
> Here:
> 1. give mutex back
> 2. give reference back
>
> I think we usually see symmetrical calls, i.e.
>
> 1. give reference back
> 2. give mutex back
>
> So, what did I
When TTY is not built, tty_kopen should return an error. This way
calling code remains consistent, regardless of whether tty is built or
not. This patch returns -ENODEV when there is no tty.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
include/linux/tty.h |2 +-
1 file c
When TTY is not built, tty_kopen should return an error. This way
calling code remains consistent, regardless of whether tty is built or
not. This patch returns -ENODEV when there is no tty.
Signed-off-by: Okash Khawaja
---
include/linux/tty.h |2 +-
1 file changed, 1 insertion(+), 1
On Sun, Jul 09, 2017 at 01:50:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote:
> > This patch replaces call to tty_open_by_driver with a tty_kopen.
> >
> > Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
On Sun, Jul 09, 2017 at 01:50:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote:
> > This patch replaces call to tty_open_by_driver with a tty_kopen.
> >
> > Signed-off-by: Okash Khawaja
> >
> > ---
> &g
I have
tested this with minicom, picocom and commands like "echo foo >
/dev/ttyS0". They all correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja <okash.khaw...@gmail.com>
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 del
I have
tested this with minicom, picocom and commands like "echo foo >
/dev/ttyS0". They all correctly report "Device or resource busy" when
the tty is already kernel opened.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c | 54 +
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 deletions(-)
--- a/drivers/tty/tty_io.c
+++ b
1 - 100 of 328 matches
Mail list logo