Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 11, 2018, at 6:44 PM, NeilBrown <ne...@suse.com> wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: >> >> Certain things that sound useless (like the debug subsystem in Lustre) >> is very useful when you have a 10k nodes in a cluster and need to sel

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 11, 2018, at 6:44 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: >> >> Certain things that sound useless (like the debug subsystem in Lustre) >> is very useful when you have a 10k nodes in a cluster and need to selectively >&g

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 11, 2018, at 6:50 PM, NeilBrown wrote: > > Maybe - as you suggest in another email - it is due to some > client/server incompatibility. I guess it is unavoidable with an fs > like lustre to have incompatible protocol changes. Is there any > mechanism for detecting the

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 11, 2018, at 6:50 PM, NeilBrown wrote: > > Maybe - as you suggest in another email - it is due to some > client/server incompatibility. I guess it is unavoidable with an fs > like lustre to have incompatible protocol changes. Is there any > mechanism for detecting the version of

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 8, 2018, at 10:10 PM, NeilBrown <ne...@suse.com> wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown <ne...@suse.com> wrote: >>> >>> On Tue, Aug 16 2016, James Simmons wrote: >>

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: >>> >>> On Tue, Aug 16 2016, James Simmons wrote: >> >> my that’s an old patch >> >>

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > > On Tue, Aug 16 2016, James Simmons wrote: my that’s an old patch > >> >> +static inline bool >> +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md >> *lsm2) >> +{ >> +int idx; >> + >> +if

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > > On Tue, Aug 16 2016, James Simmons wrote: my that’s an old patch > >> >> +static inline bool >> +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md >> *lsm2) >> +{ >> +int idx; >> + >> +if (lsm1->lsm_md_magic !=

Re: [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias.

On Jul 19, 2017, at 12:33 AM, NeilBrown wrote: > On Tue, Jul 18 2017, Oleg Drokin wrote: > >> Unfortunately this patch causes insta-crash on first stat call after mount. >> Sorry, I cannot dig into this deeper right this moment, but I will a bit >> later. > >

Re: [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias.

On Jul 19, 2017, at 12:33 AM, NeilBrown wrote: > On Tue, Jul 18 2017, Oleg Drokin wrote: > >> Unfortunately this patch causes insta-crash on first stat call after mount. >> Sorry, I cannot dig into this deeper right this moment, but I will a bit >> later. > >

Re: [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias.

Unfortunately this patch causes insta-crash on first stat call after mount. Sorry, I cannot dig into this deeper right this moment, but I will a bit later. I am adding Al that we discussed this code at some length and he found no problems here, so I am a bit surprised by your findings. Also the

Re: [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias.

Unfortunately this patch causes insta-crash on first stat call after mount. Sorry, I cannot dig into this deeper right this moment, but I will a bit later. I am adding Al that we discussed this code at some length and he found no problems here, so I am a bit surprised by your findings. Also the

Re: [PATCH][V2] staging: lustre: fix spelling mistake, "grranted" -> "granted"

On Jul 14, 2017, at 5:33 PM, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in CERROR error message. Also > clean up the grammar. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revi

Re: [PATCH][V2] staging: lustre: fix spelling mistake, "grranted" -> "granted"

On Jul 14, 2017, at 5:33 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in CERROR error message. Also > clean up the grammar. > > Signed-off-by: Colin Ian King Reviewed-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/ptlrpc/

Re: [PATCH] staging: lustre: fix spelling mistake, "grranted" -> "granted"

On Jul 14, 2017, at 9:26 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in CERROR error message > > Signed-off-by: Colin Ian King > --- > drivers/staging/lustre/lustre/ptlrpc/import.c | 2 +- > 1 file

Re: [PATCH] staging: lustre: fix spelling mistake, "grranted" -> "granted"

On Jul 14, 2017, at 9:26 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in CERROR error message > > Signed-off-by: Colin Ian King > --- > drivers/staging/lustre/lustre/ptlrpc/import.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] stating: lustre: fix sparse error: incompatible types in comparison expression

f(struct list_head))) > return -EFAULT; > > - if (tmp.next == head_up) > - return 0; > - > next = tmp.next; So the assignment is fine, but comparison is not? Strange. I guess this is fine by me if that makes the warning go away. Acke

Re: [PATCH] stating: lustre: fix sparse error: incompatible types in comparison expression

eturn -EFAULT; > > - if (tmp.next == head_up) > - return 0; > - > next = tmp.next; So the assignment is fine, but comparison is not? Strange. I guess this is fine by me if that makes the warning go away. Acked-by: Oleg Drokin

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_exit

Hello! On May 31, 2017, at 4:00 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_exit (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix it,

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_exit

Hello! On May 31, 2017, at 4:00 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_exit (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix it,

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_deschedule

Hello! On May 31, 2017, at 3:57 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_deschedule (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_deschedule

Hello! On May 31, 2017, at 3:57 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_deschedule (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix

Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct >> lov_user_md pointer from user- or kernel-space. This changes the >> behav

Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct >> lov_user_md pointer from user- or kernel-space. This changes the >> behav

[PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

https://jira.hpdd.intel.com/browse/LU-3221 Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Li Wei <wei.g...@intel.com> Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/lov/lov_pack.c | 9 - 1 file changed, 9 deletions(

[PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

/browse/LU-3221 Reviewed-by: Andreas Dilger Reviewed-by: Li Wei Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pack.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c index

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 19, 2017, at 12:41 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 19, 2017, at 12:41 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: >> >> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: >> >>> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: &

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: >> >> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: >> >>> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: &

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

[PATCH/RFC] staging/lustre: Rework class_process_proc_param

Ever since sysfs migration, class_process_proc_param stopped working correctly as all the useful params were no longer present as lvars. Replace all the nasty fake proc writes with hopefully less nasty kobject attribute search and then update the attributes as needed. Signed-off-by: Oleg Drokin

[PATCH/RFC] staging/lustre: Rework class_process_proc_param

Ever since sysfs migration, class_process_proc_param stopped working correctly as all the useful params were no longer present as lvars. Replace all the nasty fake proc writes with hopefully less nasty kobject attribute search and then update the attributes as needed. Signed-off-by: Oleg Drokin

Re: [PATCH 5/5] staging/lustre: Use generic range rwlock

On Mar 7, 2017, at 12:03 AM, Davidlohr Bueso wrote: > This replaces the in-house version, which is also derived > from Jan's interval tree implementation. > > Cc: oleg.dro...@intel.com > Cc: andreas.dil...@intel.com > Cc: jsimm...@infradead.org > Cc: lustre-de...@lists.lustre.org > >

Re: [PATCH 5/5] staging/lustre: Use generic range rwlock

On Mar 7, 2017, at 12:03 AM, Davidlohr Bueso wrote: > This replaces the in-house version, which is also derived > from Jan's interval tree implementation. > > Cc: oleg.dro...@intel.com > Cc: andreas.dil...@intel.com > Cc: jsimm...@infradead.org > Cc: lustre-de...@lists.lustre.org > >

Re: [lustre-devel] [PATCH] staging: lustre: fix sparse warning about different address spaces

On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote: > fixed the following sparse warning by adding proper cast: > drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: > incorrect type in argument 2 (different address spaces) >

Re: [lustre-devel] [PATCH] staging: lustre: fix sparse warning about different address spaces

On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote: > fixed the following sparse warning by adding proper cast: > drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: > incorrect type in argument 2 (different address spaces) >

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

reas.dil...@intel.com> >> Reviewed-by: wangdi <di.w...@intel.com> >> Reviewed-by: Mike Pershin <mike.pers...@intel.com> >> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> >> Signed-off-by: James Simmons <jsimm...@infradead.org> >> --- >> d

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

reas.dil...@intel.com> >> Reviewed-by: wangdi <di.w...@intel.com> >> Reviewed-by: Mike Pershin <mike.pers...@intel.com> >> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> >> Signed-off-by: James Simmons <jsimm...@infradead.org> >> --- >> d

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

gt; time. >> >> Signed-off-by: Alex Zhuravlev >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838 >> Reviewed-on: https://review.whamcloud.com/18028 >> Reviewed-by: Andreas Dilger >> Reviewed-by: wangdi >> Reviewed-by: Mike Pershin >> Review

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

gt; time. >> >> Signed-off-by: Alex Zhuravlev >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838 >> Reviewed-on: https://review.whamcloud.com/18028 >> Reviewed-by: Andreas Dilger >> Reviewed-by: wangdi >> Reviewed-by: Mike Pershin >> Review

Re: [PATCH v2] Style fixes

On Jan 13, 2017, at 3:48 PM, Guillermo O. Freschi wrote: > Missing braces on `if` statement. > > Signed-off-by: Guillermo O. Freschi <ked...@gmail.com> > > Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com&g

Re: [PATCH v2] Style fixes

On Jan 13, 2017, at 3:48 PM, Guillermo O. Freschi wrote: > Missing braces on `if` statement. > > Signed-off-by: Guillermo O. Freschi > > Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 9 + > 1 fi

Re: [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state()

On Jan 1, 2017, at 11:38 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 16:26:36 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue

Re: [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state()

On Jan 1, 2017, at 11:38 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 16:26:36 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue was detected by using the

Re: [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state()

On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 15:40:29 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue

Re: [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state()

On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 15:40:29 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue was detected by using the

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote: > It used to be that great swathes of Lustre were used in both user space > and kernel space. We had huge unused modules in the kernel that were > only used for user space. Huh? There was nothing of the sort. There were huge parts of code that

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote: > It used to be that great swathes of Lustre were used in both user space > and kernel space. We had huge unused modules in the kernel that were > only used for user space. Huh? There was nothing of the sort. There were huge parts of code that

Re: [PATCH 0/8] Sparse warning fixes in Lustre.

On Dec 7, 2016, at 6:46 PM, Al Viro wrote: > On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: >> This set of fixes aims at sparse warnings. > > Speaking of the stuff sparse catches there: class_process_proc_param(). > I've tried to describe what I think

Re: [PATCH 0/8] Sparse warning fixes in Lustre.

On Dec 7, 2016, at 6:46 PM, Al Viro wrote: > On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: >> This set of fixes aims at sparse warnings. > > Speaking of the stuff sparse catches there: class_process_proc_param(). > I've tried to describe what I think

[PATCH 3/8] staging/lustre/llite: mark ll_io_init() static

It's not used anywhere out of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/s

[PATCH 3/8] staging/lustre/llite: mark ll_io_init() static

It's not used anywhere out of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c

[PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static

It's not used anywhere outside of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/d

[PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs

Fixes: c948390f10ccc "fix inconsistencies of root squash feature" Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 27 +-- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/staging/lustre/lustre/

[PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

As per interval_search() prototype, the callback should return enum, not int. This fixes correspondign sparse warning. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static

It's not used anywhere outside of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov

[PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs

ncies of root squash feature" Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 27 +-- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lu

[PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

As per interval_search() prototype, the callback should return enum, not int. This fixes correspondign sparse warning. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

This avoids frowned upon extern in the C file, and also shuts down a sparse warning of drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches' was not declared. Should it be static? Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lust

[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

This avoids frowned upon extern in the C file, and also shuts down a sparse warning of drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches' was not declared. Should it be static? Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_internal.h | 2

[PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration

Move it to obd.h, so that it's included from both the users and the actual definition, making sure they never get out of sync. This also silences a sparse warning. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/include/obd.h| 3 +++ drivers/s

[PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default

Make the declaration in a header, not as an extern in a C file, that is frowned upon. This also makes sparse a little bit more happy. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/include/lu_object.h | 3 +++ drivers/staging/lustre/lustre/ob

[PATCH 0/8] Sparse warning fixes in Lustre.

This set of fixes aims at sparse warnings. Most of the patches are just moving declarations around to deal with the warning: symbol 'xxx' was not declared. Should it be static? kind of messages. Also a screwup with root_squash sysfs control is fixed. Oleg Drokin (8): staging/lustre/llite: move

[PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header

This avoids having an extern definition in a C file which is bad, and also silences sparse complaint as well. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3

[PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration

Move it to obd.h, so that it's included from both the users and the actual definition, making sure they never get out of sync. This also silences a sparse warning. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h| 3 +++ drivers/staging/lustre/lustre/llite

[PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default

Make the declaration in a header, not as an extern in a C file, that is frowned upon. This also makes sparse a little bit more happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lu_object.h | 3 +++ drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 +-- 2 files

[PATCH 0/8] Sparse warning fixes in Lustre.

This set of fixes aims at sparse warnings. Most of the patches are just moving declarations around to deal with the warning: symbol 'xxx' was not declared. Should it be static? kind of messages. Also a screwup with root_squash sysfs control is fixed. Oleg Drokin (8): staging/lustre/llite: move

[PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header

This avoids having an extern definition in a C file which is bad, and also silences sparse complaint as well. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3 +++ 2 files changed, 3

Re: [lustre-devel] [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 3:37 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote: >> >> On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: >> >>> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: >>>>

Re: [lustre-devel] [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 3:37 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote: >> >> On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: >> >>> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: >>>>

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote: > Hi all, > > I am looking at the drivers/staging/lustre/lustre/llite/dir.c: > > 1469 /* Call mdc_iocontrol */ > 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), > , > 1471

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote: > Hi all, > > I am looking at the drivers/staging/lustre/lustre/llite/dir.c: > > 1469 /* Call mdc_iocontrol */ > 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), > , > 1471

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:33 AM, Dan Carpenter wrote: > Lustre is kind of a mess with regards to keeping user and kernel > pointers separate. It's not going to be easy to fix. Actually I believe I made significant inroads in properly cleaning (almost?) everything in this area about a year ago (to

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:33 AM, Dan Carpenter wrote: > Lustre is kind of a mess with regards to keeping user and kernel > pointers separate. It's not going to be easy to fix. Actually I believe I made significant inroads in properly cleaning (almost?) everything in this area about a year ago (to

Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: > On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: >> I have been having a lot of unexplainable crashes in osc_lru_shrink >> lately that I could not see a good explanation for and then I found >> this

Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: > On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: >> I have been having a lot of unexplainable crashes in osc_lru_shrink >> lately that I could not see a good explanation for and then I found >> this

[PATCH] staging/lustre/lnetselftest: Fix potential integer overflow

is not present. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lnet/selftest/conctl.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging

[PATCH] staging/lustre/lnetselftest: Fix potential integer overflow

is not present. Reported-by: Dan Carpenter Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/selftest/conctl.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c index 02847bf..9438302 100644

[PATCH 5/5] staging/lustre/o2iblnd: Fix misspelled attemps->attempts

Highlighted by checkpatch: WARNING: 'attemps' may be misspelled - perhaps 'attempts'? #20278: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3272: + * reconnection attemps. Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2ibln

[PATCH 3/5] staging/lustre: Convert all bare unsigned to unsigned int

Highlighted by relatively new checkpatch test, warnings like: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 6 +- .../staging/lustre/lustre/include/lprocfs_status.

[PATCH 5/5] staging/lustre/o2iblnd: Fix misspelled attemps->attempts

Highlighted by checkpatch: WARNING: 'attemps' may be misspelled - perhaps 'attempts'? #20278: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3272: + * reconnection attemps. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed

[PATCH 3/5] staging/lustre: Convert all bare unsigned to unsigned int

Highlighted by relatively new checkpatch test, warnings like: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 6 +- .../staging/lustre/lustre/include/lprocfs_status.h | 3 +- drivers/staging/lustre

[PATCH 2/5] staging/lustre/socklnd: Fix whitespace problem

checkpatch highlighted there are 8 spaces that could be converted to a tab: ERROR: code indent should use tabs where possible +^I^I^I^I^I */$ Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +- 1 file changed, 1 ins

[PATCH 0/5] Lustre style fixes

These patches fix some more of the low hanging fruits in the style problems highlighted by checkpatch. Now only false positive ERRORs are left. This also converts all bare unsigneds into unsigned ints and a couple of spelling fixes. Please consider. Oleg Drokin (5): staging/lustre/o2iblnd: Add

[PATCH 4/5] staging/lustre/o2iblnd: Fix misspelling intialized->intialized

Highlighted by checkpatch: + if (!ps->ps_net) /* intialized? */ Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnd

[PATCH 2/5] staging/lustre/socklnd: Fix whitespace problem

checkpatch highlighted there are 8 spaces that could be converted to a tab: ERROR: code indent should use tabs where possible +^I^I^I^I^I */$ Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/5] Lustre style fixes

These patches fix some more of the low hanging fruits in the style problems highlighted by checkpatch. Now only false positive ERRORs are left. This also converts all bare unsigneds into unsigned ints and a couple of spelling fixes. Please consider. Oleg Drokin (5): staging/lustre/o2iblnd: Add

[PATCH 4/5] staging/lustre/o2iblnd: Fix misspelling intialized->intialized

Highlighted by checkpatch: + if (!ps->ps_net) /* intialized? */ Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/stag

[PATCH 1/5] staging/lustre/o2iblnd: Add missing space

checkpatch highlighted missing space before assignment for lock variable. + spinlock_t *lock= _data.kib_connd_lock; Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/5] staging/lustre/o2iblnd: Add missing space

checkpatch highlighted missing space before assignment for lock variable. + spinlock_t *lock= _data.kib_connd_lock; Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

aging: lustre: osc: Use list_for_each_entry_safe") CC: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Signed-off-by: Oleg Drokin <gr...@linuxhacker.ru> --- I also do not see this patch in any of the mailing lists I am subscribed to. I wonder if there's a way to subscribe to those

[PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

aging: lustre: osc: Use list_for_each_entry_safe") CC: Bhaktipriya Shridhar Signed-off-by: Oleg Drokin --- I also do not see this patch in any of the mailing lists I am subscribed to. I wonder if there's a way to subscribe to those Greg's "This is a note to let you know that I've just

Re: [PATCH 04/22] staging: lustre: osc: handle osc eviction correctly

On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote: >> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env, >> struct cl_io *io, >> /* page is top page. */ >> info->oti_next_index = osc_index(ops) + 1; >>

Re: [PATCH 04/22] staging: lustre: osc: handle osc eviction correctly

On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote: >> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env, >> struct cl_io *io, >> /* page is top page. */ >> info->oti_next_index = osc_index(ops) + 1; >>

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 2, 2016, at 12:33 PM, Quentin Lambert wrote: > lnet_ipif_enumerate was assigning a pointer from kernel space to user > space. This patch uses copy_to_user to properly do that assignment. I guess it's a false positive? While lnet_sock_ioctl()->kernel_sock_unlocked_ioctl() does call into

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 2, 2016, at 12:33 PM, Quentin Lambert wrote: > lnet_ipif_enumerate was assigning a pointer from kernel space to user > space. This patch uses copy_to_user to properly do that assignment. I guess it's a false positive? While lnet_sock_ioctl()->kernel_sock_unlocked_ioctl() does call into

Re: [PATCH] staging: lustre: Fix function declaration/definition mismatch

t; redeclared with different type... > lprocfs_status.c:1632:5: error: symbol 'lprocfs_wr_nosquash_nids' > redeclared with different type... > > Signed-off-by: Sandeep Jain <sandeepjain.li...@gmail.com> Acked-by: Oleg Drokin <oleg.dro...@intel.com> > --- > drivers/staging/lust

Re: [PATCH] staging: lustre: Fix function declaration/definition mismatch

clared with different type... > > Signed-off-by: Sandeep Jain Acked-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/lprocfs_s

  1   2   3   4   5   6   7   8   9   10   >