Re: [PATCH 1/1] ARM: imx: build suspend-imx6.S with arm instruction set

2021-01-11 Thread Oleksandr Suvorov
sumes unconditionally in ARM instruction mode > and then chokes on the presented Thumb-2 code it should execute. > > Fix this by using the arm instruction set for all code in > suspend-imx6.S. > > Signed-off-by: Max Krummenacher Acked-by: Oleksandr Suvorov > > --- > > a

[PATCH v2] mfd: stmpe: Support disabling sub-functions

2020-12-26 Thread Oleksandr Suvorov
Add support of sub-functions disabling. It allows one to define an stmpe sub-function device in devicetree, but keep it disabled. Signed-off-by: Oleksandr Suvorov --- Changes in v2: Use for_each_available_child_of_node() instead of checking of_device_is_available() for each node. Thanks

[PATCH] mfd: stmpe: Support disabling sub-functions

2020-12-26 Thread Oleksandr Suvorov
Add support of sub-functions disabling. It allows one to define an stmpe sub-function device in devicetree, but keep it disabled. Signed-off-by: Oleksandr Suvorov --- drivers/mfd/stmpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c index

Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability

2020-07-10 Thread Oleksandr Suvorov
On Fri, Jul 10, 2020 at 4:26 PM Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > drivers/usb/chipidea/core.c usb dual-role host/device switching is > working. So make use of it. > > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov

Re: [PATCH 2/3] ARM: dts: colibri-imx6: add usb dual-role switch capability

2020-07-10 Thread Oleksandr Suvorov
On Fri, Jul 10, 2020 at 4:26 PM Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > drivers/usb/chipidea/core.c usb dual-role host/device switching is > working. So make use of it. > > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov &

Re: [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan

2020-07-10 Thread Oleksandr Suvorov
On Fri, Jul 10, 2020 at 4:25 PM Philippe Schenker wrote: > > This is not necessary without a pinctrl-0 statement. Remove this > orphan. > > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > --- > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 1 - >

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-18 Thread Oleksandr Suvorov
On Thu, 2019-10-17 at 17:39 +0100, Mark Brown wrote: > > All versions of driver sgtl5000 (since creating in 2011) has a bug in > > sgtl5000_probe(): > > ... > >snd_soc_write(codec, SGTL5000_CHIP_ANA_CTRL, > >SGTL5000_HP_ZCD_EN | > >

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Oleksandr Suvorov
On Thu, 2019-10-17 at 12:11 +0100, Mark Brown wrote: > On Thu, Oct 17, 2019 at 09:49:27AM +0000, Oleksandr Suvorov wrote: > > > Mark, obviously this is not a NEW feature. This patch adds LOST > > standard control. > > It's a new feature for this CODEC to have control

Re: Fw: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Oleksandr Suvorov
t;>> On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > >>>>> From: Oleksandr Suvorov > >> > >>>>> commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > >> > >>>>> This control mute/unmute the ADC inp

[PATCH 0/1] [for 4.14] VAG power control improvement for sgtl5000 codec

2019-10-09 Thread Oleksandr Suvorov
This backport is for 4.14-stable. Oleksandr Suvorov (1): ASoC: sgtl5000: Improve VAG power and mute control sound/soc/codecs/sgtl5000.c | 234 +++- 1 file changed, 203 insertions(+), 31 deletions(-) -- 2.20.1

[PATCH 1/1] ASoC: sgtl5000: Improve VAG power and mute control

2019-10-09 Thread Oleksandr Suvorov
escale SGTL5000 codec support") Signed-off-by: Oleksandr Suvorov [Backport: Replace snd_soc_component_read32() with snd_soc_component_read()] Reviewed-by: Marcel Ziswiler Reviewed-by: Fabio Estevam Reviewed-by: Cezary Rojewski Link: https://lore.kernel.org/r/20190719100524.23300-3-oleksandr

[PATCH 1/1] ASoC: sgtl5000: Improve VAG power and mute control

2019-10-09 Thread Oleksandr Suvorov
escale SGTL5000 codec support") Signed-off-by: Oleksandr Suvorov [Backport: Replace snd_soc_component_read32() with snd_soc_component_read()] Reviewed-by: Marcel Ziswiler Reviewed-by: Fabio Estevam Reviewed-by: Cezary Rojewski Link: https://lore.kernel.org/r/20190719100524.23300-3-oleksandr

[PATCH 0/1] [for 4.4/4.9] VAG power control improvement for sgtl5000 codec

2019-10-09 Thread Oleksandr Suvorov
This is a backport to stable kernel versions 4.4 and 4.9. Oleksandr Suvorov (1): ASoC: sgtl5000: Improve VAG power and mute control sound/soc/codecs/sgtl5000.c | 234 +++- 1 file changed, 203 insertions(+), 31 deletions(-) -- 2.20.1

[PATCH v2 1/2] power: reset: gpio-poweroff: add force mode

2019-09-30 Thread Oleksandr Suvorov
Property "force-mode" tells the driver to replace previously initialized power-off kernel hook and allows gpio-poweroff to probe and operate successfully in any case. Signed-off-by: Oleksandr Suvorov --- Changes in v2: Call next pm_power_off handler if the current one fails to power

[PATCH v2 2/2] dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property

2019-09-30 Thread Oleksandr Suvorov
Add 'force-mode' property to allow the driver to load even if someone has registered the pm_power_off hook earlier. Signed-off-by: Oleksandr Suvorov --- Changes in v2: None .../devicetree/bindings/power/reset/gpio-poweroff.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 0/2] 'force-mode' for gpio-poweroff driver

2019-09-30 Thread Oleksandr Suvorov
to power system off. Oleksandr Suvorov (2): power: reset: gpio-poweroff: add force mode dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property .../bindings/power/reset/gpio-poweroff.txt| 3 ++ drivers/power/reset/gpio-poweroff.c | 34 +++ 2 files changed

Re: [PATCH 0/2] This patch introduces a feature to force gpio-poweroff module

2019-09-30 Thread Oleksandr Suvorov
Hi Andrew, On Mon, Sep 30, 2019 at 3:16 PM Andrew Lunn wrote: > > On Mon, Sep 30, 2019 at 10:35:36AM +, Oleksandr Suvorov wrote: > > to register its own pm_power_off handler even if someone has registered > > this handler earlier. > > Useful to change a way to power

[PATCH 2/2] dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property

2019-09-30 Thread Oleksandr Suvorov
Add 'force-mode' property to allow the driver to load even if someone has registered the pm_power_off hook earlier. Signed-off-by: Oleksandr Suvorov --- .../devicetree/bindings/power/reset/gpio-poweroff.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

[PATCH 1/2] power: reset: gpio-poweroff: add force mode

2019-09-30 Thread Oleksandr Suvorov
Property "force-mode" tells the driver to replace previously initialized power-off kernel hook and allows gpio-poweroff to probe and operate successfully in any case. Signed-off-by: Oleksandr Suvorov --- drivers/power/reset/gpio-poweroff.c | 27 +-- 1 file c

[PATCH 0/2] This patch introduces a feature to force gpio-poweroff module

2019-09-30 Thread Oleksandr Suvorov
to register its own pm_power_off handler even if someone has registered this handler earlier. Useful to change a way to power off the system using DT files. Oleksandr Suvorov (2): power: reset: gpio-poweroff: add force mode dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property

Re: [PATCH v1] arm64: dts: freescale: add initial support for colibri imx8x

2019-09-19 Thread Oleksandr Suvorov
luation Board supports almost all of them). > > So far there is no display or USB functionality supported at all but > basic console UART, eMMC and Ethernet functionality work fine. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > > arch/arm64/boot/dts/f

Re: [PATCH v4 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec

2019-08-16 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:22 PM Philippe Schenker wrote: > > Do not change the clock as the power for this phy is switched > with that clock. > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > > Changes in

Re: [PATCH v4 02/21] ARM: dts: imx7-colibri: disable HS400

2019-08-15 Thread Oleksandr Suvorov
status REF not lock! > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx7-colibri.dtsi | 1 + > 1 file changed, 1 ins

Re: [PATCH v4 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri

2019-08-15 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker wrote: > > This adds the possibility to wake the module with an external signal > as defined in the Colibri standard > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > &g

Re: [PATCH v4 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards

2019-08-15 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker wrote: > > This commit adds the touchscreens from Toradex so one can enable it. > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: &g

Re: [PATCH v4 19/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board

2019-08-15 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker wrote: > > This adds the common touchscreen that is used with Toradex's > Eval Boards. > > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: None > Changes in v3: Non

Re: [PATCH v4 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board

2019-08-15 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker wrote: > > This patch adds some missing pinmuxing that is in the colibri > standard to the dts. > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > >

Re: [PATCH v4 08/21] ARM: dts: imx7-colibri: Add touch controllers

2019-08-15 Thread Oleksandr Suvorov
On Mon, Aug 12, 2019 at 5:23 PM Philippe Schenker wrote: > > Add touch controller that is connected over an I2C bus. > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: > - Add Marcel Zi

Re: [PATCH v4 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off

2019-08-15 Thread Oleksandr Suvorov
> module for TAMPER7 and TAMPER9 SoC pin and switches on a pull down > instead of a pullup for the USBC_DET module pin (TAMPER2). > > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- >

Re: [PATCH v4 17/21] ARM: dts: imx6ull: improve can templates

2019-08-15 Thread Oleksandr Suvorov
does not enable flexcan functionality, but rather > eases the effort needed to do so. > > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: > - Move can nodes to module deviceteree include imx

Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules

2019-08-15 Thread Oleksandr Suvorov
On Wed, Aug 14, 2019 at 1:54 PM Philippe Schenker wrote: > > Add the stmpe-adc DT node as found on Toradex T30 modules > > Signed-off-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > > --- > > arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++-

[PATCH v6 4/6] ASoC: sgtl5000: add ADC mute control

2019-07-19 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes

[PATCH v6 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-07-19 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v6: None Changes in v5: None Changes in v4: None

[PATCH v6 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-07-19 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v6: None Changes i

[PATCH v6 6/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-07-19 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically [1]. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

[PATCH v6 1/6] ASoC: Define a set of DAPM pre/post-up events

2019-07-19 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Cc: sta...@vger.kernel.org Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v6: None Changes in v5

[PATCH v6 0/6] VAG power control improvement for sgtl5000 codec

2019-07-19 Thread Oleksandr Suvorov
-line comment format Changes in v2: - Fix patch formatting Oleksandr Suvorov (6): ASoC: Define a set of DAPM pre/post-up events ASoC: sgtl5000: Improve VAG power and mute control ASoC: sgtl5000: Fix definition of VAG Ramp Control ASoC: sgtl5000: add ADC mute control ASoC: sgtl5000: Fix

[PATCH v6 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-19 Thread Oleksandr Suvorov
any pops/clicks, the outputs should be muted during input/output routing changes. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Cc: sta...@vger.kernel.org Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support") Signed-off-by: Oleksandr Suvorov Reviewed-by: Marce

Re: [PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-19 Thread Oleksandr Suvorov
On Thu, 18 Jul 2019 at 21:49, Cezary Rojewski wrote: > > On 2019-07-18 20:42, Cezary Rojewski wrote: > > On 2019-07-18 11:02, Oleksandr Suvorov wrote: > >> +enum { > >> +HP_POWER_EVENT, > >> +DAC_POWER_EVENT, > >>

[PATCH v5 4/6] ASoC: sgtl5000: add ADC mute control

2019-07-18 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Fix patch

[PATCH v5 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-07-18 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: None Changes i

[PATCH v5 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-07-18 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: None Changes in v4: None Changes in v3: None

[PATCH v5 1/6] ASoC: Define a set of DAPM pre/post-up events

2019-07-18 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Cc: sta...@vger.kernel.org Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: - Add explicit stable

[PATCH v5 6/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-07-18 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically [1]. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

[PATCH v5 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-18 Thread Oleksandr Suvorov
any pops/clicks, the outputs should be muted during input/output routing changes. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Cc: sta...@vger.kernel.org Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support") Signed-off-by: Oleksandr Suvorov Reviewed-by: Marce

[PATCH v5 0/6] VAG power control improvement for sgtl5000 codec

2019-07-18 Thread Oleksandr Suvorov
to commit message - Add the reference to NXP SGTL5000 data sheet to commit message - Fix multi-line comment format Changes in v2: - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting Oleksandr Suvorov (6): ASoC: Define

Re: [PATCH v3 0/6] VAG power control improvement for sgtl5000 codec

2019-07-17 Thread Oleksandr Suvorov
Hello Fabio, Thank you for your feedback! I've prepared and sent a fixed patchset v4. -- R Engineer Oleksandr Suvorov Toradex AG From: Fabio Estevam Sent: Monday, July 15, 2019 10:06:57 PM To: Oleksandr Suvorov Cc: linux-kernel@vger.kernel.org; alsa

[PATCH v4 4/6] ASoC: sgtl5000: add ADC mute control

2019-07-17 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v4: None Changes in v3: None Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c | 1

[PATCH v4 6/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-07-17 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically [1]. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v4: None Changes in v3

[PATCH v4 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-07-17 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v4: None Changes in v3: None Changes in v2: -

[PATCH v4 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-07-17 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v4: None Changes in v3: None Changes in v2: - Fix patch formatting sound

[PATCH v4 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-17 Thread Oleksandr Suvorov
-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support") --- Changes in v4: - Code optimization, simplify function signature (thanks to Cezary Rojewski for an idea) - CC the patch to kernel-st

[PATCH v4 0/6] VAG power control improvement for sgtl5000 codec

2019-07-17 Thread Oleksandr Suvorov
comment format Changes in v2: - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting Oleksandr Suvorov (6): ASoC: Define a set of DAPM pre/post-up events ASoC: sgtl5000: Improve VAG power and mute control ASoC

[PATCH v4 1/6] ASoC: Define a set of DAPM pre/post-up events

2019-07-17 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v4: - CC the patch to kernel-stable Changes in v3: None Changes in v2: - Fix patch

Re: [PATCH v3 6/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-17 Thread Oleksandr Suvorov
Thank you, Cezary! This is a good idea, I'll rework my patch accordingly. R Engineer Oleksandr Suvorov Toradex AG From: Cezary Rojewski Sent: Sunday, July 14, 2019 8:17:43 PM To: Oleksandr Suvorov Cc: Fabio Estevam; linux-kernel@vger.kernel.org; alsa

Re: [PATCH] ASoC: audio-graph-card: fix type mismatch warning

2019-07-13 Thread Oleksandr Suvorov
ible-pointer-types-discards-qualifiers] > > Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in > graph_get_dai_id()") > Signed-off-by: Arnd Bergmann Reviewed-by: Oleksandr Suvorov > --- > sound/soc/generic/audio-graph-card.c | 2 +- > 1 file chan

[PATCH v3 6/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-12 Thread Oleksandr Suvorov
-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler --- Changes in v3: - Add the reference to NXP SGTL5000 data sheet to commit message Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c | 227 +++- 1 file changed, 195

[PATCH v3 5/6] ASoC: Define a set of DAPM pre/post-up events

2019-07-12 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v3: None Changes in v2: - Fix patch formatting include/sound/soc-dapm.h | 2 ++ 1

[PATCH v3 4/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-07-12 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically [1]. [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v3: - Add the reference

[PATCH v3 3/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-07-12 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v3: None Changes in v2: - Fix patch formatti

[PATCH v3 2/6] ASoC: sgtl5000: add ADC mute control

2019-07-12 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v3: None Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c | 1 + 1 file changed, 1

[PATCH v3 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-07-12 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- Changes in v3: None Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c

[PATCH v3 0/6] VAG power control improvement for sgtl5000 codec

2019-07-12 Thread Oleksandr Suvorov
data sheet to commit message - Fix multi-line comment format - Add the reference to NXP SGTL5000 data sheet to commit message Changes in v2: - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting - Fix patch formatting Oleksandr Suvorov (6

[PATCH v2 6/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-06-25 Thread Oleksandr Suvorov
OFF to avoid pop. - delay after VAG power ON if the initiative consumer is Line-In, this prevents pop during line-in muxing. Also, according to the manual, to avoid any pops/clicks, the outputs should be muted during input/output routing changes. Signed-off-by: Oleksandr Suvorov --- sound

[PATCH v2 2/6] ASoC: sgtl5000: add ADC mute control

2019-06-25 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 5e49523ee0b67..bb58c997c6914

[PATCH v2 3/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-06-25 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/

[PATCH v2 4/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-06-25 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc

[PATCH v2 5/6] ASoC: Define a set of DAPM pre/post-up events

2019-06-25 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Signed-off-by: Oleksandr Suvorov --- include/sound/soc-dapm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index c00a0b8ade086

[PATCH v2 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-06-25 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/sgtl5000.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc

[PATCH v2 0/6] VAG power control improvement for sgtl5000 codec

2019-06-25 Thread Oleksandr Suvorov
; - Connect headphone to HP jack; - Run following commands: $ amixer set 'Headphone' 80% $ amixer set 'Headphone Mux' LINE_IN Also this series includes fixes of non-important bugs in sgtl5000 codec driver. Fix patch formatting in patchset v2. Oleksandr Suvorov (6): ASoC: sgtl5000: Fix definition of VAG

Re: [PATCH v1 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-06-19 Thread Oleksandr Suvorov
> > From: Marcel Ziswiler > Sent: Thursday, June 13, 2019 12:05 > To: feste...@gmail.com; Oleksandr Suvorov > Cc: Igor Opaniuk; linux-kernel@vger.kernel.org; alsa-de...@alsa-project.org > Subject: Re: [PATCH v1 1/6] ASoC: sgtl5000: Fix

[PATCH v1 2/6] ASoC: sgtl5000: add ADC mute control

2019-05-21 Thread Oleksandr Suvorov
This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git sound/soc/codecs/sgtl5000.c sound/soc/codecs/sgtl5000.c index 5e49523ee0b6..bb58c997c691

[PATCH v1 6/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-05-21 Thread Oleksandr Suvorov
OFF to avoid pop. - delay after VAG power ON if the initiative consumer is Line-In, this prevents pop during line-in muxing. Also, according to the manual, to avoid any pops/clicks, the outputs should be muted during input/output routing changes. Signed-off-by: Oleksandr Suvorov --- sound

[PATCH v1 3/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-05-21 Thread Oleksandr Suvorov
To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git sound/

[PATCH v1 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-05-21 Thread Oleksandr Suvorov
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/sgtl5000.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git sound/soc

[PATCH v1 5/6] ASoC: Define a set of DAPM pre/post-up events

2019-05-21 Thread Oleksandr Suvorov
Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to reduce coming code size and make it more readable. Signed-off-by: Oleksandr Suvorov --- include/sound/soc-dapm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git include/sound/soc-dapm.h include/sound/soc-dapm.h index c00a0b8ade08

[PATCH v1 4/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-05-21 Thread Oleksandr Suvorov
If VDDA != VDDIO and any of them is greater than 3.1V, charge pump source can be assigned automatically. Signed-off-by: Oleksandr Suvorov --- sound/soc/codecs/sgtl5000.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git sound/soc/codecs/sgtl5000.c sound/soc

[PATCH v1 0/6] VAG power control improvement for sgtl5000 codec

2019-05-21 Thread Oleksandr Suvorov
; - Connect headphone to HP jack; - Run following commands: $ amixer set 'Headphone' 80% $ amixer set 'Headphone Mux' LINE_IN Also this series includes fixes of non-important bugs in sgtl5000 codec driver. Oleksandr Suvorov (6): ASoC: sgtl5000: Fix definition of VAG Ramp Control ASoC: sgtl5000: add