Re: Splicing to/from a tty

2021-01-20 Thread Oliver Giles
On Wed Jan 20, 2021 at 5:44 PM NZDT, Linus Torvalds wrote: > > But in the meantime, here's two more patches to try on top of the > previous four. They shouldn't matter, other than making the non-icanon > throughput a lot better. But the more coverage they get, the happier > I'll be. > I tried

Re: Splicing to/from a tty

2021-01-19 Thread Oliver Giles
On Wed Jan 20, 2021 at 9:24 AM NZDT, Linus Torvalds wrote: > Anyway, anybody willing to test these tty/pipe patches on the loads > that failed? Oliver? Writing this from a kernel with those patches in; happily splice()ing to and from a pty.

Re: Splicing to/from a tty

2021-01-19 Thread Oliver Giles
On Wed Jan 20, 2021 at 5:56 AM NZDT, Robert Karszniewicz wrote: > > I have bisected this issue down to this commit: > 4d03e3cc5982 ("fs: don't allow kernel reads and writes without iter > ops") > > Another case I've also noticed is writing to a serial connection: > kernel write not supported for

Re: Splicing to/from a tty

2021-01-16 Thread Oliver Giles
On Sun Jan 17, 2021 at 5:46 AM NZDT, Johannes Berg wrote: > On Sat, 2021-01-16 at 20:35 +1300, Oliver Giles wrote: > > Commit 36e2c7421f02 (fs: don't allow splice read/write without > > explicit ops) broke my userspace application which talks to an SSL VPN > > by splice(

Splicing to/from a tty

2021-01-16 Thread Oliver Giles
Commit 36e2c7421f02 (fs: don't allow splice read/write without explicit ops) broke my userspace application which talks to an SSL VPN by splice()ing between "openssl s_client" and "pppd". The latter operates over a pty, and since that commit there is no fallback for splice()ing between a pipe